[jira] [Resolved] (KAFKA-14495) Improve the RemoteIndexCacheTest

[ https://issues.apache.org/jira/browse/KAFKA-14495?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen resolved KAFKA-14495. --- Fix Version/s: 3.5.0 Resolution: Fixed > Improve the RemoteIndexCacheTest >

[jira] [Resolved] (KAFKA-14128) Kafka Streams terminates on topic check

[ https://issues.apache.org/jira/browse/KAFKA-14128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax resolved KAFKA-14128. - Fix Version/s: 3.5.0 3.4.1 Resolution: Fixed > Kafka Streams

[GitHub] [kafka] mjsax commented on pull request #13161: Kafka 14128

mjsax commented on PR #13161: URL: https://github.com/apache/kafka/pull/13161#issuecomment-1441323418 Thanks for the PR. Merged to `trunk` and cherry-picked to `3.4` branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [kafka] showuon commented on a diff in pull request #13279: KAFKA-14295 FetchMessageConversionsPerSec meter not recorded

showuon commented on code in PR #13279: URL: https://github.com/apache/kafka/pull/13279#discussion_r1115304004 ## core/src/test/scala/unit/kafka/server/FetchRequestDownConversionConfigTest.scala: ## @@ -221,6 +222,8 @@ class FetchRequestDownConversionConfigTest extends

[GitHub] [kafka] mjsax merged pull request #13161: Kafka 14128

mjsax merged PR #13161: URL: https://github.com/apache/kafka/pull/13161 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] chia7712 commented on pull request #13290: MINOR: stabilize LeaderElectionTest#testLeaderElectionAndEpoch

chia7712 commented on PR #13290: URL: https://github.com/apache/kafka/pull/13290#issuecomment-1441274910 > But why does this PR have no CI test running? maybe jenkins is on vacation. merge trunk to trigger QA again -- This is an automated message from the Apache Git Service. To

[GitHub] [kafka] dejan2609 commented on pull request #13205: KAFKA-14680: gradle version upgrade 7 -->> 8

dejan2609 commented on PR #13205: URL: https://github.com/apache/kafka/pull/13205#issuecomment-1441268058 @ijuma changes are integrated (please remember that https://github.com/apache/kafka/pull/13263 needs to be merged prior to this one). -- This is an automated message from the Apache

[GitHub] [kafka] dajac commented on pull request #13231: KAFKA-14402: Update AddPartitionsToTxn protocol to batch and handle verifyOnly requests

dajac commented on PR #13231: URL: https://github.com/apache/kafka/pull/13231#issuecomment-1441262764 > Took a quick look at the unstable api change. Looks like some integration tests built specifically for v4 fail with `org.apache.kafka.common.errors.InvalidRequestException: Received

[GitHub] [kafka] vamossagar12 commented on pull request #13095: KAFKA-14580: Moving EndToEndLatency from core to tools module

vamossagar12 commented on PR #13095: URL: https://github.com/apache/kafka/pull/13095#issuecomment-1441214746 Thanks Michael. I added a happy path testcase. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[jira] [Commented] (KAFKA-14739) Kafka consumer reading messages out of order after a rebalance

[ https://issues.apache.org/jira/browse/KAFKA-14739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17692452#comment-17692452 ] Luke Chen commented on KAFKA-14739: --- [~colinshaw] , Have you tried to run with the latest version of

[GitHub] [kafka] philipnee closed pull request #13289: [TESTING] (DNR)testing failing test from another PR

philipnee closed pull request #13289: [TESTING] (DNR)testing failing test from another PR URL: https://github.com/apache/kafka/pull/13289 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] showuon merged pull request #13281: [MINOR] Adjust logging with ZK log format

showuon merged PR #13281: URL: https://github.com/apache/kafka/pull/13281 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] showuon merged pull request #13261: MINOR: after reading BYTES type it's possible to access data beyond its size

showuon merged PR #13261: URL: https://github.com/apache/kafka/pull/13261 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] showuon commented on pull request #13261: MINOR: after reading BYTES type it's possible to access data beyond its size

showuon commented on PR #13261: URL: https://github.com/apache/kafka/pull/13261#issuecomment-1441133511 Failed tests are unrelated ``` Build / JDK 11 and Scala 2.13 /

[GitHub] [kafka] bachmanity1 commented on pull request #13261: MINOR: after reading BYTES type it's possible to access data beyond its size

bachmanity1 commented on PR #13261: URL: https://github.com/apache/kafka/pull/13261#issuecomment-1441126265 The CI test failures look unrelated to this PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[jira] [Assigned] (KAFKA-5863) Potential null dereference in DistributedHerder#reconfigureConnector()

[ https://issues.apache.org/jira/browse/KAFKA-5863?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Harris reassigned KAFKA-5863: -- Assignee: Greg Harris > Potential null dereference in

[GitHub] [kafka] gharris1727 opened a new pull request, #13294: KAFKA-5863: Avoid NPE when calls expecting no-content receive content.

gharris1727 opened a new pull request, #13294: URL: https://github.com/apache/kafka/pull/13294 The RestClient accepts a TypeReference argument defining what kind of response to expect from the HTTP request. If these request is expected to result in a 204 no-content, they would

[GitHub] [kafka] RivenSun2 commented on pull request #13270: KAFKA-14729: The kafakConsumer pollForFetches(timer) method takes up a lot of cpu due to the abnormal exit of the heartbeat thread

RivenSun2 commented on PR #13270: URL: https://github.com/apache/kafka/pull/13270#issuecomment-1441096550 Hi @guozhangwang could you give any suggestions? Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [kafka] jolshan commented on pull request #13231: KAFKA-14402: Update AddPartitionsToTxn protocol to batch and handle verifyOnly requests

jolshan commented on PR #13231: URL: https://github.com/apache/kafka/pull/13231#issuecomment-1441095454 Took a quick look at the unstable api change. Looks like some integration tests built specifically for v4 fail with `org.apache.kafka.common.errors.InvalidRequestException: Received

[GitHub] [kafka] kirktrue opened a new pull request, #13293: KAFKA-14365: Extract common logic from Fetcher into FetcherUtils

kirktrue opened a new pull request, #13293: URL: https://github.com/apache/kafka/pull/13293 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of

[GitHub] [kafka] ijuma commented on pull request #13205: KAFKA-14680: gradle version upgrade 7 -->> 8

ijuma commented on PR #13205: URL: https://github.com/apache/kafka/pull/13205#issuecomment-1441082213 @dejan2609 Good catch. I fixed it in the same branch. And tested with Scala 2.12 and 2.13. -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [kafka] jolshan commented on pull request #13231: KAFKA-14402: Update AddPartitionsToTxn protocol to batch and handle verifyOnly requests

jolshan commented on PR #13231: URL: https://github.com/apache/kafka/pull/13231#issuecomment-1441071519 I've added the changes to the API spec -- verify only is now a transaction level config -- top level error is added to the response I've added builders to the request and

[jira] [Resolved] (KAFKA-5827) Allow configuring Kafka sink connectors to start processing records from the end of topics

[ https://issues.apache.org/jira/browse/KAFKA-5827?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Harris resolved KAFKA-5827. Resolution: Duplicate > Allow configuring Kafka sink connectors to start processing records from

[jira] [Commented] (KAFKA-5827) Allow configuring Kafka sink connectors to start processing records from the end of topics

[ https://issues.apache.org/jira/browse/KAFKA-5827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17692413#comment-17692413 ] Greg Harris commented on KAFKA-5827: This is controllable via the Client Override feature KIP-458

[GitHub] [kafka] vcrfxia opened a new pull request, #13292: KAFKA-14491: [14/N] Set changelog topic configs for versioned stores

vcrfxia opened a new pull request, #13292: URL: https://github.com/apache/kafka/pull/13292 (This PR is stacked on https://github.com/apache/kafka/pull/13274. Only the last commit needs to be reviewed separately.) This PR sets the correct topic configs for changelog topics for

[GitHub] [kafka] kowshik commented on pull request #13268: MINOR: Introduce OffsetAndEpoch in LeaderEndpoint interface return values

kowshik commented on PR #13268: URL: https://github.com/apache/kafka/pull/13268#issuecomment-1440982486 @junrao Thanks for the review. I have rebased the PR and brought in the latest commits from AK trunk. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kafka] philipnee commented on a diff in pull request #13265: Prototype consumer stubs

philipnee commented on code in PR #13265: URL: https://github.com/apache/kafka/pull/13265#discussion_r1115068319 ## clients/src/main/java/org/apache/kafka/clients/consumer/StubbedAsyncKafkaConsumer.java: ## @@ -0,0 +1,548 @@ +/* + * Licensed to the Apache Software Foundation

[jira] [Resolved] (KAFKA-4006) Kafka connect fails sometime with InvalidTopicException in distributed mode

[ https://issues.apache.org/jira/browse/KAFKA-4006?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Harris resolved KAFKA-4006. Fix Version/s: 0.11.0.0 Resolution: Fixed > Kafka connect fails sometime with

[GitHub] [kafka] philipnee commented on a diff in pull request #13265: Prototype consumer stubs

philipnee commented on code in PR #13265: URL: https://github.com/apache/kafka/pull/13265#discussion_r1115056524 ## clients/src/main/java/org/apache/kafka/clients/consumer/StubbedAsyncKafkaConsumer.java: ## @@ -0,0 +1,548 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [kafka] guozhangwang commented on pull request #13265: Prototype consumer stubs

guozhangwang commented on PR #13265: URL: https://github.com/apache/kafka/pull/13265#issuecomment-1440933102 Thanks @philipnee , I left a comment to just give my 2c regarding your question 1) above. For your question 2), I think we should prefer to be consistent with the current

[GitHub] [kafka] guozhangwang commented on a diff in pull request #13265: Prototype consumer stubs

guozhangwang commented on code in PR #13265: URL: https://github.com/apache/kafka/pull/13265#discussion_r1115047665 ## clients/src/main/java/org/apache/kafka/clients/consumer/StubbedAsyncKafkaConsumer.java: ## @@ -0,0 +1,548 @@ +/* + * Licensed to the Apache Software Foundation

[jira] [Comment Edited] (KAFKA-14722) Make BooleanSerde public

[ https://issues.apache.org/jira/browse/KAFKA-14722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17692398#comment-17692398 ] Spacrocket edited comment on KAFKA-14722 at 2/22/23 10:32 PM: -- Thanks

[jira] [Commented] (KAFKA-14722) Make BooleanSerde public

[ https://issues.apache.org/jira/browse/KAFKA-14722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17692398#comment-17692398 ] Spacrocket commented on KAFKA-14722: Thanks Matthias J. Sax for an advice; I've added the proposal

[GitHub] [kafka] guozhangwang commented on a diff in pull request #13265: Prototype consumer stubs

guozhangwang commented on code in PR #13265: URL: https://github.com/apache/kafka/pull/13265#discussion_r1115037535 ## clients/src/main/java/org/apache/kafka/clients/consumer/StubbedAsyncKafkaConsumer.java: ## @@ -0,0 +1,548 @@ +/* + * Licensed to the Apache Software Foundation

[jira] [Assigned] (KAFKA-9228) Reconfigured converters and clients may not be propagated to connector tasks

[ https://issues.apache.org/jira/browse/KAFKA-9228?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Harris reassigned KAFKA-9228: -- Assignee: Greg Harris > Reconfigured converters and clients may not be propagated to

[GitHub] [kafka] dejan2609 commented on pull request #13205: KAFKA-14680: gradle version upgrade 7 -->> 8

dejan2609 commented on PR #13205: URL: https://github.com/apache/kafka/pull/13205#issuecomment-1440891478 > @dejan2609 I added a few cleanups here: [ijuma@9c6ae57](https://github.com/ijuma/kafka/commit/9c6ae575276e673f39d188d42a332f9f0b07d2d0) > > If you agree with them, please

[GitHub] [kafka] vcrfxia commented on a diff in pull request #13252: KAFKA-14491: [11/N] Add metered wrapper for versioned stores

vcrfxia commented on code in PR #13252: URL: https://github.com/apache/kafka/pull/13252#discussion_r1114772380 ## streams/src/main/java/org/apache/kafka/streams/state/internals/MeteredVersionedKeyValueStore.java: ## @@ -0,0 +1,227 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] junrao merged pull request #13272: MINOR: Add missing unit tests for {Local|Remote}LeaderEndpoint classes

junrao merged PR #13272: URL: https://github.com/apache/kafka/pull/13272 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] dejan2609 commented on pull request #13205: KAFKA-14680: gradle version upgrade 7 -->> 8

dejan2609 commented on PR #13205: URL: https://github.com/apache/kafka/pull/13205#issuecomment-1440804226 Got it @ijuma I will also add jacoco minor version bump: 0.8.7 -->> 0.8.8 in order to use same version as in Gradle 8.0.1:

[GitHub] [kafka] philipnee commented on a diff in pull request #13265: Prototype consumer stubs

philipnee commented on code in PR #13265: URL: https://github.com/apache/kafka/pull/13265#discussion_r1114928370 ## clients/src/main/java/org/apache/kafka/clients/consumer/StubbedAsyncKafkaConsumer.java: ## @@ -0,0 +1,548 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [kafka] philipnee commented on pull request #13265: Prototype consumer stubs

philipnee commented on PR #13265: URL: https://github.com/apache/kafka/pull/13265#issuecomment-1440786040 I feel the real challenge here is to determine the timing to synchronize the background and client state. I feel we should do that deterministically otherwise, it is hard to provide a

[GitHub] [kafka] philipnee commented on a diff in pull request #13265: Prototype consumer stubs

philipnee commented on code in PR #13265: URL: https://github.com/apache/kafka/pull/13265#discussion_r1114930390 ## clients/src/main/java/org/apache/kafka/clients/consumer/StubbedAsyncKafkaConsumer.java: ## @@ -0,0 +1,548 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [kafka] ijuma commented on pull request #13205: KAFKA-14680: gradle version upgrade 7 -->> 8

ijuma commented on PR #13205: URL: https://github.com/apache/kafka/pull/13205#issuecomment-1440767080 @dejan2609 I added a few cleanups here: https://github.com/ijuma/kafka/commit/9c6ae575276e673f39d188d42a332f9f0b07d2d0 If you agree with them, please integrate into your PR. --

[GitHub] [kafka] philipnee commented on a diff in pull request #13265: Prototype consumer stubs

philipnee commented on code in PR #13265: URL: https://github.com/apache/kafka/pull/13265#discussion_r1114928370 ## clients/src/main/java/org/apache/kafka/clients/consumer/StubbedAsyncKafkaConsumer.java: ## @@ -0,0 +1,548 @@ +/* + * Licensed to the Apache Software Foundation

[jira] [Updated] (KAFKA-14742) Flaky ExactlyOnceSourceIntegrationTest.testConnectorBoundary OOMs

[ https://issues.apache.org/jira/browse/KAFKA-14742?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Harris updated KAFKA-14742: Labels: flaky-test (was: ) > Flaky ExactlyOnceSourceIntegrationTest.testConnectorBoundary OOMs >

[GitHub] [kafka] gharris1727 opened a new pull request, #13291: KAFKA-14742: Throttle connectors in ExactlyOnceSourceIntegrationTest to fix flakey OOMEs

gharris1727 opened a new pull request, #13291: URL: https://github.com/apache/kafka/pull/13291 On my local machine, testIntervalBoundary is asserting on nearly 2.5 million records, when it appears that the test is written to need only 100-1000 records to perform assertions. This causes

[jira] [Created] (KAFKA-14742) Flaky ExactlyOnceSourceIntegrationTest.testConnectorBoundary OOMs

Greg Harris created KAFKA-14742: --- Summary: Flaky ExactlyOnceSourceIntegrationTest.testConnectorBoundary OOMs Key: KAFKA-14742 URL: https://issues.apache.org/jira/browse/KAFKA-14742 Project: Kafka

[GitHub] [kafka] chia7712 opened a new pull request, #13290: MINOR: stabilize LeaderElectionTest#testLeaderElectionAndEpoch

chia7712 opened a new pull request, #13290: URL: https://github.com/apache/kafka/pull/13290 the leader is changed from -1 to 1. The test get failed if it observes the -1 first. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ]

[GitHub] [kafka] philipnee commented on a diff in pull request #13265: Prototype consumer stubs

philipnee commented on code in PR #13265: URL: https://github.com/apache/kafka/pull/13265#discussion_r1114851962 ## clients/src/main/java/org/apache/kafka/clients/consumer/StubbedAsyncKafkaConsumer.java: ## @@ -0,0 +1,548 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [kafka] vcrfxia commented on a diff in pull request #13252: KAFKA-14491: [11/N] Add metered wrapper for versioned stores

vcrfxia commented on code in PR #13252: URL: https://github.com/apache/kafka/pull/13252#discussion_r1114835088 ## streams/src/main/java/org/apache/kafka/streams/state/internals/MeteredVersionedKeyValueStore.java: ## @@ -0,0 +1,227 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] jolshan merged pull request #12957: MINOR: Fix flaky testClientDisconnectionUpdatesRequestMetrics() (#11987)

jolshan merged PR #12957: URL: https://github.com/apache/kafka/pull/12957 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] vcrfxia commented on a diff in pull request #13252: KAFKA-14491: [11/N] Add metered wrapper for versioned stores

vcrfxia commented on code in PR #13252: URL: https://github.com/apache/kafka/pull/13252#discussion_r1114799670 ## streams/src/main/java/org/apache/kafka/streams/state/internals/MeteredVersionedKeyValueStore.java: ## @@ -0,0 +1,227 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] guozhangwang commented on a diff in pull request #13265: Prototype consumer stubs

guozhangwang commented on code in PR #13265: URL: https://github.com/apache/kafka/pull/13265#discussion_r1114721314 ## clients/src/main/java/org/apache/kafka/clients/consumer/StubbedAsyncKafkaConsumer.java: ## @@ -0,0 +1,548 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [kafka] vcrfxia commented on a diff in pull request #13252: KAFKA-14491: [11/N] Add metered wrapper for versioned stores

vcrfxia commented on code in PR #13252: URL: https://github.com/apache/kafka/pull/13252#discussion_r1114772380 ## streams/src/main/java/org/apache/kafka/streams/state/internals/MeteredVersionedKeyValueStore.java: ## @@ -0,0 +1,227 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] philipnee opened a new pull request, #13289: [TESTING] testing failing test from another PR

philipnee opened a new pull request, #13289: URL: https://github.com/apache/kafka/pull/13289 Don't review this PR! I'm just testing why a bunch of irrelevant tests are failing on the other branch! -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [kafka] vcrfxia commented on a diff in pull request #13252: KAFKA-14491: [11/N] Add metered wrapper for versioned stores

vcrfxia commented on code in PR #13252: URL: https://github.com/apache/kafka/pull/13252#discussion_r1114727896 ## streams/src/main/java/org/apache/kafka/streams/state/internals/MeteredVersionedKeyValueStore.java: ## @@ -0,0 +1,227 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] philipnee commented on pull request #13190: KAFKA-12639: exit upon expired timer to prevent tight looping

philipnee commented on PR #13190: URL: https://github.com/apache/kafka/pull/13190#issuecomment-1440514286 Hmm, strangely, this branch seems to trigger a bunch of initializing error failures. And I can't seem to reproduce them locally... -- This is an automated message from the Apache Git

[jira] [Commented] (KAFKA-14714) Move/Rewrite RollParams, LogAppendInfo, and LeaderHwChange to storage module.

[ https://issues.apache.org/jira/browse/KAFKA-14714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17692294#comment-17692294 ] Satish Duggana commented on KAFKA-14714: https://github.com/apache/kafka/pull/13255 >

[GitHub] [kafka] satishd merged pull request #13255: KAFKA 14714: Move/Rewrite RollParams, LogAppendInfo, and LeaderHwChange to storage module.

satishd merged PR #13255: URL: https://github.com/apache/kafka/pull/13255 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] guozhangwang commented on pull request #13190: KAFKA-12639: exit upon expired timer to prevent tight looping

guozhangwang commented on PR #13190: URL: https://github.com/apache/kafka/pull/13190#issuecomment-1440489302 Yeah I think it's okay to make the rule consistent, i.e. to honor the timeout even under those four exceptions: if the timer has elapsed, then we should well return from the loop in

[GitHub] [kafka] rondagostino commented on a diff in pull request #13280: KAFKA-14735: Improve KRaft metadata image change performance at high …

rondagostino commented on code in PR #13280: URL: https://github.com/apache/kafka/pull/13280#discussion_r1114692109 ## metadata/src/main/java/org/apache/kafka/image/TopicsImage.java: ## @@ -38,15 +40,21 @@ */ public final class TopicsImage { public static final

[GitHub] [kafka] rondagostino commented on a diff in pull request #13280: KAFKA-14735: Improve KRaft metadata image change performance at high …

rondagostino commented on code in PR #13280: URL: https://github.com/apache/kafka/pull/13280#discussion_r1114679640 ## metadata/src/main/java/org/apache/kafka/image/TopicsImage.java: ## @@ -76,8 +84,8 @@ public TopicImage getTopic(String name) { } public void

[GitHub] [kafka] rondagostino commented on a diff in pull request #13280: KAFKA-14735: Improve KRaft metadata image change performance at high …

rondagostino commented on code in PR #13280: URL: https://github.com/apache/kafka/pull/13280#discussion_r1114673066 ## metadata/src/main/java/org/apache/kafka/image/TopicsDelta.java: ## @@ -126,29 +127,27 @@ public void handleMetadataVersionChange(MetadataVersion newVersion) {

[GitHub] [kafka] guozhangwang commented on a diff in pull request #13228: KAFKA-10199: Add task updater metrics, part 1

guozhangwang commented on code in PR #13228: URL: https://github.com/apache/kafka/pull/13228#discussion_r1114660400 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/DefaultStateUpdater.java: ## @@ -151,9 +202,18 @@ private void resumeTasks() {

[GitHub] [kafka] clolov commented on pull request #13212: MINOR: Remove accidental unnecessary code; fix comment references

clolov commented on PR #13212: URL: https://github.com/apache/kafka/pull/13212#issuecomment-1440432643 This has been rebased on the latest trunk, test have been ran locally and I would be very grateful for a review when you get the time @mimaison -- This is an automated message from the

[GitHub] [kafka] chia7712 opened a new pull request, #13288: MINOR: fix rerun-tests for unit test

chia7712 opened a new pull request, #13288: URL: https://github.com/apache/kafka/pull/13288 related to #11926. we don't process `rerun-tests` for unit test. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage

[GitHub] [kafka] guozhangwang commented on a diff in pull request #13228: KAFKA-10199: Add task updater metrics, part 1

guozhangwang commented on code in PR #13228: URL: https://github.com/apache/kafka/pull/13228#discussion_r1114660189 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/DefaultStateUpdater.java: ## @@ -598,6 +685,12 @@ public Set getUpdatingStandbyTasks() {

[GitHub] [kafka] chia7712 commented on a diff in pull request #11926: KAFKA-13714: Fix cache flush position

chia7712 commented on code in PR #11926: URL: https://github.com/apache/kafka/pull/11926#discussion_r1114653978 ## build.gradle: ## @@ -435,6 +435,12 @@ subprojects { maxRetries = userMaxTestRetries maxFailures = userMaxTestRetryFailures } + +// Allows

[GitHub] [kafka] satishd commented on pull request #13255: KAFKA 14714: Move/Rewrite RollParams, LogAppendInfo, and LeaderHwChange to storage module.

satishd commented on PR #13255: URL: https://github.com/apache/kafka/pull/13255#issuecomment-1440419578 A couple of test failures are not related to this change, will merge the changes to trunk. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [kafka] mimaison commented on pull request #13259: MINOR: Simplify JUnit assertions in src; remove accidental unnecessary code in src

mimaison commented on PR #13259: URL: https://github.com/apache/kafka/pull/13259#issuecomment-1440413003 I checked the clients and connect changes and they look good. I think some of the streams changes could be debatable (not sure if they want to keep some of the comments) so I'll let

[jira] [Assigned] (KAFKA-14740) Missing source tag on MirrorSource metrics

[ https://issues.apache.org/jira/browse/KAFKA-14740?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mickael Maison reassigned KAFKA-14740: -- Assignee: Mickael Maison > Missing source tag on MirrorSource metrics >

[jira] [Created] (KAFKA-14741) Add description field to connector configs

Mickael Maison created KAFKA-14741: -- Summary: Add description field to connector configs Key: KAFKA-14741 URL: https://issues.apache.org/jira/browse/KAFKA-14741 Project: Kafka Issue Type:

[GitHub] [kafka] Schm1tz1 commented on a diff in pull request #12992: KIP-887: Add ConfigProvider to make use of environment variables

Schm1tz1 commented on code in PR #12992: URL: https://github.com/apache/kafka/pull/12992#discussion_r1114586256 ## clients/src/main/java/org/apache/kafka/common/config/provider/EnvVarConfigProvider.java: ## @@ -0,0 +1,94 @@ +/* + * Licensed to the Apache Software Foundation

[jira] [Commented] (KAFKA-14740) Missing source tag on MirrorSource metrics

[ https://issues.apache.org/jira/browse/KAFKA-14740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17692262#comment-17692262 ] Mickael Maison commented on KAFKA-14740: Thanks for the quick reply. I think it would make

[GitHub] [kafka] clolov commented on pull request #13259: MINOR: Simplify JUnit assertions in src; remove accidental unnecessary code in src

clolov commented on PR #13259: URL: https://github.com/apache/kafka/pull/13259#issuecomment-1440295776 Hello @mimaison, would you have the time to review this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Commented] (KAFKA-14740) Missing source tag on MirrorSource metrics

[ https://issues.apache.org/jira/browse/KAFKA-14740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17692252#comment-17692252 ] Ryanne Dolan commented on KAFKA-14740: -- [~mimaison] the topic name usually includes the source

[jira] [Commented] (KAFKA-14740) Missing source tag on MirrorSource metrics

[ https://issues.apache.org/jira/browse/KAFKA-14740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17692248#comment-17692248 ] Mickael Maison commented on KAFKA-14740: [~ryannedolan] Do you remember if there was a reason

[jira] [Created] (KAFKA-14740) Missing source tag on MirrorSource metrics

Mickael Maison created KAFKA-14740: -- Summary: Missing source tag on MirrorSource metrics Key: KAFKA-14740 URL: https://issues.apache.org/jira/browse/KAFKA-14740 Project: Kafka Issue Type:

[GitHub] [kafka] rondagostino commented on pull request #13280: KAFKA-14735: Improve KRaft metadata image change performance at high …

rondagostino commented on PR #13280: URL: https://github.com/apache/kafka/pull/13280#issuecomment-1440262838 @showuon Thanks for the review. Yes, I noticed the lack of Java 8 support as well. I tried compiling the latest version of Paguro with Java 8 and it did not work (e.g. `[ERROR]

[jira] [Commented] (KAFKA-14738) Topic disappears from kafka_topic.sh --list after modifying it with kafka_acl.sh

[ https://issues.apache.org/jira/browse/KAFKA-14738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17692235#comment-17692235 ] Gabriel Lukacs commented on KAFKA-14738: ok, thanks for clarification, my fault, i was not

[GitHub] [kafka] viktorsomogyi commented on a diff in pull request #12992: KIP-887: Add ConfigProvider to make use of environment variables

viktorsomogyi commented on code in PR #12992: URL: https://github.com/apache/kafka/pull/12992#discussion_r1114431334 ## clients/src/main/java/org/apache/kafka/common/config/provider/EnvVarConfigProvider.java: ## @@ -0,0 +1,94 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] lucasbru commented on a diff in pull request #13228: KAFKA-10199: Add task updater metrics, part 1

lucasbru commented on code in PR #13228: URL: https://github.com/apache/kafka/pull/13228#discussion_r1114354933 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/DefaultStateUpdater.java: ## @@ -151,9 +202,18 @@ private void resumeTasks() { }

[GitHub] [kafka] tinaselenge closed pull request #5545: MINOR: Fixed couple of warnings

tinaselenge closed pull request #5545: MINOR: Fixed couple of warnings URL: https://github.com/apache/kafka/pull/5545 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [kafka] tinaselenge commented on pull request #5545: MINOR: Fixed couple of warnings

tinaselenge commented on PR #5545: URL: https://github.com/apache/kafka/pull/5545#issuecomment-1439953834 This tool is being migrated as part of https://issues.apache.org/jira/browse/KAFKA-14525. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [kafka] cadonna commented on a diff in pull request #13269: KAFKA-12634 enforce checkpoint after restoration

cadonna commented on code in PR #13269: URL: https://github.com/apache/kafka/pull/13269#discussion_r1114238733 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamTask.java: ## @@ -255,6 +255,7 @@ public void completeRestoration(final

[GitHub] [kafka] mimaison merged pull request #13216: Remove unused ZooKeeper log level configuration from `connect-log4j.properties`

mimaison merged PR #13216: URL: https://github.com/apache/kafka/pull/13216 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (KAFKA-14304) ZooKeeper to KRaft Migration

[ https://issues.apache.org/jira/browse/KAFKA-14304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17692106#comment-17692106 ] Luke Chen commented on KAFKA-14304: --- [~mumrah] , also, the fixed version of this epic is set to

[GitHub] [kafka] showuon commented on pull request #13280: KAFKA-14735: Improve KRaft metadata image change performance at high …

showuon commented on PR #13280: URL: https://github.com/apache/kafka/pull/13280#issuecomment-1439780222 @rondagostino , also, it looks like this library doesn't support JDK 8? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[jira] [Assigned] (KAFKA-13771) Support to explicitly delete delegationTokens that have expired but have not been automatically cleaned up

[ https://issues.apache.org/jira/browse/KAFKA-13771?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] RivenSun reassigned KAFKA-13771: Assignee: RivenSun > Support to explicitly delete delegationTokens that have expired but have

[GitHub] [kafka] bachmanity1 commented on a diff in pull request #13261: MINOR: after reading BYTES type it's possible to access data beyond its size

bachmanity1 commented on code in PR #13261: URL: https://github.com/apache/kafka/pull/13261#discussion_r1114028635 ## clients/src/main/java/org/apache/kafka/common/protocol/types/Type.java: ## @@ -688,8 +688,10 @@ public Object read(ByteBuffer buffer) { if (size >