[jira] [Updated] (KAFKA-14304) ZooKeeper to KRaft Migration

[ https://issues.apache.org/jira/browse/KAFKA-14304?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akhilesh Chaganti updated KAFKA-14304: -- Fix Version/s: 3.5.0 > ZooKeeper to KRaft Migration > >

[GitHub] [kafka] satishd commented on a diff in pull request #13275: KAFKA-14522 Rewrite/Move of RemoteIndexCache to storage module.

satishd commented on code in PR #13275: URL: https://github.com/apache/kafka/pull/13275#discussion_r1121236675 ## storage/src/main/java/org/apache/kafka/storage/internals/log/RemoteIndexCache.java: ## @@ -0,0 +1,407 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] satishd commented on a diff in pull request #13275: KAFKA-14522 Rewrite/Move of RemoteIndexCache to storage module.

satishd commented on code in PR #13275: URL: https://github.com/apache/kafka/pull/13275#discussion_r1121168324 ## storage/src/main/java/org/apache/kafka/storage/internals/log/LogFileUtils.java: ## @@ -31,6 +32,21 @@ public final class LogFileUtils { */ public static

[GitHub] [kafka] satishd merged pull request #13309: MINOR Moved a few log segment util methods from LocalLog to LogFileUtils

satishd merged PR #13309: URL: https://github.com/apache/kafka/pull/13309 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] satishd commented on pull request #13309: MINOR Moved a few log segment util methods from LocalLog to LogFileUtils

satishd commented on PR #13309: URL: https://github.com/apache/kafka/pull/13309#issuecomment-1449372613 Test failures do not seem to be related to this change, merging these changes to trunk. -- This is an automated message from the Apache Git Service. To respond to the message, please

[jira] [Updated] (KAFKA-14768) proposal to reduce the first message's send time cost and max block time for safety

[ https://issues.apache.org/jira/browse/KAFKA-14768?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] fujian updated KAFKA-14768: --- Description: Hi, Team:   Nice to meet you!   In our business, we found two types of issue which need to

[GitHub] [kafka] jiafu1115 opened a new pull request, #13320: KAFKA-14768: provide new method to warmup first record's sending and reduce the max.block.ms safely

jiafu1115 opened a new pull request, #13320: URL: https://github.com/apache/kafka/pull/13320 Hi Team: Refer to https://issues.apache.org/jira/browse/KAFKA-14768 There are two issues for current's producer: (1) Take much time to send the first record; (2) can't reduce the

[GitHub] [kafka] showuon commented on pull request #13319: MINOR: Fix flaky tests in DefaultStateUpdaterTest

showuon commented on PR #13319: URL: https://github.com/apache/kafka/pull/13319#issuecomment-1449265831 Thanks for investigating it! This test did fail quite frequently recently. But I'm not completely understanding this: > The root cause seems to be with changing the return behavior

[GitHub] [kafka] showuon commented on a diff in pull request #13275: KAFKA-14522 Rewrite/Move of RemoteIndexCache to storage module.

showuon commented on code in PR #13275: URL: https://github.com/apache/kafka/pull/13275#discussion_r1121043658 ## storage/src/main/java/org/apache/kafka/storage/internals/log/LogFileUtils.java: ## @@ -31,6 +32,21 @@ public final class LogFileUtils { */ public static

[GitHub] [kafka] guozhangwang commented on pull request #13319: MINOR: Fix flaky tests in DefaultStateUpdaterTest

guozhangwang commented on PR #13319: URL: https://github.com/apache/kafka/pull/13319#issuecomment-1449254753 ping @cadonna @lucasbru for a quick review. Before this PR, local runs fail about 50% of the time; after this PR it succeeds with about 10 runs. -- This is an automated

[GitHub] [kafka] guozhangwang opened a new pull request, #13319: MINOR: Fix flaky tests in DefaultStateUpdaterTest

guozhangwang opened a new pull request, #13319: URL: https://github.com/apache/kafka/pull/13319 Found a few flaky tests while reviewing another PR. The root cause seems to be with changing the return behavior of `when` in mockito. Fixed those without using `reset` and also bumped a couple

[jira] [Resolved] (KAFKA-14371) quorum-state file contains empty/unused clusterId field

[ https://issues.apache.org/jira/browse/KAFKA-14371?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen resolved KAFKA-14371. --- Fix Version/s: 3.5.0 Resolution: Fixed > quorum-state file contains empty/unused clusterId

[GitHub] [kafka] showuon merged pull request #13102: KAFKA-14371: Remove unused clusterId field from quorum-state file

showuon merged PR #13102: URL: https://github.com/apache/kafka/pull/13102 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] showuon commented on pull request #13102: KAFKA-14371: Remove unused clusterId field from quorum-state file

showuon commented on PR #13102: URL: https://github.com/apache/kafka/pull/13102#issuecomment-1449214463 Failed tests are unrelated: ``` Build / JDK 11 and Scala 2.13 / org.apache.kafka.connect.mirror.integration.DedicatedMirrorIntegrationTest.testSingleNodeCluster() Build / JDK 11

[jira] [Updated] (KAFKA-14768) proposal to reduce the first message's send time cost and max block time for safety

[ https://issues.apache.org/jira/browse/KAFKA-14768?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] fujian updated KAFKA-14768: --- Description: Hi, Team:   Nice to meet you!   In our business, we found two types of issue which need to

[jira] [Updated] (KAFKA-13771) Support to explicitly delete delegationTokens that have expired but have not been automatically cleaned up

[ https://issues.apache.org/jira/browse/KAFKA-13771?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen updated KAFKA-13771: -- Fix Version/s: 3.5.0 > Support to explicitly delete delegationTokens that have expired but have not

[GitHub] [kafka] philipnee commented on pull request #13190: KAFKA-12639: exit upon expired timer to prevent tight looping

philipnee commented on PR #13190: URL: https://github.com/apache/kafka/pull/13190#issuecomment-1449191428 yeah the DefaultStateUpdaterTest has been failing from time to time... not sure why  -- This is an automated message from the Apache Git Service. To respond to the message, please

[jira] [Resolved] (KAFKA-12639) AbstractCoordinator ignores backoff timeout when joining the consumer group

[ https://issues.apache.org/jira/browse/KAFKA-12639?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang resolved KAFKA-12639. --- Fix Version/s: 3.5.0 Resolution: Fixed > AbstractCoordinator ignores backoff timeout

[GitHub] [kafka] guozhangwang commented on pull request #13190: KAFKA-12639: exit upon expired timer to prevent tight looping

guozhangwang commented on PR #13190: URL: https://github.com/apache/kafka/pull/13190#issuecomment-1449186137 Merged to trunk. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [kafka] guozhangwang commented on pull request #13190: KAFKA-12639: exit upon expired timer to prevent tight looping

guozhangwang commented on PR #13190: URL: https://github.com/apache/kafka/pull/13190#issuecomment-1449185984 The test failures are not relevant (but some of them are related to DefaultStateUpdaterTest.. sigh). -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kafka] guozhangwang merged pull request #13190: KAFKA-12639: exit upon expired timer to prevent tight looping

guozhangwang merged PR #13190: URL: https://github.com/apache/kafka/pull/13190 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] philipnee commented on pull request #13190: KAFKA-12639: exit upon expired timer to prevent tight looping

philipnee commented on PR #13190: URL: https://github.com/apache/kafka/pull/13190#issuecomment-1449185108 Hmm. I think these tests are flaky actually ``` Build / JDK 17 and Scala 2.13 / shouldPauseStandbyTaskAndNotTransitToUpdateStandbyAgain() –

[jira] [Commented] (KAFKA-14533) Flaky Test SmokeTestDriverIntegrationTest.shouldWorkWithRebalance

[ https://issues.apache.org/jira/browse/KAFKA-14533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17694801#comment-17694801 ] Guozhang Wang commented on KAFKA-14533: --- I took some time into this, also cannot find any clues

[GitHub] [kafka] guozhangwang opened a new pull request, #13318: [DO NOT MERGE] Re-enable state-updater in SmokeTestDriverIntegrationTest

guozhangwang opened a new pull request, #13318: URL: https://github.com/apache/kafka/pull/13318 1. Print fine-grained streams exception when list-offset fails. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test

[GitHub] [kafka] jolshan commented on a diff in pull request #13231: KAFKA-14402: Update AddPartitionsToTxn protocol to batch and handle verifyOnly requests

jolshan commented on code in PR #13231: URL: https://github.com/apache/kafka/pull/13231#discussion_r1121005648 ## core/src/test/scala/unit/kafka/server/KafkaApisTest.scala: ## @@ -1962,7 +1962,9 @@ class KafkaApisTest { ArgumentMatchers.eq(producerId),

[GitHub] [kafka] jolshan commented on a diff in pull request #13231: KAFKA-14402: Update AddPartitionsToTxn protocol to batch and handle verifyOnly requests

jolshan commented on code in PR #13231: URL: https://github.com/apache/kafka/pull/13231#discussion_r1120991153 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -2384,68 +2385,116 @@ class KafkaApis(val requestChannel: RequestChannel, if

[GitHub] [kafka] jolshan commented on a diff in pull request #13231: KAFKA-14402: Update AddPartitionsToTxn protocol to batch and handle verifyOnly requests

jolshan commented on code in PR #13231: URL: https://github.com/apache/kafka/pull/13231#discussion_r1120990845 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -2384,68 +2385,116 @@ class KafkaApis(val requestChannel: RequestChannel, if

[GitHub] [kafka] jolshan commented on a diff in pull request #13231: KAFKA-14402: Update AddPartitionsToTxn protocol to batch and handle verifyOnly requests

jolshan commented on code in PR #13231: URL: https://github.com/apache/kafka/pull/13231#discussion_r1120986902 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -2384,68 +2385,116 @@ class KafkaApis(val requestChannel: RequestChannel, if

[GitHub] [kafka] jolshan commented on a diff in pull request #13231: KAFKA-14402: Update AddPartitionsToTxn protocol to batch and handle verifyOnly requests

jolshan commented on code in PR #13231: URL: https://github.com/apache/kafka/pull/13231#discussion_r1120976648 ## clients/src/main/resources/common/message/AddPartitionsToTxnResponse.json: ## @@ -22,22 +22,37 @@ // Version 2 adds the support for new error code

[GitHub] [kafka] cmccabe commented on pull request #13114: KAFKA-14084: SCRAM support in KRaft.

cmccabe commented on PR #13114: URL: https://github.com/apache/kafka/pull/13114#issuecomment-1449130059 Thanks for this, @pprovenzano . It all looks good, but there is one change that we really do need here: we need to add SCRAM to MetadataVersion. I suspect we can add it to `IBP_3_5_IV0`.

[GitHub] [kafka] cmccabe commented on pull request #13114: KAFKA-14084: SCRAM support in KRaft.

cmccabe commented on PR #13114: URL: https://github.com/apache/kafka/pull/13114#issuecomment-1449130005 We need a test like `./metadata/src/test/java/org/apache/kafka/image/ScramImageTesst.java` , similar to the tests for the other Image classes. -- This is an automated message from the

[GitHub] [kafka] jolshan commented on a diff in pull request #13231: KAFKA-14402: Update AddPartitionsToTxn protocol to batch and handle verifyOnly requests

jolshan commented on code in PR #13231: URL: https://github.com/apache/kafka/pull/13231#discussion_r1120967466 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java: ## @@ -1328,7 +1328,7 @@ Priority priority() { @Override

[GitHub] [kafka] cmccabe commented on a diff in pull request #13114: KAFKA-14084: SCRAM support in KRaft.

cmccabe commented on code in PR #13114: URL: https://github.com/apache/kafka/pull/13114#discussion_r1120967385 ## metadata/src/main/java/org/apache/kafka/image/ScramImage.java: ## @@ -0,0 +1,97 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

[GitHub] [kafka] cmccabe commented on a diff in pull request #13114: KAFKA-14084: SCRAM support in KRaft.

cmccabe commented on code in PR #13114: URL: https://github.com/apache/kafka/pull/13114#discussion_r1120962516 ## core/src/main/scala/kafka/server/metadata/BrokerMetadataPublisher.scala: ## @@ -221,6 +223,21 @@ class BrokerMetadataPublisher( s"quotas in

[GitHub] [kafka] cmccabe commented on a diff in pull request #13114: KAFKA-14084: SCRAM support in KRaft.

cmccabe commented on code in PR #13114: URL: https://github.com/apache/kafka/pull/13114#discussion_r1120962516 ## core/src/main/scala/kafka/server/metadata/BrokerMetadataPublisher.scala: ## @@ -221,6 +223,21 @@ class BrokerMetadataPublisher( s"quotas in

[GitHub] [kafka] cmccabe commented on a diff in pull request #13114: KAFKA-14084: SCRAM support in KRaft.

cmccabe commented on code in PR #13114: URL: https://github.com/apache/kafka/pull/13114#discussion_r1120961672 ## core/src/main/scala/kafka/server/ControllerApis.scala: ## @@ -99,6 +99,7 @@ class ControllerApis(val requestChannel: RequestChannel, case

[GitHub] [kafka] gharris1727 commented on pull request #13315: KAFKA-14767: Fix missing commitId build error after git gc

gharris1727 commented on PR #13315: URL: https://github.com/apache/kafka/pull/13315#issuecomment-1449121574 @ijuma I don't know how my change would impact the execution order of rat vs processTestMessages, do you have any intuition? The commitId change that I originally proposed

[GitHub] [kafka] chia7712 commented on pull request #13288: MINOR: fix rerun-tests for unit test

chia7712 commented on PR #13288: URL: https://github.com/apache/kafka/pull/13288#issuecomment-1449114559 > The referenced https://github.com/apache/kafka/pull/11926 seems not relevant, is there a typo in the PR number? #11926 added the new property to avoid recompiling the tests. see

[GitHub] [kafka] ijuma commented on pull request #13315: KAFKA-14767: Fix missing commitId build error after git gc

ijuma commented on PR #13315: URL: https://github.com/apache/kafka/pull/13315#issuecomment-1449090030 Looks like the build failed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [kafka] ijuma commented on a diff in pull request #13304: KAFKA-14726 Move/rewrite of LogReadInfo, LogOffsetSnapshot, LogStartOffsetIncrementReason to storage module

ijuma commented on code in PR #13304: URL: https://github.com/apache/kafka/pull/13304#discussion_r1120933708 ## storage/src/main/java/org/apache/kafka/storage/internals/log/LogReadInfo.java: ## @@ -0,0 +1,87 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [kafka] ijuma commented on a diff in pull request #13304: KAFKA-14726 Move/rewrite of LogReadInfo, LogOffsetSnapshot, LogStartOffsetIncrementReason to storage module

ijuma commented on code in PR #13304: URL: https://github.com/apache/kafka/pull/13304#discussion_r112095 ## storage/src/main/java/org/apache/kafka/storage/internals/log/LogReadInfo.java: ## @@ -0,0 +1,60 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [kafka] guozhangwang commented on pull request #13288: MINOR: fix rerun-tests for unit test

guozhangwang commented on PR #13288: URL: https://github.com/apache/kafka/pull/13288#issuecomment-1449082224 The referenced https://github.com/apache/kafka/pull/11926 seems not relevant, is there a typo in the PR number? -- This is an automated message from the Apache Git Service. To

[GitHub] [kafka] junrao commented on a diff in pull request #13304: KAFKA-14726 Move/rewrite of LogReadInfo, LogOffsetSnapshot, LogStartOffsetIncrementReason to storage module

junrao commented on code in PR #13304: URL: https://github.com/apache/kafka/pull/13304#discussion_r1120915339 ## storage/src/main/java/org/apache/kafka/storage/internals/log/LogReadInfo.java: ## @@ -0,0 +1,87 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [kafka] OneCricketeer commented on a diff in pull request #12992: KIP-887: Add ConfigProvider to make use of environment variables

OneCricketeer commented on code in PR #12992: URL: https://github.com/apache/kafka/pull/12992#discussion_r1120908532 ## clients/src/main/java/org/apache/kafka/common/config/provider/EnvVarConfigProvider.java: ## @@ -0,0 +1,94 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] gharris1727 commented on a diff in pull request #13185: KAFKA-14670: (part 1) Wrap Connectors in IsolatedConnector objects

gharris1727 commented on code in PR #13185: URL: https://github.com/apache/kafka/pull/13185#discussion_r1120897608 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/isolation/IsolatedPlugin.java: ## @@ -0,0 +1,122 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] gharris1727 commented on a diff in pull request #13185: KAFKA-14670: (part 1) Wrap Connectors in IsolatedConnector objects

gharris1727 commented on code in PR #13185: URL: https://github.com/apache/kafka/pull/13185#discussion_r1120897608 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/isolation/IsolatedPlugin.java: ## @@ -0,0 +1,122 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] C0urante commented on a diff in pull request #13185: KAFKA-14670: (part 1) Wrap Connectors in IsolatedConnector objects

C0urante commented on code in PR #13185: URL: https://github.com/apache/kafka/pull/13185#discussion_r1120889645 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/isolation/IsolatedPlugin.java: ## @@ -0,0 +1,122 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] C0urante commented on a diff in pull request #13185: KAFKA-14670: (part 1) Wrap Connectors in IsolatedConnector objects

C0urante commented on code in PR #13185: URL: https://github.com/apache/kafka/pull/13185#discussion_r1120887378 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/isolation/IsolatedPlugin.java: ## @@ -0,0 +1,122 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] C0urante commented on a diff in pull request #13185: KAFKA-14670: (part 1) Wrap Connectors in IsolatedConnector objects

C0urante commented on code in PR #13185: URL: https://github.com/apache/kafka/pull/13185#discussion_r1120886025 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/isolation/IsolatedPlugin.java: ## @@ -0,0 +1,122 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] gharris1727 commented on a diff in pull request #13185: KAFKA-14670: (part 1) Wrap Connectors in IsolatedConnector objects

gharris1727 commented on code in PR #13185: URL: https://github.com/apache/kafka/pull/13185#discussion_r1120880473 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/isolation/IsolatedPlugin.java: ## @@ -0,0 +1,122 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] ijuma commented on a diff in pull request #13315: KAFKA-14767: Fix missing commitId build error after git gc

ijuma commented on code in PR #13315: URL: https://github.com/apache/kafka/pull/13315#discussion_r1120878251 ## build.gradle: ## @@ -159,16 +159,9 @@ def determineCommitId() { def takeFromHash = 16 if (project.hasProperty('commitId')) { commitId.take(takeFromHash) -

[GitHub] [kafka] cmccabe closed pull request #13176: MINOR: some ZK migration code cleanups.

cmccabe closed pull request #13176: MINOR: some ZK migration code cleanups. URL: https://github.com/apache/kafka/pull/13176 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [kafka] gharris1727 commented on a diff in pull request #13185: KAFKA-14670: (part 1) Wrap Connectors in IsolatedConnector objects

gharris1727 commented on code in PR #13185: URL: https://github.com/apache/kafka/pull/13185#discussion_r1120867064 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/isolation/IsolatedPlugin.java: ## @@ -0,0 +1,122 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] gharris1727 commented on a diff in pull request #13185: KAFKA-14670: (part 1) Wrap Connectors in IsolatedConnector objects

gharris1727 commented on code in PR #13185: URL: https://github.com/apache/kafka/pull/13185#discussion_r1120864255 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/isolation/IsolatedPlugin.java: ## @@ -0,0 +1,122 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] C0urante commented on a diff in pull request #13182: KAFKA-14649: Isolate failures during plugin path scanning to single plugin classes

C0urante commented on code in PR #13182: URL: https://github.com/apache/kafka/pull/13182#discussion_r1120776026 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/isolation/DelegatingClassLoader.java: ## @@ -419,7 +423,14 @@ private Collection>

[jira] [Updated] (KAFKA-14769) NPE in ControllerMetricsManager when upgrading from old KRaft version

[ https://issues.apache.org/jira/browse/KAFKA-14769?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Arthur updated KAFKA-14769: - Affects Version/s: (was: 3.4.0) > NPE in ControllerMetricsManager when upgrading from old

[jira] [Updated] (KAFKA-14769) NPE in ControllerMetricsManager when upgrading from old KRaft version

[ https://issues.apache.org/jira/browse/KAFKA-14769?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Arthur updated KAFKA-14769: - Fix Version/s: (was: 3.5.0) (was: 3.4.1) > NPE in

[jira] [Resolved] (KAFKA-14769) NPE in ControllerMetricsManager when upgrading from old KRaft version

[ https://issues.apache.org/jira/browse/KAFKA-14769?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Arthur resolved KAFKA-14769. -- Resolution: Invalid > NPE in ControllerMetricsManager when upgrading from old KRaft version >

[jira] [Created] (KAFKA-14769) NPE in ControllerMetricsManager when upgrading from old KRaft version

David Arthur created KAFKA-14769: Summary: NPE in ControllerMetricsManager when upgrading from old KRaft version Key: KAFKA-14769 URL: https://issues.apache.org/jira/browse/KAFKA-14769 Project: Kafka

[GitHub] [kafka] C0urante commented on a diff in pull request #13185: KAFKA-14670: (part 1) Wrap Connectors in IsolatedConnector objects

C0urante commented on code in PR #13185: URL: https://github.com/apache/kafka/pull/13185#discussion_r1120685793 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/isolation/IsolatedPlugin.java: ## @@ -0,0 +1,122 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] C0urante commented on a diff in pull request #12992: KIP-887: Add ConfigProvider to make use of environment variables

C0urante commented on code in PR #12992: URL: https://github.com/apache/kafka/pull/12992#discussion_r1120750168 ## clients/src/main/java/org/apache/kafka/common/config/provider/EnvVarConfigProvider.java: ## @@ -0,0 +1,94 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [kafka] OneCricketeer commented on a diff in pull request #12992: KIP-887: Add ConfigProvider to make use of environment variables

OneCricketeer commented on code in PR #12992: URL: https://github.com/apache/kafka/pull/12992#discussion_r1114750313 ## clients/src/main/java/org/apache/kafka/common/config/provider/EnvVarConfigProvider.java: ## @@ -41,6 +46,14 @@ public EnvVarConfigProvider(Map

[GitHub] [kafka] philipnee commented on a diff in pull request #13190: KAFKA-12639: exit upon expired timer to prevent tight looping

philipnee commented on code in PR #13190: URL: https://github.com/apache/kafka/pull/13190#discussion_r1120665269 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java: ## @@ -501,13 +501,18 @@ boolean joinGroupIfNeeded(final Timer timer)

[GitHub] [kafka] philipnee commented on a diff in pull request #13190: KAFKA-12639: exit upon expired timer to prevent tight looping

philipnee commented on code in PR #13190: URL: https://github.com/apache/kafka/pull/13190#discussion_r1120663942 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinatorTest.java: ## @@ -1484,7 +1484,8 @@ public void

[GitHub] [kafka] lbownik commented on a diff in pull request #13067: KAFKA-14524: Rewrite KafkaMetricsGroup in Java

lbownik commented on code in PR #13067: URL: https://github.com/apache/kafka/pull/13067#discussion_r1120661170 ## server-common/src/main/java/org/apache/kafka/server/metrics/KafkaMetricsGroup.java: ## @@ -0,0 +1,160 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] C0urante commented on a diff in pull request #13287: MINOR: Refactor task change logic to AbstractHerder, reuse for standalone mode.

C0urante commented on code in PR #13287: URL: https://github.com/apache/kafka/pull/13287#discussion_r1120636637 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/standalone/StandaloneHerder.java: ## @@ -427,9 +427,8 @@ private void updateConnectorTasks(String

[jira] [Comment Edited] (KAFKA-14767) Gradle build fails with missing commitId after git gc

[ https://issues.apache.org/jira/browse/KAFKA-14767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17694207#comment-17694207 ] Greg Harris edited comment on KAFKA-14767 at 2/28/23 7:01 PM: -- This happens

[jira] [Comment Edited] (KAFKA-14767) Gradle build fails with missing commitId after git gc

[ https://issues.apache.org/jira/browse/KAFKA-14767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17694207#comment-17694207 ] Greg Harris edited comment on KAFKA-14767 at 2/28/23 7:01 PM: -- This happens

[GitHub] [kafka] gharris1727 commented on a diff in pull request #13287: MINOR: Refactor task change logic to AbstractHerder, reuse for standalone mode.

gharris1727 commented on code in PR #13287: URL: https://github.com/apache/kafka/pull/13287#discussion_r1120610035 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/standalone/StandaloneHerder.java: ## @@ -427,9 +427,8 @@ private void updateConnectorTasks(String

[GitHub] [kafka] C0urante commented on a diff in pull request #12992: KIP-887: Add ConfigProvider to make use of environment variables

C0urante commented on code in PR #12992: URL: https://github.com/apache/kafka/pull/12992#discussion_r1120563796 ## clients/src/main/java/org/apache/kafka/common/config/provider/EnvVarConfigProvider.java: ## @@ -0,0 +1,114 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [kafka] C0urante commented on a diff in pull request #12992: KIP-887: Add ConfigProvider to make use of environment variables

C0urante commented on code in PR #12992: URL: https://github.com/apache/kafka/pull/12992#discussion_r1120561014 ## clients/src/main/java/org/apache/kafka/common/config/provider/EnvVarConfigProvider.java: ## @@ -0,0 +1,94 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [kafka] ivanyu commented on a diff in pull request #13067: KAFKA-14524: Rewrite KafkaMetricsGroup in Java

ivanyu commented on code in PR #13067: URL: https://github.com/apache/kafka/pull/13067#discussion_r1120551247 ## core/src/main/scala/kafka/network/RequestChannel.scala: ## @@ -497,51 +501,59 @@ object RequestMetrics { val ErrorsPerSec = "ErrorsPerSec" } -class

[GitHub] [kafka] C0urante merged pull request #13286: MINOR: reformat ClusterConfigState constructions in Abstract & DistributedHerder

C0urante merged PR #13286: URL: https://github.com/apache/kafka/pull/13286 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] C0urante commented on a diff in pull request #13287: MINOR: Refactor task change logic to AbstractHerder, reuse for standalone mode.

C0urante commented on code in PR #13287: URL: https://github.com/apache/kafka/pull/13287#discussion_r1120511592 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/standalone/StandaloneHerder.java: ## @@ -427,9 +427,8 @@ private void updateConnectorTasks(String

[GitHub] [kafka] satishd commented on pull request #13304: KAFKA-14726 Move/rewrite of LogReadInfo, LogOffsetSnapshot, LogStartOffsetIncrementReason to storage module

satishd commented on PR #13304: URL: https://github.com/apache/kafka/pull/13304#issuecomment-1448587425 Thanks @junrao for your review. Addressed them with the latest commit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[jira] [Assigned] (KAFKA-14533) Flaky Test SmokeTestDriverIntegrationTest.shouldWorkWithRebalance

[ https://issues.apache.org/jira/browse/KAFKA-14533?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax reassigned KAFKA-14533: --- Assignee: Guozhang Wang > Flaky Test

[GitHub] [kafka] ijuma commented on a diff in pull request #13067: KAFKA-14524: Rewrite KafkaMetricsGroup in Java

ijuma commented on code in PR #13067: URL: https://github.com/apache/kafka/pull/13067#discussion_r1120488775 ## core/src/main/scala/kafka/network/RequestChannel.scala: ## @@ -497,51 +501,59 @@ object RequestMetrics { val ErrorsPerSec = "ErrorsPerSec" } -class

[GitHub] [kafka] philipnee commented on a diff in pull request #13190: KAFKA-12639: exit upon expired timer to prevent tight looping

philipnee commented on code in PR #13190: URL: https://github.com/apache/kafka/pull/13190#discussion_r1120481527 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java: ## @@ -500,14 +500,24 @@ boolean joinGroupIfNeeded(final Timer timer)

[GitHub] [kafka] C0urante commented on pull request #13284: KAFKA-14718: Make MirrorMaker startup synchronously depend on connector start

C0urante commented on PR #13284: URL: https://github.com/apache/kafka/pull/13284#issuecomment-1448579807 > I think that fixing the test by extending the timeout might hide the problems that users may be facing in production as well. I don't think that bumping the timeouts in these

[GitHub] [kafka] gharris1727 commented on pull request #13313: KAFKA-14760: Move ThroughputThrottler from tools to clients, remove tools dependency from connect-runtime

gharris1727 commented on PR #13313: URL: https://github.com/apache/kafka/pull/13313#issuecomment-1448576594 I removed the checkstyle statements which allow `connect-runtime` to import `tools`. Since this is the only dependency on `tools`, we also have an opportunity to disallow _any_

[GitHub] [kafka] guozhangwang commented on a diff in pull request #13190: KAFKA-12639: exit upon expired timer to prevent tight looping

guozhangwang commented on code in PR #13190: URL: https://github.com/apache/kafka/pull/13190#discussion_r1120460193 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java: ## @@ -500,14 +500,24 @@ boolean joinGroupIfNeeded(final Timer

[GitHub] [kafka] ijuma commented on a diff in pull request #13312: KAFKA-14766: Improve performance of VarInt encoding and decoding

ijuma commented on code in PR #13312: URL: https://github.com/apache/kafka/pull/13312#discussion_r1120470741 ## clients/src/main/java/org/apache/kafka/common/utils/ByteUtils.java: ## @@ -227,17 +259,62 @@ public static int readVarint(DataInput in) throws IOException { *

[GitHub] [kafka] guozhangwang commented on a diff in pull request #13190: KAFKA-12639: exit upon expired timer to prevent tight looping

guozhangwang commented on code in PR #13190: URL: https://github.com/apache/kafka/pull/13190#discussion_r1120456284 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinatorTest.java: ## @@ -1484,6 +1484,8 @@ public void

[jira] [Commented] (KAFKA-14748) Relax non-null FK left-join requirement

[ https://issues.apache.org/jira/browse/KAFKA-14748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17694652#comment-17694652 ] Guozhang Wang commented on KAFKA-14748: --- I agree for Stream-Stream joins now, since for the case

[GitHub] [kafka] satishd commented on pull request #13309: MINOR Moved a few log segment util methods from LocalLog to LogFileUtils

satishd commented on PR #13309: URL: https://github.com/apache/kafka/pull/13309#issuecomment-1448524298 Thanks @junrao for the review. Addressed them with the latest commit/comments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] satishd commented on a diff in pull request #13309: MINOR Moved a few log segment util methods from LocalLog to LogFileUtils

satishd commented on code in PR #13309: URL: https://github.com/apache/kafka/pull/13309#discussion_r1120421628 ## storage/src/main/java/org/apache/kafka/storage/internals/log/LogFileUtils.java: ## @@ -72,4 +92,99 @@ private static String filenamePrefixFromOffset(long offset) {

[GitHub] [kafka] divijvaidya commented on a diff in pull request #13312: KAFKA-14766: Improve performance of VarInt encoding and decoding

divijvaidya commented on code in PR #13312: URL: https://github.com/apache/kafka/pull/13312#discussion_r1120354148 ## clients/src/main/java/org/apache/kafka/common/utils/ByteUtils.java: ## @@ -292,29 +415,66 @@ public static double readDouble(ByteBuffer buffer) { * @param

[GitHub] [kafka] C0urante merged pull request #13184: KAFKA-14671: Refactor PredicatedTransformation to not implement Transformation

C0urante merged PR #13184: URL: https://github.com/apache/kafka/pull/13184 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] divijvaidya commented on a diff in pull request #13312: KAFKA-14766: Improve performance of VarInt encoding and decoding

divijvaidya commented on code in PR #13312: URL: https://github.com/apache/kafka/pull/13312#discussion_r1120328865 ## clients/src/main/java/org/apache/kafka/common/utils/ByteUtils.java: ## @@ -227,17 +259,62 @@ public static int readVarint(DataInput in) throws IOException {

[GitHub] [kafka] divijvaidya commented on a diff in pull request #13312: KAFKA-14766: Improve performance of VarInt encoding and decoding

divijvaidya commented on code in PR #13312: URL: https://github.com/apache/kafka/pull/13312#discussion_r1120323557 ## clients/src/main/java/org/apache/kafka/common/utils/ByteUtils.java: ## @@ -150,17 +151,32 @@ public static void writeUnsignedIntLE(byte[] buffer, int offset,

[GitHub] [kafka] yashmayya commented on a diff in pull request #13276: KAFKA-14732: Use an exponential backoff retry mechanism while reconfiguring connector tasks

yashmayya commented on code in PR #13276: URL: https://github.com/apache/kafka/pull/13276#discussion_r1119640881 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/distributed/DistributedHerderTest.java: ## @@ -3694,6 +3694,54 @@ public void

[jira] [Updated] (KAFKA-14732) Use an exponential backoff retry mechanism while reconfiguring connector tasks

[ https://issues.apache.org/jira/browse/KAFKA-14732?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Egerton updated KAFKA-14732: -- Fix Version/s: 3.5.0 > Use an exponential backoff retry mechanism while reconfiguring

[GitHub] [kafka] C0urante merged pull request #13276: KAFKA-14732: Use an exponential backoff retry mechanism while reconfiguring connector tasks

C0urante merged PR #13276: URL: https://github.com/apache/kafka/pull/13276 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] C0urante commented on a diff in pull request #13276: KAFKA-14732: Use an exponential backoff retry mechanism while reconfiguring connector tasks

C0urante commented on code in PR #13276: URL: https://github.com/apache/kafka/pull/13276#discussion_r1120259483 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/distributed/DistributedHerderTest.java: ## @@ -3694,6 +3694,54 @@ public void

[GitHub] [kafka] ijuma merged pull request #13316: MINOR: srcJar should depend on processMessages task

ijuma merged PR #13316: URL: https://github.com/apache/kafka/pull/13316 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] ijuma commented on pull request #13316: MINOR: srcJar should depend on processMessages task

ijuma commented on PR #13316: URL: https://github.com/apache/kafka/pull/13316#issuecomment-1448363891 Test failures are unrelated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [kafka] ijuma commented on a diff in pull request #13312: KAFKA-14766: Improve performance of VarInt encoding and decoding

ijuma commented on code in PR #13312: URL: https://github.com/apache/kafka/pull/13312#discussion_r1120217103 ## clients/src/main/java/org/apache/kafka/common/utils/ByteUtils.java: ## @@ -292,29 +415,66 @@ public static double readDouble(ByteBuffer buffer) { * @param

[GitHub] [kafka] divijvaidya commented on pull request #12620: KAFKA-14206: upgrade zookeeper version to 3.7.1

divijvaidya commented on PR #12620: URL: https://github.com/apache/kafka/pull/12620#issuecomment-1448325538 Completing the conversation here, in case someone comes around reading this old thread. We have a new KIP and a PR for Zk migration to 3.8.1 which would hopefully land in 3.5.

[jira] [Updated] (KAFKA-14659) source-record-write-[rate|total] metrics include filtered records

[ https://issues.apache.org/jira/browse/KAFKA-14659?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Egerton updated KAFKA-14659: -- Fix Version/s: 3.3.3 > source-record-write-[rate|total] metrics include filtered records >

[jira] [Updated] (KAFKA-14659) source-record-write-[rate|total] metrics include filtered records

[ https://issues.apache.org/jira/browse/KAFKA-14659?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Egerton updated KAFKA-14659: -- Fix Version/s: 3.4.1 > source-record-write-[rate|total] metrics include filtered records >

  1   2   >