[GitHub] [kafka] ijuma commented on a diff in pull request #13116: KAFKA-14351: Controller Mutation Quota for KRaft

ijuma commented on code in PR #13116: URL: https://github.com/apache/kafka/pull/13116#discussion_r1125408496 ## metadata/src/main/java/org/apache/kafka/controller/ControllerRequestContext.java: ## @@ -42,19 +45,39 @@ public static OptionalLong requestTimeoutMsToDeadlineNs(

[GitHub] [kafka] jeffkbkim commented on a diff in pull request #13329: KAFKA-14462; [2/N] Add ConsumerGroupHeartbeart to GroupCoordinator interface

jeffkbkim commented on code in PR #13329: URL: https://github.com/apache/kafka/pull/13329#discussion_r1125367811 ## core/src/test/scala/unit/kafka/server/ConsumerGroupHeartbeatRequestTest.scala: ## @@ -54,6 +54,20 @@ class ConsumerGroupHeartbeatRequestTest(cluster:

[GitHub] [kafka] ijuma commented on pull request #13339: MINOR: version upgrades: zinc 1.7.2 -->> 1.8.0, gradle 8.0.1 -->> 8.0.2 and gradle plugins

ijuma commented on PR #13339: URL: https://github.com/apache/kafka/pull/13339#issuecomment-1454394562 Thanks for the PR. I think the following workaround where we use `:` is no longer required: https://github.com/apache/kafka/blob/trunk/build.gradle#L685 This is the PR where

[GitHub] [kafka] satishd merged pull request #13304: KAFKA-14726 Move/rewrite of LogReadInfo, LogOffsetSnapshot, LogStartOffsetIncrementReason to storage module

satishd merged PR #13304: URL: https://github.com/apache/kafka/pull/13304 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] vcrfxia opened a new pull request, #13340: KAFKA-14491: [15/N] Add integration tests for versioned stores

vcrfxia opened a new pull request, #13340: URL: https://github.com/apache/kafka/pull/13340 (This PR is stacked on https://github.com/apache/kafka/pull/13292 -- only the last commit needs to be reviewed separately.) Adds integration tests for the new versioned stores introduced in

[GitHub] [kafka] dejan2609 opened a new pull request, #13339: MINOR: version upgrades: zinc 1.7.2 -->> 1.8.0, gradle 8.0.1 -->> 8.0.2 and gradle plugins

dejan2609 opened a new pull request, #13339: URL: https://github.com/apache/kafka/pull/13339 Related links: - zinc release notes: https://github.com/sbt/zinc/releases/tag/v1.8.0 - gradle release notes: https://github.com/gradle/gradle/releases/tag/v8.0.2 - gradle diff:

[GitHub] [kafka] philipnee commented on a diff in pull request #12813: KAFKA-14317: ProduceRequest timeouts are logged as network exceptions

philipnee commented on code in PR #12813: URL: https://github.com/apache/kafka/pull/12813#discussion_r1125051927 ## clients/src/main/java/org/apache/kafka/clients/NetworkClient.java: ## @@ -753,7 +756,8 @@ public static AbstractResponse parseResponse(ByteBuffer responseBuffer,

[GitHub] [kafka] jolshan commented on a diff in pull request #13231: KAFKA-14402: Update AddPartitionsToTxn protocol to batch and handle verifyOnly requests

jolshan commented on code in PR #13231: URL: https://github.com/apache/kafka/pull/13231#discussion_r1125017580 ## clients/src/test/java/org/apache/kafka/common/requests/RequestResponseTest.java: ## @@ -2598,12 +2604,37 @@ private OffsetsForLeaderEpochResponse

[jira] [Commented] (KAFKA-13882) Dockerfile for previewing website

[ https://issues.apache.org/jira/browse/KAFKA-13882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17696324#comment-17696324 ] ASF GitHub Bot commented on KAFKA-13882: mjsax commented on PR #410: URL:

[jira] [Commented] (KAFKA-14748) Relax non-null FK left-join requirement

[ https://issues.apache.org/jira/browse/KAFKA-14748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17696313#comment-17696313 ] Matthias J. Sax commented on KAFKA-14748: - Yes, the behavior would change. But make this change

[jira] [Commented] (KAFKA-14765) Support SCRAM for brokers at bootstrap

[ https://issues.apache.org/jira/browse/KAFKA-14765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17696311#comment-17696311 ] Proven Provenzano commented on KAFKA-14765: --- PR [13114

[jira] [Commented] (KAFKA-14084) Support SCRAM when using KRaft mode

[ https://issues.apache.org/jira/browse/KAFKA-14084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17696309#comment-17696309 ] Proven Provenzano commented on KAFKA-14084: --- Base support without bootstrap support has been

[jira] [Assigned] (KAFKA-14084) Support SCRAM when using KRaft mode

[ https://issues.apache.org/jira/browse/KAFKA-14084?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Proven Provenzano reassigned KAFKA-14084: - Assignee: Proven Provenzano (was: Colin McCabe) > Support SCRAM when using

[jira] [Commented] (KAFKA-9234) Consider using @Nullable and @Nonnull annotations

[ https://issues.apache.org/jira/browse/KAFKA-9234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17696306#comment-17696306 ] Matthias J. Sax commented on KAFKA-9234: Thanks for the pointer – I am not familiar with JSpecify

[GitHub] [kafka] pprovenzano opened a new pull request, #13338: KAFKA-14765: Support SCRAM for brokers at bootstrap

pprovenzano opened a new pull request, #13338: URL: https://github.com/apache/kafka/pull/13338 Implement KIP-900 Update kafka-storage to be able to add SCRAM records to the bootstrap metadata file at format time so that SCRAM is enabled at initial start of KRaft cluster.

[jira] [Comment Edited] (KAFKA-9234) Consider using @Nullable and @Nonnull annotations

[ https://issues.apache.org/jira/browse/KAFKA-9234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17696300#comment-17696300 ] Adam edited comment on KAFKA-9234 at 3/3/23 8:05 PM: - I'd like to chip in: Since the

[jira] [Commented] (KAFKA-9234) Consider using @Nullable and @Nonnull annotations

[ https://issues.apache.org/jira/browse/KAFKA-9234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17696300#comment-17696300 ] Adam commented on KAFKA-9234: - I'd like to chip in: Since the last PR there has been an effort to implement a

[jira] [Comment Edited] (KAFKA-9234) Consider using @Nullable and @Nonnull annotations

[ https://issues.apache.org/jira/browse/KAFKA-9234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17696300#comment-17696300 ] Adam edited comment on KAFKA-9234 at 3/3/23 8:04 PM: - I'd like to chip in: Since the

[GitHub] [kafka] jolshan commented on a diff in pull request #13231: KAFKA-14402: Update AddPartitionsToTxn protocol to batch and handle verifyOnly requests

jolshan commented on code in PR #13231: URL: https://github.com/apache/kafka/pull/13231#discussion_r1124937664 ## clients/src/main/java/org/apache/kafka/common/requests/AddPartitionsToTxnResponse.java: ## @@ -80,45 +105,44 @@ topicName, new

[GitHub] [kafka] C0urante commented on pull request #10566: KAFKA-12694 Avoid schema mismatch DataException when validating default values

C0urante commented on PR #10566: URL: https://github.com/apache/kafka/pull/10566#issuecomment-1454040953 Ah thanks @urbandan, that helps. It's worth noting that the latest example test case is probably missing calls to actually set the default value for the schema builder instances?

[GitHub] [kafka] jolshan commented on a diff in pull request #13231: KAFKA-14402: Update AddPartitionsToTxn protocol to batch and handle verifyOnly requests

jolshan commented on code in PR #13231: URL: https://github.com/apache/kafka/pull/13231#discussion_r1124925652 ## core/src/test/scala/unit/kafka/coordinator/transaction/TransactionCoordinatorTest.scala: ## @@ -1185,4 +1213,8 @@ class TransactionCoordinatorTest { def

[GitHub] [kafka] lucasbru commented on a diff in pull request #13318: KAFKA-14533: Do not interrupt state-updater thread during shutdown

lucasbru commented on code in PR #13318: URL: https://github.com/apache/kafka/pull/13318#discussion_r1124916956 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/DefaultStateUpdater.java: ## @@ -312,16 +305,20 @@ private void

[GitHub] [kafka] guozhangwang commented on a diff in pull request #13330: Prototyping Rebalance Protocol

guozhangwang commented on code in PR #13330: URL: https://github.com/apache/kafka/pull/13330#discussion_r1124915057 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/ProtocolRequestManager.java: ## @@ -0,0 +1,118 @@ +package

[GitHub] [kafka] cmccabe commented on pull request #13331: MINOR: fix fault handling in ControllerServer and KafkaServer

cmccabe commented on PR #13331: URL: https://github.com/apache/kafka/pull/13331#issuecomment-1454006628 Fix checkstyle -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [kafka] cmccabe commented on pull request #13332: KAFKA-14057: Support dynamic reconfiguration in KRaft remote controllers

cmccabe commented on PR #13332: URL: https://github.com/apache/kafka/pull/13332#issuecomment-1454000670 Let me split out the MetadataPublisher refactoring part. https://github.com/apache/kafka/pull/13337 -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kafka] cmccabe opened a new pull request, #13337: MINOR: Refactor the MetadataPublisher interface

cmccabe opened a new pull request, #13337: URL: https://github.com/apache/kafka/pull/13337 This PR refactors MetadataPublisher's interface a bit. There is now a handleControllerChange callback. This is something that some publishers might want. A good example is ZkMigrationClient.

[GitHub] [kafka] cmccabe commented on pull request #13114: KAFKA-14084: SCRAM support in KRaft.

cmccabe commented on PR #13114: URL: https://github.com/apache/kafka/pull/13114#issuecomment-1453998511 follow-ons: https://issues.apache.org/jira/browse/KAFKA-14765 https://issues.apache.org/jira/browse/KAFKA-14775 https://issues.apache.org/jira/browse/KAFKA-14776 -- This is an

[GitHub] [kafka] guozhangwang commented on pull request #13301: KAFKA-14758: Extract inner classes from Fetcher for reuse in refactoring

guozhangwang commented on PR #13301: URL: https://github.com/apache/kafka/pull/13301#issuecomment-1453981950 Got it, thanks for confirming. The rule of thumb is that for any code potentially in production, we would make sure they have test coverage. So as long as we could make it to cover

[GitHub] [kafka] guozhangwang merged pull request #13082: MINOR: Clarify docs for Streams config max.warmup.replicas.

guozhangwang merged PR #13082: URL: https://github.com/apache/kafka/pull/13082 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (KAFKA-14748) Relax non-null FK left-join requirement

[ https://issues.apache.org/jira/browse/KAFKA-14748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17696279#comment-17696279 ] Guozhang Wang commented on KAFKA-14748: --- For table-table FK left-joins, if we have record B whose

[GitHub] [kafka] guozhangwang commented on pull request #13318: KAFKA-14533: Do not interrupt state-updater thread during shutdown

guozhangwang commented on PR #13318: URL: https://github.com/apache/kafka/pull/13318#issuecomment-1453957529 > We had a failure of Build / JDK 11 and Scala 2.13 / org.apache.kafka.streams.integration.PauseResumeIntegrationTest.[1] true. I'm pretty sure that one was not flaky before. Any

[GitHub] [kafka] philipnee closed pull request #13269: KAFKA-12634 enforce checkpoint after restoration

philipnee closed pull request #13269: KAFKA-12634 enforce checkpoint after restoration URL: https://github.com/apache/kafka/pull/13269 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [kafka] cmccabe merged pull request #13114: KAFKA-14084: SCRAM support in KRaft.

cmccabe merged PR #13114: URL: https://github.com/apache/kafka/pull/13114 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] philipnee commented on pull request #13269: KAFKA-12634 enforce checkpoint after restoration

philipnee commented on PR #13269: URL: https://github.com/apache/kafka/pull/13269#issuecomment-1453921659 i took a peek at it because @mjsax mentioned it is easy to work on. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [kafka] philipnee commented on pull request #13269: KAFKA-12634 enforce checkpoint after restoration

philipnee commented on PR #13269: URL: https://github.com/apache/kafka/pull/13269#issuecomment-1453919620 Oh yeah, I was wondering about that, too - it's up to you. We can abandon this and wait for 10199 to be completed. -- This is an automated message from the Apache Git Service. To

[GitHub] [kafka] guozhangwang merged pull request #13336: MINOR: update RocksDBMetricsRecorder test to JUnit5 and fix memory leak

guozhangwang merged PR #13336: URL: https://github.com/apache/kafka/pull/13336 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] philipnee commented on pull request #12038: KAFKA-13421 - fix flaky ConsumerBounceTest#testConsumerReceivesFatalExceptionWhenGroupPassesMaxSize

philipnee commented on PR #12038: URL: https://github.com/apache/kafka/pull/12038#issuecomment-1453914893 Well, not "hard to reproduce", I have not had luck to reproduce it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [kafka] guozhangwang commented on pull request #13269: KAFKA-12634 enforce checkpoint after restoration

guozhangwang commented on PR #13269: URL: https://github.com/apache/kafka/pull/13269#issuecomment-1453914588 Sorry for jumping into this PR late @philipnee , for this ticket, we have fixed it in the new state updater thread ([KAFKA-10199](https://issues.apache.org/jira/browse/KAFKA-10199).

[jira] [Commented] (KAFKA-9234) Consider using @Nullable and @Nonnull annotations

[ https://issues.apache.org/jira/browse/KAFKA-9234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17696249#comment-17696249 ] Matthias J. Sax commented on KAFKA-9234: {quote}I just joined the community this week. {quote}

[jira] [Assigned] (KAFKA-9234) Consider using @Nullable and @Nonnull annotations

[ https://issues.apache.org/jira/browse/KAFKA-9234?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax reassigned KAFKA-9234: -- Assignee: Ganesh Sahu (was: Manasvi Gupta) > Consider using @Nullable and @Nonnull

[GitHub] [kafka] jolshan commented on a diff in pull request #13231: KAFKA-14402: Update AddPartitionsToTxn protocol to batch and handle verifyOnly requests

jolshan commented on code in PR #13231: URL: https://github.com/apache/kafka/pull/13231#discussion_r1124831869 ## core/src/main/scala/kafka/coordinator/transaction/TransactionCoordinator.scala: ## @@ -317,6 +322,34 @@ class TransactionCoordinator(txnConfig: TransactionConfig,

[GitHub] [kafka] jolshan commented on a diff in pull request #13231: KAFKA-14402: Update AddPartitionsToTxn protocol to batch and handle verifyOnly requests

jolshan commented on code in PR #13231: URL: https://github.com/apache/kafka/pull/13231#discussion_r1124831349 ## clients/src/test/java/org/apache/kafka/common/requests/AddPartitionsToTxnResponseTest.java: ## @@ -58,42 +65,75 @@ public void setUp() { errorsMap.put(tp2,

[GitHub] [kafka] cmccabe commented on a diff in pull request #13114: KAFKA-14084: SCRAM support in KRaft.

cmccabe commented on code in PR #13114: URL: https://github.com/apache/kafka/pull/13114#discussion_r1124830672 ## metadata/src/test/java/org/apache/kafka/image/ScramImageTest.java: ## @@ -0,0 +1,161 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more +

[GitHub] [kafka] jolshan commented on a diff in pull request #13231: KAFKA-14402: Update AddPartitionsToTxn protocol to batch and handle verifyOnly requests

jolshan commented on code in PR #13231: URL: https://github.com/apache/kafka/pull/13231#discussion_r1124830314 ## clients/src/test/java/org/apache/kafka/common/requests/AddPartitionsToTxnResponseTest.java: ## @@ -58,42 +65,75 @@ public void setUp() { errorsMap.put(tp2,

[GitHub] [kafka] dajac commented on a diff in pull request #13231: KAFKA-14402: Update AddPartitionsToTxn protocol to batch and handle verifyOnly requests

dajac commented on code in PR #13231: URL: https://github.com/apache/kafka/pull/13231#discussion_r1124792127 ## clients/src/main/java/org/apache/kafka/common/requests/AddPartitionsToTxnRequest.java: ## @@ -34,22 +43,38 @@ public class AddPartitionsToTxnRequest extends

[GitHub] [kafka] pprovenzano commented on pull request #13114: KAFKA-14084: SCRAM support in KRaft.

pprovenzano commented on PR #13114: URL: https://github.com/apache/kafka/pull/13114#issuecomment-1453878000 I've added the MetadataVersion fixes with tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [kafka] viktorsomogyi commented on a diff in pull request #12992: KIP-887: Add ConfigProvider to make use of environment variables

viktorsomogyi commented on code in PR #12992: URL: https://github.com/apache/kafka/pull/12992#discussion_r1124689076 ## clients/src/main/java/org/apache/kafka/common/config/provider/EnvVarConfigProvider.java: ## @@ -0,0 +1,94 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] viktorsomogyi commented on a diff in pull request #12992: KIP-887: Add ConfigProvider to make use of environment variables

viktorsomogyi commented on code in PR #12992: URL: https://github.com/apache/kafka/pull/12992#discussion_r1124689076 ## clients/src/main/java/org/apache/kafka/common/config/provider/EnvVarConfigProvider.java: ## @@ -0,0 +1,94 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] philipnee commented on pull request #13269: KAFKA-12634 enforce checkpoint after restoration

philipnee commented on PR #13269: URL: https://github.com/apache/kafka/pull/13269#issuecomment-1453776408 @cadonna - Thanks for the feedback there. I added the EOS check before the checkpoint. I also made a bunch of changes to the tests. To make things obvious, I added a comment to these

[GitHub] [kafka] viktorsomogyi commented on a diff in pull request #12992: KIP-887: Add ConfigProvider to make use of environment variables

viktorsomogyi commented on code in PR #12992: URL: https://github.com/apache/kafka/pull/12992#discussion_r1124689076 ## clients/src/main/java/org/apache/kafka/common/config/provider/EnvVarConfigProvider.java: ## @@ -0,0 +1,94 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] philipnee commented on pull request #13269: KAFKA-12634 enforce checkpoint after restoration

philipnee commented on PR #13269: URL: https://github.com/apache/kafka/pull/13269#issuecomment-1453770724 There's a bunch of failing DedicatedMirrorIntegrationTest - most likely unrelated. -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] vvcephei commented on a diff in pull request #13274: KAFKA-14491: [13/N] Add versioned store builder and materializer

vvcephei commented on code in PR #13274: URL: https://github.com/apache/kafka/pull/13274#discussion_r1124670079 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/KeyValueStoreMaterializer.java: ## @@ -48,20 +55,30 @@ public StoreBuilder> materialize() {

[GitHub] [kafka] pprovenzano commented on a diff in pull request #13114: KAFKA-14084: SCRAM support in KRaft.

pprovenzano commented on code in PR #13114: URL: https://github.com/apache/kafka/pull/13114#discussion_r1124583449 ## core/src/main/scala/kafka/server/metadata/BrokerMetadataPublisher.scala: ## @@ -221,6 +223,21 @@ class BrokerMetadataPublisher( s"quotas in

[jira] [Updated] (KAFKA-14649) Failures instantiating Connect plugins hides other plugins from REST API, or crash worker

[ https://issues.apache.org/jira/browse/KAFKA-14649?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Egerton updated KAFKA-14649: -- Fix Version/s: 3.4.1 > Failures instantiating Connect plugins hides other plugins from REST

[GitHub] [kafka] Hangleton commented on a diff in pull request #13240: KAFKA-14690: Add topic IDs to OffsetCommit API and propagate for request version >= 9

Hangleton commented on code in PR #13240: URL: https://github.com/apache/kafka/pull/13240#discussion_r1124559198 ## clients/src/main/java/org/apache/kafka/common/requests/OffsetCommitResponse.java: ## @@ -167,8 +213,24 @@ public Builder addPartitions( }

[GitHub] [kafka] Hangleton commented on a diff in pull request #13240: KAFKA-14690: Add topic IDs to OffsetCommit API and propagate for request version >= 9

Hangleton commented on code in PR #13240: URL: https://github.com/apache/kafka/pull/13240#discussion_r1124559198 ## clients/src/main/java/org/apache/kafka/common/requests/OffsetCommitResponse.java: ## @@ -167,8 +213,24 @@ public Builder addPartitions( }

[jira] [Created] (KAFKA-14776) Update SCRAM system tests to run with KRaft

Proven Provenzano created KAFKA-14776: - Summary: Update SCRAM system tests to run with KRaft Key: KAFKA-14776 URL: https://issues.apache.org/jira/browse/KAFKA-14776 Project: Kafka Issue

[GitHub] [kafka] Hangleton commented on pull request #13240: KAFKA-14690: Add topic IDs to OffsetCommit API and propagate for request version >= 9

Hangleton commented on PR #13240: URL: https://github.com/apache/kafka/pull/13240#issuecomment-1453619279 Used v8 for AlterConsumerGroupOffsets in the admin client and added corresponding unit and integration tests. `MirrorConnectorsIntegrationBaseTest` is now successful. -- This is an

[jira] [Created] (KAFKA-14775) Support SCRAM for broker to controller authentication

Proven Provenzano created KAFKA-14775: - Summary: Support SCRAM for broker to controller authentication Key: KAFKA-14775 URL: https://issues.apache.org/jira/browse/KAFKA-14775 Project: Kafka

[GitHub] [kafka] edoardocomar commented on pull request #13113: KAFKA-5238: BrokerTopicMetrics can be recreated after topic is deleted

edoardocomar commented on PR #13113: URL: https://github.com/apache/kafka/pull/13113#issuecomment-1453510691 bump @mimaison @rajinisivaram @tombentley @ijuma -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [kafka] Hangleton commented on pull request #13240: KAFKA-14690: Add topic IDs to OffsetCommit API and propagate for request version >= 9

Hangleton commented on PR #13240: URL: https://github.com/apache/kafka/pull/13240#issuecomment-1453452130 The integration test `MirrorConnectorsIntegrationBaseTest` is failing due to unknown topic id detected from the admin client. I am looking into it. -- This is an automated message

[jira] [Resolved] (KAFKA-14745) MirrorSourceConnector keeps creating ReplicationPolicy instances

[ https://issues.apache.org/jira/browse/KAFKA-14745?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mickael Maison resolved KAFKA-14745. Fix Version/s: 3.5.0 Resolution: Fixed > MirrorSourceConnector keeps creating

[GitHub] [kafka] mimaison merged pull request #13328: KAFKA-14745: Cache the ReplicationPolicy instance in MirrorConnectorC…

mimaison merged PR #13328: URL: https://github.com/apache/kafka/pull/13328 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] mimaison commented on pull request #13328: KAFKA-14745: Cache the ReplicationPolicy instance in MirrorConnectorC…

mimaison commented on PR #13328: URL: https://github.com/apache/kafka/pull/13328#issuecomment-1453366283 None of the test failures are related to this change, all tests pass locally so merging to trunk. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kafka] lucasbru commented on pull request #13318: KAFKA-14533: Do not interrupt state-updater thread during shutdown

lucasbru commented on PR #13318: URL: https://github.com/apache/kafka/pull/13318#issuecomment-1453303374 We had a failure of `Build / JDK 11 and Scala 2.13 / org.apache.kafka.streams.integration.PauseResumeIntegrationTest.[1] true`. I'm pretty sure that one was not flaky before. Any chance

[GitHub] [kafka] lucasbru commented on pull request #13336: MINOR: update RocksDBMetricsRecorder test to JUnit5 and fix memory leak

lucasbru commented on PR #13336: URL: https://github.com/apache/kafka/pull/13336#issuecomment-1453283942 @cadonna Could you have a look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] lucasbru opened a new pull request, #13336: MINOR: update RocksDBMetricsRecorder test to JUnit5 and fix memory leak

lucasbru opened a new pull request, #13336: URL: https://github.com/apache/kafka/pull/13336 The test was leaking memory via Mockito internals. Piggybacking an update to JUnit5. ### Test strategy Ran the tests 10,000 times. Before:

[GitHub] [kafka] urbandan commented on pull request #10566: KAFKA-12694 Avoid schema mismatch DataException when validating default values

urbandan commented on PR #10566: URL: https://github.com/apache/kafka/pull/10566#issuecomment-1453223698 @C0urante Yes, you are right about the short-circuit, but it is caused by the defaultValue ref equals. Which means that my previous code works with your latest proposal, but this one

[GitHub] [kafka] chia7712 commented on a diff in pull request #13327: MINOR: tweak the doc of "num.network.threads"

chia7712 commented on code in PR #13327: URL: https://github.com/apache/kafka/pull/13327#discussion_r1124201822 ## core/src/main/scala/kafka/server/KafkaConfig.scala: ## @@ -678,7 +678,7 @@ object KafkaConfig { "start from " + MaxReservedBrokerIdProp + " + 1." val

[jira] [Comment Edited] (KAFKA-14768) proposal to reduce the first message's send time cost and max block time for safety

[ https://issues.apache.org/jira/browse/KAFKA-14768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17696089#comment-17696089 ] fujian edited comment on KAFKA-14768 at 3/3/23 9:13 AM: Hi  [~showuon]: I

[GitHub] [kafka] jiafu1115 commented on pull request #13335: KAFKA-14768: add new configure to reduce the max.block.ms safely

jiafu1115 commented on PR #13335: URL: https://github.com/apache/kafka/pull/13335#issuecomment-1453191584 @showuon here is the another proposal to solve part of the issues. thanks for your comment about this proposal. -- This is an automated message from the Apache Git Service. To

[jira] [Comment Edited] (KAFKA-14768) proposal to reduce the first message's send time cost and max block time for safety

[ https://issues.apache.org/jira/browse/KAFKA-14768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17695956#comment-17695956 ] fujian edited comment on KAFKA-14768 at 3/3/23 8:56 AM: Hi  [~showuon]  Thanks

[jira] [Commented] (KAFKA-14768) proposal to reduce the first message's send time cost and max block time for safety

[ https://issues.apache.org/jira/browse/KAFKA-14768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17696089#comment-17696089 ] fujian commented on KAFKA-14768: Hi  [~showuon]: I create another PR : [KAFKA-14768: add new configure

[GitHub] [kafka] jiafu1115 opened a new pull request, #13335: KAFKA-14768: add new configure to reduce the max.block.ms safely

jiafu1115 opened a new pull request, #13335: URL: https://github.com/apache/kafka/pull/13335 Hi Team: https://issues.apache.org/jira/projects/KAFKA/issues/KAFKA-14768 This PR is draft one which adopt the proposal 2 which solve the issue 2 which I mentioned in the JIRA (2)

[GitHub] [kafka] pierDipi commented on pull request #13325: KAFKA-14771: Include threads info in ConcurrentModificationException message

pierDipi commented on PR #13325: URL: https://github.com/apache/kafka/pull/13325#issuecomment-1453176497 It seems that test failures are not related -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka] vcrfxia commented on a diff in pull request #13274: KAFKA-14491: [13/N] Add versioned store builder and materializer

vcrfxia commented on code in PR #13274: URL: https://github.com/apache/kafka/pull/13274#discussion_r1124151220 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/KeyValueStoreMaterializer.java: ## @@ -48,20 +55,30 @@ public StoreBuilder> materialize() {