satishd commented on PR #13309:
URL: https://github.com/apache/kafka/pull/13309#issuecomment-1455007789
> @satishd How is this related to moving `LogSegment`? It doesn't seem like
that was updated at all?
Methods like the below have usages in `LogSegment` class. Those will be
[
https://issues.apache.org/jira/browse/KAFKA-14754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17696530#comment-17696530
]
Philip Nee commented on KAFKA-14754:
Hey [~showuon] - for #1 - perhaps you mean by there no
philipnee commented on code in PR #13303:
URL: https://github.com/apache/kafka/pull/13303#discussion_r1125607022
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/PrototypeAsyncConsumer.java:
##
@@ -226,11 +246,20 @@ public void
philipnee commented on code in PR #13303:
URL: https://github.com/apache/kafka/pull/13303#discussion_r1125606614
##
core/src/test/scala/integration/kafka/api/PlaintextConsumerTest.scala:
##
@@ -993,7 +993,7 @@ class PlaintextConsumerTest extends BaseConsumerTest {
//
philipnee commented on code in PR #13303:
URL: https://github.com/apache/kafka/pull/13303#discussion_r1125606496
##
core/src/test/scala/integration/kafka/api/AbstractConsumerTest.scala:
##
@@ -97,7 +97,7 @@ abstract class AbstractConsumerTest extends BaseRequestTest {
}
ijuma merged PR #13339:
URL: https://github.com/apache/kafka/pull/13339
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
ijuma commented on PR #13312:
URL: https://github.com/apache/kafka/pull/13312#issuecomment-1454952744
@divijvaidya The following is also interesting
https://github.com/astei/varint-writing-showdown/issues/1
--
This is an automated message from the Apache Git Service.
To respond to the
[
https://issues.apache.org/jira/browse/KAFKA-14059?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Hector Geraldino reassigned KAFKA-14059:
Assignee: Hector Geraldino
> Replace EasyMock and PowerMock with Mockito in
ijuma commented on PR #13309:
URL: https://github.com/apache/kafka/pull/13309#issuecomment-1454850372
@satishd How is this related to moving `LogSegment`? It doesn't seem like
that was updated at all?
--
This is an automated message from the Apache Git Service.
To respond to the message,
ijuma commented on PR #13309:
URL: https://github.com/apache/kafka/pull/13309#issuecomment-1454850030
I didn't see this until now. I actually think the right approach is to push
some of these methods to the respective classes (eg if it's related to an
index, the method should be in the
dejan2609 commented on PR #13339:
URL: https://github.com/apache/kafka/pull/13339#issuecomment-1454847422
And i was just about to push the same change :) You got me while I was
testing it.
--
This is an automated message from the Apache Git Service.
To respond to the
ijuma commented on PR #13339:
URL: https://github.com/apache/kafka/pull/13339#issuecomment-1454845324
I pushed a commit that removes the gradle workaround that is no longer
necessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
dajac commented on code in PR #13240:
URL: https://github.com/apache/kafka/pull/13240#discussion_r1125501983
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java:
##
@@ -1328,13 +1335,16 @@ RequestFuture sendOffsetCommitRequest(final
dajac commented on PR #13240:
URL: https://github.com/apache/kafka/pull/13240#issuecomment-1454803355
I think that we have to do 2) anyway because topic ids may not be enabled on
the server side.
--
This is an automated message from the Apache Git Service.
To respond to the message,
[
https://issues.apache.org/jira/browse/KAFKA-13882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17696454#comment-17696454
]
ASF GitHub Bot commented on KAFKA-13882:
lucasbru commented on PR #410:
URL:
[
https://issues.apache.org/jira/browse/KAFKA-13882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17696443#comment-17696443
]
ASF GitHub Bot commented on KAFKA-13882:
qingwei91 commented on PR #410:
URL:
Hangleton commented on PR #13240:
URL: https://github.com/apache/kafka/pull/13240#issuecomment-1454676488
Hello David, found a case where the use of OffsetCommit requests version 9
from the consumer resulted in an error in the ACL authorization tests. The
reason is that when the commit
17 matches
Mail list logo
