ivanyu commented on code in PR #13067:
URL: https://github.com/apache/kafka/pull/13067#discussion_r1127463069
##
server-common/src/main/java/org/apache/kafka/server/metrics/KafkaMetricsGroup.java:
##
@@ -0,0 +1,161 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
ivanyu commented on PR #13067:
URL: https://github.com/apache/kafka/pull/13067#issuecomment-1457689418
Thank you @satishd! I addressed your last comment.
> Please have incremental commits instead of a single squashed/merged
commit. This is helpful for reviewers to review the
melin created KAFKA-14787:
-
Summary: Supports reading ssl certificate files from hdfs
Key: KAFKA-14787
URL: https://issues.apache.org/jira/browse/KAFKA-14787
Project: Kafka
Issue Type: Bug
vcrfxia commented on code in PR #13340:
URL: https://github.com/apache/kafka/pull/13340#discussion_r1127290672
##
streams/src/test/java/org/apache/kafka/streams/integration/VersionedKeyValueStoreIntegrationTest.java:
##
@@ -0,0 +1,592 @@
+/*
+ * Licensed to the Apache Software
vcrfxia commented on code in PR #13292:
URL: https://github.com/apache/kafka/pull/13292#discussion_r1127274296
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopologyBuilder.java:
##
@@ -1293,12 +1306,16 @@ private void
vcrfxia commented on code in PR #13292:
URL: https://github.com/apache/kafka/pull/13292#discussion_r1127273827
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopologyBuilder.java:
##
@@ -1293,12 +1306,16 @@ private void
[
https://issues.apache.org/jira/browse/KAFKA-14371?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
José Armando García Sancio updated KAFKA-14371:
---
Fix Version/s: (was: 3.5.0)
> quorum-state file contains
[
https://issues.apache.org/jira/browse/KAFKA-14371?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
José Armando García Sancio reopened KAFKA-14371:
Assignee: (was: Gantigmaa Selenge)
> quorum-state file
jsancio merged PR #13355:
URL: https://github.com/apache/kafka/pull/13355
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
philipnee commented on code in PR #13303:
URL: https://github.com/apache/kafka/pull/13303#discussion_r1127264709
##
core/src/test/scala/integration/kafka/api/BaseAsyncConsumerTest.scala:
##
@@ -0,0 +1,37 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
philipnee commented on code in PR #13303:
URL: https://github.com/apache/kafka/pull/13303#discussion_r1127257845
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/PrototypeAsyncConsumerTest.java:
##
@@ -16,90 +16,77 @@
*/
package
philipnee commented on code in PR #13303:
URL: https://github.com/apache/kafka/pull/13303#discussion_r1127256908
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/PrototypeAsyncConsumer.java:
##
@@ -226,11 +246,20 @@ public void
philipnee commented on code in PR #13303:
URL: https://github.com/apache/kafka/pull/13303#discussion_r1127253922
##
core/src/test/scala/integration/kafka/api/BaseAsyncConsumerTest.scala:
##
@@ -0,0 +1,37 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
philipnee commented on code in PR #13303:
URL: https://github.com/apache/kafka/pull/13303#discussion_r1127253699
##
core/src/test/scala/integration/kafka/api/BaseAsyncConsumerTest.scala:
##
@@ -0,0 +1,37 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
philipnee commented on PR #13303:
URL: https://github.com/apache/kafka/pull/13303#issuecomment-1457356989
re. @guozhangwang - sorry, I think originally I added 2 tests, then I
reduced to 1. Thanks for catching this.
For testing poll() - The fetcher isn't available but I could try to
philipnee commented on code in PR #13303:
URL: https://github.com/apache/kafka/pull/13303#discussion_r1127252457
##
core/src/test/scala/integration/kafka/api/BaseAsyncConsumerTest.scala:
##
@@ -0,0 +1,37 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
philipnee commented on code in PR #13303:
URL: https://github.com/apache/kafka/pull/13303#discussion_r1127251663
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/PrototypeAsyncConsumerTest.java:
##
@@ -16,90 +16,77 @@
*/
package
philipnee commented on code in PR #13303:
URL: https://github.com/apache/kafka/pull/13303#discussion_r1127250227
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/PrototypeAsyncConsumerTest.java:
##
@@ -16,90 +16,77 @@
*/
package
mjsax commented on code in PR #13292:
URL: https://github.com/apache/kafka/pull/13292#discussion_r1127245620
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopologyBuilder.java:
##
@@ -1293,12 +1306,16 @@ private void
jsancio commented on code in PR #13355:
URL: https://github.com/apache/kafka/pull/13355#discussion_r1127245225
##
raft/src/main/resources/common/message/QuorumStateData.json:
##
@@ -16,10 +16,10 @@
{
"type": "data",
"name": "QuorumStateData",
- // Version 1 removes
jsancio commented on code in PR #13355:
URL: https://github.com/apache/kafka/pull/13355#discussion_r1127237201
##
raft/src/main/resources/common/message/QuorumStateData.json:
##
@@ -16,10 +16,10 @@
{
"type": "data",
"name": "QuorumStateData",
- // Version 1 removes
showuon commented on code in PR #13355:
URL: https://github.com/apache/kafka/pull/13355#discussion_r1127240280
##
raft/src/main/resources/common/message/QuorumStateData.json:
##
@@ -16,10 +16,10 @@
{
"type": "data",
"name": "QuorumStateData",
- // Version 1 removes
showuon commented on code in PR #13355:
URL: https://github.com/apache/kafka/pull/13355#discussion_r1127240280
##
raft/src/main/resources/common/message/QuorumStateData.json:
##
@@ -16,10 +16,10 @@
{
"type": "data",
"name": "QuorumStateData",
- // Version 1 removes
showuon commented on code in PR #13355:
URL: https://github.com/apache/kafka/pull/13355#discussion_r1127240280
##
raft/src/main/resources/common/message/QuorumStateData.json:
##
@@ -16,10 +16,10 @@
{
"type": "data",
"name": "QuorumStateData",
- // Version 1 removes
jsancio commented on code in PR #13355:
URL: https://github.com/apache/kafka/pull/13355#discussion_r1127237201
##
raft/src/main/resources/common/message/QuorumStateData.json:
##
@@ -16,10 +16,10 @@
{
"type": "data",
"name": "QuorumStateData",
- // Version 1 removes
mjsax merged PR #13274:
URL: https://github.com/apache/kafka/pull/13274
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
satishd commented on PR #13067:
URL: https://github.com/apache/kafka/pull/13067#issuecomment-1457307583
@ivanyu Please have incremental commits instead of a single squashed/merged
commit. This is helpful for reviewers to review the incremental changes done in
the PR that address the review
showuon commented on PR #13102:
URL: https://github.com/apache/kafka/pull/13102#issuecomment-1457302953
Nice catch @jsancio !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
satishd commented on code in PR #13067:
URL: https://github.com/apache/kafka/pull/13067#discussion_r1127226556
##
server-common/src/main/java/org/apache/kafka/server/metrics/KafkaMetricsGroup.java:
##
@@ -0,0 +1,161 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
satishd commented on code in PR #13067:
URL: https://github.com/apache/kafka/pull/13067#discussion_r1127222852
##
server-common/src/main/java/org/apache/kafka/server/metrics/KafkaMetricsGroup.java:
##
@@ -0,0 +1,161 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
gharris1727 opened a new pull request, #13356:
URL: https://github.com/apache/kafka/pull/13356
This will allow classpath ConfigProvider and ConnectRestExtension to appear
in ServiceLoader results from within plugins, without discovering them as
isolated plugins
*More detailed
ijuma commented on code in PR #13116:
URL: https://github.com/apache/kafka/pull/13116#discussion_r1127213105
##
core/src/test/scala/unit/kafka/utils/TestUtils.scala:
##
@@ -378,6 +378,118 @@ object TestUtils extends Logging {
props
}
+ def
cmccabe commented on code in PR #13355:
URL: https://github.com/apache/kafka/pull/13355#discussion_r1127208396
##
raft/src/main/resources/common/message/QuorumStateData.json:
##
@@ -16,10 +16,10 @@
{
"type": "data",
"name": "QuorumStateData",
- // Version 1 removes
cmccabe commented on code in PR #13355:
URL: https://github.com/apache/kafka/pull/13355#discussion_r1127208396
##
raft/src/main/resources/common/message/QuorumStateData.json:
##
@@ -16,10 +16,10 @@
{
"type": "data",
"name": "QuorumStateData",
- // Version 1 removes
cmccabe commented on PR #13116:
URL: https://github.com/apache/kafka/pull/13116#issuecomment-1457277048
Thanks for the PR, @rondagostino . You've been very patient here and I'm
sorry that the review wasn't quicker. We did a major pivot from implementing
the quota in `ControllerApis` like I
kirktrue commented on code in PR #12813:
URL: https://github.com/apache/kafka/pull/12813#discussion_r1127204081
##
clients/src/main/java/org/apache/kafka/clients/NetworkClient.java:
##
@@ -324,11 +324,14 @@ public void disconnect(String nodeId) {
log.info("Client
cmccabe commented on code in PR #13116:
URL: https://github.com/apache/kafka/pull/13116#discussion_r1127197623
##
metadata/src/main/java/org/apache/kafka/controller/ControllerRequestContext.java:
##
@@ -42,19 +45,39 @@ public static OptionalLong requestTimeoutMsToDeadlineNs(
cmccabe commented on code in PR #13116:
URL: https://github.com/apache/kafka/pull/13116#discussion_r1127191979
##
core/src/test/scala/unit/kafka/utils/TestUtils.scala:
##
@@ -378,6 +378,118 @@ object TestUtils extends Logging {
props
}
+ def
cmccabe commented on code in PR #13116:
URL: https://github.com/apache/kafka/pull/13116#discussion_r1127191300
##
core/src/test/scala/unit/kafka/utils/TestUtils.scala:
##
@@ -378,6 +378,118 @@ object TestUtils extends Logging {
props
}
+ def
cmccabe commented on code in PR #13116:
URL: https://github.com/apache/kafka/pull/13116#discussion_r1127191300
##
core/src/test/scala/unit/kafka/utils/TestUtils.scala:
##
@@ -378,6 +378,118 @@ object TestUtils extends Logging {
props
}
+ def
guozhangwang commented on code in PR #13303:
URL: https://github.com/apache/kafka/pull/13303#discussion_r1127185285
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/NetworkClientDelegate.java:
##
@@ -213,7 +215,7 @@ public UnsentRequest(
cmccabe commented on code in PR #13116:
URL: https://github.com/apache/kafka/pull/13116#discussion_r1127186242
##
core/src/test/scala/unit/kafka/server/DynamicBrokerConfigTest.scala:
##
@@ -479,6 +489,42 @@ class DynamicBrokerConfigTest {
assertEquals("User:admin",
cmccabe commented on code in PR #13116:
URL: https://github.com/apache/kafka/pull/13116#discussion_r1127186242
##
core/src/test/scala/unit/kafka/server/DynamicBrokerConfigTest.scala:
##
@@ -479,6 +489,42 @@ class DynamicBrokerConfigTest {
assertEquals("User:admin",
cmccabe commented on code in PR #13116:
URL: https://github.com/apache/kafka/pull/13116#discussion_r1127182652
##
core/src/main/scala/kafka/server/metadata/DynamicClientQuotaPublisher.scala:
##
@@ -0,0 +1,82 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
[
https://issues.apache.org/jira/browse/KAFKA-14778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17697181#comment-17697181
]
Matthias J. Sax commented on KAFKA-14778:
-
Thanks for reporting this. – I believe the issue is
cmccabe commented on code in PR #13116:
URL: https://github.com/apache/kafka/pull/13116#discussion_r1127176224
##
core/src/main/scala/kafka/server/DynamicBrokerConfig.scala:
##
@@ -730,6 +744,45 @@ class DynamicThreadPool(server: KafkaBroker) extends
BrokerReconfigurable {
cmccabe commented on code in PR #13116:
URL: https://github.com/apache/kafka/pull/13116#discussion_r1127176972
##
core/src/main/scala/kafka/server/DynamicBrokerConfig.scala:
##
@@ -911,7 +954,22 @@ object DynamicListenerConfig {
)
}
-class
cmccabe commented on code in PR #13116:
URL: https://github.com/apache/kafka/pull/13116#discussion_r1127179616
##
core/src/test/java/kafka/test/MockController.java:
##
@@ -181,10 +194,16 @@ public CompletableFuture unregisterBroker(
static class MockTopic {
cmccabe commented on code in PR #13116:
URL: https://github.com/apache/kafka/pull/13116#discussion_r1127176972
##
core/src/main/scala/kafka/server/DynamicBrokerConfig.scala:
##
@@ -911,7 +954,22 @@ object DynamicListenerConfig {
)
}
-class
cmccabe commented on code in PR #13116:
URL: https://github.com/apache/kafka/pull/13116#discussion_r1127176224
##
core/src/main/scala/kafka/server/DynamicBrokerConfig.scala:
##
@@ -730,6 +744,45 @@ class DynamicThreadPool(server: KafkaBroker) extends
BrokerReconfigurable {
[
https://issues.apache.org/jira/browse/KAFKA-14722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-14722:
Description:
KIP-907:
[
https://issues.apache.org/jira/browse/KAFKA-14722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-14722:
Labels: beginner kip newbie (was: beginner need-kip newbie)
> Make BooleanSerde public
>
[
https://issues.apache.org/jira/browse/KAFKA-12446?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-12446:
Description:
KIP-904:
[
https://issues.apache.org/jira/browse/KAFKA-12446?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-12446:
Labels: kip (was: )
> Define KGroupedTable#aggregate subtractor + adder order of
[
https://issues.apache.org/jira/browse/KAFKA-13882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17697175#comment-17697175
]
ASF GitHub Bot commented on KAFKA-13882:
mjsax commented on PR #410:
URL:
[
https://issues.apache.org/jira/browse/KAFKA-14748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17697167#comment-17697167
]
Guozhang Wang commented on KAFKA-14748:
---
Cool! We are on the same page for the first question
[
https://issues.apache.org/jira/browse/KAFKA-14371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17697165#comment-17697165
]
José Armando García Sancio commented on KAFKA-14371:
Even though the KRaft logic
[
https://issues.apache.org/jira/browse/KAFKA-14371?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
José Armando García Sancio updated KAFKA-14371:
---
Labels: needs-kip (was: )
> quorum-state file contains
jsancio commented on PR #13355:
URL: https://github.com/apache/kafka/pull/13355#issuecomment-1457165155
This PR reverts https://github.com/apache/kafka/pull/13102
Reason for the revert is documented here:
https://github.com/apache/kafka/pull/13102#issuecomment-1457138403
--
This
jsancio opened a new pull request, #13355:
URL: https://github.com/apache/kafka/pull/13355
This reverts commit 0927049a617fa2937a211aab895f6590403130fb.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and
jsancio commented on PR #13102:
URL: https://github.com/apache/kafka/pull/13102#issuecomment-1457138403
I was thinking about this change today and realized that this change is not
backwards compatible. For example, the user upgrades the cluster and then they
downgrade the cluster, it will
[
https://issues.apache.org/jira/browse/KAFKA-13882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17697160#comment-17697160
]
ASF GitHub Bot commented on KAFKA-13882:
qingwei91 commented on PR #410:
URL:
Chris Egerton created KAFKA-14786:
-
Summary: Implement connector offset write/reset internal logic
Key: KAFKA-14786
URL: https://issues.apache.org/jira/browse/KAFKA-14786
Project: Kafka
Chris Egerton created KAFKA-14784:
-
Summary: Implement connector offset reset REST API
Key: KAFKA-14784
URL: https://issues.apache.org/jira/browse/KAFKA-14784
Project: Kafka
Issue Type:
Chris Egerton created KAFKA-14785:
-
Summary: Implement connector offset read REST API
Key: KAFKA-14785
URL: https://issues.apache.org/jira/browse/KAFKA-14785
Project: Kafka
Issue Type:
[
https://issues.apache.org/jira/browse/KAFKA-14368?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Egerton updated KAFKA-14368:
--
Component/s: KafkaConnect
> Implement connector offset write REST API
>
[
https://issues.apache.org/jira/browse/KAFKA-14368?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Egerton updated KAFKA-14368:
--
Summary: Implement connector offset write REST API (was: Add an offset
write REST API to
[
https://issues.apache.org/jira/browse/KAFKA-14368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17697157#comment-17697157
]
Chris Egerton commented on KAFKA-14368:
---
[~yash.mayya] Given the updates to KIP-875, I've
[
https://issues.apache.org/jira/browse/KAFKA-14368?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Egerton updated KAFKA-14368:
--
Labels: (was: kip-required)
> Add an offset write REST API to Kafka Connect
>
[
https://issues.apache.org/jira/browse/KAFKA-14368?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Egerton updated KAFKA-14368:
--
Description: Implement the {{PATCH /connectors/name/offsets}} endpoint
[described in
Chris Egerton created KAFKA-14783:
-
Summary: Implement new STOPPED state for connectors
Key: KAFKA-14783
URL: https://issues.apache.org/jira/browse/KAFKA-14783
Project: Kafka
Issue Type:
[
https://issues.apache.org/jira/browse/KAFKA-14783?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Egerton updated KAFKA-14783:
--
Parent: KAFKA-4107
Issue Type: Sub-task (was: Task)
> Implement new STOPPED state
[
https://issues.apache.org/jira/browse/KAFKA-14368?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Egerton updated KAFKA-14368:
--
Parent: KAFKA-4107
Issue Type: Sub-task (was: New Feature)
> Add an offset write
philipnee opened a new pull request, #13354:
URL: https://github.com/apache/kafka/pull/13354
The current kafka producer example needs a bit of improvement, in particular:
1. documentation is lacking
2. it is not closing correctly
3. Code can be cleaner
--
This is an automated
philipnee commented on PR #13353:
URL: https://github.com/apache/kafka/pull/13353#issuecomment-1457033568
This is the snippet of the log:
```
Subscribe to:topic1
...
Assigning partitions:[topic1-0]
...
DemoConsumer finished reading 1 messages
Revoking
philipnee opened a new pull request, #13353:
URL: https://github.com/apache/kafka/pull/13353
The changes include:
1. Documentation changes
2. Closing mechanism
3. Adding a rebalance listener (to print partition changes when rebalance is
happening)
4. Fixing a few errors
cc
philipnee commented on PR #13303:
URL: https://github.com/apache/kafka/pull/13303#issuecomment-1457022169
Thanks for reviewing this, @rajinisivaram - fixes are on the way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
philipnee commented on code in PR #13303:
URL: https://github.com/apache/kafka/pull/13303#discussion_r1127046532
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/PrototypeAsyncConsumer.java:
##
@@ -83,12 +92,23 @@
private final Metrics metrics;
philipnee commented on code in PR #13303:
URL: https://github.com/apache/kafka/pull/13303#discussion_r1127043244
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/PrototypeAsyncConsumer.java:
##
@@ -226,11 +246,20 @@ public void
rajinisivaram commented on code in PR #13303:
URL: https://github.com/apache/kafka/pull/13303#discussion_r1126983650
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/PrototypeAsyncConsumer.java:
##
@@ -83,12 +92,23 @@
private final Metrics metrics;
jolshan commented on code in PR #13323:
URL: https://github.com/apache/kafka/pull/13323#discussion_r1126944890
##
clients/src/main/java/org/apache/kafka/common/requests/FetchRequest.java:
##
@@ -337,8 +362,27 @@ public AbstractResponse getErrorResponse(int
throttleTimeMs,
jolshan commented on PR #13352:
URL: https://github.com/apache/kafka/pull/13352#issuecomment-1456837604
Let me know if you have any topic ID questions @Hangleton
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
jolshan commented on code in PR #13329:
URL: https://github.com/apache/kafka/pull/13329#discussion_r1126927374
##
core/src/main/scala/kafka/coordinator/group/GroupCoordinatorAdapter.scala:
##
@@ -62,6 +63,15 @@ private[group] class GroupCoordinatorAdapter(
private val time:
cmccabe merged PR #13331:
URL: https://github.com/apache/kafka/pull/13331
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
dajac commented on code in PR #13329:
URL: https://github.com/apache/kafka/pull/13329#discussion_r1126922151
##
core/src/main/scala/kafka/coordinator/group/GroupCoordinatorAdapter.scala:
##
@@ -62,6 +63,15 @@ private[group] class GroupCoordinatorAdapter(
private val time:
jolshan commented on code in PR #13329:
URL: https://github.com/apache/kafka/pull/13329#discussion_r1126921525
##
core/src/test/scala/unit/kafka/server/ConsumerGroupHeartbeatRequestTest.scala:
##
@@ -54,6 +54,20 @@ class ConsumerGroupHeartbeatRequestTest(cluster:
dajac commented on code in PR #13329:
URL: https://github.com/apache/kafka/pull/13329#discussion_r1126920827
##
core/src/main/scala/kafka/server/KafkaApis.scala:
##
@@ -3573,9 +3573,27 @@ class KafkaApis(val requestChannel: RequestChannel,
def
jolshan commented on code in PR #13329:
URL: https://github.com/apache/kafka/pull/13329#discussion_r1126919357
##
core/src/main/scala/kafka/coordinator/group/GroupCoordinatorAdapter.scala:
##
@@ -62,6 +63,15 @@ private[group] class GroupCoordinatorAdapter(
private val time:
[
https://issues.apache.org/jira/browse/KAFKA-13882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17697103#comment-17697103
]
ASF GitHub Bot commented on KAFKA-13882:
qingwei91 commented on PR #410:
URL:
Hangleton opened a new pull request, #13352:
URL: https://github.com/apache/kafka/pull/13352
WIP.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation
rondagostino commented on code in PR #13331:
URL: https://github.com/apache/kafka/pull/13331#discussion_r1126859142
##
core/src/main/scala/kafka/server/SharedServer.scala:
##
@@ -170,6 +170,17 @@ class SharedServer(
snapshotsDiabledReason.compareAndSet(null, "metadata
mimaison commented on PR #13157:
URL: https://github.com/apache/kafka/pull/13157#issuecomment-1456709095
Sorry for the delay. I _think_ you technically don't necessarily need to
have transitive dependencies in the classpath to compile a class. For example,
it is possible to build a custom
[
https://issues.apache.org/jira/browse/KAFKA-13882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17697070#comment-17697070
]
ASF GitHub Bot commented on KAFKA-13882:
mimaison commented on PR #410:
URL:
C0urante commented on PR #13351:
URL: https://github.com/apache/kafka/pull/13351#issuecomment-1456617781
@mimaison would you mind taking a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
C0urante opened a new pull request, #13351:
URL: https://github.com/apache/kafka/pull/13351
[Jira](https://issues.apache.org/jira/browse/KAFKA-14781)
Instead of logging an `ERROR`-level message when topic syncing is enabled
(which it is by default) and no ACL authorizer is configured
mimaison merged PR #13212:
URL: https://github.com/apache/kafka/pull/13212
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
mimaison merged PR #13215:
URL: https://github.com/apache/kafka/pull/13215
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
rajinisivaram opened a new pull request, #13350:
URL: https://github.com/apache/kafka/pull/13350
Best-effort rack alignment for sticky assignors when both consumer racks and
partition racks are available with the protocol changes introduced in KIP-881.
Rack-aware assignment is enabled by
[
https://issues.apache.org/jira/browse/KAFKA-14781?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Egerton reassigned KAFKA-14781:
-
Assignee: Chris Egerton
> MM2 logs misleading error during topic ACL sync when broker
rajinisivaram opened a new pull request, #13349:
URL: https://github.com/apache/kafka/pull/13349
This PR refactors AbstractStickyAssignor without changing any logic to make
it easier to add rack-awareness. The class currently consists of a lot of
collections that are passed around various
1 - 100 of 131 matches
Mail list logo
