[GitHub] [kafka] dajac merged pull request #13357: KAFKA-14462; [3/N] Add `onNewMetadataImage` to `GroupCoordinator` interface

dajac merged PR #13357: URL: https://github.com/apache/kafka/pull/13357 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] dajac commented on pull request #13357: KAFKA-14462; [3/N] Add `onNewMetadataImage` to `GroupCoordinator` interface

dajac commented on PR #13357: URL: https://github.com/apache/kafka/pull/13357#issuecomment-1459679650 > Sorry if I missed it somewhere/forgot, but is this saying we will only allow the new group coordinator for kraft? Or do we have an alternative for ZK? That's right. At the moment,

[GitHub] [kafka] dajac commented on a diff in pull request #13240: KAFKA-14690: Add topic IDs to the OffsetCommit API version 9

dajac commented on code in PR #13240: URL: https://github.com/apache/kafka/pull/13240#discussion_r1129066723 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java: ## @@ -1352,8 +1370,22 @@ public void handle(OffsetCommitResponse

[GitHub] [kafka] rohits64 opened a new pull request, #13361: KAFKA-14401: Resume WorkThread if Connector/Tasks reading offsets get stuck when underneath WorkThread dies

rohits64 opened a new pull request, #13361: URL: https://github.com/apache/kafka/pull/13361 Here WorkThread dies if any unexpected exception is encountered. Resumed the WorkThread by creating another thread and offset reading continues. Added test for this, although the test can be

[jira] [Commented] (KAFKA-14218) replace temp file handler with JUnit 5 Temporary Directory Support

[ https://issues.apache.org/jira/browse/KAFKA-14218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17697723#comment-17697723 ] Ganesh Sahu commented on KAFKA-14218: - Thanks [~showuon]  for the prompt reply > replace temp file

[jira] [Assigned] (KAFKA-4969) State-store workload-aware StreamsPartitionAssignor

[ https://issues.apache.org/jira/browse/KAFKA-4969?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax reassigned KAFKA-4969: -- Assignee: Bill Bejeck > State-store workload-aware StreamsPartitionAssignor >

[jira] [Commented] (KAFKA-14218) replace temp file handler with JUnit 5 Temporary Directory Support

[ https://issues.apache.org/jira/browse/KAFKA-14218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17697705#comment-17697705 ] Luke Chen commented on KAFKA-14218: --- No need to raise a KIP. You can start with some tests to see if

[jira] [Comment Edited] (KAFKA-14218) replace temp file handler with JUnit 5 Temporary Directory Support

[ https://issues.apache.org/jira/browse/KAFKA-14218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17697695#comment-17697695 ] Ganesh Sahu edited comment on KAFKA-14218 at 3/8/23 3:00 AM: - Greetings

[jira] [Commented] (KAFKA-14218) replace temp file handler with JUnit 5 Temporary Directory Support

[ https://issues.apache.org/jira/browse/KAFKA-14218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17697695#comment-17697695 ] Ganesh Sahu commented on KAFKA-14218: - Greetings team, as no specific members have been assigned yet

[jira] [Assigned] (KAFKA-14218) replace temp file handler with JUnit 5 Temporary Directory Support

[ https://issues.apache.org/jira/browse/KAFKA-14218?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ganesh Sahu reassigned KAFKA-14218: --- Assignee: Ganesh Sahu > replace temp file handler with JUnit 5 Temporary Directory Support

[GitHub] [kafka] kirktrue commented on a diff in pull request #12813: KAFKA-14317: ProduceRequest timeouts are logged as network exceptions

kirktrue commented on code in PR #12813: URL: https://github.com/apache/kafka/pull/12813#discussion_r1128855661 ## clients/src/main/java/org/apache/kafka/clients/NetworkClient.java: ## @@ -1279,9 +1283,10 @@ public ClientResponse completed(AbstractResponse response, long

[jira] [Reopened] (KAFKA-14752) improve kafka examples under examples package

[ https://issues.apache.org/jira/browse/KAFKA-14752?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Philip Nee reopened KAFKA-14752: > improve kafka examples under examples package > - > >

[jira] [Resolved] (KAFKA-14753) improve producer under example package

[ https://issues.apache.org/jira/browse/KAFKA-14753?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Philip Nee resolved KAFKA-14753. Resolution: Fixed > improve producer under example package >

[jira] [Resolved] (KAFKA-14754) improve consumer under example package

[ https://issues.apache.org/jira/browse/KAFKA-14754?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Philip Nee resolved KAFKA-14754. Resolution: Fixed > improve consumer under example package >

[jira] [Resolved] (KAFKA-14752) improve kafka examples under examples package

[ https://issues.apache.org/jira/browse/KAFKA-14752?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Philip Nee resolved KAFKA-14752. Resolution: Fixed > improve kafka examples under examples package >

[GitHub] [kafka] guozhangwang merged pull request #13354: KAFKA-14753: Improve kafka producer example

guozhangwang merged PR #13354: URL: https://github.com/apache/kafka/pull/13354 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] junrao commented on a diff in pull request #13275: KAFKA-14522 Rewrite/Move of RemoteIndexCache to storage module.

junrao commented on code in PR #13275: URL: https://github.com/apache/kafka/pull/13275#discussion_r1128778509 ## storage/src/main/java/org/apache/kafka/storage/internals/log/RemoteIndexCache.java: ## @@ -0,0 +1,399 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] guozhangwang merged pull request #13353: KAFKA-14752: Improving the existing consumer examples

guozhangwang merged PR #13353: URL: https://github.com/apache/kafka/pull/13353 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] guozhangwang commented on a diff in pull request #13300: KAFKA-10199: Add task updater metrics, part 2

guozhangwang commented on code in PR #13300: URL: https://github.com/apache/kafka/pull/13300#discussion_r1128785406 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/StoreChangelogReader.java: ## @@ -986,6 +987,11 @@ private void prepareChangelogs(final Set

[GitHub] [kafka] guozhangwang commented on a diff in pull request #13300: KAFKA-10199: Add task updater metrics, part 2

guozhangwang commented on code in PR #13300: URL: https://github.com/apache/kafka/pull/13300#discussion_r1128784726 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/StoreChangelogReader.java: ## @@ -457,15 +457,9 @@ public long restore(final Map tasks) {

[GitHub] [kafka] guozhangwang commented on a diff in pull request #13300: KAFKA-10199: Add task updater metrics, part 2

guozhangwang commented on code in PR #13300: URL: https://github.com/apache/kafka/pull/13300#discussion_r1128784269 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/StoreChangelogReader.java: ## @@ -986,6 +987,11 @@ private void prepareChangelogs(final Set

[GitHub] [kafka] guozhangwang merged pull request #13303: KAFKA-14761 Adding integration test for the prototype consumer

guozhangwang merged PR #13303: URL: https://github.com/apache/kafka/pull/13303 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] guozhangwang commented on a diff in pull request #13303: KAFKA-14761 Adding integration test for the prototype consumer

guozhangwang commented on code in PR #13303: URL: https://github.com/apache/kafka/pull/13303#discussion_r1128780569 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/PrototypeAsyncConsumer.java: ## @@ -83,12 +92,23 @@ private final Metrics metrics;

[GitHub] [kafka] guozhangwang commented on pull request #13303: KAFKA-14761 Adding integration test for the prototype consumer

guozhangwang commented on PR #13303: URL: https://github.com/apache/kafka/pull/13303#issuecomment-1459067328 > @guozhangwang - Regarding testing the commit results, can we defer this to the subsequent PR, i.e. verify it once committed() is implemented. SGTM. -- This is an

[GitHub] [kafka] guozhangwang commented on a diff in pull request #13318: KAFKA-14533: Do not interrupt state-updater thread during shutdown

guozhangwang commented on code in PR #13318: URL: https://github.com/apache/kafka/pull/13318#discussion_r1128773556 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/RackAwarenessStreamsPartitionAssignorTest.java: ## @@ -169,26 +166,6 @@ private void

[jira] [Resolved] (KAFKA-14792) Race condition in LazyIndex.get()

[ https://issues.apache.org/jira/browse/KAFKA-14792?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma resolved KAFKA-14792. - Fix Version/s: 3.5.0 Resolution: Fixed > Race condition in LazyIndex.get() >

[GitHub] [kafka] ijuma merged pull request #13359: KAFKA-14792: Race condition in LazyIndex.get()

ijuma merged PR #13359: URL: https://github.com/apache/kafka/pull/13359 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] ijuma commented on pull request #13359: KAFKA-14792: Race condition in LazyIndex.get()

ijuma commented on PR #13359: URL: https://github.com/apache/kafka/pull/13359#issuecomment-1459049434 2 builds passed, 1 failed with 2 unrelated tests: > Build / JDK 17 and Scala 2.13 /

[GitHub] [kafka] CalvinConfluent commented on pull request #13323: KAFKA-14617 Add ReplicaState to FetchRequest.

CalvinConfluent commented on PR #13323: URL: https://github.com/apache/kafka/pull/13323#issuecomment-1459027103 Changing the old ReplicaId field default value to -1. In this way, we can easily extract the replicaId from the FetchRequest without knowing the API version. Simple and minimal

[GitHub] [kafka] CalvinConfluent commented on a diff in pull request #13323: KAFKA-14617 Add ReplicaState to FetchRequest.

CalvinConfluent commented on code in PR #13323: URL: https://github.com/apache/kafka/pull/13323#discussion_r1128713441 ## clients/src/main/java/org/apache/kafka/common/requests/FetchRequest.java: ## @@ -337,8 +362,27 @@ public AbstractResponse getErrorResponse(int

[GitHub] [kafka] CalvinConfluent commented on a diff in pull request #13323: KAFKA-14617 Add ReplicaState to FetchRequest.

CalvinConfluent commented on code in PR #13323: URL: https://github.com/apache/kafka/pull/13323#discussion_r1128713021 ## clients/src/main/java/org/apache/kafka/common/requests/FetchRequest.java: ## @@ -302,6 +315,18 @@ public String toString() { } } +public

[GitHub] [kafka] CalvinConfluent commented on a diff in pull request #13323: KAFKA-14617 Add ReplicaState to FetchRequest.

CalvinConfluent commented on code in PR #13323: URL: https://github.com/apache/kafka/pull/13323#discussion_r1128712574 ## raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java: ## @@ -936,13 +937,13 @@ private CompletableFuture handleFetchRequest(

[GitHub] [kafka] jolshan commented on a diff in pull request #13357: KAFKA-14462; [3/N] Add `onNewMetadataImage` to `GroupCoordinator` interface

jolshan commented on code in PR #13357: URL: https://github.com/apache/kafka/pull/13357#discussion_r1128706720 ## core/src/main/scala/kafka/server/metadata/BrokerMetadataPublisher.scala: ## @@ -271,19 +271,28 @@ class BrokerMetadataPublisher( }) }

[GitHub] [kafka] jolshan commented on pull request #13357: KAFKA-14462; [3/N] Add `onNewMetadataImage` to `GroupCoordinator` interface

jolshan commented on PR #13357: URL: https://github.com/apache/kafka/pull/13357#issuecomment-1458991438 Sorry if I missed it somewhere/forgot, but is this saying we will only allow the new group coordinator for kraft? Or do we have an alternative for ZK? -- This is an automated message

[GitHub] [kafka] cmccabe opened a new pull request, #13360: MINOR: fix authorizer reconfiguration in KRaft mode

cmccabe opened a new pull request, #13360: URL: https://github.com/apache/kafka/pull/13360 Fix a bug with authorizer reconfiguration in KRaft mode. The bug happened because we were invoking DynamicBrokerConfig.addReconfigurables before initializing BrokerServer.authorizer. Add a test of

[GitHub] [kafka] mumrah commented on a diff in pull request #13337: MINOR: Refactor the MetadataPublisher interface

mumrah commented on code in PR #13337: URL: https://github.com/apache/kafka/pull/13337#discussion_r1128359363 ## core/src/main/scala/kafka/server/metadata/BrokerMetadataPublisher.scala: ## @@ -213,7 +213,7 @@ class BrokerMetadataPublisher( } // Apply

[GitHub] [kafka] philipnee commented on pull request #13303: KAFKA-14761 Adding integration test for the prototype consumer

philipnee commented on PR #13303: URL: https://github.com/apache/kafka/pull/13303#issuecomment-1458974950 @guozhangwang - Regarding testing the commit results, can we defer this to the subsequent PR, i.e. verify it once committed() is implemented. -- This is an automated message from the

[GitHub] [kafka] vcrfxia commented on a diff in pull request #13340: KAFKA-14491: [15/N] Add integration tests for versioned stores

vcrfxia commented on code in PR #13340: URL: https://github.com/apache/kafka/pull/13340#discussion_r1128682440 ## streams/src/test/java/org/apache/kafka/streams/integration/VersionedKeyValueStoreIntegrationTest.java: ## @@ -0,0 +1,592 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] cmccabe closed pull request #13332: KAFKA-14057: Support dynamic reconfiguration in KRaft remote controllers

cmccabe closed pull request #13332: KAFKA-14057: Support dynamic reconfiguration in KRaft remote controllers URL: https://github.com/apache/kafka/pull/13332 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [kafka] cmccabe commented on pull request #13332: KAFKA-14057: Support dynamic reconfiguration in KRaft remote controllers

cmccabe commented on PR #13332: URL: https://github.com/apache/kafka/pull/13332#issuecomment-1458957347 Superseded by #13116 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [kafka] cmccabe commented on pull request #13337: MINOR: Refactor the MetadataPublisher interface

cmccabe commented on PR #13337: URL: https://github.com/apache/kafka/pull/13337#issuecomment-1458906783 rebase on trunk -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [kafka] ijuma commented on a diff in pull request #13359: KAFKA-14792: Race condition in LazyIndex.get()

ijuma commented on code in PR #13359: URL: https://github.com/apache/kafka/pull/13359#discussion_r1128578938 ## storage/src/main/java/org/apache/kafka/storage/internals/log/LazyIndex.java: ## @@ -166,20 +166,25 @@ public File file() { @SuppressWarnings("unchecked")

[GitHub] [kafka] ijuma commented on a diff in pull request #13359: KAFKA-14792: Race condition in LazyIndex.get()

ijuma commented on code in PR #13359: URL: https://github.com/apache/kafka/pull/13359#discussion_r1128576277 ## storage/src/main/java/org/apache/kafka/storage/internals/log/LazyIndex.java: ## @@ -166,20 +166,25 @@ public File file() { @SuppressWarnings("unchecked")

[GitHub] [kafka] ijuma opened a new pull request, #13359: KAFKA-14792: Race condition in LazyIndex.get()

ijuma opened a new pull request, #13359: URL: https://github.com/apache/kafka/pull/13359 `LazyIndex.get()` has a race condition that can result in a ClassCastException being thrown in some cases. This was introduced when it was rewritten from Scala to Java. ### Committer

[jira] [Updated] (KAFKA-14792) Race condition in LazyIndex.get()

[ https://issues.apache.org/jira/browse/KAFKA-14792?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma updated KAFKA-14792: Description: `LazyIndex.get()` has a race condition that can result in a ClassCastException

[jira] [Created] (KAFKA-14792) Race condition in LazyIndex.get()

Ismael Juma created KAFKA-14792: --- Summary: Race condition in LazyIndex.get() Key: KAFKA-14792 URL: https://issues.apache.org/jira/browse/KAFKA-14792 Project: Kafka Issue Type: Bug

[jira] [Resolved] (KAFKA-14351) Implement controller mutation quotas in KRaft

[ https://issues.apache.org/jira/browse/KAFKA-14351?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ron Dagostino resolved KAFKA-14351. --- Fix Version/s: 3.5.0 Resolution: Fixed > Implement controller mutation quotas in

[jira] [Created] (KAFKA-14791) Create a builder class for PartitionRegistration

Andrew Grant created KAFKA-14791: Summary: Create a builder class for PartitionRegistration Key: KAFKA-14791 URL: https://issues.apache.org/jira/browse/KAFKA-14791 Project: Kafka Issue Type:

[GitHub] [kafka] vcrfxia commented on a diff in pull request #13340: KAFKA-14491: [15/N] Add integration tests for versioned stores

vcrfxia commented on code in PR #13340: URL: https://github.com/apache/kafka/pull/13340#discussion_r1128550162 ## streams/src/test/java/org/apache/kafka/streams/integration/VersionedKeyValueStoreIntegrationTest.java: ## @@ -0,0 +1,592 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] philipnee commented on pull request #13303: KAFKA-14761 Adding integration test for the prototype consumer

philipnee commented on PR #13303: URL: https://github.com/apache/kafka/pull/13303#issuecomment-1458731526 Hey @rajinisivaram - Thanks! To your comments `I thought we have those methods on the existing Consumer interface. Anyway, that doesn't impact this PR.` : The current consumer uses

[GitHub] [kafka] rajinisivaram commented on a diff in pull request #13303: KAFKA-14761 Adding integration test for the prototype consumer

rajinisivaram commented on code in PR #13303: URL: https://github.com/apache/kafka/pull/13303#discussion_r1128444212 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/PrototypeAsyncConsumer.java: ## @@ -226,11 +246,20 @@ public void

[GitHub] [kafka] cmccabe merged pull request #13116: KAFKA-14351: Controller Mutation Quota for KRaft

cmccabe merged PR #13116: URL: https://github.com/apache/kafka/pull/13116 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] cmccabe commented on pull request #13116: KAFKA-14351: Controller Mutation Quota for KRaft

cmccabe commented on PR #13116: URL: https://github.com/apache/kafka/pull/13116#issuecomment-1458687762 Yes. It is frustrating that we have so many flaky tests. @mumrah is fixing the `KafkaServerKRaftRegistrationTest`. We may need to fix `SocketServerTest` too in the near future since it

[GitHub] [kafka] rondagostino commented on pull request #13116: KAFKA-14351: Controller Mutation Quota for KRaft

rondagostino commented on PR #13116: URL: https://github.com/apache/kafka/pull/13116#issuecomment-1458662433 There were several test failures (SelectorTest, Tls12SelectorTest, KafkaServerKRaftRegistrationTest, ListOffsetsRequestWithRemoteStoreTest, SocketServerTest) but I have seen them in

[jira] [Commented] (KAFKA-14786) Implement connector offset write/reset internal logic

[ https://issues.apache.org/jira/browse/KAFKA-14786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17697567#comment-17697567 ] Yash Mayya commented on KAFKA-14786: Hi [~ChrisEgerton], I'm assigning this ticket to myself if

[jira] [Assigned] (KAFKA-14786) Implement connector offset write/reset internal logic

[ https://issues.apache.org/jira/browse/KAFKA-14786?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yash Mayya reassigned KAFKA-14786: -- Assignee: Yash Mayya > Implement connector offset write/reset internal logic >

[jira] [Commented] (KAFKA-14780) Make RefreshingHttpsJwksTest#testSecondaryRefreshAfterElapsedDelay deterministic

[ https://issues.apache.org/jira/browse/KAFKA-14780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17697562#comment-17697562 ] Kirk True commented on KAFKA-14780: --- [~adupriez] Yes, that seems like something we should fix. I

[GitHub] [kafka] lucasbru commented on pull request #13318: KAFKA-14533: Do not interrupt state-updater thread during shutdown

lucasbru commented on PR #13318: URL: https://github.com/apache/kafka/pull/13318#issuecomment-1458578634 I triggered one now: https://jenkins.confluent.io/job/system-test-kafka-branch-builder/5554/console -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kafka] guozhangwang commented on pull request #13318: KAFKA-14533: Do not interrupt state-updater thread during shutdown

guozhangwang commented on PR #13318: URL: https://github.com/apache/kafka/pull/13318#issuecomment-1458570328 @lucasbru did you happen to have triggered a system test for this branch as well? -- This is an automated message from the Apache Git Service. To respond to the message, please

[jira] [Resolved] (KAFKA-14640) Update AddPartitionsToTxn protocol to batch and handle verifyOnly requests

[ https://issues.apache.org/jira/browse/KAFKA-14640?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justine Olshan resolved KAFKA-14640. Resolution: Fixed > Update AddPartitionsToTxn protocol to batch and handle verifyOnly

[GitHub] [kafka] jolshan commented on pull request #13231: KAFKA-14402: Update AddPartitionsToTxn protocol to batch and handle verifyOnly requests

jolshan commented on PR #13231: URL: https://github.com/apache/kafka/pull/13231#issuecomment-1458557507 for follow ups: https://issues.apache.org/jira/browse/KAFKA-14790 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[jira] [Created] (KAFKA-14790) Add more AddPartitionsToTxn tests in KafkaApis and Authorizer tests

Justine Olshan created KAFKA-14790: -- Summary: Add more AddPartitionsToTxn tests in KafkaApis and Authorizer tests Key: KAFKA-14790 URL: https://issues.apache.org/jira/browse/KAFKA-14790 Project:

[GitHub] [kafka] jolshan merged pull request #13231: KAFKA-14402: Update AddPartitionsToTxn protocol to batch and handle verifyOnly requests

jolshan merged PR #13231: URL: https://github.com/apache/kafka/pull/13231 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Created] (KAFKA-14789) Plugin ServiceLoader visibility from isolated plugins is inconsistent

Greg Harris created KAFKA-14789: --- Summary: Plugin ServiceLoader visibility from isolated plugins is inconsistent Key: KAFKA-14789 URL: https://issues.apache.org/jira/browse/KAFKA-14789 Project: Kafka

[GitHub] [kafka] urbandan commented on pull request #10566: KAFKA-12694 Avoid schema mismatch DataException when validating default values

urbandan commented on PR #10566: URL: https://github.com/apache/kafka/pull/10566#issuecomment-1458499533 @C0urante Thanks for the prototype, went through the change and left a few comments. Overall, I think your solution would solve this issue as well. On the other hand, I still think that

[GitHub] [kafka] dajac commented on a diff in pull request #13240: KAFKA-14690: Add topic IDs to the OffsetCommit API version 9

dajac commented on code in PR #13240: URL: https://github.com/apache/kafka/pull/13240#discussion_r1128110858 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java: ## @@ -199,7 +199,8 @@ public NetworkClientDelegate.UnsentRequest

[GitHub] [kafka] jolshan commented on a diff in pull request #13231: KAFKA-14402: Update AddPartitionsToTxn protocol to batch and handle verifyOnly requests

jolshan commented on code in PR #13231: URL: https://github.com/apache/kafka/pull/13231#discussion_r1128156639 ## core/src/test/scala/integration/kafka/api/AuthorizerIntegrationTest.scala: ## @@ -231,7 +231,7 @@ class AuthorizerIntegrationTest extends BaseRequestTest {

[GitHub] [kafka] jolshan commented on a diff in pull request #13231: KAFKA-14402: Update AddPartitionsToTxn protocol to batch and handle verifyOnly requests

jolshan commented on code in PR #13231: URL: https://github.com/apache/kafka/pull/13231#discussion_r1128154589 ## core/src/test/scala/integration/kafka/api/AuthorizerIntegrationTest.scala: ## @@ -231,7 +231,7 @@ class AuthorizerIntegrationTest extends BaseRequestTest {

[GitHub] [kafka] Hangleton commented on a diff in pull request #13352: Add support of topic ids for the OffsetFetch API from version 9.

Hangleton commented on code in PR #13352: URL: https://github.com/apache/kafka/pull/13352#discussion_r1128143723 ## clients/src/main/java/org/apache/kafka/common/requests/OffsetFetchRequest.java: ## @@ -253,38 +284,15 @@ public List groups() { } } -public

[jira] [Commented] (KAFKA-14520) TimeoutException Raised by KafkaConsumer Leads to: User provided listener org.apache.kafka.connect.runtime.WorkerSinkTask$HandleRebalance failed on invocation of onPar

[ https://issues.apache.org/jira/browse/KAFKA-14520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17697509#comment-17697509 ] Sagar Rao commented on KAFKA-14520: --- hi [~waleedfateem] , thanks for filing this. TimeoutException

[jira] [Commented] (KAFKA-14368) Implement connector offset write REST API

[ https://issues.apache.org/jira/browse/KAFKA-14368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17697508#comment-17697508 ] Yash Mayya commented on KAFKA-14368: Hi [~ChrisEgerton], thanks for updating the ticket. I'm still

[GitHub] [kafka] dajac commented on a diff in pull request #13231: KAFKA-14402: Update AddPartitionsToTxn protocol to batch and handle verifyOnly requests

dajac commented on code in PR #13231: URL: https://github.com/apache/kafka/pull/13231#discussion_r1128091331 ## core/src/test/scala/unit/kafka/server/KafkaApisTest.scala: ## @@ -2030,13 +2032,87 @@ class KafkaApisTest { val response = capturedResponse.getValue

[GitHub] [kafka] rondagostino commented on a diff in pull request #13116: KAFKA-14351: Controller Mutation Quota for KRaft

rondagostino commented on code in PR #13116: URL: https://github.com/apache/kafka/pull/13116#discussion_r1128069250 ## core/src/test/scala/unit/kafka/server/DynamicBrokerConfigTest.scala: ## @@ -479,6 +489,42 @@ class DynamicBrokerConfigTest { assertEquals("User:admin",

[jira] [Comment Edited] (KAFKA-6035) Avoid creating changelog topics for state stores that are directly piped to a sink topic

[ https://issues.apache.org/jira/browse/KAFKA-6035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17697387#comment-17697387 ] Andy Coates edited comment on KAFKA-6035 at 3/7/23 3:07 PM: I've had a couple

[GitHub] [kafka] rondagostino commented on pull request #13116: KAFKA-14351: Controller Mutation Quota for KRaft

rondagostino commented on PR #13116: URL: https://github.com/apache/kafka/pull/13116#issuecomment-1458306158 There were 6 test failures across 3 separate builds. All tests pass locally. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [kafka] C0urante opened a new pull request, #13358: MINOR: Fix anchor link in Connect docs

C0urante opened a new pull request, #13358: URL: https://github.com/apache/kafka/pull/13358 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including

[jira] [Created] (KAFKA-14788) Add TopicsToDeleteCount and ReplicasToDeleteCount to QuorumController

Chia-Ping Tsai created KAFKA-14788: -- Summary: Add TopicsToDeleteCount and ReplicasToDeleteCount to QuorumController Key: KAFKA-14788 URL: https://issues.apache.org/jira/browse/KAFKA-14788 Project:

[GitHub] [kafka] tinaselenge commented on pull request #13102: KAFKA-14371: Remove unused clusterId field from quorum-state file

tinaselenge commented on PR #13102: URL: https://github.com/apache/kafka/pull/13102#issuecomment-1458147611 @jsancio thank you for catching this and reverting the change! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [kafka] hudeqi commented on pull request #13348: MINOR: Fix ProducerPerformance still counting successful sending when sending failed

hudeqi commented on PR #13348: URL: https://github.com/apache/kafka/pull/13348#issuecomment-1458087082 Can someone take a look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Commented] (KAFKA-6035) Avoid creating changelog topics for state stores that are directly piped to a sink topic

[ https://issues.apache.org/jira/browse/KAFKA-6035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17697387#comment-17697387 ] Andy Coates commented on KAFKA-6035: I've had a couple of instances now where I've had to suffer

[GitHub] [kafka] mimaison commented on a diff in pull request #10244: KAFKA-12399: Deprecate Log4J Appender

mimaison commented on code in PR #10244: URL: https://github.com/apache/kafka/pull/10244#discussion_r1127686145 ## bin/kafka-run-class.sh: ## @@ -222,6 +234,7 @@ fi # Log4j settings if [ -z "$KAFKA_LOG4J_OPTS" ]; then + echo "DEPRECATED: using log4j 1.x configuration. To

[GitHub] [kafka] jlprat commented on a diff in pull request #13223: MINOR: fix some typo in SharedServer.scala/KafkaRaftServer.scala

jlprat commented on code in PR #13223: URL: https://github.com/apache/kafka/pull/13223#discussion_r1127673459 ## core/src/main/scala/kafka/server/KafkaRaftServer.scala: ## @@ -89,7 +89,7 @@ class KafkaRaftServer( Some(new ControllerServer( sharedServer,

[GitHub] [kafka] mimaison commented on a diff in pull request #13351: KAFKA-14781: Downgrade MM2 log message severity when no ACL authorizer is configured on source broker

mimaison commented on code in PR #13351: URL: https://github.com/apache/kafka/pull/13351#discussion_r1127673083 ## connect/mirror/src/test/java/org/apache/kafka/connect/mirror/MirrorSourceConnectorTest.java: ## @@ -149,6 +158,51 @@ public void testAclTransformation() {

[jira] [Resolved] (KAFKA-14770) Allow dynamic keystore update for brokers if string representation of DN matches even if canonical DNs don't match

[ https://issues.apache.org/jira/browse/KAFKA-14770?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajini Sivaram resolved KAFKA-14770. Reviewer: Manikumar Resolution: Fixed > Allow dynamic keystore update for brokers

[GitHub] [kafka] rajinisivaram merged pull request #13346: KAFKA-14770: Allow dynamic keystore update for brokers if string representation of DN matches even if canonical DNs don't match

rajinisivaram merged PR #13346: URL: https://github.com/apache/kafka/pull/13346 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] rajinisivaram commented on pull request #13346: KAFKA-14770: Allow dynamic keystore update for brokers if string representation of DN matches even if canonical DNs don't match

rajinisivaram commented on PR #13346: URL: https://github.com/apache/kafka/pull/13346#issuecomment-1457851382 @omkreddy @kpatelatwork Thanks for the reviews, test failures not related, merging to trunk. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kafka] Hangleton commented on pull request #13352: Add support of topic ids for the OffsetFetch API from version 9.

Hangleton commented on PR #13352: URL: https://github.com/apache/kafka/pull/13352#issuecomment-1457837585 Hi, Justine (@jolshan), thanks for your help. There is another PR with the same purpose as this one for the `OffsetCommit` API: [PR-13240](https://github.com/apache/kafka/pull/13240).

[GitHub] [kafka] dajac opened a new pull request, #13357: KAFKA-14462; [3/N] Add `onNewMetadataImage` to `GroupCoordinator` interface

dajac opened a new pull request, #13357: URL: https://github.com/apache/kafka/pull/13357 The new group coordinator needs to access cluster metadata (e.g. topics, partitions, etc.) and it needs a mechanism to be notified when the metadata changes (e.g. to trigger a rebalance). In KRaft

[GitHub] [kafka] dajac merged pull request #13329: KAFKA-14462; [2/N] Add ConsumerGroupHeartbeart to GroupCoordinator interface

dajac merged PR #13329: URL: https://github.com/apache/kafka/pull/13329 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: