[
https://issues.apache.org/jira/browse/KAFKA-14801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17699954#comment-17699954
]
Akhilesh Chaganti commented on KAFKA-14801:
---
https://github.com/apache/kafka/pull/13384
>
[
https://issues.apache.org/jira/browse/KAFKA-14801?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Akhilesh Chaganti updated KAFKA-14801:
--
Priority: Blocker (was: Major)
> Encoded sensitive configs are not decoded before
[
https://issues.apache.org/jira/browse/KAFKA-14801?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Akhilesh Chaganti reassigned KAFKA-14801:
-
Assignee: Akhilesh Chaganti
> Encoded sensitive configs are not decoded before
[
https://issues.apache.org/jira/browse/KAFKA-14804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17699938#comment-17699938
]
Yash Mayya edited comment on KAFKA-14804 at 3/14/23 4:48 AM:
-
[
https://issues.apache.org/jira/browse/KAFKA-14804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17699938#comment-17699938
]
Yash Mayya commented on KAFKA-14804:
[
https://issues.apache.org/jira/browse/KAFKA-10688?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax reassigned KAFKA-10688:
---
Assignee: (was: Guozhang Wang)
> Handle accidental truncation of repartition
mjsax commented on code in PR #13340:
URL: https://github.com/apache/kafka/pull/13340#discussion_r1134781624
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/StateManagerUtil.java:
##
@@ -48,7 +49,9 @@ final class StateManagerUtil {
private
mjsax commented on code in PR #13365:
URL: https://github.com/apache/kafka/pull/13365#discussion_r1134610789
##
streams/src/main/java/org/apache/kafka/streams/state/internals/LogicalKeyValueSegments.java:
##
@@ -57,6 +57,11 @@ public void openExisting(final ProcessorContext
jolshan opened a new pull request, #13391:
URL: https://github.com/apache/kafka/pull/13391
Added check for ongoing transaction
Thread to send and receive verify only add partition to txn requests
Code to send on request thread courtesy of @artemlivshits
### Committer Checklist
cmccabe opened a new pull request, #13390:
URL: https://github.com/apache/kafka/pull/13390
Standardize KRaft thread names a bit. Event handler threads should be
prefixed with the manager
name and node id. For example, the BrokerLifecycleManager event handler
thread for node 2 should be
cmccabe commented on code in PR #13372:
URL: https://github.com/apache/kafka/pull/13372#discussion_r1134596431
##
metadata/src/main/java/org/apache/kafka/metadata/migration/KRaftMigrationDriver.java:
##
@@ -269,15 +288,24 @@ public void close() throws Exception {
//
cmccabe commented on code in PR #13372:
URL: https://github.com/apache/kafka/pull/13372#discussion_r1134595911
##
metadata/src/main/java/org/apache/kafka/metadata/migration/KRaftMigrationDriver.java:
##
@@ -269,15 +288,24 @@ public void close() throws Exception {
//
cmccabe commented on code in PR #13372:
URL: https://github.com/apache/kafka/pull/13372#discussion_r1134594893
##
metadata/src/main/java/org/apache/kafka/metadata/migration/KRaftMigrationDriver.java:
##
@@ -132,26 +132,45 @@ private boolean isControllerQuorumReadyForMigration()
cmccabe commented on code in PR #13372:
URL: https://github.com/apache/kafka/pull/13372#discussion_r1134593684
##
metadata/src/main/java/org/apache/kafka/metadata/migration/KRaftMigrationDriver.java:
##
@@ -93,7 +93,7 @@ public KRaftMigrationDriver(
this.log =
cmccabe commented on code in PR #13372:
URL: https://github.com/apache/kafka/pull/13372#discussion_r1134592688
##
metadata/src/main/java/org/apache/kafka/metadata/migration/KRaftMigrationDriver.java:
##
@@ -93,7 +93,7 @@ public KRaftMigrationDriver(
this.log =
cmccabe commented on code in PR #13372:
URL: https://github.com/apache/kafka/pull/13372#discussion_r1134591764
##
core/src/test/scala/integration/kafka/zk/ZkMigrationIntegrationTest.scala:
##
@@ -85,7 +85,7 @@ class ZkMigrationIntegrationTest {
quotas.add(new
cmccabe commented on code in PR #13372:
URL: https://github.com/apache/kafka/pull/13372#discussion_r1134591050
##
core/src/main/scala/kafka/zk/ZkMigrationClient.scala:
##
@@ -47,24 +46,44 @@ import scala.jdk.CollectionConverters._
*/
class ZkMigrationClient(zkClient:
cmccabe commented on code in PR #13372:
URL: https://github.com/apache/kafka/pull/13372#discussion_r1134590727
##
core/src/main/scala/kafka/zk/ZkMigrationClient.scala:
##
@@ -211,19 +230,21 @@ class ZkMigrationClient(zkClient: KafkaZkClient) extends
MigrationClient with Lo
cmccabe commented on code in PR #13372:
URL: https://github.com/apache/kafka/pull/13372#discussion_r1134589780
##
core/src/main/scala/kafka/zk/ZkMigrationClient.scala:
##
@@ -47,24 +46,44 @@ import scala.jdk.CollectionConverters._
*/
class ZkMigrationClient(zkClient:
cmccabe commented on code in PR #13344:
URL: https://github.com/apache/kafka/pull/13344#discussion_r1134579225
##
core/src/main/scala/kafka/server/BrokerServer.scala:
##
@@ -362,16 +326,13 @@ class BrokerServer(
config.brokerSessionTimeoutMs / 2 // KAFKA-14392
)
[
https://issues.apache.org/jira/browse/KAFKA-14805?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Arthur updated KAFKA-14805:
-
Summary: KRaft Controller shouldn't allow metadata updates before migration
starts (was: KRaft
David Arthur created KAFKA-14805:
Summary: KRaft Controller doesn't allow metadata updates before
migration starts
Key: KAFKA-14805
URL: https://issues.apache.org/jira/browse/KAFKA-14805
Project:
guozhangwang commented on code in PR #13380:
URL: https://github.com/apache/kafka/pull/13380#discussion_r1134383599
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java:
##
@@ -207,6 +266,85 @@ public NetworkClientDelegate.UnsentRequest
Hangleton commented on PR #13378:
URL: https://github.com/apache/kafka/pull/13378#issuecomment-1466756969
Thanks David for the review, addressed the comments and inlined the
declaration of topic-id-partitions in the locations above and in few other
remaining places. The PR has just been
Hangleton commented on code in PR #13378:
URL: https://github.com/apache/kafka/pull/13378#discussion_r1134485210
##
core/src/test/scala/unit/kafka/coordinator/group/GroupCoordinatorTest.scala:
##
@@ -2917,34 +2925,33 @@ class GroupCoordinatorTest {
@Test
def
Hangleton commented on code in PR #13378:
URL: https://github.com/apache/kafka/pull/13378#discussion_r1134476449
##
core/src/main/scala/kafka/coordinator/group/GroupMetadata.scala:
##
@@ -827,6 +831,14 @@ private[group] class GroupMetadata(val groupId: String,
initialState:
mimaison commented on PR #13388:
URL: https://github.com/apache/kafka/pull/13388#issuecomment-1466730421
Thanks, I've pushed an update.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
[
https://issues.apache.org/jira/browse/KAFKA-14255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yi Ding reopened KAFKA-14255:
-
> Fetching from follower should be disallowed if fetch from follower is disabled
>
[
https://issues.apache.org/jira/browse/KAFKA-14255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yi Ding resolved KAFKA-14255.
-
Resolution: Won't Fix
> Fetching from follower should be disallowed if fetch from follower is disabled
mimaison opened a new pull request, #13389:
URL: https://github.com/apache/kafka/pull/13389
While investigating an issue today, I found this log line
https://github.com/apache/kafka/blob/trunk/connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorSourceTask.java#L112-L113
jsancio merged PR #13381:
URL: https://github.com/apache/kafka/pull/13381
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
mumrah merged PR #13387:
URL: https://github.com/apache/kafka/pull/13387
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
mimaison commented on PR #13388:
URL: https://github.com/apache/kafka/pull/13388#issuecomment-1466614689
cc @mumrah
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
mimaison opened a new pull request, #13388:
URL: https://github.com/apache/kafka/pull/13388
Otherwise the build fails with
Caused by: java.lang.NoSuchMethodException:
io.swagger.v3.jaxrs2.integration.SwaggerLoader.setOpenAPI31(java.lang.Boolean)
### Committer Checklist
[
https://issues.apache.org/jira/browse/KAFKA-14804?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mickael Maison reassigned KAFKA-14804:
--
Assignee: Mickael Maison
> Connect docs fail to build with Gradle Swagger plugin
[
https://issues.apache.org/jira/browse/KAFKA-14803?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Behavox updated KAFKA-14803:
Description:
topic deletion doesn't work as expected when attempting to delete topic(s),
after
dajac commented on code in PR #13378:
URL: https://github.com/apache/kafka/pull/13378#discussion_r1134345366
##
core/src/test/scala/unit/kafka/coordinator/group/GroupCoordinatorConcurrencyTest.scala:
##
@@ -284,7 +284,8 @@ class GroupCoordinatorConcurrencyTest extends
mumrah opened a new pull request, #13387:
URL: https://github.com/apache/kafka/pull/13387
The [recent
update](https://github.com/apache/kafka/commit/e348da4095e71f9bd6f6e1ce1e7bd52bfe605b5f)
of the Gradle Swagger plugin throws an error when building the connect docs.
This PR reverts the
David Arthur created KAFKA-14804:
Summary: Connect docs fail to build with Gradle Swagger plugin
2.2.8
Key: KAFKA-14804
URL: https://issues.apache.org/jira/browse/KAFKA-14804
Project: Kafka
Behavox created KAFKA-14803:
---
Summary: topic deletion bug
Key: KAFKA-14803
URL: https://issues.apache.org/jira/browse/KAFKA-14803
Project: Kafka
Issue Type: Bug
Components: controller,
Behavox created KAFKA-14802:
---
Summary: topic deletion bug
Key: KAFKA-14802
URL: https://issues.apache.org/jira/browse/KAFKA-14802
Project: Kafka
Issue Type: Bug
Components: controller,
[
https://issues.apache.org/jira/browse/KAFKA-14206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17699704#comment-17699704
]
Mickael Maison commented on KAFKA-14206:
The 3.4 branch has been upgrade to use ZooKeeper 3.6.4
[
https://issues.apache.org/jira/browse/KAFKA-14206?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mickael Maison updated KAFKA-14206:
---
Fix Version/s: (was: 3.4.1)
> Upgrade zookeeper to 3.7.1 to address security
Hangleton commented on PR #13378:
URL: https://github.com/apache/kafka/pull/13378#issuecomment-1466343813
Thanks David for the review, all comments should be addressed with the new
commits. I wonder how useful it would be to extend the tests in
`GroupCoordinatorTest` to exercise the
C0urante commented on code in PR #13367:
URL: https://github.com/apache/kafka/pull/13367#discussion_r1134001434
##
connect/mirror/src/test/java/org/apache/kafka/connect/mirror/MirrorSourceTaskTest.java:
##
@@ -99,11 +99,13 @@ public void testOffsetSync() {
C0urante commented on code in PR #13367:
URL: https://github.com/apache/kafka/pull/13367#discussion_r1134035661
##
connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorSourceTask.java:
##
@@ -316,13 +315,14 @@ static class PartitionState {
// true if we
omkreddy commented on code in PR #13374:
URL: https://github.com/apache/kafka/pull/13374#discussion_r1133830351
##
clients/src/main/java/org/apache/kafka/common/security/scram/internals/ScramMechanism.java:
##
@@ -40,11 +42,13 @@ public enum ScramMechanism {
hgeraldino opened a new pull request, #13386:
URL: https://github.com/apache/kafka/pull/13386
This shouldn't be a controversial change: the `if` condition here is
checking the wrong variable (`this.committableOffsets.isEmpty()` always
evaluates to true because of L#216). I assume this bug
Hangleton commented on code in PR #13378:
URL: https://github.com/apache/kafka/pull/13378#discussion_r1134008996
##
core/src/main/scala/kafka/coordinator/group/GroupMetadata.scala:
##
@@ -649,26 +649,27 @@ private[group] class GroupMetadata(val groupId: String,
initialState:
Hangleton commented on PR #13378:
URL: https://github.com/apache/kafka/pull/13378#issuecomment-1466175146
Thank you David for the continued review, updating the PR to address the
review comments.
--
This is an automated message from the Apache Git Service.
To respond to the message,
Hangleton commented on code in PR #13378:
URL: https://github.com/apache/kafka/pull/13378#discussion_r1133971136
##
core/src/test/scala/unit/kafka/coordinator/group/GroupMetadataTest.scala:
##
@@ -386,175 +386,269 @@ class GroupMetadataTest {
@Test
def
dajac commented on code in PR #13378:
URL: https://github.com/apache/kafka/pull/13378#discussion_r1133929949
##
core/src/main/scala/kafka/coordinator/group/GroupMetadata.scala:
##
@@ -824,9 +827,18 @@ private[group] class GroupMetadata(val groupId: String,
initialState:
[
https://issues.apache.org/jira/browse/KAFKA-14597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17699629#comment-17699629
]
Tales Tonini commented on KAFKA-14597:
--
Hi [~cadonna] , I went through
Hangleton commented on code in PR #13378:
URL: https://github.com/apache/kafka/pull/13378#discussion_r1133796725
##
core/src/test/scala/unit/kafka/coordinator/group/GroupCoordinatorConcurrencyTest.scala:
##
@@ -295,8 +295,12 @@ class GroupCoordinatorConcurrencyTest extends
Hangleton commented on code in PR #13378:
URL: https://github.com/apache/kafka/pull/13378#discussion_r1133792178
##
core/src/main/scala/kafka/coordinator/group/GroupMetadataManager.scala:
##
@@ -469,11 +469,11 @@ class GroupMetadataManager(brokerId: Int,
if
dajac commented on code in PR #13378:
URL: https://github.com/apache/kafka/pull/13378#discussion_r1133770968
##
core/src/main/scala/kafka/coordinator/group/GroupCoordinator.scala:
##
@@ -971,8 +971,11 @@ private[group] class GroupCoordinator(
if
lucasbru commented on code in PR #13382:
URL: https://github.com/apache/kafka/pull/13382#discussion_r1133769875
##
clients/src/main/java/org/apache/kafka/common/serialization/Serdes.java:
##
@@ -274,6 +282,13 @@ static public Serde UUID() {
return new UUIDSerde();
dajac commented on code in PR #13378:
URL: https://github.com/apache/kafka/pull/13378#discussion_r1133769199
##
core/src/main/scala/kafka/coordinator/group/GroupMetadataManager.scala:
##
@@ -469,11 +469,11 @@ class GroupMetadataManager(brokerId: Int,
if
Hangleton commented on code in PR #13378:
URL: https://github.com/apache/kafka/pull/13378#discussion_r1133751522
##
core/src/main/scala/kafka/coordinator/group/GroupMetadataManager.scala:
##
@@ -469,11 +469,11 @@ class GroupMetadataManager(brokerId: Int,
if
Hangleton commented on code in PR #13378:
URL: https://github.com/apache/kafka/pull/13378#discussion_r1133737665
##
core/src/main/scala/kafka/coordinator/group/GroupMetadataManager.scala:
##
@@ -469,11 +469,11 @@ class GroupMetadataManager(brokerId: Int,
if
jujoramos opened a new pull request, #13385:
URL: https://github.com/apache/kafka/pull/13385
Extra Release Details:
- https://github.com/google/snappy/releases/tag/1.1.9
- https://github.com/xerial/snappy-java/releases/tag/v1.1.9.1
### Committer Checklist (excluded from commit
[
https://issues.apache.org/jira/browse/KAFKA-14800?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Juan Ramos updated KAFKA-14800:
---
Affects Version/s: (was: 3.4.0)
(was: 3.3.2)
> Upgrade snappy-java
[
https://issues.apache.org/jira/browse/KAFKA-14800?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Juan Ramos updated KAFKA-14800:
---
Affects Version/s: 3.4.0
3.5.0
3.4.1
urbandan commented on code in PR #11565:
URL: https://github.com/apache/kafka/pull/11565#discussion_r1133617771
##
connect/runtime/src/main/java/org/apache/kafka/connect/util/TopicAdmin.java:
##
@@ -360,10 +361,20 @@ public Set createTopicsWithRetry(NewTopic
topicDescription,
[
https://issues.apache.org/jira/browse/KAFKA-13349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17699524#comment-17699524
]
Mahesh Madushan commented on KAFKA-13349:
-
Thanks [~sagarrao] .
> Allow Iterator.remove on
rajinisivaram merged PR #13349:
URL: https://github.com/apache/kafka/pull/13349
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
rajinisivaram commented on PR #13349:
URL: https://github.com/apache/kafka/pull/13349#issuecomment-1465742276
@dajac Thanks for the review, merging to trunk.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
dajac commented on code in PR #13378:
URL: https://github.com/apache/kafka/pull/13378#discussion_r1133562845
##
core/src/test/scala/unit/kafka/coordinator/group/GroupCoordinatorConcurrencyTest.scala:
##
@@ -295,8 +295,12 @@ class GroupCoordinatorConcurrencyTest extends
dajac commented on code in PR #13378:
URL: https://github.com/apache/kafka/pull/13378#discussion_r1133562173
##
core/src/main/scala/kafka/coordinator/group/GroupMetadataManager.scala:
##
@@ -469,11 +469,11 @@ class GroupMetadataManager(brokerId: Int,
if
mukkachaitanya commented on code in PR #13361:
URL: https://github.com/apache/kafka/pull/13361#discussion_r1133500395
##
connect/runtime/src/main/java/org/apache/kafka/connect/util/KafkaBasedLog.java:
##
@@ -561,6 +561,9 @@ public void run() {
}
}
divijvaidya commented on code in PR #13362:
URL: https://github.com/apache/kafka/pull/13362#discussion_r1133528025
##
storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/serialization/RemoteLogMetadataSerde.java:
##
@@ -107,4 +110,13 @@ private
[
https://issues.apache.org/jira/browse/KAFKA-13349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17699492#comment-17699492
]
Sagar Rao commented on KAFKA-13349:
---
hi [~mahesh98] , it was assigned to me but I un-assigned as I
Akhilesh Chaganti created KAFKA-14801:
-
Summary: Encoded sensitive configs are not decoded before migration
Key: KAFKA-14801
URL: https://issues.apache.org/jira/browse/KAFKA-14801
Project: Kafka
divijvaidya commented on code in PR #13382:
URL: https://github.com/apache/kafka/pull/13382#discussion_r1133507231
##
clients/src/main/java/org/apache/kafka/common/serialization/BooleanDeserializer.java:
##
@@ -0,0 +1,27 @@
+package org.apache.kafka.common.serialization;
74 matches
Mail list logo
