[GitHub] [kafka] philipnee commented on a diff in pull request #13380: KAFKA-14468: Committed API

philipnee commented on code in PR #13380: URL: https://github.com/apache/kafka/pull/13380#discussion_r1136454999 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/PrototypeAsyncConsumer.java: ## @@ -437,29 +456,24 @@ public void wakeup() { */

[GitHub] [kafka] philipnee commented on a diff in pull request #13380: KAFKA-14468: Committed API

philipnee commented on code in PR #13380: URL: https://github.com/apache/kafka/pull/13380#discussion_r1136454609 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java: ## @@ -235,4 +373,105 @@ public void ack(final long currentTimeMs) {

[GitHub] [kafka] philipnee commented on a diff in pull request #13380: KAFKA-14468: Committed API

philipnee commented on code in PR #13380: URL: https://github.com/apache/kafka/pull/13380#discussion_r1136449438 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/PrototypeAsyncConsumer.java: ## @@ -306,13 +310,28 @@ public OffsetAndMetadata

[jira] [Assigned] (KAFKA-14206) Upgrade zookeeper to 3.7.1 to address security vulnerabilities

[ https://issues.apache.org/jira/browse/KAFKA-14206?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen reassigned KAFKA-14206: - Assignee: (was: Luke Chen) > Upgrade zookeeper to 3.7.1 to address security

[GitHub] [kafka] philipnee commented on a diff in pull request #13380: KAFKA-14468: Committed API

philipnee commented on code in PR #13380: URL: https://github.com/apache/kafka/pull/13380#discussion_r1136434874 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java: ## @@ -207,6 +266,85 @@ public NetworkClientDelegate.UnsentRequest

[jira] [Created] (KAFKA-14810) Refactor FileRawSansphotWriter to not reference ReplicateLog

José Armando García Sancio created KAFKA-14810: -- Summary: Refactor FileRawSansphotWriter to not reference ReplicateLog Key: KAFKA-14810 URL: https://issues.apache.org/jira/browse/KAFKA-14810

[GitHub] [kafka] pprovenzano commented on a diff in pull request #13374: KRAFT-14765 and KRAFT-14776: Support for SCRAM at bootstrap with integration tests

pprovenzano commented on code in PR #13374: URL: https://github.com/apache/kafka/pull/13374#discussion_r1136329445 ## core/src/test/scala/unit/kafka/tools/StorageToolTest.scala: ## @@ -221,4 +224,78 @@ Found problem: assertThrows(classOf[IllegalArgumentException], () =>

[GitHub] [kafka] pprovenzano commented on a diff in pull request #13374: KRAFT-14765 and KRAFT-14776: Support for SCRAM at bootstrap with integration tests

pprovenzano commented on code in PR #13374: URL: https://github.com/apache/kafka/pull/13374#discussion_r1136323073 ## core/src/test/scala/integration/kafka/server/ScramServerStartupTest.scala: ## @@ -46,8 +47,8 @@ class ScramServerStartupTest extends IntegrationTestHarness

[GitHub] [kafka] pprovenzano commented on a diff in pull request #13374: KRAFT-14765 and KRAFT-14776: Support for SCRAM at bootstrap with integration tests

pprovenzano commented on code in PR #13374: URL: https://github.com/apache/kafka/pull/13374#discussion_r1136321668 ## core/src/main/scala/kafka/tools/StorageTool.scala: ## @@ -96,6 +115,9 @@ object StorageTool extends Logging { action(store()). required(true).

[GitHub] [kafka] pprovenzano commented on a diff in pull request #13374: KRAFT-14765 and KRAFT-14776: Support for SCRAM at bootstrap with integration tests

pprovenzano commented on code in PR #13374: URL: https://github.com/apache/kafka/pull/13374#discussion_r1136321240 ## clients/src/main/java/org/apache/kafka/common/security/scram/internals/ScramMechanism.java: ## @@ -40,11 +42,13 @@ public enum ScramMechanism {

[GitHub] [kafka] guozhangwang commented on a diff in pull request #13380: KAFKA-14468: Committed API

guozhangwang commented on code in PR #13380: URL: https://github.com/apache/kafka/pull/13380#discussion_r1136315295 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java: ## @@ -207,6 +266,85 @@ public NetworkClientDelegate.UnsentRequest

[GitHub] [kafka] vcrfxia commented on a diff in pull request #13365: KAFKA-14491: [17/N] Refactor segments cleanup logic

vcrfxia commented on code in PR #13365: URL: https://github.com/apache/kafka/pull/13365#discussion_r1136263824 ## streams/src/main/java/org/apache/kafka/streams/state/internals/LogicalKeyValueSegments.java: ## @@ -57,6 +57,11 @@ public void openExisting(final ProcessorContext

[GitHub] [kafka] vcrfxia commented on a diff in pull request #13365: KAFKA-14491: [17/N] Refactor segments cleanup logic

vcrfxia commented on code in PR #13365: URL: https://github.com/apache/kafka/pull/13365#discussion_r1136263824 ## streams/src/main/java/org/apache/kafka/streams/state/internals/LogicalKeyValueSegments.java: ## @@ -57,6 +57,11 @@ public void openExisting(final ProcessorContext

[GitHub] [kafka] vcrfxia commented on a diff in pull request #13340: KAFKA-14491: [15/N] Add integration tests for versioned stores

vcrfxia commented on code in PR #13340: URL: https://github.com/apache/kafka/pull/13340#discussion_r1136261694 ## streams/src/test/java/org/apache/kafka/streams/integration/VersionedKeyValueStoreIntegrationTest.java: ## @@ -302,7 +319,54 @@ public void

[GitHub] [kafka] CalvinConfluent commented on a diff in pull request #13323: KAFKA-14617: Add ReplicaState to FetchRequest

CalvinConfluent commented on code in PR #13323: URL: https://github.com/apache/kafka/pull/13323#discussion_r1136255311 ## clients/src/main/resources/common/message/FetchRequest.json: ## @@ -50,14 +50,23 @@ // Version 13 replaces topic names with topic IDs (KIP-516). May

[GitHub] [kafka] CalvinConfluent commented on a diff in pull request #13323: KAFKA-14617: Add ReplicaState to FetchRequest

CalvinConfluent commented on code in PR #13323: URL: https://github.com/apache/kafka/pull/13323#discussion_r1136238469 ## clients/src/main/resources/common/message/FetchRequest.json: ## @@ -50,14 +50,23 @@ // Version 13 replaces topic names with topic IDs (KIP-516). May

[GitHub] [kafka] vcrfxia commented on a diff in pull request #13340: KAFKA-14491: [15/N] Add integration tests for versioned stores

vcrfxia commented on code in PR #13340: URL: https://github.com/apache/kafka/pull/13340#discussion_r1136258765 ## streams/src/test/java/org/apache/kafka/streams/integration/VersionedKeyValueStoreIntegrationTest.java: ## @@ -334,18 +399,65 @@ private final int

[GitHub] [kafka] CalvinConfluent commented on a diff in pull request #13323: KAFKA-14617: Add ReplicaState to FetchRequest

CalvinConfluent commented on code in PR #13323: URL: https://github.com/apache/kafka/pull/13323#discussion_r1136255311 ## clients/src/main/resources/common/message/FetchRequest.json: ## @@ -50,14 +50,23 @@ // Version 13 replaces topic names with topic IDs (KIP-516). May

[GitHub] [kafka] CalvinConfluent commented on a diff in pull request #13323: KAFKA-14617: Add ReplicaState to FetchRequest

CalvinConfluent commented on code in PR #13323: URL: https://github.com/apache/kafka/pull/13323#discussion_r1136255311 ## clients/src/main/resources/common/message/FetchRequest.json: ## @@ -50,14 +50,23 @@ // Version 13 replaces topic names with topic IDs (KIP-516). May

[GitHub] [kafka] vcrfxia commented on pull request #13292: KAFKA-14491: [14/N] Set changelog topic configs for versioned stores

vcrfxia commented on PR #13292: URL: https://github.com/apache/kafka/pull/13292#issuecomment-1468887946 Thanks @mjsax for your review! I made the refactor you suggested (including to the existing WindowedChangelogTopicConfig) and also pushed updates to InternalTopicManager.

[GitHub] [kafka] CalvinConfluent commented on a diff in pull request #13323: KAFKA-14617: Add ReplicaState to FetchRequest

CalvinConfluent commented on code in PR #13323: URL: https://github.com/apache/kafka/pull/13323#discussion_r1136249875 ## clients/src/main/resources/common/message/FetchRequest.json: ## @@ -50,14 +50,23 @@ // Version 13 replaces topic names with topic IDs (KIP-516). May

[GitHub] [kafka] vcrfxia commented on a diff in pull request #13292: KAFKA-14491: [14/N] Set changelog topic configs for versioned stores

vcrfxia commented on code in PR #13292: URL: https://github.com/apache/kafka/pull/13292#discussion_r1136249663 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopologyBuilder.java: ## @@ -1293,12 +1306,16 @@ private void

[GitHub] [kafka] jolshan commented on a diff in pull request #13323: KAFKA-14617: Add ReplicaState to FetchRequest

jolshan commented on code in PR #13323: URL: https://github.com/apache/kafka/pull/13323#discussion_r1136245326 ## clients/src/main/resources/common/message/FetchRequest.json: ## @@ -50,14 +50,23 @@ // Version 13 replaces topic names with topic IDs (KIP-516). May return

[GitHub] [kafka] CalvinConfluent commented on a diff in pull request #13323: KAFKA-14617: Add ReplicaState to FetchRequest

CalvinConfluent commented on code in PR #13323: URL: https://github.com/apache/kafka/pull/13323#discussion_r1136238469 ## clients/src/main/resources/common/message/FetchRequest.json: ## @@ -50,14 +50,23 @@ // Version 13 replaces topic names with topic IDs (KIP-516). May

[GitHub] [kafka] jolshan commented on a diff in pull request #13323: KAFKA-14617: Add ReplicaState to FetchRequest

jolshan commented on code in PR #13323: URL: https://github.com/apache/kafka/pull/13323#discussion_r1136221498 ## clients/src/main/resources/common/message/FetchRequest.json: ## @@ -50,14 +50,23 @@ // Version 13 replaces topic names with topic IDs (KIP-516). May return

[GitHub] [kafka] jolshan commented on a diff in pull request #13323: KAFKA-14617: Add ReplicaState to FetchRequest

jolshan commented on code in PR #13323: URL: https://github.com/apache/kafka/pull/13323#discussion_r1136220531 ## clients/src/main/resources/common/message/FetchRequest.json: ## @@ -50,14 +50,23 @@ // Version 13 replaces topic names with topic IDs (KIP-516). May return

[GitHub] [kafka] CalvinConfluent commented on a diff in pull request #13323: KAFKA-14617: Add ReplicaState to FetchRequest

CalvinConfluent commented on code in PR #13323: URL: https://github.com/apache/kafka/pull/13323#discussion_r1136218503 ## clients/src/main/resources/common/message/FetchRequest.json: ## @@ -50,14 +50,23 @@ // Version 13 replaces topic names with topic IDs (KIP-516). May

[GitHub] [kafka] jsancio commented on a diff in pull request #13396: KAFKA-13884; Only voters flush on Fetch response

jsancio commented on code in PR #13396: URL: https://github.com/apache/kafka/pull/13396#discussion_r1136211424 ## raft/src/test/java/org/apache/kafka/raft/RaftClientTestContext.java: ## @@ -975,6 +980,18 @@ void assertFetchRequestData( assertEquals(fetchOffset,

[GitHub] [kafka] hachikuji commented on a diff in pull request #13396: KAFKA-13884; Only voters flush on Fetch response

hachikuji commented on code in PR #13396: URL: https://github.com/apache/kafka/pull/13396#discussion_r1136194254 ## raft/src/test/java/org/apache/kafka/raft/RaftClientTestContext.java: ## @@ -975,6 +980,18 @@ void assertFetchRequestData( assertEquals(fetchOffset,

[GitHub] [kafka] jsancio commented on a diff in pull request #13396: KAFKA-13884; Only voters flush on Fetch response

jsancio commented on code in PR #13396: URL: https://github.com/apache/kafka/pull/13396#discussion_r1136182878 ## raft/src/test/java/org/apache/kafka/raft/RaftClientTestContext.java: ## @@ -975,6 +980,18 @@ void assertFetchRequestData( assertEquals(fetchOffset,

[jira] [Commented] (KAFKA-14809) Connect incorrectly logs that no records were produced by source tasks

[ https://issues.apache.org/jira/browse/KAFKA-14809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17700372#comment-17700372 ] Hector Geraldino commented on KAFKA-14809: -- No that's perfect. Thanks [~ChrisEgerton]! >

[GitHub] [kafka] jolshan commented on a diff in pull request #13323: KAFKA-14617: Add ReplicaState to FetchRequest

jolshan commented on code in PR #13323: URL: https://github.com/apache/kafka/pull/13323#discussion_r1136148988 ## clients/src/main/resources/common/message/FetchRequest.json: ## @@ -50,14 +50,23 @@ // Version 13 replaces topic names with topic IDs (KIP-516). May return

[jira] [Commented] (KAFKA-14809) Connect incorrectly logs that no records were produced by source tasks

[ https://issues.apache.org/jira/browse/KAFKA-14809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17700360#comment-17700360 ] Chris Egerton commented on KAFKA-14809: --- [~hgeraldino] I wanted a Jira ticket for this so that

[jira] [Updated] (KAFKA-14809) Connect incorrectly logs that no records were produced by source tasks

[ https://issues.apache.org/jira/browse/KAFKA-14809?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Egerton updated KAFKA-14809: -- Description: There's an *{{if}}* condition when [committing

[GitHub] [kafka] jolshan commented on a diff in pull request #13323: KAFKA-14617: Add ReplicaState to FetchRequest

jolshan commented on code in PR #13323: URL: https://github.com/apache/kafka/pull/13323#discussion_r1136146308 ## clients/src/main/java/org/apache/kafka/common/requests/FetchRequest.java: ## @@ -302,6 +335,10 @@ public String toString() { } } +public static

[jira] [Updated] (KAFKA-14809) Connect incorrectly logs that no records were produced by source task

[ https://issues.apache.org/jira/browse/KAFKA-14809?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Egerton updated KAFKA-14809: -- Summary: Connect incorrectly logs that no records were produced by source task (was: Kafka

[jira] [Updated] (KAFKA-14809) Connect incorrectly logs that no records were produced by source tasks

[ https://issues.apache.org/jira/browse/KAFKA-14809?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Egerton updated KAFKA-14809: -- Summary: Connect incorrectly logs that no records were produced by source tasks (was:

[jira] [Updated] (KAFKA-14809) Kafka Connect incorrectly logs that no records were produced by source task

[ https://issues.apache.org/jira/browse/KAFKA-14809?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Egerton updated KAFKA-14809: -- Description: There's an *{{if}}* condition when [committing

[jira] [Updated] (KAFKA-14809) Kafka Connect incorrectly logs that no records were produced by source task

[ https://issues.apache.org/jira/browse/KAFKA-14809?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Egerton updated KAFKA-14809: -- Summary: Kafka Connect incorrectly logs that no records were produced by source task (was:

[jira] [Updated] (KAFKA-14809) Fix logging conditional on WorkerSourceTask

[ https://issues.apache.org/jira/browse/KAFKA-14809?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Egerton updated KAFKA-14809: -- Priority: Minor (was: Trivial) > Fix logging conditional on WorkerSourceTask >

[GitHub] [kafka] hgeraldino commented on pull request #13386: KAFKA-14809 Fix logging conditional on WorkerSourceTask

hgeraldino commented on PR #13386: URL: https://github.com/apache/kafka/pull/13386#issuecomment-1468755316 > LGTM, thanks @hgeraldino! > > It would be nice to have a Jira for this so that others who notice the logging issue on older versions can know 1) that it is a bug and 2) which

[jira] [Created] (KAFKA-14809) Fix logging conditional on WorkerSourceTask

Hector Geraldino created KAFKA-14809: Summary: Fix logging conditional on WorkerSourceTask Key: KAFKA-14809 URL: https://issues.apache.org/jira/browse/KAFKA-14809 Project: Kafka Issue

[GitHub] [kafka] hachikuji commented on a diff in pull request #13396: KAFKA-13884; Only voters flush on Fetch response

hachikuji commented on code in PR #13396: URL: https://github.com/apache/kafka/pull/13396#discussion_r1136130884 ## raft/src/test/java/org/apache/kafka/raft/RaftClientTestContext.java: ## @@ -975,6 +980,18 @@ void assertFetchRequestData( assertEquals(fetchOffset,

[GitHub] [kafka] philipnee commented on a diff in pull request #13380: KAFKA-14468: Committed API

philipnee commented on code in PR #13380: URL: https://github.com/apache/kafka/pull/13380#discussion_r1136104123 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java: ## @@ -149,6 +185,29 @@ Queue stagedCommits() { return

[GitHub] [kafka] philipnee commented on a diff in pull request #13380: KAFKA-14468: Committed API

philipnee commented on code in PR #13380: URL: https://github.com/apache/kafka/pull/13380#discussion_r1136096815 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java: ## @@ -80,16 +97,18 @@ public CommitRequestManager( */

[GitHub] [kafka] jsancio opened a new pull request, #13396: KAFKA-13884; Only voters flush on Fetch response

jsancio opened a new pull request, #13396: URL: https://github.com/apache/kafka/pull/13396 The leader only requires that voters have flushed their log up to the fetch offset before sending a fetch request. This change only flushes the log when handling the fetch response, if the

[jira] [Resolved] (KAFKA-14794) Unable to deserialize base64 JSON strings

[ https://issues.apache.org/jira/browse/KAFKA-14794?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] José Armando García Sancio resolved KAFKA-14794. Fix Version/s: 3.5.0 Resolution: Fixed > Unable to

[GitHub] [kafka] chia7712 opened a new pull request, #13395: MINOR: don't disconnect stale controller if the network client is res…

chia7712 opened a new pull request, #13395: URL: https://github.com/apache/kafka/pull/13395 the unsent request stored by `InterBrokerSendThread` uses stale controller even though the `NetworkClient` is reset already. The request will get error `NOT_CONTROLLER`, and then the error handle

[GitHub] [kafka] C0urante commented on pull request #13379: KAFKA-14799: Ignore source task requests to abort empty transactions

C0urante commented on PR #13379: URL: https://github.com/apache/kafka/pull/13379#issuecomment-1468683227 Test failures are unrelated; merging. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] C0urante merged pull request #13379: KAFKA-14799: Ignore source task requests to abort empty transactions

C0urante merged PR #13379: URL: https://github.com/apache/kafka/pull/13379 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] mumrah commented on pull request #13390: MINOR: Standardize KRaft logging, thread names, and terminology

mumrah commented on PR #13390: URL: https://github.com/apache/kafka/pull/13390#issuecomment-1468662689 @cmccabe, I see your point about the node ID when debugging tests -- it can be annoying to not know which broker instance a thread belongs to. You're kebab case examples look good to me 

[GitHub] [kafka] C0urante commented on a diff in pull request #13386: Fix logging conditional

C0urante commented on code in PR #13386: URL: https://github.com/apache/kafka/pull/13386#discussion_r1136051929 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerSourceTask.java: ## @@ -216,7 +216,7 @@ public boolean commitOffsets() {

[GitHub] [kafka] mumrah commented on a diff in pull request #13384: KAFKA-14801: Handle sensitive configs during ZK migration

mumrah commented on code in PR #13384: URL: https://github.com/apache/kafka/pull/13384#discussion_r1136050391 ## core/src/test/scala/unit/kafka/zk/ZkMigrationClientTest.scala: ## @@ -49,12 +51,25 @@ class ZkMigrationClientTest extends QuorumTestHarness { private var

[GitHub] [kafka] mumrah commented on a diff in pull request #13368: KAFKA-14796 Migrate ACLs from AclAuthorizor to KRaft

mumrah commented on code in PR #13368: URL: https://github.com/apache/kafka/pull/13368#discussion_r1136047272 ## core/src/main/scala/kafka/zk/ZkMigrationClient.scala: ## @@ -211,12 +214,38 @@ class ZkMigrationClient(zkClient: KafkaZkClient) extends MigrationClient with Lo

[GitHub] [kafka] rajinisivaram commented on a diff in pull request #13368: KAFKA-14796 Migrate ACLs from AclAuthorizor to KRaft

rajinisivaram commented on code in PR #13368: URL: https://github.com/apache/kafka/pull/13368#discussion_r1136044199 ## core/src/main/scala/kafka/zk/ZkMigrationClient.scala: ## @@ -211,12 +214,38 @@ class ZkMigrationClient(zkClient: KafkaZkClient) extends MigrationClient with

[GitHub] [kafka] akhileshchg commented on a diff in pull request #13384: KAFKA-14801: Handle sensitive configs during ZK migration

akhileshchg commented on code in PR #13384: URL: https://github.com/apache/kafka/pull/13384#discussion_r1136044153 ## core/src/test/scala/unit/kafka/zk/ZkMigrationClientTest.scala: ## @@ -49,12 +51,25 @@ class ZkMigrationClientTest extends QuorumTestHarness { private var

[GitHub] [kafka] mumrah commented on a diff in pull request #13384: KAFKA-14801: Handle sensitive configs during ZK migration

mumrah commented on code in PR #13384: URL: https://github.com/apache/kafka/pull/13384#discussion_r1136040540 ## core/src/test/scala/unit/kafka/zk/ZkMigrationClientTest.scala: ## @@ -49,12 +51,25 @@ class ZkMigrationClientTest extends QuorumTestHarness { private var

[GitHub] [kafka] CalvinConfluent commented on a diff in pull request #13323: KAFKA-14617: Add ReplicaState to FetchRequest

CalvinConfluent commented on code in PR #13323: URL: https://github.com/apache/kafka/pull/13323#discussion_r1136021203 ## raft/src/test/java/org/apache/kafka/raft/KafkaRaftClientTest.java: ## @@ -1436,6 +1441,38 @@ public void testInvalidFetchRequest() throws Exception {

[GitHub] [kafka] chia7712 opened a new pull request, #13393: KAFKA-10244 An new java interface to replace 'kafka.common.MessageReader'

chia7712 opened a new pull request, #13393: URL: https://github.com/apache/kafka/pull/13393 related to https://issues.apache.org/jira/browse/KAFKA-10244 `kafka.common.MessageReader` is a input argument of kafka-console-producer and we expect users can have their custom reader to

[GitHub] [kafka] cmccabe merged pull request #13344: MINOR: Replace BrokerMetadataListener with MetadataLoader

cmccabe merged PR #13344: URL: https://github.com/apache/kafka/pull/13344 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] hgeraldino commented on a diff in pull request #13386: Fix logging conditional

hgeraldino commented on code in PR #13386: URL: https://github.com/apache/kafka/pull/13386#discussion_r1135857544 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerSourceTask.java: ## @@ -216,7 +216,7 @@ public boolean commitOffsets() {

[GitHub] [kafka] cmccabe commented on a diff in pull request #13390: MINOR: Standardize KRaft logging, thread names, and terminology

cmccabe commented on code in PR #13390: URL: https://github.com/apache/kafka/pull/13390#discussion_r1135927103 ## core/src/main/scala/kafka/server/ControllerServer.scala: ## @@ -131,11 +131,11 @@ class ControllerServer( if (!maybeChangeStatus(SHUTDOWN, STARTING)) return

[GitHub] [kafka] cmccabe commented on pull request #13390: MINOR: Standardize KRaft logging, thread names, and terminology

cmccabe commented on PR #13390: URL: https://github.com/apache/kafka/pull/13390#issuecomment-1468497417 cc @ijuma @mumrah @hachikuji So about the thread names thing. I’m open to changing the thread names to “kebab case” (i.e. `my-thread-name`) I do think in the context of

[GitHub] [kafka] gharris1727 commented on pull request #13367: KAFKA-14797: Emit offset sync when offset translation lag would exceed max.offset.lag

gharris1727 commented on PR #13367: URL: https://github.com/apache/kafka/pull/13367#issuecomment-1468475024 > One high-level thought: it seems like we've elected to drop integration testing coverage for offset.lag.max = 0 and replace it with offset.lag.max = 10. Do you think there's any

[GitHub] [kafka] gharris1727 commented on a diff in pull request #13367: KAFKA-14797: Emit offset sync when offset translation lag would exceed max.offset.lag

gharris1727 commented on code in PR #13367: URL: https://github.com/apache/kafka/pull/13367#discussion_r1135890001 ## connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorSourceTask.java: ## @@ -315,18 +314,16 @@ static class PartitionState { // true if

[GitHub] [kafka] dajac commented on a diff in pull request #13323: KAFKA-14617: Add ReplicaState to FetchRequest

dajac commented on code in PR #13323: URL: https://github.com/apache/kafka/pull/13323#discussion_r1135754940 ## clients/src/main/java/org/apache/kafka/common/requests/FetchRequest.java: ## @@ -130,10 +131,33 @@ private static Optional optionalEpoch(int rawEpochValue) {

[GitHub] [kafka] hgeraldino commented on a diff in pull request #13386: Fix logging conditional

hgeraldino commented on code in PR #13386: URL: https://github.com/apache/kafka/pull/13386#discussion_r1135857544 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerSourceTask.java: ## @@ -216,7 +216,7 @@ public boolean commitOffsets() {

[GitHub] [kafka] C0urante commented on a diff in pull request #13386: Fix logging conditional

C0urante commented on code in PR #13386: URL: https://github.com/apache/kafka/pull/13386#discussion_r1135813644 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerSourceTask.java: ## @@ -216,7 +216,7 @@ public boolean commitOffsets() {

[GitHub] [kafka] C0urante merged pull request #13392: MINOR: Fix error check in zombie fencing for exactly-once source connectors

C0urante merged PR #13392: URL: https://github.com/apache/kafka/pull/13392 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] mumrah commented on a diff in pull request #13384: KAFKA-14801 : Decode the sensitive configs and Zk and use encrypted records before writing them to KRaft log

mumrah commented on code in PR #13384: URL: https://github.com/apache/kafka/pull/13384#discussion_r1135792879 ## core/src/main/scala/kafka/zk/ZkMigrationClient.scala: ## @@ -135,20 +138,34 @@ class ZkMigrationClient(zkClient: KafkaZkClient) extends MigrationClient with Lo }

[GitHub] [kafka] C0urante commented on pull request #13379: KAFKA-14799: Ignore source task requests to abort empty transactions

C0urante commented on PR #13379: URL: https://github.com/apache/kafka/pull/13379#issuecomment-1468372731 Thanks @chia7712, good catch with that edge case! You're correct about the behavior in that scenario; the record-based boundary is given precedence over the batch-based one. I've

[GitHub] [kafka] chia7712 commented on a diff in pull request #13379: KAFKA-14799: Ignore source task requests to abort empty transactions

chia7712 commented on code in PR #13379: URL: https://github.com/apache/kafka/pull/13379#discussion_r1135751362 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/ExactlyOnceWorkerSourceTask.java: ## @@ -483,15 +483,19 @@ protected boolean

[GitHub] [kafka] mimaison commented on a diff in pull request #13373: Kafka-14420 Use incrementalAlterConfigs API for syncing topic configurations (KIP-894)

mimaison commented on code in PR #13373: URL: https://github.com/apache/kafka/pull/13373#discussion_r1135392026 ## connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorSourceConnector.java: ## @@ -539,11 +596,20 @@ Map describeTopicConfigs(Set topics) }

[jira] [Updated] (KAFKA-14672) Producer queue time does not reflect batches expired in the accumulator

[ https://issues.apache.org/jira/browse/KAFKA-14672?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-14672: -- Description: The producer exposes two metrics for the time a record has spent in the accumulator

[GitHub] [kafka] ijuma commented on a diff in pull request #13390: MINOR: Standardize KRaft logging, thread names, and terminology

ijuma commented on code in PR #13390: URL: https://github.com/apache/kafka/pull/13390#discussion_r1135739560 ## core/src/main/scala/kafka/server/BrokerLifecycleManager.scala: ## @@ -182,7 +182,7 @@ class BrokerLifecycleManager( */ private[server] val eventQueue = new

[GitHub] [kafka] ijuma commented on a diff in pull request #13390: MINOR: Standardize KRaft logging, thread names, and terminology

ijuma commented on code in PR #13390: URL: https://github.com/apache/kafka/pull/13390#discussion_r1135739560 ## core/src/main/scala/kafka/server/BrokerLifecycleManager.scala: ## @@ -182,7 +182,7 @@ class BrokerLifecycleManager( */ private[server] val eventQueue = new

[jira] [Commented] (KAFKA-14750) Sink connector fails if a topic matching its topics.regex gets deleted

[ https://issues.apache.org/jira/browse/KAFKA-14750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17700263#comment-17700263 ] Sagar Rao commented on KAFKA-14750: --- hmm I tried the approach from above and turns out it's not very

[GitHub] [kafka] ijuma commented on a diff in pull request #13390: MINOR: Standardize KRaft logging, thread names, and terminology

ijuma commented on code in PR #13390: URL: https://github.com/apache/kafka/pull/13390#discussion_r1135736972 ## core/src/main/scala/kafka/server/ControllerServer.scala: ## @@ -131,11 +131,11 @@ class ControllerServer( if (!maybeChangeStatus(SHUTDOWN, STARTING)) return

[jira] [Resolved] (KAFKA-10228) producer: NETWORK_EXCEPTION is thrown instead of a request timeout

[ https://issues.apache.org/jira/browse/KAFKA-10228?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True resolved KAFKA-10228. --- Fix Version/s: 3.5.0 Resolution: Duplicate > producer: NETWORK_EXCEPTION is thrown instead

[GitHub] [kafka] C0urante commented on a diff in pull request #13379: KAFKA-14799: Ignore source task requests to abort empty transactions

C0urante commented on code in PR #13379: URL: https://github.com/apache/kafka/pull/13379#discussion_r1135720026 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/ExactlyOnceWorkerSourceTask.java: ## @@ -483,15 +483,19 @@ protected boolean

[GitHub] [kafka] Hangleton commented on pull request #13378: KAFKA-14793: Propagate Topic Ids to the Group Coordinator during Offsets Commit

Hangleton commented on PR #13378: URL: https://github.com/apache/kafka/pull/13378#issuecomment-1468290773 Thanks David @mumrah for the follow-up! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] mumrah commented on a diff in pull request #13372: MINOR: Improved error handling in ZK migration

mumrah commented on code in PR #13372: URL: https://github.com/apache/kafka/pull/13372#discussion_r1135709978 ## metadata/src/main/java/org/apache/kafka/metadata/migration/KRaftMigrationDriver.java: ## @@ -132,26 +132,45 @@ private boolean isControllerQuorumReadyForMigration()

[GitHub] [kafka] C0urante commented on a diff in pull request #11565: KAFKA-13504: Retry connect internal topics' creation in case of InvalidReplicationFactorException

C0urante commented on code in PR #11565: URL: https://github.com/apache/kafka/pull/11565#discussion_r1135694291 ## connect/runtime/src/main/java/org/apache/kafka/connect/storage/KafkaTopicBasedBackingStore.java: ## @@ -0,0 +1,73 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] mumrah commented on pull request #13378: KAFKA-14793: Propagate Topic Ids to the Group Coordinator during Offsets Commit

mumrah commented on PR #13378: URL: https://github.com/apache/kafka/pull/13378#issuecomment-1468256274 @Hangleton, yes we should expect some improvement to ZkMigrationIntegrationTest with that PR. There are some cases where we lose the ZK session during the tests which causes a spurious

[GitHub] [kafka] mumrah commented on a diff in pull request #13390: MINOR: Standardize KRaft logging, thread names, and terminology

mumrah commented on code in PR #13390: URL: https://github.com/apache/kafka/pull/13390#discussion_r1135643036 ## core/src/main/scala/kafka/server/BrokerToControllerChannelManager.scala: ## @@ -238,7 +238,7 @@ class BrokerToControllerChannelManagerImpl( } val

[GitHub] [kafka] C0urante commented on a diff in pull request #13367: KAFKA-14797: Emit offset sync when offset translation lag would exceed max.offset.lag

C0urante commented on code in PR #13367: URL: https://github.com/apache/kafka/pull/13367#discussion_r1135661761 ## connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorSourceTask.java: ## @@ -315,18 +314,16 @@ static class PartitionState { // true if we

[GitHub] [kafka] ijuma commented on a diff in pull request #13390: MINOR: Standardize KRaft logging, thread names, and terminology

ijuma commented on code in PR #13390: URL: https://github.com/apache/kafka/pull/13390#discussion_r1135641916 ## core/src/main/scala/kafka/server/BrokerLifecycleManager.scala: ## @@ -182,7 +182,7 @@ class BrokerLifecycleManager( */ private[server] val eventQueue = new

[GitHub] [kafka] ijuma commented on a diff in pull request #13390: MINOR: Standardize KRaft logging, thread names, and terminology

ijuma commented on code in PR #13390: URL: https://github.com/apache/kafka/pull/13390#discussion_r1135641916 ## core/src/main/scala/kafka/server/BrokerLifecycleManager.scala: ## @@ -182,7 +182,7 @@ class BrokerLifecycleManager( */ private[server] val eventQueue = new

[GitHub] [kafka] C0urante commented on a diff in pull request #11565: KAFKA-13504: Retry connect internal topics' creation in case of InvalidReplicationFactorException

C0urante commented on code in PR #11565: URL: https://github.com/apache/kafka/pull/11565#discussion_r1135639682 ## connect/runtime/src/main/java/org/apache/kafka/connect/util/TopicAdmin.java: ## @@ -70,6 +74,9 @@ public class TopicAdmin implements AutoCloseable { public

[jira] [Commented] (KAFKA-14803) topic deletion bug

[ https://issues.apache.org/jira/browse/KAFKA-14803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17700217#comment-17700217 ] Chris Egerton commented on KAFKA-14803: --- [~bwei9awf] It looks like this is a duplicate of

[jira] [Updated] (KAFKA-14802) topic deletion bug

[ https://issues.apache.org/jira/browse/KAFKA-14802?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Egerton updated KAFKA-14802: -- Environment: AWS m5.xlarge EC2 instance > topic deletion bug > -- > >

[jira] [Resolved] (KAFKA-14803) topic deletion bug

[ https://issues.apache.org/jira/browse/KAFKA-14803?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Egerton resolved KAFKA-14803. --- Resolution: Duplicate > topic deletion bug > -- > > Key:

[jira] [Assigned] (KAFKA-14808) Partition becomes leaderless when new partition reassignment removes the adding replica

[ https://issues.apache.org/jira/browse/KAFKA-14808?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shenglong Zhang reassigned KAFKA-14808: --- Assignee: Shenglong Zhang > Partition becomes leaderless when new partition

[jira] [Created] (KAFKA-14808) Partition becomes leaderless when new partition reassignment removes the adding replica

Shenglong Zhang created KAFKA-14808: --- Summary: Partition becomes leaderless when new partition reassignment removes the adding replica Key: KAFKA-14808 URL: https://issues.apache.org/jira/browse/KAFKA-14808

[GitHub] [kafka] viktorsomogyi commented on a diff in pull request #11565: KAFKA-13504: Retry connect internal topics' creation in case of InvalidReplicationFactorException

viktorsomogyi commented on code in PR #11565: URL: https://github.com/apache/kafka/pull/11565#discussion_r1135376859 ## connect/runtime/src/main/java/org/apache/kafka/connect/util/TopicAdmin.java: ## @@ -328,6 +335,48 @@ public Set createTopics(NewTopic... topics) {

[jira] [Resolved] (KAFKA-14804) Connect docs fail to build with Gradle Swagger plugin 2.2.8

[ https://issues.apache.org/jira/browse/KAFKA-14804?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mickael Maison resolved KAFKA-14804. Fix Version/s: 3.5.0 Resolution: Fixed > Connect docs fail to build with Gradle

[GitHub] [kafka] mimaison merged pull request #13388: MINOR: Align swagger dependencies with gradle plugin

mimaison merged PR #13388: URL: https://github.com/apache/kafka/pull/13388 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] mimaison commented on pull request #13388: MINOR: Align swagger dependencies with gradle plugin

mimaison commented on PR #13388: URL: https://github.com/apache/kafka/pull/13388#issuecomment-1467878813 Build failures are not related, merging -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Updated] (KAFKA-14807) MirrorMaker2 config source.consumer.auto.offset.reset=latest leading to the pause of replication of consumer groups

[ https://issues.apache.org/jira/browse/KAFKA-14807?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhaoli updated KAFKA-14807: --- Description: We use MirrorMaker2 to replicate messages and consumergroup offsets from kafka cluster

[GitHub] [kafka] divijvaidya commented on a diff in pull request #13284: KAFKA-14718: Fix flaky DedicatedMirrorIntegrationTest

divijvaidya commented on code in PR #13284: URL: https://github.com/apache/kafka/pull/13284#discussion_r1135316350 ## connect/mirror/src/test/java/org/apache/kafka/connect/mirror/DedicatedMirrorIntegrationTest.java: ## @@ -62,8 +60,10 @@ public void setup() { @AfterEach

  1   2   >