rohits64 commented on PR #13361:
URL: https://github.com/apache/kafka/pull/13361#issuecomment-1477318855
Hi @mukkachaitanya, thanks for the inputs. I think it we can go with
exponential backoff with some static number of retries. I have made the
changes. Currently I have made the number of
satishd commented on PR #13362:
URL: https://github.com/apache/kafka/pull/13362#issuecomment-1477226052
>LGTM, the only comment is should we make the formatter as a separate file?
@satishd , thoughts?
@showuon I am fine with formatter inside the serde class.
--
This is an
mjsax merged PR #13365:
URL: https://github.com/apache/kafka/pull/13365
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
mjsax commented on code in PR #13365:
URL: https://github.com/apache/kafka/pull/13365#discussion_r1142849436
##
streams/src/main/java/org/apache/kafka/streams/state/internals/LogicalKeyValueSegments.java:
##
@@ -57,6 +57,11 @@ public void openExisting(final ProcessorContext
mjsax commented on PR #13340:
URL: https://github.com/apache/kafka/pull/13340#issuecomment-1477214689
Build failed with checkstyle errors:
```
[ant:checkstyle] [ERROR]
mjsax commented on code in PR #13340:
URL: https://github.com/apache/kafka/pull/13340#discussion_r1142848310
##
streams/src/test/java/org/apache/kafka/streams/integration/VersionedKeyValueStoreIntegrationTest.java:
##
@@ -334,18 +399,65 @@ private final int
mjsax commented on code in PR #13340:
URL: https://github.com/apache/kafka/pull/13340#discussion_r1142848103
##
streams/src/test/java/org/apache/kafka/streams/integration/VersionedKeyValueStoreIntegrationTest.java:
##
@@ -302,7 +319,54 @@ public void
mjsax commented on code in PR #13292:
URL: https://github.com/apache/kafka/pull/13292#discussion_r1142842326
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopologyBuilder.java:
##
@@ -1293,12 +1306,16 @@ private void
[
https://issues.apache.org/jira/browse/KAFKA-7224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17702980#comment-17702980
]
Matthias J. Sax commented on KAFKA-7224:
With
leeleeian commented on PR #13418:
URL: https://github.com/apache/kafka/pull/13418#issuecomment-1477157623
We're discussing the solution for our use case.
Closing this PR for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
leeleeian closed pull request #13418: MINOR: add equals and hashcode methods to
KafkaProducer and ProducerMetadata
URL: https://github.com/apache/kafka/pull/13418
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
jolshan commented on code in PR #13391:
URL: https://github.com/apache/kafka/pull/13391#discussion_r1142788313
##
core/src/main/scala/kafka/server/BrokerServer.scala:
##
@@ -247,6 +248,10 @@ class BrokerServer(
)
alterPartitionManager.start()
+ val
jolshan commented on code in PR #13391:
URL: https://github.com/apache/kafka/pull/13391#discussion_r1142788144
##
core/src/main/scala/kafka/server/AddPartitionsToTxnManager.scala:
##
@@ -0,0 +1,173 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+
jolshan commented on code in PR #13391:
URL: https://github.com/apache/kafka/pull/13391#discussion_r1142787356
##
core/src/main/scala/kafka/server/AddPartitionsToTxnManager.scala:
##
@@ -0,0 +1,173 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+
jolshan commented on code in PR #13391:
URL: https://github.com/apache/kafka/pull/13391#discussion_r1142787086
##
core/src/main/scala/kafka/server/AddPartitionsToTxnManager.scala:
##
@@ -0,0 +1,173 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+
jolshan commented on code in PR #13391:
URL: https://github.com/apache/kafka/pull/13391#discussion_r1142786061
##
core/src/main/scala/kafka/server/AddPartitionsToTxnManager.scala:
##
@@ -0,0 +1,173 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+
artemlivshits commented on code in PR #13391:
URL: https://github.com/apache/kafka/pull/13391#discussion_r1142722842
##
core/src/main/scala/kafka/server/AddPartitionsToTxnManager.scala:
##
@@ -0,0 +1,173 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or
[
https://issues.apache.org/jira/browse/KAFKA-14365?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-14365:
--
Description:
The {{Fetcher}} class is used internally by the {{KafkaConsumer}} to fetch
records from
kirktrue opened a new pull request, #13425:
URL: https://github.com/apache/kafka/pull/13425
The `Fetcher` class is used internally by the `KafkaConsumer` to fetch
records from the brokers. There is ongoing work to create a new consumer
implementation with a significantly refactored
guozhangwang commented on code in PR #13380:
URL: https://github.com/apache/kafka/pull/13380#discussion_r1142683410
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java:
##
@@ -207,6 +226,232 @@ public
[
https://issues.apache.org/jira/browse/KAFKA-14829?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrew Grant updated KAFKA-14829:
-
Description: Currently, we have various bits of reassignment logic spread
across different
[
https://issues.apache.org/jira/browse/KAFKA-14829?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrew Grant updated KAFKA-14829:
-
Description: Currently, we have various bits of reassignment logic spread
across different
artemlivshits commented on code in PR #13391:
URL: https://github.com/apache/kafka/pull/13391#discussion_r1142707455
##
core/src/main/scala/kafka/server/AddPartitionsToTxnManager.scala:
##
@@ -0,0 +1,173 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or
C0urante commented on code in PR #11565:
URL: https://github.com/apache/kafka/pull/11565#discussion_r1142700527
##
connect/runtime/src/main/java/org/apache/kafka/connect/storage/KafkaTopicBasedBackingStore.java:
##
@@ -0,0 +1,73 @@
+/*
+ * Licensed to the Apache Software
C0urante commented on code in PR #13367:
URL: https://github.com/apache/kafka/pull/13367#discussion_r1142683836
##
connect/mirror/src/test/java/org/apache/kafka/connect/mirror/integration/MirrorConnectorsIntegrationBaseTest.java:
##
@@ -416,6 +417,15 @@ public void
[
https://issues.apache.org/jira/browse/KAFKA-14829?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrew Grant updated KAFKA-14829:
-
Priority: Minor (was: Major)
> Consolidate reassignment logic in PartitionReassignmentReplicas
[
https://issues.apache.org/jira/browse/KAFKA-14829?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrew Grant reassigned KAFKA-14829:
Assignee: Andrew Grant
> Consolidate reassignment logic in PartitionReassignmentReplicas
Andrew Grant created KAFKA-14829:
Summary: Consolidate reassignment logic in
PartitionReassignmentReplicas
Key: KAFKA-14829
URL: https://issues.apache.org/jira/browse/KAFKA-14829
Project: Kafka
[
https://issues.apache.org/jira/browse/KAFKA-14823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17702932#comment-17702932
]
Greg Harris commented on KAFKA-14823:
-
Connect currently has an issue where secrets can be changed
C0urante commented on PR #13424:
URL: https://github.com/apache/kafka/pull/13424#issuecomment-1476936722
@mimaison do you think you'll have time to take a look? Hoping to get this
in before the 3.5.0 release but we can punt if there's not enough bandwidth for
review.
--
This is an
C0urante commented on PR #13424:
URL: https://github.com/apache/kafka/pull/13424#issuecomment-1476935983
cc @yashmayya; feel free to review and/or build off of this for KAFKA-14786,
KAFKA-14368, and KAFKA-14784.
--
This is an automated message from the Apache Git Service.
To respond to
[
https://issues.apache.org/jira/browse/KAFKA-14365?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-14365:
--
Summary: Extract common logic from Fetcher (was: Extract common logic from
Fetcher into
C0urante opened a new pull request, #13424:
URL: https://github.com/apache/kafka/pull/13424
[Jira](https://issues.apache.org/jira/browse/KAFKA-14783), [relevant KIP
guozhangwang commented on code in PR #13369:
URL: https://github.com/apache/kafka/pull/13369#discussion_r1142674372
##
streams/src/test/java/org/apache/kafka/streams/integration/StandbyTaskEOSMultiRebalanceIntegrationTest.java:
##
@@ -0,0 +1,304 @@
+/*
+ * Licensed to the
guozhangwang commented on code in PR #13369:
URL: https://github.com/apache/kafka/pull/13369#discussion_r1142669679
##
streams/src/test/java/org/apache/kafka/streams/integration/StandbyTaskEOSMultiRebalanceIntegrationTest.java:
##
@@ -0,0 +1,304 @@
+/*
+ * Licensed to the
guozhangwang merged PR #13347:
URL: https://github.com/apache/kafka/pull/13347
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
guozhangwang commented on PR #13347:
URL: https://github.com/apache/kafka/pull/13347#issuecomment-1476912355
@lucasbru ack (and sorry for late reply)! Will take a look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
jsancio merged PR #13402:
URL: https://github.com/apache/kafka/pull/13402
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
Purshotam Chauhan created KAFKA-14828:
-
Summary: Remove R/W lock from StandardAuthorizer
Key: KAFKA-14828
URL: https://issues.apache.org/jira/browse/KAFKA-14828
Project: Kafka
Issue
[
https://issues.apache.org/jira/browse/KAFKA-14828?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Purshotam Chauhan updated KAFKA-14828:
--
Description: Currently, StandardAuthorizer uses R/W locks to keep the data
consistent
emissionnebula opened a new pull request, #13423:
URL: https://github.com/apache/kafka/pull/13423
What
* Renamed AclAuthorizerBenchmark -> AuthorizerBenchmark
* Updated it to run benchmarks for both AclAuthorizer and StandardAuthorizer
Current benchmark results:
Purshotam Chauhan created KAFKA-14827:
-
Summary: Support for StandardAuthorizer in Benchmark
Key: KAFKA-14827
URL: https://issues.apache.org/jira/browse/KAFKA-14827
Project: Kafka
Issue
lucasbru commented on code in PR #13369:
URL: https://github.com/apache/kafka/pull/13369#discussion_r1142535965
##
streams/src/test/java/org/apache/kafka/streams/integration/StandbyTaskEOSMultiRebalanceIntegrationTest.java:
##
@@ -0,0 +1,304 @@
+/*
+ * Licensed to the Apache
José Armando García Sancio created KAFKA-14826:
--
Summary: Log the completion time for request that resulted in an
error.
Key: KAFKA-14826
URL: https://issues.apache.org/jira/browse/KAFKA-14826
José Armando García Sancio created KAFKA-14825:
--
Summary: Handle divergence between KRaft's HWM and Log's HWM
Key: KAFKA-14825
URL: https://issues.apache.org/jira/browse/KAFKA-14825
[
https://issues.apache.org/jira/browse/KAFKA-14816?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Egerton resolved KAFKA-14816.
---
Reviewer: Justine Olshan
Resolution: Fixed
> Connect loading SSL configs when
jolshan commented on PR #13415:
URL: https://github.com/apache/kafka/pull/13415#issuecomment-1476575571
cherrypicked to 3.4 as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
mimaison opened a new pull request, #13422:
URL: https://github.com/apache/kafka/pull/13422
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including
hudeqi commented on PR #13421:
URL: https://github.com/apache/kafka/pull/13421#issuecomment-1476492254
hello, maybe you are interested in this issue? @chia7712
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
[
https://issues.apache.org/jira/browse/KAFKA-14824?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
hudeqi updated KAFKA-14824:
---
Reviewer: Chia-Ping Tsai
> ReplicaAlterLogDirsThread may cause serious disk usage in case of unknown
>
hudeqi opened a new pull request, #13421:
URL: https://github.com/apache/kafka/pull/13421
For ReplicaAlterLogDirsThread, if the partition is marked as failed due to
an unknown exception and the partition fetch is suspended, the paused cleanup
logic of the partition needs to be canceled,
hudeqi created KAFKA-14824:
--
Summary: ReplicaAlterLogDirsThread may cause serious disk usage in
case of unknown exception
Key: KAFKA-14824
URL: https://issues.apache.org/jira/browse/KAFKA-14824
Project:
mimaison opened a new pull request, #13420:
URL: https://github.com/apache/kafka/pull/13420
New add.source.alias.to.metrics setting to add the source cluster alias to
the MirrorSourceConnector metrics
### Committer Checklist (excluded from commit message)
- [ ] Verify design
C0urante commented on PR #13415:
URL: https://github.com/apache/kafka/pull/13415#issuecomment-1476461304
Thanks Justine!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
jolshan merged PR #13415:
URL: https://github.com/apache/kafka/pull/13415
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
mimaison opened a new pull request, #13419:
URL: https://github.com/apache/kafka/pull/13419
Add a new configuration replace.null.with.default to allow using null
instead of the default value.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and
viktorsomogyi commented on code in PR #11565:
URL: https://github.com/apache/kafka/pull/11565#discussion_r114295
##
connect/runtime/src/main/java/org/apache/kafka/connect/util/TopicAdmin.java:
##
@@ -328,6 +335,48 @@ public Set createTopics(NewTopic... topics) {
C0urante commented on code in PR #13415:
URL: https://github.com/apache/kafka/pull/13415#discussion_r1142078897
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/rest/RestClient.java:
##
@@ -97,7 +98,11 @@ public HttpResponse httpRequest(String url, String
C0urante commented on code in PR #13415:
URL: https://github.com/apache/kafka/pull/13415#discussion_r1142078897
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/rest/RestClient.java:
##
@@ -97,7 +98,11 @@ public HttpResponse httpRequest(String url, String
C0urante commented on PR #13418:
URL: https://github.com/apache/kafka/pull/13418#issuecomment-1476186302
Thanks for providing more detail. I'm still confused about this part:
> The default equals method compares by address. But this is not what we
want.
Wouldn't comparison by
dengziming merged PR #13403:
URL: https://github.com/apache/kafka/pull/13403
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/KAFKA-14784?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yash Mayya reassigned KAFKA-14784:
--
Assignee: Yash Mayya
> Implement connector offset reset REST API
>
[
https://issues.apache.org/jira/browse/KAFKA-14785?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yash Mayya reassigned KAFKA-14785:
--
Assignee: Yash Mayya
> Implement connector offset read REST API
>
Schm1tz1 commented on PR #12992:
URL: https://github.com/apache/kafka/pull/12992#issuecomment-1475939063
> Can you reply to the DISCUSS/VOTE threads explaining the changes you made
since the KIP was accepted?
Sure, just sent an update to the KIP thread:
Mickael Maison created KAFKA-14823:
--
Summary: Clean up ConfigProvider API
Key: KAFKA-14823
URL: https://issues.apache.org/jira/browse/KAFKA-14823
Project: Kafka
Issue Type: Improvement
Mickael Maison created KAFKA-14822:
--
Summary: Allow restricting File and Directory ConfigProviders to
specific paths
Key: KAFKA-14822
URL: https://issues.apache.org/jira/browse/KAFKA-14822
Project:
mimaison commented on PR #12992:
URL: https://github.com/apache/kafka/pull/12992#issuecomment-1475905586
Can you reply to the DISCUSS/VOTE threads explaining the changes you made
since the KIP was accepted?
--
This is an automated message from the Apache Git Service.
To respond to the
Dimitar Dimitrov created KAFKA-14821:
Summary: Better handle timeouts in ListOffsets API
Key: KAFKA-14821
URL: https://issues.apache.org/jira/browse/KAFKA-14821
Project: Kafka
Issue
akatona84 commented on code in PR #11565:
URL: https://github.com/apache/kafka/pull/11565#discussion_r1141776979
##
connect/runtime/src/main/java/org/apache/kafka/connect/util/TopicAdmin.java:
##
@@ -328,6 +335,48 @@ public Set createTopics(NewTopic... topics) {
return
akatona84 commented on code in PR #11565:
URL: https://github.com/apache/kafka/pull/11565#discussion_r1141771004
##
connect/runtime/src/main/java/org/apache/kafka/connect/storage/KafkaTopicBasedBackingStore.java:
##
@@ -0,0 +1,73 @@
+/*
+ * Licensed to the Apache Software
dajac commented on code in PR #13350:
URL: https://github.com/apache/kafka/pull/13350#discussion_r1141731445
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignor.java:
##
@@ -495,8 +615,8 @@ private class ConstrainedAssignmentBuilder
yashmayya commented on code in PR #13415:
URL: https://github.com/apache/kafka/pull/13415#discussion_r1141704800
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/rest/RestClient.java:
##
@@ -97,7 +98,11 @@ public HttpResponse httpRequest(String url, String
72 matches
Mail list logo
