[GitHub] [kafka] vamossagar12 commented on pull request #13453: KAFKA-12525: Ignoring Stale status statuses when reading from Status …

2023-03-25 Thread via GitHub
vamossagar12 commented on PR #13453: URL: https://github.com/apache/kafka/pull/13453#issuecomment-1483978300 @yashmayya , @gharris1727 , @C0urante Plz review whenever you get the chance. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [kafka] vamossagar12 opened a new pull request, #13453: KAFKA-12525: Ignoring Stale status statuses when reading from Status …

2023-03-25 Thread via GitHub
vamossagar12 opened a new pull request, #13453: URL: https://github.com/apache/kafka/pull/13453 During fast consecutive rebalances where a task is revoked from one worker and assigned to another one, it has been observed that there is a small time window and thus a race condition during

[jira] [Assigned] (KAFKA-12525) Inaccurate task status due to status record interleaving in fast rebalances in Connect

2023-03-25 Thread Sagar Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12525?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sagar Rao reassigned KAFKA-12525: - Assignee: Sagar Rao (was: Konstantine Karantasis) > Inaccurate task status due to status

[jira] [Updated] (KAFKA-14848) KafkaConsumer incorrectly passes locally-scoped deserializers to FetchConfig

2023-03-25 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14848?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-14848: -- Description: [~rayokota] found some {{{}NullPointerException{}}}s that originate because of a

[jira] [Updated] (KAFKA-14848) KafkaConsumer incorrectly passes locally-scoped deserializers to FetchConfig

2023-03-25 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14848?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-14848: -- Summary: KafkaConsumer incorrectly passes locally-scoped deserializers to FetchConfig (was:

[GitHub] [kafka] kirktrue opened a new pull request, #13452: KAFKA-14848: KafkaConsumer incorrectly passes locally-scoped serializers to FetchConfig

2023-03-25 Thread via GitHub
kirktrue opened a new pull request, #13452: URL: https://github.com/apache/kafka/pull/13452 Fix for a NPE bug that was caused by referring to a local variable and not the instance variable of the deserializers. See fix suggestion from @rayokota:

[jira] [Updated] (KAFKA-14848) KafkaConsumer incorrectly passes locally-scoped serializers to FetchConfig

2023-03-25 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14848?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-14848: -- Description: [~rayokota] found some {{{}NullPointerException{}}}s that originate because of a

[jira] [Created] (KAFKA-14848) KafkaConsumer incorrectly passes locally-scoped serializers to FetchConfig

2023-03-25 Thread Kirk True (Jira)
Kirk True created KAFKA-14848: - Summary: KafkaConsumer incorrectly passes locally-scoped serializers to FetchConfig Key: KAFKA-14848 URL: https://issues.apache.org/jira/browse/KAFKA-14848 Project: Kafka

[GitHub] [kafka] dajac commented on a diff in pull request #13408: KAFKA-14617: Update AlterPartitionRequest and enable Kraft controller to reject stale request.

2023-03-25 Thread via GitHub
dajac commented on code in PR #13408: URL: https://github.com/apache/kafka/pull/13408#discussion_r1148431864 ## metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java: ## @@ -1156,9 +1169,32 @@ private Errors validateAlterPartitionData( }

[GitHub] [kafka] dajac commented on a diff in pull request #13408: KAFKA-14617: Update AlterPartitionRequest and enable Kraft controller to reject stale request.

2023-03-25 Thread via GitHub
dajac commented on code in PR #13408: URL: https://github.com/apache/kafka/pull/13408#discussion_r1148431780 ## metadata/src/main/java/org/apache/kafka/controller/ClusterControlManager.java: ## @@ -596,6 +596,11 @@ public void checkBrokerEpoch(int brokerId, long brokerEpoch) {

[GitHub] [kafka] dajac commented on a diff in pull request #13408: KAFKA-14617: Update AlterPartitionRequest and enable Kraft controller to reject stale request.

2023-03-25 Thread via GitHub
dajac commented on code in PR #13408: URL: https://github.com/apache/kafka/pull/13408#discussion_r1148431107 ## metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java: ## @@ -1930,4 +1966,24 @@ public String toString() { return replicaId

[GitHub] [kafka] rondagostino commented on pull request #13437: KAFKA-14828: Remove R/W locks using persistent data structures

2023-03-25 Thread via GitHub
rondagostino commented on PR #13437: URL: https://github.com/apache/kafka/pull/13437#issuecomment-1483915474 Thanks @emissionnebula! This is great information to consider when evaluating these libraries. A requirement to use `tailSet()` on a sorted set does not exist in the metadata

[GitHub] [kafka] chia7712 commented on pull request #13393: KAFKA-10244 An new java interface to replace 'kafka.common.MessageReader'

2023-03-25 Thread via GitHub
chia7712 commented on PR #13393: URL: https://github.com/apache/kafka/pull/13393#issuecomment-1483899781 > we need to enable javadoc generation for it. Have we done that? I will address it later. > should probably not add new ones for public apis due to

[jira] [Updated] (KAFKA-14847) Separate the callers of commitAllTasks v.s. commitTasks for EOS(-v2) and ALOS

2023-03-25 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14847?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-14847: Description: Today, EOS-v2/v1 and ALOS shares the same internal callpath inside

[GitHub] [kafka] ijuma commented on pull request #13393: KAFKA-10244 An new java interface to replace 'kafka.common.MessageReader'

2023-03-25 Thread via GitHub
ijuma commented on PR #13393: URL: https://github.com/apache/kafka/pull/13393#issuecomment-1483895151 One additional issue is that we are introducing a new "split packages" situation. We already have some of those, but we should probably not add new ones for public apis due to

[jira] [Updated] (KAFKA-14847) Separate the callers of commitAllTasks v.s. commitTasks for EOS(-v2) and ALOS

2023-03-25 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14847?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-14847: Description: Today, EOS-v2/v1 and ALOS shares the same internal callpath inside

[jira] [Updated] (KAFKA-14847) Separate the callers of commitAllTasks v.s. commitTasks for EOS(-v2) and ALOS

2023-03-25 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14847?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-14847: Description: Today, EOS-v2/v1 and ALOS shares the same internal callpath inside

[GitHub] [kafka] ijuma commented on pull request #13393: KAFKA-10244 An new java interface to replace 'kafka.common.MessageReader'

2023-03-25 Thread via GitHub
ijuma commented on PR #13393: URL: https://github.com/apache/kafka/pull/13393#issuecomment-1483894522 Since this is a public api, we need to enable javadoc generation for it. Have we done that? -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [kafka] chia7712 commented on pull request #13450: MINOR: doc: fix typo in config-streams

2023-03-25 Thread via GitHub
chia7712 commented on PR #13450: URL: https://github.com/apache/kafka/pull/13450#issuecomment-1483857657 @iblislin thanks for patch! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [kafka] chia7712 merged pull request #13450: MINOR: doc: fix typo in config-streams

2023-03-25 Thread via GitHub
chia7712 merged PR #13450: URL: https://github.com/apache/kafka/pull/13450 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] iblislin commented on a diff in pull request #13450: MINOR: doc: fix typo in config-streams

2023-03-25 Thread via GitHub
iblislin commented on code in PR #13450: URL: https://github.com/apache/kafka/pull/13450#discussion_r1148394667 ## docs/streams/developer-guide/config-streams.html: ## @@ -216,7 +216,7 @@ num.standby.replicas

[GitHub] [kafka] iblislin commented on a diff in pull request #13450: MINOR: doc: fix typo in config-streams

2023-03-25 Thread via GitHub
iblislin commented on code in PR #13450: URL: https://github.com/apache/kafka/pull/13450#discussion_r1148394423 ## docs/streams/developer-guide/config-streams.html: ## @@ -216,7 +216,7 @@

[GitHub] [kafka] chia7712 commented on a diff in pull request #13450: MINOR: doc: fix typo in config-streams

2023-03-25 Thread via GitHub
chia7712 commented on code in PR #13450: URL: https://github.com/apache/kafka/pull/13450#discussion_r1148388588 ## docs/streams/developer-guide/config-streams.html: ## @@ -216,7 +216,7 @@ num.standby.replicas

[jira] [Resolved] (KAFKA-10244) An new java interface to replace 'kafka.common.MessageReader'

2023-03-25 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10244?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-10244. Fix Version/s: 3.5.0 Resolution: Fixed > An new java interface to replace

[GitHub] [kafka] chia7712 merged pull request #13393: KAFKA-10244 An new java interface to replace 'kafka.common.MessageReader'

2023-03-25 Thread via GitHub
chia7712 merged PR #13393: URL: https://github.com/apache/kafka/pull/13393 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] chia7712 commented on pull request #13326: KAFKA-14774 the removed listeners should not be reconfigurable

2023-03-25 Thread via GitHub
chia7712 commented on PR #13326: URL: https://github.com/apache/kafka/pull/13326#issuecomment-1483823016 @mimaison thanks for feedback. Have better naming in latest commit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [kafka] yashmayya commented on a diff in pull request #13434: KAFKA-14785: Connect offset read REST API

2023-03-25 Thread via GitHub
yashmayya commented on code in PR #13434: URL: https://github.com/apache/kafka/pull/13434#discussion_r1148315133 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/Worker.java: ## @@ -1133,6 +1139,105 @@ public void setTargetState(String connName, TargetState

[GitHub] [kafka] songnon opened a new pull request, #13451: KAFKA-14808: fix leaderless partition issue when controller removes u…

2023-03-25 Thread via GitHub
songnon opened a new pull request, #13451: URL: https://github.com/apache/kafka/pull/13451 …nneeded replicas If there is ongoing partition reassignment and any adding replica has been elected as leader (due to preferred leader election or other reason), the partition will

[jira] [Updated] (KAFKA-14845) Broker ZNode creation can fail due to a session ID unknown to the broker

2023-03-25 Thread Alexandre Dupriez (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14845?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexandre Dupriez updated KAFKA-14845: -- Description: Our production environment faced a use case where registration of a

[jira] [Updated] (KAFKA-14845) Broker ZNode creation can fail due to a session ID unknown to the broker

2023-03-25 Thread Alexandre Dupriez (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14845?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexandre Dupriez updated KAFKA-14845: -- Description: Our production environment faced a use case where registration of a

[jira] [Updated] (KAFKA-14845) Broker ZNode creation can fail due to a session ID unknown to the broker

2023-03-25 Thread Alexandre Dupriez (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14845?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexandre Dupriez updated KAFKA-14845: -- Description: Our production environment faced a use case where registration of a

[jira] [Updated] (KAFKA-14845) Broker ZNode creation can fail due to a session ID unknown to the broker

2023-03-25 Thread Alexandre Dupriez (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14845?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexandre Dupriez updated KAFKA-14845: -- Description: Our production environment faced a use case where registration of a

[GitHub] [kafka] rayokota commented on pull request #13425: KAFKA-14365: Extract common logic from Fetcher

2023-03-25 Thread via GitHub
rayokota commented on PR #13425: URL: https://github.com/apache/kafka/pull/13425#issuecomment-1483750202 @guozhangwang , @kirktrue , this PR is causing NPEs downstream. I've added a comment above that indicates the bad lines. Thanks. -- This is an automated message from the Apache Git

[GitHub] [kafka] rayokota commented on a diff in pull request #13425: KAFKA-14365: Extract common logic from Fetcher

2023-03-25 Thread via GitHub
rayokota commented on code in PR #13425: URL: https://github.com/apache/kafka/pull/13425#discussion_r1148320558 ## clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java: ## @@ -797,24 +799,15 @@ public KafkaConsumer(Map configs,

[GitHub] [kafka] rayokota commented on a diff in pull request #13425: KAFKA-14365: Extract common logic from Fetcher

2023-03-25 Thread via GitHub
rayokota commented on code in PR #13425: URL: https://github.com/apache/kafka/pull/13425#discussion_r1148320365 ## clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java: ## @@ -797,24 +799,15 @@ public KafkaConsumer(Map configs,

[GitHub] [kafka] rayokota commented on a diff in pull request #13425: KAFKA-14365: Extract common logic from Fetcher

2023-03-25 Thread via GitHub
rayokota commented on code in PR #13425: URL: https://github.com/apache/kafka/pull/13425#discussion_r1148316785 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/CompletedFetch.java: ## @@ -306,10 +297,10 @@ ConsumerRecord parseRecord(TopicPartition

[GitHub] [kafka] rayokota commented on a diff in pull request #13425: KAFKA-14365: Extract common logic from Fetcher

2023-03-25 Thread via GitHub
rayokota commented on code in PR #13425: URL: https://github.com/apache/kafka/pull/13425#discussion_r1148316785 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/CompletedFetch.java: ## @@ -306,10 +297,10 @@ ConsumerRecord parseRecord(TopicPartition