[jira] [Resolved] (KAFKA-14864) Memory leak in KStreamWindowAggregate with ON_WINDOW_CLOSE emit strategy

[ https://issues.apache.org/jira/browse/KAFKA-14864?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax resolved KAFKA-14864. - Fix Version/s: 3.4.1 3.3.3 Resolution: Fixed > Memory leak in

[GitHub] [kafka] mjsax commented on pull request #13470: KAFKA-14864: Close iterator in KStream windowed aggregation emit on window close

mjsax commented on PR #13470: URL: https://github.com/apache/kafka/pull/13470#issuecomment-1495353048 Thx. Merged to `trunk` and cherry-picked to `3.4` and `3.3` branches. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[jira] [Commented] (KAFKA-14722) Make BooleanSerde public

[ https://issues.apache.org/jira/browse/KAFKA-14722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17708211#comment-17708211 ] Matthias J. Sax commented on KAFKA-14722: - The docs PRs was not merged yet – thus the work is

[jira] [Updated] (KAFKA-14722) Make BooleanSerde public

[ https://issues.apache.org/jira/browse/KAFKA-14722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-14722: Fix Version/s: 3.5.0 > Make BooleanSerde public > > >

[jira] [Updated] (KAFKA-14864) Memory leak in KStreamWindowAggregate with ON_WINDOW_CLOSE emit strategy

[ https://issues.apache.org/jira/browse/KAFKA-14864?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-14864: Affects Version/s: 3.3.2 3.4.0 > Memory leak in

[GitHub] [kafka] mjsax opened a new pull request, #13498: MINOR: fix log statement

mjsax opened a new pull request, #13498: URL: https://github.com/apache/kafka/pull/13498 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of testing

[GitHub] [kafka] mjsax merged pull request #13470: KAFKA-14864: Close iterator in KStream windowed aggregation emit on window close

mjsax merged PR #13470: URL: https://github.com/apache/kafka/pull/13470 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] mjsax merged pull request #13431: KAFKA-14491: [19/N] Combine versioned store RocksDB instances into one

mjsax merged PR #13431: URL: https://github.com/apache/kafka/pull/13431 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] mjsax merged pull request #13364: KAFKA-14491: [16/N] Add recovery logic for store inconsistency due to failed write

mjsax merged PR #13364: URL: https://github.com/apache/kafka/pull/13364 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] ijuma commented on a diff in pull request #13454: MINOR: move RecordReader from org.apache.kafka.tools to org.apache.co…

ijuma commented on code in PR #13454: URL: https://github.com/apache/kafka/pull/13454#discussion_r1156697756 ## clients/src/main/java/org/apache/kafka/common/RecordReader.java: ## @@ -14,10 +14,9 @@ * See the License for the specific language governing permissions and *

[GitHub] [kafka] junrao commented on a diff in pull request #13451: KAFKA-14808: fix leaderless partition issue when controller removes u…

junrao commented on code in PR #13451: URL: https://github.com/apache/kafka/pull/13451#discussion_r1156683028 ## core/src/main/scala/kafka/controller/KafkaController.scala: ## @@ -802,8 +802,11 @@ class KafkaController(val config: KafkaConfig, // If there is a

[GitHub] [kafka] songnon commented on pull request #13451: KAFKA-14808: fix leaderless partition issue when controller removes u…

songnon commented on PR #13451: URL: https://github.com/apache/kafka/pull/13451#issuecomment-1495270760 @junrao I couldn't find your comment. It's lost somehow. :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [kafka] hudeqi commented on pull request #13473: KAFKA-14866:Remove controller module metrics when broker is shutting down

hudeqi commented on PR #13473: URL: https://github.com/apache/kafka/pull/13473#issuecomment-1495258058 And this pr. thx! @showuon -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [kafka] hudeqi commented on pull request #13471: KAFKA-14868:Remove some forgotten metrics when the replicaManager is closed

hudeqi commented on PR #13471: URL: https://github.com/apache/kafka/pull/13471#issuecomment-1495257711 Hi, could you help to review this pr? @showuon -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [kafka] vcrfxia opened a new pull request, #13497: KAFKA-14834: [2/N] Test coverage for out-of-order data in joins

vcrfxia opened a new pull request, #13497: URL: https://github.com/apache/kafka/pull/13497 In preparation for updating DSL join processors to have updated semantics when versioned stores are used (cf

[GitHub] [kafka] vcrfxia opened a new pull request, #13496: KAFKA-14834: [1/N] Add timestamped get to KTableValueGetter

vcrfxia opened a new pull request, #13496: URL: https://github.com/apache/kafka/pull/13496 (This PR is stacked on https://github.com/apache/kafka/pull/13442. Only the last commit needs to be reviewed separately.) In preparation for updating DSL processors to use versioned stores (cf

[GitHub] [kafka] guozhangwang commented on a diff in pull request #11433: KAFKA-13295: Avoiding Transation timeouts arising due to long restora…

guozhangwang commented on code in PR #11433: URL: https://github.com/apache/kafka/pull/11433#discussion_r1156551492 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java: ## @@ -342,7 +342,18 @@ public void handleAssignment(final Map>

[GitHub] [kafka] kirktrue opened a new pull request, #13495: KAFKA-14274: Introduce FetchRequestManager to integrate fetch into new consumer threading refactor

kirktrue opened a new pull request, #13495: URL: https://github.com/apache/kafka/pull/13495 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgrade

[GitHub] [kafka] pprovenzano commented on pull request #13374: KAFKA-14765 and KAFKA-14776: Support for SCRAM at bootstrap with integration tests

pprovenzano commented on PR #13374: URL: https://github.com/apache/kafka/pull/13374#issuecomment-1495078769 > I looked in `org.apache.kafka.clients.admin.ScramMechanism` and didn't see any message about the other ScramMechanism enum. So it seems like someone changing this code could still

[GitHub] [kafka] jolshan commented on a diff in pull request #13463: KAFKA-14854: Refactor inter broker send thread to handle all interbroker requests on one thread

jolshan commented on code in PR #13463: URL: https://github.com/apache/kafka/pull/13463#discussion_r1156508649 ## core/src/main/scala/kafka/common/InterBrokerSender.scala: ## @@ -45,10 +45,15 @@ abstract class InterBrokerSendThread( private val unsentRequests = new

[GitHub] [kafka] jolshan commented on a diff in pull request #13463: KAFKA-14854: Refactor inter broker send thread to handle all interbroker requests on one thread

jolshan commented on code in PR #13463: URL: https://github.com/apache/kafka/pull/13463#discussion_r1156509464 ## core/src/main/scala/kafka/common/InterBrokerSender.scala: ## @@ -156,6 +163,16 @@ abstract class InterBrokerSendThread( def wakeup(): Unit =

[GitHub] [kafka] jolshan commented on a diff in pull request #13463: KAFKA-14854: Refactor inter broker send thread to handle all interbroker requests on one thread

jolshan commented on code in PR #13463: URL: https://github.com/apache/kafka/pull/13463#discussion_r1156508649 ## core/src/main/scala/kafka/common/InterBrokerSender.scala: ## @@ -45,10 +45,15 @@ abstract class InterBrokerSendThread( private val unsentRequests = new

[GitHub] [kafka] artemlivshits commented on a diff in pull request #13463: KAFKA-14854: Refactor inter broker send thread to handle all interbroker requests on one thread

artemlivshits commented on code in PR #13463: URL: https://github.com/apache/kafka/pull/13463#discussion_r1156501035 ## core/src/main/scala/kafka/common/InterBrokerSender.scala: ## @@ -45,10 +45,15 @@ abstract class InterBrokerSendThread( private val unsentRequests = new

[GitHub] [kafka] pprovenzano commented on a diff in pull request #13374: KAFKA-14765 and KAFKA-14776: Support for SCRAM at bootstrap with integration tests

pprovenzano commented on code in PR #13374: URL: https://github.com/apache/kafka/pull/13374#discussion_r1156501556 ## clients/src/main/java/org/apache/kafka/common/security/scram/internals/ScramMechanism.java: ## @@ -40,11 +48,13 @@ public enum ScramMechanism {

[GitHub] [kafka] pprovenzano commented on a diff in pull request #13374: KAFKA-14765 and KAFKA-14776: Support for SCRAM at bootstrap with integration tests

pprovenzano commented on code in PR #13374: URL: https://github.com/apache/kafka/pull/13374#discussion_r1156501112 ## core/src/main/scala/kafka/tools/StorageTool.scala: ## @@ -235,9 +379,21 @@ object StorageTool extends Logging { metaProperties:

[GitHub] [kafka] junrao commented on a diff in pull request #13454: MINOR: move RecordReader from org.apache.kafka.tools to org.apache.co…

junrao commented on code in PR #13454: URL: https://github.com/apache/kafka/pull/13454#discussion_r1156500801 ## clients/src/main/java/org/apache/kafka/common/RecordReader.java: ## @@ -14,10 +14,9 @@ * See the License for the specific language governing permissions and *

[GitHub] [kafka] pprovenzano commented on a diff in pull request #13374: KAFKA-14765 and KAFKA-14776: Support for SCRAM at bootstrap with integration tests

pprovenzano commented on code in PR #13374: URL: https://github.com/apache/kafka/pull/13374#discussion_r1156499455 ## core/src/test/java/kafka/testkit/KafkaClusterTestKit.java: ## @@ -395,9 +395,7 @@ private void formatNodeAndLog(MetaProperties properties, String

[GitHub] [kafka] jolshan commented on a diff in pull request #13463: KAFKA-14854: Refactor inter broker send thread to handle all interbroker requests on one thread

jolshan commented on code in PR #13463: URL: https://github.com/apache/kafka/pull/13463#discussion_r1156496683 ## core/src/main/scala/kafka/common/InterBrokerSender.scala: ## @@ -156,6 +163,16 @@ abstract class InterBrokerSendThread( def wakeup(): Unit =

[GitHub] [kafka] jolshan commented on a diff in pull request #13463: KAFKA-14854: Refactor inter broker send thread to handle all interbroker requests on one thread

jolshan commented on code in PR #13463: URL: https://github.com/apache/kafka/pull/13463#discussion_r1156496361 ## core/src/main/scala/kafka/common/InterBrokerSender.scala: ## @@ -45,10 +45,15 @@ abstract class InterBrokerSendThread( private val unsentRequests = new

[GitHub] [kafka] jolshan commented on a diff in pull request #13463: KAFKA-14854: Refactor inter broker send thread to handle all interbroker requests on one thread

jolshan commented on code in PR #13463: URL: https://github.com/apache/kafka/pull/13463#discussion_r1156496118 ## core/src/main/scala/kafka/coordinator/transaction/TransactionCoordinator.scala: ## @@ -59,8 +61,9 @@ object TransactionCoordinator { time, metrics)

[GitHub] [kafka] artemlivshits commented on a diff in pull request #13463: KAFKA-14854: Refactor inter broker send thread to handle all interbroker requests on one thread

artemlivshits commented on code in PR #13463: URL: https://github.com/apache/kafka/pull/13463#discussion_r1156488622 ## core/src/main/scala/kafka/coordinator/transaction/TransactionCoordinator.scala: ## @@ -59,8 +61,9 @@ object TransactionCoordinator { time, metrics)

[GitHub] [kafka] philipnee commented on a diff in pull request #13269: KAFKA-12634 enforce checkpoint after restoration

philipnee commented on code in PR #13269: URL: https://github.com/apache/kafka/pull/13269#discussion_r1156483833 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamTaskTest.java: ## @@ -2484,6 +2511,48 @@ public void

[GitHub] [kafka] philipnee commented on a diff in pull request #13269: KAFKA-12634 enforce checkpoint after restoration

philipnee commented on code in PR #13269: URL: https://github.com/apache/kafka/pull/13269#discussion_r1156483107 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamTaskTest.java: ## @@ -44,6 +44,7 @@ import org.apache.kafka.common.utils.MockTime;

[GitHub] [kafka] philipnee commented on pull request #13269: KAFKA-12634 enforce checkpoint after restoration

philipnee commented on PR #13269: URL: https://github.com/apache/kafka/pull/13269#issuecomment-1495021777 Hey @cadonna - Again, thanks for the reviews; sorry for the auto-cleanup for my IDE, I've cleaned up most of the unnecessary changes. -- This is an automated message from the Apache

[GitHub] [kafka] junrao merged pull request #13480: MINOR: Fix typos in `security.html`

junrao merged PR #13480: URL: https://github.com/apache/kafka/pull/13480 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] junrao commented on a diff in pull request #13463: KAFKA-14854: Refactor inter broker send thread to handle all interbroker requests on one thread

junrao commented on code in PR #13463: URL: https://github.com/apache/kafka/pull/13463#discussion_r1156467464 ## core/src/main/scala/kafka/coordinator/transaction/TransactionCoordinator.scala: ## @@ -59,8 +61,9 @@ object TransactionCoordinator { time, metrics) val

[GitHub] [kafka] junrao commented on a diff in pull request #13463: KAFKA-14854: Refactor inter broker send thread to handle all interbroker requests on one thread

junrao commented on code in PR #13463: URL: https://github.com/apache/kafka/pull/13463#discussion_r1156467080 ## core/src/main/scala/kafka/common/InterBrokerSender.scala: ## @@ -156,6 +163,16 @@ abstract class InterBrokerSendThread( def wakeup(): Unit =

[GitHub] [kafka] junrao commented on a diff in pull request #13463: KAFKA-14854: Refactor inter broker send thread to handle all interbroker requests on one thread

junrao commented on code in PR #13463: URL: https://github.com/apache/kafka/pull/13463#discussion_r1156466725 ## core/src/main/scala/kafka/common/InterBrokerSender.scala: ## @@ -45,10 +45,15 @@ abstract class InterBrokerSendThread( private val unsentRequests = new

[GitHub] [kafka] cmccabe commented on a diff in pull request #13374: KAFKA-14765 and KAFKA-14776: Support for SCRAM at bootstrap with integration tests

cmccabe commented on code in PR #13374: URL: https://github.com/apache/kafka/pull/13374#discussion_r1156401794 ## core/src/test/java/kafka/testkit/KafkaClusterTestKit.java: ## @@ -395,9 +395,7 @@ private void formatNodeAndLog(MetaProperties properties, String metadataLogDir,

[GitHub] [kafka] cmccabe commented on a diff in pull request #13374: KAFKA-14765 and KAFKA-14776: Support for SCRAM at bootstrap with integration tests

cmccabe commented on code in PR #13374: URL: https://github.com/apache/kafka/pull/13374#discussion_r1156401424 ## core/src/main/scala/kafka/tools/StorageTool.scala: ## @@ -235,9 +379,21 @@ object StorageTool extends Logging { metaProperties: MetaProperties,

[GitHub] [kafka] cmccabe commented on a diff in pull request #13374: KAFKA-14765 and KAFKA-14776: Support for SCRAM at bootstrap with integration tests

cmccabe commented on code in PR #13374: URL: https://github.com/apache/kafka/pull/13374#discussion_r1156400641 ## clients/src/main/java/org/apache/kafka/common/security/scram/internals/ScramMechanism.java: ## @@ -40,11 +48,13 @@ public enum ScramMechanism {

[GitHub] [kafka] cmccabe commented on pull request #13374: KAFKA-14765 and KAFKA-14776: Support for SCRAM at bootstrap with integration tests

cmccabe commented on PR #13374: URL: https://github.com/apache/kafka/pull/13374#issuecomment-1494895163 I looked in `org.apache.kafka.clients.admin.ScramMechanism` and didn't see any message about the other ScramMechanism enum. So it seems like someone changing this code could still make a

[jira] [Resolved] (KAFKA-6007) Connect can't validate against transforms in plugins.path

[ https://issues.apache.org/jira/browse/KAFKA-6007?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Harris resolved KAFKA-6007. Assignee: Greg Harris (was: Konstantine Karantasis) Resolution: Fixed > Connect can't

[jira] [Updated] (KAFKA-6007) Connect can't validate against transforms in plugins.path

[ https://issues.apache.org/jira/browse/KAFKA-6007?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Harris updated KAFKA-6007: --- Fix Version/s: 1.0.3 1.1.2 2.0.2 2.1.2

[jira] [Commented] (KAFKA-6007) Connect can't validate against transforms in plugins.path

[ https://issues.apache.org/jira/browse/KAFKA-6007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17708085#comment-17708085 ] Greg Harris commented on KAFKA-6007: I believe that this failure mode was addressed in

[GitHub] [kafka] rondagostino commented on pull request #13280: KAFKA-14735: Improve KRaft metadata image change performance at high …

rondagostino commented on PR #13280: URL: https://github.com/apache/kafka/pull/13280#issuecomment-1494811199 The persistent collection library space remain unsettled (frustrating that it would remain this way even after so many years). I therefore added wrapper classes and import controls

[GitHub] [kafka] dorwi commented on pull request #13494: MINOR: update the batch size connect task metrics documentation

dorwi commented on PR #13494: URL: https://github.com/apache/kafka/pull/13494#issuecomment-1494781625 It was not clear in the documentation whether the size referred to the batch size in bytes or it was the number of records. Changed the wording as it's done for example in

[jira] [Commented] (KAFKA-14237) Kafka TLS Doesn't Present Intermediary Certificates when using PEM

[ https://issues.apache.org/jira/browse/KAFKA-14237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17708071#comment-17708071 ] Manikumar commented on KAFKA-14237: --- [~sophokles73] Thanks for your interest. You can take a look at

[GitHub] [kafka] lucasbru commented on pull request #11433: KAFKA-13295: Avoiding Transation timeouts arising due to long restora…

lucasbru commented on PR #11433: URL: https://github.com/apache/kafka/pull/11433#issuecomment-1494744241 > Regarding system tests, is there a way to trigger via Jenkins ? (Sorry I am not aware of this).

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #13443: KAFKA-14514: Add Server Side Sticky Range Assignor (KIP-848)

rreddy-22 commented on code in PR #13443: URL: https://github.com/apache/kafka/pull/13443#discussion_r1156255508 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/assignor/ServerSideStickyRangeAssignorTest.java: ## @@ -0,0 +1,389 @@ +/* + * Licensed to the

[GitHub] [kafka] jeffkbkim commented on a diff in pull request #13443: KAFKA-14514: Add Server Side Sticky Range Assignor (KIP-848)

jeffkbkim commented on code in PR #13443: URL: https://github.com/apache/kafka/pull/13443#discussion_r1156251873 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/assignor/ServerSideStickyRangeAssignorTest.java: ## @@ -0,0 +1,389 @@ +/* + * Licensed to the

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #13443: KAFKA-14514: Add Server Side Sticky Range Assignor (KIP-848)

rreddy-22 commented on code in PR #13443: URL: https://github.com/apache/kafka/pull/13443#discussion_r1156241130 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/assignor/ServerSideStickyRangeAssignorTest.java: ## @@ -0,0 +1,389 @@ +/* + * Licensed to the

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #13443: KAFKA-14514: Add Server Side Sticky Range Assignor (KIP-848)

rreddy-22 commented on code in PR #13443: URL: https://github.com/apache/kafka/pull/13443#discussion_r1156240340 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/ServerSideStickyRangeAssignor.java: ## @@ -0,0 +1,268 @@ +/* + * Licensed to the

[GitHub] [kafka] gharris1727 commented on pull request #13466: MINOR: Fix base ConfigDef in AbstractHerder::connectorPluginConfig

gharris1727 commented on PR #13466: URL: https://github.com/apache/kafka/pull/13466#issuecomment-1494694048 @mimaison can you merge and backport this, as Chris is offline? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [kafka] jolshan commented on a diff in pull request #13463: KAFKA-14854: Refactor inter broker send thread to handle all interbroker requests on one thread

jolshan commented on code in PR #13463: URL: https://github.com/apache/kafka/pull/13463#discussion_r1156237705 ## core/src/main/scala/kafka/common/InterBrokerSender.scala: ## @@ -45,10 +45,15 @@ abstract class InterBrokerSendThread( private val unsentRequests = new

[GitHub] [kafka] jolshan commented on a diff in pull request #13463: KAFKA-14854: Refactor inter broker send thread to handle all interbroker requests on one thread

jolshan commented on code in PR #13463: URL: https://github.com/apache/kafka/pull/13463#discussion_r1156236037 ## core/src/main/scala/kafka/common/InterBrokerSender.scala: ## @@ -156,6 +163,16 @@ abstract class InterBrokerSendThread( def wakeup(): Unit =

[GitHub] [kafka] vamossagar12 commented on pull request #11433: KAFKA-13295: Avoiding Transation timeouts arising due to long restora…

vamossagar12 commented on PR #11433: URL: https://github.com/apache/kafka/pull/11433#issuecomment-1494691660 @guozhangwang , thanks for another round of review. Regarding system tests, is there a way to trigger via Jenkins ? (Sorry I am not aware of this). -- This is an automated message

[GitHub] [kafka] jolshan commented on a diff in pull request #13463: KAFKA-14854: Refactor inter broker send thread to handle all interbroker requests on one thread

jolshan commented on code in PR #13463: URL: https://github.com/apache/kafka/pull/13463#discussion_r1156235480 ## core/src/main/scala/kafka/coordinator/transaction/TransactionCoordinator.scala: ## @@ -59,8 +61,9 @@ object TransactionCoordinator { time, metrics)

[GitHub] [kafka] vamossagar12 commented on a diff in pull request #11433: KAFKA-13295: Avoiding Transation timeouts arising due to long restora…

vamossagar12 commented on code in PR #11433: URL: https://github.com/apache/kafka/pull/11433#discussion_r1156233120 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java: ## @@ -342,7 +342,18 @@ public void handleAssignment(final Map>

[GitHub] [kafka] vamossagar12 commented on a diff in pull request #11433: KAFKA-13295: Avoiding Transation timeouts arising due to long restora…

vamossagar12 commented on code in PR #11433: URL: https://github.com/apache/kafka/pull/11433#discussion_r1156232890 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java: ## @@ -342,7 +342,18 @@ public void handleAssignment(final Map>

[GitHub] [kafka] vamossagar12 commented on a diff in pull request #11433: KAFKA-13295: Avoiding Transation timeouts arising due to long restora…

vamossagar12 commented on code in PR #11433: URL: https://github.com/apache/kafka/pull/11433#discussion_r1156231874 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java: ## @@ -342,7 +342,18 @@ public void handleAssignment(final Map>

[GitHub] [kafka] fvaleri commented on pull request #13492: KAFKA-14752: Kafka examples improvements

fvaleri commented on PR #13492: URL: https://github.com/apache/kafka/pull/13492#issuecomment-1494641695 Hi @divijvaidya, I restored the original layout to make review easier. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [kafka] philipnee commented on a diff in pull request #13269: KAFKA-12634 enforce checkpoint after restoration

philipnee commented on code in PR #13269: URL: https://github.com/apache/kafka/pull/13269#discussion_r1156197845 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamTaskTest.java: ## @@ -2484,6 +2505,34 @@ public void

[GitHub] [kafka] philipnee commented on a diff in pull request #13269: KAFKA-12634 enforce checkpoint after restoration

philipnee commented on code in PR #13269: URL: https://github.com/apache/kafka/pull/13269#discussion_r1156196422 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamTaskTest.java: ## @@ -1692,43 +1699,45 @@ public void

[GitHub] [kafka] SpacRocket commented on a diff in pull request #13491: KAFKA-14722: Make BooleanSerde public (an addition of upgrade.html changes)

SpacRocket commented on code in PR #13491: URL: https://github.com/apache/kafka/pull/13491#discussion_r1156179615 ## docs/upgrade.html: ## @@ -19,6 +19,75 @@

[GitHub] [kafka] philipnee commented on a diff in pull request #13269: KAFKA-12634 enforce checkpoint after restoration

philipnee commented on code in PR #13269: URL: https://github.com/apache/kafka/pull/13269#discussion_r1156165447 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamTaskTest.java: ## @@ -1692,43 +1699,45 @@ public void

[GitHub] [kafka] philipnee commented on a diff in pull request #13269: KAFKA-12634 enforce checkpoint after restoration

philipnee commented on code in PR #13269: URL: https://github.com/apache/kafka/pull/13269#discussion_r1156164789 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamTask.java: ## @@ -255,6 +255,9 @@ public void completeRestoration(final

[jira] [Resolved] (KAFKA-14871) Kafka Connect - TTL not respected for Config Provider-provided connector configurations

[ https://issues.apache.org/jira/browse/KAFKA-14871?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dave Sloan resolved KAFKA-14871. Resolution: Abandoned After discussing with my colleagues, we have come to the conclusion that

[jira] [Commented] (KAFKA-14581) Move GetOffsetShell to tools

[ https://issues.apache.org/jira/browse/KAFKA-14581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17708011#comment-17708011 ] Ruslan Krivoshein commented on KAFKA-14581: --- Let it be booked for me, please > Move

[GitHub] [kafka] jeffkbkim commented on a diff in pull request #13443: KAFKA-14514: Add Server Side Sticky Range Assignor (KIP-848)

jeffkbkim commented on code in PR #13443: URL: https://github.com/apache/kafka/pull/13443#discussion_r1156090957 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/assignor/ServerSideStickyRangeAssignorTest.java: ## @@ -0,0 +1,389 @@ +/* + * Licensed to the

[GitHub] [kafka] dorwi opened a new pull request, #13494: MINOR: update the batch size connect task metrics documentation

dorwi opened a new pull request, #13494: URL: https://github.com/apache/kafka/pull/13494 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgrade notes)

[GitHub] [kafka] jeffkbkim commented on a diff in pull request #13463: KAFKA-14854: Refactor inter broker send thread to handle all interbroker requests on one thread

jeffkbkim commented on code in PR #13463: URL: https://github.com/apache/kafka/pull/13463#discussion_r1156037401 ## core/src/main/scala/kafka/common/InterBrokerSender.scala: ## @@ -156,6 +163,16 @@ abstract class InterBrokerSendThread( def wakeup(): Unit =

[GitHub] [kafka] divijvaidya commented on a diff in pull request #13456: KAFKA-14850: introduce InMemoryLeaderEpochCheckpoint

divijvaidya commented on code in PR #13456: URL: https://github.com/apache/kafka/pull/13456#discussion_r1155911890 ## storage/src/main/java/org/apache/kafka/storage/internals/epoch/LeaderEpochFileCache.java: ## @@ -147,6 +152,16 @@ private List removeWhileMatching(Iterator

[GitHub] [kafka] Hangleton opened a new pull request, #13493: KAFKA-14852: Propagate Topic Ids to the Group Coordinator for Offset Fetch

Hangleton opened a new pull request, #13493: URL: https://github.com/apache/kafka/pull/13493 This task is the sibling of [PR-13378](https://github.com/apache/kafka/pull/13378) which propagates topic ids in the group coordinator on the offset commit (write) path. The purpose of this PR is

[GitHub] [kafka] showuon commented on a diff in pull request #13487: KAFKA-9550 Copying log segments to tiered storage in RemoteLogManager

showuon commented on code in PR #13487: URL: https://github.com/apache/kafka/pull/13487#discussion_r1155880909 ## storage/src/main/java/org/apache/kafka/storage/internals/epoch/LeaderEpochFileCache.java: ## @@ -359,6 +361,27 @@ public OptionalInt epochForOffset(long offset) {

[GitHub] [kafka] showuon commented on a diff in pull request #13456: KAFKA-14850: introduce InMemoryLeaderEpochCheckpoint

showuon commented on code in PR #13456: URL: https://github.com/apache/kafka/pull/13456#discussion_r1155878999 ## storage/src/main/java/org/apache/kafka/storage/internals/checkpoint/InMemoryLeaderEpochCheckpoint.java: ## @@ -0,0 +1,58 @@ +/* + * Licensed to the Apache Software

[jira] [Created] (KAFKA-14877) refactor

Luke Chen created KAFKA-14877: - Summary: refactor Key: KAFKA-14877 URL: https://issues.apache.org/jira/browse/KAFKA-14877 Project: Kafka Issue Type: Sub-task Reporter: Luke Chen

[jira] [Updated] (KAFKA-14877) refactor InMemoryLeaderEpochCheckpoint

[ https://issues.apache.org/jira/browse/KAFKA-14877?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen updated KAFKA-14877: -- Summary: refactor InMemoryLeaderEpochCheckpoint (was: refactor ) > refactor

[GitHub] [kafka] showuon commented on a diff in pull request #13456: KAFKA-14850: introduce InMemoryLeaderEpochCheckpoint

showuon commented on code in PR #13456: URL: https://github.com/apache/kafka/pull/13456#discussion_r1155876324 ## storage/src/main/java/org/apache/kafka/storage/internals/epoch/LeaderEpochFileCache.java: ## @@ -383,21 +398,25 @@ public void clear() { // Visible for

[GitHub] [kafka] hudeqi commented on pull request #13473: KAFKA-14866:Remove controller module metrics when broker is shutting down

hudeqi commented on PR #13473: URL: https://github.com/apache/kafka/pull/13473#issuecomment-1494104389 > Added a nit, otherwise code looks good to me. As a general suggestion for this and future PRs, it helps the reviewer if your description has the following sections: > > ``` >

[GitHub] [kafka] divijvaidya commented on pull request #13492: KAFKA-14752: Kafka examples improvements

divijvaidya commented on PR #13492: URL: https://github.com/apache/kafka/pull/13492#issuecomment-1494096264 May I suggest having different PRs for package change and the actual code changes? It would help view the diff of changes clearly. -- This is an automated message from the Apache

[GitHub] [kafka] cadonna commented on a diff in pull request #13269: KAFKA-12634 enforce checkpoint after restoration

cadonna commented on code in PR #13269: URL: https://github.com/apache/kafka/pull/13269#discussion_r1155775071 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamTaskTest.java: ## @@ -1692,43 +1699,45 @@ public void

[GitHub] [kafka] divijvaidya commented on a diff in pull request #13491: KAFKA-14722: Make BooleanSerde public (an addition of upgrade.html changes)

divijvaidya commented on code in PR #13491: URL: https://github.com/apache/kafka/pull/13491#discussion_r1155795184 ## docs/upgrade.html: ## @@ -19,6 +19,75 @@

[GitHub] [kafka] divijvaidya commented on a diff in pull request #13473: KAFKA-14866:Remove controller module metrics when broker is shutting down

divijvaidya commented on code in PR #13473: URL: https://github.com/apache/kafka/pull/13473#discussion_r1155781010 ## core/src/test/scala/unit/kafka/controller/KafkaControllerTest.scala: ## @@ -0,0 +1,75 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [kafka] mimaison merged pull request #13325: KAFKA-14771: Include threads info in ConcurrentModificationException message

mimaison merged PR #13325: URL: https://github.com/apache/kafka/pull/13325 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] pierDipi commented on a diff in pull request #13325: KAFKA-14771: Include threads info in ConcurrentModificationException message

pierDipi commented on code in PR #13325: URL: https://github.com/apache/kafka/pull/13325#discussion_r1155728488 ## clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java: ## @@ -2547,9 +2547,13 @@ private void acquireAndEnsureOpen() { * @throws

[jira] [Commented] (KAFKA-14746) Throwing in Connector.taskConfigs in distributed mode generates a lot of logs

[ https://issues.apache.org/jira/browse/KAFKA-14746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17707886#comment-17707886 ] Mickael Maison commented on KAFKA-14746: To be honest I'm not sure if we should change this

[GitHub] [kafka] mimaison commented on a diff in pull request #13325: KAFKA-14771: Include threads info in ConcurrentModificationException message

mimaison commented on code in PR #13325: URL: https://github.com/apache/kafka/pull/13325#discussion_r1155674207 ## clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java: ## @@ -2547,9 +2547,13 @@ private void acquireAndEnsureOpen() { * @throws

[jira] [Resolved] (KAFKA-14450) Rack-aware partition assignment for consumers (KIP-881)

[ https://issues.apache.org/jira/browse/KAFKA-14450?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajini Sivaram resolved KAFKA-14450. Resolution: Fixed > Rack-aware partition assignment for consumers (KIP-881) >

[jira] [Resolved] (KAFKA-14452) Make sticky assignors rack-aware if consumer racks are configured.

[ https://issues.apache.org/jira/browse/KAFKA-14452?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajini Sivaram resolved KAFKA-14452. Fix Version/s: 3.5.0 Reviewer: David Jacot Resolution: Fixed > Make

[GitHub] [kafka] rajinisivaram merged pull request #13350: KAFKA-14452: Make sticky assignors rack-aware if client rack is configured (KIP-881)

rajinisivaram merged PR #13350: URL: https://github.com/apache/kafka/pull/13350 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] rajinisivaram commented on pull request #13350: KAFKA-14452: Make sticky assignors rack-aware if client rack is configured (KIP-881)

rajinisivaram commented on PR #13350: URL: https://github.com/apache/kafka/pull/13350#issuecomment-1493889009 @dajac Thanks for the reviews. Test failures not related, merging to trunk. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [kafka] emissionnebula commented on pull request #13437: KAFKA-14828: Remove R/W locks using persistent data structures

emissionnebula commented on PR #13437: URL: https://github.com/apache/kafka/pull/13437#issuecomment-1493821132 > Since you mentioned, "authorizer is quite read-heavy with very infrequent writes", and given the above risk highlighted above, would having slow writes with CopyOnWrite be an

[jira] [Commented] (KAFKA-14868) Remove some forgotten metrics when the replicaManager is closed

[ https://issues.apache.org/jira/browse/KAFKA-14868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17707796#comment-17707796 ] hudeqi commented on KAFKA-14868: The problem of not closing the metric in the replicaManager has been

[jira] [Updated] (KAFKA-14868) Remove some forgotten metrics when the replicaManager is closed

[ https://issues.apache.org/jira/browse/KAFKA-14868?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] hudeqi updated KAFKA-14868: --- Summary: Remove some forgotten metrics when the replicaManager is closed (was: Add metric counting

[GitHub] [kafka] fvaleri opened a new pull request, #13492: KAFKA-14752: Kafka examples improvements

fvaleri opened a new pull request, #13492: URL: https://github.com/apache/kafka/pull/13492 This is an attempt to improve the Kafka examples module. There is some heavy refactoring and minor fixes, but the original logic and script interface is kept. Below you can find the list of