[jira] [Created] (KAFKA-14889) RemoteLogManager - allow consumer fetch records from remote storage implementation

Luke Chen created KAFKA-14889: - Summary: RemoteLogManager - allow consumer fetch records from remote storage implementation Key: KAFKA-14889 URL: https://issues.apache.org/jira/browse/KAFKA-14889

[jira] [Assigned] (KAFKA-14888) RemoteLogManager - deleting expired/size breached log segments to remote storage implementation

[ https://issues.apache.org/jira/browse/KAFKA-14888?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen reassigned KAFKA-14888: - Assignee: Luke Chen > RemoteLogManager - deleting expired/size breached log segments to remote

[jira] [Assigned] (KAFKA-14889) RemoteLogManager - allow consumer fetch records from remote storage implementation

[ https://issues.apache.org/jira/browse/KAFKA-14889?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen reassigned KAFKA-14889: - Assignee: Satish Duggana > RemoteLogManager - allow consumer fetch records from remote storage

[GitHub] [kafka] vcrfxia commented on a diff in pull request #13496: KAFKA-14834: [1/N] Add timestamped get to KTableValueGetter

vcrfxia commented on code in PR #13496: URL: https://github.com/apache/kafka/pull/13496#discussion_r1162213072 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/KTableKTableInnerJoin.java: ## @@ -153,11 +154,37 @@ public void init(final ProcessorContext

[jira] [Created] (KAFKA-14888) RemoteLogManager - deleting expired/size breached log segments to remote storage implementation

Luke Chen created KAFKA-14888: - Summary: RemoteLogManager - deleting expired/size breached log segments to remote storage implementation Key: KAFKA-14888 URL: https://issues.apache.org/jira/browse/KAFKA-14888

[jira] [Updated] (KAFKA-14834) Improved processor semantics for versioned stores

[ https://issues.apache.org/jira/browse/KAFKA-14834?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Victoria Xia updated KAFKA-14834: - Description: With the introduction of versioned state stores in

[GitHub] [kafka] ijuma commented on a diff in pull request #13280: KAFKA-14735: Improve KRaft metadata image change performance at high …

ijuma commented on code in PR #13280: URL: https://github.com/apache/kafka/pull/13280#discussion_r1162191919 ## server-common/src/main/java/org/apache/kafka/server/immutable/ImmutableMap.java: ## @@ -0,0 +1,47 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [kafka] ijuma commented on a diff in pull request #13280: KAFKA-14735: Improve KRaft metadata image change performance at high …

ijuma commented on code in PR #13280: URL: https://github.com/apache/kafka/pull/13280#discussion_r1162191307 ## server-common/src/main/java/org/apache/kafka/server/immutable/ImmutableMap.java: ## @@ -0,0 +1,47 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [kafka] ijuma commented on a diff in pull request #13280: KAFKA-14735: Improve KRaft metadata image change performance at high …

ijuma commented on code in PR #13280: URL: https://github.com/apache/kafka/pull/13280#discussion_r1162191307 ## server-common/src/main/java/org/apache/kafka/server/immutable/ImmutableMap.java: ## @@ -0,0 +1,47 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [kafka] rondagostino commented on a diff in pull request #13280: KAFKA-14735: Improve KRaft metadata image change performance at high …

rondagostino commented on code in PR #13280: URL: https://github.com/apache/kafka/pull/13280#discussion_r1162184665 ## server-common/src/main/java/org/apache/kafka/server/immutable/ImmutableMap.java: ## @@ -0,0 +1,47 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] rondagostino commented on a diff in pull request #13280: KAFKA-14735: Improve KRaft metadata image change performance at high …

rondagostino commented on code in PR #13280: URL: https://github.com/apache/kafka/pull/13280#discussion_r1162184505 ## server-common/src/main/java/org/apache/kafka/server/immutable/ImmutableMap.java: ## @@ -0,0 +1,47 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] rondagostino commented on pull request #13532: KAFKA-14887: No shutdown for ZK session expiration in feature processing

rondagostino commented on PR #13532: URL: https://github.com/apache/kafka/pull/13532#issuecomment-1502480192 Test failures are unrelated. `MirrorConnectorsWithCustomForwardingAdminIntegrationTest` passed locally. -- This is an automated message from the Apache Git Service. To respond to

[jira] [Assigned] (KAFKA-14887) ZK session timeout can cause broker to shutdown

[ https://issues.apache.org/jira/browse/KAFKA-14887?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ron Dagostino reassigned KAFKA-14887: - Assignee: Ron Dagostino > ZK session timeout can cause broker to shutdown >

[GitHub] [kafka] philipnee commented on a diff in pull request #13490: KAFKA-14875: Implement wakeup

philipnee commented on code in PR #13490: URL: https://github.com/apache/kafka/pull/13490#discussion_r1162151428 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/PrototypeAsyncConsumer.java: ## @@ -447,6 +482,19 @@ public void close() { @Override

[GitHub] [kafka] mjsax opened a new pull request, #13534: KAFKA-14054: Handle TimeoutException gracefully

mjsax opened a new pull request, #13534: URL: https://github.com/apache/kafka/pull/13534 We incorrectly assumed, that `consumer.position()` should always be served by the consumer locally set position. However, within `commitNeeded()` we check if first `if(commitNeeded)` and thus go

[GitHub] [kafka] cmccabe commented on pull request #13280: KAFKA-14735: Improve KRaft metadata image change performance at high …

cmccabe commented on PR #13280: URL: https://github.com/apache/kafka/pull/13280#issuecomment-1502416844 > Yes, updated would only make sense on the map interface. For the Set interface, added seems reasonable. Sorry to bikeshed this again but I kinda like `withAdded`, `withRemoval`,

[GitHub] [kafka] cmccabe commented on pull request #13280: KAFKA-14735: Improve KRaft metadata image change performance at high …

cmccabe commented on PR #13280: URL: https://github.com/apache/kafka/pull/13280#issuecomment-1502415755 @ijuma @rondagostino : I feel like "persistent" should appear somewhere in the class names here. Perhaps you're right that it doesn't need to be in the short class name, but can we put

[GitHub] [kafka] cmccabe commented on a diff in pull request #13280: KAFKA-14735: Improve KRaft metadata image change performance at high …

cmccabe commented on code in PR #13280: URL: https://github.com/apache/kafka/pull/13280#discussion_r1162134827 ## server-common/src/main/java/org/apache/kafka/server/immutable/ImmutableMap.java: ## @@ -0,0 +1,47 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [kafka] vvcephei commented on a diff in pull request #13490: KAFKA-14875: Implement wakeup

vvcephei commented on code in PR #13490: URL: https://github.com/apache/kafka/pull/13490#discussion_r1162130597 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/PrototypeAsyncConsumer.java: ## @@ -447,6 +482,19 @@ public void close() { @Override

[GitHub] [kafka] cmccabe commented on a diff in pull request #13280: KAFKA-14735: Improve KRaft metadata image change performance at high …

cmccabe commented on code in PR #13280: URL: https://github.com/apache/kafka/pull/13280#discussion_r1162131601 ## server-common/src/main/java/org/apache/kafka/server/immutable/ImmutableMap.java: ## @@ -0,0 +1,47 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [kafka] cmccabe commented on a diff in pull request #13280: KAFKA-14735: Improve KRaft metadata image change performance at high …

cmccabe commented on code in PR #13280: URL: https://github.com/apache/kafka/pull/13280#discussion_r1162131601 ## server-common/src/main/java/org/apache/kafka/server/immutable/ImmutableMap.java: ## @@ -0,0 +1,47 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [kafka] cmccabe commented on a diff in pull request #13280: KAFKA-14735: Improve KRaft metadata image change performance at high …

cmccabe commented on code in PR #13280: URL: https://github.com/apache/kafka/pull/13280#discussion_r1162129955 ## server-common/src/main/java/org/apache/kafka/server/immutable/ImmutableMap.java: ## @@ -0,0 +1,47 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [kafka] cmccabe commented on a diff in pull request #13280: KAFKA-14735: Improve KRaft metadata image change performance at high …

cmccabe commented on code in PR #13280: URL: https://github.com/apache/kafka/pull/13280#discussion_r1162128357 ## metadata/src/main/java/org/apache/kafka/image/TopicsImage.java: ## @@ -76,8 +84,8 @@ public TopicImage getTopic(String name) { } public void

[GitHub] [kafka] cmccabe commented on a diff in pull request #13280: KAFKA-14735: Improve KRaft metadata image change performance at high …

cmccabe commented on code in PR #13280: URL: https://github.com/apache/kafka/pull/13280#discussion_r1162128357 ## metadata/src/main/java/org/apache/kafka/image/TopicsImage.java: ## @@ -76,8 +84,8 @@ public TopicImage getTopic(String name) { } public void

[jira] [Assigned] (KAFKA-14054) Unexpected client shutdown as TimeoutException is thrown as IllegalStateException

[ https://issues.apache.org/jira/browse/KAFKA-14054?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax reassigned KAFKA-14054: --- Assignee: Matthias J. Sax > Unexpected client shutdown as TimeoutException is

[GitHub] [kafka] mjsax commented on pull request #13269: KAFKA-12634 enforce checkpoint after restoration

mjsax commented on PR #13269: URL: https://github.com/apache/kafka/pull/13269#issuecomment-1502392008 @cadonna -- Should we cherry-pick to 3.4 branch? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [kafka] mjsax commented on pull request #10747: KAFKA-12446: Call subtractor before adder if key is the same

mjsax commented on PR #10747: URL: https://github.com/apache/kafka/pull/10747#issuecomment-1502379032 Follow up PR to user varint encoding: https://github.com/apache/kafka/pull/13533 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] mjsax opened a new pull request, #13533: KAFKA-12446: update change encoding to use varint

mjsax opened a new pull request, #13533: URL: https://github.com/apache/kafka/pull/13533 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of testing

[GitHub] [kafka] jeffkbkim commented on a diff in pull request #13476: KAFKA-14462; [4/N] Add GroupMetadataManager: ConsumerGroups Management, Members Management and Reconciliation Logic

jeffkbkim commented on code in PR #13476: URL: https://github.com/apache/kafka/pull/13476#discussion_r1161913599 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -0,0 +1,873 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] guozhangwang commented on a diff in pull request #13523: MINOR: Follow-up on failing streams test, and fix StoreChangelogReader

guozhangwang commented on code in PR #13523: URL: https://github.com/apache/kafka/pull/13523#discussion_r1162110812 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/StoreChangelogReader.java: ## @@ -988,6 +1005,14 @@ private void prepareChangelogs(final Map

[GitHub] [kafka] jolshan commented on a diff in pull request #13391: KAFKA-14561: Improve transactions experience for older clients by ensuring ongoing transaction

jolshan commented on code in PR #13391: URL: https://github.com/apache/kafka/pull/13391#discussion_r1162109668 ## core/src/main/scala/kafka/network/RequestChannel.scala: ## @@ -354,6 +361,7 @@ class RequestChannel(val queueSize: Int, private val processors = new

[GitHub] [kafka] guozhangwang commented on a diff in pull request #13523: MINOR: Follow-up on failing streams test, and fix StoreChangelogReader

guozhangwang commented on code in PR #13523: URL: https://github.com/apache/kafka/pull/13523#discussion_r1162107892 ## streams/src/test/java/org/apache/kafka/streams/integration/PauseResumeIntegrationTest.java: ## @@ -188,12 +188,11 @@ public void

[GitHub] [kafka] cmccabe commented on a diff in pull request #13280: KAFKA-14735: Improve KRaft metadata image change performance at high …

cmccabe commented on code in PR #13280: URL: https://github.com/apache/kafka/pull/13280#discussion_r1162107641 ## metadata/src/main/java/org/apache/kafka/image/TopicsImage.java: ## @@ -21,41 +21,48 @@ import org.apache.kafka.image.writer.ImageWriter; import

[GitHub] [kafka] guozhangwang commented on a diff in pull request #13523: MINOR: Follow-up on failing streams test, and fix StoreChangelogReader

guozhangwang commented on code in PR #13523: URL: https://github.com/apache/kafka/pull/13523#discussion_r1162102863 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/StoreChangelogReader.java: ## @@ -880,6 +896,9 @@ private void initializeChangelogs(final

[GitHub] [kafka] cmccabe commented on a diff in pull request #13513: KAFKA-14881: Update UserScramCredentialRecord for SCRAM ZK to KRaft migration

cmccabe commented on code in PR #13513: URL: https://github.com/apache/kafka/pull/13513#discussion_r1162102531 ## metadata/src/main/java/org/apache/kafka/metadata/migration/KRaftMigrationDriver.java: ## @@ -458,8 +458,9 @@ public void run() throws Exception {

[GitHub] [kafka] cmccabe commented on a diff in pull request #13513: KAFKA-14881: Update UserScramCredentialRecord for SCRAM ZK to KRaft migration

cmccabe commented on code in PR #13513: URL: https://github.com/apache/kafka/pull/13513#discussion_r1162102172 ## metadata/src/main/java/org/apache/kafka/metadata/migration/KRaftMigrationDriver.java: ## @@ -458,8 +458,9 @@ public void run() throws Exception {

[GitHub] [kafka] cmccabe commented on pull request #13513: KAFKA-14881: Update UserScramCredentialRecord for SCRAM ZK to KRaft migration

cmccabe commented on PR #13513: URL: https://github.com/apache/kafka/pull/13513#issuecomment-1502329503 > Should I move ScramCredentialData.java from metadata/src/main/java/org/apache/kafka/image to metadata/src/main/java/org/apache/kafka/metadata ? yes, please. -- This is an

[GitHub] [kafka] rondagostino opened a new pull request, #13532: KAFKA-14887: No shutdown for ZK session expiration in feature processing

rondagostino opened a new pull request, #13532: URL: https://github.com/apache/kafka/pull/13532 `FinalizedFeatureChangeListener` shuts the broker down when it encounters an issue trying to process feature change events, but it does not distinguish between issues related to feature changes

[jira] [Created] (KAFKA-14887) ZK session timeout can cause broker to shutdown

Ron Dagostino created KAFKA-14887: - Summary: ZK session timeout can cause broker to shutdown Key: KAFKA-14887 URL: https://issues.apache.org/jira/browse/KAFKA-14887 Project: Kafka Issue

[GitHub] [kafka] mjsax commented on pull request #10747: KAFKA-12446: Call subtractor before adder if key is the same

mjsax commented on PR #10747: URL: https://github.com/apache/kafka/pull/10747#issuecomment-1502280780 Thanks for the quick turn around time! Merged. We can still do a follow up on the open question with regard to the serialization format. Using `Bytes.putInt()` should actually do. --

[GitHub] [kafka] mjsax merged pull request #10747: KAFKA-12446: Call subtractor before adder if key is the same

mjsax merged PR #10747: URL: https://github.com/apache/kafka/pull/10747 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] mjsax commented on a diff in pull request #10747: KAFKA-12446: Call subtractor before adder if key is the same

mjsax commented on code in PR #10747: URL: https://github.com/apache/kafka/pull/10747#discussion_r1162058460 ## docs/streams/upgrade-guide.html: ## @@ -75,6 +75,20 @@ < changelogs. + +Downgrading from 3.5.x or newer version to 3.4.x or older version

[GitHub] [kafka] mjsax commented on a diff in pull request #10747: KAFKA-12446: Call subtractor before adder if key is the same

mjsax commented on code in PR #10747: URL: https://github.com/apache/kafka/pull/10747#discussion_r1162056271 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/KTableRepartitionMap.java: ## @@ -76,6 +79,48 @@ public boolean enableSendingOldValues(final boolean

[GitHub] [kafka] mjsax commented on a diff in pull request #10747: KAFKA-12446: Call subtractor before adder if key is the same

mjsax commented on code in PR #10747: URL: https://github.com/apache/kafka/pull/10747#discussion_r1162055509 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/ChangedSerializer.java: ## @@ -45,34 +49,87 @@ public void setIfUnset(final SerdeGetter getter) {

[GitHub] [kafka] jolshan commented on a diff in pull request #13391: KAFKA-14561: Improve transactions experience for older clients by ensuring ongoing transaction

jolshan commented on code in PR #13391: URL: https://github.com/apache/kafka/pull/13391#discussion_r1162049144 ## core/src/main/scala/kafka/server/AddPartitionsToTxnManager.scala: ## @@ -0,0 +1,180 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or more +

[GitHub] [kafka] jolshan commented on a diff in pull request #13391: KAFKA-14561: Improve transactions experience for older clients by ensuring ongoing transaction

jolshan commented on code in PR #13391: URL: https://github.com/apache/kafka/pull/13391#discussion_r1162047588 ## core/src/main/scala/kafka/server/KafkaRequestHandler.scala: ## @@ -69,20 +108,52 @@ class KafkaRequestHandler(id: Int, completeShutdown()

[GitHub] [kafka] jolshan commented on a diff in pull request #13391: KAFKA-14561: Improve transactions experience for older clients by ensuring ongoing transaction

jolshan commented on code in PR #13391: URL: https://github.com/apache/kafka/pull/13391#discussion_r1162047387 ## core/src/main/scala/kafka/server/KafkaRequestHandler.scala: ## @@ -69,20 +108,52 @@ class KafkaRequestHandler(id: Int, completeShutdown()

[GitHub] [kafka] jolshan commented on a diff in pull request #13391: KAFKA-14561: Improve transactions experience for older clients by ensuring ongoing transaction

jolshan commented on code in PR #13391: URL: https://github.com/apache/kafka/pull/13391#discussion_r1162046736 ## core/src/main/scala/kafka/server/KafkaRequestHandler.scala: ## @@ -69,20 +108,52 @@ class KafkaRequestHandler(id: Int, completeShutdown()

[GitHub] [kafka] jolshan commented on a diff in pull request #13391: KAFKA-14561: Improve transactions experience for older clients by ensuring ongoing transaction

jolshan commented on code in PR #13391: URL: https://github.com/apache/kafka/pull/13391#discussion_r1162045551 ## core/src/main/scala/kafka/server/KafkaRequestHandler.scala: ## @@ -35,6 +36,43 @@ trait ApiRequestHandler { def handle(request: RequestChannel.Request,

[GitHub] [kafka] jolshan commented on a diff in pull request #13391: KAFKA-14561: Improve transactions experience for older clients by ensuring ongoing transaction

jolshan commented on code in PR #13391: URL: https://github.com/apache/kafka/pull/13391#discussion_r1162045206 ## core/src/main/scala/kafka/server/AddPartitionsToTxnManager.scala: ## @@ -0,0 +1,180 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or more +

[GitHub] [kafka] jolshan commented on a diff in pull request #13391: KAFKA-14561: Improve transactions experience for older clients by ensuring ongoing transaction

jolshan commented on code in PR #13391: URL: https://github.com/apache/kafka/pull/13391#discussion_r1162044614 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -616,66 +619,128 @@ class ReplicaManager(val config: KafkaConfig,

[GitHub] [kafka] jolshan commented on a diff in pull request #13391: KAFKA-14561: Improve transactions experience for older clients by ensuring ongoing transaction

jolshan commented on code in PR #13391: URL: https://github.com/apache/kafka/pull/13391#discussion_r1162043968 ## clients/src/main/resources/common/message/AddPartitionsToTxnRequest.json: ## @@ -29,7 +29,7 @@ // The AddPartitionsToTxnRequest version 4 API is added as part of

[GitHub] [kafka] junrao commented on a diff in pull request #13391: KAFKA-14561: Improve transactions experience for older clients by ensuring ongoing transaction

junrao commented on code in PR #13391: URL: https://github.com/apache/kafka/pull/13391#discussion_r1161909242 ## core/src/main/scala/kafka/server/AddPartitionsToTxnManager.scala: ## @@ -0,0 +1,180 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or more +

[GitHub] [kafka] sql888 commented on pull request #12006: KAFKA-13794: Follow up to fix comparator

sql888 commented on PR #12006: URL: https://github.com/apache/kafka/pull/12006#issuecomment-1502205546 > Failed tests are unrelated > > ``` > Build / ARM / kafka.network.ConnectionQuotasTest.testListenerConnectionRateLimitWhenActualRateAboveLimit() > ``` How to fix

[GitHub] [kafka] SpacRocket commented on pull request #13382: KAFKA-14722: Make BooleanSerde public

SpacRocket commented on PR #13382: URL: https://github.com/apache/kafka/pull/13382#issuecomment-1502183087 @mjsax Sure thanks for the suggestion. I've pushed a new commit in this pull request: https://github.com/apache/kafka/pull/13491 -- This is an automated message from the Apache

[jira] [Commented] (KAFKA-14750) Sink connector fails if a topic matching its topics.regex gets deleted

[ https://issues.apache.org/jira/browse/KAFKA-14750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17710259#comment-17710259 ] Sergei Morozov commented on KAFKA-14750: [~sagarrao] thank you for digging into this and

[GitHub] [kafka] jolshan commented on a diff in pull request #13391: KAFKA-14561: Improve transactions experience for older clients by ensuring ongoing transaction

jolshan commented on code in PR #13391: URL: https://github.com/apache/kafka/pull/13391#discussion_r1161946467 ## core/src/test/scala/unit/kafka/server/AddPartitionsToTxnManagerTest.scala: ## Review Comment: Added a line to the ReplicaManager test to see that we return

[GitHub] [kafka] guozhangwang commented on a diff in pull request #11433: KAFKA-13295: Avoiding Transation timeouts arising due to long restora…

guozhangwang commented on code in PR #11433: URL: https://github.com/apache/kafka/pull/11433#discussion_r1161940023 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java: ## @@ -342,7 +342,18 @@ public void handleAssignment(final Map>

[GitHub] [kafka] gharris1727 commented on a diff in pull request #13165: KAFKA-14654: Connector classes should statically initialize with plugin classloader

gharris1727 commented on code in PR #13165: URL: https://github.com/apache/kafka/pull/13165#discussion_r1161929533 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/isolation/DelegatingClassLoader.java: ## @@ -360,17 +360,22 @@ private PluginScanResult

[GitHub] [kafka] jeffkbkim commented on a diff in pull request #13524: KIP-848-Interface changes

jeffkbkim commented on code in PR #13524: URL: https://github.com/apache/kafka/pull/13524#discussion_r1161928058 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/common/TopicIdToPartition.java: ## @@ -0,0 +1,76 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] jolshan commented on a diff in pull request #13391: KAFKA-14561: Improve transactions experience for older clients by ensuring ongoing transaction

jolshan commented on code in PR #13391: URL: https://github.com/apache/kafka/pull/13391#discussion_r1161896585 ## core/src/test/scala/unit/kafka/server/AddPartitionsToTxnManagerTest.scala: ## Review Comment: We do have tests from the previous PR that return errors if the

[GitHub] [kafka] jolshan commented on a diff in pull request #13391: KAFKA-14561: Improve transactions experience for older clients by ensuring ongoing transaction

jolshan commented on code in PR #13391: URL: https://github.com/apache/kafka/pull/13391#discussion_r1161874495 ## core/src/main/scala/kafka/log/UnifiedLog.scala: ## @@ -572,6 +572,11 @@ class UnifiedLog(@volatile var logStartOffset: Long, result } + def

[jira] [Updated] (KAFKA-14886) Broker request handler thread pool is full due to single request slowdown

[ https://issues.apache.org/jira/browse/KAFKA-14886?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haoze Wu updated KAFKA-14886: - Description: In Kafka-2.8.0, we found that the number of data plane Kafka request handlers may quickly

[jira] [Created] (KAFKA-14886) Broker request handler thread pool is full due to single request slowdown

Haoze Wu created KAFKA-14886: Summary: Broker request handler thread pool is full due to single request slowdown Key: KAFKA-14886 URL: https://issues.apache.org/jira/browse/KAFKA-14886 Project: Kafka

[GitHub] [kafka] jolshan commented on a diff in pull request #13391: KAFKA-14561: Improve transactions experience for older clients by ensuring ongoing transaction

jolshan commented on code in PR #13391: URL: https://github.com/apache/kafka/pull/13391#discussion_r1161854813 ## core/src/test/scala/unit/kafka/server/AddPartitionsToTxnManagerTest.scala: ## Review Comment: Actually hmm -- I suppose this test is not present if you mean

[GitHub] [kafka] jolshan commented on a diff in pull request #13391: KAFKA-14561: Improve transactions experience for older clients by ensuring ongoing transaction

jolshan commented on code in PR #13391: URL: https://github.com/apache/kafka/pull/13391#discussion_r1161847053 ## core/src/test/scala/unit/kafka/server/AddPartitionsToTxnManagerTest.scala: ## Review Comment: Depends what you mean here. If you mean a unit test -- yes. If

[GitHub] [kafka] jolshan commented on a diff in pull request #13391: KAFKA-14561: Improve transactions experience for older clients by ensuring ongoing transaction

jolshan commented on code in PR #13391: URL: https://github.com/apache/kafka/pull/13391#discussion_r1161846085 ## core/src/main/scala/kafka/server/KafkaRequestHandler.scala: ## @@ -35,6 +36,43 @@ trait ApiRequestHandler { def handle(request: RequestChannel.Request,

[jira] [Updated] (KAFKA-14420) MirrorMaker should not clear filtered configs on target topics

[ https://issues.apache.org/jira/browse/KAFKA-14420?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Egerton updated KAFKA-14420: -- Fix Version/s: 3.5.0 > MirrorMaker should not clear filtered configs on target topics >

[jira] [Commented] (KAFKA-14420) MirrorMaker should not clear filtered configs on target topics

[ https://issues.apache.org/jira/browse/KAFKA-14420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17710197#comment-17710197 ] Chris Egerton commented on KAFKA-14420: --- Addressed with

[GitHub] [kafka] C0urante merged pull request #13373: Kafka-14420 Use incrementalAlterConfigs API for syncing topic configurations (KIP-894)

C0urante merged PR #13373: URL: https://github.com/apache/kafka/pull/13373 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] ppatierno commented on a diff in pull request #13525: KAFKA-14883: Expose `observer` state in KRaft metrics

ppatierno commented on code in PR #13525: URL: https://github.com/apache/kafka/pull/13525#discussion_r1161834571 ## raft/src/test/java/org/apache/kafka/raft/internals/KafkaRaftMetricsTest.java: ## @@ -137,14 +137,14 @@ public void shouldRecordNonVoterQuorumState() throws

[GitHub] [kafka] ppatierno commented on a diff in pull request #13525: KAFKA-14883: Expose `observer` state in KRaft metrics

ppatierno commented on code in PR #13525: URL: https://github.com/apache/kafka/pull/13525#discussion_r1161834571 ## raft/src/test/java/org/apache/kafka/raft/internals/KafkaRaftMetricsTest.java: ## @@ -137,14 +137,14 @@ public void shouldRecordNonVoterQuorumState() throws

[GitHub] [kafka] C0urante commented on pull request #13424: KAFKA-14783 (KIP-875): New STOPPED state for connectors

C0urante commented on PR #13424: URL: https://github.com/apache/kafka/pull/13424#issuecomment-1501942587 @mimaison thanks for the reviews. Do you think you'll have time to take another look at this before the April 12th feature freeze? -- This is an automated message from the Apache Git

[GitHub] [kafka] C0urante commented on a diff in pull request #13424: KAFKA-14783 (KIP-875): New STOPPED state for connectors

C0urante commented on code in PR #13424: URL: https://github.com/apache/kafka/pull/13424#discussion_r1161808636 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/DistributedHerder.java: ## @@ -1090,6 +1090,39 @@ public void putConnectorConfig(final

[GitHub] [kafka] C0urante commented on pull request #13453: KAFKA-12525: Ignoring Stale status statuses when reading from Status …

C0urante commented on PR #13453: URL: https://github.com/apache/kafka/pull/13453#issuecomment-1501923378 @vamossagar12 I think this approach is a bit too broad. We intentionally permit "unsafe" writes for reasons documented in the

[GitHub] [kafka] C0urante commented on pull request #13466: MINOR: Fix base ConfigDef in AbstractHerder::connectorPluginConfig

C0urante commented on PR #13466: URL: https://github.com/apache/kafka/pull/13466#issuecomment-1501875562 Thanks Mickael! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [kafka] dengziming commented on a diff in pull request #13525: KAFKA-14883: Expose `observer` state in KRaft metrics

dengziming commented on code in PR #13525: URL: https://github.com/apache/kafka/pull/13525#discussion_r1161721906 ## raft/src/test/java/org/apache/kafka/raft/internals/KafkaRaftMetricsTest.java: ## @@ -137,14 +137,14 @@ public void shouldRecordNonVoterQuorumState() throws

[GitHub] [kafka] showuon commented on a diff in pull request #13487: KAFKA-9550 Copying log segments to tiered storage in RemoteLogManager

showuon commented on code in PR #13487: URL: https://github.com/apache/kafka/pull/13487#discussion_r1161677863 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -0,0 +1,736 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

[GitHub] [kafka] satishd commented on a diff in pull request #13487: KAFKA-9550 Copying log segments to tiered storage in RemoteLogManager

satishd commented on code in PR #13487: URL: https://github.com/apache/kafka/pull/13487#discussion_r1161670474 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -0,0 +1,749 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

[GitHub] [kafka] satishd commented on a diff in pull request #13487: KAFKA-9550 Copying log segments to tiered storage in RemoteLogManager

satishd commented on code in PR #13487: URL: https://github.com/apache/kafka/pull/13487#discussion_r1161286998 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -0,0 +1,749 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

[GitHub] [kafka] Stephan14 opened a new pull request, #13531: KAFKA-14885: fix kafka client connect to the broker that offline from…

Stephan14 opened a new pull request, #13531: URL: https://github.com/apache/kafka/pull/13531 … cluster *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.*

[GitHub] [kafka] hudeqi commented on pull request #13473: KAFKA-14866:Remove controller module metrics when broker is shutting down

hudeqi commented on PR #13473: URL: https://github.com/apache/kafka/pull/13473#issuecomment-1501643812 > Do other committers have time to review this PR? @guozhangwang Hello, can you help to review these two PRs? this and https://github.com/apache/kafka/pull/13471 -- This is an

[GitHub] [kafka] mukkachaitanya commented on a diff in pull request #13165: KAFKA-14654: Connector classes should statically initialize with plugin classloader

mukkachaitanya commented on code in PR #13165: URL: https://github.com/apache/kafka/pull/13165#discussion_r1161593044 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/isolation/DelegatingClassLoader.java: ## @@ -360,17 +360,22 @@ private PluginScanResult

[jira] [Updated] (KAFKA-14885) Client can connect to broker and broker can not connect zookeeper

[ https://issues.apache.org/jira/browse/KAFKA-14885?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] zou shengfu updated KAFKA-14885: Description: When a broker has some issues about network, the broker can not connect to

[jira] [Updated] (KAFKA-14885) Client can connect to broker and broker can not connect zookeeper

[ https://issues.apache.org/jira/browse/KAFKA-14885?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] zou shengfu updated KAFKA-14885: Description: When a broker has some issues about network, the broker can not connect to

[jira] [Comment Edited] (KAFKA-14581) Move GetOffsetShell to tools

[ https://issues.apache.org/jira/browse/KAFKA-14581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17708011#comment-17708011 ] Ruslan Krivoshein edited comment on KAFKA-14581 at 4/10/23 8:12 AM:

[jira] [Created] (KAFKA-14885) Client can connect to broker and broker can not connect zookeeper

zou shengfu created KAFKA-14885: --- Summary: Client can connect to broker and broker can not connect zookeeper Key: KAFKA-14885 URL: https://issues.apache.org/jira/browse/KAFKA-14885 Project: Kafka

[jira] [Commented] (KAFKA-14873) Pluggable storage for Kafka Connect internal topics

[ https://issues.apache.org/jira/browse/KAFKA-14873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17710078#comment-17710078 ] Sagar Rao commented on KAFKA-14873: --- Hi [~malthe] , thanks for reporting this. I think your point

[jira] [Commented] (KAFKA-14750) Sink connector fails if a topic matching its topics.regex gets deleted

[ https://issues.apache.org/jira/browse/KAFKA-14750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17710077#comment-17710077 ] Sagar Rao commented on KAFKA-14750: --- I ran a few more tests for this. This issue is found specifically