[GitHub] [kafka] vcrfxia opened a new pull request, #13554: KAFKA-14834: [7/N] Update VersionedKeyValueStore#put() to return boolean

vcrfxia opened a new pull request, #13554: URL: https://github.com/apache/kafka/pull/13554 This PR updates the return type of `VersionedKeyValueStore#put(...)` from void to boolean, where the boolean represents whether the record that was put is the latest record for the particular key. As

[jira] [Resolved] (KAFKA-14883) Broker state should be "observer" in KRaft quorum

[ https://issues.apache.org/jira/browse/KAFKA-14883?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen resolved KAFKA-14883. --- Fix Version/s: 3.5.0 Resolution: Fixed > Broker state should be "observer" in KRaft quorum >

[jira] [Resolved] (KAFKA-9550) RemoteLogManager - copying eligible log segments to remote storage implementation

[ https://issues.apache.org/jira/browse/KAFKA-9550?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen resolved KAFKA-9550. -- Resolution: Fixed > RemoteLogManager - copying eligible log segments to remote storage >

[GitHub] [kafka] showuon merged pull request #13525: KAFKA-14883: Expose `observer` state in KRaft metrics

showuon merged PR #13525: URL: https://github.com/apache/kafka/pull/13525 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] showuon commented on pull request #13525: KAFKA-14883: Expose `observer` state in KRaft metrics

showuon commented on PR #13525: URL: https://github.com/apache/kafka/pull/13525#issuecomment-1506342972 Failed tests are unrelated ``` Build / JDK 8 and Scala 2.12 / kafka.security.authorizer.AuthorizerTest.testAllowAllAccess(String).quorum=kraft Build / JDK 8 and Scala

[GitHub] [kafka] showuon commented on a diff in pull request #13525: KAFKA-14883: Expose `observer` state in KRaft metrics

showuon commented on code in PR #13525: URL: https://github.com/apache/kafka/pull/13525#discussion_r1164996982 ## raft/src/test/java/org/apache/kafka/raft/internals/KafkaRaftMetricsTest.java: ## @@ -137,14 +137,14 @@ public void shouldRecordNonVoterQuorumState() throws

[GitHub] [kafka] vcrfxia commented on a diff in pull request #13552: KAFKA-14834: [6/N] Add tracking of versioned tables into graph nodes

vcrfxia commented on code in PR #13552: URL: https://github.com/apache/kafka/pull/13552#discussion_r1164980568 ## streams/src/test/java/org/apache/kafka/streams/kstream/internals/InternalStreamsBuilderTest.java: ## @@ -705,12 +711,304 @@ public void

[jira] [Assigned] (KAFKA-14901) Flaky test ExactlyOnceSourceIntegrationTest.testConnectorReconfiguration

[ https://issues.apache.org/jira/browse/KAFKA-14901?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] li xiangyuan reassigned KAFKA-14901: Assignee: (was: li xiangyuan) > Flaky test

[jira] [Assigned] (KAFKA-14901) Flaky test ExactlyOnceSourceIntegrationTest.testConnectorReconfiguration

[ https://issues.apache.org/jira/browse/KAFKA-14901?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] li xiangyuan reassigned KAFKA-14901: Assignee: li xiangyuan > Flaky test

[GitHub] [kafka] dengziming commented on a diff in pull request #13525: KAFKA-14883: Expose `observer` state in KRaft metrics

dengziming commented on code in PR #13525: URL: https://github.com/apache/kafka/pull/13525#discussion_r1164956809 ## raft/src/test/java/org/apache/kafka/raft/internals/KafkaRaftMetricsTest.java: ## @@ -137,14 +137,14 @@ public void shouldRecordNonVoterQuorumState() throws

[GitHub] [kafka] mjsax commented on a diff in pull request #13552: KAFKA-14834: [6/N] Add tracking of versioned tables into graph nodes

mjsax commented on code in PR #13552: URL: https://github.com/apache/kafka/pull/13552#discussion_r1164930944 ## streams/src/test/java/org/apache/kafka/streams/kstream/internals/InternalStreamsBuilderTest.java: ## @@ -705,12 +711,304 @@ public void

[GitHub] [kafka] mjsax commented on a diff in pull request #13552: KAFKA-14834: [6/N] Add tracking of versioned tables into graph nodes

mjsax commented on code in PR #13552: URL: https://github.com/apache/kafka/pull/13552#discussion_r1164922362 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/KTableImpl.java: ## @@ -1294,4 +1307,11 @@ private KTable doJoinOnForeignKey(final KTable forei

[GitHub] [kafka] mjsax commented on a diff in pull request #13552: KAFKA-14834: [6/N] Add tracking of versioned tables into graph nodes

mjsax commented on code in PR #13552: URL: https://github.com/apache/kafka/pull/13552#discussion_r1164920870 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/KTableImpl.java: ## @@ -1281,6 +1293,7 @@ private KTable doJoinOnForeignKey(final KTable forei

[GitHub] [kafka] mjsax commented on a diff in pull request #13552: KAFKA-14834: [6/N] Add tracking of versioned tables into graph nodes

mjsax commented on code in PR #13552: URL: https://github.com/apache/kafka/pull/13552#discussion_r1164915423 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/CogroupedStreamAggregateBuilder.java: ## @@ -73,6 +74,7 @@ KTable build(final Map, Aggregator

[GitHub] [kafka] mjsax commented on a diff in pull request #13552: KAFKA-14834: [6/N] Add tracking of versioned tables into graph nodes

mjsax commented on code in PR #13552: URL: https://github.com/apache/kafka/pull/13552#discussion_r1164913480 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/KGroupedStreamImpl.java: ## @@ -236,13 +237,16 @@ public SessionWindowedKStream windowedBy(final

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #13443: KAFKA-14514: Add Server Side Sticky Range Assignor (KIP-848)

rreddy-22 commented on code in PR #13443: URL: https://github.com/apache/kafka/pull/13443#discussion_r1164911085 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/ServerSideStickyRangeAssignor.java: ## @@ -0,0 +1,257 @@ +/* + * Licensed to the

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #13443: KAFKA-14514: Add Server Side Sticky Range Assignor (KIP-848)

rreddy-22 commented on code in PR #13443: URL: https://github.com/apache/kafka/pull/13443#discussion_r1164908509 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/ServerSideStickyRangeAssignor.java: ## @@ -0,0 +1,257 @@ +/* + * Licensed to the

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #13443: KAFKA-14514: Add Server Side Sticky Range Assignor (KIP-848)

rreddy-22 commented on code in PR #13443: URL: https://github.com/apache/kafka/pull/13443#discussion_r1164908245 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/ServerSideStickyRangeAssignor.java: ## @@ -0,0 +1,257 @@ +/* + * Licensed to the

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #13443: KAFKA-14514: Add Server Side Sticky Range Assignor (KIP-848)

rreddy-22 commented on code in PR #13443: URL: https://github.com/apache/kafka/pull/13443#discussion_r1164906996 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/ServerSideStickyRangeAssignor.java: ## @@ -0,0 +1,257 @@ +/* + * Licensed to the

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #13443: KAFKA-14514: Add Server Side Sticky Range Assignor (KIP-848)

rreddy-22 commented on code in PR #13443: URL: https://github.com/apache/kafka/pull/13443#discussion_r1164906229 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/ServerSideStickyRangeAssignor.java: ## @@ -0,0 +1,257 @@ +/* + * Licensed to the

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #13443: KAFKA-14514: Add Server Side Sticky Range Assignor (KIP-848)

rreddy-22 commented on code in PR #13443: URL: https://github.com/apache/kafka/pull/13443#discussion_r1164905279 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/ServerSideStickyRangeAssignor.java: ## @@ -0,0 +1,257 @@ +/* + * Licensed to the

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #13443: KAFKA-14514: Add Server Side Sticky Range Assignor (KIP-848)

rreddy-22 commented on code in PR #13443: URL: https://github.com/apache/kafka/pull/13443#discussion_r1164902619 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/ServerSideStickyRangeAssignor.java: ## @@ -0,0 +1,257 @@ +/* + * Licensed to the

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #13443: KAFKA-14514: Add Server Side Sticky Range Assignor (KIP-848)

rreddy-22 commented on code in PR #13443: URL: https://github.com/apache/kafka/pull/13443#discussion_r1164901673 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/ServerSideStickyRangeAssignor.java: ## @@ -0,0 +1,257 @@ +/* + * Licensed to the

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #13443: KAFKA-14514: Add Server Side Sticky Range Assignor (KIP-848)

rreddy-22 commented on code in PR #13443: URL: https://github.com/apache/kafka/pull/13443#discussion_r1164899524 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/ServerSideStickyRangeAssignor.java: ## @@ -0,0 +1,257 @@ +/* + * Licensed to the

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #13443: KAFKA-14514: Add Server Side Sticky Range Assignor (KIP-848)

rreddy-22 commented on code in PR #13443: URL: https://github.com/apache/kafka/pull/13443#discussion_r1164894366 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/ServerSideStickyRangeAssignor.java: ## @@ -0,0 +1,257 @@ +/* + * Licensed to the

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #13443: KAFKA-14514: Add Server Side Sticky Range Assignor (KIP-848)

rreddy-22 commented on code in PR #13443: URL: https://github.com/apache/kafka/pull/13443#discussion_r1164893597 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/ServerSideStickyRangeAssignor.java: ## @@ -0,0 +1,257 @@ +/* + * Licensed to the

[GitHub] [kafka] mjsax commented on a diff in pull request #13552: KAFKA-14834: [6/N] Add tracking of versioned tables into graph nodes

mjsax commented on code in PR #13552: URL: https://github.com/apache/kafka/pull/13552#discussion_r1164893058 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/InternalStreamsBuilder.java: ## @@ -142,6 +145,7 @@ public KTable table(final String topic,

[GitHub] [kafka] mjsax commented on a diff in pull request #13552: KAFKA-14834: [6/N] Add tracking of versioned tables into graph nodes

mjsax commented on code in PR #13552: URL: https://github.com/apache/kafka/pull/13552#discussion_r1164891330 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/CogroupedKStreamImpl.java: ## @@ -136,13 +137,16 @@ public SessionWindowedCogroupedKStream

[GitHub] [kafka] mjsax commented on a diff in pull request #13552: KAFKA-14834: [6/N] Add tracking of versioned tables into graph nodes

mjsax commented on code in PR #13552: URL: https://github.com/apache/kafka/pull/13552#discussion_r1164890769 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/CogroupedKStreamImpl.java: ## @@ -136,13 +137,16 @@ public SessionWindowedCogroupedKStream

[GitHub] [kafka] mjsax merged pull request #13522: KAFKA-14834: [5/N] Drop out-of-order records from FK join with versioned tables

mjsax merged PR #13522: URL: https://github.com/apache/kafka/pull/13522 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #13443: KAFKA-14514: Add Server Side Sticky Range Assignor (KIP-848)

rreddy-22 commented on code in PR #13443: URL: https://github.com/apache/kafka/pull/13443#discussion_r1164884866 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/ServerSideStickyRangeAssignor.java: ## @@ -0,0 +1,257 @@ +/* + * Licensed to the

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #13443: KAFKA-14514: Add Server Side Sticky Range Assignor (KIP-848)

rreddy-22 commented on code in PR #13443: URL: https://github.com/apache/kafka/pull/13443#discussion_r1164884200 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/ServerSideStickyRangeAssignor.java: ## @@ -0,0 +1,257 @@ +/* + * Licensed to the

[GitHub] [kafka] mjsax commented on a diff in pull request #13522: KAFKA-14834: [5/N] Drop out-of-order records from FK join with versioned tables

mjsax commented on code in PR #13522: URL: https://github.com/apache/kafka/pull/13522#discussion_r1164874948 ## streams/src/test/java/org/apache/kafka/streams/integration/KTableKTableForeignKeyVersionedJoinIntegrationTest.java: ## @@ -0,0 +1,301 @@ +/* + * Licensed to the

[GitHub] [kafka] mjsax commented on a diff in pull request #13522: KAFKA-14834: [5/N] Drop out-of-order records from FK join with versioned tables

mjsax commented on code in PR #13522: URL: https://github.com/apache/kafka/pull/13522#discussion_r1164874948 ## streams/src/test/java/org/apache/kafka/streams/integration/KTableKTableForeignKeyVersionedJoinIntegrationTest.java: ## @@ -0,0 +1,301 @@ +/* + * Licensed to the

[GitHub] [kafka] mjsax commented on a diff in pull request #13522: KAFKA-14834: [5/N] Drop out-of-order records from FK join with versioned tables

mjsax commented on code in PR #13522: URL: https://github.com/apache/kafka/pull/13522#discussion_r1164864257 ## streams/src/test/java/org/apache/kafka/streams/integration/KTableKTableForeignKeyJoinIntegrationTest.java: ## @@ -140,9 +163,9 @@ public void

[GitHub] [kafka] mjsax commented on a diff in pull request #13522: KAFKA-14834: [5/N] Drop out-of-order records from FK join with versioned tables

mjsax commented on code in PR #13522: URL: https://github.com/apache/kafka/pull/13522#discussion_r1164867385 ## streams/src/test/java/org/apache/kafka/streams/integration/KTableKTableForeignKeyJoinIntegrationTest.java: ## @@ -249,62 +272,62 @@ public void

[GitHub] [kafka] mjsax commented on a diff in pull request #13522: KAFKA-14834: [5/N] Drop out-of-order records from FK join with versioned tables

mjsax commented on code in PR #13522: URL: https://github.com/apache/kafka/pull/13522#discussion_r1164864257 ## streams/src/test/java/org/apache/kafka/streams/integration/KTableKTableForeignKeyJoinIntegrationTest.java: ## @@ -140,9 +163,9 @@ public void

[GitHub] [kafka] showuon commented on a diff in pull request #13547: Add note for KIP-894 and DelegationTokenCommand

showuon commented on code in PR #13547: URL: https://github.com/apache/kafka/pull/13547#discussion_r1164858999 ## docs/upgrade.html: ## @@ -27,6 +27,15 @@ Notable changes in 3 See

[GitHub] [kafka] showuon merged pull request #13500: MINOR: Install missing iputils-ping for system tests

showuon merged PR #13500: URL: https://github.com/apache/kafka/pull/13500 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] jsancio opened a new pull request, #13553: MINOR; Improve logging to help debug kraft

jsancio opened a new pull request, #13553: URL: https://github.com/apache/kafka/pull/13553 Minor changes to the log message and log levels to help us debug KRaft issues. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify

[jira] [Resolved] (KAFKA-14561) Improve transactions experience for older clients by ensuring ongoing transaction

[ https://issues.apache.org/jira/browse/KAFKA-14561?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao resolved KAFKA-14561. - Fix Version/s: 3.5.0 Resolution: Fixed merged the PR to trunk. > Improve transactions

[GitHub] [kafka] jolshan commented on pull request #13391: KAFKA-14561: Improve transactions experience for older clients by ensuring ongoing transaction

jolshan commented on PR #13391: URL: https://github.com/apache/kafka/pull/13391#issuecomment-1506123475 Here are errors on the latest build on trunk I could find: https://ci-builds.apache.org/job/Kafka/job/kafka/job/trunk/1754/#showFailuresLink Seems to roughly correlate with the

[GitHub] [kafka] mjsax merged pull request #13510: KAFKA-14834: [4/N] Drop out-of-order records from table-table join with versioned tables

mjsax merged PR #13510: URL: https://github.com/apache/kafka/pull/13510 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] junrao merged pull request #13391: KAFKA-14561: Improve transactions experience for older clients by ensuring ongoing transaction

junrao merged PR #13391: URL: https://github.com/apache/kafka/pull/13391 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] mjsax commented on pull request #13509: KAFKA-14834: [3/N] Timestamped lookups for stream-table joins

mjsax commented on PR #13509: URL: https://github.com/apache/kafka/pull/13509#issuecomment-1506112408 Merged this PR, but as discussed in person, it seems questionable to allow versioned-stores for global-ktables -- the code change to the stream-table join processor that is shared for

[GitHub] [kafka] mjsax merged pull request #13509: KAFKA-14834: [3/N] Timestamped lookups for stream-table joins

mjsax merged PR #13509: URL: https://github.com/apache/kafka/pull/13509 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (KAFKA-14901) Flaky test ExactlyOnceSourceIntegrationTest.testConnectorReconfiguration

[ https://issues.apache.org/jira/browse/KAFKA-14901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17711608#comment-17711608 ] Justine Olshan commented on KAFKA-14901: So many transaction/init producer ID issues lately. I

[GitHub] [kafka] mjsax commented on pull request #13477: KAFKA-7499: Handle serialization error in ProductionExceptionHandler

mjsax commented on PR #13477: URL: https://github.com/apache/kafka/pull/13477#issuecomment-1506098834 > I believe I saw something about the class casting handling but I couldn't see that in the comments. I did leave a commend on the PR, but delete it later as the comment was wrong

[GitHub] [kafka] cmccabe closed pull request #13546: Cherry-pick KAFKA-14857: Fix some MetadataLoader bugs (#13462)

cmccabe closed pull request #13546: Cherry-pick KAFKA-14857: Fix some MetadataLoader bugs (#13462) URL: https://github.com/apache/kafka/pull/13546 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] vcrfxia opened a new pull request, #13552: KAFKA-14834: [6/N] Add tracking of versioned tables into graph nodes

vcrfxia opened a new pull request, #13552: URL: https://github.com/apache/kafka/pull/13552 This PR adds a method into GraphNode to assist in tracking whether tables are materialized as versioned or unversioned stores. This is needed in order to allow processors which have different

[jira] [Comment Edited] (KAFKA-14750) Sink connector fails if a topic matching its topics.regex gets deleted

[ https://issues.apache.org/jira/browse/KAFKA-14750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17711589#comment-17711589 ] Sergei Morozov edited comment on KAFKA-14750 at 4/12/23 10:48 PM: --

[jira] [Comment Edited] (KAFKA-14750) Sink connector fails if a topic matching its topics.regex gets deleted

[ https://issues.apache.org/jira/browse/KAFKA-14750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17711589#comment-17711589 ] Sergei Morozov edited comment on KAFKA-14750 at 4/12/23 10:47 PM: --

[jira] [Comment Edited] (KAFKA-14750) Sink connector fails if a topic matching its topics.regex gets deleted

[ https://issues.apache.org/jira/browse/KAFKA-14750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17711589#comment-17711589 ] Sergei Morozov edited comment on KAFKA-14750 at 4/12/23 10:46 PM: --

[jira] [Commented] (KAFKA-14750) Sink connector fails if a topic matching its topics.regex gets deleted

[ https://issues.apache.org/jira/browse/KAFKA-14750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17711589#comment-17711589 ] Sergei Morozov commented on KAFKA-14750: {quote}how big of an impact is this to you for your use

[GitHub] [kafka] cmccabe commented on pull request #13549: KAFKA-14900: Fix NPE in SharedServer causing flaky failure in AuthorizerTest

cmccabe commented on PR #13549: URL: https://github.com/apache/kafka/pull/13549#issuecomment-1506025212 Thanks @gharris1727 . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [kafka] guozhangwang merged pull request #13523: MINOR: Follow-up on failing streams test, and fix StoreChangelogReader

guozhangwang merged PR #13523: URL: https://github.com/apache/kafka/pull/13523 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (KAFKA-14900) Flaky test AuthorizerTest failing with NPE

[ https://issues.apache.org/jira/browse/KAFKA-14900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17711581#comment-17711581 ] Greg Harris commented on KAFKA-14900: - This will be addressed in

[GitHub] [kafka] gharris1727 closed pull request #13549: KAFKA-14900: Fix NPE in SharedServer causing flaky failure in AuthorizerTest

gharris1727 closed pull request #13549: KAFKA-14900: Fix NPE in SharedServer causing flaky failure in AuthorizerTest URL: https://github.com/apache/kafka/pull/13549 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [kafka] gharris1727 commented on pull request #13549: KAFKA-14900: Fix NPE in SharedServer causing flaky failure in AuthorizerTest

gharris1727 commented on PR #13549: URL: https://github.com/apache/kafka/pull/13549#issuecomment-1506006379 This duplicates #13543 so I'll close this in favor of that more comprehensive change. -- This is an automated message from the Apache Git Service. To respond to the message, please

[jira] [Comment Edited] (KAFKA-14901) Flaky test ExactlyOnceSourceIntegrationTest.testConnectorReconfiguration

[ https://issues.apache.org/jira/browse/KAFKA-14901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17711580#comment-17711580 ] Greg Harris edited comment on KAFKA-14901 at 4/12/23 9:49 PM: -- cc

[jira] [Commented] (KAFKA-14901) Flaky test ExactlyOnceSourceIntegrationTest.testConnectorReconfiguration

[ https://issues.apache.org/jira/browse/KAFKA-14901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17711580#comment-17711580 ] Greg Harris commented on KAFKA-14901: - cc [~jolshan] [~dajac] [~hachikuji] [~mimaison] I have not

[jira] [Updated] (KAFKA-14901) Flaky test ExactlyOnceSourceIntegrationTest.testConnectorReconfiguration

[ https://issues.apache.org/jira/browse/KAFKA-14901?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Harris updated KAFKA-14901: Attachment: transaction-flake-trace-0.out > Flaky test

[GitHub] [kafka] philipnee commented on pull request #13477: KAFKA-7499: Handle serialization error in ProductionExceptionHandler

philipnee commented on PR #13477: URL: https://github.com/apache/kafka/pull/13477#issuecomment-1505978765 @bbejeck and @mjsax - thanks for the reviews. I believe I saw something about the class casting handling but I couldn't see that in the comments. I believe that is already implemented

[jira] [Updated] (KAFKA-14901) Flaky test ExactlyOnceSourceIntegrationTest.testConnectorReconfiguration

[ https://issues.apache.org/jira/browse/KAFKA-14901?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Harris updated KAFKA-14901: Fix Version/s: 3.5.0 > Flaky test ExactlyOnceSourceIntegrationTest.testConnectorReconfiguration >

[jira] [Updated] (KAFKA-14901) Flaky test ExactlyOnceSourceIntegrationTest.testConnectorReconfiguration

[ https://issues.apache.org/jira/browse/KAFKA-14901?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Harris updated KAFKA-14901: Priority: Blocker (was: Major) > Flaky test

[jira] [Updated] (KAFKA-14901) Flaky test ExactlyOnceSourceIntegrationTest.testConnectorReconfiguration

[ https://issues.apache.org/jira/browse/KAFKA-14901?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Harris updated KAFKA-14901: Attachment: transaction-flake.out > Flaky test

[jira] [Updated] (KAFKA-14901) Flaky test ExactlyOnceSourceIntegrationTest.testConnectorReconfiguration

[ https://issues.apache.org/jira/browse/KAFKA-14901?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Harris updated KAFKA-14901: Description: The EOS Source test appears to be very rarely failing (<5% chance) with the

[jira] [Created] (KAFKA-14901) Flaky test ExactlyOnceSourceIntegrationTest.testConnectorReconfiguration

Greg Harris created KAFKA-14901: --- Summary: Flaky test ExactlyOnceSourceIntegrationTest.testConnectorReconfiguration Key: KAFKA-14901 URL: https://issues.apache.org/jira/browse/KAFKA-14901 Project:

[GitHub] [kafka] philipnee commented on a diff in pull request #13477: KAFKA-7499: Handle serialization error in ProductionExceptionHandler

philipnee commented on code in PR #13477: URL: https://github.com/apache/kafka/pull/13477#discussion_r1164651827 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/RecordCollectorImpl.java: ## @@ -213,6 +212,31 @@ public void send(final String topic,

[GitHub] [kafka] hachikuji opened a new pull request, #13551: MINOR: Allow tagged fields with version subset of flexible version range

hachikuji opened a new pull request, #13551: URL: https://github.com/apache/kafka/pull/13551 The generated message types are missing a range check for the case when the tagged version range is a subset of the flexible version range. This causes the tagged field count, which is computed

[GitHub] [kafka] jolshan commented on a diff in pull request #13391: KAFKA-14561: Improve transactions experience for older clients by ensuring ongoing transaction

jolshan commented on code in PR #13391: URL: https://github.com/apache/kafka/pull/13391#discussion_r1164638992 ## core/src/main/scala/kafka/server/AddPartitionsToTxnManager.scala: ## @@ -0,0 +1,180 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or more +

[GitHub] [kafka] philipnee opened a new pull request, #13550: KAFKA-14639 - A single partition may be revoked and assign during a single round of rebalance

philipnee opened a new pull request, #13550: URL: https://github.com/apache/kafka/pull/13550 This is a really long story, but the incident started in KAFKA-13419 when we observed a member sending out a topic partition owned from the previous generation when a member missed a rebalance

[jira] [Resolved] (KAFKA-14898) [ MirrorMaker ] sync.topic.configs.enabled not working as expected

[ https://issues.apache.org/jira/browse/KAFKA-14898?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Harris resolved KAFKA-14898. - Resolution: Fixed > [ MirrorMaker ] sync.topic.configs.enabled not working as expected >

[GitHub] [kafka] junrao commented on a diff in pull request #13391: KAFKA-14561: Improve transactions experience for older clients by ensuring ongoing transaction

junrao commented on code in PR #13391: URL: https://github.com/apache/kafka/pull/13391#discussion_r1164633122 ## core/src/main/scala/kafka/server/AddPartitionsToTxnManager.scala: ## @@ -0,0 +1,180 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or more +

[jira] [Commented] (KAFKA-14898) [ MirrorMaker ] sync.topic.configs.enabled not working as expected

[ https://issues.apache.org/jira/browse/KAFKA-14898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17711551#comment-17711551 ] Srinivas Boga commented on KAFKA-14898: --- [~gharris1727] Thanks for your help on this   Yes i

[GitHub] [kafka] gharris1727 commented on pull request #13549: KAFKA-14900: Fix NPE in SharedServer causing flaky failure in AuthorizerTest

gharris1727 commented on PR #13549: URL: https://github.com/apache/kafka/pull/13549#issuecomment-1505884041 @cmccabe Could you review this fix? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] gharris1727 opened a new pull request, #13549: KAFKA-14900: Fix NPE in SharedServer causing flaky failure in AuthorizerTest

gharris1727 opened a new pull request, #13549: URL: https://github.com/apache/kafka/pull/13549 It appears that raftManager can become null via ControllerServer.shutdown() -> ensureNotRaftLeader() and various call sites of stop(). Rather than emit an NPE, evaluate raftManager.client while

[jira] [Updated] (KAFKA-14900) Flaky test AuthorizerTest failing with NPE

[ https://issues.apache.org/jira/browse/KAFKA-14900?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Harris updated KAFKA-14900: Description: The AuthorizerTest has multiple tests that appear to have the same flaky failure:

[jira] [Created] (KAFKA-14900) Flaky test AuthorizerTest failing with NPE

Greg Harris created KAFKA-14900: --- Summary: Flaky test AuthorizerTest failing with NPE Key: KAFKA-14900 URL: https://issues.apache.org/jira/browse/KAFKA-14900 Project: Kafka Issue Type: Test

[GitHub] [kafka] gharris1727 opened a new pull request, #13548: MINOR: Fix regression in MM2 task forwarding introduced by KAFKA-14783

gharris1727 opened a new pull request, #13548: URL: https://github.com/apache/kafka/pull/13548 The DistributedHerder was computing the forwarded URL for publishing task configs incorrectly leading to 404s in MM2 distributed mode. This regression appears in #13424 and presently only

[GitHub] [kafka] rittikaadhikari commented on pull request #13503: MINOR: Refactor TierStateMachine related tests into a separate test file

rittikaadhikari commented on PR #13503: URL: https://github.com/apache/kafka/pull/13503#issuecomment-1505826616 @junrao when you get a chance, would you be free to take a quick pass? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] jeffkbkim commented on a diff in pull request #13443: KAFKA-14514: Add Server Side Sticky Range Assignor (KIP-848)

jeffkbkim commented on code in PR #13443: URL: https://github.com/apache/kafka/pull/13443#discussion_r1160974966 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/ServerSideStickyRangeAssignor.java: ## @@ -0,0 +1,257 @@ +/* + * Licensed to the

[GitHub] [kafka] dajac closed pull request #13484: KAFKA-14016: Revoke more partitions than expected in Cooperative rebalance

dajac closed pull request #13484: KAFKA-14016: Revoke more partitions than expected in Cooperative rebalance URL: https://github.com/apache/kafka/pull/13484 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [kafka] jeffkbkim commented on a diff in pull request #13443: KAFKA-14514: Add Server Side Sticky Range Assignor (KIP-848)

jeffkbkim commented on code in PR #13443: URL: https://github.com/apache/kafka/pull/13443#discussion_r1160941760 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/ServerSideStickyRangeAssignor.java: ## @@ -0,0 +1,257 @@ +/* + * Licensed to the

[GitHub] [kafka] tinaselenge opened a new pull request, #13547: Add note for KIP-894 and DelegationTokenCommand

tinaselenge opened a new pull request, #13547: URL: https://github.com/apache/kafka/pull/13547 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #13524: MINOR: Refine `PartitionAssignor` server-side interface

rreddy-22 commented on code in PR #13524: URL: https://github.com/apache/kafka/pull/13524#discussion_r1164542031 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/common/TopicIdToPartition.java: ## @@ -0,0 +1,76 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] rreddy-22 commented on pull request #13524: MINOR: Refine `PartitionAssignor` server-side interface

rreddy-22 commented on PR #13524: URL: https://github.com/apache/kafka/pull/13524#issuecomment-1505791579 > > I like the idea of augmenting AssignmentTopicMetadata with rackIds since this comes under metadata and it'll be passed to all the assignors -- This is an

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #13524: MINOR: Refine `PartitionAssignor` server-side interface

rreddy-22 commented on code in PR #13524: URL: https://github.com/apache/kafka/pull/13524#discussion_r1164538097 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/common/TopicIdToPartition.java: ## @@ -0,0 +1,76 @@ +/* Review Comment: we can remove it

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #13524: MINOR: Refine `PartitionAssignor` server-side interface

rreddy-22 commented on code in PR #13524: URL: https://github.com/apache/kafka/pull/13524#discussion_r1164536324 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/AssignmentTopicMetadata.java: ## @@ -25,12 +25,12 @@ public class

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #13524: MINOR: Refine `PartitionAssignor` server-side interface

rreddy-22 commented on code in PR #13524: URL: https://github.com/apache/kafka/pull/13524#discussion_r1164535218 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/AssignmentSpec.java: ## @@ -28,12 +28,12 @@ public class AssignmentSpec { /**

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #13524: MINOR: Refine `PartitionAssignor` server-side interface

rreddy-22 commented on code in PR #13524: URL: https://github.com/apache/kafka/pull/13524#discussion_r1164530365 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/MemberAssignment.java: ## @@ -16,25 +16,28 @@ */ package

[GitHub] [kafka] cmccabe merged pull request #13521: MINOR: Add tests verifying leadership during and after reassignments in KRaft mode

cmccabe merged PR #13521: URL: https://github.com/apache/kafka/pull/13521 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] dajac commented on a diff in pull request #13502: KAFKA-14790: Add more AddPartitionsToTxn tests in KafkaApis and Authorizer tests

dajac commented on code in PR #13502: URL: https://github.com/apache/kafka/pull/13502#discussion_r1164521028 ## core/src/test/scala/unit/kafka/server/KafkaApisTest.scala: ## @@ -2113,6 +2113,115 @@ class KafkaApisTest { assertEquals(expectedErrors, response.errors()) }

[GitHub] [kafka] cmccabe commented on pull request #13521: MINOR: Add tests verifying leadership during and after reassignments in KRaft mode

cmccabe commented on PR #13521: URL: https://github.com/apache/kafka/pull/13521#issuecomment-1505765473 Sure. The test is valid since it's testing the `PartitionChangeBuilder` and we do want it to have the behavior you're describing. Thanks for the explanation. LGTM -- This is an

[GitHub] [kafka] cmccabe opened a new pull request, #13546: Cherry-pick KAFKA-14857: Fix some MetadataLoader bugs (#13462)

cmccabe opened a new pull request, #13546: URL: https://github.com/apache/kafka/pull/13546 The MetadataLoader is not supposed to publish metadata updates until we have loaded up to the high water mark. Previously, this logic was broken, and we published updates immediately. This PR fixes

[GitHub] [kafka] jolshan commented on a diff in pull request #13502: KAFKA-14790: Add more AddPartitionsToTxn tests in KafkaApis and Authorizer tests

jolshan commented on code in PR #13502: URL: https://github.com/apache/kafka/pull/13502#discussion_r1164515573 ## core/src/test/scala/unit/kafka/server/KafkaApisTest.scala: ## @@ -2113,6 +2113,115 @@ class KafkaApisTest { assertEquals(expectedErrors, response.errors())

[GitHub] [kafka] dajac commented on a diff in pull request #13502: KAFKA-14790: Add more AddPartitionsToTxn tests in KafkaApis and Authorizer tests

dajac commented on code in PR #13502: URL: https://github.com/apache/kafka/pull/13502#discussion_r1164508565 ## core/src/test/scala/unit/kafka/server/KafkaApisTest.scala: ## @@ -2113,6 +2113,115 @@ class KafkaApisTest { assertEquals(expectedErrors, response.errors()) }

[GitHub] [kafka] mjsax merged pull request #13444: KAFKA-14491: [21/N] Docs updates for versioned state stores

mjsax merged PR #13444: URL: https://github.com/apache/kafka/pull/13444 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #13524: MINOR: Refine `PartitionAssignor` server-side interface

rreddy-22 commented on code in PR #13524: URL: https://github.com/apache/kafka/pull/13524#discussion_r1164499488 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/AssignmentMemberSpec.java: ## @@ -29,37 +31,53 @@ public class AssignmentMemberSpec {

[jira] [Comment Edited] (KAFKA-14898) [ MirrorMaker ] sync.topic.configs.enabled not working as expected

[ https://issues.apache.org/jira/browse/KAFKA-14898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17711511#comment-17711511 ] Greg Harris edited comment on KAFKA-14898 at 4/12/23 6:25 PM: -- [~bseenu]

  1   2   3   >