[GitHub] [kafka] yashmayya commented on a diff in pull request #13465: KAFKA-14368: Connect offset write REST API

2023-04-14 Thread via GitHub
yashmayya commented on code in PR #13465: URL: https://github.com/apache/kafka/pull/13465#discussion_r1167384274 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/Worker.java: ## @@ -114,6 +127,7 @@ public class Worker { public static final long

[jira] [Created] (KAFKA-14910) Consider cancelling ongoing alter connector offsets requests when the connector is resumed

2023-04-14 Thread Yash Mayya (Jira)
Yash Mayya created KAFKA-14910: -- Summary: Consider cancelling ongoing alter connector offsets requests when the connector is resumed Key: KAFKA-14910 URL: https://issues.apache.org/jira/browse/KAFKA-14910

[jira] [Updated] (KAFKA-14910) Consider cancelling ongoing alter / reset connector offsets requests when the connector is resumed

2023-04-14 Thread Yash Mayya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14910?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yash Mayya updated KAFKA-14910: --- Summary: Consider cancelling ongoing alter / reset connector offsets requests when the connector is

[jira] [Commented] (KAFKA-7739) Kafka Tiered Storage

2023-04-14 Thread Henry Cai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17712586#comment-17712586 ] Henry Cai commented on KAFKA-7739: -- [~satish.duggana] I saw this KIP is moved out of [3.5.0 release plan

[jira] [Updated] (KAFKA-14884) Include check transaction is still ongoing right before append

2023-04-14 Thread Justine Olshan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14884?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justine Olshan updated KAFKA-14884: --- Priority: Blocker (was: Major) > Include check transaction is still ongoing right before

[jira] [Resolved] (KAFKA-14790) Add more AddPartitionsToTxn tests in KafkaApis and Authorizer tests

2023-04-14 Thread Justine Olshan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14790?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justine Olshan resolved KAFKA-14790. Resolution: Fixed > Add more AddPartitionsToTxn tests in KafkaApis and Authorizer tests >

[jira] [Updated] (KAFKA-14884) Include check transaction is still ongoing right before append

2023-04-14 Thread Justine Olshan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14884?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justine Olshan updated KAFKA-14884: --- Affects Version/s: 3.5.0 > Include check transaction is still ongoing right before append

[jira] [Updated] (KAFKA-14402) Transactions Server Side Defense

2023-04-14 Thread Justine Olshan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14402?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justine Olshan updated KAFKA-14402: --- Affects Version/s: 3.5.0 > Transactions Server Side Defense >

[jira] [Updated] (KAFKA-14904) Flaky Test kafka.api.TransactionsBounceTest.testWithGroupId()

2023-04-14 Thread Justine Olshan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14904?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justine Olshan updated KAFKA-14904: --- Affects Version/s: 3.5.0 > Flaky Test kafka.api.TransactionsBounceTest.testWithGroupId() >

[GitHub] [kafka] gharris1727 opened a new pull request, #13580: MINOR: Debug EmbeddedConnect/KafkaCluster failures

2023-04-14 Thread via GitHub
gharris1727 opened a new pull request, #13580: URL: https://github.com/apache/kafka/pull/13580 It appears that very rarely the EmbeddedConnectCluster will not come up, possibly due to the underlying EmbeddedKafkaCluster being unhealthy. This PR is trying to improve the debug info for this

[GitHub] [kafka] gharris1727 commented on pull request #13575: KAFKA-14905: Intercept incrementalAlterConfigs in MM2 ForwardingAdminTest

2023-04-14 Thread via GitHub
gharris1727 commented on PR #13575: URL: https://github.com/apache/kafka/pull/13575#issuecomment-1509359010 It looks like this change does solve some of the failures, which are now flaky instead of consistently failing. This needs some more iteration to reduce the flakiness. -- This is

[GitHub] [kafka] jolshan opened a new pull request, #13579: KAFKA-14904: Flaky Test kafka.api.TransactionsBounceTest.testWithGroupId()

2023-04-14 Thread via GitHub
jolshan opened a new pull request, #13579: URL: https://github.com/apache/kafka/pull/13579 [KAFKA-14561](https://github.com/apache/kafka/commit/56dcb837a2f1c1d8c016cfccf8268a910bb77a36) added verification to transactional produce requests to confirm an ongoing transaction. There is

[GitHub] [kafka] mjsax commented on pull request #13533: KAFKA-12446: update change encoding to use varint

2023-04-14 Thread via GitHub
mjsax commented on PR #13533: URL: https://github.com/apache/kafka/pull/13533#issuecomment-1509328479 @fqaiser94 -- what do you think? It's your KIP in the end. I think we should make this change and also "simplify" the KIP to drop implementation details. -- This is an automated message

[GitHub] [kafka] mjsax commented on pull request #13533: KAFKA-12446: update change encoding to use varint

2023-04-14 Thread via GitHub
mjsax commented on PR #13533: URL: https://github.com/apache/kafka/pull/13533#issuecomment-1509326373 I think it's better to keep the changes in this PR, because it's not related to KIP-914, but to KIP-904. I just rebased and updated this PR. -- This is an automated message from

[GitHub] [kafka] mjsax merged pull request #13545: MINOR: remove unnecessary `KeyValueMapper`

2023-04-14 Thread via GitHub
mjsax merged PR #13545: URL: https://github.com/apache/kafka/pull/13545 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (KAFKA-14904) Flaky Test kafka.api.TransactionsBounceTest.testWithGroupId()

2023-04-14 Thread Justine Olshan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17712556#comment-17712556 ] Justine Olshan commented on KAFKA-14904: Marking as a blocker since the commit that caused this

[jira] [Updated] (KAFKA-14904) Flaky Test kafka.api.TransactionsBounceTest.testWithGroupId()

2023-04-14 Thread Justine Olshan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14904?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justine Olshan updated KAFKA-14904: --- Priority: Blocker (was: Major) > Flaky Test

[GitHub] [kafka] mjsax opened a new pull request, #13578: MINOR: update .asf.yaml

2023-04-14 Thread via GitHub
mjsax opened a new pull request, #13578: URL: https://github.com/apache/kafka/pull/13578 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of testing

[GitHub] [kafka] jeffkbkim commented on pull request #13526: KAFKA-14869: bump coordinator Value records to flexible versions

2023-04-14 Thread via GitHub
jeffkbkim commented on PR #13526: URL: https://github.com/apache/kafka/pull/13526#issuecomment-1509245732 @dajac > I recall that we discussed adding a mechanism to prevent adding non-tagged fields in the future. Have you looked into this? @hachikuji pointed out that we may

[GitHub] [kafka] jeffkbkim commented on a diff in pull request #13526: KAFKA-14869: bump coordinator Value records to flexible versions

2023-04-14 Thread via GitHub
jeffkbkim commented on code in PR #13526: URL: https://github.com/apache/kafka/pull/13526#discussion_r1167262801 ## core/src/test/scala/unit/kafka/coordinator/group/GroupMetadataManagerTest.scala: ## @@ -2466,6 +2467,64 @@ class GroupMetadataManagerTest {

[GitHub] [kafka] jeffkbkim commented on a diff in pull request #13526: KAFKA-14869: bump coordinator Value records to flexible versions

2023-04-14 Thread via GitHub
jeffkbkim commented on code in PR #13526: URL: https://github.com/apache/kafka/pull/13526#discussion_r1167261871 ## group-coordinator/src/main/resources/common/message/GroupMetadataValue.json: ## @@ -13,11 +13,14 @@ // See the License for the specific language governing

[GitHub] [kafka] jeffkbkim commented on a diff in pull request #13511: KAFKA-14869: ignore unknown record types for coordinators

2023-04-14 Thread via GitHub
jeffkbkim commented on code in PR #13511: URL: https://github.com/apache/kafka/pull/13511#discussion_r1167257449 ## core/src/main/scala/kafka/coordinator/transaction/TransactionLog.scala: ## @@ -148,17 +149,23 @@ object TransactionLog { // Formatter for use with tools to

[GitHub] [kafka] mjsax opened a new pull request, #13577: MINOR: updated KS release notes for 3.5

2023-04-14 Thread via GitHub
mjsax opened a new pull request, #13577: URL: https://github.com/apache/kafka/pull/13577 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of testing

[GitHub] [kafka] jolshan commented on a diff in pull request #12149: KAFKA-13668: Retry upon missing initProducerId due to authorization error

2023-04-14 Thread via GitHub
jolshan commented on code in PR #12149: URL: https://github.com/apache/kafka/pull/12149#discussion_r1167247268 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java: ## @@ -1294,7 +1309,10 @@ public void handleResponse(AbstractResponse

[GitHub] [kafka] jolshan commented on a diff in pull request #12149: KAFKA-13668: Retry upon missing initProducerId due to authorization error

2023-04-14 Thread via GitHub
jolshan commented on code in PR #12149: URL: https://github.com/apache/kafka/pull/12149#discussion_r1167246564 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java: ## @@ -607,6 +608,14 @@ public synchronized void

[GitHub] [kafka] mjsax commented on pull request #13576: MINOR: Assure no streamsProducer send after handling the serialization error.

2023-04-14 Thread via GitHub
mjsax commented on PR #13576: URL: https://github.com/apache/kafka/pull/13576#issuecomment-1509174831 Merged to `trunk` and cherry-picked to `3.5` branch. Thanks for the follow up! -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [kafka] mjsax merged pull request #13576: MINOR: Assure no streamsProducer send after handling the serialization error.

2023-04-14 Thread via GitHub
mjsax merged PR #13576: URL: https://github.com/apache/kafka/pull/13576 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] mjsax commented on pull request #13527: Revert "KAFKA-14318: KIP-878, Introduce partition autoscaling configs (#12962)"

2023-04-14 Thread via GitHub
mjsax commented on PR #13527: URL: https://github.com/apache/kafka/pull/13527#issuecomment-1509166017 Merged to `trunk` and cherry-picked to `3.5` branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [kafka] philipnee commented on a diff in pull request #12149: KAFKA-13668: Retry upon missing initProducerId due to authorization error

2023-04-14 Thread via GitHub
philipnee commented on code in PR #12149: URL: https://github.com/apache/kafka/pull/12149#discussion_r1167231804 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java: ## @@ -1294,7 +1309,10 @@ public void handleResponse(AbstractResponse

[GitHub] [kafka] philipnee commented on a diff in pull request #12149: KAFKA-13668: Retry upon missing initProducerId due to authorization error

2023-04-14 Thread via GitHub
philipnee commented on code in PR #12149: URL: https://github.com/apache/kafka/pull/12149#discussion_r1167230503 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java: ## @@ -607,6 +608,14 @@ public synchronized void

[jira] [Created] (KAFKA-14909) KRaft Controllers not setting ZkMigrationReady tagged field

2023-04-14 Thread David Arthur (Jira)
David Arthur created KAFKA-14909: Summary: KRaft Controllers not setting ZkMigrationReady tagged field Key: KAFKA-14909 URL: https://issues.apache.org/jira/browse/KAFKA-14909 Project: Kafka

[GitHub] [kafka] dajac commented on a diff in pull request #13526: KAFKA-14869: bump coordinator Value records to flexible versions

2023-04-14 Thread via GitHub
dajac commented on code in PR #13526: URL: https://github.com/apache/kafka/pull/13526#discussion_r1167208479 ## core/src/test/scala/unit/kafka/coordinator/group/GroupMetadataManagerTest.scala: ## @@ -2466,6 +2467,64 @@ class GroupMetadataManagerTest {

[GitHub] [kafka] mjsax merged pull request #13527: Revert "KAFKA-14318: KIP-878, Introduce partition autoscaling configs (#12962)"

2023-04-14 Thread via GitHub
mjsax merged PR #13527: URL: https://github.com/apache/kafka/pull/13527 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] mjsax commented on a diff in pull request #13527: Revert "KAFKA-14318: KIP-878, Introduce partition autoscaling configs (#12962)"

2023-04-14 Thread via GitHub
mjsax commented on code in PR #13527: URL: https://github.com/apache/kafka/pull/13527#discussion_r1167196102 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/assignment/HighAvailabilityTaskAssignorTest.java: ## @@ -71,7 +67,23 @@ import static

[GitHub] [kafka] mjsax commented on a diff in pull request #13527: Revert "KAFKA-14318: KIP-878, Introduce partition autoscaling configs (#12962)"

2023-04-14 Thread via GitHub
mjsax commented on code in PR #13527: URL: https://github.com/apache/kafka/pull/13527#discussion_r1167194742 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/AssignorConfiguration.java: ## @@ -261,41 +261,29 @@ public interface AssignmentListener

[jira] [Commented] (KAFKA-14904) Flaky Test kafka.api.TransactionsBounceTest.testWithGroupId()

2023-04-14 Thread Justine Olshan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17712497#comment-17712497 ] Justine Olshan commented on KAFKA-14904: The issue is the first request we verify is still in

[jira] [Assigned] (KAFKA-14900) Flaky test AuthorizerTest failing with NPE

2023-04-14 Thread Greg Harris (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14900?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Harris reassigned KAFKA-14900: --- Assignee: Colin McCabe (was: Greg Harris) > Flaky test AuthorizerTest failing with NPE >

[GitHub] [kafka] jeqo commented on a diff in pull request #12637: KAFKA-14226 (KIP-821): [connect:transform] Introduce support for nested structures

2023-04-14 Thread via GitHub
jeqo commented on code in PR #12637: URL: https://github.com/apache/kafka/pull/12637#discussion_r1167124072 ## connect/transforms/src/main/java/org/apache/kafka/connect/transforms/field/SingleFieldPath.java: ## @@ -0,0 +1,585 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] mjsax commented on pull request #13534: KAFKA-14054: Handle TimeoutException gracefully

2023-04-14 Thread via GitHub
mjsax commented on PR #13534: URL: https://github.com/apache/kafka/pull/13534#issuecomment-1509012485 Merged to `trunk` and cherry-picked to `3.5` branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [kafka] jeqo commented on a diff in pull request #12637: KAFKA-14226 (KIP-821): [connect:transform] Introduce support for nested structures

2023-04-14 Thread via GitHub
jeqo commented on code in PR #12637: URL: https://github.com/apache/kafka/pull/12637#discussion_r1167124072 ## connect/transforms/src/main/java/org/apache/kafka/connect/transforms/field/SingleFieldPath.java: ## @@ -0,0 +1,585 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] mumrah closed pull request #13574: DO NOT MERGE: Jenkins AuthorizerTest investigation

2023-04-14 Thread via GitHub
mumrah closed pull request #13574: DO NOT MERGE: Jenkins AuthorizerTest investigation URL: https://github.com/apache/kafka/pull/13574 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [kafka] mumrah merged pull request #13543: MINOR: fix flaky KRaft-related tests

2023-04-14 Thread via GitHub
mumrah merged PR #13543: URL: https://github.com/apache/kafka/pull/13543 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] philipnee commented on a diff in pull request #12149: KAFKA-13668: Retry upon missing initProducerId due to authorization error

2023-04-14 Thread via GitHub
philipnee commented on code in PR #12149: URL: https://github.com/apache/kafka/pull/12149#discussion_r1167110290 ## clients/src/test/java/org/apache/kafka/clients/producer/KafkaProducerTest.java: ## @@ -1237,6 +1238,34 @@ public void testInitTransactionWhileThrottled() {

[GitHub] [kafka] bbejeck commented on pull request #13527: Revert "KAFKA-14318: KIP-878, Introduce partition autoscaling configs (#12962)"

2023-04-14 Thread via GitHub
bbejeck commented on PR #13527: URL: https://github.com/apache/kafka/pull/13527#issuecomment-1508982838 I looked at the build and the test failures are unrelated to this PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [kafka] bbejeck commented on a diff in pull request #13527: Revert "KAFKA-14318: KIP-878, Introduce partition autoscaling configs (#12962)"

2023-04-14 Thread via GitHub
bbejeck commented on code in PR #13527: URL: https://github.com/apache/kafka/pull/13527#discussion_r1167075556 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/AssignorConfiguration.java: ## @@ -261,41 +261,29 @@ public interface

[GitHub] [kafka] philipnee commented on a diff in pull request #13477: KAFKA-7499: Handle serialization error in ProductionExceptionHandler

2023-04-14 Thread via GitHub
philipnee commented on code in PR #13477: URL: https://github.com/apache/kafka/pull/13477#discussion_r1167095917 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/RecordCollectorImpl.java: ## @@ -212,11 +212,11 @@ public void send(final String topic,

[GitHub] [kafka] philipnee commented on a diff in pull request #13477: KAFKA-7499: Handle serialization error in ProductionExceptionHandler

2023-04-14 Thread via GitHub
philipnee commented on code in PR #13477: URL: https://github.com/apache/kafka/pull/13477#discussion_r1167093584 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/RecordCollectorTest.java: ## @@ -1391,21 +1390,57 @@ public void

[GitHub] [kafka] philipnee commented on pull request #13576: MINOR: Assure no streamsProducer send after handling the serialization error.

2023-04-14 Thread via GitHub
philipnee commented on PR #13576: URL: https://github.com/apache/kafka/pull/13576#issuecomment-1508973679 @mjsax - I think.. this seems to be the way to do it? Originally I thought we would just mock the producer, but this seems to work too. -- This is an automated message from the

[GitHub] [kafka] cmccabe merged pull request #13553: MINOR; Improve logging to help debug raft

2023-04-14 Thread via GitHub
cmccabe merged PR #13553: URL: https://github.com/apache/kafka/pull/13553 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] mjsax commented on a diff in pull request #13477: KAFKA-7499: Handle serialization error in ProductionExceptionHandler

2023-04-14 Thread via GitHub
mjsax commented on code in PR #13477: URL: https://github.com/apache/kafka/pull/13477#discussion_r1167091288 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/RecordCollectorTest.java: ## @@ -1391,21 +1390,57 @@ public void

[GitHub] [kafka] mjsax commented on a diff in pull request #13477: KAFKA-7499: Handle serialization error in ProductionExceptionHandler

2023-04-14 Thread via GitHub
mjsax commented on code in PR #13477: URL: https://github.com/apache/kafka/pull/13477#discussion_r1167090307 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/RecordCollectorImpl.java: ## @@ -212,11 +212,11 @@ public void send(final String topic,

[GitHub] [kafka] cmccabe commented on pull request #13280: KAFKA-14735: Improve KRaft metadata image change performance at high …

2023-04-14 Thread via GitHub
cmccabe commented on PR #13280: URL: https://github.com/apache/kafka/pull/13280#issuecomment-1508967636 @rondagostino BTW I still would like to understand what is wrong with calling `values()` on the map (if anything) but let's take that discussion offline and not block on it -- This is

[GitHub] [kafka] Hangleton commented on a diff in pull request #13561: KAFKA-14888: Added remote log segments retention functionality based on time and size.

2023-04-14 Thread via GitHub
Hangleton commented on code in PR #13561: URL: https://github.com/apache/kafka/pull/13561#discussion_r1167074461 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -595,6 +609,193 @@ public void run() { } } +public void

[GitHub] [kafka] cmccabe commented on pull request #13280: KAFKA-14735: Improve KRaft metadata image change performance at high …

2023-04-14 Thread via GitHub
cmccabe commented on PR #13280: URL: https://github.com/apache/kafka/pull/13280#issuecomment-1508964167 OK. It sounds like the consensus is that we should keep the "immutable" naming then. Thanks, @rondagostino , @showuon , @emissionnebula , @ijuma . LGTM -- This is an automated

[GitHub] [kafka] philipnee opened a new pull request, #13576: MINOR: Assure no streamsProducer send after handling the serialization error.

2023-04-14 Thread via GitHub
philipnee opened a new pull request, #13576: URL: https://github.com/apache/kafka/pull/13576 We want to make sure the streamsProducer doesn't send upon handling the error per comment here: https://github.com/apache/kafka/pull/13477/commits/510f2aaf0808d3c543720dec8a6dd6b455b41460 --

[GitHub] [kafka] cmccabe commented on a diff in pull request #13280: KAFKA-14735: Improve KRaft metadata image change performance at high …

2023-04-14 Thread via GitHub
cmccabe commented on code in PR #13280: URL: https://github.com/apache/kafka/pull/13280#discussion_r1167076930 ## server-common/src/main/java/org/apache/kafka/server/immutable/ImmutableMap.java: ## @@ -0,0 +1,47 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [kafka] philipnee commented on a diff in pull request #13477: KAFKA-7499: Handle serialization error in ProductionExceptionHandler

2023-04-14 Thread via GitHub
philipnee commented on code in PR #13477: URL: https://github.com/apache/kafka/pull/13477#discussion_r1167075145 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/RecordCollectorTest.java: ## @@ -1391,21 +1390,57 @@ public void

[GitHub] [kafka] mumrah commented on pull request #13574: DO NOT MERGE: Jenkins AuthorizerTest investigation

2023-04-14 Thread via GitHub
mumrah commented on PR #13574: URL: https://github.com/apache/kafka/pull/13574#issuecomment-1508946825 Merged in #13543 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [kafka] mumrah commented on pull request #13574: DO NOT MERGE: Jenkins AuthorizerTest investigation

2023-04-14 Thread via GitHub
mumrah commented on PR #13574: URL: https://github.com/apache/kafka/pull/13574#issuecomment-1508944703 AuthorizerTest failed a few times in the first run https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-13574/1/testReport/ -- This is an automated message from the Apache Git

[GitHub] [kafka] jeffkbkim commented on a diff in pull request #13526: KAFKA-14869: bump coordinator Value records to flexible versions

2023-04-14 Thread via GitHub
jeffkbkim commented on code in PR #13526: URL: https://github.com/apache/kafka/pull/13526#discussion_r1167066378 ## core/src/main/resources/common/message/TransactionLogValue.json: ## @@ -13,27 +13,31 @@ // See the License for the specific language governing permissions and

[GitHub] [kafka] jeffkbkim commented on a diff in pull request #13526: KAFKA-14869: bump coordinator Value records to flexible versions

2023-04-14 Thread via GitHub
jeffkbkim commented on code in PR #13526: URL: https://github.com/apache/kafka/pull/13526#discussion_r1167065703 ## core/src/test/scala/unit/kafka/coordinator/group/GroupMetadataManagerTest.scala: ## @@ -2466,6 +2467,64 @@ class GroupMetadataManagerTest {

[GitHub] [kafka] gharris1727 opened a new pull request, #13575: KAFKA-14905: Intercept incremenntalAlterConfigs in MM2 ForwardingAdminTest

2023-04-14 Thread via GitHub
gharris1727 opened a new pull request, #13575: URL: https://github.com/apache/kafka/pull/13575 This fixes test failures introduced in KIP-894 #13373 These tests consistently pass locally with or without this change, but it appears that Jenkins is more discerning. I do not know yet

[GitHub] [kafka] mjsax merged pull request #13534: KAFKA-14054: Handle TimeoutException gracefully

2023-04-14 Thread via GitHub
mjsax merged PR #13534: URL: https://github.com/apache/kafka/pull/13534 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] philipnee commented on a diff in pull request #13477: KAFKA-7499: Handle serialization error in ProductionExceptionHandler

2023-04-14 Thread via GitHub
philipnee commented on code in PR #13477: URL: https://github.com/apache/kafka/pull/13477#discussion_r1167062912 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/RecordCollectorImpl.java: ## @@ -212,11 +212,11 @@ public void send(final String topic,

[GitHub] [kafka] jeffkbkim commented on a diff in pull request #13526: KAFKA-14869: bump coordinator Value records to flexible versions

2023-04-14 Thread via GitHub
jeffkbkim commented on code in PR #13526: URL: https://github.com/apache/kafka/pull/13526#discussion_r1167058951 ## core/src/test/scala/unit/kafka/coordinator/transaction/TransactionLogTest.scala: ## @@ -135,4 +138,28 @@ class TransactionLogTest { assertEquals(Some(""),

[GitHub] [kafka] jolshan merged pull request #13502: KAFKA-14790: Add more AddPartitionsToTxn tests in KafkaApis and Authorizer tests

2023-04-14 Thread via GitHub
jolshan merged PR #13502: URL: https://github.com/apache/kafka/pull/13502 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] jeffkbkim commented on a diff in pull request #13526: KAFKA-14869: bump coordinator Value records to flexible versions

2023-04-14 Thread via GitHub
jeffkbkim commented on code in PR #13526: URL: https://github.com/apache/kafka/pull/13526#discussion_r1167056232 ## core/src/test/scala/unit/kafka/coordinator/group/GroupMetadataManagerTest.scala: ## @@ -2616,7 +2675,8 @@ class GroupMetadataManagerTest {

[jira] [Commented] (KAFKA-14904) Flaky Test kafka.api.TransactionsBounceTest.testWithGroupId()

2023-04-14 Thread Justine Olshan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17712459#comment-17712459 ] Justine Olshan commented on KAFKA-14904: Further investigation shows this occurs after the

[GitHub] [kafka] Hangleton commented on a diff in pull request #13487: KAFKA-9550 Copying log segments to tiered storage in RemoteLogManager

2023-04-14 Thread via GitHub
Hangleton commented on code in PR #13487: URL: https://github.com/apache/kafka/pull/13487#discussion_r1167007616 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -0,0 +1,719 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

[GitHub] [kafka] Hangleton commented on pull request #13487: KAFKA-9550 Copying log segments to tiered storage in RemoteLogManager

2023-04-14 Thread via GitHub
Hangleton commented on PR #13487: URL: https://github.com/apache/kafka/pull/13487#issuecomment-1508916524 > *Since this PR blocks other following PRs, I'm going to merge it soon. We can have a follow-up PR to address any new comments if any. Thank you.* Provided a few comments FYI

[GitHub] [kafka] mumrah opened a new pull request, #13574: DO NOT MERGE: Jenkins AuthorizerTest investigation

2023-04-14 Thread via GitHub
mumrah opened a new pull request, #13574: URL: https://github.com/apache/kafka/pull/13574 This PR is only here to get some data out of Jenkins regarding the recent AuthorizerTest failures. Do not merge this PR -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kafka] Hangleton commented on a diff in pull request #13487: KAFKA-9550 Copying log segments to tiered storage in RemoteLogManager

2023-04-14 Thread via GitHub
Hangleton commented on code in PR #13487: URL: https://github.com/apache/kafka/pull/13487#discussion_r1166975428 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -0,0 +1,719 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

[GitHub] [kafka] jeffkbkim commented on a diff in pull request #13511: KAFKA-14869: ignore unknown record types for coordinators

2023-04-14 Thread via GitHub
jeffkbkim commented on code in PR #13511: URL: https://github.com/apache/kafka/pull/13511#discussion_r1167009340 ## core/src/main/scala/kafka/coordinator/group/GroupMetadataManager.scala: ## @@ -683,8 +685,10 @@ class GroupMetadataManager(brokerId: Int,

[GitHub] [kafka] ijuma commented on pull request #13373: Kafka-14420 Use incrementalAlterConfigs API for syncing topic configurations (KIP-894)

2023-04-14 Thread via GitHub
ijuma commented on PR #13373: URL: https://github.com/apache/kafka/pull/13373#issuecomment-1508861550 Thanks for helping with this @gharris1727. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] gharris1727 commented on pull request #13373: Kafka-14420 Use incrementalAlterConfigs API for syncing topic configurations (KIP-894)

2023-04-14 Thread via GitHub
gharris1727 commented on PR #13373: URL: https://github.com/apache/kafka/pull/13373#issuecomment-1508855593 Ticket for the failures introduced here: https://issues.apache.org/jira/browse/KAFKA-14905 Some cursory investigation reveals that these tests hook into `alterConfigs` via

[GitHub] [kafka] ijuma commented on pull request #13548: MINOR: Fix regression in MM2 task forwarding introduced by KAFKA-14783

2023-04-14 Thread via GitHub
ijuma commented on PR #13548: URL: https://github.com/apache/kafka/pull/13548#issuecomment-1508828513 @gharris1727 I think what you did was fine. :) My concern is more on how we decided that it was ok to merge. I looked a bit more and I think the issues potentially started around here for

[GitHub] [kafka] ijuma commented on pull request #13373: Kafka-14420 Use incrementalAlterConfigs API for syncing topic configurations (KIP-894)

2023-04-14 Thread via GitHub
ijuma commented on PR #13373: URL: https://github.com/apache/kafka/pull/13373#issuecomment-1508823431 It looks like we started getting a _lot_ of test failures after this PR: https://ci-builds.apache.org/job/Kafka/job/kafka/job/trunk/1746/#showFailuresLink I see a lot of the

[GitHub] [kafka] gharris1727 commented on pull request #13548: MINOR: Fix regression in MM2 task forwarding introduced by KAFKA-14783

2023-04-14 Thread via GitHub
gharris1727 commented on PR #13548: URL: https://github.com/apache/kafka/pull/13548#issuecomment-1508814690 @ijuma I proposed this PR in the form I did because it restored a piece of code that was unintentionally changed. From an end user-perspective, the unintentional change was certainly

[GitHub] [kafka] mjsax commented on pull request #13563: MINOR: Refactor changelogger to accept timestamp

2023-04-14 Thread via GitHub
mjsax commented on PR #13563: URL: https://github.com/apache/kafka/pull/13563#issuecomment-1508797441 Merged to `trunk` and cherry-picked to `3.5` branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [kafka] ijuma commented on pull request #13548: MINOR: Fix regression in MM2 task forwarding introduced by KAFKA-14783

2023-04-14 Thread via GitHub
ijuma commented on PR #13548: URL: https://github.com/apache/kafka/pull/13548#issuecomment-1508774105 But how do we even know that this is helping vs making it worse with so many failures? -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] gharris1727 commented on pull request #13548: MINOR: Fix regression in MM2 task forwarding introduced by KAFKA-14783

2023-04-14 Thread via GitHub
gharris1727 commented on PR #13548: URL: https://github.com/apache/kafka/pull/13548#issuecomment-1508726959 @ijuma The scope of this PR was small, addressing just one issue. We certainly have several flakey and failing tests that need to be addressed during this test stabilization period.

[GitHub] [kafka] Hangleton commented on a diff in pull request #13535: KAFKA-9579 Fetch implementation for records in the remote storage through a specific purgatory.

2023-04-14 Thread via GitHub
Hangleton commented on code in PR #13535: URL: https://github.com/apache/kafka/pull/13535#discussion_r1166887367 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -600,6 +622,176 @@ public String toString() { } } +public FetchDataInfo

[GitHub] [kafka] Hangleton commented on a diff in pull request #13535: KAFKA-9579 Fetch implementation for records in the remote storage through a specific purgatory.

2023-04-14 Thread via GitHub
Hangleton commented on code in PR #13535: URL: https://github.com/apache/kafka/pull/13535#discussion_r1166887367 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -600,6 +622,176 @@ public String toString() { } } +public FetchDataInfo

[jira] [Updated] (KAFKA-4107) Support offset reset capability in Kafka Connect

2023-04-14 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-4107?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mickael Maison updated KAFKA-4107: -- Labels: kip (was: needs-kip) > Support offset reset capability in Kafka Connect >

[jira] [Commented] (KAFKA-4107) Support offset reset capability in Kafka Connect

2023-04-14 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-4107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17712414#comment-17712414 ] Mickael Maison commented on KAFKA-4107: --- This is being implemented by

[GitHub] [kafka] Hangleton commented on a diff in pull request #13535: KAFKA-9579 Fetch implementation for records in the remote storage through a specific purgatory.

2023-04-14 Thread via GitHub
Hangleton commented on code in PR #13535: URL: https://github.com/apache/kafka/pull/13535#discussion_r1166846747 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -600,6 +622,176 @@ public String toString() { } } +public FetchDataInfo

[GitHub] [kafka] divijvaidya commented on a diff in pull request #13561: KAFKA-14888: Added remote log segments retention functionality based on time and size.

2023-04-14 Thread via GitHub
divijvaidya commented on code in PR #13561: URL: https://github.com/apache/kafka/pull/13561#discussion_r1166622209 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -581,11 +588,18 @@ public void run() { if (isLeader()) {

[GitHub] [kafka] mjsax merged pull request #13563: MINOR: Refactor changelogger to accept timestamp

2023-04-14 Thread via GitHub
mjsax merged PR #13563: URL: https://github.com/apache/kafka/pull/13563 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] mumrah merged pull request #13573: MINOR Disable the dual write integration test until KAFKA-14840

2023-04-14 Thread via GitHub
mumrah merged PR #13573: URL: https://github.com/apache/kafka/pull/13573 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Updated] (KAFKA-10892) Add Topology#connectSourceStoreAndTopic as a public method

2023-04-14 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10892?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mickael Maison updated KAFKA-10892: --- Fix Version/s: 3.6.0 > Add Topology#connectSourceStoreAndTopic as a public method >

[jira] [Updated] (KAFKA-10892) Add Topology#connectSourceStoreAndTopic as a public method

2023-04-14 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10892?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mickael Maison updated KAFKA-10892: --- Labels: kip (was: ) > Add Topology#connectSourceStoreAndTopic as a public method >

[GitHub] [kafka] mumrah opened a new pull request, #13573: MINOR Disable the dual write integration test until KAFKA-14840

2023-04-14 Thread via GitHub
mumrah opened a new pull request, #13573: URL: https://github.com/apache/kafka/pull/13573 Until the KRaft controller supports pre-migration mode, it is possible for metadata updates to happen before the migration starts during tests. -- This is an automated message from the Apache Git

[GitHub] [kafka] ijuma commented on pull request #13548: MINOR: Fix regression in MM2 task forwarding introduced by KAFKA-14783

2023-04-14 Thread via GitHub
ijuma commented on PR #13548: URL: https://github.com/apache/kafka/pull/13548#issuecomment-1508573002 The PR build has 95 failures: > Build / JDK 17 and Scala 2.13 / org.apache.kafka.common.network.SslTransportLayerTest.[2] tlsProtocol=TLSv1.2, useInlinePem=true Build / JDK 17

[jira] [Assigned] (KAFKA-14091) Suddenly-killed tasks can leave hanging transactions open

2023-04-14 Thread Sudesh Wasnik (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14091?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sudesh Wasnik reassigned KAFKA-14091: - Assignee: Sudesh Wasnik (was: Sagar Rao) > Suddenly-killed tasks can leave hanging

[GitHub] [kafka] urbandan commented on a diff in pull request #13557: KAFKA-14902: KafkaStatusBackingStore retries on a dedicated backgroun…

2023-04-14 Thread via GitHub
urbandan commented on code in PR #13557: URL: https://github.com/apache/kafka/pull/13557#discussion_r1166859143 ## clients/src/main/java/org/apache/kafka/common/utils/ThreadUtils.java: ## @@ -52,4 +55,26 @@ public Thread newThread(Runnable r) { } }; }

[GitHub] [kafka] viktorsomogyi commented on a diff in pull request #13557: KAFKA-14902: KafkaStatusBackingStore retries on a dedicated backgroun…

2023-04-14 Thread via GitHub
viktorsomogyi commented on code in PR #13557: URL: https://github.com/apache/kafka/pull/13557#discussion_r1166798950 ## clients/src/main/java/org/apache/kafka/common/utils/ThreadUtils.java: ## @@ -52,4 +55,26 @@ public Thread newThread(Runnable r) { } };

[GitHub] [kafka] dajac commented on pull request #13537: KAFKA-14462; [7/N] Add ClientAssignor, Assignment, TopicMetadata and VersionedMetadata

2023-04-14 Thread via GitHub
dajac commented on PR #13537: URL: https://github.com/apache/kafka/pull/13537#issuecomment-1508440940 @clolov Thanks for the comments. I have addressed them while rebasing the PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[jira] [Updated] (KAFKA-7739) Kafka Tiered Storage

2023-04-14 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7739?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mickael Maison updated KAFKA-7739: -- Fix Version/s: 3.6.0 (was: 3.5.0) > Kafka Tiered Storage >

[GitHub] [kafka] dajac merged pull request #13536: KAFKA-14462; [6/N] Update Records

2023-04-14 Thread via GitHub
dajac merged PR #13536: URL: https://github.com/apache/kafka/pull/13536 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] dajac merged pull request #13524: MINOR: Refine `PartitionAssignor` server-side interface

2023-04-14 Thread via GitHub
dajac merged PR #13524: URL: https://github.com/apache/kafka/pull/13524 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

  1   2   >