[GitHub] [kafka] satishd commented on a diff in pull request #13535: KAFKA-9579 Fetch implementation for records in the remote storage through a specific purgatory.

satishd commented on code in PR #13535: URL: https://github.com/apache/kafka/pull/13535#discussion_r1170269949 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -1083,48 +1095,100 @@ class ReplicaManager(val config: KafkaConfig, fetchPartitionStatus +=

[GitHub] [kafka] dengziming commented on a diff in pull request #13432: KAFKA-14821 Implement the listOffsets API with AdminApiDriver

dengziming commented on code in PR #13432: URL: https://github.com/apache/kafka/pull/13432#discussion_r1170758199 ## clients/src/main/java/org/apache/kafka/clients/admin/internals/ListOffsetsHandler.java: ## @@ -0,0 +1,209 @@ +/* + * Licensed to the Apache Software Foundation

[jira] [Resolved] (KAFKA-14908) Sporadic "Address already in use" when starting kafka cluster embedded within tests

[ https://issues.apache.org/jira/browse/KAFKA-14908?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen resolved KAFKA-14908. --- Fix Version/s: 3.6.0 Resolution: Fixed > Sporadic "Address already in use" when starting

[GitHub] [kafka] showuon merged pull request #13572: KAFKA-14908: Set setReuseAddress on the kafka server socket

showuon merged PR #13572: URL: https://github.com/apache/kafka/pull/13572 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (KAFKA-14586) Move StreamsResetter to tools

[ https://issues.apache.org/jira/browse/KAFKA-14586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17713836#comment-17713836 ] Matthias J. Sax commented on KAFKA-14586: - Thanks for providing context, and no worries about

[GitHub] [kafka] hudeqi commented on pull request #13473: KAFKA-14866:Remove controller module metrics when broker is shutting down

hudeqi commented on PR #13473: URL: https://github.com/apache/kafka/pull/13473#issuecomment-1514011903 Hello, can you help to review this PR? @mimaison -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [kafka] mjsax commented on a diff in pull request #13609: KAFKA-14834: [11/N] Update table joins to identify out-of-order records with `isLatest`

mjsax commented on code in PR #13609: URL: https://github.com/apache/kafka/pull/13609#discussion_r1170677125 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/graph/KTableKTableJoinNode.java: ## @@ -97,6 +95,27 @@ public KTableKTableJoinMerger joinMerger() {

[GitHub] [kafka] hachikuji commented on a diff in pull request #13579: KAFKA-14904: Flaky Test kafka.api.TransactionsBounceTest.testWithGroupId()

hachikuji commented on code in PR #13579: URL: https://github.com/apache/kafka/pull/13579#discussion_r1170696945 ## core/src/main/scala/kafka/coordinator/transaction/TransactionCoordinator.scala: ## @@ -332,24 +331,42 @@ class TransactionCoordinator(txnConfig:

[GitHub] [kafka] hachikuji commented on a diff in pull request #13579: KAFKA-14904: Flaky Test kafka.api.TransactionsBounceTest.testWithGroupId()

hachikuji commented on code in PR #13579: URL: https://github.com/apache/kafka/pull/13579#discussion_r1170696945 ## core/src/main/scala/kafka/coordinator/transaction/TransactionCoordinator.scala: ## @@ -332,24 +331,42 @@ class TransactionCoordinator(txnConfig:

[GitHub] [kafka] lanshiqin commented on a diff in pull request #13584: MINOR: Add log segment unit tests, If the maximum offset beyond index, appen…

lanshiqin commented on code in PR #13584: URL: https://github.com/apache/kafka/pull/13584#discussion_r1170685549 ## core/src/test/scala/unit/kafka/log/LogSegmentTest.scala: ## @@ -65,6 +68,28 @@ class LogSegmentTest { Utils.delete(logDir) } + /** + * If the maximum

[GitHub] [kafka] jolshan commented on a diff in pull request #13579: KAFKA-14904: Flaky Test kafka.api.TransactionsBounceTest.testWithGroupId()

jolshan commented on code in PR #13579: URL: https://github.com/apache/kafka/pull/13579#discussion_r1170681401 ## core/src/main/scala/kafka/coordinator/transaction/TransactionCoordinator.scala: ## @@ -332,24 +331,45 @@ class TransactionCoordinator(txnConfig: TransactionConfig,

[GitHub] [kafka] jolshan commented on a diff in pull request #13579: KAFKA-14904: Flaky Test kafka.api.TransactionsBounceTest.testWithGroupId()

jolshan commented on code in PR #13579: URL: https://github.com/apache/kafka/pull/13579#discussion_r1170681193 ## core/src/main/scala/kafka/coordinator/transaction/TransactionCoordinator.scala: ## @@ -332,24 +331,45 @@ class TransactionCoordinator(txnConfig: TransactionConfig,

[GitHub] [kafka] hachikuji commented on a diff in pull request #13579: KAFKA-14904: Flaky Test kafka.api.TransactionsBounceTest.testWithGroupId()

hachikuji commented on code in PR #13579: URL: https://github.com/apache/kafka/pull/13579#discussion_r1170680513 ## core/src/main/scala/kafka/coordinator/transaction/TransactionCoordinator.scala: ## @@ -332,24 +331,45 @@ class TransactionCoordinator(txnConfig:

[GitHub] [kafka] artemlivshits commented on a diff in pull request #13579: KAFKA-14904: Flaky Test kafka.api.TransactionsBounceTest.testWithGroupId()

artemlivshits commented on code in PR #13579: URL: https://github.com/apache/kafka/pull/13579#discussion_r1170670464 ## core/src/main/scala/kafka/coordinator/transaction/TransactionCoordinator.scala: ## @@ -332,24 +331,45 @@ class TransactionCoordinator(txnConfig:

[jira] [Created] (KAFKA-14920) Address timeouts and out of order sequences

Justine Olshan created KAFKA-14920: -- Summary: Address timeouts and out of order sequences Key: KAFKA-14920 URL: https://issues.apache.org/jira/browse/KAFKA-14920 Project: Kafka Issue Type:

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #13443: KAFKA-14514: Add Server Side Sticky Range Assignor (KIP-848)

rreddy-22 commented on code in PR #13443: URL: https://github.com/apache/kafka/pull/13443#discussion_r1170662644 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/assignor/RangeAssignorTest.java: ## @@ -0,0 +1,416 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #13443: KAFKA-14514: Add Server Side Sticky Range Assignor (KIP-848)

rreddy-22 commented on code in PR #13443: URL: https://github.com/apache/kafka/pull/13443#discussion_r1170662644 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/assignor/RangeAssignorTest.java: ## @@ -0,0 +1,416 @@ +/* + * Licensed to the Apache Software

[jira] [Resolved] (KAFKA-14917) Producer write while transaction is pending.

[ https://issues.apache.org/jira/browse/KAFKA-14917?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justine Olshan resolved KAFKA-14917. Resolution: Won't Fix > Producer write while transaction is pending. >

[jira] [Commented] (KAFKA-14917) Producer write while transaction is pending.

[ https://issues.apache.org/jira/browse/KAFKA-14917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17713794#comment-17713794 ] Justine Olshan commented on KAFKA-14917: Turns out we set state to pending when we are adding

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #13443: KAFKA-14514: Add Server Side Sticky Range Assignor (KIP-848)

rreddy-22 commented on code in PR #13443: URL: https://github.com/apache/kafka/pull/13443#discussion_r1170659867 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/RangeAssignor.java: ## @@ -0,0 +1,240 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #13443: KAFKA-14514: Add Server Side Sticky Range Assignor (KIP-848)

rreddy-22 commented on code in PR #13443: URL: https://github.com/apache/kafka/pull/13443#discussion_r1170658595 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/RangeAssignor.java: ## @@ -0,0 +1,240 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #13443: KAFKA-14514: Add Server Side Sticky Range Assignor (KIP-848)

rreddy-22 commented on code in PR #13443: URL: https://github.com/apache/kafka/pull/13443#discussion_r1170658513 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/RangeAssignor.java: ## @@ -0,0 +1,240 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] vcrfxia commented on a diff in pull request #13497: KAFKA-14834: [2/N] Test coverage for out-of-order data in joins

vcrfxia commented on code in PR #13497: URL: https://github.com/apache/kafka/pull/13497#discussion_r1170638852 ## streams/src/test/java/org/apache/kafka/streams/integration/AbstractJoinIntegrationTest.java: ## @@ -88,31 +88,35 @@ public static Collection data() {

[GitHub] [kafka] vcrfxia commented on a diff in pull request #13609: KAFKA-14834: [11/N] Update table joins to identify out-of-order records with `isLatest`

vcrfxia commented on code in PR #13609: URL: https://github.com/apache/kafka/pull/13609#discussion_r1170638371 ## streams/src/test/java/org/apache/kafka/streams/integration/AbstractJoinIntegrationTest.java: ## @@ -87,7 +87,37 @@ public static Collection data() {

[GitHub] [kafka] vcrfxia commented on a diff in pull request #13609: KAFKA-14834: [11/N] Update table joins to identify out-of-order records with `isLatest`

vcrfxia commented on code in PR #13609: URL: https://github.com/apache/kafka/pull/13609#discussion_r1170633123 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/KTableImpl.java: ## @@ -804,6 +806,7 @@ private KTable doJoin(final KTable other,

[GitHub] [kafka] vcrfxia opened a new pull request, #13609: KAFKA-14834: [11/N] Update table joins to identify out-of-order records with `isLatest`

vcrfxia opened a new pull request, #13609: URL: https://github.com/apache/kafka/pull/13609 There's a bug in the table-table join handling of out-of-order records in versioned tables (see https://github.com/apache/kafka/pull/13510 and https://github.com/apache/kafka/pull/13522 for context)

[jira] [Resolved] (KAFKA-14881) Update UserScramCredentialRecord for SCRAM ZK to KRaft migration

[ https://issues.apache.org/jira/browse/KAFKA-14881?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Proven Provenzano resolved KAFKA-14881. --- Resolution: Fixed Merged to Trunk and 3.5. > Update UserScramCredentialRecord for

[jira] [Created] (KAFKA-14919) MM2 ForwardingAdmin tests should not conflate admin operations

Greg Harris created KAFKA-14919: --- Summary: MM2 ForwardingAdmin tests should not conflate admin operations Key: KAFKA-14919 URL: https://issues.apache.org/jira/browse/KAFKA-14919 Project: Kafka

[GitHub] [kafka] gharris1727 commented on pull request #13575: KAFKA-14905: Reduce flakiness in MM2 ForwardingAdmin test due to admin timeouts

gharris1727 commented on PR #13575: URL: https://github.com/apache/kafka/pull/13575#issuecomment-1513850889 Follow-up ticket: https://issues.apache.org/jira/browse/KAFKA-14919 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[jira] [Assigned] (KAFKA-14905) Failing tests in MM2 ForwardingAdmin test since KIP-894

[ https://issues.apache.org/jira/browse/KAFKA-14905?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Harris reassigned KAFKA-14905: --- Assignee: Greg Harris > Failing tests in MM2 ForwardingAdmin test since KIP-894 >

[jira] [Updated] (KAFKA-14905) Failing tests in MM2 ForwardingAdmin test since KIP-894

[ https://issues.apache.org/jira/browse/KAFKA-14905?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Harris updated KAFKA-14905: Labels: flaky-test (was: ) > Failing tests in MM2 ForwardingAdmin test since KIP-894 >

[GitHub] [kafka] philipnee commented on a diff in pull request #13550: KAFKA-14639 - A single partition may be revoked and assign during a single round of rebalance

philipnee commented on code in PR #13550: URL: https://github.com/apache/kafka/pull/13550#discussion_r1170599794 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java: ## @@ -835,6 +835,7 @@ public void handle(SyncGroupResponse

[GitHub] [kafka] gharris1727 commented on pull request #13575: KAFKA-14905: Intercept incrementalAlterConfigs in MM2 ForwardingAdminTest

gharris1727 commented on PR #13575: URL: https://github.com/apache/kafka/pull/13575#issuecomment-1513825281 Okay, upon further investigation it appears that this is technically a flakey test failure, it just nearly always fails in CI due to CPU load. The core reason for the failure is that

[GitHub] [kafka] jolshan opened a new pull request, #13608: KAFKA-14844: Include check transaction is still ongoing right before append

jolshan opened a new pull request, #13608: URL: https://github.com/apache/kafka/pull/13608 We will need to pick up the changes in KAFKA-14916 (right now we assume producer ID is shared in all batches), but wanted to get a WIP draft out for general ideas. Will need to add the

[GitHub] [kafka] mjsax commented on pull request #13589: MINOR: rename internal FK-join processor classes

mjsax commented on PR #13589: URL: https://github.com/apache/kafka/pull/13589#issuecomment-1513693392 Merged to `trunk` and cherry-picked to `3.5` and `3.4` branches. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [kafka] jolshan commented on pull request #13607: KAFKA-14916: Fix code that assumes transactional ID implies all records are transactional

jolshan commented on PR #13607: URL: https://github.com/apache/kafka/pull/13607#issuecomment-1513675548 I already see the checkstyle issues created by my IDE so I will fix in a bit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [kafka] jolshan opened a new pull request, #13607: KAFKA-14916: Fix code that assumes transactional ID implies all records are transactional

jolshan opened a new pull request, #13607: URL: https://github.com/apache/kafka/pull/13607 Adds validation to ensure all producer IDs in a transactional/idempotent produce request are the same. Also modifies verification to only add a partition to verify if it is transactional.

[GitHub] [kafka] chia7712 merged pull request #13588: [MINOR]: Fixing gradle build during compileScala and compileTestScala

chia7712 merged PR #13588: URL: https://github.com/apache/kafka/pull/13588 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] cmccabe commented on a diff in pull request #13606: KAFKA-14918 Only send controller RPCs to migrating ZK brokers

cmccabe commented on code in PR #13606: URL: https://github.com/apache/kafka/pull/13606#discussion_r1170454667 ## core/src/main/scala/kafka/migration/MigrationPropagator.scala: ## @@ -70,14 +70,24 @@ class MigrationPropagator( override def publishMetadata(image:

[jira] [Updated] (KAFKA-14918) KRaft controller sending ZK controller RPCs to KRaft brokers

[ https://issues.apache.org/jira/browse/KAFKA-14918?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Arthur updated KAFKA-14918: - Fix Version/s: 3.5.0 > KRaft controller sending ZK controller RPCs to KRaft brokers >

[jira] [Created] (KAFKA-14918) KRaft controller sending ZK controller RPCs to KRaft brokers

David Arthur created KAFKA-14918: Summary: KRaft controller sending ZK controller RPCs to KRaft brokers Key: KAFKA-14918 URL: https://issues.apache.org/jira/browse/KAFKA-14918 Project: Kafka

[GitHub] [kafka] dimitarndimitrov commented on a diff in pull request #13432: KAFKA-14821 Implement the listOffsets API with AdminApiDriver

dimitarndimitrov commented on code in PR #13432: URL: https://github.com/apache/kafka/pull/13432#discussion_r1170437027 ## clients/src/main/java/org/apache/kafka/clients/admin/internals/AdminApiDriver.java: ## @@ -260,12 +261,29 @@ public void onFailure(

[GitHub] [kafka] mjsax merged pull request #13589: MINOR: rename internal FK-join processor classes

mjsax merged PR #13589: URL: https://github.com/apache/kafka/pull/13589 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] emissionnebula commented on pull request #13437: KAFKA-14828: Remove R/W locks using persistent data structures

emissionnebula commented on PR #13437: URL: https://github.com/apache/kafka/pull/13437#issuecomment-1513618207 A lot of [tests](https://ci-builds.apache.org/blue/rest/organizations/jenkins/pipelines/Kafka/pipelines/kafka-pr/branches/PR-13437/runs/8/log/?start=0) related to Connect seems to

[GitHub] [kafka] dajac commented on a diff in pull request #13443: KAFKA-14514: Add Server Side Sticky Range Assignor (KIP-848)

dajac commented on code in PR #13443: URL: https://github.com/apache/kafka/pull/13443#discussion_r1170357303 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/assignor/RangeAssignorTest.java: ## @@ -0,0 +1,416 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] jsancio commented on a diff in pull request #13540: MINOR: improve QuorumController logging

jsancio commented on code in PR #13540: URL: https://github.com/apache/kafka/pull/13540#discussion_r1170345743 ## metadata/src/main/java/org/apache/kafka/controller/ControllerPurgatory.java: ## @@ -65,6 +81,7 @@ void failAll(Exception exception) { while

[GitHub] [kafka] philipnee opened a new pull request, #13605: KAFKA-____: implement assign()

philipnee opened a new pull request, #13605: URL: https://github.com/apache/kafka/pull/13605 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of

[GitHub] [kafka] wcarlson5 commented on a diff in pull request #13533: KAFKA-12446: update change encoding to use varint

wcarlson5 commented on code in PR #13533: URL: https://github.com/apache/kafka/pull/13533#discussion_r1170320445 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/ChangedSerializer.java: ## @@ -104,33 +104,40 @@ public byte[] serialize(final String topic,

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #13443: KAFKA-14514: Add Server Side Sticky Range Assignor (KIP-848)

rreddy-22 commented on code in PR #13443: URL: https://github.com/apache/kafka/pull/13443#discussion_r1170322124 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/assignor/RangeAssignorTest.java: ## @@ -0,0 +1,416 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] hachikuji commented on a diff in pull request #13267: KAFKA-14694: RPCProducerIdManager should not wait on new block

hachikuji commented on code in PR #13267: URL: https://github.com/apache/kafka/pull/13267#discussion_r1170301813 ## core/src/main/scala/kafka/coordinator/transaction/ProducerIdManager.scala: ## @@ -207,35 +234,38 @@ class RPCProducerIdManager(brokerId: Int, }) } + //

[GitHub] [kafka] cmccabe closed pull request #13590: Scram kraft update user scram credential record

cmccabe closed pull request #13590: Scram kraft update user scram credential record URL: https://github.com/apache/kafka/pull/13590 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [kafka] cmccabe merged pull request #13513: KAFKA-14881: Rework UserScramCredentialRecord

cmccabe merged PR #13513: URL: https://github.com/apache/kafka/pull/13513 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] satishd commented on a diff in pull request #13535: KAFKA-9579 Fetch implementation for records in the remote storage through a specific purgatory.

satishd commented on code in PR #13535: URL: https://github.com/apache/kafka/pull/13535#discussion_r1170273242 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -600,6 +622,176 @@ public String toString() { } } +public FetchDataInfo

[GitHub] [kafka] satishd commented on a diff in pull request #13535: KAFKA-9579 Fetch implementation for records in the remote storage through a specific purgatory.

satishd commented on code in PR #13535: URL: https://github.com/apache/kafka/pull/13535#discussion_r1168261768 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -1243,6 +1327,33 @@ class ReplicaManager(val config: KafkaConfig, result } + def

[GitHub] [kafka] k-wall commented on pull request #13572: KAFKA-14908: Set setReuseAddress on the kafka server socket

k-wall commented on PR #13572: URL: https://github.com/apache/kafka/pull/13572#issuecomment-1513428217 @divijvaidya thanks for the review feedback, much appreciated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [kafka] k-wall commented on a diff in pull request #13572: KAFKA-14908: Set setReuseAddress on the kafka server socket

k-wall commented on code in PR #13572: URL: https://github.com/apache/kafka/pull/13572#discussion_r1170252886 ## core/src/test/scala/unit/kafka/network/SocketServerTest.scala: ## @@ -1893,6 +1893,33 @@ class SocketServerTest { }, false) } + @Test + def

[GitHub] [kafka] k-wall commented on a diff in pull request #13572: KAFKA-14908: Set setReuseAddress on the kafka server socket

k-wall commented on code in PR #13572: URL: https://github.com/apache/kafka/pull/13572#discussion_r1170252886 ## core/src/test/scala/unit/kafka/network/SocketServerTest.scala: ## @@ -1893,6 +1893,33 @@ class SocketServerTest { }, false) } + @Test + def

[GitHub] [kafka] k-wall commented on a diff in pull request #13572: KAFKA-14908: Set setReuseAddress on the kafka server socket

k-wall commented on code in PR #13572: URL: https://github.com/apache/kafka/pull/13572#discussion_r1170251661 ## core/src/test/scala/unit/kafka/network/SocketServerTest.scala: ## @@ -1893,6 +1893,33 @@ class SocketServerTest { }, false) } + @Test + def

[GitHub] [kafka] jolshan commented on a diff in pull request #13493: KAFKA-14852: Propagate Topic Ids to the Group Coordinator for Offset Fetch

jolshan commented on code in PR #13493: URL: https://github.com/apache/kafka/pull/13493#discussion_r1170250900 ## core/src/main/scala/kafka/coordinator/group/GroupMetadataManager.scala: ## @@ -492,42 +492,59 @@ class GroupMetadataManager(brokerId: Int, * The most important

[GitHub] [kafka] divijvaidya commented on a diff in pull request #13582: MINOR: Fix lossy conversions flagged by Java 20

divijvaidya commented on code in PR #13582: URL: https://github.com/apache/kafka/pull/13582#discussion_r1170245494 ## clients/src/main/java/org/apache/kafka/common/record/DefaultRecordBatch.java: ## @@ -434,7 +434,7 @@ private static byte computeAttributes(CompressionType type,

[GitHub] [kafka] divijvaidya commented on a diff in pull request #13584: MINOR: Add log segment unit tests, If the maximum offset beyond index, appen…

divijvaidya commented on code in PR #13584: URL: https://github.com/apache/kafka/pull/13584#discussion_r1170238988 ## core/src/test/scala/unit/kafka/log/LogSegmentTest.scala: ## @@ -65,6 +68,28 @@ class LogSegmentTest { Utils.delete(logDir) } + /** + * If the

[GitHub] [kafka] divijvaidya commented on a diff in pull request #13572: KAFKA-14908: Set setReuseAddress on the kafka server socket

divijvaidya commented on code in PR #13572: URL: https://github.com/apache/kafka/pull/13572#discussion_r1170213078 ## core/src/test/scala/unit/kafka/network/SocketServerTest.scala: ## @@ -1893,6 +1893,33 @@ class SocketServerTest { }, false) } + @Test + def

[GitHub] [kafka] urbandan commented on a diff in pull request #13591: KAFKA-14831: Illegal state errors should be fatal in transactional producer

urbandan commented on code in PR #13591: URL: https://github.com/apache/kafka/pull/13591#discussion_r1170149228 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java: ## @@ -266,7 +266,7 @@ public synchronized TransactionalRequestResult

[GitHub] [kafka] urbandan commented on a diff in pull request #13591: KAFKA-14831: Illegal state errors should be fatal in transactional producer

urbandan commented on code in PR #13591: URL: https://github.com/apache/kafka/pull/13591#discussion_r1170141463 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java: ## @@ -968,13 +968,31 @@ private void transitionTo(State target) {

[GitHub] [kafka] clolov commented on a diff in pull request #13514: KAFKA-14752: Kafka examples improvements - consumer changes

clolov commented on code in PR #13514: URL: https://github.com/apache/kafka/pull/13514#discussion_r1170144013 ## examples/src/main/java/kafka/examples/Utils.java: ## @@ -0,0 +1,106 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor

[GitHub] [kafka] clolov commented on pull request #12607: KAFKA-14133: Replace EasyMock with Mockito in streams tests

clolov commented on PR #12607: URL: https://github.com/apache/kafka/pull/12607#issuecomment-1513271209 Okay, this makes sense to me. I will aim to start opening PRs in the same manner as yours in the upcoming days and let's see where we go! -- This is an automated message from the Apache

[GitHub] [kafka] jeffkbkim opened a new pull request, #13604: KAFKA-14869: Bump coordinator value records to flexible versions (KIP…

jeffkbkim opened a new pull request, #13604: URL: https://github.com/apache/kafka/pull/13604 …-915, Part-2) (#13526) This patch implemented the second part of KIP-915. It bumps the versions of the value records used by the group coordinator and the transaction coordinator to make

[GitHub] [kafka] jeffkbkim opened a new pull request, #13603: KAFKA-14869: Bump coordinator value records to flexible versions (KIP…

jeffkbkim opened a new pull request, #13603: URL: https://github.com/apache/kafka/pull/13603 …-915, Part-2) (#13526) This patch implemented the second part of KIP-915. It bumps the versions of the value records used by the group coordinator and the transaction coordinator to make

[GitHub] [kafka] clolov commented on a diff in pull request #13529: KAFKA-14133: Migrate topology builder mock in TaskManagerTest to mockito

clolov commented on code in PR #13529: URL: https://github.com/apache/kafka/pull/13529#discussion_r1170120571 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/TaskManagerTest.java: ## @@ -2895,10 +2871,8 @@ public void

[GitHub] [kafka] jeffkbkim opened a new pull request, #13602: KAFKA-14869: Bump coordinator value records to flexible versions (KIP…

jeffkbkim opened a new pull request, #13602: URL: https://github.com/apache/kafka/pull/13602 …-915, Part-2) (#13526) This patch implemented the second part of KIP-915. It bumps the versions of the value records used by the group coordinator and the transaction coordinator to make

[GitHub] [kafka] jeffkbkim opened a new pull request, #13601: KAFKA-14869: Bump coordinator value records to flexible versions (KIP…

jeffkbkim opened a new pull request, #13601: URL: https://github.com/apache/kafka/pull/13601 …-915, Part-2) (#13526) This patch implemented the second part of KIP-915. It bumps the versions of the value records used by the group coordinator and the transaction coordinator to make

[GitHub] [kafka] philipnee commented on a diff in pull request #13550: KAFKA-14639 - A single partition may be revoked and assign during a single round of rebalance

philipnee commented on code in PR #13550: URL: https://github.com/apache/kafka/pull/13550#discussion_r1170098942 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java: ## @@ -835,6 +835,7 @@ public void handle(SyncGroupResponse

[GitHub] [kafka] philipnee commented on a diff in pull request #13550: KAFKA-14639 - A single partition may be revoked and assign during a single round of rebalance

philipnee commented on code in PR #13550: URL: https://github.com/apache/kafka/pull/13550#discussion_r1170094810 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java: ## @@ -835,6 +835,7 @@ public void handle(SyncGroupResponse

[GitHub] [kafka] philipnee commented on a diff in pull request #13550: KAFKA-14639 - A single partition may be revoked and assign during a single round of rebalance

philipnee commented on code in PR #13550: URL: https://github.com/apache/kafka/pull/13550#discussion_r1170094810 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java: ## @@ -835,6 +835,7 @@ public void handle(SyncGroupResponse

[GitHub] [kafka] jeffkbkim opened a new pull request, #13600: KAFKA-14869: Bump coordinator value records to flexible versions (KIP…

jeffkbkim opened a new pull request, #13600: URL: https://github.com/apache/kafka/pull/13600 …-915, Part-2) (#13526) This patch implemented the second part of KIP-915. It bumps the versions of the value records used by the group coordinator and the transaction coordinator to make

[GitHub] [kafka] mimaison commented on pull request #11478: KAFKA-13299: Accept duplicate listener on port for IPv4/IPv6

mimaison commented on PR #11478: URL: https://github.com/apache/kafka/pull/11478#issuecomment-1513201845 Hi @jlprat, the point of tests is also to ensure future changes don't break this feature. You're more familiar with this feature than me, if you think the unit tests are enough, you can

[jira] [Updated] (KAFKA-14869) txn and group coordinator downgrade foundation

[ https://issues.apache.org/jira/browse/KAFKA-14869?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mickael Maison updated KAFKA-14869: --- Fix Version/s: 3.5.0 > txn and group coordinator downgrade foundation >

[GitHub] [kafka] jeffkbkim commented on a diff in pull request #13267: KAFKA-14694: RPCProducerIdManager should not wait on new block

jeffkbkim commented on code in PR #13267: URL: https://github.com/apache/kafka/pull/13267#discussion_r1170068205 ## core/src/main/scala/kafka/coordinator/transaction/ProducerIdManager.scala: ## @@ -123,73 +129,95 @@ class ZkProducerIdManager(brokerId: Int, } } - def

[GitHub] [kafka] dajac commented on pull request #13526: KAFKA-14869: Bump coordinator Value records to flexible versions (KIP-915, Part-2)

dajac commented on PR #13526: URL: https://github.com/apache/kafka/pull/13526#issuecomment-1513180068 Merged to trunk and 3.5. We need to open PRs for the other branches. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [kafka] dajac merged pull request #13526: KAFKA-14869: Bump coordinator Value records to flexible versions (KIP-915, Part-2)

dajac merged PR #13526: URL: https://github.com/apache/kafka/pull/13526 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] ijuma commented on a diff in pull request #13582: MINOR: Fix lossy conversions flagged by Java 20

ijuma commented on code in PR #13582: URL: https://github.com/apache/kafka/pull/13582#discussion_r1170050264 ## clients/src/main/java/org/apache/kafka/common/record/DefaultRecordBatch.java: ## @@ -434,7 +434,7 @@ private static byte computeAttributes(CompressionType type,

[jira] [Resolved] (KAFKA-14735) Improve KRaft metadata image change performance at high topic counts

[ https://issues.apache.org/jira/browse/KAFKA-14735?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ron Dagostino resolved KAFKA-14735. --- Resolution: Fixed > Improve KRaft metadata image change performance at high topic counts >

[GitHub] [kafka] dimitarndimitrov commented on a diff in pull request #13432: KAFKA-14821 Implement the listOffsets API with AdminApiDriver

dimitarndimitrov commented on code in PR #13432: URL: https://github.com/apache/kafka/pull/13432#discussion_r1170024821 ## clients/src/main/java/org/apache/kafka/clients/admin/internals/ListOffsetsHandler.java: ## @@ -0,0 +1,229 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] dajac commented on a diff in pull request #13443: KAFKA-14514: Add Server Side Sticky Range Assignor (KIP-848)

dajac commented on code in PR #13443: URL: https://github.com/apache/kafka/pull/13443#discussion_r1170021475 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/assignor/RangeAssignorTest.java: ## @@ -0,0 +1,416 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] dajac commented on a diff in pull request #13443: KAFKA-14514: Add Server Side Sticky Range Assignor (KIP-848)

dajac commented on code in PR #13443: URL: https://github.com/apache/kafka/pull/13443#discussion_r1170017991 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/assignor/RangeAssignorTest.java: ## @@ -0,0 +1,416 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] dajac commented on a diff in pull request #13443: KAFKA-14514: Add Server Side Sticky Range Assignor (KIP-848)

dajac commented on code in PR #13443: URL: https://github.com/apache/kafka/pull/13443#discussion_r1170014726 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/assignor/RangeAssignorTest.java: ## @@ -0,0 +1,416 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] dajac commented on a diff in pull request #13443: KAFKA-14514: Add Server Side Sticky Range Assignor (KIP-848)

dajac commented on code in PR #13443: URL: https://github.com/apache/kafka/pull/13443#discussion_r1170013892 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/assignor/RangeAssignorTest.java: ## @@ -0,0 +1,416 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] dimitarndimitrov commented on a diff in pull request #13432: KAFKA-14821 Implement the listOffsets API with AdminApiDriver

dimitarndimitrov commented on code in PR #13432: URL: https://github.com/apache/kafka/pull/13432#discussion_r1170012160 ## clients/src/main/java/org/apache/kafka/clients/admin/internals/ListOffsetsHandler.java: ## @@ -0,0 +1,209 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] dajac commented on a diff in pull request #13443: KAFKA-14514: Add Server Side Sticky Range Assignor (KIP-848)

dajac commented on code in PR #13443: URL: https://github.com/apache/kafka/pull/13443#discussion_r1170010343 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/assignor/RangeAssignorTest.java: ## @@ -0,0 +1,416 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] dajac commented on a diff in pull request #13443: KAFKA-14514: Add Server Side Sticky Range Assignor (KIP-848)

dajac commented on code in PR #13443: URL: https://github.com/apache/kafka/pull/13443#discussion_r1170007516 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/RangeAssignor.java: ## @@ -0,0 +1,240 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] dajac commented on a diff in pull request #13443: KAFKA-14514: Add Server Side Sticky Range Assignor (KIP-848)

dajac commented on code in PR #13443: URL: https://github.com/apache/kafka/pull/13443#discussion_r1170005574 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/RangeAssignor.java: ## @@ -0,0 +1,240 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] jeffkbkim opened a new pull request, #13599: KAFKA-14869: Ignore unknown record types for coordinators (KIP-915, P…

jeffkbkim opened a new pull request, #13599: URL: https://github.com/apache/kafka/pull/13599 …art-1) (#13511) This patch implemented the first part of KIP-915. It updates the group coordinator and the transaction coordinator to ignores unknown record types while loading their

[GitHub] [kafka] jeffkbkim opened a new pull request, #13598: KAFKA-14869: Ignore unknown record types for coordinators (KIP-915, P…

jeffkbkim opened a new pull request, #13598: URL: https://github.com/apache/kafka/pull/13598 …art-1) (#13511) This patch implemented the first part of KIP-915. It updates the group coordinator and the transaction coordinator to ignores unknown record types while loading their

[GitHub] [kafka] jeffkbkim opened a new pull request, #13597: KAFKA-14869: Ignore unknown record types for coordinators (KIP-915, P…

jeffkbkim opened a new pull request, #13597: URL: https://github.com/apache/kafka/pull/13597 …art-1) (#13511) This patch implemented the first part of KIP-915. It updates the group coordinator and the transaction coordinator to ignores unknown record types while loading their

[GitHub] [kafka] dajac commented on a diff in pull request #13443: KAFKA-14514: Add Server Side Sticky Range Assignor (KIP-848)

dajac commented on code in PR #13443: URL: https://github.com/apache/kafka/pull/13443#discussion_r1169982137 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/RangeAssignor.java: ## @@ -0,0 +1,240 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] jeffkbkim opened a new pull request, #13596: KAFKA-14869: Ignore unknown record types for coordinators (KIP-915, P…

jeffkbkim opened a new pull request, #13596: URL: https://github.com/apache/kafka/pull/13596 …art-1) (#13511) This patch implemented the first part of KIP-915. It updates the group coordinator and the transaction coordinator to ignores unknown record types while loading their

[GitHub] [kafka] divijvaidya commented on pull request #13572: KAFKA-14908: Set setReuseAddress on the kafka server socket

divijvaidya commented on PR #13572: URL: https://github.com/apache/kafka/pull/13572#issuecomment-1513029513 @showuon That's a good point. The problem I want to solve here is to ensure that tests are using the same code that SocketServer is using. If we implement a method in `TestUtils`

[GitHub] [kafka] dajac commented on a diff in pull request #13443: KAFKA-14514: Add Server Side Sticky Range Assignor (KIP-848)

dajac commented on code in PR #13443: URL: https://github.com/apache/kafka/pull/13443#discussion_r1169966483 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/RangeAssignor.java: ## @@ -0,0 +1,240 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] dajac commented on a diff in pull request #13443: KAFKA-14514: Add Server Side Sticky Range Assignor (KIP-848)

dajac commented on code in PR #13443: URL: https://github.com/apache/kafka/pull/13443#discussion_r1169959223 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/RangeAssignor.java: ## @@ -0,0 +1,240 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] dajac commented on a diff in pull request #13443: KAFKA-14514: Add Server Side Sticky Range Assignor (KIP-848)

dajac commented on code in PR #13443: URL: https://github.com/apache/kafka/pull/13443#discussion_r1169958192 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/RangeAssignor.java: ## @@ -0,0 +1,240 @@ +/* + * Licensed to the Apache Software

  1   2   >