[GitHub] [kafka] philipnee commented on a diff in pull request #13550: KAFKA-14639 - A single partition may be revoked and assign during a single round of rebalance

philipnee commented on code in PR #13550: URL: https://github.com/apache/kafka/pull/13550#discussion_r1172072549 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java: ## @@ -835,6 +839,8 @@ public void handle(SyncGroupResponse

[GitHub] [kafka] philipnee opened a new pull request, #13618: MINOR: Fixing typos in the ConsumerCoordinators

philipnee opened a new pull request, #13618: URL: https://github.com/apache/kafka/pull/13618 Not very much really, just fixing some typos. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] jolshan commented on a diff in pull request #13607: KAFKA-14916: Fix code that assumes transactional ID implies all records are transactional

jolshan commented on code in PR #13607: URL: https://github.com/apache/kafka/pull/13607#discussion_r1172068360 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -565,6 +565,12 @@ class KafkaApis(val requestChannel: RequestChannel,

[GitHub] [kafka] dengziming merged pull request #13432: KAFKA-14821 Implement the listOffsets API with AdminApiDriver

dengziming merged PR #13432: URL: https://github.com/apache/kafka/pull/13432 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] hudeqi opened a new pull request, #13617: MINOR:code optimization in QuorumController

hudeqi opened a new pull request, #13617: URL: https://github.com/apache/kafka/pull/13617 1. add hint in switch item "BROKER_LOGGER" in ConfigResourceExistenceChecker, otherwise, it will be classified as default break and deleted directly. I don’t know if adding hint is better than

[GitHub] [kafka] dengziming commented on pull request #13432: KAFKA-14821 Implement the listOffsets API with AdminApiDriver

dengziming commented on PR #13432: URL: https://github.com/apache/kafka/pull/13432#issuecomment-1515639065 Notable changes better than old logic: 1. Retry lookup stage on receiving `NOT_LEADER_OR_FOLLOWER` and `LEADER_NOT_AVAILABLE`, whereas in the past we failed the partition directly

[jira] [Updated] (KAFKA-14922) kafka-streams-application-reset deletes topics not belonging to specified application-id

[ https://issues.apache.org/jira/browse/KAFKA-14922?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-14922: Component/s: streams tools > kafka-streams-application-reset deletes

[jira] [Commented] (KAFKA-14922) kafka-streams-application-reset deletes topics not belonging to specified application-id

[ https://issues.apache.org/jira/browse/KAFKA-14922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17714354#comment-17714354 ] Matthias J. Sax commented on KAFKA-14922: - Thanks for creating this ticket. It's a know issue

[GitHub] [kafka] ykubota commented on a diff in pull request #13532: KAFKA-14887: No shutdown for ZK session expiration in feature processing

ykubota commented on code in PR #13532: URL: https://github.com/apache/kafka/pull/13532#discussion_r1171979375 ## core/src/main/scala/kafka/server/FinalizedFeatureChangeListener.scala: ## @@ -160,10 +160,12 @@ class FinalizedFeatureChangeListener(private val

[GitHub] [kafka] rreddy-22 opened a new pull request, #13616: KAFKA-14514: Add Optimized Uniform Assignor (KIP-848)

rreddy-22 opened a new pull request, #13616: URL: https://github.com/apache/kafka/pull/13616 Part of KIP-848 https://cwiki.apache.org/confluence/display/KAFKA/KIP-848%3A+The+Next+Generation+of+the+Consumer+Rebalance+Protocol As a part of the new protocol, there will be assignors

[GitHub] [kafka] artemlivshits commented on a diff in pull request #13607: KAFKA-14916: Fix code that assumes transactional ID implies all records are transactional

artemlivshits commented on code in PR #13607: URL: https://github.com/apache/kafka/pull/13607#discussion_r1171959120 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -565,6 +565,12 @@ class KafkaApis(val requestChannel: RequestChannel,

[GitHub] [kafka] mjsax commented on pull request #13609: KAFKA-14834: [11/N] Update table joins to identify out-of-order records with `isLatest`

mjsax commented on PR #13609: URL: https://github.com/apache/kafka/pull/13609#issuecomment-1515524362 Merged to `trunk` and cherry-picked to `3.5` branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [kafka] cmccabe commented on a diff in pull request #13407: KAFKA-14805 KRaft controller supports pre-migration mode

cmccabe commented on code in PR #13407: URL: https://github.com/apache/kafka/pull/13407#discussion_r1171950976 ## metadata/src/test/java/org/apache/kafka/image/publisher/SnapshotGeneratorTest.java: ## @@ -48,7 +48,7 @@ public class SnapshotGeneratorTest { static class

[GitHub] [kafka] cmccabe commented on a diff in pull request #13407: KAFKA-14805 KRaft controller supports pre-migration mode

cmccabe commented on code in PR #13407: URL: https://github.com/apache/kafka/pull/13407#discussion_r1171950562 ## metadata/src/main/java/org/apache/kafka/controller/QuorumController.java: ## @@ -869,19 +906,30 @@ public CompletableFuture acceptBatch(List recordBatch)

[GitHub] [kafka] cmccabe merged pull request #13532: KAFKA-14887: No shutdown for ZK session expiration in feature processing

cmccabe merged PR #13532: URL: https://github.com/apache/kafka/pull/13532 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] cmccabe commented on a diff in pull request #13532: KAFKA-14887: No shutdown for ZK session expiration in feature processing

cmccabe commented on code in PR #13532: URL: https://github.com/apache/kafka/pull/13532#discussion_r1171947569 ## core/src/main/scala/kafka/server/FinalizedFeatureChangeListener.scala: ## @@ -160,10 +160,12 @@ class FinalizedFeatureChangeListener(private val

[GitHub] [kafka] jolshan commented on a diff in pull request #12149: KAFKA-13668: Retry upon missing initProducerId due to authorization error

jolshan commented on code in PR #12149: URL: https://github.com/apache/kafka/pull/12149#discussion_r1171947129 ## clients/src/test/java/org/apache/kafka/clients/producer/internals/SenderTest.java: ## @@ -2175,7 +2182,7 @@ public void

[GitHub] [kafka] philipnee commented on a diff in pull request #12149: KAFKA-13668: Retry upon missing initProducerId due to authorization error

philipnee commented on code in PR #12149: URL: https://github.com/apache/kafka/pull/12149#discussion_r1171946214 ## clients/src/test/java/org/apache/kafka/clients/producer/internals/SenderTest.java: ## @@ -2175,7 +2182,7 @@ public void

[GitHub] [kafka] cmccabe commented on a diff in pull request #13461: KAFKA-14840: Support for snapshots during ZK migration

cmccabe commented on code in PR #13461: URL: https://github.com/apache/kafka/pull/13461#discussion_r1171945830 ## core/src/main/scala/kafka/zk/migration/ZkConfigMigrationClient.scala: ## @@ -0,0 +1,250 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [kafka] cmccabe commented on a diff in pull request #13461: KAFKA-14840: Support for snapshots during ZK migration

cmccabe commented on code in PR #13461: URL: https://github.com/apache/kafka/pull/13461#discussion_r1171945520 ## core/src/main/scala/kafka/zk/migration/ZkConfigMigrationClient.scala: ## @@ -0,0 +1,250 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [kafka] cmccabe commented on a diff in pull request #13461: KAFKA-14840: Support for snapshots during ZK migration

cmccabe commented on code in PR #13461: URL: https://github.com/apache/kafka/pull/13461#discussion_r1171945520 ## core/src/main/scala/kafka/zk/migration/ZkConfigMigrationClient.scala: ## @@ -0,0 +1,250 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [kafka] cmccabe commented on a diff in pull request #13461: KAFKA-14840: Support for snapshots during ZK migration

cmccabe commented on code in PR #13461: URL: https://github.com/apache/kafka/pull/13461#discussion_r1171945097 ## metadata/src/main/java/org/apache/kafka/metadata/migration/KRaftMigrationDriver.java: ## @@ -174,12 +173,12 @@ private boolean areZkBrokersReadyForMigration() {

[GitHub] [kafka] mjsax merged pull request #13609: KAFKA-14834: [11/N] Update table joins to identify out-of-order records with `isLatest`

mjsax merged PR #13609: URL: https://github.com/apache/kafka/pull/13609 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] vcrfxia commented on a diff in pull request #13615: KAFKA-14834: [12/N] Minor code cleanups relating to versioned stores

vcrfxia commented on code in PR #13615: URL: https://github.com/apache/kafka/pull/13615#discussion_r1171934110 ## streams/src/main/java/org/apache/kafka/streams/state/KeyValueStore.java: ## @@ -36,6 +37,7 @@ * @param value The value to update, it can be {@code null};

[GitHub] [kafka] cmccabe commented on a diff in pull request #13461: KAFKA-14840: Support for snapshots during ZK migration

cmccabe commented on code in PR #13461: URL: https://github.com/apache/kafka/pull/13461#discussion_r1171943462 ## core/src/main/scala/kafka/zk/migration/ZkAclMigrationClient.scala: ## @@ -0,0 +1,115 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more +

[GitHub] [kafka] cmccabe commented on a diff in pull request #13461: KAFKA-14840: Support for snapshots during ZK migration

cmccabe commented on code in PR #13461: URL: https://github.com/apache/kafka/pull/13461#discussion_r1171941841 ## metadata/src/main/java/org/apache/kafka/metadata/migration/KRaftMigrationZkWriter.java: ## @@ -0,0 +1,333 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [kafka] cmccabe commented on a diff in pull request #13461: KAFKA-14840: Support for snapshots during ZK migration

cmccabe commented on code in PR #13461: URL: https://github.com/apache/kafka/pull/13461#discussion_r1171941706 ## metadata/src/main/java/org/apache/kafka/metadata/migration/KRaftMigrationZkWriter.java: ## @@ -0,0 +1,333 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [kafka] mjsax merged pull request #13610: MINOR: update comments for FK join processor renames

mjsax merged PR #13610: URL: https://github.com/apache/kafka/pull/13610 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] cmccabe commented on pull request #13461: KAFKA-14840: Support for snapshots during ZK migration

cmccabe commented on PR #13461: URL: https://github.com/apache/kafka/pull/13461#issuecomment-1515504502 Thanks for this @mumrah . Can we have a ZkConfigMigrationClientTest and so on, for the other new migrationclient classes? Should we wrap the calls to

[GitHub] [kafka] vcrfxia commented on a diff in pull request #13552: KAFKA-14834: [6/N] Add tracking of versioned tables into graph nodes

vcrfxia commented on code in PR #13552: URL: https://github.com/apache/kafka/pull/13552#discussion_r1171939132 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/CogroupedStreamAggregateBuilder.java: ## @@ -73,6 +74,7 @@ KTable build(final Map, Aggregator

[GitHub] [kafka] cmccabe commented on a diff in pull request #13461: KAFKA-14840: Support for snapshots during ZK migration

cmccabe commented on code in PR #13461: URL: https://github.com/apache/kafka/pull/13461#discussion_r1171935467 ## metadata/src/test/java/org/apache/kafka/metadata/migration/CapturingTopicMigrationClient.java: ## @@ -0,0 +1,66 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] cmccabe commented on a diff in pull request #13461: KAFKA-14840: Support for snapshots during ZK migration

cmccabe commented on code in PR #13461: URL: https://github.com/apache/kafka/pull/13461#discussion_r1171935467 ## metadata/src/test/java/org/apache/kafka/metadata/migration/CapturingTopicMigrationClient.java: ## @@ -0,0 +1,66 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] cmccabe commented on a diff in pull request #13461: KAFKA-14840: Support for snapshots during ZK migration

cmccabe commented on code in PR #13461: URL: https://github.com/apache/kafka/pull/13461#discussion_r1171934758 ## core/src/main/scala/kafka/zk/ZkMigrationClient.scala: ## @@ -16,71 +16,79 @@ */ package kafka.zk -import kafka.api.LeaderAndIsr -import

[GitHub] [kafka] vcrfxia commented on a diff in pull request #13615: KAFKA-14834: [12/N] Minor code cleanups relating to versioned stores

vcrfxia commented on code in PR #13615: URL: https://github.com/apache/kafka/pull/13615#discussion_r1171934110 ## streams/src/main/java/org/apache/kafka/streams/state/KeyValueStore.java: ## @@ -36,6 +37,7 @@ * @param value The value to update, it can be {@code null};

[GitHub] [kafka] vcrfxia commented on a diff in pull request #13615: KAFKA-14834: [12/N] Minor code cleanups relating to versioned stores

vcrfxia commented on code in PR #13615: URL: https://github.com/apache/kafka/pull/13615#discussion_r1171934110 ## streams/src/main/java/org/apache/kafka/streams/state/KeyValueStore.java: ## @@ -36,6 +37,7 @@ * @param value The value to update, it can be {@code null};

[GitHub] [kafka] vcrfxia commented on a diff in pull request #13188: KAFKA-14491: [5/N] Basic operations for RocksDB versioned store

vcrfxia commented on code in PR #13188: URL: https://github.com/apache/kafka/pull/13188#discussion_r1171931840 ## streams/src/main/java/org/apache/kafka/streams/state/VersionedKeyValueStore.java: ## @@ -0,0 +1,99 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [kafka] vcrfxia commented on a diff in pull request #13564: KAFKA-14834: [8/N] Propagate `isLatest` as part of `Change`

vcrfxia commented on code in PR #13564: URL: https://github.com/apache/kafka/pull/13564#discussion_r1171930596 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/KTableKTableInnerJoin.java: ## @@ -139,7 +139,7 @@ public void process(final Record> record) {

[GitHub] [kafka] vcrfxia commented on a diff in pull request #13564: KAFKA-14834: [8/N] Propagate `isLatest` as part of `Change`

vcrfxia commented on code in PR #13564: URL: https://github.com/apache/kafka/pull/13564#discussion_r1171930805 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/KTableRepartitionMap.java: ## @@ -154,27 +154,25 @@ public void process(final Record> record) {

[GitHub] [kafka] vcrfxia commented on a diff in pull request #13564: KAFKA-14834: [8/N] Propagate `isLatest` as part of `Change`

vcrfxia commented on code in PR #13564: URL: https://github.com/apache/kafka/pull/13564#discussion_r1171929315 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/KTableKTableInnerJoin.java: ## @@ -139,7 +139,7 @@ public void process(final Record> record) {

[GitHub] [kafka] vcrfxia commented on a diff in pull request #13564: KAFKA-14834: [8/N] Propagate `isLatest` as part of `Change`

vcrfxia commented on code in PR #13564: URL: https://github.com/apache/kafka/pull/13564#discussion_r1171926280 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamAggregate.java: ## @@ -118,10 +120,13 @@ public void process(final Record record) {

[GitHub] [kafka] vcrfxia commented on a diff in pull request #13564: KAFKA-14834: [8/N] Propagate `isLatest` as part of `Change`

vcrfxia commented on code in PR #13564: URL: https://github.com/apache/kafka/pull/13564#discussion_r1171926005 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamAggregate.java: ## @@ -118,10 +120,13 @@ public void process(final Record record) {

[GitHub] [kafka] vcrfxia commented on a diff in pull request #13564: KAFKA-14834: [8/N] Propagate `isLatest` as part of `Change`

vcrfxia commented on code in PR #13564: URL: https://github.com/apache/kafka/pull/13564#discussion_r1171925337 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/KTableAggregate.java: ## @@ -116,10 +118,13 @@ public void process(final Record> record) {

[GitHub] [kafka] vcrfxia commented on a diff in pull request #13522: KAFKA-14834: [5/N] Drop out-of-order records from FK join with versioned tables

vcrfxia commented on code in PR #13522: URL: https://github.com/apache/kafka/pull/13522#discussion_r1171919730 ## streams/src/test/java/org/apache/kafka/streams/integration/KTableKTableForeignKeyVersionedJoinIntegrationTest.java: ## @@ -0,0 +1,301 @@ +/* + * Licensed to the

[GitHub] [kafka] vcrfxia commented on a diff in pull request #13522: KAFKA-14834: [5/N] Drop out-of-order records from FK join with versioned tables

vcrfxia commented on code in PR #13522: URL: https://github.com/apache/kafka/pull/13522#discussion_r1171919367 ## streams/src/test/java/org/apache/kafka/streams/integration/KTableKTableForeignKeyJoinIntegrationTest.java: ## @@ -249,62 +272,62 @@ public void

[GitHub] [kafka] vcrfxia commented on a diff in pull request #13522: KAFKA-14834: [5/N] Drop out-of-order records from FK join with versioned tables

vcrfxia commented on code in PR #13522: URL: https://github.com/apache/kafka/pull/13522#discussion_r1171919015 ## streams/src/test/java/org/apache/kafka/streams/integration/KTableKTableForeignKeyJoinIntegrationTest.java: ## @@ -140,9 +163,9 @@ public void

[GitHub] [kafka] vcrfxia commented on pull request #13509: KAFKA-14834: [3/N] Timestamped lookups for stream-table joins

vcrfxia commented on PR #13509: URL: https://github.com/apache/kafka/pull/13509#issuecomment-1515473590 Closing the loop here: versioned stores are disallowed for GlobalKTables in https://github.com/apache/kafka/pull/13565, so we should be all set. -- This is an automated message from

[GitHub] [kafka] vcrfxia opened a new pull request, #13615: KAFKA-14834: [12/N] Minor code cleanups relating to versioned stores

vcrfxia opened a new pull request, #13615: URL: https://github.com/apache/kafka/pull/13615 (This PR is stacked on https://github.com/apache/kafka/pull/13609. Only commits starting from `whitespace cleanup` need to be reviewed separately.) This PR contains various minor/non-functional

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #13443: KAFKA-14514: Add Server Side Sticky Range Assignor (KIP-848)

rreddy-22 commented on code in PR #13443: URL: https://github.com/apache/kafka/pull/13443#discussion_r1171913729 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/RangeAssignor.java: ## @@ -0,0 +1,240 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] jolshan commented on a diff in pull request #12149: KAFKA-13668: Retry upon missing initProducerId due to authorization error

jolshan commented on code in PR #12149: URL: https://github.com/apache/kafka/pull/12149#discussion_r1171913050 ## clients/src/test/java/org/apache/kafka/clients/producer/internals/SenderTest.java: ## @@ -2189,7 +2196,7 @@ public void testCancelInFlightRequestAfterFatalError()

[GitHub] [kafka] jolshan commented on a diff in pull request #12149: KAFKA-13668: Retry upon missing initProducerId due to authorization error

jolshan commented on code in PR #12149: URL: https://github.com/apache/kafka/pull/12149#discussion_r1171912717 ## clients/src/test/java/org/apache/kafka/clients/producer/internals/SenderTest.java: ## @@ -2175,7 +2182,7 @@ public void

[GitHub] [kafka] philipnee commented on a diff in pull request #12149: KAFKA-13668: Retry upon missing initProducerId due to authorization error

philipnee commented on code in PR #12149: URL: https://github.com/apache/kafka/pull/12149#discussion_r1171904037 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java: ## @@ -1294,7 +1309,10 @@ public void handleResponse(AbstractResponse

[jira] [Commented] (KAFKA-8154) Buffer Overflow exceptions between brokers and with clients

[ https://issues.apache.org/jira/browse/KAFKA-8154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17714323#comment-17714323 ] keith.paulson commented on KAFKA-8154: -- I'm getting this error now, kafka 3.4 with BouncyCastle

[GitHub] [kafka] philipnee commented on a diff in pull request #12149: KAFKA-13668: Retry upon missing initProducerId due to authorization error

philipnee commented on code in PR #12149: URL: https://github.com/apache/kafka/pull/12149#discussion_r1171873787 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java: ## @@ -1294,7 +1309,10 @@ public void handleResponse(AbstractResponse

[GitHub] [kafka] jolshan commented on a diff in pull request #12149: KAFKA-13668: Retry upon missing initProducerId due to authorization error

jolshan commented on code in PR #12149: URL: https://github.com/apache/kafka/pull/12149#discussion_r1171872077 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java: ## @@ -1294,7 +1309,10 @@ public void handleResponse(AbstractResponse

[GitHub] [kafka] jolshan commented on a diff in pull request #13608: KAFKA-14884: Include check transaction is still ongoing right before append

jolshan commented on code in PR #13608: URL: https://github.com/apache/kafka/pull/13608#discussion_r1171868072 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -1051,6 +1060,8 @@ class ReplicaManager(val config: KafkaConfig, } else { try {

[GitHub] [kafka] philipnee commented on a diff in pull request #12149: KAFKA-13668: Retry upon missing initProducerId due to authorization error

philipnee commented on code in PR #12149: URL: https://github.com/apache/kafka/pull/12149#discussion_r1171855134 ## clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java: ## @@ -618,7 +618,8 @@ private TransactionManager

[GitHub] [kafka] jolshan commented on a diff in pull request #12149: KAFKA-13668: Retry upon missing initProducerId due to authorization error

jolshan commented on code in PR #12149: URL: https://github.com/apache/kafka/pull/12149#discussion_r1171818667 ## clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java: ## @@ -618,7 +618,8 @@ private TransactionManager

[GitHub] [kafka] jolshan commented on a diff in pull request #12149: KAFKA-13668: Retry upon missing initProducerId due to authorization error

jolshan commented on code in PR #12149: URL: https://github.com/apache/kafka/pull/12149#discussion_r1171816496 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java: ## @@ -300,9 +301,13 @@ void runOnce() { try {

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #13443: KAFKA-14514: Add Server Side Sticky Range Assignor (KIP-848)

rreddy-22 commented on code in PR #13443: URL: https://github.com/apache/kafka/pull/13443#discussion_r1171783796 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/RangeAssignor.java: ## @@ -0,0 +1,240 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #13443: KAFKA-14514: Add Server Side Sticky Range Assignor (KIP-848)

rreddy-22 commented on code in PR #13443: URL: https://github.com/apache/kafka/pull/13443#discussion_r1171781883 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/RangeAssignor.java: ## @@ -0,0 +1,240 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] philipnee commented on a diff in pull request #13550: KAFKA-14639 - A single partition may be revoked and assign during a single round of rebalance

philipnee commented on code in PR #13550: URL: https://github.com/apache/kafka/pull/13550#discussion_r1171780417 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java: ## @@ -835,6 +839,8 @@ public void handle(SyncGroupResponse

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #13443: KAFKA-14514: Add Server Side Sticky Range Assignor (KIP-848)

rreddy-22 commented on code in PR #13443: URL: https://github.com/apache/kafka/pull/13443#discussion_r1171778657 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/RangeAssignor.java: ## @@ -0,0 +1,240 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #13443: KAFKA-14514: Add Server Side Sticky Range Assignor (KIP-848)

rreddy-22 commented on code in PR #13443: URL: https://github.com/apache/kafka/pull/13443#discussion_r1171777998 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/assignor/RangeAssignorTest.java: ## @@ -0,0 +1,416 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] dajac commented on a diff in pull request #13550: KAFKA-14639 - A single partition may be revoked and assign during a single round of rebalance

dajac commented on code in PR #13550: URL: https://github.com/apache/kafka/pull/13550#discussion_r1171774551 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java: ## @@ -835,6 +839,8 @@ public void handle(SyncGroupResponse syncResponse,

[GitHub] [kafka] vcrfxia commented on a diff in pull request #13592: KAFKA-14862: Outer stream-stream join does not output all results with multiple input partitions

vcrfxia commented on code in PR #13592: URL: https://github.com/apache/kafka/pull/13592#discussion_r1171766477 ## streams/src/test/java/org/apache/kafka/streams/integration/KStreamKStreamIntegrationTest.java: ## @@ -0,0 +1,186 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] philipnee commented on a diff in pull request #12149: KAFKA-13668: Retry upon missing initProducerId due to authorization error

philipnee commented on code in PR #12149: URL: https://github.com/apache/kafka/pull/12149#discussion_r1171764467 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java: ## @@ -300,9 +301,13 @@ void runOnce() { try {

[GitHub] [kafka] philipnee commented on a diff in pull request #12149: KAFKA-13668: Retry upon missing initProducerId due to authorization error

philipnee commented on code in PR #12149: URL: https://github.com/apache/kafka/pull/12149#discussion_r1171757259 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java: ## @@ -300,9 +301,13 @@ void runOnce() { try {

[GitHub] [kafka] jlprat merged pull request #11478: KAFKA-13299: Accept duplicate listener on port for IPv4/IPv6

jlprat merged PR #11478: URL: https://github.com/apache/kafka/pull/11478 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] jlprat commented on pull request #11478: KAFKA-13299: Accept duplicate listener on port for IPv4/IPv6

jlprat commented on PR #11478: URL: https://github.com/apache/kafka/pull/11478#issuecomment-1515213471 To the best of my knowledge, test failures seem to be all unrelated to the change in this PR. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [kafka] philipnee commented on a diff in pull request #13550: KAFKA-14639 - A single partition may be revoked and assign during a single round of rebalance

philipnee commented on code in PR #13550: URL: https://github.com/apache/kafka/pull/13550#discussion_r1171712519 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java: ## @@ -835,6 +839,8 @@ public void handle(SyncGroupResponse

[GitHub] [kafka] mumrah merged pull request #13606: KAFKA-14918 Only send controller RPCs to migrating ZK brokers

mumrah merged PR #13606: URL: https://github.com/apache/kafka/pull/13606 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] jolshan commented on pull request #13607: KAFKA-14916: Fix code that assumes transactional ID implies all records are transactional

jolshan commented on PR #13607: URL: https://github.com/apache/kafka/pull/13607#issuecomment-151533 I believe the connect mirror failures are known -- so no issues from the testing front. -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [kafka] jeffkbkim commented on a diff in pull request #13537: KAFKA-14462; [7/N] Add ClientAssignor, Assignment, TopicMetadata and VersionedMetadata

jeffkbkim commented on code in PR #13537: URL: https://github.com/apache/kafka/pull/13537#discussion_r1171626106 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/VersionedMetadata.java: ## @@ -0,0 +1,85 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] jolshan commented on a diff in pull request #13537: KAFKA-14462; [7/N] Add ClientAssignor, Assignment, TopicMetadata and VersionedMetadata

jolshan commented on code in PR #13537: URL: https://github.com/apache/kafka/pull/13537#discussion_r1171634759 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/consumer/AssignmentTest.java: ## @@ -0,0 +1,137 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] mimaison commented on pull request #13614: KAFKA-14586: Adding redirection for StreamsResetter

mimaison commented on PR #13614: URL: https://github.com/apache/kafka/pull/13614#issuecomment-1515084652 Not merging immediately to let @mjsax a chance to review. Feel free to merge to trunk and 3.5, otherwise I'll do it when I come online tomorrow. -- This is an automated message

[jira] [Resolved] (KAFKA-4327) Move Reset Tool from core to streams

[ https://issues.apache.org/jira/browse/KAFKA-4327?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax resolved KAFKA-4327. Fix Version/s: (was: 4.0.0) Resolution: Fixed This was resolved via

[GitHub] [kafka] jolshan commented on a diff in pull request #13537: KAFKA-14462; [7/N] Add ClientAssignor, Assignment, TopicMetadata and VersionedMetadata

jolshan commented on code in PR #13537: URL: https://github.com/apache/kafka/pull/13537#discussion_r1171629591 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/Assignment.java: ## @@ -0,0 +1,144 @@ +/* + * Licensed to the Apache Software Foundation

[jira] [Assigned] (KAFKA-4327) Move Reset Tool from core to streams

[ https://issues.apache.org/jira/browse/KAFKA-4327?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax reassigned KAFKA-4327: -- Assignee: (was: Jorge Esteban Quilcate Otoya) > Move Reset Tool from core to

[GitHub] [kafka] jolshan commented on a diff in pull request #13537: KAFKA-14462; [7/N] Add ClientAssignor, Assignment, TopicMetadata and VersionedMetadata

jolshan commented on code in PR #13537: URL: https://github.com/apache/kafka/pull/13537#discussion_r1171628212 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ClientAssignor.java: ## @@ -0,0 +1,150 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] jolshan commented on a diff in pull request #13537: KAFKA-14462; [7/N] Add ClientAssignor, Assignment, TopicMetadata and VersionedMetadata

jolshan commented on code in PR #13537: URL: https://github.com/apache/kafka/pull/13537#discussion_r1171626917 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/TopicMetadata.java: ## @@ -0,0 +1,109 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] jolshan commented on a diff in pull request #13537: KAFKA-14462; [7/N] Add ClientAssignor, Assignment, TopicMetadata and VersionedMetadata

jolshan commented on code in PR #13537: URL: https://github.com/apache/kafka/pull/13537#discussion_r1171626201 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/TopicMetadata.java: ## @@ -0,0 +1,109 @@ +/* + * Licensed to the Apache Software

[jira] [Updated] (KAFKA-14868) Remove some forgotten metrics when the replicaManager is closed

[ https://issues.apache.org/jira/browse/KAFKA-14868?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mickael Maison updated KAFKA-14868: --- Fix Version/s: 3.6.0 (was: 3.5.0) > Remove some forgotten metrics

[GitHub] [kafka] mimaison merged pull request #13471: KAFKA-14868:Remove some forgotten metrics when the replicaManager is closed

mimaison merged PR #13471: URL: https://github.com/apache/kafka/pull/13471 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] divijvaidya commented on pull request #13312: KAFKA-14766: Improve performance of VarInt encoding and decoding

divijvaidya commented on PR #13312: URL: https://github.com/apache/kafka/pull/13312#issuecomment-1515034487 @ijuma I tried end to end benchmarks w/ and w/o this change but I didn't observe any noticeable change in end to end latency or throughput (because the bottle neck in end to end

[jira] [Assigned] (KAFKA-14669) Include MirrorMaker connector configurations in docs

[ https://issues.apache.org/jira/browse/KAFKA-14669?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gantigmaa Selenge reassigned KAFKA-14669: - Assignee: Gantigmaa Selenge > Include MirrorMaker connector configurations in

[GitHub] [kafka] dajac commented on pull request #13537: KAFKA-14462; [7/N] Add ClientAssignor, Assignment, TopicMetadata and VersionedMetadata

dajac commented on PR #13537: URL: https://github.com/apache/kafka/pull/13537#issuecomment-1515007003 @dengziming @showuon I have a few PRs in-flight for KIP-848 if you are interested to help with reviews on that front. -- This is an automated message from the Apache Git Service. To

[GitHub] [kafka] gharris1727 commented on a diff in pull request #13429: KAFKA-14666: Add MM2 in-memory offset translation index for offsets behind replication

gharris1727 commented on code in PR #13429: URL: https://github.com/apache/kafka/pull/13429#discussion_r1171513542 ## connect/mirror/src/main/java/org/apache/kafka/connect/mirror/OffsetSyncStore.java: ## @@ -139,10 +171,103 @@ public void close() { protected void

[GitHub] [kafka] dimitarndimitrov commented on pull request #13432: KAFKA-14821 Implement the listOffsets API with AdminApiDriver

dimitarndimitrov commented on PR #13432: URL: https://github.com/apache/kafka/pull/13432#issuecomment-1514934648 > please also change the description to include the modifications you made @dengziming I have updated the PR description a bit and added a "review modifications" section.

[GitHub] [kafka] dimitarndimitrov commented on a diff in pull request #13432: KAFKA-14821 Implement the listOffsets API with AdminApiDriver

dimitarndimitrov commented on code in PR #13432: URL: https://github.com/apache/kafka/pull/13432#discussion_r1171490648 ## clients/src/main/java/org/apache/kafka/clients/admin/internals/ListOffsetsHandler.java: ## @@ -0,0 +1,212 @@ +/* + * Licensed to the Apache Software

[jira] [Commented] (KAFKA-14586) Move StreamsResetter to tools

[ https://issues.apache.org/jira/browse/KAFKA-14586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17714140#comment-17714140 ] Sagar Rao commented on KAFKA-14586: --- Thanks [~fvaleri] , I created the PR.  > Move StreamsResetter to

[GitHub] [kafka] vamossagar12 opened a new pull request, #13614: KAFKA-14586: Adding redirection for StreamsResetter

vamossagar12 opened a new pull request, #13614: URL: https://github.com/apache/kafka/pull/13614 Adding Redirection for StreamsResetter. The erstwhile StreamsResetter resided in core/src/main/scala/kafka/tools package and that's where I added this class. I tried to run the main method

[jira] [Updated] (KAFKA-14922) kafka-streams-application-reset deletes topics not belonging to specified application-id

[ https://issues.apache.org/jira/browse/KAFKA-14922?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jørgen updated KAFKA-14922: --- Description: Slack-thread: [https://confluentcommunity.slack.com/archives/C48AHTCUQ/p1681908267206849]

[jira] [Updated] (KAFKA-14922) kafka-streams-application-reset deletes topics not belonging to specified application-id

[ https://issues.apache.org/jira/browse/KAFKA-14922?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jørgen updated KAFKA-14922: --- Description: Slack-thread: [https://confluentcommunity.slack.com/archives/C48AHTCUQ/p1681908267206849]

[jira] [Created] (KAFKA-14922) kafka-streams-application-reset deletes topics not belonging to specified application-id

Jørgen created KAFKA-14922: -- Summary: kafka-streams-application-reset deletes topics not belonging to specified application-id Key: KAFKA-14922 URL: https://issues.apache.org/jira/browse/KAFKA-14922

[jira] [Commented] (KAFKA-14084) Support SCRAM when using KRaft mode

[ https://issues.apache.org/jira/browse/KAFKA-14084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17714103#comment-17714103 ] Proven Provenzano commented on KAFKA-14084: --- PR added for migrating SCRAM records during ZK to

[GitHub] [kafka] pprovenzano opened a new pull request, #13613: KAFKA-14859: SCRAM ZK to KRaft migration without dual write

pprovenzano opened a new pull request, #13613: URL: https://github.com/apache/kafka/pull/13613 Handle migrating SCRAM records in ZK when migrating from ZK to KRaft. This does not allow the user to change SCRAM records while migration is happening. ### Committer Checklist

[jira] [Commented] (KAFKA-14807) MirrorMaker2 config source.consumer.auto.offset.reset=latest leading to the pause of replication of consumer groups

[ https://issues.apache.org/jira/browse/KAFKA-14807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17714097#comment-17714097 ] Daniel Urban commented on KAFKA-14807: -- [~fisher91] do you use MM2 dedicated mode, or use the

[GitHub] [kafka] urbandan commented on a diff in pull request #13429: KAFKA-14666: Add MM2 in-memory offset translation index for offsets behind replication

urbandan commented on code in PR #13429: URL: https://github.com/apache/kafka/pull/13429#discussion_r1171304080 ## connect/mirror/src/main/java/org/apache/kafka/connect/mirror/OffsetSyncStore.java: ## @@ -139,10 +171,103 @@ public void close() { protected void

[GitHub] [kafka] satishd commented on a diff in pull request #13535: KAFKA-9579 Fetch implementation for records in the remote storage through a specific purgatory.

satishd commented on code in PR #13535: URL: https://github.com/apache/kafka/pull/13535#discussion_r1171245421 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -600,6 +622,176 @@ public String toString() { } } +public FetchDataInfo

[GitHub] [kafka] satishd commented on a diff in pull request #13535: KAFKA-9579 Fetch implementation for records in the remote storage through a specific purgatory.

satishd commented on code in PR #13535: URL: https://github.com/apache/kafka/pull/13535#discussion_r1171250580 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -1118,9 +1122,13 @@ class ReplicaManager(val config: KafkaConfig, responseCallback:

  1   2   >