[GitHub] [kafka] vamossagar12 commented on pull request #13594: KAFKA-14913: Using ThreadUtils.shutdownExecutorServiceQuietly to close executors in Connect Runtime

2023-04-24 Thread via GitHub
vamossagar12 commented on PR #13594: URL: https://github.com/apache/kafka/pull/13594#issuecomment-1521193360 @yashmayya , hmm MemoryOffsetBackingStore is used in Connect Standalone IIUC. I am not totally aware of the historical context here of whether throwing a ConnectException is valid

[GitHub] [kafka] showuon commented on a diff in pull request #13631: KAFKA-14909: check zkMigrationReady tag before migration

2023-04-24 Thread via GitHub
showuon commented on code in PR #13631: URL: https://github.com/apache/kafka/pull/13631#discussion_r1176030390 ## clients/src/main/java/org/apache/kafka/clients/ApiVersions.java: ## @@ -64,4 +64,8 @@ public synchronized byte maxUsableProduceMagic() { return

[GitHub] [kafka] showuon commented on a diff in pull request #13631: KAFKA-14909: check zkMigrationReady tag before migration

2023-04-24 Thread via GitHub
showuon commented on code in PR #13631: URL: https://github.com/apache/kafka/pull/13631#discussion_r1176030100 ## metadata/src/main/java/org/apache/kafka/metadata/migration/KRaftMigrationDriver.java: ## @@ -134,8 +139,7 @@ private void initializeMigrationState() { }

[GitHub] [kafka] showuon commented on a diff in pull request #13631: KAFKA-14909: check zkMigrationReady tag before migration

2023-04-24 Thread via GitHub
showuon commented on code in PR #13631: URL: https://github.com/apache/kafka/pull/13631#discussion_r1176029069 ## core/src/main/scala/kafka/server/ControllerServer.scala: ## @@ -270,7 +271,8 @@ class ControllerServer( "zk migration", fatal = false,

[GitHub] [kafka] vamossagar12 commented on a diff in pull request #13594: KAFKA-14913: Using ThreadUtils.shutdownExecutorServiceQuietly to close executors in Connect Runtime

2023-04-24 Thread via GitHub
vamossagar12 commented on code in PR #13594: URL: https://github.com/apache/kafka/pull/13594#discussion_r1176029043 ## connect/runtime/src/test/java/org/apache/kafka/connect/storage/KafkaStatusBackingStoreFormatTest.java: ## @@ -216,7 +216,7 @@ public void

[GitHub] [kafka] vamossagar12 opened a new pull request, #13634: KAFKA-14929: Fixing flaky test putTopicStateRetriableFailure

2023-04-24 Thread via GitHub
vamossagar12 opened a new pull request, #13634: URL: https://github.com/apache/kafka/pull/13634 Fixing flaky test putTopicStateRetriableFailure by adding a timeout to have the background thread kicked in which invokes KafkaBasedLog#send. -- This is an automated message from the Apache

[GitHub] [kafka] showuon commented on a diff in pull request #13631: KAFKA-14909: check zkMigrationReady tag before migration

2023-04-24 Thread via GitHub
showuon commented on code in PR #13631: URL: https://github.com/apache/kafka/pull/13631#discussion_r1176027142 ## metadata/src/test/java/org/apache/kafka/metadata/migration/KRaftMigrationDriverTest.java: ## @@ -277,64 +312,65 @@ CompletableFuture

[GitHub] [kafka] showuon commented on a diff in pull request #13631: KAFKA-14909: check zkMigrationReady tag before migration

2023-04-24 Thread via GitHub
showuon commented on code in PR #13631: URL: https://github.com/apache/kafka/pull/13631#discussion_r1176025802 ## metadata/src/test/java/org/apache/kafka/metadata/migration/KRaftMigrationDriverTest.java: ## @@ -383,8 +466,8 @@ public ZkMigrationLeadershipState

[GitHub] [kafka] hgeraldino commented on pull request #13383: KAFKA-14059 Replace PowerMock with Mockito in WorkerSourceTaskTest

2023-04-24 Thread via GitHub
hgeraldino commented on PR #13383: URL: https://github.com/apache/kafka/pull/13383#issuecomment-1521090615 Thanks for your feedback @C0urante. I finally had time this past week and tweaked the test to address your comments and fix coverage. -- This is an automated message from

[GitHub] [kafka] hgeraldino commented on a diff in pull request #13383: KAFKA-14059 Replace PowerMock with Mockito in WorkerSourceTaskTest

2023-04-24 Thread via GitHub
hgeraldino commented on code in PR #13383: URL: https://github.com/apache/kafka/pull/13383#discussion_r1175960799 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/WorkerSourceTaskTest.java: ## @@ -474,129 +442,107 @@ public void testFailureInPollAfterStop()

[GitHub] [kafka] hgeraldino commented on a diff in pull request #13383: KAFKA-14059 Replace PowerMock with Mockito in WorkerSourceTaskTest

2023-04-24 Thread via GitHub
hgeraldino commented on code in PR #13383: URL: https://github.com/apache/kafka/pull/13383#discussion_r1175960401 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/WorkerSourceTaskTest.java: ## @@ -1003,31 +868,35 @@ private boolean awaitLatch(CountDownLatch

[GitHub] [kafka] atu-sharm opened a new pull request, #13633: KAFKA-14839: Exclude protected variable from JavaDocs

2023-04-24 Thread via GitHub
atu-sharm opened a new pull request, #13633: URL: https://github.com/apache/kafka/pull/13633 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of

[GitHub] [kafka] maulin-vasavada commented on pull request #13626: MINOR: only set sslEngine#setUseClientMode to false once when ssl mode is server

2023-04-24 Thread via GitHub
maulin-vasavada commented on PR #13626: URL: https://github.com/apache/kafka/pull/13626#issuecomment-1520995629 @machi1990 looks good to me. However you will need a committer to review and merge this. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [kafka] mjsax commented on pull request #13533: KAFKA-12446: update change encoding to use varint

2023-04-24 Thread via GitHub
mjsax commented on PR #13533: URL: https://github.com/apache/kafka/pull/13533#issuecomment-1520912631 Merged to `trunk` and cherry-picked to `3.5` branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [kafka] mjsax merged pull request #13533: KAFKA-12446: update change encoding to use varint

2023-04-24 Thread via GitHub
mjsax merged PR #13533: URL: https://github.com/apache/kafka/pull/13533 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] jsancio closed pull request #13030: MINOR; Add log message when Log high watermark differs

2023-04-24 Thread via GitHub
jsancio closed pull request #13030: MINOR; Add log message when Log high watermark differs URL: https://github.com/apache/kafka/pull/13030 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] jsancio commented on pull request #13030: MINOR; Add log message when Log high watermark differs

2023-04-24 Thread via GitHub
jsancio commented on PR #13030: URL: https://github.com/apache/kafka/pull/13030#issuecomment-1520845699 Changes included in https://github.com/apache/kafka/pull/13553 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [kafka] jeffkbkim commented on a diff in pull request #13538: KAFKA-14462; [8/N] Add ConsumerGroupMember

2023-04-24 Thread via GitHub
jeffkbkim commented on code in PR #13538: URL: https://github.com/apache/kafka/pull/13538#discussion_r1175790304 ## checkstyle/suppressions.xml: ## @@ -318,6 +318,14 @@ + + +

[jira] [Updated] (KAFKA-14932) Heuristic for increasing the log start offset after replicas are caught up

2023-04-24 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-14932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] José Armando García Sancio updated KAFKA-14932: --- Description: The implementation in

[jira] [Created] (KAFKA-14932) Heuristic for increasing the log start offset after replicas are caught up

2023-04-24 Thread Jira
José Armando García Sancio created KAFKA-14932: -- Summary: Heuristic for increasing the log start offset after replicas are caught up Key: KAFKA-14932 URL:

[GitHub] [kafka] mjsax commented on pull request #13615: KAFKA-14834: [12/N] Minor code cleanups relating to versioned stores

2023-04-24 Thread via GitHub
mjsax commented on PR #13615: URL: https://github.com/apache/kafka/pull/13615#issuecomment-1520833481 Merged to `trunk` and cherry-picked to `3.5`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka] mjsax merged pull request #13615: KAFKA-14834: [12/N] Minor code cleanups relating to versioned stores

2023-04-24 Thread via GitHub
mjsax merged PR #13615: URL: https://github.com/apache/kafka/pull/13615 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] mjsax commented on pull request #13592: KAFKA-14862: Outer stream-stream join does not output all results with multiple input partitions

2023-04-24 Thread via GitHub
mjsax commented on PR #13592: URL: https://github.com/apache/kafka/pull/13592#issuecomment-1520757094 Merged to `trunk` and cherry-picked to `3.5` and `3.4` branches. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [kafka] cadonna commented on a diff in pull request #13621: KAFKA-14133: Migrate ChangeLogReader mock in TaskManagerTest to Mockito

2023-04-24 Thread via GitHub
cadonna commented on code in PR #13621: URL: https://github.com/apache/kafka/pull/13621#discussion_r1175663484 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/TaskManagerTest.java: ## @@ -2602,23 +2608,21 @@ public void

[GitHub] [kafka] jeffkbkim commented on pull request #13600: KAFKA-14869: Bump coordinator value records to flexible versions (KIP…

2023-04-24 Thread via GitHub
jeffkbkim commented on PR #13600: URL: https://github.com/apache/kafka/pull/13600#issuecomment-1520740394 i see a different error now ``` [2023-04-24T17:51:21.714Z] FAILURE: Build failed with an exception. [2023-04-24T17:51:21.714Z] [2023-04-24T17:51:21.714Z] * What

[GitHub] [kafka] jeffkbkim commented on pull request #13602: KAFKA-14869: Bump coordinator value records to flexible versions (KIP…

2023-04-24 Thread via GitHub
jeffkbkim commented on PR #13602: URL: https://github.com/apache/kafka/pull/13602#issuecomment-1520737975 the build looks to be successful -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] cmccabe commented on a diff in pull request #13407: KAFKA-14805 KRaft controller supports pre-migration mode

2023-04-24 Thread via GitHub
cmccabe commented on code in PR #13407: URL: https://github.com/apache/kafka/pull/13407#discussion_r1175718263 ## metadata/src/main/java/org/apache/kafka/controller/metrics/ControllerMetadataMetricsPublisher.java: ## @@ -115,6 +115,9 @@ private void publishDelta(MetadataDelta

[GitHub] [kafka] cmccabe commented on a diff in pull request #13407: KAFKA-14805 KRaft controller supports pre-migration mode

2023-04-24 Thread via GitHub
cmccabe commented on code in PR #13407: URL: https://github.com/apache/kafka/pull/13407#discussion_r1175717268 ## metadata/src/main/java/org/apache/kafka/controller/QuorumController.java: ## @@ -1123,29 +1165,104 @@ private void claim(int epoch) { // Prepend the

[GitHub] [kafka] mjsax commented on a diff in pull request #13533: KAFKA-12446: update change encoding to use varint

2023-04-24 Thread via GitHub
mjsax commented on code in PR #13533: URL: https://github.com/apache/kafka/pull/13533#discussion_r1175716345 ## streams/src/test/java/org/apache/kafka/streams/integration/NamedTopologyIntegrationTest.java: ## @@ -543,6 +543,16 @@ public void

[jira] [Updated] (KAFKA-14862) Outer stream-stream join does not output all results with multiple input partitions

2023-04-24 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14862?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-14862: Affects Version/s: 3.1.0 > Outer stream-stream join does not output all results with

[GitHub] [kafka] cmccabe commented on a diff in pull request #13407: KAFKA-14805 KRaft controller supports pre-migration mode

2023-04-24 Thread via GitHub
cmccabe commented on code in PR #13407: URL: https://github.com/apache/kafka/pull/13407#discussion_r1175710520 ## metadata/src/main/java/org/apache/kafka/controller/QuorumController.java: ## @@ -869,19 +906,30 @@ public CompletableFuture acceptBatch(List recordBatch)

[GitHub] [kafka] cmccabe commented on a diff in pull request #13407: KAFKA-14805 KRaft controller supports pre-migration mode

2023-04-24 Thread via GitHub
cmccabe commented on code in PR #13407: URL: https://github.com/apache/kafka/pull/13407#discussion_r1175709187 ## core/src/test/scala/unit/kafka/server/BrokerRegistrationRequestTest.scala: ## @@ -145,25 +146,29 @@ class BrokerRegistrationRequestTest { }

[GitHub] [kafka] mjsax merged pull request #13592: KAFKA-14862: Outer stream-stream join does not output all results with multiple input partitions

2023-04-24 Thread via GitHub
mjsax merged PR #13592: URL: https://github.com/apache/kafka/pull/13592 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] cmccabe commented on a diff in pull request #13407: KAFKA-14805 KRaft controller supports pre-migration mode

2023-04-24 Thread via GitHub
cmccabe commented on code in PR #13407: URL: https://github.com/apache/kafka/pull/13407#discussion_r1175709187 ## core/src/test/scala/unit/kafka/server/BrokerRegistrationRequestTest.scala: ## @@ -145,25 +146,29 @@ class BrokerRegistrationRequestTest { }

[GitHub] [kafka] cmccabe commented on a diff in pull request #13407: KAFKA-14805 KRaft controller supports pre-migration mode

2023-04-24 Thread via GitHub
cmccabe commented on code in PR #13407: URL: https://github.com/apache/kafka/pull/13407#discussion_r1175709047 ## core/src/test/scala/integration/kafka/zk/ZkMigrationIntegrationTest.scala: ## @@ -324,4 +329,29 @@ class ZkMigrationIntegrationTest {

[GitHub] [kafka] mjsax commented on a diff in pull request #13622: KAFKA-14834: [13/N] Docs updates for versioned store semantics

2023-04-24 Thread via GitHub
mjsax commented on code in PR #13622: URL: https://github.com/apache/kafka/pull/13622#discussion_r1175694673 ## docs/streams/core-concepts.html: ## @@ -328,13 +328,17 @@ < for stateful operations such as aggregations and joins, however, out-of-order data could cause

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #13443: KAFKA-14514: Add Sticky Range Assignor on the Server (KIP-848)

2023-04-24 Thread via GitHub
rreddy-22 commented on code in PR #13443: URL: https://github.com/apache/kafka/pull/13443#discussion_r1175703194 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/RangeAssignor.java: ## @@ -0,0 +1,261 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #13443: KAFKA-14514: Add Sticky Range Assignor on the Server (KIP-848)

2023-04-24 Thread via GitHub
rreddy-22 commented on code in PR #13443: URL: https://github.com/apache/kafka/pull/13443#discussion_r1175701652 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/RangeAssignor.java: ## @@ -0,0 +1,261 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] mumrah commented on a diff in pull request #13407: KAFKA-14805 KRaft controller supports pre-migration mode

2023-04-24 Thread via GitHub
mumrah commented on code in PR #13407: URL: https://github.com/apache/kafka/pull/13407#discussion_r1175698954 ## core/src/test/scala/unit/kafka/server/BrokerRegistrationRequestTest.scala: ## @@ -145,25 +146,29 @@ class BrokerRegistrationRequestTest { }

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #13443: KAFKA-14514: Add Sticky Range Assignor on the Server (KIP-848)

2023-04-24 Thread via GitHub
rreddy-22 commented on code in PR #13443: URL: https://github.com/apache/kafka/pull/13443#discussion_r1175689958 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/RangeAssignor.java: ## @@ -0,0 +1,261 @@ +/* + * Licensed to the Apache Software

[jira] [Commented] (KAFKA-14927) Dynamic configs not validated when using kafka-configs and --add-config-file

2023-04-24 Thread Colin McCabe (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17715940#comment-17715940 ] Colin McCabe commented on KAFKA-14927: -- I haven't verified this but I would expect the same

[jira] [Assigned] (KAFKA-14049) Relax Non Null Requirement for KStreamGlobalKTable Left Join

2023-04-24 Thread Philip Nee (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14049?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Philip Nee reassigned KAFKA-14049: -- Assignee: Philip Nee > Relax Non Null Requirement for KStreamGlobalKTable Left Join >

[GitHub] [kafka] jeffkbkim commented on pull request #13603: KAFKA-14869: Bump coordinator value records to flexible versions (KIP…

2023-04-24 Thread via GitHub
jeffkbkim commented on PR #13603: URL: https://github.com/apache/kafka/pull/13603#issuecomment-1520578217 test are unrelated ``` Build / JDK 8 and Scala 2.12 / testDescribeQuorumRequestToBrokers() – kafka.server.KRaftClusterTest 31s Build / JDK 8 and Scala 2.12 /

[GitHub] [kafka] jeffkbkim commented on pull request #13601: KAFKA-14869: Bump coordinator value records to flexible versions (KIP…

2023-04-24 Thread via GitHub
jeffkbkim commented on PR #13601: URL: https://github.com/apache/kafka/pull/13601#issuecomment-1520572197 this one as well ``` [2023-04-24T15:00:18.297Z] FAILURE: Build failed with an exception. [2023-04-24T15:00:18.297Z] [2023-04-24T15:00:18.297Z] * What went wrong:

[GitHub] [kafka] jeffkbkim commented on pull request #13600: KAFKA-14869: Bump coordinator value records to flexible versions (KIP…

2023-04-24 Thread via GitHub
jeffkbkim commented on PR #13600: URL: https://github.com/apache/kafka/pull/13600#issuecomment-1520571706 @dajac i'm seeing ``` [2023-04-24T15:00:10.166Z] FAILURE: Build failed with an exception. [2023-04-24T15:00:10.166Z] [2023-04-24T15:00:10.166Z] * What went

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #13443: KAFKA-14514: Add Sticky Range Assignor on the Server (KIP-848)

2023-04-24 Thread via GitHub
rreddy-22 commented on code in PR #13443: URL: https://github.com/apache/kafka/pull/13443#discussion_r1175567311 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/RangeAssignor.java: ## @@ -0,0 +1,261 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] jolshan opened a new pull request, #13632: KAFKA-14931: Revert KAFKA-14561 in 3.5

2023-04-24 Thread via GitHub
jolshan opened a new pull request, #13632: URL: https://github.com/apache/kafka/pull/13632 There were too many blocker bugs so it is easier to revert for this release. Revert was clean. ### Committer Checklist (excluded from commit message) - [ ] Verify design and

[jira] [Updated] (KAFKA-14931) Revert KAFKA-14561 in 3.5

2023-04-24 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14931?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mickael Maison updated KAFKA-14931: --- Description: We have too many blockers for this commit to work well, so in the interest of

[jira] [Updated] (KAFKA-14931) Revert KAFKA-14561 in 3.5

2023-04-24 Thread Justine Olshan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14931?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justine Olshan updated KAFKA-14931: --- Affects Version/s: 3.5.0 > Revert KAFKA-14561 in 3.5 > - > >

[jira] [Updated] (KAFKA-14884) Include check transaction is still ongoing right before append

2023-04-24 Thread Justine Olshan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14884?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justine Olshan updated KAFKA-14884: --- Affects Version/s: 3.6.0 (was: 3.5.0) > Include check

[jira] [Updated] (KAFKA-14920) Address timeouts and out of order sequences

2023-04-24 Thread Justine Olshan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justine Olshan updated KAFKA-14920: --- Affects Version/s: 3.6.0 > Address timeouts and out of order sequences >

[jira] [Updated] (KAFKA-14916) Fix code that assumes transactional ID implies all records are transactional

2023-04-24 Thread Justine Olshan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14916?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justine Olshan updated KAFKA-14916: --- Affects Version/s: 3.6.0 > Fix code that assumes transactional ID implies all records are

[jira] [Created] (KAFKA-14931) Revert KAFKA-14561 in 3.5

2023-04-24 Thread Justine Olshan (Jira)
Justine Olshan created KAFKA-14931: -- Summary: Revert KAFKA-14561 in 3.5 Key: KAFKA-14931 URL: https://issues.apache.org/jira/browse/KAFKA-14931 Project: Kafka Issue Type: Task

[GitHub] [kafka] mumrah commented on pull request #13257: MINOR: Add ZK migration docs to the packaged docs

2023-04-24 Thread via GitHub
mumrah commented on PR #13257: URL: https://github.com/apache/kafka/pull/13257#issuecomment-1520515387 @mimaison i'm fairly occupied with #13407 and #13461 at the moment, but could probably find time for this PR in between things this week or next. Come to think of it, I'll need to

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #13443: KAFKA-14514: Add Sticky Range Assignor on the Server (KIP-848)

2023-04-24 Thread via GitHub
rreddy-22 commented on code in PR #13443: URL: https://github.com/apache/kafka/pull/13443#discussion_r1175552910 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/RangeAssignor.java: ## @@ -0,0 +1,261 @@ +/* + * Licensed to the Apache Software

Kafka Node Shutting Down Automatically

2023-04-24 Thread Akshay Kumar
Hello team, - We are using the zookeeper less Kafka (kafka Kraft). - The cluster is having 3 nodes. - One of the nodes gets automatically shut down randomly. - Checked the logs but didn't get the exact reason. - Kafka version - 3.3.1 - Attaching the log files. - Time -

[GitHub] [kafka] urbandan commented on a diff in pull request #13429: KAFKA-14666: Add MM2 in-memory offset translation index for offsets behind replication

2023-04-24 Thread via GitHub
urbandan commented on code in PR #13429: URL: https://github.com/apache/kafka/pull/13429#discussion_r1175425019 ## connect/mirror/src/main/java/org/apache/kafka/connect/mirror/OffsetSyncStore.java: ## @@ -139,10 +171,103 @@ public void close() { protected void

[GitHub] [kafka] mumrah commented on a diff in pull request #13631: KAFKA-14909: check zkMigrationReady tag before migration

2023-04-24 Thread via GitHub
mumrah commented on code in PR #13631: URL: https://github.com/apache/kafka/pull/13631#discussion_r1175362654 ## metadata/src/main/java/org/apache/kafka/metadata/migration/KRaftMigrationDriver.java: ## @@ -134,8 +139,7 @@ private void initializeMigrationState() { }

[jira] [Commented] (KAFKA-14918) KRaft controller sending ZK controller RPCs to KRaft brokers

2023-04-24 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17715852#comment-17715852 ] Mickael Maison commented on KAFKA-14918: [~mumrah] The associated PR is merged, can we resolve

[GitHub] [kafka] mimaison commented on pull request #13257: MINOR: Add ZK migration docs to the packaged docs

2023-04-24 Thread via GitHub
mimaison commented on PR #13257: URL: https://github.com/apache/kafka/pull/13257#issuecomment-1520246270 @mumrah Let me know if you don't have time to finish this PR. We should merge this to trunk and backport to 3.5. -- This is an automated message from the Apache Git Service. To

[GitHub] [kafka] mimaison commented on a diff in pull request #13257: MINOR: Add ZK migration docs to the packaged docs

2023-04-24 Thread via GitHub
mimaison commented on code in PR #13257: URL: https://github.com/apache/kafka/pull/13257#discussion_r1175352627 ## docs/ops.html: ## @@ -3550,22 +3550,220 @@ Deploying Considerations -Kafka server's process.role should be set to either broker or controller but not

[GitHub] [kafka] dajac commented on a diff in pull request #13443: KAFKA-14514: Add Sticky Range Assignor on the Server (KIP-848)

2023-04-24 Thread via GitHub
dajac commented on code in PR #13443: URL: https://github.com/apache/kafka/pull/13443#discussion_r1175273145 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/RangeAssignor.java: ## @@ -0,0 +1,261 @@ +/* + * Licensed to the Apache Software

[jira] [Resolved] (KAFKA-14925) The website shouldn't load external resources

2023-04-24 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14925?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mickael Maison resolved KAFKA-14925. Resolution: Fixed > The website shouldn't load external resources >

[jira] [Commented] (KAFKA-14925) The website shouldn't load external resources

2023-04-24 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17715804#comment-17715804 ] ASF GitHub Bot commented on KAFKA-14925: mimaison merged PR #506: URL:

[jira] [Updated] (KAFKA-14630) Update zstd-jni version to 1.5.5

2023-04-24 Thread Divij Vaidya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14630?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Divij Vaidya updated KAFKA-14630: - Fix Version/s: 3.5.0 > Update zstd-jni version to 1.5.5 > > >

[jira] [Resolved] (KAFKA-14630) Update zstd-jni version to 1.5.2-5

2023-04-24 Thread Divij Vaidya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14630?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Divij Vaidya resolved KAFKA-14630. -- Assignee: Ismael Juma (was: Divij Vaidya) Resolution: Fixed > Update zstd-jni version

[jira] [Updated] (KAFKA-14630) Update zstd-jni version to 1.5.5

2023-04-24 Thread Divij Vaidya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14630?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Divij Vaidya updated KAFKA-14630: - Summary: Update zstd-jni version to 1.5.5 (was: Update zstd-jni version to 1.5.2-5) > Update

[GitHub] [kafka] yashmayya commented on pull request #13594: KAFKA-14913: Using ThreadUtils.shutdownExecutorServiceQuietly to close executors in Connect Runtime

2023-04-24 Thread via GitHub
yashmayya commented on PR #13594: URL: https://github.com/apache/kafka/pull/13594#issuecomment-1520127170 @vamossagar12 the behavior in `MemoryOffsetBackingStore` should probably be changed - if it fails to shutdown cleanly and throws an exception, it'll cause further resource closures to

[jira] [Commented] (KAFKA-14630) Update zstd-jni version to 1.5.2-5

2023-04-24 Thread Divij Vaidya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17715783#comment-17715783 ] Divij Vaidya commented on KAFKA-14630: -- This was merged in

[GitHub] [kafka] hudeqi commented on pull request #13617: MINOR:code optimization in QuorumController

2023-04-24 Thread via GitHub
hudeqi commented on PR #13617: URL: https://github.com/apache/kafka/pull/13617#issuecomment-1520104888 Hello, Guozhang, please review if you have time. @guozhangwang -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [kafka] hudeqi commented on pull request #13473: KAFKA-14866:Remove controller module metrics when broker is shutting down

2023-04-24 Thread via GitHub
hudeqi commented on PR #13473: URL: https://github.com/apache/kafka/pull/13473#issuecomment-1520101597 > Hello, can you help to review this PR? @mimaison and pin here @mimaison -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] hudeqi commented on pull request #13571: KAFKA-14907:Add the traffic metric of the partition dimension in BrokerTopicStats

2023-04-24 Thread via GitHub
hudeqi commented on PR #13571: URL: https://github.com/apache/kafka/pull/13571#issuecomment-1520098448 > @hudeqi Thanks for the PR and KIP. The KIP has to be discussed and voted by the community. See the process section in

[GitHub] [kafka] showuon opened a new pull request, #13631: KAFKA-14909: check zkMigrationReady tag before migration

2023-04-24 Thread via GitHub
showuon opened a new pull request, #13631: URL: https://github.com/apache/kafka/pull/13631 1. add `ZkMigrationReady` in apiVersionsResponse 2. check all nodes if `ZkMigrationReady` are ready before moving to next migration state ### Committer Checklist (excluded from commit

[GitHub] [kafka] viktorsomogyi commented on a diff in pull request #13594: KAFKA-14913: Using ThreadUtils.shutdownExecutorServiceQuietly to close executors in Connect Runtime

2023-04-24 Thread via GitHub
viktorsomogyi commented on code in PR #13594: URL: https://github.com/apache/kafka/pull/13594#discussion_r1175222973 ## connect/runtime/src/test/java/org/apache/kafka/connect/storage/KafkaStatusBackingStoreFormatTest.java: ## @@ -216,7 +216,7 @@ public void

[GitHub] [kafka] mimaison commented on pull request #13571: KAFKA-14907:Add the traffic metric of the partition dimension in BrokerTopicStats

2023-04-24 Thread via GitHub
mimaison commented on PR #13571: URL: https://github.com/apache/kafka/pull/13571#issuecomment-1520050947 @hudeqi Thanks for the PR and KIP. The KIP has to be discussed and voted by the community. See the process section in

[GitHub] [kafka] machi1990 commented on a diff in pull request #13135: KAFKA-14633: Reduce data copy & buffer allocation during decompression

2023-04-24 Thread via GitHub
machi1990 commented on code in PR #13135: URL: https://github.com/apache/kafka/pull/13135#discussion_r1175200643 ## clients/src/main/java/org/apache/kafka/common/utils/ChunkedBytesStream.java: ## @@ -0,0 +1,357 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [kafka] C0urante commented on a diff in pull request #13429: KAFKA-14666: Add MM2 in-memory offset translation index for offsets behind replication

2023-04-24 Thread via GitHub
C0urante commented on code in PR #13429: URL: https://github.com/apache/kafka/pull/13429#discussion_r1175123889 ## connect/mirror/src/main/java/org/apache/kafka/connect/mirror/OffsetSyncStore.java: ## @@ -139,10 +171,103 @@ public void close() { protected void

[GitHub] [kafka] C0urante commented on a diff in pull request #13429: KAFKA-14666: Add MM2 in-memory offset translation index for offsets behind replication

2023-04-24 Thread via GitHub
C0urante commented on code in PR #13429: URL: https://github.com/apache/kafka/pull/13429#discussion_r1174698662 ## connect/mirror/src/main/java/org/apache/kafka/connect/mirror/OffsetSyncStore.java: ## @@ -25,17 +25,46 @@ import org.apache.kafka.common.utils.Utils; import

[GitHub] [kafka] urbandan commented on a diff in pull request #13429: KAFKA-14666: Add MM2 in-memory offset translation index for offsets behind replication

2023-04-24 Thread via GitHub
urbandan commented on code in PR #13429: URL: https://github.com/apache/kafka/pull/13429#discussion_r1175076558 ## connect/mirror/src/main/java/org/apache/kafka/connect/mirror/OffsetSyncStore.java: ## @@ -139,10 +171,103 @@ public void close() { protected void

[GitHub] [kafka] mimaison commented on pull request #13259: MINOR: Remove accidental unnecessary code in src

2023-04-24 Thread via GitHub
mimaison commented on PR #13259: URL: https://github.com/apache/kafka/pull/13259#issuecomment-1519845506 Thanks for the updates! There's a spotbugs failure: ``` Bug type EQ_DOESNT_OVERRIDE_EQUALS In class org.apache.kafka.connect.runtime.InternalSinkRecord

[GitHub] [kafka] clolov commented on a diff in pull request #13538: KAFKA-14462; [8/N] Add ConsumerGroupMember

2023-04-24 Thread via GitHub
clolov commented on code in PR #13538: URL: https://github.com/apache/kafka/pull/13538#discussion_r1175040697 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroupMember.java: ## @@ -0,0 +1,613 @@ +/* + * Licensed to the Apache Software

[jira] [Assigned] (KAFKA-14909) KRaft Controllers not setting ZkMigrationReady tagged field

2023-04-24 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14909?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen reassigned KAFKA-14909: - Assignee: Luke Chen > KRaft Controllers not setting ZkMigrationReady tagged field >

[GitHub] [kafka] chia7712 merged pull request #13630: MINOR: fix zookeeper_migration_test.py

2023-04-24 Thread via GitHub
chia7712 merged PR #13630: URL: https://github.com/apache/kafka/pull/13630 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] chia7712 commented on pull request #13620: MINOR: fix zookeeper_migration_test.py

2023-04-24 Thread via GitHub
chia7712 commented on PR #13620: URL: https://github.com/apache/kafka/pull/13620#issuecomment-1519754399 > I think we should be backported to 3.5 too see #13630 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [kafka] chia7712 opened a new pull request, #13630: MINOR: fix zookeeper_migration_test.py

2023-04-24 Thread via GitHub
chia7712 opened a new pull request, #13630: URL: https://github.com/apache/kafka/pull/13630 backport #13620 to branch-3.5 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [kafka] chia7712 merged pull request #13620: MINOR: fix zookeeper_migration_test.py

2023-04-24 Thread via GitHub
chia7712 merged PR #13620: URL: https://github.com/apache/kafka/pull/13620 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Updated] (KAFKA-14712) Confusing error when writing downgraded FeatureImage

2023-04-24 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14712?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mickael Maison updated KAFKA-14712: --- Fix Version/s: 3.6.0 (was: 3.5.0) > Confusing error when writing

[jira] [Commented] (KAFKA-14712) Confusing error when writing downgraded FeatureImage

2023-04-24 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17715669#comment-17715669 ] Mickael Maison commented on KAFKA-14712: The ticket is still unassigned so moving to the next

[jira] [Updated] (KAFKA-14632) Compression optimization: Remove unnecessary intermediate buffers

2023-04-24 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14632?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mickael Maison updated KAFKA-14632: --- Fix Version/s: 3.6.0 (was: 3.5.0) > Compression optimization: Remove

[jira] [Commented] (KAFKA-14632) Compression optimization: Remove unnecessary intermediate buffers

2023-04-24 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17715666#comment-17715666 ] Mickael Maison commented on KAFKA-14632: PR is still a draft so moving to the next release. >

[jira] [Updated] (KAFKA-14186) Add unit tests for BatchFileWriter

2023-04-24 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14186?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mickael Maison updated KAFKA-14186: --- Fix Version/s: 3.6.0 (was: 3.5.0) > Add unit tests for

[jira] [Commented] (KAFKA-14186) Add unit tests for BatchFileWriter

2023-04-24 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17715660#comment-17715660 ] Mickael Maison commented on KAFKA-14186: I can't see a PR and we're near code freeze so bumping

[jira] [Commented] (KAFKA-14839) Exclude protected variable from JavaDocs

2023-04-24 Thread Atul Sharma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17715657#comment-17715657 ] Atul Sharma commented on KAFKA-14839: - Hi, [~mjsax] can i work in this? > Exclude protected

[jira] [Updated] (KAFKA-14876) Public documentation for new Kafka Connect offset management REST APIs in 3.5

2023-04-24 Thread Yash Mayya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14876?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yash Mayya updated KAFKA-14876: --- Description: Add public documentation for the new Kafka Connect offset management REST API being

[jira] [Commented] (KAFKA-14302) Infinite probing rebalance if a changelog topic got emptied

2023-04-24 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17715656#comment-17715656 ] Mickael Maison commented on KAFKA-14302: The ticket is still unassigned so moving to the next

[jira] [Updated] (KAFKA-14302) Infinite probing rebalance if a changelog topic got emptied

2023-04-24 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14302?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mickael Maison updated KAFKA-14302: --- Fix Version/s: 3.6.0 (was: 3.5.0) > Infinite probing rebalance if a

[jira] [Updated] (KAFKA-6527) Transient failure in DynamicBrokerReconfigurationTest.testDefaultTopicConfig

2023-04-24 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-6527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mickael Maison updated KAFKA-6527: -- Fix Version/s: 3.6.0 (was: 3.5.0) > Transient failure in

[jira] [Commented] (KAFKA-6527) Transient failure in DynamicBrokerReconfigurationTest.testDefaultTopicConfig

2023-04-24 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-6527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17715654#comment-17715654 ] Mickael Maison commented on KAFKA-6527: --- The test is currently disabled and the ticket is

[jira] [Updated] (KAFKA-8280) Flaky Test DynamicBrokerReconfigurationTest#testUncleanLeaderElectionEnable

2023-04-24 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8280?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mickael Maison updated KAFKA-8280: -- Fix Version/s: 3.6.0 (was: 3.5.0) > Flaky Test

[jira] [Updated] (KAFKA-7957) Flaky Test DynamicBrokerReconfigurationTest#testMetricsReporterUpdate

2023-04-24 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7957?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mickael Maison updated KAFKA-7957: -- Fix Version/s: 3.6.0 (was: 3.5.0) > Flaky Test

  1   2   >