[GitHub] [kafka] showuon commented on a diff in pull request #13514: KAFKA-14752: Kafka examples improvements - consumer changes

showuon commented on code in PR #13514: URL: https://github.com/apache/kafka/pull/13514#discussion_r1176408614 ## examples/src/main/java/kafka/examples/Consumer.java: ## @@ -76,12 +79,17 @@ public Consumer(String threadName, public void run() { // the consumer

[jira] [Assigned] (KAFKA-14911) Add system tests for rolling upgrade path of KIP-904

[ https://issues.apache.org/jira/browse/KAFKA-14911?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax reassigned KAFKA-14911: --- Assignee: Victoria Xia > Add system tests for rolling upgrade path of KIP-904 >

[jira] [Assigned] (KAFKA-14839) Exclude protected variable from JavaDocs

[ https://issues.apache.org/jira/browse/KAFKA-14839?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax reassigned KAFKA-14839: --- Assignee: Atul Sharma > Exclude protected variable from JavaDocs >

[jira] [Commented] (KAFKA-14839) Exclude protected variable from JavaDocs

[ https://issues.apache.org/jira/browse/KAFKA-14839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17716493#comment-17716493 ] Matthias J. Sax commented on KAFKA-14839: - Sure! > Exclude protected variable from JavaDocs >

[GitHub] [kafka] mjsax commented on pull request #13642: MINOR: update docs note about spurious stream-stream join results

mjsax commented on PR #13642: URL: https://github.com/apache/kafka/pull/13642#issuecomment-1522688918 Merged to `3.4` and cherry-picked to `3.3`, `3.2`, and `3.1` branches. Can you also do a follow up PR again `kafak-site.git` -- otherwise the changes does only go live if we do a

[GitHub] [kafka] mjsax merged pull request #13642: MINOR: update docs note about spurious stream-stream join results

mjsax merged PR #13642: URL: https://github.com/apache/kafka/pull/13642 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] mjsax commented on pull request #13622: KAFKA-14834: [13/N] Docs updates for versioned store semantics

mjsax commented on PR #13622: URL: https://github.com/apache/kafka/pull/13622#issuecomment-1522686788 Merged to `trunk` and cherry-picked to `3.5` branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [kafka] mjsax merged pull request #13622: KAFKA-14834: [13/N] Docs updates for versioned store semantics

mjsax merged PR #13622: URL: https://github.com/apache/kafka/pull/13622 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] mjsax commented on a diff in pull request #13622: KAFKA-14834: [13/N] Docs updates for versioned store semantics

mjsax commented on code in PR #13622: URL: https://github.com/apache/kafka/pull/13622#discussion_r1177276484 ## docs/streams/developer-guide/dsl-api.html: ## @@ -2830,6 +2846,9 @@ KTable-KTable Foreign-Key

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #13443: KAFKA-14514: Add Sticky Range Assignor on the Server (KIP-848)

rreddy-22 commented on code in PR #13443: URL: https://github.com/apache/kafka/pull/13443#discussion_r1177178765 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/RangeAssignor.java: ## @@ -0,0 +1,261 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #13443: KAFKA-14514: Add Sticky Range Assignor on the Server (KIP-848)

rreddy-22 commented on code in PR #13443: URL: https://github.com/apache/kafka/pull/13443#discussion_r1177177698 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/assignor/RangeAssignorTest.java: ## @@ -0,0 +1,514 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #13443: KAFKA-14514: Add Sticky Range Assignor on the Server (KIP-848)

rreddy-22 commented on code in PR #13443: URL: https://github.com/apache/kafka/pull/13443#discussion_r1177168484 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/RangeAssignor.java: ## @@ -0,0 +1,261 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #13443: KAFKA-14514: Add Sticky Range Assignor on the Server (KIP-848)

rreddy-22 commented on code in PR #13443: URL: https://github.com/apache/kafka/pull/13443#discussion_r1177168484 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/RangeAssignor.java: ## @@ -0,0 +1,261 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #13443: KAFKA-14514: Add Sticky Range Assignor on the Server (KIP-848)

rreddy-22 commented on code in PR #13443: URL: https://github.com/apache/kafka/pull/13443#discussion_r1177168353 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/RangeAssignor.java: ## @@ -0,0 +1,261 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] jeffkbkim commented on pull request #13267: KAFKA-14694: RPCProducerIdManager should not wait on new block

jeffkbkim commented on PR #13267: URL: https://github.com/apache/kafka/pull/13267#issuecomment-1522547962 @hachikuji this is ready for another round of review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [kafka] jeffkbkim commented on a diff in pull request #13267: KAFKA-14694: RPCProducerIdManager should not wait on new block

jeffkbkim commented on code in PR #13267: URL: https://github.com/apache/kafka/pull/13267#discussion_r1177161037 ## core/src/main/scala/kafka/coordinator/transaction/ProducerIdManager.scala: ## @@ -123,73 +129,95 @@ class ZkProducerIdManager(brokerId: Int, } } - def

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #13443: KAFKA-14514: Add Sticky Range Assignor on the Server (KIP-848)

rreddy-22 commented on code in PR #13443: URL: https://github.com/apache/kafka/pull/13443#discussion_r1177156668 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/RangeAssignor.java: ## @@ -0,0 +1,261 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #13443: KAFKA-14514: Add Sticky Range Assignor on the Server (KIP-848)

rreddy-22 commented on code in PR #13443: URL: https://github.com/apache/kafka/pull/13443#discussion_r1177156557 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/RangeAssignor.java: ## @@ -0,0 +1,261 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] cmccabe opened a new pull request, #13643: MINOR: provide the exact offset to QuorumController.replay

cmccabe opened a new pull request, #13643: URL: https://github.com/apache/kafka/pull/13643 Provide the exact record offset to QuorumController.replay() in all cases. There are several situations where this is useful, such as logging, implementing metadata transactions, or handling broker

[GitHub] [kafka] jeffkbkim commented on a diff in pull request #13267: KAFKA-14694: RPCProducerIdManager should not wait on new block

jeffkbkim commented on code in PR #13267: URL: https://github.com/apache/kafka/pull/13267#discussion_r1177143449 ## core/src/main/scala/kafka/coordinator/transaction/ProducerIdManager.scala: ## @@ -123,73 +129,94 @@ class ZkProducerIdManager(brokerId: Int, } } - def

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #13443: KAFKA-14514: Add Sticky Range Assignor on the Server (KIP-848)

rreddy-22 commented on code in PR #13443: URL: https://github.com/apache/kafka/pull/13443#discussion_r1177139606 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/RangeAssignor.java: ## @@ -0,0 +1,261 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #13443: KAFKA-14514: Add Sticky Range Assignor on the Server (KIP-848)

rreddy-22 commented on code in PR #13443: URL: https://github.com/apache/kafka/pull/13443#discussion_r1177136376 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/RangeAssignor.java: ## @@ -0,0 +1,261 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #13443: KAFKA-14514: Add Sticky Range Assignor on the Server (KIP-848)

rreddy-22 commented on code in PR #13443: URL: https://github.com/apache/kafka/pull/13443#discussion_r1177135296 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/RangeAssignor.java: ## @@ -0,0 +1,261 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] jeffkbkim commented on a diff in pull request #13267: KAFKA-14694: RPCProducerIdManager should not wait on new block

jeffkbkim commented on code in PR #13267: URL: https://github.com/apache/kafka/pull/13267#discussion_r1177133004 ## core/src/main/scala/kafka/coordinator/transaction/ProducerIdManager.scala: ## @@ -123,73 +129,94 @@ class ZkProducerIdManager(brokerId: Int, } } - def

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #13443: KAFKA-14514: Add Sticky Range Assignor on the Server (KIP-848)

rreddy-22 commented on code in PR #13443: URL: https://github.com/apache/kafka/pull/13443#discussion_r1177128215 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/RangeAssignor.java: ## @@ -0,0 +1,261 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] vcrfxia commented on a diff in pull request #13622: KAFKA-14834: [13/N] Docs updates for versioned store semantics

vcrfxia commented on code in PR #13622: URL: https://github.com/apache/kafka/pull/13622#discussion_r1177130156 ## docs/streams/core-concepts.html: ## @@ -328,13 +328,17 @@ < for stateful operations such as aggregations and joins, however, out-of-order data could cause

[GitHub] [kafka] vcrfxia opened a new pull request, #13642: MINOR: update docs note about spurious stream-stream join results

vcrfxia opened a new pull request, #13642: URL: https://github.com/apache/kafka/pull/13642 The existing docs note about spurious results from left and outer stream-stream joins is out-of-date as of https://issues.apache.org/jira/browse/KAFKA-10847. ### Committer Checklist (excluded

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #13443: KAFKA-14514: Add Sticky Range Assignor on the Server (KIP-848)

rreddy-22 commented on code in PR #13443: URL: https://github.com/apache/kafka/pull/13443#discussion_r1177128655 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/RangeAssignor.java: ## @@ -0,0 +1,261 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #13443: KAFKA-14514: Add Sticky Range Assignor on the Server (KIP-848)

rreddy-22 commented on code in PR #13443: URL: https://github.com/apache/kafka/pull/13443#discussion_r1177128215 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/RangeAssignor.java: ## @@ -0,0 +1,261 @@ +/* + * Licensed to the Apache Software

[jira] [Resolved] (KAFKA-14848) KafkaConsumer incorrectly passes locally-scoped deserializers to FetchConfig

[ https://issues.apache.org/jira/browse/KAFKA-14848?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True resolved KAFKA-14848. --- Resolution: Fixed > KafkaConsumer incorrectly passes locally-scoped deserializers to FetchConfig >

[jira] [Updated] (KAFKA-14937) Refactoring for client code to reduce boilerplate

[ https://issues.apache.org/jira/browse/KAFKA-14937?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-14937: -- Fix Version/s: 3.6.0 > Refactoring for client code to reduce boilerplate >

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #13443: KAFKA-14514: Add Sticky Range Assignor on the Server (KIP-848)

rreddy-22 commented on code in PR #13443: URL: https://github.com/apache/kafka/pull/13443#discussion_r1177109065 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/RangeAssignor.java: ## @@ -0,0 +1,261 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] vcrfxia commented on a diff in pull request #13622: KAFKA-14834: [13/N] Docs updates for versioned store semantics

vcrfxia commented on code in PR #13622: URL: https://github.com/apache/kafka/pull/13622#discussion_r1177112691 ## docs/streams/developer-guide/dsl-api.html: ## @@ -2830,6 +2846,9 @@ KTable-KTable Foreign-Key

[GitHub] [kafka] vcrfxia commented on a diff in pull request #13622: KAFKA-14834: [13/N] Docs updates for versioned store semantics

vcrfxia commented on code in PR #13622: URL: https://github.com/apache/kafka/pull/13622#discussion_r1177113372 ## docs/streams/developer-guide/dsl-api.html: ## @@ -3609,6 +3631,52 @@ KTable-KTable Foreign-Key and https://cwiki.apache.org/confluence/x/sQU0BQ;

[GitHub] [kafka] vcrfxia commented on a diff in pull request #13622: KAFKA-14834: [13/N] Docs updates for versioned store semantics

vcrfxia commented on code in PR #13622: URL: https://github.com/apache/kafka/pull/13622#discussion_r1177112439 ## docs/streams/core-concepts.html: ## @@ -328,13 +328,17 @@ < for stateful operations such as aggregations and joins, however, out-of-order data could cause

[GitHub] [kafka] vcrfxia commented on a diff in pull request #13622: KAFKA-14834: [13/N] Docs updates for versioned store semantics

vcrfxia commented on code in PR #13622: URL: https://github.com/apache/kafka/pull/13622#discussion_r1177112234 ## docs/streams/core-concepts.html: ## @@ -328,13 +328,17 @@ < for stateful operations such as aggregations and joins, however, out-of-order data could cause

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #13443: KAFKA-14514: Add Sticky Range Assignor on the Server (KIP-848)

rreddy-22 commented on code in PR #13443: URL: https://github.com/apache/kafka/pull/13443#discussion_r1177109065 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/RangeAssignor.java: ## @@ -0,0 +1,261 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] vamossagar12 commented on a diff in pull request #13634: KAFKA-14929: Fixing flaky test putTopicStateRetriableFailure

vamossagar12 commented on code in PR #13634: URL: https://github.com/apache/kafka/pull/13634#discussion_r1177099657 ## connect/runtime/src/test/java/org/apache/kafka/connect/storage/KafkaStatusBackingStoreFormatTest.java: ## @@ -216,7 +216,7 @@ public void

[GitHub] [kafka] wcarlson5 opened a new pull request, #13641: Kafka-14936: Add Grace Period to Stream Table Join

wcarlson5 opened a new pull request, #13641: URL: https://github.com/apache/kafka/pull/13641 Add grace period to the stream table join. Add an upstream processor that acts as a buffer to establish the grace period before sending the stream records down to the join operator to preform

[GitHub] [kafka] bmscomp commented on pull request #13569: MINOR: Upgrade to Gradle 8.1

bmscomp commented on PR #13569: URL: https://github.com/apache/kafka/pull/13569#issuecomment-1522451446 @ijuma Yes of course, I'll do that , this is the first PR ever for me in this repo, I'll keep learning from all of you -- This is an automated message from the Apache Git Service. To

[GitHub] [kafka] ijuma closed pull request #13569: MINOR: Upgrade to Gradle 8.1

ijuma closed pull request #13569: MINOR: Upgrade to Gradle 8.1 URL: https://github.com/apache/kafka/pull/13569 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [kafka] ijuma commented on pull request #13569: MINOR: Upgrade to Gradle 8.1

ijuma commented on PR #13569: URL: https://github.com/apache/kafka/pull/13569#issuecomment-1522449988 In the future, please try to work with the contributor who submitted a PR instead of creating your own. In this case, I went ahead and merged your PR and closing this one. -- This is an

[GitHub] [kafka] ijuma merged pull request #13625: MINOR: Upgrade gradle to 8.1.1

ijuma merged PR #13625: URL: https://github.com/apache/kafka/pull/13625 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] jolshan commented on a diff in pull request #13634: KAFKA-14929: Fixing flaky test putTopicStateRetriableFailure

jolshan commented on code in PR #13634: URL: https://github.com/apache/kafka/pull/13634#discussion_r1177067744 ## connect/runtime/src/test/java/org/apache/kafka/connect/storage/KafkaStatusBackingStoreFormatTest.java: ## @@ -216,7 +216,7 @@ public void

[GitHub] [kafka] jolshan commented on a diff in pull request #13544: KAFKA-14462; [9/N] Add RecordHelpers

jolshan commented on code in PR #13544: URL: https://github.com/apache/kafka/pull/13544#discussion_r1177047273 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/RecordHelpers.java: ## @@ -0,0 +1,371 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] jolshan commented on a diff in pull request #13544: KAFKA-14462; [9/N] Add RecordHelpers

jolshan commented on code in PR #13544: URL: https://github.com/apache/kafka/pull/13544#discussion_r1177046195 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/RecordHelpers.java: ## @@ -0,0 +1,371 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] jolshan commented on a diff in pull request #13544: KAFKA-14462; [9/N] Add RecordHelpers

jolshan commented on code in PR #13544: URL: https://github.com/apache/kafka/pull/13544#discussion_r1177028222 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/RecordHelpers.java: ## @@ -0,0 +1,371 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] jolshan commented on a diff in pull request #13544: KAFKA-14462; [9/N] Add RecordHelpers

jolshan commented on code in PR #13544: URL: https://github.com/apache/kafka/pull/13544#discussion_r1177026365 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/RecordHelpers.java: ## @@ -0,0 +1,371 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] kirktrue opened a new pull request, #13640: KAFKA-14937: Refactoring for client code to reduce boilerplate

kirktrue opened a new pull request, #13640: URL: https://github.com/apache/kafka/pull/13640 There are a number of places in the client code where the same basic calls are made by more than one client implementation. Minor refactoring will reduce the amount of boilerplate code necessary for

[jira] [Created] (KAFKA-14937) Refactoring for client code to reduce boilerplate

Kirk True created KAFKA-14937: - Summary: Refactoring for client code to reduce boilerplate Key: KAFKA-14937 URL: https://issues.apache.org/jira/browse/KAFKA-14937 Project: Kafka Issue Type:

[GitHub] [kafka] philipnee commented on pull request #13550: KAFKA-14639 - A single partition may be revoked and assign during a single round of rebalance

philipnee commented on PR #13550: URL: https://github.com/apache/kafka/pull/13550#issuecomment-1522355547 Hey @mimaison - Sorry for the late notice. We've been trying to fix this issue for the coming release 3.5. Would it be possible to include this for the 3.5 release? We should be able

[GitHub] [kafka] philipnee commented on a diff in pull request #13550: KAFKA-14639 - A single partition may be revoked and assign during a single round of rebalance

philipnee commented on code in PR #13550: URL: https://github.com/apache/kafka/pull/13550#discussion_r1176980677 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java: ## @@ -835,6 +835,7 @@ public void handle(SyncGroupResponse

[GitHub] [kafka] philipnee commented on a diff in pull request #13550: KAFKA-14639 - A single partition may be revoked and assign during a single round of rebalance

philipnee commented on code in PR #13550: URL: https://github.com/apache/kafka/pull/13550#discussion_r1176980400 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java: ## @@ -835,6 +839,8 @@ public void handle(SyncGroupResponse

[jira] [Commented] (KAFKA-14935) Wire Protocol Documentation Does Not Explain Header Versioning

[ https://issues.apache.org/jira/browse/KAFKA-14935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17716418#comment-17716418 ] Andrew Thaddeus Martin commented on KAFKA-14935: In

[jira] [Updated] (KAFKA-14936) Add Grace Period To Stream Table Join

[ https://issues.apache.org/jira/browse/KAFKA-14936?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-14936: Labels: kip streams (was: streams) > Add Grace Period To Stream Table Join >

[jira] [Updated] (KAFKA-14172) bug: State stores lose state when tasks are reassigned under EOS wit…

[ https://issues.apache.org/jira/browse/KAFKA-14172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-14172: Fix Version/s: 3.4.1 > bug: State stores lose state when tasks are reassigned under EOS

[jira] [Commented] (KAFKA-12570) Improve Documentation on COMPACT_ARRAY usage

[ https://issues.apache.org/jira/browse/KAFKA-12570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17716413#comment-17716413 ] Andrew Thaddeus Martin commented on KAFKA-12570: The documentation of COMPACT_ARRAY

[GitHub] [kafka] jolshan commented on a diff in pull request #13544: KAFKA-14462; [9/N] Add RecordHelpers

jolshan commented on code in PR #13544: URL: https://github.com/apache/kafka/pull/13544#discussion_r1176941034 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/RecordHelpers.java: ## @@ -0,0 +1,371 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] jolshan commented on a diff in pull request #13544: KAFKA-14462; [9/N] Add RecordHelpers

jolshan commented on code in PR #13544: URL: https://github.com/apache/kafka/pull/13544#discussion_r1176936158 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/RecordHelpers.java: ## @@ -0,0 +1,371 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] jolshan commented on a diff in pull request #13544: KAFKA-14462; [9/N] Add RecordHelpers

jolshan commented on code in PR #13544: URL: https://github.com/apache/kafka/pull/13544#discussion_r1176933020 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/RecordHelpers.java: ## @@ -0,0 +1,371 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[jira] [Created] (KAFKA-14936) Add Grace Period To Stream Table Join

Walker Carlson created KAFKA-14936: -- Summary: Add Grace Period To Stream Table Join Key: KAFKA-14936 URL: https://issues.apache.org/jira/browse/KAFKA-14936 Project: Kafka Issue Type:

[jira] [Updated] (KAFKA-14892) Harmonize package names in storage module

[ https://issues.apache.org/jira/browse/KAFKA-14892?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma updated KAFKA-14892: Fix Version/s: 3.6.0 > Harmonize package names in storage module >

[GitHub] [kafka] divijvaidya commented on pull request #13284: KAFKA-14718: Fix flaky DedicatedMirrorIntegrationTest

divijvaidya commented on PR #13284: URL: https://github.com/apache/kafka/pull/13284#issuecomment-150743 Hey @C0urante I haven't forgotten about this PR :) I am stuck right now and would solicit your help here. I have made the changes that you suggested but the below condition is

[GitHub] [kafka] jeffkbkim commented on a diff in pull request #13443: KAFKA-14514: Add Sticky Range Assignor on the Server (KIP-848)

jeffkbkim commented on code in PR #13443: URL: https://github.com/apache/kafka/pull/13443#discussion_r1176631579 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/RangeAssignor.java: ## @@ -0,0 +1,261 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #13637: KAFKA-14462; [10/N] Add TargetAssignmentBuilder

rreddy-22 commented on code in PR #13637: URL: https://github.com/apache/kafka/pull/13637#discussion_r1176848867 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/TargetAssignmentBuilder.java: ## @@ -0,0 +1,327 @@ +/* + * Licensed to the Apache

[GitHub] [kafka] mumrah commented on a diff in pull request #13631: KAFKA-14909: check zkMigrationReady tag before migration

mumrah commented on code in PR #13631: URL: https://github.com/apache/kafka/pull/13631#discussion_r1176825739 ## metadata/src/main/java/org/apache/kafka/controller/QuorumFeatures.java: ## @@ -128,4 +128,27 @@ VersionRange localSupportedFeature(String featureName) { boolean

[GitHub] [kafka] dajac commented on a diff in pull request #13544: KAFKA-14462; [9/N] Add RecordHelpers

dajac commented on code in PR #13544: URL: https://github.com/apache/kafka/pull/13544#discussion_r1176825997 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/RecordHelpers.java: ## @@ -0,0 +1,371 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #13637: KAFKA-14462; [10/N] Add TargetAssignmentBuilder

rreddy-22 commented on code in PR #13637: URL: https://github.com/apache/kafka/pull/13637#discussion_r1176822091 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/TargetAssignmentBuilder.java: ## @@ -0,0 +1,327 @@ +/* + * Licensed to the Apache

[jira] [Updated] (KAFKA-14935) Wire Protocol Documentation Does Not Explain Header Versioning

[ https://issues.apache.org/jira/browse/KAFKA-14935?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Thaddeus Martin updated KAFKA-14935: --- Description: The documentation for Kafka's wire protocol does not explain

[jira] [Created] (KAFKA-14935) Wire Protocol Documentation Does Not Explain Header Versioning

Andrew Thaddeus Martin created KAFKA-14935: -- Summary: Wire Protocol Documentation Does Not Explain Header Versioning Key: KAFKA-14935 URL: https://issues.apache.org/jira/browse/KAFKA-14935

[GitHub] [kafka] jeffkbkim commented on a diff in pull request #13544: KAFKA-14462; [9/N] Add RecordHelpers

jeffkbkim commented on code in PR #13544: URL: https://github.com/apache/kafka/pull/13544#discussion_r1176800586 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/RecordHelpers.java: ## @@ -0,0 +1,371 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [kafka] jeffkbkim commented on a diff in pull request #13544: KAFKA-14462; [9/N] Add RecordHelpers

jeffkbkim commented on code in PR #13544: URL: https://github.com/apache/kafka/pull/13544#discussion_r1176793376 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/RecordHelpers.java: ## @@ -0,0 +1,371 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [kafka] dajac commented on a diff in pull request #13544: KAFKA-14462; [9/N] Add RecordHelpers

dajac commented on code in PR #13544: URL: https://github.com/apache/kafka/pull/13544#discussion_r1176791643 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/RecordHelpers.java: ## @@ -0,0 +1,371 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] dajac merged pull request #13538: KAFKA-14462; [8/N] Add ConsumerGroupMember

dajac merged PR #13538: URL: https://github.com/apache/kafka/pull/13538 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Updated] (KAFKA-14922) kafka-streams-application-reset deletes topics not belonging to specified application-id

[ https://issues.apache.org/jira/browse/KAFKA-14922?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-14922: Labels: beginner needs-kip newbie (was: ) > kafka-streams-application-reset deletes

[jira] [Resolved] (KAFKA-14931) Revert KAFKA-14561 in 3.5

[ https://issues.apache.org/jira/browse/KAFKA-14931?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justine Olshan resolved KAFKA-14931. Resolution: Fixed > Revert KAFKA-14561 in 3.5 > - > >

[GitHub] [kafka] jolshan merged pull request #13632: KAFKA-14931: Revert KAFKA-14561 in 3.5

jolshan merged PR #13632: URL: https://github.com/apache/kafka/pull/13632 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] yashmayya commented on pull request #13636: KAFKA-14933: Document Kafka Connect's log level REST APIs added in KIP-495

yashmayya commented on PR #13636: URL: https://github.com/apache/kafka/pull/13636#issuecomment-1522043739 Thanks Mickael! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [kafka] mimaison merged pull request #13636: KAFKA-14933: Document Kafka Connect's log level REST APIs added in KIP-495

mimaison merged PR #13636: URL: https://github.com/apache/kafka/pull/13636 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Consumer Lag Metrics/ Topic level metrics

Dear Kafka Experts Could you please suggest good metrics exporter for consumer lag and topic level metrics apart from Linkedin kafka burrow for the kafka broker cluster.

[GitHub] [kafka] dajac closed pull request #13476: KAFKA-14462; [4/N] Add GroupMetadataManager: ConsumerGroups Management, Members Management and Reconciliation Logic

dajac closed pull request #13476: KAFKA-14462; [4/N] Add GroupMetadataManager: ConsumerGroups Management, Members Management and Reconciliation Logic URL: https://github.com/apache/kafka/pull/13476 -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [kafka] dajac commented on pull request #13476: KAFKA-14462; [4/N] Add GroupMetadataManager: ConsumerGroups Management, Members Management and Reconciliation Logic

dajac commented on PR #13476: URL: https://github.com/apache/kafka/pull/13476#issuecomment-1521927635 Closing this PR as I have opened smaller ones with the same code. @jeffkbkim I have addressed some of your last comments in https://github.com/apache/kafka/pull/13639. -- This is an

[GitHub] [kafka] dajac commented on a diff in pull request #13476: KAFKA-14462; [4/N] Add GroupMetadataManager: ConsumerGroups Management, Members Management and Reconciliation Logic

dajac commented on code in PR #13476: URL: https://github.com/apache/kafka/pull/13476#discussion_r1176634664 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroup.java: ## @@ -0,0 +1,535 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] dajac commented on a diff in pull request #13476: KAFKA-14462; [4/N] Add GroupMetadataManager: ConsumerGroups Management, Members Management and Reconciliation Logic

dajac commented on code in PR #13476: URL: https://github.com/apache/kafka/pull/13476#discussion_r1176634255 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -0,0 +1,873 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [kafka] dajac commented on a diff in pull request #13476: KAFKA-14462; [4/N] Add GroupMetadataManager: ConsumerGroups Management, Members Management and Reconciliation Logic

dajac commented on code in PR #13476: URL: https://github.com/apache/kafka/pull/13476#discussion_r1176632816 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -0,0 +1,873 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [kafka] dajac commented on a diff in pull request #13476: KAFKA-14462; [4/N] Add GroupMetadataManager: ConsumerGroups Management, Members Management and Reconciliation Logic

dajac commented on code in PR #13476: URL: https://github.com/apache/kafka/pull/13476#discussion_r1176631863 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -0,0 +1,873 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [kafka] dajac opened a new pull request, #13639: KAFKA-14462; [12/N] Add GroupMetadataManager and ConsumerGroup

dajac opened a new pull request, #13639: URL: https://github.com/apache/kafka/pull/13639 This PR is build on top of https://github.com/apache/kafka/pull/13637 and https://github.com/apache/kafka/pull/13638. This PR adds the GroupMetadataManager to the group-coordinator module. This

[jira] [Commented] (KAFKA-12485) Speed up Consumer#committed by returning cached offsets for owned partitions

[ https://issues.apache.org/jira/browse/KAFKA-12485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17716307#comment-17716307 ] Manyanda Chitimbo commented on KAFKA-12485: --- Hi [~ableegoldman] I am current looking at this

[GitHub] [kafka] jeffkbkim commented on a diff in pull request #13544: KAFKA-14462; [9/N] Add RecordHelpers

jeffkbkim commented on code in PR #13544: URL: https://github.com/apache/kafka/pull/13544#discussion_r1176590727 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/RecordHelpers.java: ## @@ -0,0 +1,371 @@ +/* + * Licensed to the Apache Software Foundation

[jira] [Created] (KAFKA-14934) KafkaClusterTestKit makes FaultHandler accessible

David Arthur created KAFKA-14934: Summary: KafkaClusterTestKit makes FaultHandler accessible Key: KAFKA-14934 URL: https://issues.apache.org/jira/browse/KAFKA-14934 Project: Kafka Issue

[GitHub] [kafka] mumrah commented on a diff in pull request #13407: KAFKA-14805 KRaft controller supports pre-migration mode

mumrah commented on code in PR #13407: URL: https://github.com/apache/kafka/pull/13407#discussion_r1176597177 ## core/src/test/scala/unit/kafka/server/BrokerRegistrationRequestTest.scala: ## @@ -145,25 +146,29 @@ class BrokerRegistrationRequestTest { }

[GitHub] [kafka] divijvaidya commented on a diff in pull request #13135: KAFKA-14633: Reduce data copy & buffer allocation during decompression

divijvaidya commented on code in PR #13135: URL: https://github.com/apache/kafka/pull/13135#discussion_r1176575715 ## clients/src/main/java/org/apache/kafka/common/utils/ByteBufferInputStream.java: ## @@ -29,6 +30,11 @@ public ByteBufferInputStream(ByteBuffer buffer) {

[jira] [Commented] (KAFKA-14666) MM2 should translate consumer group offsets behind replication flow

[ https://issues.apache.org/jira/browse/KAFKA-14666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17716286#comment-17716286 ] Mickael Maison commented on KAFKA-14666: I thought we were further from resolution. In that

[GitHub] [kafka] divijvaidya commented on pull request #13135: KAFKA-14633: Reduce data copy & buffer allocation during decompression

divijvaidya commented on PR #13135: URL: https://github.com/apache/kafka/pull/13135#issuecomment-1521852820 This is ready for review. A summary of the changes is provided below. **On the server:** 1. This PR starts using buffer pools to allocate intermediate buffer which is used

[jira] [Commented] (KAFKA-14666) MM2 should translate consumer group offsets behind replication flow

[ https://issues.apache.org/jira/browse/KAFKA-14666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17716280#comment-17716280 ] Chris Egerton commented on KAFKA-14666: --- [~mimaison] I believe this should be a release blocker.

[GitHub] [kafka] bmscomp commented on pull request #13569: MINOR: Upgrade to Gradle 8.1

bmscomp commented on PR #13569: URL: https://github.com/apache/kafka/pull/13569#issuecomment-1521831677 @ijuma Apologies, may be it's more wise to close the one I created and keep updating this one, I'll update my pull request since it contains also some Gradle plugin upgrades --

[GitHub] [kafka] ijuma commented on pull request #13569: MINOR: Upgrade to Gradle 8.1

ijuma commented on PR #13569: URL: https://github.com/apache/kafka/pull/13569#issuecomment-1521824170 It's a little odd to create a new PR instead of simply updating the one that's open... -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] gharris1727 commented on a diff in pull request #13429: KAFKA-14666: Add MM2 in-memory offset translation index for offsets behind replication

gharris1727 commented on code in PR #13429: URL: https://github.com/apache/kafka/pull/13429#discussion_r1176536050 ## connect/mirror/src/test/java/org/apache/kafka/connect/mirror/OffsetSyncStoreTest.java: ## @@ -57,52 +58,170 @@ public void testOffsetTranslation() {

[GitHub] [kafka] bmscomp commented on a diff in pull request #13627: MINOR: simplify if else conditions in Uuid.compareTo method

bmscomp commented on code in PR #13627: URL: https://github.com/apache/kafka/pull/13627#discussion_r1176527874 ## clients/src/main/java/org/apache/kafka/common/Uuid.java: ## @@ -143,12 +143,6 @@ public int compareTo(Uuid other) { return 1; Review Comment:

[GitHub] [kafka] C0urante commented on a diff in pull request #13429: KAFKA-14666: Add MM2 in-memory offset translation index for offsets behind replication

C0urante commented on code in PR #13429: URL: https://github.com/apache/kafka/pull/13429#discussion_r1175063429 ## connect/mirror/src/test/java/org/apache/kafka/connect/mirror/OffsetSyncStoreTest.java: ## @@ -57,52 +58,170 @@ public void testOffsetTranslation() {

  1   2   >