[jira] [Commented] (KAFKA-14322) Kafka node eating Disk continuously

2023-05-03 Thread Sergey Ivanov (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17719157#comment-17719157 ] Sergey Ivanov commented on KAFKA-14322: --- Hi, We faced similar problem. I described it in ticket

[jira] [Commented] (KAFKA-14817) LogCleaner mark some partitions of __consumer_offsets as uncleanable

2023-05-03 Thread Sergey Ivanov (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17719156#comment-17719156 ] Sergey Ivanov commented on KAFKA-14817: --- Hi, We faced the same issue in Kafka 2.8.1. Some

[GitHub] [kafka] mjsax commented on pull request #13654: HOTFIX: fix broken Streams upgrade system test

2023-05-03 Thread via GitHub
mjsax commented on PR #13654: URL: https://github.com/apache/kafka/pull/13654#issuecomment-1534030108 13 tests failed -- `StreamsBrokerBounceTest` should be unrelated, but also `StreamsUpgradeTest.test_rolling_upgrade_with_2_bounces` Re-triggred to see if the same tests fails, or if

[GitHub] [kafka] jolshan commented on pull request #13607: KAFKA-14916: Fix code that assumes transactional ID implies all records are transactional

2023-05-03 Thread via GitHub
jolshan commented on PR #13607: URL: https://github.com/apache/kafka/pull/13607#issuecomment-1533922748 haven't updated the base in a while, so merging so that we can hopefully get a cleaner build. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [kafka] jolshan merged pull request #13655: MINOR: Reduce number of threads created for integration test brokers

2023-05-03 Thread via GitHub
jolshan merged PR #13655: URL: https://github.com/apache/kafka/pull/13655 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] mumrah commented on a diff in pull request #13540: MINOR: improve QuorumController logging

2023-05-03 Thread via GitHub
mumrah commented on code in PR #13540: URL: https://github.com/apache/kafka/pull/13540#discussion_r1184415101 ## metadata/src/main/java/org/apache/kafka/metadata/util/RecordRedactor.java: ## @@ -0,0 +1,63 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [kafka] jolshan commented on a diff in pull request #13591: KAFKA-14831: Illegal state errors should be fatal in transactional producer

2023-05-03 Thread via GitHub
jolshan commented on code in PR #13591: URL: https://github.com/apache/kafka/pull/13591#discussion_r1184411246 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java: ## @@ -1090,6 +1090,9 @@ private void maybeFailWithError() {

[GitHub] [kafka] jolshan commented on a diff in pull request #13591: KAFKA-14831: Illegal state errors should be fatal in transactional producer

2023-05-03 Thread via GitHub
jolshan commented on code in PR #13591: URL: https://github.com/apache/kafka/pull/13591#discussion_r1184407115 ## clients/src/test/java/org/apache/kafka/clients/producer/internals/TransactionManagerTest.java: ## @@ -3405,6 +3408,53 @@ MAX_REQUEST_SIZE, ACKS_ALL, MAX_RETRIES,

[GitHub] [kafka] jolshan commented on a diff in pull request #13591: KAFKA-14831: Illegal state errors should be fatal in transactional producer

2023-05-03 Thread via GitHub
jolshan commented on code in PR #13591: URL: https://github.com/apache/kafka/pull/13591#discussion_r1184406528 ## clients/src/test/java/org/apache/kafka/clients/producer/internals/TransactionManagerTest.java: ## @@ -3405,6 +3406,54 @@ MAX_REQUEST_SIZE, ACKS_ALL, MAX_RETRIES,

[GitHub] [kafka] jolshan commented on a diff in pull request #13638: KAFKA-14462; [11/N] Add CurrentAssignmentBuilder

2023-05-03 Thread via GitHub
jolshan commented on code in PR #13638: URL: https://github.com/apache/kafka/pull/13638#discussion_r1184405678 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/consumer/CurrentAssignmentBuilderTest.java: ## @@ -0,0 +1,548 @@ +/* + * Licensed to the Apache

[GitHub] [kafka] kirktrue commented on a diff in pull request #13591: KAFKA-14831: Illegal state errors should be fatal in transactional producer

2023-05-03 Thread via GitHub
kirktrue commented on code in PR #13591: URL: https://github.com/apache/kafka/pull/13591#discussion_r1184402932 ## clients/src/test/java/org/apache/kafka/clients/producer/internals/TransactionManagerTest.java: ## @@ -3405,6 +3406,54 @@ MAX_REQUEST_SIZE, ACKS_ALL, MAX_RETRIES,

[GitHub] [kafka] kirktrue commented on a diff in pull request #13591: KAFKA-14831: Illegal state errors should be fatal in transactional producer

2023-05-03 Thread via GitHub
kirktrue commented on code in PR #13591: URL: https://github.com/apache/kafka/pull/13591#discussion_r1184402932 ## clients/src/test/java/org/apache/kafka/clients/producer/internals/TransactionManagerTest.java: ## @@ -3405,6 +3406,54 @@ MAX_REQUEST_SIZE, ACKS_ALL, MAX_RETRIES,

[GitHub] [kafka] kirktrue commented on a diff in pull request #13591: KAFKA-14831: Illegal state errors should be fatal in transactional producer

2023-05-03 Thread via GitHub
kirktrue commented on code in PR #13591: URL: https://github.com/apache/kafka/pull/13591#discussion_r1184401971 ## clients/src/test/java/org/apache/kafka/clients/producer/internals/TransactionManagerTest.java: ## @@ -3405,6 +3406,54 @@ MAX_REQUEST_SIZE, ACKS_ALL, MAX_RETRIES,

[GitHub] [kafka] jolshan commented on a diff in pull request #13638: KAFKA-14462; [11/N] Add CurrentAssignmentBuilder

2023-05-03 Thread via GitHub
jolshan commented on code in PR #13638: URL: https://github.com/apache/kafka/pull/13638#discussion_r1184401478 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/consumer/CurrentAssignmentBuilderTest.java: ## @@ -0,0 +1,548 @@ +/* + * Licensed to the Apache

[GitHub] [kafka] jolshan commented on a diff in pull request #13638: KAFKA-14462; [11/N] Add CurrentAssignmentBuilder

2023-05-03 Thread via GitHub
jolshan commented on code in PR #13638: URL: https://github.com/apache/kafka/pull/13638#discussion_r1184401478 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/consumer/CurrentAssignmentBuilderTest.java: ## @@ -0,0 +1,548 @@ +/* + * Licensed to the Apache

[GitHub] [kafka] jolshan commented on a diff in pull request #13638: KAFKA-14462; [11/N] Add CurrentAssignmentBuilder

2023-05-03 Thread via GitHub
jolshan commented on code in PR #13638: URL: https://github.com/apache/kafka/pull/13638#discussion_r1184383745 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/consumer/CurrentAssignmentBuilderTest.java: ## @@ -0,0 +1,548 @@ +/* + * Licensed to the Apache

[jira] [Commented] (KAFKA-14957) Default value for state.dir is confusing

2023-05-03 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17719079#comment-17719079 ] Matthias J. Sax commented on KAFKA-14957: - Ah. Thanks. That's gonna be nasty to fix... This

[GitHub] [kafka] jolshan commented on a diff in pull request #13638: KAFKA-14462; [11/N] Add CurrentAssignmentBuilder

2023-05-03 Thread via GitHub
jolshan commented on code in PR #13638: URL: https://github.com/apache/kafka/pull/13638#discussion_r1184300900 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/CurrentAssignmentBuilder.java: ## @@ -0,0 +1,415 @@ +/* + * Licensed to the Apache

[GitHub] [kafka] jolshan commented on a diff in pull request #13638: KAFKA-14462; [11/N] Add CurrentAssignmentBuilder

2023-05-03 Thread via GitHub
jolshan commented on code in PR #13638: URL: https://github.com/apache/kafka/pull/13638#discussion_r1184368057 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/CurrentAssignmentBuilder.java: ## @@ -0,0 +1,415 @@ +/* + * Licensed to the Apache

[GitHub] [kafka] jeffkbkim commented on a diff in pull request #13638: KAFKA-14462; [11/N] Add CurrentAssignmentBuilder

2023-05-03 Thread via GitHub
jeffkbkim commented on code in PR #13638: URL: https://github.com/apache/kafka/pull/13638#discussion_r1184358012 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/CurrentAssignmentBuilder.java: ## @@ -0,0 +1,436 @@ +/* + * Licensed to the Apache

[GitHub] [kafka] cmccabe merged pull request #13551: MINOR: Allow tagged fields with version subset of flexible version range

2023-05-03 Thread via GitHub
cmccabe merged PR #13551: URL: https://github.com/apache/kafka/pull/13551 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] jolshan commented on a diff in pull request #13638: KAFKA-14462; [11/N] Add CurrentAssignmentBuilder

2023-05-03 Thread via GitHub
jolshan commented on code in PR #13638: URL: https://github.com/apache/kafka/pull/13638#discussion_r1184323192 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/CurrentAssignmentBuilder.java: ## @@ -0,0 +1,415 @@ +/* + * Licensed to the Apache

[GitHub] [kafka] jolshan commented on a diff in pull request #13638: KAFKA-14462; [11/N] Add CurrentAssignmentBuilder

2023-05-03 Thread via GitHub
jolshan commented on code in PR #13638: URL: https://github.com/apache/kafka/pull/13638#discussion_r1184321022 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/CurrentAssignmentBuilder.java: ## @@ -0,0 +1,415 @@ +/* + * Licensed to the Apache

[GitHub] [kafka] jolshan commented on a diff in pull request #13638: KAFKA-14462; [11/N] Add CurrentAssignmentBuilder

2023-05-03 Thread via GitHub
jolshan commented on code in PR #13638: URL: https://github.com/apache/kafka/pull/13638#discussion_r1184317038 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/CurrentAssignmentBuilder.java: ## @@ -0,0 +1,415 @@ +/* + * Licensed to the Apache

[GitHub] [kafka] jolshan commented on pull request #12149: KAFKA-13668: Retry upon missing initProducerId due to authorization error

2023-05-03 Thread via GitHub
jolshan commented on PR #12149: URL: https://github.com/apache/kafka/pull/12149#issuecomment-1533772132 Thanks Philip. The initialization ones come when there is a thread leak somewhere. I'm pretty convinced it wasn't your change, but just wanted to be extra safe. I will check the next

[GitHub] [kafka] jolshan commented on a diff in pull request #13638: KAFKA-14462; [11/N] Add CurrentAssignmentBuilder

2023-05-03 Thread via GitHub
jolshan commented on code in PR #13638: URL: https://github.com/apache/kafka/pull/13638#discussion_r1184300900 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/CurrentAssignmentBuilder.java: ## @@ -0,0 +1,415 @@ +/* + * Licensed to the Apache

[GitHub] [kafka] jolshan commented on a diff in pull request #13638: KAFKA-14462; [11/N] Add CurrentAssignmentBuilder

2023-05-03 Thread via GitHub
jolshan commented on code in PR #13638: URL: https://github.com/apache/kafka/pull/13638#discussion_r1184300900 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/CurrentAssignmentBuilder.java: ## @@ -0,0 +1,415 @@ +/* + * Licensed to the Apache

[GitHub] [kafka] philipnee commented on a diff in pull request #12149: KAFKA-13668: Retry upon missing initProducerId due to authorization error

2023-05-03 Thread via GitHub
philipnee commented on code in PR #12149: URL: https://github.com/apache/kafka/pull/12149#discussion_r1184293956 ## clients/src/test/java/org/apache/kafka/clients/producer/KafkaProducerTest.java: ## @@ -1237,6 +1238,34 @@ public void testInitTransactionWhileThrottled() {

[GitHub] [kafka] jolshan commented on a diff in pull request #12149: KAFKA-13668: Retry upon missing initProducerId due to authorization error

2023-05-03 Thread via GitHub
jolshan commented on code in PR #12149: URL: https://github.com/apache/kafka/pull/12149#discussion_r1184283663 ## clients/src/test/java/org/apache/kafka/clients/producer/KafkaProducerTest.java: ## @@ -1237,6 +1238,34 @@ public void testInitTransactionWhileThrottled() {

[jira] [Created] (KAFKA-14966) Extract reusable common logic from OffsetFetcher

2023-05-03 Thread Lianet Magrans (Jira)
Lianet Magrans created KAFKA-14966: -- Summary: Extract reusable common logic from OffsetFetcher Key: KAFKA-14966 URL: https://issues.apache.org/jira/browse/KAFKA-14966 Project: Kafka Issue

[jira] [Created] (KAFKA-14965) Introduce ListOffsetsRequestManager to integrate ListOffsetsRequests into new consumer threading refactor

2023-05-03 Thread Lianet Magrans (Jira)
Lianet Magrans created KAFKA-14965: -- Summary: Introduce ListOffsetsRequestManager to integrate ListOffsetsRequests into new consumer threading refactor Key: KAFKA-14965 URL:

[GitHub] [kafka] jolshan commented on pull request #11096: Adding reviewers.py to help tag reviewers in commit message

2023-05-03 Thread via GitHub
jolshan commented on PR #11096: URL: https://github.com/apache/kafka/pull/11096#issuecomment-1533709307 @mumrah Can we please check builds before merging? The build caught the license issue. -- This is an automated message from the Apache Git Service. To respond to the message, please

[jira] [Updated] (KAFKA-14964) ClientQuotaMetadataManager should not suppress exceptions

2023-05-03 Thread David Arthur (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14964?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Arthur updated KAFKA-14964: - Affects Version/s: 3.4.0 3.5.0 > ClientQuotaMetadataManager should not

[jira] [Updated] (KAFKA-14964) ClientQuotaMetadataManager should not suppress exceptions

2023-05-03 Thread David Arthur (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14964?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Arthur updated KAFKA-14964: - Component/s: kraft > ClientQuotaMetadataManager should not suppress exceptions >

[jira] [Created] (KAFKA-14964) ClientQuotaMetadataManager should not suppress exceptions

2023-05-03 Thread David Arthur (Jira)
David Arthur created KAFKA-14964: Summary: ClientQuotaMetadataManager should not suppress exceptions Key: KAFKA-14964 URL: https://issues.apache.org/jira/browse/KAFKA-14964 Project: Kafka

[GitHub] [kafka] hachikuji commented on a diff in pull request #13607: KAFKA-14916: Fix code that assumes transactional ID implies all records are transactional

2023-05-03 Thread via GitHub
hachikuji commented on code in PR #13607: URL: https://github.com/apache/kafka/pull/13607#discussion_r1184131575 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -637,17 +637,31 @@ class ReplicaManager(val config: KafkaConfig, if

[GitHub] [kafka] philipnee commented on pull request #13664: KAFKA-14961: harden DefaultBackgroundThreadTest.testStartupAndTearDown test

2023-05-03 Thread via GitHub
philipnee commented on PR #13664: URL: https://github.com/apache/kafka/pull/13664#issuecomment-1533526150 Hey @machi1990 - I'll get someone to review this. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [kafka] divijvaidya opened a new pull request, #13670: KAFKA-14962: Trim whitespace from ACL configuration

2023-05-03 Thread via GitHub
divijvaidya opened a new pull request, #13670: URL: https://github.com/apache/kafka/pull/13670 Kafka's startup can fail (see the exception trace below) if there is a trailing or leading whitespace for a configuration value. This fix makes it more tolerant towards cases where a user might

[GitHub] [kafka] machi1990 commented on a diff in pull request #13669: MINOR: Fix producer Callback comment

2023-05-03 Thread via GitHub
machi1990 commented on code in PR #13669: URL: https://github.com/apache/kafka/pull/13669#discussion_r1184074412 ## clients/src/main/java/org/apache/kafka/clients/producer/Callback.java: ## @@ -36,7 +36,7 @@ public interface Callback { * Non-Retriable

[GitHub] [kafka] jsancio merged pull request #13668: KAFKA-14963; Use equals method with Uuid

2023-05-03 Thread via GitHub
jsancio merged PR #13668: URL: https://github.com/apache/kafka/pull/13668 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] jsancio commented on pull request #13668: KAFKA-14963; Use equals method with Uuid

2023-05-03 Thread via GitHub
jsancio commented on PR #13668: URL: https://github.com/apache/kafka/pull/13668#issuecomment-1533476771 Uuid is an object so they need to be compared with the equals method and not the == operator. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [kafka] jsancio commented on pull request #13668: KAFKA-14963; Use equals method with Uuid

2023-05-03 Thread via GitHub
jsancio commented on PR #13668: URL: https://github.com/apache/kafka/pull/13668#issuecomment-1533473126 Thanks for the reviews. The following command passes: ```bash $ ./gradlew metadata:test ``` -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kafka] machi1990 commented on pull request #13664: KAFKA-14961: harden DefaultBackgroundThreadTest.testStartupAndTearDown test

2023-05-03 Thread via GitHub
machi1990 commented on PR #13664: URL: https://github.com/apache/kafka/pull/13664#issuecomment-1533468874 Thanks for the review @philipnee Do you know which committer we can tag for this to be reviewed and then merged by them? -- This is an automated message from the Apache Git Service.

[jira] [Created] (KAFKA-14963) Incorrect partition count metrics for kraft controllers

2023-05-03 Thread Jira
José Armando García Sancio created KAFKA-14963: -- Summary: Incorrect partition count metrics for kraft controllers Key: KAFKA-14963 URL: https://issues.apache.org/jira/browse/KAFKA-14963

[GitHub] [kafka] jsancio commented on a diff in pull request #13668: MINOR; Use equals method with Uuid

2023-05-03 Thread via GitHub
jsancio commented on code in PR #13668: URL: https://github.com/apache/kafka/pull/13668#discussion_r1184012897 ## metadata/src/main/java/org/apache/kafka/controller/ControllerMetricsManager.java: ## @@ -202,10 +202,10 @@ private void handleFencingChange(Integer brokerId,

[GitHub] [kafka] ijuma commented on a diff in pull request #13668: MINOR; Use equals method with Uuid

2023-05-03 Thread via GitHub
ijuma commented on code in PR #13668: URL: https://github.com/apache/kafka/pull/13668#discussion_r1183991722 ## metadata/src/main/java/org/apache/kafka/controller/ControllerMetricsManager.java: ## @@ -202,10 +202,10 @@ private void handleFencingChange(Integer brokerId,

[GitHub] [kafka] cmccabe merged pull request #13653: KAFKA-14946: fix NPE when merging the deltatable

2023-05-03 Thread via GitHub
cmccabe merged PR #13653: URL: https://github.com/apache/kafka/pull/13653 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Resolved] (KAFKA-14016) Revoke more partitions than expected in Cooperative rebalance

2023-05-03 Thread Philip Nee (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14016?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Philip Nee resolved KAFKA-14016. Fix Version/s: 3.5.0 3.4.1 Assignee: Philip Nee Resolution:

[jira] [Resolved] (KAFKA-13891) sync group failed with rebalanceInProgress error cause rebalance many rounds in coopeartive

2023-05-03 Thread Philip Nee (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13891?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Philip Nee resolved KAFKA-13891. Fix Version/s: 3.5.0 3.4.1 (was: 3.6.0)

[jira] [Commented] (KAFKA-13891) sync group failed with rebalanceInProgress error cause rebalance many rounds in coopeartive

2023-05-03 Thread Philip Nee (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17718993#comment-17718993 ] Philip Nee commented on KAFKA-13891: Hey [~mimaison]  - this is actually the same issue as

[GitHub] [kafka] fvaleri commented on a diff in pull request #13515: KAFKA-14752: Kafka examples improvements - producer changes

2023-05-03 Thread via GitHub
fvaleri commented on code in PR #13515: URL: https://github.com/apache/kafka/pull/13515#discussion_r1183960378 ## examples/src/main/java/kafka/examples/Producer.java: ## @@ -21,133 +21,159 @@ import org.apache.kafka.clients.producer.ProducerConfig; import

[GitHub] [kafka] fvaleri commented on a diff in pull request #13515: KAFKA-14752: Kafka examples improvements - producer changes

2023-05-03 Thread via GitHub
fvaleri commented on code in PR #13515: URL: https://github.com/apache/kafka/pull/13515#discussion_r1183960307 ## examples/src/main/java/kafka/examples/Producer.java: ## @@ -21,133 +21,159 @@ import org.apache.kafka.clients.producer.ProducerConfig; import

[GitHub] [kafka] jsancio commented on pull request #13668: MINOR; Use equals method with Uuid

2023-05-03 Thread via GitHub
jsancio commented on PR #13668: URL: https://github.com/apache/kafka/pull/13668#issuecomment-1533380250 @mumrah this test fails without this fix: ``` Gradle Test Run :metadata:test > Gradle Test Executor 12 > ControllerMetricsManagerTest > testPartitionCountDecreased() FAILED

[GitHub] [kafka] jsancio opened a new pull request, #13668: MINOR; Use equals method with Uuid

2023-05-03 Thread via GitHub
jsancio opened a new pull request, #13668: URL: https://github.com/apache/kafka/pull/13668 Uuid is an object so they need to be compared with the equals method and not the == operator. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation

[GitHub] [kafka] fvaleri commented on a diff in pull request #13515: KAFKA-14752: Kafka examples improvements - producer changes

2023-05-03 Thread via GitHub
fvaleri commented on code in PR #13515: URL: https://github.com/apache/kafka/pull/13515#discussion_r1183959056 ## examples/src/main/java/kafka/examples/Producer.java: ## @@ -21,133 +21,159 @@ import org.apache.kafka.clients.producer.ProducerConfig; import

[jira] [Created] (KAFKA-14962) Whitespace in ACL configuration causes Kafka startup to fail

2023-05-03 Thread Divij Vaidya (Jira)
Divij Vaidya created KAFKA-14962: Summary: Whitespace in ACL configuration causes Kafka startup to fail Key: KAFKA-14962 URL: https://issues.apache.org/jira/browse/KAFKA-14962 Project: Kafka

[GitHub] [kafka] philipnee commented on pull request #12149: KAFKA-13668: Retry upon missing initProducerId due to authorization error

2023-05-03 Thread via GitHub
philipnee commented on PR #12149: URL: https://github.com/apache/kafka/pull/12149#issuecomment-1533354929 There seem to be a bit of server related failures, but they are also irrelevant to this change I think: I believe JDK17 tests and most of the JDK11 tests passed. ```

[GitHub] [kafka] dajac commented on a diff in pull request #13638: KAFKA-14462; [11/N] Add CurrentAssignmentBuilder

2023-05-03 Thread via GitHub
dajac commented on code in PR #13638: URL: https://github.com/apache/kafka/pull/13638#discussion_r1183933777 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/CurrentAssignmentBuilder.java: ## @@ -0,0 +1,415 @@ +/* + * Licensed to the Apache

[GitHub] [kafka] dajac commented on a diff in pull request #13638: KAFKA-14462; [11/N] Add CurrentAssignmentBuilder

2023-05-03 Thread via GitHub
dajac commented on code in PR #13638: URL: https://github.com/apache/kafka/pull/13638#discussion_r1183933309 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/CurrentAssignmentBuilder.java: ## @@ -0,0 +1,415 @@ +/* + * Licensed to the Apache

[GitHub] [kafka] machi1990 commented on a diff in pull request #13664: KAFKA-14961: harden DefaultBackgroundThreadTest.testStartupAndTearDown test

2023-05-03 Thread via GitHub
machi1990 commented on code in PR #13664: URL: https://github.com/apache/kafka/pull/13664#discussion_r1183913810 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/DefaultBackgroundThreadTest.java: ## @@ -89,11 +90,14 @@ public void setup() { }

[GitHub] [kafka] lucasbru opened a new pull request, #13667: KAFKA-12693: ALOS fencing

2023-05-03 Thread via GitHub
lucasbru opened a new pull request, #13667: URL: https://github.com/apache/kafka/pull/13667 When an instance (or thread within an instance) of Kafka Streams has a soft failure and the group coordinator triggers a rebalance, that instance would temporarily become a "zombie writer". That is,

[GitHub] [kafka] mimaison commented on pull request #13122: KAFKA-14594: Move LogDirsCommand to tools module

2023-05-03 Thread via GitHub
mimaison commented on PR #13122: URL: https://github.com/apache/kafka/pull/13122#issuecomment-1533310873 Thanks @clolov for the update. There's a few checkstyle failures in LogDirsCommandTest.java -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [kafka] jolshan commented on a diff in pull request #13638: KAFKA-14462; [11/N] Add CurrentAssignmentBuilder

2023-05-03 Thread via GitHub
jolshan commented on code in PR #13638: URL: https://github.com/apache/kafka/pull/13638#discussion_r1183889134 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/CurrentAssignmentBuilder.java: ## @@ -0,0 +1,415 @@ +/* + * Licensed to the Apache

[GitHub] [kafka] jolshan commented on a diff in pull request #13638: KAFKA-14462; [11/N] Add CurrentAssignmentBuilder

2023-05-03 Thread via GitHub
jolshan commented on code in PR #13638: URL: https://github.com/apache/kafka/pull/13638#discussion_r1183887136 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/CurrentAssignmentBuilder.java: ## @@ -0,0 +1,415 @@ +/* + * Licensed to the Apache

[GitHub] [kafka] jolshan commented on a diff in pull request #13638: KAFKA-14462; [11/N] Add CurrentAssignmentBuilder

2023-05-03 Thread via GitHub
jolshan commented on code in PR #13638: URL: https://github.com/apache/kafka/pull/13638#discussion_r1183887136 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/CurrentAssignmentBuilder.java: ## @@ -0,0 +1,415 @@ +/* + * Licensed to the Apache

[GitHub] [kafka] chia7712 commented on pull request #13659: MINOR: add docs to remind reader that impl of ConsumerPartitionAssign…

2023-05-03 Thread via GitHub
chia7712 commented on PR #13659: URL: https://github.com/apache/kafka/pull/13659#issuecomment-1533287238 @kirktrue thanks for feedback. will address it later. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [kafka] kirktrue commented on pull request #13659: MINOR: add docs to remind reader that impl of ConsumerPartitionAssign…

2023-05-03 Thread via GitHub
kirktrue commented on PR #13659: URL: https://github.com/apache/kafka/pull/13659#issuecomment-1533285689 This looks good to me. I looked briefly at the code that calls

[GitHub] [kafka] clolov commented on a diff in pull request #13122: KAFKA-14594: Move LogDirsCommand to tools module

2023-05-03 Thread via GitHub
clolov commented on code in PR #13122: URL: https://github.com/apache/kafka/pull/13122#discussion_r1183882730 ## tools/src/test/java/org/apache/kafka/tools/LogDirsCommandTest.java: ## @@ -0,0 +1,119 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more +

[GitHub] [kafka] clolov commented on a diff in pull request #13122: KAFKA-14594: Move LogDirsCommand to tools module

2023-05-03 Thread via GitHub
clolov commented on code in PR #13122: URL: https://github.com/apache/kafka/pull/13122#discussion_r1183881591 ## tools/src/test/java/org/apache/kafka/tools/LogDirsCommandTest.java: ## @@ -0,0 +1,119 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more +

[GitHub] [kafka] kirktrue commented on a diff in pull request #13664: KAFKA-14961: harden DefaultBackgroundThreadTest.testStartupAndTearDown test

2023-05-03 Thread via GitHub
kirktrue commented on code in PR #13664: URL: https://github.com/apache/kafka/pull/13664#discussion_r1183863358 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/DefaultBackgroundThreadTest.java: ## @@ -89,11 +90,14 @@ public void setup() { }

[GitHub] [kafka] kirktrue commented on a diff in pull request #13666: KAFKA-14462; [13/N] CoordinatorEvent and CoordinatorEventProcessor

2023-05-03 Thread via GitHub
kirktrue commented on code in PR #13666: URL: https://github.com/apache/kafka/pull/13666#discussion_r1183846777 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/MultiThreadedEventProcessor.java: ## @@ -0,0 +1,191 @@ +/* + * Licensed to the Apache

[GitHub] [kafka] sambhav-jain-16 commented on pull request #13646: KAFKA-14938: Fixing flaky test testConnectorBoundary

2023-05-03 Thread via GitHub
sambhav-jain-16 commented on PR #13646: URL: https://github.com/apache/kafka/pull/13646#issuecomment-1533239690 Hi @vamossagar12, I can set that but actually `endoffsets` is getting populated with right values. The issue is with the way `lastConsumedOffset` is being used. -- This

[jira] [Assigned] (KAFKA-12693) Consecutive rebalances with zombie instances may cause corrupted changelogs

2023-05-03 Thread Lucas Brutschy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12693?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lucas Brutschy reassigned KAFKA-12693: -- Assignee: Lucas Brutschy > Consecutive rebalances with zombie instances may cause

[GitHub] [kafka] dajac opened a new pull request, #13666: KAFKA-14462; [13/N] CoordinatorEvent and CoordinatorEventProcessor

2023-05-03 Thread via GitHub
dajac opened a new pull request, #13666: URL: https://github.com/apache/kafka/pull/13666 Adds CoordinatorEvent, CoordinatorEventProcessor, and MultiThreadedEventProcessor. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ]

[GitHub] [kafka] divijvaidya commented on a diff in pull request #13623: KAFKA-14926: Remove metrics on Log Cleaner shutdown

2023-05-03 Thread via GitHub
divijvaidya commented on code in PR #13623: URL: https://github.com/apache/kafka/pull/13623#discussion_r1183658413 ## core/src/test/scala/unit/kafka/log/LogCleanerTest.scala: ## @@ -62,6 +65,39 @@ class LogCleanerTest { Utils.delete(tmpdir) } + @Test + def

[GitHub] [kafka] divijvaidya commented on a diff in pull request #13623: KAFKA-14926: Remove metrics on Log Cleaner shutdown

2023-05-03 Thread via GitHub
divijvaidya commented on code in PR #13623: URL: https://github.com/apache/kafka/pull/13623#discussion_r1183654795 ## core/src/main/scala/kafka/log/LogCleaner.scala: ## @@ -466,6 +472,17 @@ object LogCleaner { config.logCleanerEnable) } + + private val

[GitHub] [kafka] divijvaidya commented on a diff in pull request #13623: KAFKA-14926: Remove metrics on Log Cleaner shutdown

2023-05-03 Thread via GitHub
divijvaidya commented on code in PR #13623: URL: https://github.com/apache/kafka/pull/13623#discussion_r1183654517 ## core/src/test/scala/unit/kafka/log/LogCleanerTest.scala: ## @@ -62,6 +65,39 @@ class LogCleanerTest { Utils.delete(tmpdir) } + @Test + def

[GitHub] [kafka] machi1990 opened a new pull request, #13665: KAFKA-12485: Speed up Consumer#committed by returning cached offsets for owned partitions

2023-05-03 Thread via GitHub
machi1990 opened a new pull request, #13665: URL: https://github.com/apache/kafka/pull/13665 Opening as a WIP as I need to look on adding more tests. I'll promote this once that's done. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation

[GitHub] [kafka] machi1990 commented on pull request #13664: KAFKA-14961: harden DefaultBackgroundThreadTest.testStartupAndTearDown test

2023-05-03 Thread via GitHub
machi1990 commented on PR #13664: URL: https://github.com/apache/kafka/pull/13664#issuecomment-153294 @philipnee can you've a look? Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] machi1990 commented on a diff in pull request #13664: KAFKA-14961: harden DefaultBackgroundThreadTest.testStartupAndTearDown test

2023-05-03 Thread via GitHub
machi1990 commented on code in PR #13664: URL: https://github.com/apache/kafka/pull/13664#discussion_r1183579541 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/DefaultBackgroundThreadTest.java: ## @@ -89,11 +90,14 @@ public void setup() { }

[GitHub] [kafka] machi1990 commented on a diff in pull request #13664: KAFKA-14961: harden DefaultBackgroundThreadTest.testStartupAndTearDown test

2023-05-03 Thread via GitHub
machi1990 commented on code in PR #13664: URL: https://github.com/apache/kafka/pull/13664#discussion_r1183579038 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/DefaultBackgroundThreadTest.java: ## @@ -89,11 +90,14 @@ public void setup() { }

[GitHub] [kafka] machi1990 opened a new pull request, #13664: KAFKA-14961: harden DefaultBackgroundThreadTest.testStartupAndTearDown test

2023-05-03 Thread via GitHub
machi1990 opened a new pull request, #13664: URL: https://github.com/apache/kafka/pull/13664 1. Ensures that NPE are not thrown 2. Ensures that the background thread has been started to avoid flasky assertions failures on isRunning 3. Add a check that the thread is not running when

[jira] [Created] (KAFKA-14961) DefaultBackgroundThreadTest.testStartupAndTearDown test is flasky

2023-05-03 Thread Manyanda Chitimbo (Jira)
Manyanda Chitimbo created KAFKA-14961: - Summary: DefaultBackgroundThreadTest.testStartupAndTearDown test is flasky Key: KAFKA-14961 URL: https://issues.apache.org/jira/browse/KAFKA-14961 Project:

[GitHub] [kafka] tinaselenge commented on a diff in pull request #13660: KAFKA-14662: Update the ACL list in the doc

2023-05-03 Thread via GitHub
tinaselenge commented on code in PR #13660: URL: https://github.com/apache/kafka/pull/13660#discussion_r1183526354 ## docs/security.html: ## @@ -2089,6 +2089,144 @@

[GitHub] [kafka] tinaselenge commented on a diff in pull request #13660: KAFKA-14662: Update the ACL list in the doc

2023-05-03 Thread via GitHub
tinaselenge commented on code in PR #13660: URL: https://github.com/apache/kafka/pull/13660#discussion_r1183527261 ## docs/security.html: ## @@ -2089,6 +2089,144 @@

[GitHub] [kafka] tinaselenge commented on a diff in pull request #13660: KAFKA-14662: Update the ACL list in the doc

2023-05-03 Thread via GitHub
tinaselenge commented on code in PR #13660: URL: https://github.com/apache/kafka/pull/13660#discussion_r1183526354 ## docs/security.html: ## @@ -2089,6 +2089,144 @@

[GitHub] [kafka] cadonna commented on a diff in pull request #13656: KAFKA-14911: Add system tests for rolling upgrade path of KIP-904

2023-05-03 Thread via GitHub
cadonna commented on code in PR #13656: URL: https://github.com/apache/kafka/pull/13656#discussion_r1183390548 ## streams/src/test/java/org/apache/kafka/streams/tests/SmokeTestDriver.java: ## @@ -106,7 +106,11 @@ private static class ValueList { } int next()

[GitHub] [kafka] Hangleton commented on a diff in pull request #12331: KAFKA-1194: changes needed to run on Windows

2023-05-03 Thread via GitHub
Hangleton commented on code in PR #12331: URL: https://github.com/apache/kafka/pull/12331#discussion_r1183474170 ## raft/src/main/java/org/apache/kafka/raft/FileBasedStateStore.java: ## @@ -139,16 +139,17 @@ private void writeElectionStateToFile(final File stateFile,

[jira] [Updated] (KAFKA-14946) KRaft controller node shutting down while renouncing leadership

2023-05-03 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14946?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen updated KAFKA-14946: -- Fix Version/s: 3.4.1 > KRaft controller node shutting down while renouncing leadership >

[jira] [Updated] (KAFKA-14946) KRaft controller node shutting down while renouncing leadership

2023-05-03 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14946?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen updated KAFKA-14946: -- Fix Version/s: 3.5.0 > KRaft controller node shutting down while renouncing leadership >

[GitHub] [kafka] Hangleton commented on a diff in pull request #13535: KAFKA-9579 Fetch implementation for records in the remote storage through a specific purgatory.

2023-05-03 Thread via GitHub
Hangleton commented on code in PR #13535: URL: https://github.com/apache/kafka/pull/13535#discussion_r1183397975 ## core/src/main/java/kafka/log/remote/RemoteLogReader.java: ## @@ -0,0 +1,70 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

[GitHub] [kafka] vamossagar12 commented on pull request #13646: KAFKA-14938: Fixing flaky test testConnectorBoundary

2023-05-03 Thread via GitHub
vamossagar12 commented on PR #13646: URL: https://github.com/apache/kafka/pull/13646#issuecomment-1532658288 Thanks @sambhav-jain-16 . So, one thing that I note is that the `readEndOffsets` method is using `IsolationLevel.READ_UNCOMMITTED` when reading the messages while the test uses

[jira] [Updated] (KAFKA-14909) KRaft Controllers not setting ZkMigrationReady tagged field

2023-05-03 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14909?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen updated KAFKA-14909: -- Fix Version/s: (was: 3.4.1) > KRaft Controllers not setting ZkMigrationReady tagged field >

[jira] [Commented] (KAFKA-14957) Default value for state.dir is confusing

2023-05-03 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17718841#comment-17718841 ] Mickael Maison commented on KAFKA-14957: The configuration docs on the website:

[jira] [Updated] (KAFKA-13891) sync group failed with rebalanceInProgress error cause rebalance many rounds in coopeartive

2023-05-03 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13891?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mickael Maison updated KAFKA-13891: --- Fix Version/s: 3.6.0 (was: 3.5.0) > sync group failed with

[jira] [Commented] (KAFKA-13891) sync group failed with rebalanceInProgress error cause rebalance many rounds in coopeartive

2023-05-03 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17718826#comment-17718826 ] Mickael Maison commented on KAFKA-13891: We are past code freeze for 3.5 so moving this to the

[jira] [Commented] (KAFKA-13421) Fix ConsumerBounceTest#testRollingBrokerRestartsWithSmallerMaxGroupSizeConfigDisruptsBigGroup

2023-05-03 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17718824#comment-17718824 ] Mickael Maison commented on KAFKA-13421: We are past code freeze for 3.5 so moving to the next

[jira] [Updated] (KAFKA-13421) Fix ConsumerBounceTest#testRollingBrokerRestartsWithSmallerMaxGroupSizeConfigDisruptsBigGroup

2023-05-03 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13421?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mickael Maison updated KAFKA-13421: --- Fix Version/s: 3.6.0 (was: 3.5.0) > Fix >

[jira] [Updated] (KAFKA-12319) Flaky test ConnectionQuotasTest.testListenerConnectionRateLimitWhenActualRateAboveLimit()

2023-05-03 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12319?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mickael Maison updated KAFKA-12319: --- Fix Version/s: 3.6.0 (was: 3.5.0) > Flaky test >

[jira] [Commented] (KAFKA-12319) Flaky test ConnectionQuotasTest.testListenerConnectionRateLimitWhenActualRateAboveLimit()

2023-05-03 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17718823#comment-17718823 ] Mickael Maison commented on KAFKA-12319: We are past code freeze for 3.5 so moving this to the

  1   2   >