[GitHub] [kafka] vamossagar12 commented on pull request #13733: KAFKA-13337: fix of possible java.nio.file.AccessDeniedException during Connect plugin directory scan

2023-05-23 Thread via GitHub
vamossagar12 commented on PR #13733: URL: https://github.com/apache/kafka/pull/13733#issuecomment-1560458136 Thanks @akatona84 for the clarification. If I go by what @gharris1727 is saying above, i.e > When a directory is not accessible, only plugins within that directory should be

[GitHub] [kafka] satishd commented on a diff in pull request #13561: KAFKA-14888: Added remote log segments retention functionality based on time and size.

2023-05-23 Thread via GitHub
satishd commented on code in PR #13561: URL: https://github.com/apache/kafka/pull/13561#discussion_r1181520975 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -581,11 +588,18 @@ public void run() { if (isLeader()) { //

[jira] [Updated] (KAFKA-14836) Fix UtilsTest#testToLogDateTimeFormat failure in some cases

2023-05-23 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14836?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen updated KAFKA-14836: -- Fix Version/s: 3.4.1 > Fix UtilsTest#testToLogDateTimeFormat failure in some cases >

[GitHub] [kafka] showuon merged pull request #13744: MINOR: update 3.4.1 licence

2023-05-23 Thread via GitHub
showuon merged PR #13744: URL: https://github.com/apache/kafka/pull/13744 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] showuon commented on pull request #13745: KAFKA-15015: Explicit on reload4j version

2023-05-23 Thread via GitHub
showuon commented on PR #13745: URL: https://github.com/apache/kafka/pull/13745#issuecomment-1560339089 Backported to 3.4 and 3.5 branch. @mimaison , if you have another RC build, this duplicated reload4j binary issue will be fixed. FYI -- This is an automated message from the Apache Git

[jira] [Resolved] (KAFKA-15015) Binaries contain 2 versions of reload4j

2023-05-23 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15015?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen resolved KAFKA-15015. --- Fix Version/s: 3.5.0 3.4.1 Resolution: Fixed > Binaries contain 2

[GitHub] [kafka] showuon merged pull request #13745: KAFKA-15015: Explicit on reload4j version

2023-05-23 Thread via GitHub
showuon merged PR #13745: URL: https://github.com/apache/kafka/pull/13745 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] showuon commented on pull request #13745: KAFKA-15015: Explicit on reload4j version

2023-05-23 Thread via GitHub
showuon commented on PR #13745: URL: https://github.com/apache/kafka/pull/13745#issuecomment-1560336419 Failed tests also failed in trunk build ``` Build / JDK 17 and Scala 2.13 / kafka.server.ListOffsetsRequestTest.testResponseIncludesLeaderEpoch() Build / JDK 17 and Scala

[GitHub] [kafka] jolshan commented on a diff in pull request #13639: KAFKA-14462; [12/N] Add GroupMetadataManager and ConsumerGroup

2023-05-23 Thread via GitHub
jolshan commented on code in PR #13639: URL: https://github.com/apache/kafka/pull/13639#discussion_r1203225900 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java: ## @@ -0,0 +1,2017 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] jolshan commented on a diff in pull request #13639: KAFKA-14462; [12/N] Add GroupMetadataManager and ConsumerGroup

2023-05-23 Thread via GitHub
jolshan commented on code in PR #13639: URL: https://github.com/apache/kafka/pull/13639#discussion_r1203224577 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java: ## @@ -0,0 +1,2017 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] jolshan commented on a diff in pull request #13639: KAFKA-14462; [12/N] Add GroupMetadataManager and ConsumerGroup

2023-05-23 Thread via GitHub
jolshan commented on code in PR #13639: URL: https://github.com/apache/kafka/pull/13639#discussion_r1203222949 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java: ## @@ -0,0 +1,2017 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] junrao commented on a diff in pull request #13561: KAFKA-14888: Added remote log segments retention functionality based on time and size.

2023-05-23 Thread via GitHub
junrao commented on code in PR #13561: URL: https://github.com/apache/kafka/pull/13561#discussion_r1203191600 ## core/src/main/scala/kafka/server/BrokerServer.scala: ## @@ -522,7 +522,12 @@ class BrokerServer( } Some(new RemoteLogManager(remoteLogManagerConfig,

[GitHub] [kafka] jolshan commented on a diff in pull request #13639: KAFKA-14462; [12/N] Add GroupMetadataManager and ConsumerGroup

2023-05-23 Thread via GitHub
jolshan commented on code in PR #13639: URL: https://github.com/apache/kafka/pull/13639#discussion_r1203192959 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java: ## @@ -0,0 +1,2080 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] jolshan commented on a diff in pull request #13639: KAFKA-14462; [12/N] Add GroupMetadataManager and ConsumerGroup

2023-05-23 Thread via GitHub
jolshan commented on code in PR #13639: URL: https://github.com/apache/kafka/pull/13639#discussion_r1203184877 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroup.java: ## @@ -0,0 +1,535 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] jolshan commented on a diff in pull request #13639: KAFKA-14462; [12/N] Add GroupMetadataManager and ConsumerGroup

2023-05-23 Thread via GitHub
jolshan commented on code in PR #13639: URL: https://github.com/apache/kafka/pull/13639#discussion_r1203181594 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroup.java: ## @@ -0,0 +1,535 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] jolshan commented on a diff in pull request #13639: KAFKA-14462; [12/N] Add GroupMetadataManager and ConsumerGroup

2023-05-23 Thread via GitHub
jolshan commented on code in PR #13639: URL: https://github.com/apache/kafka/pull/13639#discussion_r1203158830 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroup.java: ## @@ -0,0 +1,635 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] jolshan commented on a diff in pull request #13639: KAFKA-14462; [12/N] Add GroupMetadataManager and ConsumerGroup

2023-05-23 Thread via GitHub
jolshan commented on code in PR #13639: URL: https://github.com/apache/kafka/pull/13639#discussion_r1203152667 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroup.java: ## @@ -0,0 +1,635 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] jolshan commented on a diff in pull request #13639: KAFKA-14462; [12/N] Add GroupMetadataManager and ConsumerGroup

2023-05-23 Thread via GitHub
jolshan commented on code in PR #13639: URL: https://github.com/apache/kafka/pull/13639#discussion_r1203152667 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroup.java: ## @@ -0,0 +1,635 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] danicafine opened a new pull request, #13751: KAFKA-14539: Simplify StreamsMetadataState by replacing the Cluster metadata with partition info map

2023-05-23 Thread via GitHub
danicafine opened a new pull request, #13751: URL: https://github.com/apache/kafka/pull/13751 Replace usage of Cluster in StreamsMetadataState with Map>. Update StreamsPartitionAssignor#onAssignment method to pass existing Map instead of fake Cluster object. Behavior remains the

[GitHub] [kafka] jolshan commented on a diff in pull request #13639: KAFKA-14462; [12/N] Add GroupMetadataManager and ConsumerGroup

2023-05-23 Thread via GitHub
jolshan commented on code in PR #13639: URL: https://github.com/apache/kafka/pull/13639#discussion_r1203150079 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroup.java: ## @@ -0,0 +1,535 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] gharris1727 commented on a diff in pull request #13165: KAFKA-14654: Connector classes should statically initialize with plugin classloader

2023-05-23 Thread via GitHub
gharris1727 commented on code in PR #13165: URL: https://github.com/apache/kafka/pull/13165#discussion_r1203138122 ## connect/runtime/src/main/java/org/apache/kafka/connect/cli/AbstractConnectCli.java: ## @@ -119,36 +120,37 @@ public Connect startConnect(Map workerProps,

[GitHub] [kafka] jolshan commented on a diff in pull request #13639: KAFKA-14462; [12/N] Add GroupMetadataManager and ConsumerGroup

2023-05-23 Thread via GitHub
jolshan commented on code in PR #13639: URL: https://github.com/apache/kafka/pull/13639#discussion_r1203132909 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -0,0 +1,859 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] gharris1727 commented on pull request #13165: KAFKA-14654: Connector classes should statically initialize with plugin classloader

2023-05-23 Thread via GitHub
gharris1727 commented on PR #13165: URL: https://github.com/apache/kafka/pull/13165#issuecomment-1560240995 > I'm wondering if we can get better coverage for DelegatingClassLoader::scanPluginPath. Right now we verify in PluginsTest::newConnectorShouldInstantiateWithPluginClassLoader that

[GitHub] [kafka] jolshan commented on a diff in pull request #13639: KAFKA-14462; [12/N] Add GroupMetadataManager and ConsumerGroup

2023-05-23 Thread via GitHub
jolshan commented on code in PR #13639: URL: https://github.com/apache/kafka/pull/13639#discussion_r1203119594 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -0,0 +1,865 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] jolshan commented on a diff in pull request #13639: KAFKA-14462; [12/N] Add GroupMetadataManager and ConsumerGroup

2023-05-23 Thread via GitHub
jolshan commented on code in PR #13639: URL: https://github.com/apache/kafka/pull/13639#discussion_r1203119594 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -0,0 +1,865 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] jolshan commented on a diff in pull request #13639: KAFKA-14462; [12/N] Add GroupMetadataManager and ConsumerGroup

2023-05-23 Thread via GitHub
jolshan commented on code in PR #13639: URL: https://github.com/apache/kafka/pull/13639#discussion_r1203119594 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -0,0 +1,865 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] jolshan commented on a diff in pull request #13639: KAFKA-14462; [12/N] Add GroupMetadataManager and ConsumerGroup

2023-05-23 Thread via GitHub
jolshan commented on code in PR #13639: URL: https://github.com/apache/kafka/pull/13639#discussion_r1203106357 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -0,0 +1,865 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] jolshan commented on a diff in pull request #13639: KAFKA-14462; [12/N] Add GroupMetadataManager and ConsumerGroup

2023-05-23 Thread via GitHub
jolshan commented on code in PR #13639: URL: https://github.com/apache/kafka/pull/13639#discussion_r1203106357 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -0,0 +1,865 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] jolshan commented on a diff in pull request #13639: KAFKA-14462; [12/N] Add GroupMetadataManager and ConsumerGroup

2023-05-23 Thread via GitHub
jolshan commented on code in PR #13639: URL: https://github.com/apache/kafka/pull/13639#discussion_r1203084630 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -0,0 +1,859 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] jolshan commented on a diff in pull request #13639: KAFKA-14462; [12/N] Add GroupMetadataManager and ConsumerGroup

2023-05-23 Thread via GitHub
jolshan commented on code in PR #13639: URL: https://github.com/apache/kafka/pull/13639#discussion_r1203083017 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -0,0 +1,859 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] jolshan commented on a diff in pull request #13639: KAFKA-14462; [12/N] Add GroupMetadataManager and ConsumerGroup

2023-05-23 Thread via GitHub
jolshan commented on code in PR #13639: URL: https://github.com/apache/kafka/pull/13639#discussion_r1203079411 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -0,0 +1,859 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] jolshan commented on a diff in pull request #13639: KAFKA-14462; [12/N] Add GroupMetadataManager and ConsumerGroup

2023-05-23 Thread via GitHub
jolshan commented on code in PR #13639: URL: https://github.com/apache/kafka/pull/13639#discussion_r1203077539 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -0,0 +1,859 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] clayburn commented on pull request #13676: MINOR: Capture build scans on ge.apache.org to benefit from deep build insights

2023-05-23 Thread via GitHub
clayburn commented on PR #13676: URL: https://github.com/apache/kafka/pull/13676#issuecomment-1560105054 I updated this PR to the latest version of Gradle Enterprise Gradle Plugin. Is there anything else I need to do to get this PR integrated? -- This is an automated message from the

[GitHub] [kafka] gharris1727 commented on a diff in pull request #13165: KAFKA-14654: Connector classes should statically initialize with plugin classloader

2023-05-23 Thread via GitHub
gharris1727 commented on code in PR #13165: URL: https://github.com/apache/kafka/pull/13165#discussion_r1202962972 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/isolation/LoaderSwap.java: ## @@ -24,13 +24,32 @@ public class LoaderSwap implements

[GitHub] [kafka] C0urante commented on a diff in pull request #13165: KAFKA-14654: Connector classes should statically initialize with plugin classloader

2023-05-23 Thread via GitHub
C0urante commented on code in PR #13165: URL: https://github.com/apache/kafka/pull/13165#discussion_r1202903632 ## connect/runtime/src/main/java/org/apache/kafka/connect/cli/AbstractConnectCli.java: ## @@ -119,36 +120,37 @@ public Connect startConnect(Map workerProps,

[GitHub] [kafka] divijvaidya commented on pull request #13749: KAFKA-15016: Update LICENSE-binary file

2023-05-23 Thread via GitHub
divijvaidya commented on PR #13749: URL: https://github.com/apache/kafka/pull/13749#issuecomment-1559996120 `bcpkix` is still missing https://github.com/apache/kafka/blob/trunk/gradle/dependencies.gradle#L61. Do you happen to know why? -- This is an automated message from the Apache Git

[GitHub] [kafka] jolshan commented on a diff in pull request #13639: KAFKA-14462; [12/N] Add GroupMetadataManager and ConsumerGroup

2023-05-23 Thread via GitHub
jolshan commented on code in PR #13639: URL: https://github.com/apache/kafka/pull/13639#discussion_r1202846585 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -0,0 +1,859 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] jolshan commented on a diff in pull request #13639: KAFKA-14462; [12/N] Add GroupMetadataManager and ConsumerGroup

2023-05-23 Thread via GitHub
jolshan commented on code in PR #13639: URL: https://github.com/apache/kafka/pull/13639#discussion_r1202846284 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -0,0 +1,859 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] jolshan commented on a diff in pull request #13639: KAFKA-14462; [12/N] Add GroupMetadataManager and ConsumerGroup

2023-05-23 Thread via GitHub
jolshan commented on code in PR #13639: URL: https://github.com/apache/kafka/pull/13639#discussion_r1202840230 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -0,0 +1,859 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] jolshan commented on a diff in pull request #13639: KAFKA-14462; [12/N] Add GroupMetadataManager and ConsumerGroup

2023-05-23 Thread via GitHub
jolshan commented on code in PR #13639: URL: https://github.com/apache/kafka/pull/13639#discussion_r1202837929 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -0,0 +1,859 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] gharris1727 commented on a diff in pull request #13733: KAFKA-13337: fix of possible java.nio.file.AccessDeniedException during Connect plugin directory scan

2023-05-23 Thread via GitHub
gharris1727 commented on code in PR #13733: URL: https://github.com/apache/kafka/pull/13733#discussion_r1202806994 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/isolation/DelegatingClassLoaderTest.java: ## @@ -22,6 +22,7 @@ import

[GitHub] [kafka] gharris1727 commented on pull request #9910: KAFKA-10877

2023-05-23 Thread via GitHub
gharris1727 commented on PR #9910: URL: https://github.com/apache/kafka/pull/9910#issuecomment-1559871005 @smccauliff Are you still interested in making this change? I think this is still affecting users and wasting CPU cycles :) -- This is an automated message from the Apache Git

[GitHub] [kafka] C0urante commented on a diff in pull request #13465: KAFKA-14368: Connect offset write REST API

2023-05-23 Thread via GitHub
C0urante commented on code in PR #13465: URL: https://github.com/apache/kafka/pull/13465#discussion_r1202738629 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/Worker.java: ## @@ -1247,6 +1257,257 @@ void sourceConnectorOffsets(String connName,

[jira] [Commented] (KAFKA-15018) Potential tombstone offsets corruption for exactly-once source connectors

2023-05-23 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17725502#comment-17725502 ] Chris Egerton commented on KAFKA-15018: --- One possible fix for this could be to preemptively write

[jira] [Created] (KAFKA-15018) Potential tombstone offsets corruption for exactly-once source connectors

2023-05-23 Thread Chris Egerton (Jira)
Chris Egerton created KAFKA-15018: - Summary: Potential tombstone offsets corruption for exactly-once source connectors Key: KAFKA-15018 URL: https://issues.apache.org/jira/browse/KAFKA-15018 Project:

[GitHub] [kafka] cmccabe closed pull request #13686: MINOR: Create the MetadataNode classes to introspect MetadataImage

2023-05-23 Thread via GitHub
cmccabe closed pull request #13686: MINOR: Create the MetadataNode classes to introspect MetadataImage URL: https://github.com/apache/kafka/pull/13686 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka] C0urante commented on a diff in pull request #13465: KAFKA-14368: Connect offset write REST API

2023-05-23 Thread via GitHub
C0urante commented on code in PR #13465: URL: https://github.com/apache/kafka/pull/13465#discussion_r1202709620 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/Worker.java: ## @@ -1247,6 +1257,257 @@ void sourceConnectorOffsets(String connName,

[GitHub] [kafka] C0urante commented on a diff in pull request #13465: KAFKA-14368: Connect offset write REST API

2023-05-23 Thread via GitHub
C0urante commented on code in PR #13465: URL: https://github.com/apache/kafka/pull/13465#discussion_r1202694716 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/Worker.java: ## @@ -1235,6 +1244,246 @@ void sourceConnectorOffsets(String connName,

[GitHub] [kafka] yashmayya opened a new pull request, #13750: MINOR: Handle the config topic read timeout edge case in DistributedHerder's stopConnector method

2023-05-23 Thread via GitHub
yashmayya opened a new pull request, #13750: URL: https://github.com/apache/kafka/pull/13750 - Handle the config topic read timeout edge case in `DistributedHerder::stopConnector` - https://github.com/apache/kafka/pull/13465#discussion_r1200500990 ### Committer Checklist (excluded

[GitHub] [kafka] C0urante commented on a diff in pull request #13465: KAFKA-14368: Connect offset write REST API

2023-05-23 Thread via GitHub
C0urante commented on code in PR #13465: URL: https://github.com/apache/kafka/pull/13465#discussion_r1202684769 ## connect/runtime/src/main/java/org/apache/kafka/connect/util/SinkUtils.java: ## @@ -52,4 +53,82 @@ public static ConnectorOffsets

[GitHub] [kafka] C0urante commented on a diff in pull request #13465: KAFKA-14368: Connect offset write REST API

2023-05-23 Thread via GitHub
C0urante commented on code in PR #13465: URL: https://github.com/apache/kafka/pull/13465#discussion_r1202678391 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/DistributedHerder.java: ## @@ -1528,6 +1539,80 @@ public void connectorOffsets(String

[GitHub] [kafka] C0urante commented on a diff in pull request #13465: KAFKA-14368: Connect offset write REST API

2023-05-23 Thread via GitHub
C0urante commented on code in PR #13465: URL: https://github.com/apache/kafka/pull/13465#discussion_r1202644196 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/DistributedHerder.java: ## @@ -1528,6 +1539,80 @@ public void connectorOffsets(String

[GitHub] [kafka] KarboniteKream commented on pull request #13679: KAFKA-14291: KRaft controller should return right finalized features in ApiVersionResponse

2023-05-23 Thread via GitHub
KarboniteKream commented on PR #13679: URL: https://github.com/apache/kafka/pull/13679#issuecomment-1559681643 This PR seems to have introduced a regression (confirmed using bisect). In a simple setup of two controllers using `config/kraft/controller.properties`, after the leader is shut

[GitHub] [kafka] mimaison opened a new pull request, #13749: KAFKA-15016: Update LICENSE-binary file

2023-05-23 Thread via GitHub
mimaison opened a new pull request, #13749: URL: https://github.com/apache/kafka/pull/13749 The file was getting a bit out of sync with the actual dependencies we ship. Also the [process we follow each release](https://issues.apache.org/jira/browse/KAFKA-12622) catches missing licenses

[GitHub] [kafka] mumrah merged pull request #13741: KAFKA-15009: Handle errors while migrating ACL metadata from snapshot to Zk during DUAL_WRITE mode.

2023-05-23 Thread via GitHub
mumrah merged PR #13741: URL: https://github.com/apache/kafka/pull/13741 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Updated] (KAFKA-15009) New ACLs are not written to ZK during migration

2023-05-23 Thread David Arthur (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15009?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Arthur updated KAFKA-15009: - Component/s: kraft > New ACLs are not written to ZK during migration >

[GitHub] [kafka] mumrah commented on pull request #13741: KAFKA-15009: Handle errors while migrating ACL metadata from snapshot to Zk during DUAL_WRITE mode.

2023-05-23 Thread via GitHub
mumrah commented on PR #13741: URL: https://github.com/apache/kafka/pull/13741#issuecomment-1559562400 Ok, I split out the client quotas work into KAFKA-15017 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Created] (KAFKA-15017) New ClientQuotas are not written to ZK from snapshot

2023-05-23 Thread David Arthur (Jira)
David Arthur created KAFKA-15017: Summary: New ClientQuotas are not written to ZK from snapshot Key: KAFKA-15017 URL: https://issues.apache.org/jira/browse/KAFKA-15017 Project: Kafka Issue

[jira] [Updated] (KAFKA-15009) New ACLs are not written to ZK during migration

2023-05-23 Thread David Arthur (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15009?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Arthur updated KAFKA-15009: - Description: While handling snapshots in dual-write mode, we are missing the logic to detect

[jira] [Assigned] (KAFKA-15009) New ACLs are not written to ZK during migration

2023-05-23 Thread David Arthur (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15009?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Arthur reassigned KAFKA-15009: Assignee: Akhilesh Chaganti (was: David Arthur) > New ACLs are not written to ZK during

[jira] [Assigned] (KAFKA-15009) New ACLs are not written to ZK during migration

2023-05-23 Thread David Arthur (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15009?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Arthur reassigned KAFKA-15009: Assignee: David Arthur (was: Akhilesh Chaganti) > New ACLs are not written to ZK during

[jira] [Updated] (KAFKA-15009) New ACLs are not written to ZK during migration

2023-05-23 Thread David Arthur (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15009?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Arthur updated KAFKA-15009: - Summary: New ACLs are not written to ZK during migration (was: ClientQuotas and ACLs are not

[GitHub] [kafka] krespo opened a new pull request, #13748: [BUGFIX] Bugfixed in KAFKA-8713, but it doesn't work properly.

2023-05-23 Thread via GitHub
krespo opened a new pull request, #13748: URL: https://github.com/apache/kafka/pull/13748 Through the ticket ["KAFKA-8713"](https://issues.apache.org/jira/browse/KAFKA-8713), a bug that always outputs "default value" when JsonConverter is a nullable schema was fixed. After

[GitHub] [kafka] dajac commented on a diff in pull request #13747: MINOR: Fix ListOffsetsRequestTest.testResponseIncludesLeaderEpoch

2023-05-23 Thread via GitHub
dajac commented on code in PR #13747: URL: https://github.com/apache/kafka/pull/13747#discussion_r1202331207 ## core/src/test/scala/unit/kafka/server/ListOffsetsRequestTest.scala: ## @@ -192,7 +192,7 @@ class ListOffsetsRequestTest extends BaseRequestTest {

[GitHub] [kafka] dajac opened a new pull request, #13747: MINOR: Fix ListOffsetsRequestTest.testResponseIncludesLeaderEpoch

2023-05-23 Thread via GitHub
dajac opened a new pull request, #13747: URL: https://github.com/apache/kafka/pull/13747 Fix flaky ListOffsetsRequestTest.testResponseIncludesLeaderEpoch. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage

[GitHub] [kafka] dajac commented on pull request #13535: KAFKA-9579 Fetch implementation for records in the remote storage through a specific purgatory.

2023-05-23 Thread via GitHub
dajac commented on PR #13535: URL: https://github.com/apache/kafka/pull/13535#issuecomment-1559262765 @satishd Weird... It fails all the time on my laptop. ``` Gradle Test Run :core:test > Gradle Test Executor 9 > ListOffsetsRequestTest > testResponseIncludesLeaderEpoch() FAILED

[GitHub] [kafka] sanjanagoyal opened a new pull request, #13746: removed recreation of partition to fix partitions having uneven data disctribution

2023-05-23 Thread via GitHub
sanjanagoyal opened a new pull request, #13746: URL: https://github.com/apache/kafka/pull/13746 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of

[GitHub] [kafka] atu-sharm commented on pull request #13745: KAFKA-15015: Explicit on reload4j version

2023-05-23 Thread via GitHub
atu-sharm commented on PR #13745: URL: https://github.com/apache/kafka/pull/13745#issuecomment-1559239546 Output: ``` reload4j-1.2.25.jar slf4j-reload4j-1.7.36.jar ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] showuon commented on pull request #13745: KAFKA-15015: Explicit on reload4j version

2023-05-23 Thread via GitHub
showuon commented on PR #13745: URL: https://github.com/apache/kafka/pull/13745#issuecomment-1559220469 @atu-sharm , could you run these commands to show what's the output of the lib folder for reload library? ``` // build the binary artifacts $ ./gradlewAll releaseTarGz //

[GitHub] [kafka] satishd commented on a diff in pull request #13535: KAFKA-9579 Fetch implementation for records in the remote storage through a specific purgatory.

2023-05-23 Thread via GitHub
satishd commented on code in PR #13535: URL: https://github.com/apache/kafka/pull/13535#discussion_r1184873142 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -670,6 +875,14 @@ public void close() { } catch (InterruptedException e) {

[GitHub] [kafka] satishd commented on pull request #13535: KAFKA-9579 Fetch implementation for records in the remote storage through a specific purgatory.

2023-05-23 Thread via GitHub
satishd commented on PR #13535: URL: https://github.com/apache/kafka/pull/13535#issuecomment-1559216261 @dajac It is passed locally on my laptop. ``` Gradle Test Run :core:test > Gradle Test Executor 65 > ListOffsetsRequestTest >

[jira] [Assigned] (KAFKA-15015) Binaries contain 2 versions of reload4j

2023-05-23 Thread Atul Sharma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15015?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Atul Sharma reassigned KAFKA-15015: --- Assignee: Atul Sharma > Binaries contain 2 versions of reload4j >

[GitHub] [kafka] atu-sharm commented on pull request #13745: KAFKA-15015: Explicit on reload4j version

2023-05-23 Thread via GitHub
atu-sharm commented on PR #13745: URL: https://github.com/apache/kafka/pull/13745#issuecomment-1559203084 @showuon @mimaison can you review? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Commented] (KAFKA-15015) Binaries contain 2 versions of reload4j

2023-05-23 Thread Atul Sharma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17725390#comment-17725390 ] Atul Sharma commented on KAFKA-15015: - [~mimaison] [~showuon] raised PR [GitHub Pull Request

[GitHub] [kafka] atu-sharm opened a new pull request, #13745: KAFKA-15015: Explicit on reload4j version

2023-05-23 Thread via GitHub
atu-sharm opened a new pull request, #13745: URL: https://github.com/apache/kafka/pull/13745 Defining a specific version for reload4j -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] yashmayya commented on a diff in pull request #13465: KAFKA-14368: Connect offset write REST API

2023-05-23 Thread via GitHub
yashmayya commented on code in PR #13465: URL: https://github.com/apache/kafka/pull/13465#discussion_r1200530069 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/DistributedHerder.java: ## @@ -1528,6 +1539,80 @@ public void connectorOffsets(String

[GitHub] [kafka] divijvaidya commented on pull request #13662: MINOR: Upgrade Jackson dependencies to version 2.15.0

2023-05-23 Thread via GitHub
divijvaidya commented on PR #13662: URL: https://github.com/apache/kafka/pull/13662#issuecomment-1559122983 I found today that there is another change that needs to make it in this PR. We need to update the LICENSE file with the correct version at

[jira] [Commented] (KAFKA-7497) Kafka Streams should support self-join on streams

2023-05-23 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17725357#comment-17725357 ] Matthias J. Sax commented on KAFKA-7497: Seems to be fixed. Cf

[jira] [Resolved] (KAFKA-7497) Kafka Streams should support self-join on streams

2023-05-23 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7497?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax resolved KAFKA-7497. Resolution: Fixed > Kafka Streams should support self-join on streams >

[GitHub] [kafka] mimaison commented on pull request #13744: MINOR: update 3.4.1 licence

2023-05-23 Thread via GitHub
mimaison commented on PR #13744: URL: https://github.com/apache/kafka/pull/13744#issuecomment-1559077621 @divijvaidya For the "audit" I filled https://issues.apache.org/jira/browse/KAFKA-15016 yesterday. The validation we use to check what the LICENSE file should include is documented

[jira] [Commented] (KAFKA-14173) TopologyTestDriver does not use mock wall clock time when sending test records

2023-05-23 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17725356#comment-17725356 ] Matthias J. Sax commented on KAFKA-14173: - Just discovering this ticket. I guess you would need

[jira] [Resolved] (KAFKA-14173) TopologyTestDriver does not use mock wall clock time when sending test records

2023-05-23 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax resolved KAFKA-14173. - Resolution: Not A Problem > TopologyTestDriver does not use mock wall clock time when

[jira] [Updated] (KAFKA-10575) StateRestoreListener#onRestoreEnd should always be triggered

2023-05-23 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10575?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-10575: Labels: kip (was: ) > StateRestoreListener#onRestoreEnd should always be triggered >

[jira] [Updated] (KAFKA-10575) StateRestoreListener#onRestoreEnd should always be triggered

2023-05-23 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10575?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-10575: Description: Part of KIP-869:

[jira] [Resolved] (KAFKA-10575) StateRestoreListener#onRestoreEnd should always be triggered

2023-05-23 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10575?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax resolved KAFKA-10575. - Fix Version/s: 3.5.0 Resolution: Fixed > StateRestoreListener#onRestoreEnd

[jira] [Assigned] (KAFKA-10575) StateRestoreListener#onRestoreEnd should always be triggered

2023-05-23 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10575?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax reassigned KAFKA-10575: --- Assignee: Guozhang Wang (was: highluck) > StateRestoreListener#onRestoreEnd

[GitHub] [kafka] divijvaidya commented on pull request #13744: MINOR: update 3.4.1 licence

2023-05-23 Thread via GitHub
divijvaidya commented on PR #13744: URL: https://github.com/apache/kafka/pull/13744#issuecomment-1559041622 Hey @showuon I know that it is unrelated to your specific change but we seem to be missing adding license for a bunch of dependencies such as `bcpkix` and `jaxb`. Shall we do an

[GitHub] [kafka] machi1990 commented on a diff in pull request #13744: MINOR: update 3.4.1 licence

2023-05-23 Thread via GitHub
machi1990 commented on code in PR #13744: URL: https://github.com/apache/kafka/pull/13744#discussion_r1202034297 ## LICENSE-binary: ## @@ -205,53 +205,54 @@ This project bundles some components that are also licensed under the Apache License Version 2.0:

[GitHub] [kafka] showuon commented on a diff in pull request #13744: MINOR: update 3.4.1 licence

2023-05-23 Thread via GitHub
showuon commented on code in PR #13744: URL: https://github.com/apache/kafka/pull/13744#discussion_r1202033613 ## LICENSE-binary: ## @@ -205,53 +205,54 @@ This project bundles some components that are also licensed under the Apache License Version 2.0:

[GitHub] [kafka] machi1990 commented on a diff in pull request #13744: MINOR: update 3.4.1 licence

2023-05-23 Thread via GitHub
machi1990 commented on code in PR #13744: URL: https://github.com/apache/kafka/pull/13744#discussion_r1202030847 ## LICENSE-binary: ## @@ -205,53 +205,54 @@ This project bundles some components that are also licensed under the Apache License Version 2.0:

[jira] [Assigned] (KAFKA-14539) Simplify StreamsMetadataState by replacing the Cluster metadata with partition info map

2023-05-23 Thread Danica Fine (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14539?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danica Fine reassigned KAFKA-14539: --- Assignee: Danica Fine > Simplify StreamsMetadataState by replacing the Cluster metadata

[GitHub] [kafka] showuon commented on pull request #13744: MINOR: update 3.4.1 licence

2023-05-23 Thread via GitHub
showuon commented on PR #13744: URL: https://github.com/apache/kafka/pull/13744#issuecomment-1559011060 @mimaison , call for review. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] showuon opened a new pull request, #13744: MINOR: update 3.4.1 licence

2023-05-23 Thread via GitHub
showuon opened a new pull request, #13744: URL: https://github.com/apache/kafka/pull/13744 update v3.4.1 licence ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify

[GitHub] [kafka] dajac merged pull request #13708: KAFKA-14500; [4/N] Add Timer interface

2023-05-23 Thread via GitHub
dajac merged PR #13708: URL: https://github.com/apache/kafka/pull/13708 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] mimaison closed pull request #13581: A document on the current usage of Kafka project is added

2023-05-23 Thread via GitHub
mimaison closed pull request #13581: A document on the current usage of Kafka project is added URL: https://github.com/apache/kafka/pull/13581 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] mimaison commented on pull request #13581: A document on the current usage of Kafka project is added

2023-05-23 Thread via GitHub
mimaison commented on PR #13581: URL: https://github.com/apache/kafka/pull/13581#issuecomment-1558820436 Because it's opened against the 3.5 branch, this PR is currently preventing us to add the 3.5 branch to the Apache Kafka Jenkins job. So I'll close the PR temporarily while I fix the

[GitHub] [kafka] dajac merged pull request #13704: KAFKA-14500; [3/N] add GroupMetadataKey/Value record helpers

2023-05-23 Thread via GitHub
dajac merged PR #13704: URL: https://github.com/apache/kafka/pull/13704 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (KAFKA-15015) Binaries contain 2 versions of reload4j

2023-05-23 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17725278#comment-17725278 ] Mickael Maison commented on KAFKA-15015: I don't think it's a blocker for 3.4.1 or 3.5.0 so we

[GitHub] [kafka] akatona84 commented on pull request #13733: KAFKA-13337: fix of possible java.nio.file.AccessDeniedException during Connect plugin directory scan

2023-05-23 Thread via GitHub
akatona84 commented on PR #13733: URL: https://github.com/apache/kafka/pull/13733#issuecomment-1558629671 > Is there any way to decide if a specific file/dir is meant to be a plugin? currently the code is only checking whether it is a dir or the extension is zip, jar or class. Yet for an

[GitHub] [kafka] dajac commented on pull request #13535: KAFKA-9579 Fetch implementation for records in the remote storage through a specific purgatory.

2023-05-23 Thread via GitHub
dajac commented on PR #13535: URL: https://github.com/apache/kafka/pull/13535#issuecomment-1558604752 @satishd `testResponseIncludesLeaderEpoch` fails locally. Does it pass for you? It does not seem to be related to slow CI. -- This is an automated message from the Apache Git Service. To

  1   2   >