hudeqi commented on PR #13888:
URL: https://github.com/apache/kafka/pull/13888#issuecomment-1600053247
> @hudeqi I'm using a tool called
[typos](https://github.com/crate-ci/typos). And it can be integrated with
GitHub Actions. But I'm sure if it's a good practice to intergrate with repo.
xiaocairush commented on PR #13888:
URL: https://github.com/apache/kafka/pull/13888#issuecomment-1600049673
@hudeqi I'm using a tool called [typos](https://github.com/crate-ci/typos).
And it can be integrated with GitHub Actions. But I'm sure if it's a good
practice to intergrate with
jeffkbkim commented on code in PR #13880:
URL: https://github.com/apache/kafka/pull/13880#discussion_r1236242369
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/RecordSerDe.java:
##
@@ -0,0 +1,161 @@
+/*
Review Comment:
nit: Other serdes follow "Serde"
xiaocairush commented on PR #13884:
URL: https://github.com/apache/kafka/pull/13884#issuecomment-1600037542
test this please
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
xiaocairush commented on PR #13883:
URL: https://github.com/apache/kafka/pull/13883#issuecomment-1600024221
Besides, how do you ensure there is not some people work on the same issue
simultaneously in jira when the issue is not assigned. Seems like I need a jira
account to assign issue to
showuon commented on PR #13665:
URL: https://github.com/apache/kafka/pull/13665#issuecomment-167864
> offsets commits are happening somewhere else and that's via the
producer.sendOffsetsToTransaction(..) e.g
Oh, EOS case! I didn't consider it, sorry!
Hmm... if there is EOS
xiaocairush commented on PR #13883:
URL: https://github.com/apache/kafka/pull/13883#issuecomment-164067
@divijvaidya I'm using a tool called
[typos](https://github.com/crate-ci/typos). And it can be integrated with
GitHub Actions. But I don't sure if it's a good practice to intergrate
showuon commented on PR #13850:
URL: https://github.com/apache/kafka/pull/13850#issuecomment-151668
@divijvaidya , sorry, which commits should I check?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
hudeqi commented on PR #13888:
URL: https://github.com/apache/kafka/pull/13888#issuecomment-1599966481
Seeing that you have found so many typos, is there any convenient way? Can
you share it so that we can scan globally and fix it all at once? @xiaocairush
--
This is an automated
lukestephenson-zendesk commented on code in PR #13447:
URL: https://github.com/apache/kafka/pull/13447#discussion_r1236164778
##
clients/src/main/java/org/apache/kafka/clients/Metadata.java:
##
@@ -399,8 +399,13 @@ private Optional
updateLatestMetadata(
//
ijuma commented on code in PR #13582:
URL: https://github.com/apache/kafka/pull/13582#discussion_r1236054069
##
clients/src/main/java/org/apache/kafka/common/record/DefaultRecord.java:
##
@@ -431,7 +431,7 @@ private static void skipBytes(InputStream in, int
bytesToSkip) throws
ijuma commented on code in PR #13582:
URL: https://github.com/apache/kafka/pull/13582#discussion_r1236050527
##
clients/src/main/java/org/apache/kafka/common/serialization/ShortDeserializer.java:
##
@@ -34,7 +34,7 @@ public Short deserialize(String topic, byte[] data) {
[
https://issues.apache.org/jira/browse/KAFKA-15108?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tomonari Yamashita updated KAFKA-15108:
---
Description:
[Problem]
- task.timeout.ms does not work when TimeoutException is
[
https://issues.apache.org/jira/browse/KAFKA-15108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17735476#comment-17735476
]
Matthias J. Sax commented on KAFKA-15108:
-
There are a few cases for which we cannot handle a
lmr3796 commented on code in PR #13187:
URL: https://github.com/apache/kafka/pull/13187#discussion_r1235962927
##
core/src/main/scala/kafka/cluster/Partition.scala:
##
@@ -1046,10 +1046,14 @@ class Partition(val topicPartition: TopicPartition,
partitionState match {
divijvaidya commented on code in PR #13187:
URL: https://github.com/apache/kafka/pull/13187#discussion_r1235943898
##
core/src/main/scala/kafka/cluster/Partition.scala:
##
@@ -1046,10 +1046,14 @@ class Partition(val topicPartition: TopicPartition,
partitionState
jolshan commented on PR #13787:
URL: https://github.com/apache/kafka/pull/13787#issuecomment-1599609852
I'm getting tripped up on some flaky tests -- namely
jolshan commented on code in PR #13798:
URL: https://github.com/apache/kafka/pull/13798#discussion_r1235928525
##
core/src/main/scala/kafka/server/AddPartitionsToTxnManager.scala:
##
@@ -42,13 +50,19 @@ class AddPartitionsToTxnManager(config: KafkaConfig,
client:
divijvaidya commented on code in PR #13798:
URL: https://github.com/apache/kafka/pull/13798#discussion_r1235924422
##
core/src/main/scala/kafka/server/AddPartitionsToTxnManager.scala:
##
@@ -42,13 +50,19 @@ class AddPartitionsToTxnManager(config: KafkaConfig,
client:
jolshan commented on code in PR #13421:
URL: https://github.com/apache/kafka/pull/13421#discussion_r1235920177
##
core/src/test/scala/unit/kafka/server/ReplicaAlterLogDirsThreadTest.scala:
##
@@ -196,6 +201,110 @@ class ReplicaAlterLogDirsThreadTest {
assertEquals(0,
jolshan commented on code in PR #13421:
URL: https://github.com/apache/kafka/pull/13421#discussion_r1235919152
##
core/src/main/scala/kafka/server/AbstractFetcherThread.scala:
##
@@ -706,6 +706,8 @@ abstract class AbstractFetcherThread(name: String,
*- the request
divijvaidya commented on PR #13876:
URL: https://github.com/apache/kafka/pull/13876#issuecomment-1599595596
1. We might end up breaking customer's application code for exception
handling with this change. What is our plan to prevent the inadvertent impact
to customer's code on upgrade?
jolshan commented on code in PR #13876:
URL: https://github.com/apache/kafka/pull/13876#discussion_r1235917215
##
clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java:
##
@@ -1013,16 +1013,8 @@ private void maybeFailWithError() {
if
jolshan commented on PR #13876:
URL: https://github.com/apache/kafka/pull/13876#issuecomment-1599593794
Thanks @lucasbru -- just had one question. Everything else looks pretty good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
divijvaidya commented on code in PR #13881:
URL: https://github.com/apache/kafka/pull/13881#discussion_r1235909656
##
clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java:
##
@@ -94,8 +94,8 @@ public class ProducerConfig extends AbstractConfig {
divijvaidya commented on PR #13883:
URL: https://github.com/apache/kafka/pull/13883#issuecomment-1599501486
Also, @xiaocairush is it possible to automate testing for these spell typos
in checkstyle of some other build plugin? What tool did you use to find these?
--
This is an automated
divijvaidya merged PR #13888:
URL: https://github.com/apache/kafka/pull/13888
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
divijvaidya commented on PR #13888:
URL: https://github.com/apache/kafka/pull/13888#issuecomment-1599495288
Unrelated test failures:
```
[Build / JDK 11 and Scala 2.13 /
[
https://issues.apache.org/jira/browse/KAFKA-15053?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Egerton reassigned KAFKA-15053:
-
Assignee: Bo Gao
> Regression for security.protocol validation starting from 3.3.0
>
jeffkbkim commented on code in PR #13870:
URL: https://github.com/apache/kafka/pull/13870#discussion_r1235823024
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -874,4 +1045,1265 @@ public void replay(
jeffkbkim commented on code in PR #13870:
URL: https://github.com/apache/kafka/pull/13870#discussion_r1235822238
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -874,4 +1045,1265 @@ public void replay(
divijvaidya merged PR #13886:
URL: https://github.com/apache/kafka/pull/13886
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
divijvaidya merged PR #13887:
URL: https://github.com/apache/kafka/pull/13887
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
jeffkbkim commented on code in PR #13870:
URL: https://github.com/apache/kafka/pull/13870#discussion_r1235818207
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -874,4 +1045,1265 @@ public void replay(
divijvaidya commented on PR #13883:
URL: https://github.com/apache/kafka/pull/13883#issuecomment-1599479499
please rebase with trunk, #13882 has been merged
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
divijvaidya merged PR #13882:
URL: https://github.com/apache/kafka/pull/13882
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
jeffkbkim commented on code in PR #13870:
URL: https://github.com/apache/kafka/pull/13870#discussion_r1235813521
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -874,4 +1045,1265 @@ public void replay(
jolshan commented on code in PR #13876:
URL: https://github.com/apache/kafka/pull/13876#discussion_r1235809528
##
clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java:
##
@@ -1013,16 +1013,8 @@ private void maybeFailWithError() {
if
jeffkbkim commented on code in PR #13870:
URL: https://github.com/apache/kafka/pull/13870#discussion_r1235808438
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -874,4 +1045,1265 @@ public void replay(
divijvaidya commented on code in PR #13868:
URL: https://github.com/apache/kafka/pull/13868#discussion_r1235807347
##
core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala:
##
@@ -75,31 +75,31 @@ import org.mockito.invocation.InvocationOnMock
import
jolshan commented on code in PR #13868:
URL: https://github.com/apache/kafka/pull/13868#discussion_r1235803368
##
core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala:
##
@@ -75,31 +75,31 @@ import org.mockito.invocation.InvocationOnMock
import
C0urante merged PR #13885:
URL: https://github.com/apache/kafka/pull/13885
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
jolshan commented on code in PR #13812:
URL: https://github.com/apache/kafka/pull/13812#discussion_r1235772593
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorService.java:
##
@@ -0,0 +1,581 @@
+/*
+ * Licensed to the Apache Software
jolshan commented on code in PR #13812:
URL: https://github.com/apache/kafka/pull/13812#discussion_r1235773175
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorService.java:
##
@@ -0,0 +1,581 @@
+/*
+ * Licensed to the Apache Software
jeffkbkim commented on code in PR #13870:
URL: https://github.com/apache/kafka/pull/13870#discussion_r1235752587
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -874,4 +1045,1265 @@ public void replay(
jeffkbkim commented on code in PR #13870:
URL: https://github.com/apache/kafka/pull/13870#discussion_r1235733198
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -874,4 +1045,1265 @@ public void replay(
jeffkbkim commented on code in PR #13870:
URL: https://github.com/apache/kafka/pull/13870#discussion_r1235734010
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -874,4 +1045,1265 @@ public void replay(
dajac commented on code in PR #13812:
URL: https://github.com/apache/kafka/pull/13812#discussion_r1235696555
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorService.java:
##
@@ -0,0 +1,581 @@
+/*
+ * Licensed to the Apache Software
dajac commented on code in PR #13812:
URL: https://github.com/apache/kafka/pull/13812#discussion_r1235694270
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorService.java:
##
@@ -0,0 +1,581 @@
+/*
+ * Licensed to the Apache Software
dajac commented on code in PR #13812:
URL: https://github.com/apache/kafka/pull/13812#discussion_r1235693242
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorService.java:
##
@@ -0,0 +1,581 @@
+/*
+ * Licensed to the Apache Software
mumrah commented on PR #13890:
URL: https://github.com/apache/kafka/pull/13890#issuecomment-1599310423
This system test was failing on trunk, with this patch it's passing again.
```
SESSION REPORT
divijvaidya commented on PR #13850:
URL: https://github.com/apache/kafka/pull/13850#issuecomment-1599308163
Thank you @showuon @satishd for your review so far. I have added another
commit to de-flake some tests, improved thread safety for `Entry`, added new
unit tests and added log
jeffkbkim commented on code in PR #13870:
URL: https://github.com/apache/kafka/pull/13870#discussion_r1235653740
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -171,70 +260,152 @@ GroupMetadataManager build() {
/**
jolshan commented on code in PR #13812:
URL: https://github.com/apache/kafka/pull/13812#discussion_r1235651106
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorService.java:
##
@@ -0,0 +1,581 @@
+/*
+ * Licensed to the Apache Software
jolshan commented on code in PR #13812:
URL: https://github.com/apache/kafka/pull/13812#discussion_r1235650169
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorService.java:
##
@@ -0,0 +1,581 @@
+/*
+ * Licensed to the Apache Software
jolshan commented on code in PR #13812:
URL: https://github.com/apache/kafka/pull/13812#discussion_r1235640808
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorService.java:
##
@@ -0,0 +1,581 @@
+/*
+ * Licensed to the Apache Software
jolshan commented on code in PR #13812:
URL: https://github.com/apache/kafka/pull/13812#discussion_r1235639793
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorService.java:
##
@@ -0,0 +1,581 @@
+/*
+ * Licensed to the Apache Software
ijuma merged PR #13840:
URL: https://github.com/apache/kafka/pull/13840
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
ijuma commented on PR #13840:
URL: https://github.com/apache/kafka/pull/13840#issuecomment-1599220710
JDK 11 build passed, there were two unrelated failures outside of that:
> Build / JDK 17 and Scala 2.13 / testMaxConnectionsPerIp() –
kafka.network.SocketServerTest
15s
Build /
[
https://issues.apache.org/jira/browse/KAFKA-15109?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Arthur updated KAFKA-15109:
-
Affects Version/s: 3.6.0
(was: 3.5.0)
> ISR shrink/expand issues on
clayburn commented on PR #13676:
URL: https://github.com/apache/kafka/pull/13676#issuecomment-1599144163
@ijuma - good question. I do not have an answer myself, but I can get in
touch with those involved in the agreement between ASF and Gradle and get back
to you on that case.
--
This
wcarlson5 commented on code in PR #13878:
URL: https://github.com/apache/kafka/pull/13878#discussion_r1235507430
##
streams/src/test/java/org/apache/kafka/streams/state/internals/RocksDBTimeOrderedKeyValueBufferTest.java:
##
@@ -32,31 +32,28 @@
import
wcarlson5 commented on code in PR #13878:
URL: https://github.com/apache/kafka/pull/13878#discussion_r1235506750
##
streams/src/test/java/org/apache/kafka/streams/state/internals/RocksDBTimeOrderedKeyValueBufferTest.java:
##
@@ -32,31 +32,28 @@
import
[
https://issues.apache.org/jira/browse/KAFKA-15109?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Arthur updated KAFKA-15109:
-
Summary: ISR shrink/expand issues on ZK brokers during migration (was: ISR
not expanding on ZK
[
https://issues.apache.org/jira/browse/KAFKA-15109?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Arthur updated KAFKA-15109:
-
Description:
KAFKA-15021 introduced a new controller behavior that avoids increasing the
jeffkbkim commented on code in PR #13870:
URL: https://github.com/apache/kafka/pull/13870#discussion_r1235497178
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -171,70 +260,152 @@ GroupMetadataManager build() {
/**
David Arthur created KAFKA-15109:
Summary: ISR not expanding on ZK brokers during migration
Key: KAFKA-15109
URL: https://issues.apache.org/jira/browse/KAFKA-15109
Project: Kafka
Issue Type:
mimaison commented on PR #13260:
URL: https://github.com/apache/kafka/pull/13260#issuecomment-1599080971
I've not setup the system tests recently. If the provided instructions are
not clear enough, let's discuss it on the dev mailing list. You can also open
Jiras for the issues you
[
https://issues.apache.org/jira/browse/KAFKA-14995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17735344#comment-17735344
]
ASF GitHub Bot commented on KAFKA-14995:
mimaison commented on PR #521:
URL:
mimaison commented on code in PR #13842:
URL: https://github.com/apache/kafka/pull/13842#discussion_r1235448777
##
refresh-collaborators.py:
##
@@ -0,0 +1,44 @@
+import os
Review Comment:
We need to have the Apache license at the top of the file.
##
C0urante commented on PR #13885:
URL: https://github.com/apache/kafka/pull/13885#issuecomment-1599050843
Thanks! Will merge pending CI build.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
xiaocairush commented on code in PR #13885:
URL: https://github.com/apache/kafka/pull/13885#discussion_r1235460018
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerConnector.java:
##
@@ -325,20 +325,20 @@ public boolean awaitShutdown(long timeoutMs) {
xiaocairush commented on code in PR #13885:
URL: https://github.com/apache/kafka/pull/13885#discussion_r1235458225
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerConnector.java:
##
@@ -271,12 +271,12 @@ public synchronized void shutdown() {
void
xiaocairush commented on code in PR #13885:
URL: https://github.com/apache/kafka/pull/13885#discussion_r1235458225
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerConnector.java:
##
@@ -271,12 +271,12 @@ public synchronized void shutdown() {
void
xiaocairush commented on code in PR #13885:
URL: https://github.com/apache/kafka/pull/13885#discussion_r1235455670
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerConnector.java:
##
@@ -325,20 +325,20 @@ public boolean awaitShutdown(long timeoutMs) {
jolshan commented on code in PR #13447:
URL: https://github.com/apache/kafka/pull/13447#discussion_r1235450231
##
clients/src/main/java/org/apache/kafka/clients/Metadata.java:
##
@@ -399,8 +399,13 @@ private Optional
updateLatestMetadata(
// Between the time
ijuma commented on PR #13676:
URL: https://github.com/apache/kafka/pull/13676#issuecomment-1599025907
As long as there are no restrictions due to this proprietary plugin, I am ok
with it. That is, others (including several companies) run these builds too. Is
there some official comms from
C0urante commented on code in PR #13885:
URL: https://github.com/apache/kafka/pull/13885#discussion_r1235437562
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerConnector.java:
##
@@ -325,20 +325,20 @@ public boolean awaitShutdown(long timeoutMs) {
}
jsancio commented on code in PR #13845:
URL: https://github.com/apache/kafka/pull/13845#discussion_r1235409277
##
raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java:
##
@@ -1017,7 +1017,16 @@ private FetchResponseData tryCompleteFetchRequest(
long
[
https://issues.apache.org/jira/browse/KAFKA-15075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17735327#comment-17735327
]
Elkhan Eminov commented on KAFKA-15075:
---
[~durban] hi there, is this up for grabs or are you
[
https://issues.apache.org/jira/browse/KAFKA-15087?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Jacot resolved KAFKA-15087.
-
Fix Version/s: 3.6.0
Reviewer: David Jacot
Resolution: Fixed
> Move
dajac merged PR #13856:
URL: https://github.com/apache/kafka/pull/13856
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
xiaocairush opened a new pull request, #13889:
URL: https://github.com/apache/kafka/pull/13889
*More detailed description of your change,
Fix typos for meatadata*
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify
mimaison commented on PR #13676:
URL: https://github.com/apache/kafka/pull/13676#issuecomment-1598926367
Thanks, this is a useful improvement. I was not aware the ASF had a GE
instance. The changes look good to me.
@ijuma any concerns?
--
This is an automated message from the
xiaocairush commented on PR #13888:
URL: https://github.com/apache/kafka/pull/13888#issuecomment-1598872442
> nice catches!
Thanks, there are still little typos in other module. I will commit in the
future after these PR is merged.
--
This is an automated message from the Apache
[
https://issues.apache.org/jira/browse/KAFKA-7739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17735299#comment-17735299
]
Jorge Esteban Quilcate Otoya commented on KAFKA-7739:
-
Thanks [~showuon]. My
[
https://issues.apache.org/jira/browse/KAFKA-14953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17735298#comment-17735298
]
Jorge Esteban Quilcate Otoya commented on KAFKA-14953:
--
[~showuon] I pressed add to
xiaocairush opened a new pull request, #13888:
URL: https://github.com/apache/kafka/pull/13888
*More detailed description of your change,
Fix typos for streams*
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify
xiaocairush opened a new pull request, #13887:
URL: https://github.com/apache/kafka/pull/13887
*More detailed description of your change,
Fix typos for server common*
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify
machi1990 commented on PR #13665:
URL: https://github.com/apache/kafka/pull/13665#issuecomment-1598817722
> @machi1990 , could you explain more about this:
>
> > The test neither calls commitSync, nor commitAsync which means that the
cache is never updated in [2] after initially set
xiaocairush opened a new pull request, #13886:
URL: https://github.com/apache/kafka/pull/13886
*More detailed description of your change,
Fix typos for group coordinator.*
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ]
xiaocairush opened a new pull request, #13885:
URL: https://github.com/apache/kafka/pull/13885
*More detailed description of your change,
Fix typos for connect*
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify
xiaocairush opened a new pull request, #13884:
URL: https://github.com/apache/kafka/pull/13884
*More detailed description of your change,
Fix typos for client
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test
[
https://issues.apache.org/jira/browse/KAFKA-14953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17735279#comment-17735279
]
Abhijeet Kumar commented on KAFKA-14953:
I am working on the unit tests and the PR should be
showuon commented on PR #13665:
URL: https://github.com/apache/kafka/pull/13665#issuecomment-1598673535
@machi1990 , could you explain more about this:
> The test neither calls commitSync, nor commitAsync which means that the
cache is never updated in [2] after initially set in [1].
drawxy commented on code in PR #13847:
URL: https://github.com/apache/kafka/pull/13847#discussion_r1235172202
##
core/src/main/scala/kafka/server/ReplicaManager.scala:
##
@@ -1808,7 +1809,10 @@ class ReplicaManager(val config: KafkaConfig,
// pause cleaning for
machi1990 commented on PR #13665:
URL: https://github.com/apache/kafka/pull/13665#issuecomment-1598653771
> @showuon I was looking onto this and after several local runs, I managed
to eliminate some flasky test and came up with the list of failures that are
only caused by this change. The
lukestephenson-zendesk commented on code in PR #13447:
URL: https://github.com/apache/kafka/pull/13447#discussion_r1235166042
##
clients/src/main/java/org/apache/kafka/clients/Metadata.java:
##
@@ -399,8 +399,13 @@ private Optional
updateLatestMetadata(
//
xiaocairush commented on PR #13883:
URL: https://github.com/apache/kafka/pull/13883#issuecomment-1598643673
sorry for that commit so many changes. Please review
https://github.com/apache/kafka/pull/13882 first. When that PR is merged then
the change will be only in doc module.
--
This
xiaocairush opened a new pull request, #13883:
URL: https://github.com/apache/kafka/pull/13883
*More detailed description of your change,
Fix some typos for documents
*Summary of testing strategy (including rationale)
### Committer Checklist (excluded from commit
1 - 100 of 136 matches
Mail list logo
