vamossagar12 commented on code in PR #13801:
URL: https://github.com/apache/kafka/pull/13801#discussion_r1240598727
##
connect/runtime/src/main/java/org/apache/kafka/connect/storage/ConnectorOffsetBackingStore.java:
##
@@ -279,10 +284,61 @@ public Future set(Map
values,
vamossagar12 commented on code in PR #13801:
URL: https://github.com/apache/kafka/pull/13801#discussion_r1240595738
##
connect/runtime/src/main/java/org/apache/kafka/connect/storage/ConnectorOffsetBackingStore.java:
##
@@ -279,8 +284,59 @@ public Future set(Map
values,
showuon merged PR #13665:
URL: https://github.com/apache/kafka/pull/13665
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
showuon commented on PR #13665:
URL: https://github.com/apache/kafka/pull/13665#issuecomment-1605261735
Failed tests are unrelated:
```
Build / JDK 11 and Scala 2.13 / kafka.zk.ZkMigrationIntegrationTest.[1]
Type=ZK, Name=testDualWriteScram, MetadataVersion=3.5-IV2,
Owen-CH-Leung commented on PR #13909:
URL: https://github.com/apache/kafka/pull/13909#issuecomment-1605257065
> Thanks for the PR. The change to `STATE_DIR_DOC` LGTM, but we cannot
change the actual default value.
>
> It's difficult to actually fix the ticket properly, because the
github-actions[bot] commented on PR #12883:
URL: https://github.com/apache/kafka/pull/12883#issuecomment-1605250889
This PR is being marked as stale since it has not had any activity in 90
days. If you would like to keep this PR alive, please ask a committer for
review. If the PR has
github-actions[bot] commented on PR #12888:
URL: https://github.com/apache/kafka/pull/12888#issuecomment-1605250884
This PR is being marked as stale since it has not had any activity in 90
days. If you would like to keep this PR alive, please ask a committer for
review. If the PR has
github-actions[bot] commented on PR #12894:
URL: https://github.com/apache/kafka/pull/12894#issuecomment-1605250881
This PR is being marked as stale since it has not had any activity in 90
days. If you would like to keep this PR alive, please ask a committer for
review. If the PR has
github-actions[bot] commented on PR #12907:
URL: https://github.com/apache/kafka/pull/12907#issuecomment-1605250876
This PR is being marked as stale since it has not had any activity in 90
days. If you would like to keep this PR alive, please ask a committer for
review. If the PR has
mjsax commented on code in PR #13909:
URL: https://github.com/apache/kafka/pull/13909#discussion_r1240487420
##
streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java:
##
@@ -794,7 +794,7 @@ public class StreamsConfig extends AbstractConfig {
[
https://issues.apache.org/jira/browse/KAFKA-15116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17736637#comment-17736637
]
Matthias J. Sax commented on KAFKA-15116:
-
> The complexity is that there is a requirement that
[
https://issues.apache.org/jira/browse/KAFKA-13988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17736629#comment-17736629
]
Ravindranath Kakarla commented on KAFKA-13988:
--
Created a PR,
[
https://issues.apache.org/jira/browse/KAFKA-13988?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ravindranath Kakarla reassigned KAFKA-13988:
Assignee: Ravindranath Kakarla (was: Justinwins)
> Mirrormaker 2
jeffkbkim commented on code in PR #13870:
URL: https://github.com/apache/kafka/pull/13870#discussion_r1240415098
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -874,4 +1072,1338 @@ public void replay(
jeffkbkim commented on code in PR #13870:
URL: https://github.com/apache/kafka/pull/13870#discussion_r1240399005
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -874,4 +1072,1338 @@ public void replay(
jsancio commented on code in PR #13910:
URL: https://github.com/apache/kafka/pull/13910#discussion_r1240397926
##
metadata/src/test/java/org/apache/kafka/controller/PartitionChangeBuilderTest.java:
##
@@ -207,7 +211,7 @@ public void testTriggerLeaderEpochBumpIfNeeded() {
jolshan commented on code in PR #13798:
URL: https://github.com/apache/kafka/pull/13798#discussion_r1240394281
##
core/src/main/scala/kafka/network/RequestChannel.scala:
##
@@ -240,16 +240,17 @@ object RequestChannel extends Logging {
val responseSendTimeMs =
gharris1727 commented on PR #13315:
URL: https://github.com/apache/kafka/pull/13315#issuecomment-1604661850
The rat problem was fixed in #13854 so i'm removing my fix for it in this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
C0urante merged PR #13912:
URL: https://github.com/apache/kafka/pull/13912
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
C0urante commented on PR #13912:
URL: https://github.com/apache/kafka/pull/13912#issuecomment-1604661486
I've built and verified this patch locally (including the reduction in error
log messages). Given the trivial nature of the changes, I'll merge without
awaiting the CI run.
--
This
C0urante commented on code in PR #13912:
URL: https://github.com/apache/kafka/pull/13912#discussion_r1240123793
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/ErrorHandlingTaskTest.java:
##
@@ -554,7 +554,7 @@ private ConsumerRecords
records(ConsumerRecord r
[
https://issues.apache.org/jira/browse/KAFKA-4107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17736570#comment-17736570
]
Chris Egerton commented on KAFKA-4107:
--
Wanted to update everyone here and let you all know that
[
https://issues.apache.org/jira/browse/KAFKA-4107?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Egerton updated KAFKA-4107:
-
Fix Version/s: 3.6.0
> Support offset reset capability in Kafka Connect
>
[
https://issues.apache.org/jira/browse/KAFKA-4107?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Egerton resolved KAFKA-4107.
--
Resolution: Done
> Support offset reset capability in Kafka Connect
>
[
https://issues.apache.org/jira/browse/KAFKA-14784?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Egerton updated KAFKA-14784:
--
Fix Version/s: 3.6.0
> Implement connector offset reset REST API
>
C0urante merged PR #13818:
URL: https://github.com/apache/kafka/pull/13818
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
C0urante commented on PR #13818:
URL: https://github.com/apache/kafka/pull/13818#issuecomment-1604598212
Test failures appear unrelated; merging...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
gharris1727 opened a new pull request, #13912:
URL: https://github.com/apache/kafka/pull/13912
In #13467 we changed non-connector plugins to be instantiated during plugin
scanning. This has the effect that converters and transform classes without a
valid (public, no-args) constructor print
gharris1727 opened a new pull request, #13911:
URL: https://github.com/apache/kafka/pull/13911
This was originally landed in #13838 and reverted in #13864 because it made
flakiness worse.
This reverts commit 73dd51e13765f77004aae51bea1009006778bd0e.
### Committer Checklist
ijuma commented on code in PR #12948:
URL: https://github.com/apache/kafka/pull/12948#discussion_r1240004510
##
core/src/test/scala/kafka/server/KafkaRequestHandlerTest.scala:
##
@@ -53,7 +53,7 @@ class KafkaRequestHandlerTest {
val context = new
ijuma commented on PR #12948:
URL: https://github.com/apache/kafka/pull/12948#issuecomment-1604501337
@divijvaidya Do you have cycles to review this PR? It is ready for review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
dimitarndimitrov commented on PR #13908:
URL: https://github.com/apache/kafka/pull/13908#issuecomment-1604500166
Thanks, @clolov, although this shapes up to be a bit of a head-scratcher.
The test failed in the CI run - just once, but with an error I haven't seen
before:
```
clolov commented on code in PR #13873:
URL: https://github.com/apache/kafka/pull/13873#discussion_r1239995959
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/TaskManagerTest.java:
##
@@ -4521,11 +4385,18 @@ public void shouldListNotPausedTasks() {
clolov commented on code in PR #13873:
URL: https://github.com/apache/kafka/pull/13873#discussion_r1239994806
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/TaskManagerTest.java:
##
@@ -2688,20 +2614,8 @@ public void
clolov commented on code in PR #13873:
URL: https://github.com/apache/kafka/pull/13873#discussion_r1239994017
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/TaskManagerTest.java:
##
@@ -918,9 +915,6 @@ public void
clolov commented on code in PR #13873:
URL: https://github.com/apache/kafka/pull/13873#discussion_r1239992529
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/TaskManagerTest.java:
##
@@ -886,11 +885,9 @@ public void
clolov commented on code in PR #13873:
URL: https://github.com/apache/kafka/pull/13873#discussion_r1239990255
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/TaskManagerTest.java:
##
@@ -918,9 +915,6 @@ public void
Ismael Juma created KAFKA-15117:
---
Summary: SslTransportLayerTest.testValidEndpointIdentificationCN
fails with Java 20
Key: KAFKA-15117
URL: https://issues.apache.org/jira/browse/KAFKA-15117
Project:
clolov commented on code in PR #13859:
URL: https://github.com/apache/kafka/pull/13859#discussion_r1239984189
##
tests/kafkatest/tests/core/upgrade_test.py:
##
@@ -94,6 +94,12 @@ def perform_upgrade(self, from_kafka_version,
to_message_format_version=None):
clolov commented on code in PR #13859:
URL: https://github.com/apache/kafka/pull/13859#discussion_r1239984189
##
tests/kafkatest/tests/core/upgrade_test.py:
##
@@ -94,6 +94,12 @@ def perform_upgrade(self, from_kafka_version,
to_message_format_version=None):
[
https://issues.apache.org/jira/browse/KAFKA-15053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17736529#comment-17736529
]
Chris Egerton edited comment on KAFKA-15053 at 6/23/23 3:31 PM:
[
https://issues.apache.org/jira/browse/KAFKA-15053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17736529#comment-17736529
]
Chris Egerton commented on KAFKA-15053:
---
[~dlgaobo] I think that may have been a typo, but just to
clolov commented on PR #13260:
URL: https://github.com/apache/kafka/pull/13260#issuecomment-1604416528
I ran
https://github.com/apache/kafka/blob/trunk/tests/kafkatest/tests/core/upgrade_test.py#L33
and all tests passed. I have confirmed that as part of the tests we start with
an older
[
https://issues.apache.org/jira/browse/KAFKA-13875?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Manyanda Chitimbo resolved KAFKA-13875.
---
Resolution: Fixed
Closing the Jira as it has been fixed by
Owen-CH-Leung commented on code in PR #13909:
URL: https://github.com/apache/kafka/pull/13909#discussion_r1239877001
##
streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java:
##
@@ -718,7 +718,7 @@ public class StreamsConfig extends AbstractConfig {
/** {@code
[
https://issues.apache.org/jira/browse/KAFKA-14957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17736502#comment-17736502
]
Owen C.H. Leung edited comment on KAFKA-14957 at 6/23/23 2:11 PM:
--
machi1990 commented on code in PR #13909:
URL: https://github.com/apache/kafka/pull/13909#discussion_r1239870549
##
streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java:
##
@@ -718,7 +718,7 @@ public class StreamsConfig extends AbstractConfig {
/** {@code
[
https://issues.apache.org/jira/browse/KAFKA-14957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17736502#comment-17736502
]
Owen C.H. Leung commented on KAFKA-14957:
-
[~mimaison] I created a PR to address this. Could you
[
https://issues.apache.org/jira/browse/KAFKA-14957?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Owen C.H. Leung reassigned KAFKA-14957:
---
Assignee: Owen C.H. Leung
> Default value for state.dir is confusing
>
Owen-CH-Leung opened a new pull request, #13909:
URL: https://github.com/apache/kafka/pull/13909
Revise description string as per discussion in
[
https://issues.apache.org/jira/browse/KAFKA-15113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17736483#comment-17736483
]
Yash Mayya commented on KAFKA-15113:
Thanks for reviewing the ticket Chris! Yeah, I'm not sure
yashmayya commented on code in PR #13801:
URL: https://github.com/apache/kafka/pull/13801#discussion_r1239720643
##
connect/runtime/src/test/java/org/apache/kafka/connect/storage/OffsetStorageWriterTest.java:
##
@@ -192,6 +209,236 @@ public void testCancelAfterAwaitFlush()
[
https://issues.apache.org/jira/browse/KAFKA-15052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17736453#comment-17736453
]
Dimitar Dimitrov commented on KAFKA-15052:
--
After a good amount of not super-successful local
dimitarndimitrov opened a new pull request, #13908:
URL: https://github.com/apache/kafka/pull/13908
A follow-up to https://github.com/apache/kafka/pull/13804. This follow-up
adds the alternative fix approach mentioned in the PR above - bumping the
session timeout used in the test with 1
kamalcph commented on PR #13837:
URL: https://github.com/apache/kafka/pull/13837#issuecomment-1604056026
@satishd
Can you please take a look when you get chance?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
viktorsomogyi closed pull request #13069: MINOR: Check process role and set
correct logdirs
URL: https://github.com/apache/kafka/pull/13069
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
David Gammon created KAFKA-15116:
Summary: Kafka Streams processing blocked during rebalance
Key: KAFKA-15116
URL: https://issues.apache.org/jira/browse/KAFKA-15116
Project: Kafka
Issue
joobisb commented on PR #13862:
URL: https://github.com/apache/kafka/pull/13862#issuecomment-1603798251
> @mimaison mentioned in a separate conversation a couple of other points:
>
> 1. it looks like we never need to refer to any of the example lines of
console input/output using the
58 matches
Mail list logo
