[GitHub] [kafka] yashmayya commented on a diff in pull request #13915: KAFKA-14930: Document the new PATCH and DELETE offsets REST APIs for Connect

yashmayya commented on code in PR #13915: URL: https://github.com/apache/kafka/pull/13915#discussion_r1243145305 ## docs/connect.html: ## @@ -313,7 +313,13 @@ REST API DELETE /connectors/{name} - delete a connector, halting all tasks and deleting its configuration

[GitHub] [kafka] yashmayya commented on a diff in pull request #13915: KAFKA-14930: Document the new PATCH and DELETE offsets REST APIs for Connect

yashmayya commented on code in PR #13915: URL: https://github.com/apache/kafka/pull/13915#discussion_r1243142955 ## docs/connect.html: ## @@ -313,7 +313,13 @@ REST API DELETE /connectors/{name} - delete a connector, halting all tasks and deleting its configuration

[GitHub] [kafka] hudeqi commented on pull request #13852: KAFKA-15086:Set a reasonable segment size upper limit for MM2 internal topics

hudeqi commented on PR #13852: URL: https://github.com/apache/kafka/pull/13852#issuecomment-1608769851 > @hudeqi sorry, this is a tricky issue and I'm trying to take time to think things through :) > > I hate to say it, but I don't think we can make this change or anything like it

[jira] [Commented] (KAFKA-13965) Document broker-side socket-server-metrics

[ https://issues.apache.org/jira/browse/KAFKA-13965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17737431#comment-17737431 ] David Jameson commented on KAFKA-13965: --- This looks like a good first ticket to get familiar with

[GitHub] [kafka] github-actions[bot] commented on pull request #13375: KAFKA-14569: Migrate Connect's integration test EmbeddedKafkaCluster from ZK to KRaft mode

github-actions[bot] commented on PR #13375: URL: https://github.com/apache/kafka/pull/13375#issuecomment-1608729834 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has

[GitHub] [kafka] iblislin opened a new pull request, #13919: MINOR: doc/streams/dsl-api, fix href of "KTable-KTable Foreign-Key Joins"

iblislin opened a new pull request, #13919: URL: https://github.com/apache/kafka/pull/13919 The `href` shown in ToC is here: https://github.com/apache/kafka/blob/c5889fceddb9a0174452ae60a57c8ff3f087a6a4/docs/streams/developer-guide/dsl-api.html#L52 -- This is an automated message from

[GitHub] [kafka] jeffkbkim commented on a diff in pull request #13880: KAFKA-14462; [19/N] Add CoordinatorLoader implementation

jeffkbkim commented on code in PR #13880: URL: https://github.com/apache/kafka/pull/13880#discussion_r1243002218 ## core/src/main/scala/kafka/coordinator/group/CoordinatorLoaderImpl.scala: ## @@ -0,0 +1,168 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [kafka] gharris1727 commented on a diff in pull request #13821: KAFKA-15069: Refactor plugin scanning logic into ReflectionScanner and ServiceLoaderScanner

gharris1727 commented on code in PR #13821: URL: https://github.com/apache/kafka/pull/13821#discussion_r1242974877 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/isolation/DelegatingClassLoader.java: ## @@ -104,6 +81,33 @@ public DelegatingClassLoader(List

[GitHub] [kafka] gharris1727 commented on a diff in pull request #13821: KAFKA-15069: Refactor plugin scanning logic into ReflectionScanner and ServiceLoaderScanner

gharris1727 commented on code in PR #13821: URL: https://github.com/apache/kafka/pull/13821#discussion_r1242962203 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/isolation/PluginScanner.java: ## @@ -0,0 +1,155 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] gharris1727 commented on a diff in pull request #13821: KAFKA-15069: Refactor plugin scanning logic into ReflectionScanner and ServiceLoaderScanner

gharris1727 commented on code in PR #13821: URL: https://github.com/apache/kafka/pull/13821#discussion_r1242961259 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/isolation/DelegatingClassLoader.java: ## @@ -147,229 +151,7 @@ PluginClassLoader

[GitHub] [kafka] jolshan opened a new pull request, #13918: DO NOT MERGE -- testing

jolshan opened a new pull request, #13918: URL: https://github.com/apache/kafka/pull/13918 Trying to debug flaky test that only seems to fail on CI. This is a version of https://github.com/apache/kafka/pull/13787 where I comment out some of the noisy logs and include some less noisy ones.

[GitHub] [kafka] jolshan commented on a diff in pull request #13798: KAFKA-15028: AddPartitionsToTxnManager metrics

jolshan commented on code in PR #13798: URL: https://github.com/apache/kafka/pull/13798#discussion_r1242874939 ## core/src/main/scala/kafka/server/AddPartitionsToTxnManager.scala: ## @@ -47,13 +55,19 @@ class AddPartitionsToTxnManager(config: KafkaConfig, client:

[GitHub] [kafka] jolshan commented on a diff in pull request #13798: KAFKA-15028: AddPartitionsToTxnManager metrics

jolshan commented on code in PR #13798: URL: https://github.com/apache/kafka/pull/13798#discussion_r1242731206 ## clients/src/main/java/org/apache/kafka/common/requests/AddPartitionsToTxnRequest.java: ## @@ -154,6 +154,11 @@ public AddPartitionsToTxnRequest normalizeRequest() {

[GitHub] [kafka] jolshan commented on a diff in pull request #13798: KAFKA-15028: AddPartitionsToTxnManager metrics

jolshan commented on code in PR #13798: URL: https://github.com/apache/kafka/pull/13798#discussion_r1242867082 ## clients/src/main/java/org/apache/kafka/common/requests/AddPartitionsToTxnRequest.java: ## @@ -154,6 +154,11 @@ public AddPartitionsToTxnRequest normalizeRequest() {

[GitHub] [kafka] jolshan commented on a diff in pull request #13880: KAFKA-14462; [19/N] Add CoordinatorLoader implementation

jolshan commented on code in PR #13880: URL: https://github.com/apache/kafka/pull/13880#discussion_r1242860978 ## core/src/main/scala/kafka/coordinator/group/CoordinatorLoaderImpl.scala: ## @@ -0,0 +1,168 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [kafka] jolshan commented on a diff in pull request #13880: KAFKA-14462; [19/N] Add CoordinatorLoader implementation

jolshan commented on code in PR #13880: URL: https://github.com/apache/kafka/pull/13880#discussion_r1242855495 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/RecordSerdeTest.java: ## @@ -0,0 +1,260 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [kafka] jolshan commented on a diff in pull request #13880: KAFKA-14462; [19/N] Add CoordinatorLoader implementation

jolshan commented on code in PR #13880: URL: https://github.com/apache/kafka/pull/13880#discussion_r1242849519 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/CoordinatorLoader.java: ## @@ -26,7 +27,40 @@ * * @param The type of the record.

[GitHub] [kafka] jolshan commented on a diff in pull request #13880: KAFKA-14462; [19/N] Add CoordinatorLoader implementation

jolshan commented on code in PR #13880: URL: https://github.com/apache/kafka/pull/13880#discussion_r1242822664 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/CoordinatorLoader.java: ## @@ -26,7 +27,40 @@ * * @param The type of the record.

[GitHub] [kafka] jolshan commented on a diff in pull request #13880: KAFKA-14462; [19/N] Add CoordinatorLoader implementation

jolshan commented on code in PR #13880: URL: https://github.com/apache/kafka/pull/13880#discussion_r1242819355 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/CoordinatorLoader.java: ## @@ -26,7 +27,40 @@ * * @param The type of the record.

[GitHub] [kafka] jolshan commented on a diff in pull request #13880: KAFKA-14462; [19/N] Add CoordinatorLoader implementation

jolshan commented on code in PR #13880: URL: https://github.com/apache/kafka/pull/13880#discussion_r1242803548 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/RecordSerde.java: ## @@ -0,0 +1,158 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] jolshan commented on a diff in pull request #13880: KAFKA-14462; [19/N] Add CoordinatorLoader implementation

jolshan commented on code in PR #13880: URL: https://github.com/apache/kafka/pull/13880#discussion_r1242789616 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/RecordSerde.java: ## @@ -0,0 +1,158 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] jolshan commented on a diff in pull request #13880: KAFKA-14462; [19/N] Add CoordinatorLoader implementation

jolshan commented on code in PR #13880: URL: https://github.com/apache/kafka/pull/13880#discussion_r1242786634 ## core/src/test/scala/unit/kafka/coordinator/group/CoordinatorLoaderImplTest.scala: ## @@ -0,0 +1,315 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] jolshan commented on a diff in pull request #13798: KAFKA-15028: AddPartitionsToTxnManager metrics

jolshan commented on code in PR #13798: URL: https://github.com/apache/kafka/pull/13798#discussion_r1242731206 ## clients/src/main/java/org/apache/kafka/common/requests/AddPartitionsToTxnRequest.java: ## @@ -154,6 +154,11 @@ public AddPartitionsToTxnRequest normalizeRequest() {

[GitHub] [kafka] jolshan commented on a diff in pull request #13798: KAFKA-15028: AddPartitionsToTxnManager metrics

jolshan commented on code in PR #13798: URL: https://github.com/apache/kafka/pull/13798#discussion_r1242724200 ## core/src/main/scala/kafka/server/AddPartitionsToTxnManager.scala: ## @@ -47,13 +55,19 @@ class AddPartitionsToTxnManager(config: KafkaConfig, client:

[GitHub] [kafka] jolshan commented on a diff in pull request #13798: KAFKA-15028: AddPartitionsToTxnManager metrics

jolshan commented on code in PR #13798: URL: https://github.com/apache/kafka/pull/13798#discussion_r1242721231 ## clients/src/main/java/org/apache/kafka/common/requests/AddPartitionsToTxnRequest.java: ## @@ -154,6 +154,11 @@ public AddPartitionsToTxnRequest normalizeRequest() {

[GitHub] [kafka] jolshan commented on a diff in pull request #13798: KAFKA-15028: AddPartitionsToTxnManager metrics

jolshan commented on code in PR #13798: URL: https://github.com/apache/kafka/pull/13798#discussion_r1242719150 ## core/src/test/scala/unit/kafka/utils/TestUtils.scala: ## @@ -2158,6 +2158,12 @@ object TestUtils extends Logging {

[GitHub] [kafka] C0urante commented on a diff in pull request #13915: KAFKA-14930: Document the new PATCH and DELETE offsets REST APIs for Connect

C0urante commented on code in PR #13915: URL: https://github.com/apache/kafka/pull/13915#discussion_r1242245895 ## docs/connect.html: ## @@ -301,7 +301,7 @@ REST API GET /connectors/{name}/tasks - get a list of tasks currently running for a connector GET

[GitHub] [kafka] divijvaidya commented on a diff in pull request #13884: MINOR: fix typos for client

divijvaidya commented on code in PR #13884: URL: https://github.com/apache/kafka/pull/13884#discussion_r1242669461 ## clients/src/test/java/org/apache/kafka/common/utils/UtilsTest.java: ## @@ -854,7 +854,7 @@ public void shouldThrowOnInvalidDateFormatOrNullTimestamp() {

[GitHub] [kafka] divijvaidya commented on pull request #13831: KAFKA-15053: Use case insensitive validator for security.protocol config

divijvaidya commented on PR #13831: URL: https://github.com/apache/kafka/pull/13831#issuecomment-1608088036 @C0urante ah! we have fancy stuff. Thanks for letting me know. @bogao007 seems like we might not need the docs change for config after all. The only remaining fix is the small

[jira] [Assigned] (KAFKA-8977) Remove MockStreamsMetrics Since it is not a Mock

[ https://issues.apache.org/jira/browse/KAFKA-8977?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joobi S B reassigned KAFKA-8977: Assignee: Joobi S B > Remove MockStreamsMetrics Since it is not a Mock >

[jira] [Commented] (KAFKA-15050) Prompts in the quickstarts

[ https://issues.apache.org/jira/browse/KAFKA-15050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17737315#comment-17737315 ] Joobi S B commented on KAFKA-15050: --- Hi [~tombentley], i've updated the PR with latest comments, 

[GitHub] [kafka] divijvaidya commented on a diff in pull request #13798: KAFKA-15028: AddPartitionsToTxnManager metrics

divijvaidya commented on code in PR #13798: URL: https://github.com/apache/kafka/pull/13798#discussion_r1242585330 ## clients/src/main/java/org/apache/kafka/common/requests/AddPartitionsToTxnRequest.java: ## @@ -154,6 +154,11 @@ public AddPartitionsToTxnRequest

[GitHub] [kafka] jolshan commented on a diff in pull request #13880: KAFKA-14462; [19/N] Add CoordinatorLoader implementation

jolshan commented on code in PR #13880: URL: https://github.com/apache/kafka/pull/13880#discussion_r1242623544 ## core/src/main/scala/kafka/coordinator/group/CoordinatorLoaderImpl.scala: ## @@ -0,0 +1,168 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [kafka] jolshan commented on a diff in pull request #13880: KAFKA-14462; [19/N] Add CoordinatorLoader implementation

jolshan commented on code in PR #13880: URL: https://github.com/apache/kafka/pull/13880#discussion_r1242616962 ## core/src/main/scala/kafka/coordinator/group/CoordinatorLoaderImpl.scala: ## @@ -0,0 +1,168 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [kafka] C0urante commented on a diff in pull request #13383: KAFKA-14059 Replace PowerMock with Mockito in WorkerSourceTaskTest

C0urante commented on code in PR #13383: URL: https://github.com/apache/kafka/pull/13383#discussion_r1242606914 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/WorkerSourceTaskTest.java: ## @@ -706,95 +662,72 @@ public void

[jira] [Created] (KAFKA-15126) Change range queries to accept null lower and upper bounds

Lucia Cerchie created KAFKA-15126: - Summary: Change range queries to accept null lower and upper bounds Key: KAFKA-15126 URL: https://issues.apache.org/jira/browse/KAFKA-15126 Project: Kafka

[GitHub] [kafka] cmccabe closed pull request #7646: KAFKA-7504: prepare FetchResponses in the request handler threads

cmccabe closed pull request #7646: KAFKA-7504: prepare FetchResponses in the request handler threads URL: https://github.com/apache/kafka/pull/7646 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] cmccabe closed pull request #4442: Add TestKit

cmccabe closed pull request #4442: Add TestKit URL: https://github.com/apache/kafka/pull/4442 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] cmccabe commented on pull request #4442: Add TestKit

cmccabe commented on PR #4442: URL: https://github.com/apache/kafka/pull/4442#issuecomment-1607963901 This has been implemented, although in a slightly different form. :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [kafka] cmccabe closed pull request #3794: KAFKA-5838. Speed up running system tests in docker a bit with better…

cmccabe closed pull request #3794: KAFKA-5838. Speed up running system tests in docker a bit with better… URL: https://github.com/apache/kafka/pull/3794 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka] jaewie commented on pull request #13891: Breaks down SocketServer classes into ConnectionQuotaEntity.scala and ConnectionQuotas.scala

jaewie commented on PR #13891: URL: https://github.com/apache/kafka/pull/13891#issuecomment-1607955171 Hi @kirktrue, I just created one here https://issues.apache.org/jira/browse/KAFKA-15125 -- This is an automated message from the Apache Git Service. To respond to the message, please

[jira] [Created] (KAFKA-15125) Break down SocketServer classes into separate files

Jae Wie created KAFKA-15125: --- Summary: Break down SocketServer classes into separate files Key: KAFKA-15125 URL: https://issues.apache.org/jira/browse/KAFKA-15125 Project: Kafka Issue Type: Task

[GitHub] [kafka] cmccabe closed pull request #3359: KAFKA-5062. Kafka brokers can accept malformed requests which allocat…

cmccabe closed pull request #3359: KAFKA-5062. Kafka brokers can accept malformed requests which allocat… URL: https://github.com/apache/kafka/pull/3359 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka] C0urante commented on pull request #13852: KAFKA-15086:Set a reasonable segment size upper limit for MM2 internal topics

C0urante commented on PR #13852: URL: https://github.com/apache/kafka/pull/13852#issuecomment-1607920082 @hudeqi sorry, this is a tricky issue and I'm trying to take time to think things through :) I hate to say it, but I don't think we can make this change or anything like it

[GitHub] [kafka] jsancio commented on a diff in pull request #13845: KAFKA-15078; KRaft leader replys with snapshot for offset 0

jsancio commented on code in PR #13845: URL: https://github.com/apache/kafka/pull/13845#discussion_r1235409277 ## raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java: ## @@ -1017,7 +1017,16 @@ private FetchResponseData tryCompleteFetchRequest( long

[GitHub] [kafka] jolshan commented on pull request #13721: KAFKA-14782: Implementation Details Different from Documentation (del…

jolshan commented on PR #13721: URL: https://github.com/apache/kafka/pull/13721#issuecomment-1607896742 I think the safer thing would be to just update the text to not include this in the calculation and any documentation. I don't think this has caused anyone issues in the current state

[GitHub] [kafka] jolshan commented on pull request #13876: KAFKA-10733: Clean up producer exceptions

jolshan commented on PR #13876: URL: https://github.com/apache/kafka/pull/13876#issuecomment-1607891946 > - Keep things somewhat inconsistent > - Do not wrap fatal exceptions and keep the exceptions as-is > - Do wrap fatal exceptions and let the users deal with it > - Always rethrow

[GitHub] [kafka] jolshan commented on pull request #13798: KAFKA-15028: AddPartitionsToTxnManager metrics

jolshan commented on PR #13798: URL: https://github.com/apache/kafka/pull/13798#issuecomment-1607881974 The last builds are looking better. @divijvaidya please take a look when you get a chance. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [kafka] clayburn commented on pull request #13676: MINOR: Capture build scans on ge.apache.org to benefit from deep build insights

clayburn commented on PR #13676: URL: https://github.com/apache/kafka/pull/13676#issuecomment-1607863528 @ijuma Under our Software License and Sponsorship Agreement, Apache's users and contributors may use the Gradle Enterprise instance and run any ASF builds with GE enabled solely in

[jira] [Assigned] (KAFKA-15123) Add tests for ChunkedBytesStream

[ https://issues.apache.org/jira/browse/KAFKA-15123?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Divij Vaidya reassigned KAFKA-15123: Assignee: Max Riedel > Add tests for ChunkedBytesStream >

[GitHub] [kafka] C0urante commented on a diff in pull request #13821: KAFKA-15069: Refactor plugin scanning logic into ReflectionScanner and ServiceLoaderScanner

C0urante commented on code in PR #13821: URL: https://github.com/apache/kafka/pull/13821#discussion_r1242437655 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/isolation/PluginScanner.java: ## @@ -0,0 +1,155 @@ +/* + * Licensed to the Apache Software

[jira] [Commented] (KAFKA-15123) Add tests for ChunkedBytesStream

[ https://issues.apache.org/jira/browse/KAFKA-15123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17737267#comment-17737267 ] Divij Vaidya commented on KAFKA-15123: -- Sure thing. Please go ahead. I assigned this to you. > Add

[jira] [Updated] (KAFKA-9015) Unify metric names

[ https://issues.apache.org/jira/browse/KAFKA-9015?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-9015: - Labels: easy kip needs-kip newbie (was: easy kip newbie) > Unify metric names > -- > >

[jira] [Updated] (KAFKA-15118) Need for a Centralized Configuration Management System in Apache Kafka

[ https://issues.apache.org/jira/browse/KAFKA-15118?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-15118: -- Labels: needs-kip (was: ) > Need for a Centralized Configuration Management System in Apache Kafka >

[jira] [Commented] (KAFKA-15118) Need for a Centralized Configuration Management System in Apache Kafka

[ https://issues.apache.org/jira/browse/KAFKA-15118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17737245#comment-17737245 ] Kirk True commented on KAFKA-15118: --- [~jimmywang611] Thanks for the ticket. Centralized configuration

[GitHub] [kafka] jsancio commented on a diff in pull request #13917: MINOR; Failed move should be logged at WARN

jsancio commented on code in PR #13917: URL: https://github.com/apache/kafka/pull/13917#discussion_r1242449562 ## clients/src/main/java/org/apache/kafka/common/utils/Utils.java: ## @@ -978,9 +978,9 @@ public static void atomicMoveWithFallback(Path source, Path target, boolean

[jira] [Resolved] (KAFKA-15122) Moving partitions between log dirs leads to kafka.log:type=Log metrics being deleted

[ https://issues.apache.org/jira/browse/KAFKA-15122?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mickael Maison resolved KAFKA-15122. Fix Version/s: 3.5.0 Resolution: Duplicate Duplicate of

[jira] [Updated] (KAFKA-15122) Moving partitions between log dirs leads to kafka.log:type=Log metrics being deleted

[ https://issues.apache.org/jira/browse/KAFKA-15122?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mickael Maison updated KAFKA-15122: --- Affects Version/s: 3.4.0 (was: 3.5.0) > Moving partitions

[GitHub] [kafka] rondagostino commented on a diff in pull request #13917: MINOR; Failed move should be logged at WARN

rondagostino commented on code in PR #13917: URL: https://github.com/apache/kafka/pull/13917#discussion_r1242445724 ## clients/src/main/java/org/apache/kafka/common/utils/Utils.java: ## @@ -978,9 +978,9 @@ public static void atomicMoveWithFallback(Path source, Path target,

[GitHub] [kafka] rondagostino commented on a diff in pull request #13917: MINOR; Failed move should be logged at WARN

rondagostino commented on code in PR #13917: URL: https://github.com/apache/kafka/pull/13917#discussion_r1242444579 ## clients/src/main/java/org/apache/kafka/common/utils/Utils.java: ## @@ -978,9 +978,9 @@ public static void atomicMoveWithFallback(Path source, Path target,

[GitHub] [kafka] jsancio commented on a diff in pull request #13917: MINOR; Failed move should be logged at WARN

jsancio commented on code in PR #13917: URL: https://github.com/apache/kafka/pull/13917#discussion_r1242443198 ## clients/src/main/java/org/apache/kafka/common/utils/Utils.java: ## @@ -979,7 +979,7 @@ public static void atomicMoveWithFallback(Path source, Path target, boolean

[GitHub] [kafka] jsancio commented on a diff in pull request #13917: MINOR; Failed move should be logged at WARN

jsancio commented on code in PR #13917: URL: https://github.com/apache/kafka/pull/13917#discussion_r1242429861 ## clients/src/main/java/org/apache/kafka/common/utils/Utils.java: ## @@ -979,7 +979,7 @@ public static void atomicMoveWithFallback(Path source, Path target, boolean

[GitHub] [kafka] rondagostino commented on a diff in pull request #13917: MINOR; Failed move should be logged at WARN

rondagostino commented on code in PR #13917: URL: https://github.com/apache/kafka/pull/13917#discussion_r1242428311 ## clients/src/main/java/org/apache/kafka/common/utils/Utils.java: ## @@ -979,7 +979,7 @@ public static void atomicMoveWithFallback(Path source, Path target,

[GitHub] [kafka] rondagostino commented on a diff in pull request #13917: MINOR; Failed move should be logged at WARN

rondagostino commented on code in PR #13917: URL: https://github.com/apache/kafka/pull/13917#discussion_r1242424176 ## clients/src/main/java/org/apache/kafka/common/utils/Utils.java: ## @@ -979,7 +979,7 @@ public static void atomicMoveWithFallback(Path source, Path target,

[GitHub] [kafka] jsancio opened a new pull request, #13917: MINOR; Failed move should be logged at WARN

jsancio opened a new pull request, #13917: URL: https://github.com/apache/kafka/pull/13917 When Kafka fails to perform file move the error is getting swallowed. Kafka should log these cases at least at WARN level. ### Committer Checklist (excluded from commit message) - [ ] Verify

[jira] [Updated] (KAFKA-15122) Moving partitions between log dirs leads to kafka.log:type=Log metrics being deleted

[ https://issues.apache.org/jira/browse/KAFKA-15122?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mickael Maison updated KAFKA-15122: --- Description: # Start a broker with 2 log directories # Create a topic-partition Metrics

[jira] [Commented] (KAFKA-15123) Add tests for ChunkedBytesStream

[ https://issues.apache.org/jira/browse/KAFKA-15123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17737201#comment-17737201 ] Max Riedel commented on KAFKA-15123: Hi [~divijvaidya]  This sounds like a good task to start

[jira] [Created] (KAFKA-15124) KRaft snapshot freeze should never perform copy

José Armando García Sancio created KAFKA-15124: -- Summary: KRaft snapshot freeze should never perform copy Key: KAFKA-15124 URL: https://issues.apache.org/jira/browse/KAFKA-15124 Project:

[GitHub] [kafka] divijvaidya commented on a diff in pull request #12948: MINOR: Add JDK 20 CI build and remove some branch builds

divijvaidya commented on code in PR #12948: URL: https://github.com/apache/kafka/pull/12948#discussion_r1242377704 ## clients/src/main/java/org/apache/kafka/common/utils/ChunkedBytesStream.java: ## @@ -290,25 +290,27 @@ public long skip(long toSkip) throws IOException {

[jira] [Created] (KAFKA-15123) Add tests for ChunkedBytesStream

Divij Vaidya created KAFKA-15123: Summary: Add tests for ChunkedBytesStream Key: KAFKA-15123 URL: https://issues.apache.org/jira/browse/KAFKA-15123 Project: Kafka Issue Type: Improvement

[jira] [Created] (KAFKA-15122) Moving partitions between log dirs leads to kafka.log:type=Log metrics being deleted

Mickael Maison created KAFKA-15122: -- Summary: Moving partitions between log dirs leads to kafka.log:type=Log metrics being deleted Key: KAFKA-15122 URL: https://issues.apache.org/jira/browse/KAFKA-15122

[GitHub] [kafka] ijuma commented on a diff in pull request #12948: MINOR: Add JDK 20 CI build and remove some branch builds

ijuma commented on code in PR #12948: URL: https://github.com/apache/kafka/pull/12948#discussion_r1242345211 ## clients/src/main/java/org/apache/kafka/common/utils/ChunkedBytesStream.java: ## @@ -290,25 +290,27 @@ public long skip(long toSkip) throws IOException { //

[jira] [Updated] (KAFKA-15053) Regression for security.protocol validation starting from 3.3.0

[ https://issues.apache.org/jira/browse/KAFKA-15053?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Divij Vaidya updated KAFKA-15053: - Fix Version/s: 3.6.0 > Regression for security.protocol validation starting from 3.3.0 >

[GitHub] [kafka] divijvaidya commented on pull request #13700: KAFKA-14959: remove delayed queue and exempt sensors during ClientQuota and ClientRequestQuota managers shutdown

divijvaidya commented on PR #13700: URL: https://github.com/apache/kafka/pull/13700#issuecomment-1607659721 I wanted to let you know that this is on my radar and I need a few more days to get to this. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [kafka] divijvaidya commented on a diff in pull request #12948: MINOR: Add JDK 20 CI build and remove some branch builds

divijvaidya commented on code in PR #12948: URL: https://github.com/apache/kafka/pull/12948#discussion_r1242328144 ## clients/src/main/java/org/apache/kafka/common/utils/ChunkedBytesStream.java: ## @@ -290,25 +290,27 @@ public long skip(long toSkip) throws IOException {

[jira] [Commented] (KAFKA-15105) Flaky test FetchFromFollowerIntegrationTest.testFetchFromLeaderWhilePreferredReadReplicaIsUnavailable

[ https://issues.apache.org/jira/browse/KAFKA-15105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17737186#comment-17737186 ] Max Riedel commented on KAFKA-15105: I would like to work on this issue. I'm still trying to

[GitHub] [kafka] divijvaidya commented on a diff in pull request #13831: KAFKA-15053: Use case insensitive validator for security.protocol config

divijvaidya commented on code in PR #13831: URL: https://github.com/apache/kafka/pull/13831#discussion_r1242302387 ## docs/security.html: ## @@ -72,6 +72,10 @@ SSL SASL_PLAINTEXT SASL_SSL + plaintext Review Comment: Instead of adding all values, please

[GitHub] [kafka] ijuma commented on a diff in pull request #12948: MINOR: Add JDK 20 CI build and remove some branch builds

ijuma commented on code in PR #12948: URL: https://github.com/apache/kafka/pull/12948#discussion_r1242312432 ## Jenkinsfile: ## @@ -155,79 +155,23 @@ pipeline { echo 'Skipping Kafka Streams archetype test for Java 17' } } - -//

[GitHub] [kafka] ijuma commented on a diff in pull request #12948: MINOR: Add JDK 20 CI build and remove some branch builds

ijuma commented on code in PR #12948: URL: https://github.com/apache/kafka/pull/12948#discussion_r1242309422 ## clients/src/main/java/org/apache/kafka/common/utils/ChunkedBytesStream.java: ## @@ -290,25 +290,27 @@ public long skip(long toSkip) throws IOException { //

[GitHub] [kafka] divijvaidya commented on pull request #12685: KAFKA-14945: Add Serializer#serializeToByteBuffer() to reduce memory copying

divijvaidya commented on PR #12685: URL: https://github.com/apache/kafka/pull/12685#issuecomment-1607609145 @LinShunKang Give me a few days. I will get to it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [kafka] C0urante commented on a diff in pull request #13915: KAFKA-14930: Document the new PATCH and DELETE offsets REST APIs for Connect

C0urante commented on code in PR #13915: URL: https://github.com/apache/kafka/pull/13915#discussion_r1242245895 ## docs/connect.html: ## @@ -301,7 +301,7 @@ REST API GET /connectors/{name}/tasks - get a list of tasks currently running for a connector GET

[GitHub] [kafka] clolov commented on a diff in pull request #13873: KAFKA-14133: Migrate Consumer mock in TaskManagerTest to Mockito

clolov commented on code in PR #13873: URL: https://github.com/apache/kafka/pull/13873#discussion_r1242226466 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/TaskManagerTest.java: ## @@ -2688,20 +2614,8 @@ public void

[GitHub] [kafka] clolov commented on a diff in pull request #13873: KAFKA-14133: Migrate Consumer mock in TaskManagerTest to Mockito

clolov commented on code in PR #13873: URL: https://github.com/apache/kafka/pull/13873#discussion_r1242149622 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/TaskManagerTest.java: ## @@ -1961,10 +1920,10 @@ public void postCommit(final boolean

[GitHub] [kafka] clolov commented on a diff in pull request #13873: KAFKA-14133: Migrate Consumer mock in TaskManagerTest to Mockito

clolov commented on code in PR #13873: URL: https://github.com/apache/kafka/pull/13873#discussion_r1242148687 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/TaskManagerTest.java: ## @@ -1961,10 +1920,10 @@ public void postCommit(final boolean

[GitHub] [kafka] clolov commented on a diff in pull request #13873: KAFKA-14133: Migrate Consumer mock in TaskManagerTest to Mockito

clolov commented on code in PR #13873: URL: https://github.com/apache/kafka/pull/13873#discussion_r1242151305 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/TaskManagerTest.java: ## @@ -1961,10 +1920,10 @@ public void postCommit(final boolean

[GitHub] [kafka] clolov commented on a diff in pull request #13873: KAFKA-14133: Migrate Consumer mock in TaskManagerTest to Mockito

clolov commented on code in PR #13873: URL: https://github.com/apache/kafka/pull/13873#discussion_r1242149622 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/TaskManagerTest.java: ## @@ -1961,10 +1920,10 @@ public void postCommit(final boolean

[GitHub] [kafka] clolov commented on a diff in pull request #13873: KAFKA-14133: Migrate Consumer mock in TaskManagerTest to Mockito

clolov commented on code in PR #13873: URL: https://github.com/apache/kafka/pull/13873#discussion_r1242148687 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/TaskManagerTest.java: ## @@ -1961,10 +1920,10 @@ public void postCommit(final boolean

[GitHub] [kafka] clolov commented on a diff in pull request #13873: KAFKA-14133: Migrate Consumer mock in TaskManagerTest to Mockito

clolov commented on code in PR #13873: URL: https://github.com/apache/kafka/pull/13873#discussion_r1242144879 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/TaskManagerTest.java: ## @@ -2418,19 +2368,18 @@ public void markChangelogAsCorrupted(final

[GitHub] [kafka] clolov commented on a diff in pull request #13873: KAFKA-14133: Migrate Consumer mock in TaskManagerTest to Mockito

clolov commented on code in PR #13873: URL: https://github.com/apache/kafka/pull/13873#discussion_r1242142731 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/TaskManagerTest.java: ## @@ -2469,19 +2416,18 @@ public void

[GitHub] [kafka] clolov commented on a diff in pull request #13873: KAFKA-14133: Migrate Consumer mock in TaskManagerTest to Mockito

clolov commented on code in PR #13873: URL: https://github.com/apache/kafka/pull/13873#discussion_r1242140474 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/TaskManagerTest.java: ## @@ -2469,19 +2416,18 @@ public void

[GitHub] [kafka] clolov commented on a diff in pull request #13873: KAFKA-14133: Migrate Consumer mock in TaskManagerTest to Mockito

clolov commented on code in PR #13873: URL: https://github.com/apache/kafka/pull/13873#discussion_r1242132233 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/TaskManagerTest.java: ## @@ -4050,12 +3928,8 @@ public void

[GitHub] [kafka] clolov commented on a diff in pull request #13873: KAFKA-14133: Migrate Consumer mock in TaskManagerTest to Mockito

clolov commented on code in PR #13873: URL: https://github.com/apache/kafka/pull/13873#discussion_r1242131444 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/TaskManagerTest.java: ## @@ -3418,16 +3311,12 @@ public void shouldCommitProvidedTasksIfNeeded() {

[GitHub] [kafka] clolov commented on a diff in pull request #13873: KAFKA-14133: Migrate Consumer mock in TaskManagerTest to Mockito

clolov commented on code in PR #13873: URL: https://github.com/apache/kafka/pull/13873#discussion_r1242121402 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/TaskManagerTest.java: ## @@ -3219,17 +3128,6 @@ public void shouldCloseStandbyTasksOnShutdown() {

[GitHub] [kafka] clolov commented on a diff in pull request #13873: KAFKA-14133: Migrate Consumer mock in TaskManagerTest to Mockito

clolov commented on code in PR #13873: URL: https://github.com/apache/kafka/pull/13873#discussion_r1242121402 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/TaskManagerTest.java: ## @@ -3219,17 +3128,6 @@ public void shouldCloseStandbyTasksOnShutdown() {

[GitHub] [kafka] cadonna commented on a diff in pull request #13873: KAFKA-14133: Migrate Consumer mock in TaskManagerTest to Mockito

cadonna commented on code in PR #13873: URL: https://github.com/apache/kafka/pull/13873#discussion_r1241990023 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/TaskManagerTest.java: ## @@ -4521,11 +4385,18 @@ public void shouldListNotPausedTasks() {

[GitHub] [kafka] divijvaidya commented on a diff in pull request #12948: MINOR: Add JDK 20 CI build and remove some branch builds

divijvaidya commented on code in PR #12948: URL: https://github.com/apache/kafka/pull/12948#discussion_r1242092544 ## Jenkinsfile: ## @@ -155,79 +155,23 @@ pipeline { echo 'Skipping Kafka Streams archetype test for Java 17' } } - -

[GitHub] [kafka] pprovenzano opened a new pull request, #13916: WIP DelegationToken Support for KRaft

pprovenzano opened a new pull request, #13916: URL: https://github.com/apache/kafka/pull/13916 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of

[GitHub] [kafka] divijvaidya commented on a diff in pull request #12948: MINOR: Add JDK 20 CI build and remove some branch builds

divijvaidya commented on code in PR #12948: URL: https://github.com/apache/kafka/pull/12948#discussion_r1242078745 ## clients/src/main/java/org/apache/kafka/common/utils/ChunkedBytesStream.java: ## @@ -290,25 +290,27 @@ public long skip(long toSkip) throws IOException {

[jira] [Assigned] (KAFKA-14972) Make KafkaConsumer usable in async runtimes

[ https://issues.apache.org/jira/browse/KAFKA-14972?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Egerton reassigned KAFKA-14972: - Assignee: Erik van Oosten > Make KafkaConsumer usable in async runtimes >

[GitHub] [kafka] mimaison commented on pull request #13914: KAFKA-14972: Support async runtimes in consumer

mimaison commented on PR #13914: URL: https://github.com/apache/kafka/pull/13914#issuecomment-1607082695 Thanks for the PR. This introduces public methods in KafkaConsumer which is part of the public API. SO in order to accept this, we first need to vote a KIP. See the process in the

  1   2   >