[GitHub] [kafka] mjsax commented on a diff in pull request #13925: KAFKA-10199: Consider tasks in state updater when computing offset sums

2023-06-29 Thread via GitHub
mjsax commented on code in PR #13925: URL: https://github.com/apache/kafka/pull/13925#discussion_r1247273467 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java: ## @@ -1141,25 +1141,30 @@ public Map getTaskOffsetSums() { // Not all

[GitHub] [kafka] jolshan closed pull request #13918: DO NOT MERGE -- testing

2023-06-29 Thread via GitHub
jolshan closed pull request #13918: DO NOT MERGE -- testing URL: https://github.com/apache/kafka/pull/13918 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [kafka] jolshan commented on a diff in pull request #13787: KAFKA-14884: Include check transaction is still ongoing right before append (take 2)

2023-06-29 Thread via GitHub
jolshan commented on code in PR #13787: URL: https://github.com/apache/kafka/pull/13787#discussion_r1247245146 ## core/src/main/scala/kafka/network/RequestChannel.scala: ## @@ -507,9 +507,14 @@ class RequestChannel(val queueSize: Int, def sendShutdownRequest(): Unit =

[GitHub] [kafka] hachikuji commented on a diff in pull request #13787: KAFKA-14884: Include check transaction is still ongoing right before append (take 2)

2023-06-29 Thread via GitHub
hachikuji commented on code in PR #13787: URL: https://github.com/apache/kafka/pull/13787#discussion_r1247229531 ## core/src/main/scala/kafka/network/RequestChannel.scala: ## @@ -507,9 +507,14 @@ class RequestChannel(val queueSize: Int, def sendShutdownRequest(): Unit =

[GitHub] [kafka] JimGalasyn commented on pull request #13937: Add Streams API broker compatibility table

2023-06-29 Thread via GitHub
JimGalasyn commented on PR #13937: URL: https://github.com/apache/kafka/pull/13937#issuecomment-1613837996 cc @guozhangwang @mjsax -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [kafka] JimGalasyn opened a new pull request, #13937: Add Streams API broker compatibility table

2023-06-29 Thread via GitHub
JimGalasyn opened a new pull request, #13937: URL: https://github.com/apache/kafka/pull/13937 Add a broker compatibility matrix to the Streams Developer Guide. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [kafka] szalapski commented on pull request #5876: KAFKA-7509: Avoid passing most non-applicable properties to producer, consumer, and admin client

2023-06-29 Thread via GitHub
szalapski commented on PR #5876: URL: https://github.com/apache/kafka/pull/5876#issuecomment-1613828699 That sounds great. I'll try to upgrade and look into it soon. Feel free to close. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[jira] [Updated] (KAFKA-14246) Update threading model for Consumer (KIP-945)

2023-06-29 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14246?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-14246: -- Summary: Update threading model for Consumer (KIP-945) (was: Update threading model for Consumer) >

[GitHub] [kafka] CalvinConfluent commented on a diff in pull request #13870: KAFKA-14500; [5/N] Implement JoinGroup protocol in new GroupCoordinator

2023-06-29 Thread via GitHub
CalvinConfluent commented on code in PR #13870: URL: https://github.com/apache/kafka/pull/13870#discussion_r1246995181 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -874,4 +1087,1362 @@ public void replay(

[jira] [Updated] (KAFKA-14264) Refactor coordinator code

2023-06-29 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14264?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-14264: -- Component/s: clients > Refactor coordinator code > - > > Key:

[jira] [Updated] (KAFKA-14875) Implement Wakeup()

2023-06-29 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14875?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-14875: -- Component/s: clients > Implement Wakeup() > -- > > Key: KAFKA-14875 >

[jira] [Updated] (KAFKA-14761) Integration Tests for the New Consumer Implementation

2023-06-29 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14761?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-14761: -- Component/s: clients > Integration Tests for the New Consumer Implementation >

[jira] [Updated] (KAFKA-14252) Create background thread skeleton for new Consumer threading model

2023-06-29 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14252?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-14252: -- Component/s: clients > Create background thread skeleton for new Consumer threading model >

[jira] [Updated] (KAFKA-14468) Refactor Commit Logic

2023-06-29 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14468?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-14468: -- Component/s: clients > Refactor Commit Logic > - > > Key:

[jira] [Updated] (KAFKA-14247) Implement EventHandler interface and DefaultEventHandler for Consumer

2023-06-29 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14247?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-14247: -- Component/s: clients > Implement EventHandler interface and DefaultEventHandler for Consumer >

[jira] [Updated] (KAFKA-14960) Metadata Request Manager and listTopics/partitionsFor API

2023-06-29 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14960?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-14960: -- Component/s: clients > Metadata Request Manager and listTopics/partitionsFor API >

[jira] [Updated] (KAFKA-14950) Implement assign() and assignment()

2023-06-29 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14950?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-14950: -- Component/s: clients > Implement assign() and assignment() > --- > >

[jira] [Updated] (KAFKA-14246) Update threading model for Consumer

2023-06-29 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14246?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-14246: -- Component/s: clients > Update threading model for Consumer > --- > >

[GitHub] [kafka] CalvinConfluent commented on a diff in pull request #13870: KAFKA-14500; [5/N] Implement JoinGroup protocol in new GroupCoordinator

2023-06-29 Thread via GitHub
CalvinConfluent commented on code in PR #13870: URL: https://github.com/apache/kafka/pull/13870#discussion_r1246964799 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorService.java: ## @@ -102,13 +108,34 @@ public Builder

[jira] [Updated] (KAFKA-14761) Integration Tests for the New Consumer Implementation

2023-06-29 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14761?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-14761: -- Parent: (was: KAFKA-14246) Issue Type: Task (was: Sub-task) > Integration Tests for the

[jira] [Updated] (KAFKA-14247) Implement EventHandler interface and DefaultEventHandler

2023-06-29 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14247?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-14247: -- Parent: (was: KAFKA-14246) Issue Type: Task (was: Sub-task) > Implement EventHandler

[jira] [Updated] (KAFKA-14247) Implement EventHandler interface and DefaultEventHandler for Consumer

2023-06-29 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14247?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-14247: -- Summary: Implement EventHandler interface and DefaultEventHandler for Consumer (was: Implement

[jira] [Updated] (KAFKA-14252) Create background thread skeleton

2023-06-29 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14252?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-14252: -- Parent: (was: KAFKA-14246) Issue Type: Task (was: Sub-task) > Create background thread

[jira] [Updated] (KAFKA-14252) Create background thread skeleton for new Consumer threading model

2023-06-29 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14252?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-14252: -- Summary: Create background thread skeleton for new Consumer threading model (was: Create background

[jira] [Updated] (KAFKA-14960) Metadata Request Manager and listTopics/partitionsFor API

2023-06-29 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14960?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-14960: -- Parent: (was: KAFKA-14246) Issue Type: Task (was: Sub-task) > Metadata Request Manager

[jira] [Updated] (KAFKA-14264) Refactor coordinator code

2023-06-29 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14264?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-14264: -- Parent: (was: KAFKA-14246) Issue Type: Task (was: Sub-task) > Refactor coordinator code

[jira] [Updated] (KAFKA-14468) Refactor Commit Logic

2023-06-29 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14468?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-14468: -- Parent: (was: KAFKA-14246) Issue Type: Task (was: Sub-task) > Refactor Commit Logic >

[jira] [Updated] (KAFKA-14966) Extract reusable common logic from OffsetFetcher

2023-06-29 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14966?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-14966: -- Parent: (was: KAFKA-14965) Issue Type: Task (was: Sub-task) > Extract reusable common

[jira] [Updated] (KAFKA-14950) Implement assign() and assignment()

2023-06-29 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14950?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-14950: -- Parent: (was: KAFKA-14246) Issue Type: Task (was: Sub-task) > Implement assign() and

[jira] [Updated] (KAFKA-14875) Implement Wakeup()

2023-06-29 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14875?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-14875: -- Parent: (was: KAFKA-14246) Issue Type: Task (was: Sub-task) > Implement Wakeup() >

[jira] [Updated] (KAFKA-14274) Introduce FetchRequestManager to integrate fetch into new consumer threading refactor

2023-06-29 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14274?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-14274: -- Issue Type: Task (was: Improvement) > Introduce FetchRequestManager to integrate fetch into new

[jira] [Updated] (KAFKA-14675) Extract metadata-related tasks from Fetcher into MetadataFetcher

2023-06-29 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14675?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-14675: -- Issue Type: Task (was: Improvement) > Extract metadata-related tasks from Fetcher into

[jira] [Updated] (KAFKA-14365) Extract common logic from Fetcher

2023-06-29 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14365?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-14365: -- Issue Type: Task (was: Improvement) > Extract common logic from Fetcher >

[jira] [Updated] (KAFKA-14758) Extract inner classes from Fetcher for reuse in refactoring

2023-06-29 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14758?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-14758: -- Issue Type: Task (was: Improvement) > Extract inner classes from Fetcher for reuse in refactoring >

[jira] [Updated] (KAFKA-14724) Port tests in FetcherTest to FetchRequestManagerTest

2023-06-29 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14724?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-14724: -- Issue Type: Task (was: Improvement) > Port tests in FetcherTest to FetchRequestManagerTest >

[jira] [Updated] (KAFKA-14724) Port tests in FetcherTest to FetchRequestManagerTest

2023-06-29 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14724?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-14724: -- Component/s: clients consumer > Port tests in FetcherTest to FetchRequestManagerTest

[jira] [Updated] (KAFKA-14848) KafkaConsumer incorrectly passes locally-scoped deserializers to FetchConfig

2023-06-29 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14848?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-14848: -- Labels: kip-945 (was: ) > KafkaConsumer incorrectly passes locally-scoped deserializers to

[jira] [Updated] (KAFKA-13445) Add ECDSA test for JWT validation

2023-06-29 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13445?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-13445: -- Labels: OAuth (was: ) > Add ECDSA test for JWT validation > - > >

[jira] [Updated] (KAFKA-13444) Fix OAuthCompatibilityTool help and add SSL options

2023-06-29 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13444?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-13444: -- Labels: OAuth (was: ) > Fix OAuthCompatibilityTool help and add SSL options >

[jira] [Updated] (KAFKA-13443) Kafka broker exits when OAuth enabled and certain configuration not specified

2023-06-29 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13443?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-13443: -- Labels: OAuth beginner (was: beginner) > Kafka broker exits when OAuth enabled and certain

[jira] [Updated] (KAFKA-14623) OAuth's HttpAccessTokenRetriever potentially leaks secrets in logging

2023-06-29 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14623?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-14623: -- Labels: OAuth (was: ) > OAuth's HttpAccessTokenRetriever potentially leaks secrets in logging >

[jira] [Updated] (KAFKA-13725) KIP-768 OAuth code mixes public and internal classes in same package

2023-06-29 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13725?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-13725: -- Labels: OAuth (was: ) > KIP-768 OAuth code mixes public and internal classes in same package >

[jira] [Updated] (KAFKA-13202) KIP-768: Extend SASL/OAUTHBEARER with Support for OIDC

2023-06-29 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13202?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-13202: -- Labels: OAuth (was: ) > KIP-768: Extend SASL/OAUTHBEARER with Support for OIDC >

[jira] [Updated] (KAFKA-13446) Remove JWT access token from logs

2023-06-29 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13446?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-13446: -- Labels: OAuth (was: ) > Remove JWT access token from logs > - > >

[jira] [Updated] (KAFKA-14724) Port tests in FetcherTest to FetchRequestManagerTest

2023-06-29 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14724?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-14724: -- Labels: kip-945 (was: ) > Port tests in FetcherTest to FetchRequestManagerTest >

[jira] [Updated] (KAFKA-14365) Extract common logic from Fetcher

2023-06-29 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14365?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-14365: -- Labels: kip-945 (was: ) > Extract common logic from Fetcher > - > >

[jira] [Updated] (KAFKA-14675) Extract metadata-related tasks from Fetcher into MetadataFetcher

2023-06-29 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14675?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-14675: -- Labels: kip-945 (was: ) > Extract metadata-related tasks from Fetcher into MetadataFetcher >

[jira] [Updated] (KAFKA-14758) Extract inner classes from Fetcher for reuse in refactoring

2023-06-29 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14758?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-14758: -- Labels: kip-945 (was: ) > Extract inner classes from Fetcher for reuse in refactoring >

[jira] [Updated] (KAFKA-14937) Refactoring for client code to reduce boilerplate

2023-06-29 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14937?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-14937: -- Parent: (was: KAFKA-14274) Issue Type: Improvement (was: Sub-task) > Refactoring for

[jira] [Updated] (KAFKA-14966) Extract reusable common logic from OffsetFetcher

2023-06-29 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14966?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-14966: -- Labels: kip-945 (was: ) > Extract reusable common logic from OffsetFetcher >

[jira] [Updated] (KAFKA-14937) Refactoring for client code to reduce boilerplate

2023-06-29 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14937?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-14937: -- Labels: kip-945 (was: ) > Refactoring for client code to reduce boilerplate >

[jira] [Updated] (KAFKA-14965) Introduce ListOffsetsRequestManager to integrate ListOffsetsRequests into new consumer threading refactor

2023-06-29 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14965?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-14965: -- Labels: kip-945 (was: ) > Introduce ListOffsetsRequestManager to integrate ListOffsetsRequests into

[jira] [Updated] (KAFKA-15081) Implement new consumer offsetsForTimes

2023-06-29 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15081?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-15081: -- Labels: kip-945 (was: ) > Implement new consumer offsetsForTimes >

[jira] [Updated] (KAFKA-15115) Implement resetPositions functionality in ListOffsetRequestManager

2023-06-29 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15115?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-15115: -- Labels: kip-945 (was: ) > Implement resetPositions functionality in ListOffsetRequestManager >

[jira] [Updated] (KAFKA-14252) Create background thread skeleton

2023-06-29 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14252?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-14252: -- Labels: kip-945 (was: ) > Create background thread skeleton > - > >

[jira] [Updated] (KAFKA-14247) Implement EventHandler interface and DefaultEventHandler

2023-06-29 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14247?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-14247: -- Labels: kip-945 (was: ) > Implement EventHandler interface and DefaultEventHandler >

[jira] [Updated] (KAFKA-14264) Refactor coordinator code

2023-06-29 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14264?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-14264: -- Labels: kip-945 (was: ) > Refactor coordinator code > - > >

[jira] [Commented] (KAFKA-15116) Kafka Streams processing blocked during rebalance

2023-06-29 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17738782#comment-17738782 ] Matthias J. Sax commented on KAFKA-15116: - > Message A uses an internal store to store

[jira] [Updated] (KAFKA-14274) Introduce FetchRequestManager to integrate fetch into new consumer threading refactor

2023-06-29 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14274?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-14274: -- Labels: kip-945 (was: ) > Introduce FetchRequestManager to integrate fetch into new consumer

[jira] [Updated] (KAFKA-14960) Metadata Request Manager and listTopics/partitionsFor API

2023-06-29 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14960?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-14960: -- Labels: kip-945 (was: ) > Metadata Request Manager and listTopics/partitionsFor API >

[jira] [Updated] (KAFKA-14950) Implement assign() and assignment()

2023-06-29 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14950?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-14950: -- Labels: kip-945 (was: ) > Implement assign() and assignment() > ---

[jira] [Updated] (KAFKA-14875) Implement Wakeup()

2023-06-29 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14875?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-14875: -- Labels: kip-945 (was: ) > Implement Wakeup() > -- > > Key:

[jira] [Updated] (KAFKA-14468) Refactor Commit Logic

2023-06-29 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14468?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-14468: -- Labels: kip-945 (was: ) > Refactor Commit Logic > - > > Key:

[jira] [Updated] (KAFKA-14246) Update threading model for Consumer

2023-06-29 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14246?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-14246: -- Labels: kip-945 (was: ) > Update threading model for Consumer > ---

[jira] [Updated] (KAFKA-14761) Integration Tests for the New Consumer Implementation

2023-06-29 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14761?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-14761: -- Parent: KAFKA-14246 Issue Type: Sub-task (was: Task) > Integration Tests for the New

[jira] [Updated] (KAFKA-14875) Implement Wakeup()

2023-06-29 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14875?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-14875: -- Parent: KAFKA-14246 Issue Type: Sub-task (was: Task) > Implement Wakeup() >

[jira] [Updated] (KAFKA-14761) Integration Tests for the New Consumer Implementation

2023-06-29 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14761?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-14761: -- Labels: kip-945 (was: ) > Integration Tests for the New Consumer Implementation >

[GitHub] [kafka] jolshan commented on a diff in pull request #13901: KAFKA-14462; [20/N] Refresh subscription metadata on new metadata image

2023-06-29 Thread via GitHub
jolshan commented on code in PR #13901: URL: https://github.com/apache/kafka/pull/13901#discussion_r1247163837 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java: ## @@ -172,19 +186,21 @@ public List build(TopicsImage

[jira] [Updated] (KAFKA-14246) Update threading model for Consumer

2023-06-29 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14246?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-14246: -- Summary: Update threading model for Consumer (was: Refactor KafkaConsumer Threading Model) > Update

[GitHub] [kafka] jolshan commented on a diff in pull request #13901: KAFKA-14462; [20/N] Refresh subscription metadata on new metadata image

2023-06-29 Thread via GitHub
jolshan commented on code in PR #13901: URL: https://github.com/apache/kafka/pull/13901#discussion_r1247156849 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -728,6 +794,81 @@ public void replay( }

[GitHub] [kafka] jolshan commented on a diff in pull request #13901: KAFKA-14462; [20/N] Refresh subscription metadata on new metadata image

2023-06-29 Thread via GitHub
jolshan commented on code in PR #13901: URL: https://github.com/apache/kafka/pull/13901#discussion_r1247155039 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/runtime/CoordinatorRuntimeTest.java: ## @@ -825,4 +828,60 @@ public void testClose() throws

[GitHub] [kafka] jolshan commented on a diff in pull request #13901: KAFKA-14462; [20/N] Refresh subscription metadata on new metadata image

2023-06-29 Thread via GitHub
jolshan commented on code in PR #13901: URL: https://github.com/apache/kafka/pull/13901#discussion_r1247154202 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/runtime/CoordinatorRuntimeTest.java: ## @@ -825,4 +828,60 @@ public void testClose() throws

[GitHub] [kafka] kirktrue commented on pull request #13591: KAFKA-14831: Illegal state errors should be fatal in transactional producer

2023-06-29 Thread via GitHub
kirktrue commented on PR #13591: URL: https://github.com/apache/kafka/pull/13591#issuecomment-1613748954 Thanks @jolshan, @urbandan, and @hachikuji for the reviews! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[jira] [Comment Edited] (KAFKA-15102) Mirror Maker 2 - KIP690 backward compatibility

2023-06-29 Thread Omnia Ibrahim (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17738744#comment-17738744 ] Omnia Ibrahim edited comment on KAFKA-15102 at 6/29/23 7:30 PM: Thanks,

[GitHub] [kafka] C0urante merged pull request #13934: MINOR: Replace synchronization with atomic update in Connect's StateTracker::changeState method

2023-06-29 Thread via GitHub
C0urante merged PR #13934: URL: https://github.com/apache/kafka/pull/13934 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Comment Edited] (KAFKA-15102) Mirror Maker 2 - KIP690 backward compatibility

2023-06-29 Thread Omnia Ibrahim (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17738744#comment-17738744 ] Omnia Ibrahim edited comment on KAFKA-15102 at 6/29/23 7:01 PM: Thanks,

[jira] [Comment Edited] (KAFKA-15102) Mirror Maker 2 - KIP690 backward compatibility

2023-06-29 Thread Omnia Ibrahim (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17738744#comment-17738744 ] Omnia Ibrahim edited comment on KAFKA-15102 at 6/29/23 7:00 PM: Thanks,

[jira] [Comment Edited] (KAFKA-15102) Mirror Maker 2 - KIP690 backward compatibility

2023-06-29 Thread Omnia Ibrahim (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17738744#comment-17738744 ] Omnia Ibrahim edited comment on KAFKA-15102 at 6/29/23 7:00 PM: Thanks,

[jira] [Comment Edited] (KAFKA-15102) Mirror Maker 2 - KIP690 backward compatibility

2023-06-29 Thread Omnia Ibrahim (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17738744#comment-17738744 ] Omnia Ibrahim edited comment on KAFKA-15102 at 6/29/23 7:00 PM: Thanks,

[jira] [Comment Edited] (KAFKA-15102) Mirror Maker 2 - KIP690 backward compatibility

2023-06-29 Thread Omnia Ibrahim (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17738744#comment-17738744 ] Omnia Ibrahim edited comment on KAFKA-15102 at 6/29/23 7:00 PM: Thanks,

[jira] [Commented] (KAFKA-15102) Mirror Maker 2 - KIP690 backward compatibility

2023-06-29 Thread Omnia Ibrahim (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17738744#comment-17738744 ] Omnia Ibrahim commented on KAFKA-15102: --- Thanks, [~ddufour1a] for raising this. The backward

[GitHub] [kafka] jolshan commented on a diff in pull request #13901: KAFKA-14462; [20/N] Refresh subscription metadata on new metadata image

2023-06-29 Thread via GitHub
jolshan commented on code in PR #13901: URL: https://github.com/apache/kafka/pull/13901#discussion_r1246997020 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroupTest.java: ## @@ -537,8 +538,35 @@ public void

[jira] [Commented] (KAFKA-15113) Gracefully handle cases where a sink connector's admin and consumer client config overrides target different Kafka clusters

2023-06-29 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17738740#comment-17738740 ] Chris Egerton commented on KAFKA-15113: --- [~yash.mayya] although it seems a little unlikely, I

[jira] [Comment Edited] (KAFKA-15102) Mirror Maker 2 - KIP690 backward compatibility

2023-06-29 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17738733#comment-17738733 ] Chris Egerton edited comment on KAFKA-15102 at 6/29/23 6:43 PM:

[jira] [Commented] (KAFKA-15102) Mirror Maker 2 - KIP690 backward compatibility

2023-06-29 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17738733#comment-17738733 ] Chris Egerton commented on KAFKA-15102: --- [~ddufour1a] Thanks for raising this. I believe if we

[GitHub] [kafka] jolshan commented on pull request #13876: KAFKA-10733: Clean up producer exceptions

2023-06-29 Thread via GitHub
jolshan commented on PR #13876: URL: https://github.com/apache/kafka/pull/13876#issuecomment-1613602815 @lucasbru -- I'm also thinking about consistency from the sense of compatibility with previous state. Ideally our final state will balance consistency in how we handle errors (so new

[GitHub] [kafka] jolshan merged pull request #13591: KAFKA-14831: Illegal state errors should be fatal in transactional producer

2023-06-29 Thread via GitHub
jolshan merged PR #13591: URL: https://github.com/apache/kafka/pull/13591 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] jolshan commented on pull request #13591: KAFKA-14831: Illegal state errors should be fatal in transactional producer

2023-06-29 Thread via GitHub
jolshan commented on PR #13591: URL: https://github.com/apache/kafka/pull/13591#issuecomment-1613597535 Ok -- test failures seem to be consistent with current trunk and not due to this change. Will go ahead and merge. -- This is an automated message from the Apache Git Service. To

[GitHub] [kafka] C0urante merged pull request #13933: MINOR: Update anchor link for exactly-once source connectors

2023-06-29 Thread via GitHub
C0urante merged PR #13933: URL: https://github.com/apache/kafka/pull/13933 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] cmccabe merged pull request #13904: KAFKA-15114: Minor: Update help in StorageTool for creating SCRAM credentials for KRaft bootstrap.

2023-06-29 Thread via GitHub
cmccabe merged PR #13904: URL: https://github.com/apache/kafka/pull/13904 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (KAFKA-15127) Allow offsets to be reset at the same time a connector is deleted.

2023-06-29 Thread Sagar Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17738704#comment-17738704 ] Sagar Rao commented on KAFKA-15127: --- I don't intend working on this immediately or in the near future.

[jira] [Resolved] (KAFKA-15053) Regression for security.protocol validation starting from 3.3.0

2023-06-29 Thread Divij Vaidya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15053?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Divij Vaidya resolved KAFKA-15053. -- Reviewer: Divij Vaidya Resolution: Fixed > Regression for security.protocol validation

[jira] [Updated] (KAFKA-15053) Regression for security.protocol validation starting from 3.3.0

2023-06-29 Thread Divij Vaidya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15053?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Divij Vaidya updated KAFKA-15053: - Labels: backport (was: ) > Regression for security.protocol validation starting from 3.3.0 >

[jira] [Updated] (KAFKA-15053) Regression for security.protocol validation starting from 3.3.0

2023-06-29 Thread Divij Vaidya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15053?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Divij Vaidya updated KAFKA-15053: - Fix Version/s: 3.3.3 3.5.1 3.4.2 > Regression for

[GitHub] [kafka] C0urante commented on pull request #13530: KAFKA-14858: Handle exceptions thrown from Connector::taskConfigs in Connect's standalone mode

2023-06-29 Thread via GitHub
C0urante commented on PR #13530: URL: https://github.com/apache/kafka/pull/13530#issuecomment-1613554645 Hmmm... is there an advantage to enabling users to pause/resume a failed connector? I feel like restarting it is still the natural corrective action in that case, which will also cause

[GitHub] [kafka] divijvaidya opened a new pull request, #13936: MINOR: Refactor & cleanup for RemoteIndexCache

2023-06-29 Thread via GitHub
divijvaidya opened a new pull request, #13936: URL: https://github.com/apache/kafka/pull/13936 **Changes** 1. Add new unit tests 2. Change the on-disk filename from `__.` to `_.` i.e. remove trailing suffix 3. Fix a small bug where we were parsing offset as Int when reading the

[GitHub] [kafka] hudeqi commented on pull request #13913: KAFKA-15119:Support incremental syncTopicAcls in MirrorSourceConnector

2023-06-29 Thread via GitHub
hudeqi commented on PR #13913: URL: https://github.com/apache/kafka/pull/13913#issuecomment-1613529431 Hi! please help to review this PR when you are free, thank you! @C0urante -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [kafka] hudeqi commented on pull request #13924: KAFKA-15129;[1/N] Remove metrics in LogCleanerManager when LogCleaner shutdown

2023-06-29 Thread via GitHub
hudeqi commented on PR #13924: URL: https://github.com/apache/kafka/pull/13924#issuecomment-1613525851 I have submitted some PRs (two others: https://github.com/apache/kafka/pull/13926、https://github.com/apache/kafka/pull/13929) on the topic of "clean metric", please help to review, thank

[GitHub] [kafka] hudeqi commented on pull request #13930: KAFKA-15134:Enrich the prompt reason in CommitFailedException

2023-06-29 Thread via GitHub
hudeqi commented on PR #13930: URL: https://github.com/apache/kafka/pull/13930#issuecomment-1613522211 Hi! Could you help to review this PR? @hachikuji @guozhangwang -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [kafka] C0urante commented on pull request #13302: KAFKA-14759: Move Mock, Schema, and Verifiable connectors to new test-plugins module

2023-06-29 Thread via GitHub
C0urante commented on PR #13302: URL: https://github.com/apache/kafka/pull/13302#issuecomment-1613519953 Verified locally by running the `ConnectDistributedTest::test_file_source_and_sink`, `ConnectDistributedTest::test_bounce`, and `ConnectStandaloneFileTest::test_file_source_and_sink`

  1   2   >