[GitHub] [kafka] satishd merged pull request #14045: MINOR: refactor(storage): topic-based RLMM consumer-manager/task related improvements

2023-07-21 Thread via GitHub
satishd merged PR #14045: URL: https://github.com/apache/kafka/pull/14045 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] satishd commented on pull request #14045: MINOR: refactor(storage): topic-based RLMM consumer-manager/task related improvements

2023-07-21 Thread via GitHub
satishd commented on PR #14045: URL: https://github.com/apache/kafka/pull/14045#issuecomment-1646452657 A few failed tests are observed on the Jenkins build jobs but they do not seem to be related, merging it to trunk. -- This is an automated message from the Apache Git Service. To

[GitHub] [kafka] kirktrue commented on pull request #13990: KAFKA-14937: Refactoring for client code to reduce boilerplate

2023-07-21 Thread via GitHub
kirktrue commented on PR #13990: URL: https://github.com/apache/kafka/pull/13990#issuecomment-1646378435 @junrao The JDK 11, 17, and 20 test runs output this as their last test execution: ``` Gradle Test Run :streams:integrationTest > Gradle Test Executor 177 >

[GitHub] [kafka] kirktrue commented on pull request #13990: KAFKA-14937: Refactoring for client code to reduce boilerplate

2023-07-21 Thread via GitHub
kirktrue commented on PR #13990: URL: https://github.com/apache/kafka/pull/13990#issuecomment-1646371022 @junrao In [the JDK 11 run](https://ci-builds.apache.org/blue/organizations/jenkins/Kafka%2Fkafka-pr/detail/PR-13990/23/tests), `DeleteTopicTest.testDeleteTopicWithCleaner()` fails and

[GitHub] [kafka] jolshan commented on a diff in pull request #14067: KAFKA-14499: [3/N] Implement OffsetCommit API

2023-07-21 Thread via GitHub
jolshan commented on code in PR #14067: URL: https://github.com/apache/kafka/pull/14067#discussion_r1271176157 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetMetadataManager.java: ## @@ -0,0 +1,448 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] jolshan commented on a diff in pull request #14067: KAFKA-14499: [3/N] Implement OffsetCommit API

2023-07-21 Thread via GitHub
jolshan commented on code in PR #14067: URL: https://github.com/apache/kafka/pull/14067#discussion_r1271176157 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetMetadataManager.java: ## @@ -0,0 +1,448 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] jolshan commented on a diff in pull request #14067: KAFKA-14499: [3/N] Implement OffsetCommit API

2023-07-21 Thread via GitHub
jolshan commented on code in PR #14067: URL: https://github.com/apache/kafka/pull/14067#discussion_r1271173194 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -408,6 +408,31 @@ public MetadataImage image() { return

[GitHub] [kafka] jolshan commented on a diff in pull request #14067: KAFKA-14499: [3/N] Implement OffsetCommit API

2023-07-21 Thread via GitHub
jolshan commented on code in PR #14067: URL: https://github.com/apache/kafka/pull/14067#discussion_r1271172931 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetMetadataManager.java: ## @@ -0,0 +1,448 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] jolshan commented on a diff in pull request #14067: KAFKA-14499: [3/N] Implement OffsetCommit API

2023-07-21 Thread via GitHub
jolshan commented on code in PR #14067: URL: https://github.com/apache/kafka/pull/14067#discussion_r1271172931 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetMetadataManager.java: ## @@ -0,0 +1,448 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] jolshan commented on a diff in pull request #14067: KAFKA-14499: [3/N] Implement OffsetCommit API

2023-07-21 Thread via GitHub
jolshan commented on code in PR #14067: URL: https://github.com/apache/kafka/pull/14067#discussion_r1271172399 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetMetadataManager.java: ## @@ -0,0 +1,448 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] jolshan commented on a diff in pull request #14067: KAFKA-14499: [3/N] Implement OffsetCommit API

2023-07-21 Thread via GitHub
jolshan commented on code in PR #14067: URL: https://github.com/apache/kafka/pull/14067#discussion_r1271168880 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorService.java: ## @@ -471,9 +472,48 @@ public CompletableFuture commitOffsets(

[GitHub] [kafka] jolshan commented on a diff in pull request #14062: MINOR: Add a Builder for KRaftMigrationDriver

2023-07-21 Thread via GitHub
jolshan commented on code in PR #14062: URL: https://github.com/apache/kafka/pull/14062#discussion_r1271166831 ## metadata/src/main/java/org/apache/kafka/metadata/migration/KRaftMigrationDriver.java: ## @@ -756,4 +745,109 @@ static KRaftMigrationOperationConsumer

[GitHub] [kafka] mjsax commented on a diff in pull request #14030: KAFKA-15022: [3/N] use graph to compute rack aware assignment for active stateful tasks

2023-07-21 Thread via GitHub
mjsax commented on code in PR #14030: URL: https://github.com/apache/kafka/pull/14030#discussion_r1271152663 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/RackAwareTaskAssignor.java: ## @@ -185,4 +191,224 @@ public boolean validateClientRack()

[GitHub] [kafka] mjsax commented on a diff in pull request #14030: KAFKA-15022: [3/N] use graph to compute rack aware assignment for active stateful tasks

2023-07-21 Thread via GitHub
mjsax commented on code in PR #14030: URL: https://github.com/apache/kafka/pull/14030#discussion_r1271152663 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/RackAwareTaskAssignor.java: ## @@ -185,4 +191,224 @@ public boolean validateClientRack()

[GitHub] [kafka] mjsax commented on a diff in pull request #14030: KAFKA-15022: [3/N] use graph to compute rack aware assignment for active stateful tasks

2023-07-21 Thread via GitHub
mjsax commented on code in PR #14030: URL: https://github.com/apache/kafka/pull/14030#discussion_r1271151967 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/RackAwareTaskAssignor.java: ## @@ -185,4 +191,224 @@ public boolean validateClientRack()

[GitHub] [kafka] mjsax commented on a diff in pull request #14030: KAFKA-15022: [3/N] use graph to compute rack aware assignment for active stateful tasks

2023-07-21 Thread via GitHub
mjsax commented on code in PR #14030: URL: https://github.com/apache/kafka/pull/14030#discussion_r1270106140 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/RackAwareTaskAssignor.java: ## @@ -185,4 +191,224 @@ public boolean validateClientRack()

[GitHub] [kafka] mjsax commented on a diff in pull request #13996: KAFKA-15022: [2/N] introduce graph to compute min cost

2023-07-21 Thread via GitHub
mjsax commented on code in PR #13996: URL: https://github.com/apache/kafka/pull/13996#discussion_r1271148006 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/assignment/GraphTest.java: ## @@ -0,0 +1,414 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [kafka] mjsax commented on a diff in pull request #13996: KAFKA-15022: [2/N] introduce graph to compute min cost

2023-07-21 Thread via GitHub
mjsax commented on code in PR #13996: URL: https://github.com/apache/kafka/pull/13996#discussion_r1271147536 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/Graph.java: ## @@ -0,0 +1,377 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [kafka] mjsax commented on a diff in pull request #13996: KAFKA-15022: [2/N] introduce graph to compute min cost

2023-07-21 Thread via GitHub
mjsax commented on code in PR #13996: URL: https://github.com/apache/kafka/pull/13996#discussion_r1270057798 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/assignment/GraphTest.java: ## @@ -0,0 +1,414 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [kafka] splett2 commented on pull request #14050: KAFKA-15220: Do not returned fenced brokers from getAliveBrokerNode

2023-07-21 Thread via GitHub
splett2 commented on PR #14050: URL: https://github.com/apache/kafka/pull/14050#issuecomment-1646268752 Failing tests: ``` Build / JDK 8 and Scala 2.12 / testOffsetTranslationBehindReplicationFlow() –

[GitHub] [kafka] junrao commented on pull request #13990: KAFKA-14937: Refactoring for client code to reduce boilerplate

2023-07-21 Thread via GitHub
junrao commented on PR #13990: URL: https://github.com/apache/kafka/pull/13990#issuecomment-1646244882 @kirktrue : In the latest run, it seems that most test failures are from java 11. I'd suggest looking at the jenkins's log to see the first test that failed. Sometimes, a failed test

[jira] [Resolved] (KAFKA-14950) Implement assign() and assignment()

2023-07-21 Thread Jun Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14950?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao resolved KAFKA-14950. - Fix Version/s: 3.6.0 Resolution: Fixed merged the PR to trunk. > Implement assign() and

[GitHub] [kafka] junrao merged pull request #13797: KAFKA-14950: implement assign() and assignment()

2023-07-21 Thread via GitHub
junrao merged PR #13797: URL: https://github.com/apache/kafka/pull/13797 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] lihaosky commented on a diff in pull request #14030: KAFKA-15022: [3/N] use graph to compute rack aware assignment for active stateful tasks

2023-07-21 Thread via GitHub
lihaosky commented on code in PR #14030: URL: https://github.com/apache/kafka/pull/14030#discussion_r1271098823 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/RackAwareTaskAssignor.java: ## @@ -38,29 +43,34 @@ public class

[GitHub] [kafka] lihaosky commented on a diff in pull request #14030: KAFKA-15022: [3/N] use graph to compute rack aware assignment for active stateful tasks

2023-07-21 Thread via GitHub
lihaosky commented on code in PR #14030: URL: https://github.com/apache/kafka/pull/14030#discussion_r1271081266 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/RackAwareTaskAssignor.java: ## @@ -185,4 +191,224 @@ public boolean

[GitHub] [kafka] gharris1727 commented on a diff in pull request #14055: KAFKA-15031: Add plugin.discovery to Connect worker configuration (KIP-898)

2023-07-21 Thread via GitHub
gharris1727 commented on code in PR #14055: URL: https://github.com/apache/kafka/pull/14055#discussion_r1271051021 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/isolation/Plugins.java: ## @@ -63,16 +67,72 @@ public Plugins(Map props) { //

[GitHub] [kafka] gharris1727 opened a new pull request, #14068: KAFKA-15233: Add documentation for plugin.discovery and connect-plugin-path (KIP-898)

2023-07-21 Thread via GitHub
gharris1727 opened a new pull request, #14068: URL: https://github.com/apache/kafka/pull/14068 This is a restatement of the contents of KIP-898, geared towards a wider audience. This documentation is linked from error messages in #14055. ### Committer Checklist (excluded from

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #13998: KAFKA-14702: Extend server side assignor to support rack aware replica placement

2023-07-21 Thread via GitHub
rreddy-22 commented on code in PR #13998: URL: https://github.com/apache/kafka/pull/13998#discussion_r1271047554 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/TargetAssignmentBuilder.java: ## @@ -244,16 +245,18 @@ public TargetAssignmentResult

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #13998: KAFKA-14702: Extend server side assignor to support rack aware replica placement

2023-07-21 Thread via GitHub
rreddy-22 commented on code in PR #13998: URL: https://github.com/apache/kafka/pull/13998#discussion_r1271047554 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/TargetAssignmentBuilder.java: ## @@ -244,16 +245,18 @@ public TargetAssignmentResult

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #13998: KAFKA-14702: Extend server side assignor to support rack aware replica placement

2023-07-21 Thread via GitHub
rreddy-22 commented on code in PR #13998: URL: https://github.com/apache/kafka/pull/13998#discussion_r1271043473 ## group-coordinator/src/main/resources/common/message/ConsumerGroupPartitionMetadataValue.json: ## @@ -29,7 +29,27 @@ { "name": "TopicName", "versions":

[GitHub] [kafka] kirktrue commented on pull request #13990: KAFKA-14937: Refactoring for client code to reduce boilerplate

2023-07-21 Thread via GitHub
kirktrue commented on PR #13990: URL: https://github.com/apache/kafka/pull/13990#issuecomment-1646176441 > @kirktrue : It seems there were 4 test failures for jdk 11. But the tests for jdk 17 and 20 were aborted. Do you know why? @junrao I don't know why yet, no  I have

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #13998: KAFKA-14702: Extend server side assignor to support rack aware replica placement

2023-07-21 Thread via GitHub
rreddy-22 commented on code in PR #13998: URL: https://github.com/apache/kafka/pull/13998#discussion_r1271036247 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/TopicMetadata.java: ## @@ -40,23 +44,31 @@ public class TopicMetadata { */

[jira] [Commented] (KAFKA-15132) Implement disable & re-enablement for Tiered Storage

2023-07-21 Thread Mehari Beyene (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17745705#comment-17745705 ] Mehari Beyene commented on KAFKA-15132: --- KIP:

[GitHub] [kafka] philipnee commented on pull request #13797: KAFKA-14950: implement assign() and assignment()

2023-07-21 Thread via GitHub
philipnee commented on PR #13797: URL: https://github.com/apache/kafka/pull/13797#issuecomment-1646161376 Hey @junrao - Thanks again. I updated the description to reflect the updated code more accurately. Here I just quoted the paragraph I made the change to: ``` We will explicitly

[GitHub] [kafka] lihaosky commented on a diff in pull request #13996: KAFKA-15022: [2/N] introduce graph to compute min cost

2023-07-21 Thread via GitHub
lihaosky commented on code in PR #13996: URL: https://github.com/apache/kafka/pull/13996#discussion_r1271010298 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/assignment/GraphTest.java: ## @@ -0,0 +1,414 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] junrao commented on pull request #13947: KAFKA-15130: Delete remote segments when delete a topic

2023-07-21 Thread via GitHub
junrao commented on PR #13947: URL: https://github.com/apache/kafka/pull/13947#issuecomment-1646140881 Thanks for the comment @clolov. It seems this PR calls `RemoteLogManager.stopPartitions()`. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [kafka] junrao commented on a diff in pull request #13947: KAFKA-15130: Delete remote segments when delete a topic

2023-07-21 Thread via GitHub
junrao commented on code in PR #13947: URL: https://github.com/apache/kafka/pull/13947#discussion_r1270993960 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -119,6 +119,8 @@ public class RemoteLogManager implements Closeable { private static final

[GitHub] [kafka] junrao commented on pull request #13797: KAFKA-14950: implement assign() and assignment()

2023-07-21 Thread via GitHub
junrao commented on PR #13797: URL: https://github.com/apache/kafka/pull/13797#issuecomment-1646102324 @philipnee : Could you update the description of the PR (to be included in the commit message) before I merge it? The description still has the following and I am not sure if it's still

[GitHub] [kafka] lihaosky commented on a diff in pull request #13996: KAFKA-15022: [2/N] introduce graph to compute min cost

2023-07-21 Thread via GitHub
lihaosky commented on code in PR #13996: URL: https://github.com/apache/kafka/pull/13996#discussion_r1270971692 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/assignment/GraphTest.java: ## @@ -0,0 +1,414 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] dajac commented on a diff in pull request #13998: KAFKA-14702: Extend server side assignor to support rack aware replica placement

2023-07-21 Thread via GitHub
dajac commented on code in PR #13998: URL: https://github.com/apache/kafka/pull/13998#discussion_r1270971855 ## group-coordinator/src/main/resources/common/message/ConsumerGroupPartitionMetadataValue.json: ## @@ -29,7 +29,27 @@ { "name": "TopicName", "versions": "0+",

[GitHub] [kafka] mimaison merged pull request #14066: KAFKA-15232: Move ToolsUtils to tools

2023-07-21 Thread via GitHub
mimaison merged PR #14066: URL: https://github.com/apache/kafka/pull/14066 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] dajac commented on a diff in pull request #13998: KAFKA-14702: Extend server side assignor to support rack aware replica placement

2023-07-21 Thread via GitHub
dajac commented on code in PR #13998: URL: https://github.com/apache/kafka/pull/13998#discussion_r1270967491 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/AssignmentTopicDescriber.java: ## @@ -0,0 +1,59 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] gharris1727 commented on pull request #14055: KAFKA-15031: Add plugin.discovery to Connect worker configuration (KIP-898)

2023-07-21 Thread via GitHub
gharris1727 commented on PR #14055: URL: https://github.com/apache/kafka/pull/14055#issuecomment-1646086669 > The question of plugins that are installed directly onto the classpath might be a bit tricky... let me know if I've missed something. My current understanding is that these plugins

[GitHub] [kafka] dajac commented on a diff in pull request #13998: KAFKA-14702: Extend server side assignor to support rack aware replica placement

2023-07-21 Thread via GitHub
dajac commented on code in PR #13998: URL: https://github.com/apache/kafka/pull/13998#discussion_r1270966763 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/AssignmentTopicMetadata.java: ## @@ -16,44 +16,83 @@ */ package

[GitHub] [kafka] dajac commented on a diff in pull request #13998: KAFKA-14702: Extend server side assignor to support rack aware replica placement

2023-07-21 Thread via GitHub
dajac commented on code in PR #13998: URL: https://github.com/apache/kafka/pull/13998#discussion_r1270965310 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/RangeAssignor.java: ## @@ -87,7 +87,7 @@ private Map> membersPerTopic(final

[jira] [Comment Edited] (KAFKA-15116) Kafka Streams processing blocked during rebalance

2023-07-21 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17745690#comment-17745690 ] Matthias J. Sax edited comment on KAFKA-15116 at 7/21/23 6:18 PM: --

[jira] [Commented] (KAFKA-15116) Kafka Streams processing blocked during rebalance

2023-07-21 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17745690#comment-17745690 ] Matthias J. Sax commented on KAFKA-15116: - {quote}The internal store is shared across stream

[GitHub] [kafka] dajac commented on a diff in pull request #14067: KAFKA-14499: [3/N] Implement OffsetCommit API

2023-07-21 Thread via GitHub
dajac commented on code in PR #14067: URL: https://github.com/apache/kafka/pull/14067#discussion_r1270960303 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetMetadataManager.java: ## @@ -0,0 +1,448 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [kafka] dajac commented on a diff in pull request #14067: KAFKA-14499: [3/N] Implement OffsetCommit API

2023-07-21 Thread via GitHub
dajac commented on code in PR #14067: URL: https://github.com/apache/kafka/pull/14067#discussion_r1270959863 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetMetadataManager.java: ## @@ -0,0 +1,448 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [kafka] dajac commented on a diff in pull request #14067: KAFKA-14499: [3/N] Implement OffsetCommit API

2023-07-21 Thread via GitHub
dajac commented on code in PR #14067: URL: https://github.com/apache/kafka/pull/14067#discussion_r1270959230 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetMetadataManager.java: ## @@ -0,0 +1,448 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [kafka] dajac opened a new pull request, #14067: KAFKA-14499: [3/N] Implement OffsetCommit API

2023-07-21 Thread via GitHub
dajac opened a new pull request, #14067: URL: https://github.com/apache/kafka/pull/14067 This patch introduces the `OffsetMetadataManager` and implements the `OffsetCommit` API for both the old rebalance protocol and the new rebalance protocol. ### Committer Checklist (excluded from

[GitHub] [kafka] dajac merged pull request #14047: KAFKA-14499: [2/N] Add OffsetCommit record & related

2023-07-21 Thread via GitHub
dajac merged PR #14047: URL: https://github.com/apache/kafka/pull/14047 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] dajac commented on pull request #14047: KAFKA-14499: [2/N] Add OffsetCommit record & related

2023-07-21 Thread via GitHub
dajac commented on PR #14047: URL: https://github.com/apache/kafka/pull/14047#issuecomment-1646069623 Failed tests are unrelated. Merging to trunk. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka] dajac merged pull request #14046: KAFKA-14499: [1/N] Introduce OffsetCommit API version 9 and add new StaleMemberEpochException error

2023-07-21 Thread via GitHub
dajac merged PR #14046: URL: https://github.com/apache/kafka/pull/14046 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] dajac commented on pull request #14046: KAFKA-14499: [1/N] Introduce OffsetCommit API version 9 and add new StaleMemberEpochException error

2023-07-21 Thread via GitHub
dajac commented on PR #14046: URL: https://github.com/apache/kafka/pull/14046#issuecomment-1646067746 Failed tests are unrelated. Merging to trunk. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka] jeffkbkim commented on a diff in pull request #14017: KAFKA-14500; [6/6] Implement SyncGroup protocol in new GroupCoordinator

2023-07-21 Thread via GitHub
jeffkbkim commented on code in PR #14017: URL: https://github.com/apache/kafka/pull/14017#discussion_r1270946493 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java: ## @@ -5524,5 +5670,2897 @@ private static Record

[jira] [Created] (KAFKA-15233) Add public documentation for plugin.discovery migration steps

2023-07-21 Thread Greg Harris (Jira)
Greg Harris created KAFKA-15233: --- Summary: Add public documentation for plugin.discovery migration steps Key: KAFKA-15233 URL: https://issues.apache.org/jira/browse/KAFKA-15233 Project: Kafka

[GitHub] [kafka] jeffkbkim commented on a diff in pull request #14017: KAFKA-14500; [6/6] Implement SyncGroup protocol in new GroupCoordinator

2023-07-21 Thread via GitHub
jeffkbkim commented on code in PR #14017: URL: https://github.com/apache/kafka/pull/14017#discussion_r1270943845 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java: ## @@ -5524,5 +5670,2897 @@ private static Record

[GitHub] [kafka] jeffkbkim commented on a diff in pull request #14017: KAFKA-14500; [6/6] Implement SyncGroup protocol in new GroupCoordinator

2023-07-21 Thread via GitHub
jeffkbkim commented on code in PR #14017: URL: https://github.com/apache/kafka/pull/14017#discussion_r1270940010 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java: ## @@ -5524,5 +5670,2897 @@ private static Record

[GitHub] [kafka] jeffkbkim commented on a diff in pull request #14017: KAFKA-14500; [6/6] Implement SyncGroup protocol in new GroupCoordinator

2023-07-21 Thread via GitHub
jeffkbkim commented on code in PR #14017: URL: https://github.com/apache/kafka/pull/14017#discussion_r1270939083 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java: ## @@ -5524,5 +5670,2897 @@ private static Record

[GitHub] [kafka] gharris1727 commented on a diff in pull request #14055: KAFKA-15031: Add plugin.discovery to Connect worker configuration (KIP-898)

2023-07-21 Thread via GitHub
gharris1727 commented on code in PR #14055: URL: https://github.com/apache/kafka/pull/14055#discussion_r1270918323 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/isolation/Plugins.java: ## @@ -63,16 +67,72 @@ public Plugins(Map props) { //

[GitHub] [kafka] jeffkbkim commented on a diff in pull request #14017: KAFKA-14500; [6/6] Implement SyncGroup protocol in new GroupCoordinator

2023-07-21 Thread via GitHub
jeffkbkim commented on code in PR #14017: URL: https://github.com/apache/kafka/pull/14017#discussion_r1270937110 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -2643,9 +2652,175 @@ private CoordinatorResult

[GitHub] [kafka] jeffkbkim commented on a diff in pull request #14017: KAFKA-14500; [6/6] Implement SyncGroup protocol in new GroupCoordinator

2023-07-21 Thread via GitHub
jeffkbkim commented on code in PR #14017: URL: https://github.com/apache/kafka/pull/14017#discussion_r1270934792 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java: ## @@ -5524,5 +5670,2897 @@ private static Record

[GitHub] [kafka] jeffkbkim commented on a diff in pull request #14017: KAFKA-14500; [6/6] Implement SyncGroup protocol in new GroupCoordinator

2023-07-21 Thread via GitHub
jeffkbkim commented on code in PR #14017: URL: https://github.com/apache/kafka/pull/14017#discussion_r1270929646 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java: ## @@ -5524,5 +5670,2897 @@ private static Record

[GitHub] [kafka] jeffkbkim commented on a diff in pull request #14017: KAFKA-14500; [6/6] Implement SyncGroup protocol in new GroupCoordinator

2023-07-21 Thread via GitHub
jeffkbkim commented on code in PR #14017: URL: https://github.com/apache/kafka/pull/14017#discussion_r1270926383 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java: ## @@ -5524,5 +5670,2897 @@ private static Record

[GitHub] [kafka] ruslankrivoshein commented on a diff in pull request #13562: KAFKA-14581: Moving GetOffsetShell to tools

2023-07-21 Thread via GitHub
ruslankrivoshein commented on code in PR #13562: URL: https://github.com/apache/kafka/pull/13562#discussion_r1270907553 ## tools/src/main/java/org/apache/kafka/tools/ToolsUtils.java: ## @@ -0,0 +1,44 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more

[GitHub] [kafka] jeffkbkim commented on a diff in pull request #14017: KAFKA-14500; [6/6] Implement SyncGroup protocol in new GroupCoordinator

2023-07-21 Thread via GitHub
jeffkbkim commented on code in PR #14017: URL: https://github.com/apache/kafka/pull/14017#discussion_r1270901334 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java: ## @@ -5524,5 +5670,2897 @@ private static Record

[GitHub] [kafka] nizhikov commented on pull request #13247: KAFKA-14595 Move value objects of ReassignPartitionsCommand to java

2023-07-21 Thread via GitHub
nizhikov commented on PR #13247: URL: https://github.com/apache/kafka/pull/13247#issuecomment-1645993319 @mimaison Thanks for the review. I will address your comments in the nearest time. -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] nizhikov commented on pull request #13278: KAFKA-14591 DeleteRecordsCommand moved to tools

2023-07-21 Thread via GitHub
nizhikov commented on PR #13278: URL: https://github.com/apache/kafka/pull/13278#issuecomment-1645987767 @fvaleri @mimaison Thank you for the review and merge! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [kafka] fvaleri commented on a diff in pull request #13417: KAFKA-14585: Moving StorageTool from core to tools module

2023-07-21 Thread via GitHub
fvaleri commented on code in PR #13417: URL: https://github.com/apache/kafka/pull/13417#discussion_r1270828901 ## checkstyle/import-control.xml: ## @@ -302,6 +302,11 @@ + + + + + Review Comment: This entry is duplicated, and we don't

[GitHub] [kafka] fvaleri commented on a diff in pull request #13562: KAFKA-14581: Moving GetOffsetShell to tools

2023-07-21 Thread via GitHub
fvaleri commented on code in PR #13562: URL: https://github.com/apache/kafka/pull/13562#discussion_r1270884317 ## tools/src/main/java/org/apache/kafka/tools/ToolsUtils.java: ## @@ -0,0 +1,44 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

[jira] [Updated] (KAFKA-14851) Move StreamResetterTest to tools

2023-07-21 Thread Federico Valeri (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14851?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Federico Valeri updated KAFKA-14851: Summary: Move StreamResetterTest to tools (was: Move StreamResetterTest to tools module)

[GitHub] [kafka] philipnee commented on a diff in pull request #13920: KAFKA-15106 fix AbstractStickyAssignor isBalanced predict

2023-07-21 Thread via GitHub
philipnee commented on code in PR #13920: URL: https://github.com/apache/kafka/pull/13920#discussion_r1270851855 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignorTest.java: ## @@ -724,6 +725,90 @@ public void

[GitHub] [kafka] ruslankrivoshein commented on a diff in pull request #13562: KAFKA-14581: Moving GetOffsetShell to tools

2023-07-21 Thread via GitHub
ruslankrivoshein commented on code in PR #13562: URL: https://github.com/apache/kafka/pull/13562#discussion_r1270873057 ## tools/src/main/java/org/apache/kafka/tools/ToolsUtils.java: ## @@ -0,0 +1,44 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more

[GitHub] [kafka] ruslankrivoshein commented on a diff in pull request #13562: KAFKA-14581: Moving GetOffsetShell to tools

2023-07-21 Thread via GitHub
ruslankrivoshein commented on code in PR #13562: URL: https://github.com/apache/kafka/pull/13562#discussion_r1270873057 ## tools/src/main/java/org/apache/kafka/tools/ToolsUtils.java: ## @@ -0,0 +1,44 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more

[jira] [Resolved] (KAFKA-13431) Sink Connectors: Support topic-mutating SMTs for async connectors (preCommit users)

2023-07-21 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13431?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Egerton resolved KAFKA-13431. --- Fix Version/s: 3.6.0 Resolution: Done > Sink Connectors: Support topic-mutating SMTs

[GitHub] [kafka] C0urante commented on a diff in pull request #14055: KAFKA-15031: Add plugin.discovery to Connect worker configuration (KIP-898)

2023-07-21 Thread via GitHub
C0urante commented on code in PR #14055: URL: https://github.com/apache/kafka/pull/14055#discussion_r1270745253 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerConfig.java: ## @@ -122,6 +124,18 @@ public class WorkerConfig extends AbstractConfig {

[GitHub] [kafka] mimaison merged pull request #13278: KAFKA-14591 DeleteRecordsCommand moved to tools

2023-07-21 Thread via GitHub
mimaison merged PR #13278: URL: https://github.com/apache/kafka/pull/13278 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Assigned] (KAFKA-15232) Move ToolsUtils to tools

2023-07-21 Thread Federico Valeri (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Federico Valeri reassigned KAFKA-15232: --- Assignee: Federico Valeri > Move ToolsUtils to tools > >

[jira] [Created] (KAFKA-15232) Move ToolsUtils to tools

2023-07-21 Thread Federico Valeri (Jira)
Federico Valeri created KAFKA-15232: --- Summary: Move ToolsUtils to tools Key: KAFKA-15232 URL: https://issues.apache.org/jira/browse/KAFKA-15232 Project: Kafka Issue Type: Sub-task

[GitHub] [kafka] Owen-CH-Leung commented on pull request #14057: KAFKA-15194-Prepend-Offset-as-Filename

2023-07-21 Thread via GitHub
Owen-CH-Leung commented on PR #14057: URL: https://github.com/apache/kafka/pull/14057#issuecomment-1645730474 I've already merged trunk and this time the `JDK 11 + Scala 2.13` failed: ``` 1: Task failed with an exception. --- * What went wrong: Execution failed

[jira] [Updated] (KAFKA-14583) Move ReplicaVerificationTool to tools

2023-07-21 Thread Federico Valeri (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14583?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Federico Valeri updated KAFKA-14583: Fix Version/s: 3.6.0 > Move ReplicaVerificationTool to tools >

[jira] [Comment Edited] (KAFKA-15217) Consider usage of Gradle toolchain to specify Java version

2023-07-21 Thread Said BOUDJELDA (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17745507#comment-17745507 ] Said BOUDJELDA edited comment on KAFKA-15217 at 7/21/23 2:28 PM: -

[GitHub] [kafka] fvaleri commented on a diff in pull request #13562: KAFKA-14581: Moving GetOffsetShell to tools

2023-07-21 Thread via GitHub
fvaleri commented on code in PR #13562: URL: https://github.com/apache/kafka/pull/13562#discussion_r1270733830 ## tools/src/main/java/org/apache/kafka/tools/ToolsUtils.java: ## @@ -0,0 +1,44 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

[jira] [Commented] (KAFKA-15231) Add ability to pause/resume Remote Log Manager tasks

2023-07-21 Thread Jorge Esteban Quilcate Otoya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17745620#comment-17745620 ] Jorge Esteban Quilcate Otoya commented on KAFKA-15231: -- Thanks [~divijvaidya]. Of

[GitHub] [kafka] songnon commented on pull request #13451: KAFKA-14808: fix leaderless partition issue when controller removes u…

2023-07-21 Thread via GitHub
songnon commented on PR #13451: URL: https://github.com/apache/kafka/pull/13451#issuecomment-1645629406 @junrao I have updated the code. Would you like to have a look? Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[jira] [Commented] (KAFKA-15231) Add ability to pause/resume Remote Log Manager tasks

2023-07-21 Thread Divij Vaidya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17745602#comment-17745602 ] Divij Vaidya commented on KAFKA-15231: -- Hey [~jeqo]  If the RSM is unavailable (for maintenance as

[jira] [Commented] (KAFKA-15231) Add ability to pause/resume Remote Log Manager tasks

2023-07-21 Thread Jorge Esteban Quilcate Otoya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17745600#comment-17745600 ] Jorge Esteban Quilcate Otoya commented on KAFKA-15231: -- cc [~satishd] [~showuon]

[jira] [Created] (KAFKA-15231) Add ability to pause/resume Remote Log Manager tasks

2023-07-21 Thread Jorge Esteban Quilcate Otoya (Jira)
Jorge Esteban Quilcate Otoya created KAFKA-15231: Summary: Add ability to pause/resume Remote Log Manager tasks Key: KAFKA-15231 URL: https://issues.apache.org/jira/browse/KAFKA-15231

[GitHub] [kafka] ruslankrivoshein commented on pull request #13562: KAFKA-14581: Moving GetOffsetShell to tools

2023-07-21 Thread via GitHub
ruslankrivoshein commented on PR #13562: URL: https://github.com/apache/kafka/pull/13562#issuecomment-1645561485 ``` $ ./gradlew :tools:checkstyleMain ... omitted husk BUILD SUCCESSFUL $ ./gradlew clean systemTestLibs ... omitted husk BUILD SUCCESSFUL tests run:

[GitHub] [kafka] fvaleri commented on a diff in pull request #14059: KAFKA-14583: Move ReplicaVerificationTool to tools

2023-07-21 Thread via GitHub
fvaleri commented on code in PR #14059: URL: https://github.com/apache/kafka/pull/14059#discussion_r1270643655 ## tools/src/main/java/org/apache/kafka/tools/ReplicaVerificationTool.java: ## @@ -0,0 +1,740 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [kafka] fvaleri commented on pull request #14059: KAFKA-14583: Move ReplicaVerificationTool to tools

2023-07-21 Thread via GitHub
fvaleri commented on PR #14059: URL: https://github.com/apache/kafka/pull/14059#issuecomment-1645541067 @mimaison removed all extra changes. ```sh SESSION REPORT (ALL TESTS) ducktape version: 0.11.3 session_id: 2023-07-21--001 run time: 42.089 seconds

[GitHub] [kafka] fvaleri commented on a diff in pull request #14059: KAFKA-14583: Move ReplicaVerificationTool to tools

2023-07-21 Thread via GitHub
fvaleri commented on code in PR #14059: URL: https://github.com/apache/kafka/pull/14059#discussion_r1270643655 ## tools/src/main/java/org/apache/kafka/tools/ReplicaVerificationTool.java: ## @@ -0,0 +1,740 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [kafka] fvaleri commented on pull request #13562: KAFKA-14581: Moving GetOffsetShell to tools

2023-07-21 Thread via GitHub
fvaleri commented on PR #13562: URL: https://github.com/apache/kafka/pull/13562#issuecomment-1645507764 Hey @ruslankrivoshein, about the deprecation warning message, it looks like it is considered a public interface change, so a committer may ask to remove it or create a KIP, so please

[jira] [Created] (KAFKA-15230) ApiVersions data between controllers is not reliable

2023-07-21 Thread David Arthur (Jira)
David Arthur created KAFKA-15230: Summary: ApiVersions data between controllers is not reliable Key: KAFKA-15230 URL: https://issues.apache.org/jira/browse/KAFKA-15230 Project: Kafka Issue

[GitHub] [kafka] mimaison commented on a diff in pull request #14059: KAFKA-14583: Move ReplicaVerificationTool to tools

2023-07-21 Thread via GitHub
mimaison commented on code in PR #14059: URL: https://github.com/apache/kafka/pull/14059#discussion_r1270606054 ## tools/src/main/java/org/apache/kafka/tools/ReplicaVerificationTool.java: ## @@ -0,0 +1,740 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [kafka] fvaleri commented on a diff in pull request #14059: KAFKA-14583: Move ReplicaVerificationTool to tools

2023-07-21 Thread via GitHub
fvaleri commented on code in PR #14059: URL: https://github.com/apache/kafka/pull/14059#discussion_r1270544624 ## tools/src/main/java/org/apache/kafka/tools/ReplicaVerificationTool.java: ## @@ -0,0 +1,740 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [kafka] divijvaidya commented on pull request #14057: KAFKA-15194-Prepend-Offset-as-Filename

2023-07-21 Thread via GitHub
divijvaidya commented on PR #14057: URL: https://github.com/apache/kafka/pull/14057#issuecomment-1645447012 Actually, you need to rebase with trunk. https://github.com/apache/kafka/commit/4ea9394e7ebf71e2dcf96e9b96191dac253f4930 is the commit that fixes the build. -- This is an

[GitHub] [kafka] Owen-CH-Leung commented on pull request #14057: KAFKA-15194-Prepend-Offset-as-Filename

2023-07-21 Thread via GitHub
Owen-CH-Leung commented on PR #14057: URL: https://github.com/apache/kafka/pull/14057#issuecomment-1645437694 Seems like the error from the CI job is not related to what I have changed. Here are the 3 errors that are reported from the failing CI job: ``` [Error]

[GitHub] [kafka] fvaleri commented on a diff in pull request #14059: KAFKA-14583: Move ReplicaVerificationTool to tools

2023-07-21 Thread via GitHub
fvaleri commented on code in PR #14059: URL: https://github.com/apache/kafka/pull/14059#discussion_r1270547364 ## tools/src/main/java/org/apache/kafka/tools/ReplicaVerificationTool.java: ## @@ -0,0 +1,740 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

  1   2   >