[jira] [Created] (KAFKA-15245) Improve Tiered Storage Metrics

2023-07-24 Thread Abhijeet Kumar (Jira)
Abhijeet Kumar created KAFKA-15245: -- Summary: Improve Tiered Storage Metrics Key: KAFKA-15245 URL: https://issues.apache.org/jira/browse/KAFKA-15245 Project: Kafka Issue Type: Sub-task

[GitHub] [kafka] vamossagar12 commented on pull request #14051: KAFKA-15218: Avoid NPE thrown while deleting topic and fetch from follower concurrently

2023-07-24 Thread via GitHub
vamossagar12 commented on PR #14051: URL: https://github.com/apache/kafka/pull/14051#issuecomment-1649138031 hmm I still see 93 test failures out of which 90 are from JDK 11 build. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #13998: KAFKA-14702: Extend server side assignor to support rack aware replica placement

2023-07-24 Thread via GitHub
rreddy-22 commented on code in PR #13998: URL: https://github.com/apache/kafka/pull/13998#discussion_r1273004953 ## group-coordinator/src/main/resources/common/message/ConsumerGroupPartitionMetadataValue.json: ## @@ -29,7 +29,20 @@ { "name": "TopicName", "versions":

[jira] [Commented] (KAFKA-15005) Status of KafkaConnect task not correct

2023-07-24 Thread Sagar Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17746774#comment-17746774 ] Sagar Rao commented on KAFKA-15005: --- [~LucentWong], the PR for

[jira] [Resolved] (KAFKA-15005) Status of KafkaConnect task not correct

2023-07-24 Thread Sagar Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15005?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sagar Rao resolved KAFKA-15005. --- Resolution: Duplicate > Status of KafkaConnect task not correct >

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #13998: KAFKA-14702: Extend server side assignor to support rack aware replica placement

2023-07-24 Thread via GitHub
rreddy-22 commented on code in PR #13998: URL: https://github.com/apache/kafka/pull/13998#discussion_r1273003055 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/SubscribedTopicDescriber.java: ## @@ -0,0 +1,59 @@ +/* + * Licensed to the Apache

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #13998: KAFKA-14702: Extend server side assignor to support rack aware replica placement

2023-07-24 Thread via GitHub
rreddy-22 commented on code in PR #13998: URL: https://github.com/apache/kafka/pull/13998#discussion_r1272999133 ## checkstyle/suppressions.xml: ## @@ -321,6 +321,8 @@ +

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #13998: KAFKA-14702: Extend server side assignor to support rack aware replica placement

2023-07-24 Thread via GitHub
rreddy-22 commented on code in PR #13998: URL: https://github.com/apache/kafka/pull/13998#discussion_r1272998731 ## checkstyle/import-control.xml: ## @@ -48,6 +48,7 @@ + Review Comment: yep correct we don't need it now that we don't have any classes in it

[GitHub] [kafka] cmccabe closed pull request #14087: Kafka 15183 ii

2023-07-24 Thread via GitHub
cmccabe closed pull request #14087: Kafka 15183 ii URL: https://github.com/apache/kafka/pull/14087 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] cmccabe merged pull request #14010: KAFKA-15183: Add more controller, loader, snapshot emitter metrics

2023-07-24 Thread via GitHub
cmccabe merged PR #14010: URL: https://github.com/apache/kafka/pull/14010 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] github-actions[bot] commented on pull request #12787: [WIP][KAFKA-14326] StreamsRestter trim excess white space surrounding topic input

2023-07-24 Thread via GitHub
github-actions[bot] commented on PR #12787: URL: https://github.com/apache/kafka/pull/12787#issuecomment-1649012604 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has

[GitHub] [kafka] mumrah commented on a diff in pull request #14028: KAFKA-15196 Additional ZK migration metrics

2023-07-24 Thread via GitHub
mumrah commented on code in PR #14028: URL: https://github.com/apache/kafka/pull/14028#discussion_r1272796566 ## server-common/src/main/java/org/apache/kafka/server/metrics/MetadataTypeMetric.java: ## @@ -0,0 +1,26 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[jira] [Commented] (KAFKA-15240) BrokerToControllerChannelManager cache activeController error cause DefaultAlterPartitionManager send AlterPartition request failed

2023-07-24 Thread shilin Lu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17746733#comment-17746733 ] shilin Lu commented on KAFKA-15240: --- [~ijuma] [~junrao] please watch this issue,thank you! >

[GitHub] [kafka] vamossagar12 commented on pull request #14051: KAFKA-15218: Avoid NPE thrown while deleting topic and fetch from follower concurrently

2023-07-24 Thread via GitHub
vamossagar12 commented on PR #14051: URL: https://github.com/apache/kafka/pull/14051#issuecomment-1648892717 I see 92 tests failed this time. I think I also have access to re-trigger builds but have never been able to login to Jenkins. -- This is an automated message from the Apache Git

[GitHub] [kafka] gharris1727 commented on pull request #14064: KAFKA-15030: Add connect-plugin-path command-line tool.

2023-07-24 Thread via GitHub
gharris1727 commented on PR #14064: URL: https://github.com/apache/kafka/pull/14064#issuecomment-1648823990 #14089 contains the fix for the PluginType inference which this change requires. -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] gharris1727 opened a new pull request, #14089: KAFKA-15244: Remove PluginType.from(Class)

2023-07-24 Thread via GitHub
gharris1727 opened a new pull request, #14089: URL: https://github.com/apache/kafka/pull/14089 This method is misleading, as it makes the caller assume that a given plugin class has only one supertype, when it may actually have multiple. Rather than documenting this limitation, or having

[jira] [Created] (KAFKA-15244) Connect PluginType.from(Class) result is incorrect when subclassing multiple plugin interfaces

2023-07-24 Thread Greg Harris (Jira)
Greg Harris created KAFKA-15244: --- Summary: Connect PluginType.from(Class) result is incorrect when subclassing multiple plugin interfaces Key: KAFKA-15244 URL: https://issues.apache.org/jira/browse/KAFKA-15244

[jira] [Commented] (KAFKA-14969) Upgrade Mockito to 4.11.0

2023-07-24 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17746711#comment-17746711 ] Ismael Juma commented on KAFKA-14969: - This is sort of done already:

[GitHub] [kafka] jolshan commented on a diff in pull request #14088: MINOR: Adjust Invalid Record Exception for Invalid Txn State as mentioned in KIP-890

2023-07-24 Thread via GitHub
jolshan commented on code in PR #14088: URL: https://github.com/apache/kafka/pull/14088#discussion_r1272869719 ## core/src/test/scala/unit/kafka/server/AddPartitionsToTxnManagerTest.scala: ## @@ -201,7 +201,7 @@ class AddPartitionsToTxnManagerTest {

[GitHub] [kafka] hachikuji commented on a diff in pull request #14088: MINOR: Adjust Invalid Record Exception for Invalid Txn State as mentioned in KIP-890

2023-07-24 Thread via GitHub
hachikuji commented on code in PR #14088: URL: https://github.com/apache/kafka/pull/14088#discussion_r1272868243 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -732,8 +732,7 @@ class ReplicaManager(val config: KafkaConfig, debug("Produce to local log

[GitHub] [kafka] CalvinConfluent commented on a diff in pull request #14053: KAFKA-15221; Fix the race between fetch requests from a rebooted follower.

2023-07-24 Thread via GitHub
CalvinConfluent commented on code in PR #14053: URL: https://github.com/apache/kafka/pull/14053#discussion_r1272855952 ## core/src/main/scala/kafka/cluster/Replica.scala: ## @@ -98,31 +101,39 @@ class Replica(val brokerId: Int, val topicPartition: TopicPartition) extends Log

[GitHub] [kafka] jeffkbkim commented on a diff in pull request #14017: KAFKA-14500; [6/6] Implement SyncGroup protocol in new GroupCoordinator

2023-07-24 Thread via GitHub
jeffkbkim commented on code in PR #14017: URL: https://github.com/apache/kafka/pull/14017#discussion_r1272854832 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java: ## @@ -5205,11 +5245,102 @@ public void

[GitHub] [kafka] CalvinConfluent commented on a diff in pull request #14053: KAFKA-15221; Fix the race between fetch requests from a rebooted follower.

2023-07-24 Thread via GitHub
CalvinConfluent commented on code in PR #14053: URL: https://github.com/apache/kafka/pull/14053#discussion_r1272852459 ## core/src/main/scala/kafka/cluster/Replica.scala: ## @@ -98,31 +101,39 @@ class Replica(val brokerId: Int, val topicPartition: TopicPartition) extends Log

[GitHub] [kafka] CalvinConfluent commented on a diff in pull request #14053: KAFKA-15221; Fix the race between fetch requests from a rebooted follower.

2023-07-24 Thread via GitHub
CalvinConfluent commented on code in PR #14053: URL: https://github.com/apache/kafka/pull/14053#discussion_r1272852459 ## core/src/main/scala/kafka/cluster/Replica.scala: ## @@ -98,31 +101,39 @@ class Replica(val brokerId: Int, val topicPartition: TopicPartition) extends Log

[GitHub] [kafka] jeffkbkim commented on a diff in pull request #14017: KAFKA-14500; [6/6] Implement SyncGroup protocol in new GroupCoordinator

2023-07-24 Thread via GitHub
jeffkbkim commented on code in PR #14017: URL: https://github.com/apache/kafka/pull/14017#discussion_r1272852347 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java: ## @@ -5524,5 +5670,2897 @@ private static Record

[GitHub] [kafka] jeffkbkim commented on a diff in pull request #14017: KAFKA-14500; [6/6] Implement SyncGroup protocol in new GroupCoordinator

2023-07-24 Thread via GitHub
jeffkbkim commented on code in PR #14017: URL: https://github.com/apache/kafka/pull/14017#discussion_r1272851939 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java: ## @@ -5524,5 +5670,2897 @@ private static Record

[GitHub] [kafka] jolshan opened a new pull request, #14088: MINOR: Adjust Invalid Record Exception for Invalid Txn State as mentioned in KIP-890

2023-07-24 Thread via GitHub
jolshan opened a new pull request, #14088: URL: https://github.com/apache/kafka/pull/14088 Invalid record is a newer error. Invalid_Txn_State has been around as long as transactions and is not retriable. This is the desired behavior. ### Committer Checklist (excluded from commit

[GitHub] [kafka] cmccabe opened a new pull request, #14087: Kafka 15183 ii

2023-07-24 Thread via GitHub
cmccabe opened a new pull request, #14087: URL: https://github.com/apache/kafka/pull/14087 get test run for https://github.com/apache/kafka/pull/14010 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Resolved] (KAFKA-14920) Address timeouts and out of order sequences

2023-07-24 Thread Justine Olshan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justine Olshan resolved KAFKA-14920. Resolution: Fixed > Address timeouts and out of order sequences >

[jira] [Commented] (KAFKA-14969) Upgrade Mockito to 4.11.0

2023-07-24 Thread Said BOUDJELDA (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17746667#comment-17746667 ] Said BOUDJELDA commented on KAFKA-14969: Can I take this ticket, and prepare even the most

[jira] [Updated] (KAFKA-14969) Upgrade Mockito to 4.11.0

2023-07-24 Thread Said BOUDJELDA (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14969?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Said BOUDJELDA updated KAFKA-14969: --- Labels: dependencies (was: ) > Upgrade Mockito to 4.11.0 > - > >

[GitHub] [kafka] cmccabe commented on pull request #13643: KAFKA-15213: provide the exact offset to QuorumController.replay

2023-07-24 Thread via GitHub
cmccabe commented on PR #13643: URL: https://github.com/apache/kafka/pull/13643#issuecomment-1648709714 Thanks, @jsancio . I updated the PR with the results of our discussion. One small change I made is that I think `RaftClient#logEndOffset` can just unconditionally return the log end

[jira] [Commented] (KAFKA-15235) No test coverage reports for Java due to settings for Jacoco being incompatible with Gradle 8.x

2023-07-24 Thread Eike Thaden (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17746659#comment-17746659 ] Eike Thaden commented on KAFKA-15235: - @Said: Thank you for the additional explanation.

[jira] [Commented] (KAFKA-15214) Add metrics for OffsetOutOfRangeException when tiered storage is enabled

2023-07-24 Thread Lixin Yao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17746655#comment-17746655 ] Lixin Yao commented on KAFKA-15214: --- Hi [~divijvaidya] , any further suggestion? Is that ok if I

[GitHub] [kafka] philipnee opened a new pull request, #14086: MINOR: Test assign() and assignment() in the integration test

2023-07-24 Thread via GitHub
philipnee opened a new pull request, #14086: URL: https://github.com/apache/kafka/pull/14086 *A missing piece from [KAFKA-14950](https://issues.apache.org/jira/browse/KAFKA-14950). This is to test assign() and assignment() in the integration test. ### Committer Checklist (excluded

[GitHub] [kafka] lihaosky commented on a diff in pull request #14030: KAFKA-15022: [3/N] use graph to compute rack aware assignment for active stateful tasks

2023-07-24 Thread via GitHub
lihaosky commented on code in PR #14030: URL: https://github.com/apache/kafka/pull/14030#discussion_r1272791951 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/assignment/RackAwareTaskAssignorTest.java: ## @@ -145,147 +188,517 @@ public void

[GitHub] [kafka] cmccabe commented on a diff in pull request #14028: KAFKA-15196 Additional ZK migration metrics

2023-07-24 Thread via GitHub
cmccabe commented on code in PR #14028: URL: https://github.com/apache/kafka/pull/14028#discussion_r1272782778 ## metadata/src/main/java/org/apache/kafka/controller/metrics/ControllerMetadataMetrics.java: ## @@ -117,6 +120,15 @@ public Integer value() { return

[GitHub] [kafka] cmccabe commented on a diff in pull request #14028: KAFKA-15196 Additional ZK migration metrics

2023-07-24 Thread via GitHub
cmccabe commented on code in PR #14028: URL: https://github.com/apache/kafka/pull/14028#discussion_r1272782778 ## metadata/src/main/java/org/apache/kafka/controller/metrics/ControllerMetadataMetrics.java: ## @@ -117,6 +120,15 @@ public Integer value() { return

[GitHub] [kafka] cmccabe commented on a diff in pull request #14028: KAFKA-15196 Additional ZK migration metrics

2023-07-24 Thread via GitHub
cmccabe commented on code in PR #14028: URL: https://github.com/apache/kafka/pull/14028#discussion_r1272784428 ## server-common/src/main/java/org/apache/kafka/server/metrics/MetadataTypeMetric.java: ## @@ -0,0 +1,26 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] cmccabe commented on a diff in pull request #14028: KAFKA-15196 Additional ZK migration metrics

2023-07-24 Thread via GitHub
cmccabe commented on code in PR #14028: URL: https://github.com/apache/kafka/pull/14028#discussion_r1272782778 ## metadata/src/main/java/org/apache/kafka/controller/metrics/ControllerMetadataMetrics.java: ## @@ -117,6 +120,15 @@ public Integer value() { return

[GitHub] [kafka] mjsax opened a new pull request, #14085: MINOR: fix docs markup

2023-07-24 Thread via GitHub
mjsax opened a new pull request, #14085: URL: https://github.com/apache/kafka/pull/14085 Porting fixes from https://github.com/apache/kafka-site/pull/528 back. This should also be cherry-picked to `3.5` branch. -- This is an automated message from the Apache Git Service. To respond

[GitHub] [kafka] bmscomp commented on pull request #13662: KAFKA-15208: Upgrade Jackson dependencies to version 2.15.2

2023-07-24 Thread via GitHub
bmscomp commented on PR #13662: URL: https://github.com/apache/kafka/pull/13662#issuecomment-1648586221 @divijvaidya after analysing the regression regarding Kafka code base, it seems that the regression is related to records, and in the current version of Kafka records are not introduced

[GitHub] [kafka] ahuang98 opened a new pull request, #14084: [MINOR] Add latest versions to kraft upgrade kafkatest

2023-07-24 Thread via GitHub
ahuang98 opened a new pull request, #14084: URL: https://github.com/apache/kafka/pull/14084 Adding latest versions to kafka_upgrade_test.py. Confirmed test passes on the latest versions. Nit: also added back `LATEST_3_6` definition which was removed in

[GitHub] [kafka] lihaosky commented on a diff in pull request #14030: KAFKA-15022: [3/N] use graph to compute rack aware assignment for active stateful tasks

2023-07-24 Thread via GitHub
lihaosky commented on code in PR #14030: URL: https://github.com/apache/kafka/pull/14030#discussion_r1272724945 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/RackAwareTaskAssignor.java: ## @@ -185,4 +193,212 @@ public boolean

[GitHub] [kafka] lihaosky commented on a diff in pull request #14030: KAFKA-15022: [3/N] use graph to compute rack aware assignment for active stateful tasks

2023-07-24 Thread via GitHub
lihaosky commented on code in PR #14030: URL: https://github.com/apache/kafka/pull/14030#discussion_r1272693494 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/RackAwareTaskAssignor.java: ## @@ -185,4 +191,224 @@ public boolean

[GitHub] [kafka] splett2 closed pull request #13501: MINOR: Use `exists` instead of return in DelayedFetch

2023-07-24 Thread via GitHub
splett2 closed pull request #13501: MINOR: Use `exists` instead of return in DelayedFetch URL: https://github.com/apache/kafka/pull/13501 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] jolshan merged pull request #13707: KAFKA-14990: Dynamic producer ID expiration should be applied on a broker restart

2023-07-24 Thread via GitHub
jolshan merged PR #13707: URL: https://github.com/apache/kafka/pull/13707 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] lihaosky commented on a diff in pull request #14030: KAFKA-15022: [3/N] use graph to compute rack aware assignment for active stateful tasks

2023-07-24 Thread via GitHub
lihaosky commented on code in PR #14030: URL: https://github.com/apache/kafka/pull/14030#discussion_r1272692608 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/AssignorConfiguration.java: ## @@ -268,24 +268,44 @@ public static class

[GitHub] [kafka] gharris1727 commented on pull request #14064: KAFKA-15030: Add connect-plugin-path command-line tool.

2023-07-24 Thread via GitHub
gharris1727 commented on PR #14064: URL: https://github.com/apache/kafka/pull/14064#issuecomment-1648540605 > I think TSV is fine for the output format. It'd definitely help if we added headers.  > I also found it a bit difficult to parse with the plugin location being

[GitHub] [kafka] jolshan merged pull request #14033: KAFKA-14920: Address timeouts and out of order sequences

2023-07-24 Thread via GitHub
jolshan merged PR #14033: URL: https://github.com/apache/kafka/pull/14033 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] jolshan commented on pull request #14033: KAFKA-14920: Address timeouts and out of order sequences

2023-07-24 Thread via GitHub
jolshan commented on PR #14033: URL: https://github.com/apache/kafka/pull/14033#issuecomment-1648533713 Test failures look unrelated.  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] mumrah commented on a diff in pull request #14062: MINOR: Add a Builder for KRaftMigrationDriver

2023-07-24 Thread via GitHub
mumrah commented on code in PR #14062: URL: https://github.com/apache/kafka/pull/14062#discussion_r1272701730 ## metadata/src/main/java/org/apache/kafka/metadata/migration/KRaftMigrationDriver.java: ## @@ -756,4 +745,109 @@ static KRaftMigrationOperationConsumer

[jira] [Commented] (KAFKA-15243) User creation mismatch

2023-07-24 Thread Proven Provenzano (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17746624#comment-17746624 ] Proven Provenzano commented on KAFKA-15243: --- I just want to make sure that it works the same

[jira] [Commented] (KAFKA-15239) producerPerformance system test for old client failed after v3.5.0

2023-07-24 Thread Federico Valeri (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17746622#comment-17746622 ] Federico Valeri commented on KAFKA-15239: - Hi [~showuon], thanks for raising this. QuotaTest

[jira] [Updated] (KAFKA-15242) FixedKeyProcessor testing is unusable

2023-07-24 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15242?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-15242: Component/s: streams > FixedKeyProcessor testing is unusable >

[GitHub] [kafka] C0urante commented on a diff in pull request #14079: KAFKA-15238: Move DLQ reporter setup from the DistributedHerder's tick thread to the sink task thread

2023-07-24 Thread via GitHub
C0urante commented on code in PR #14079: URL: https://github.com/apache/kafka/pull/14079#discussion_r1272633816 ## connect/runtime/src/test/java/org/apache/kafka/connect/integration/SinkConnectorsIntegrationTest.java: ## @@ -309,6 +319,48 @@ public void

[GitHub] [kafka] mjsax commented on a diff in pull request #14030: KAFKA-15022: [3/N] use graph to compute rack aware assignment for active stateful tasks

2023-07-24 Thread via GitHub
mjsax commented on code in PR #14030: URL: https://github.com/apache/kafka/pull/14030#discussion_r1272606193 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/RackAwareTaskAssignor.java: ## @@ -185,4 +193,212 @@ public boolean validateClientRack()

[GitHub] [kafka] gharris1727 commented on a diff in pull request #14064: KAFKA-15030: Add connect-plugin-path command-line tool.

2023-07-24 Thread via GitHub
gharris1727 commented on code in PR #14064: URL: https://github.com/apache/kafka/pull/14064#discussion_r1272626540 ## tools/src/main/java/org/apache/kafka/tools/ConnectPluginPath.java: ## @@ -0,0 +1,399 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [kafka] gharris1727 commented on a diff in pull request #14064: KAFKA-15030: Add connect-plugin-path command-line tool.

2023-07-24 Thread via GitHub
gharris1727 commented on code in PR #14064: URL: https://github.com/apache/kafka/pull/14064#discussion_r1272620934 ## tools/src/main/java/org/apache/kafka/tools/ConnectPluginPath.java: ## @@ -0,0 +1,399 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [kafka] jolshan commented on a diff in pull request #14067: KAFKA-14499: [3/N] Implement OffsetCommit API

2023-07-24 Thread via GitHub
jolshan commented on code in PR #14067: URL: https://github.com/apache/kafka/pull/14067#discussion_r1272624245 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetMetadataManager.java: ## @@ -0,0 +1,454 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] jolshan commented on a diff in pull request #14067: KAFKA-14499: [3/N] Implement OffsetCommit API

2023-07-24 Thread via GitHub
jolshan commented on code in PR #14067: URL: https://github.com/apache/kafka/pull/14067#discussion_r1272624245 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetMetadataManager.java: ## @@ -0,0 +1,454 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] jolshan commented on a diff in pull request #14067: KAFKA-14499: [3/N] Implement OffsetCommit API

2023-07-24 Thread via GitHub
jolshan commented on code in PR #14067: URL: https://github.com/apache/kafka/pull/14067#discussion_r1272621431 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetMetadataManager.java: ## @@ -0,0 +1,448 @@ +/* + * Licensed to the Apache Software

[jira] [Updated] (KAFKA-15168) Handle overlapping remote log segments in RemoteLogMetadata cache

2023-07-24 Thread Kamal Chandraprakash (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15168?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kamal Chandraprakash updated KAFKA-15168: - Fix Version/s: 3.6.0 > Handle overlapping remote log segments in

[GitHub] [kafka] cmccabe commented on a diff in pull request #13947: KAFKA-15130: Delete remote segments when delete a topic

2023-07-24 Thread via GitHub
cmccabe commented on code in PR #13947: URL: https://github.com/apache/kafka/pull/13947#discussion_r1272579577 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -526,14 +532,17 @@ class ReplicaManager(val config: KafkaConfig, /** * Stop the given

[GitHub] [kafka] cmccabe commented on pull request #13947: KAFKA-15130: Delete remote segments when delete a topic

2023-07-24 Thread via GitHub
cmccabe commented on PR #13947: URL: https://github.com/apache/kafka/pull/13947#issuecomment-1648357381 We can't commit this without KRaft support. ZK mode is deprecated and we cannot add new features there that don't exist in KRaft. Leaving a -1 until this is addressed. -- This

[GitHub] [kafka] kamalcph commented on a diff in pull request #14049: KAFKA-14038: Optimise calculation of size for log in remote tier

2023-07-24 Thread via GitHub
kamalcph commented on code in PR #14049: URL: https://github.com/apache/kafka/pull/14049#discussion_r1272573307 ## storage/api/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteLogMetadataManager.java: ## @@ -201,4 +201,13 @@ void onPartitionLeadershipChanges(Set

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #13998: KAFKA-14702: Extend server side assignor to support rack aware replica placement

2023-07-24 Thread via GitHub
rreddy-22 commented on code in PR #13998: URL: https://github.com/apache/kafka/pull/13998#discussion_r1272573195 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java: ## @@ -5402,6 +5412,14 @@ private Map> fromTopicPartitions(

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #13998: KAFKA-14702: Extend server side assignor to support rack aware replica placement

2023-07-24 Thread via GitHub
rreddy-22 commented on code in PR #13998: URL: https://github.com/apache/kafka/pull/13998#discussion_r1272561659 ## group-coordinator/src/main/resources/common/message/ConsumerGroupPartitionMetadataValue.json: ## @@ -29,7 +29,20 @@ { "name": "TopicName", "versions":

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #13998: KAFKA-14702: Extend server side assignor to support rack aware replica placement

2023-07-24 Thread via GitHub
rreddy-22 commented on code in PR #13998: URL: https://github.com/apache/kafka/pull/13998#discussion_r1272561274 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/TopicMetadata.java: ## @@ -40,23 +45,31 @@ public class TopicMetadata { */

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #13998: KAFKA-14702: Extend server side assignor to support rack aware replica placement

2023-07-24 Thread via GitHub
rreddy-22 commented on code in PR #13998: URL: https://github.com/apache/kafka/pull/13998#discussion_r1272558721 ## group-coordinator/src/main/resources/common/message/ConsumerGroupPartitionMetadataValue.json: ## @@ -29,7 +29,20 @@ { "name": "TopicName", "versions":

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #13998: KAFKA-14702: Extend server side assignor to support rack aware replica placement

2023-07-24 Thread via GitHub
rreddy-22 commented on code in PR #13998: URL: https://github.com/apache/kafka/pull/13998#discussion_r1272557652 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/TargetAssignmentBuilder.java: ## @@ -244,16 +244,21 @@ public TargetAssignmentResult

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #13998: KAFKA-14702: Extend server side assignor to support rack aware replica placement

2023-07-24 Thread via GitHub
rreddy-22 commented on code in PR #13998: URL: https://github.com/apache/kafka/pull/13998#discussion_r1272551436 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/PartitionMetadata.java: ## @@ -0,0 +1,85 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #13998: KAFKA-14702: Extend server side assignor to support rack aware replica placement

2023-07-24 Thread via GitHub
rreddy-22 commented on code in PR #13998: URL: https://github.com/apache/kafka/pull/13998#discussion_r1272550567 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/PartitionMetadata.java: ## @@ -0,0 +1,85 @@ +/* + * Licensed to the Apache Software

[jira] [Commented] (KAFKA-15243) User creation mismatch

2023-07-24 Thread Sergio Troiano (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17746546#comment-17746546 ] Sergio Troiano commented on KAFKA-15243: [~pprovenzano] we don't use KRaft yet, so this is

[jira] [Commented] (KAFKA-15243) User creation mismatch

2023-07-24 Thread Proven Provenzano (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17746544#comment-17746544 ] Proven Provenzano commented on KAFKA-15243: --- Does this happen with KRaft? > User creation

[GitHub] [kafka] pprovenzano opened a new pull request, #14083: KAFKA-15219: KRaft support for DelegationTokens [WIP]

2023-07-24 Thread via GitHub
pprovenzano opened a new pull request, #14083: URL: https://github.com/apache/kafka/pull/14083 This PR includes KRaft Metadata support for DelelegationTokens, updated tests for DelegationTokens to run in Zk and KRaft mode, and a bump of the metadata version specifically for

[GitHub] [kafka] pprovenzano closed pull request #13916: WIP DelegationToken Support for KRaft

2023-07-24 Thread via GitHub
pprovenzano closed pull request #13916: WIP DelegationToken Support for KRaft URL: https://github.com/apache/kafka/pull/13916 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [kafka] dajac commented on a diff in pull request #14033: KAFKA-14920: Address timeouts and out of order sequences

2023-07-24 Thread via GitHub
dajac commented on code in PR #14033: URL: https://github.com/apache/kafka/pull/14033#discussion_r127255 ## storage/src/main/java/org/apache/kafka/storage/internals/log/VerificationStateEntry.java: ## @@ -58,14 +58,16 @@ public short epoch() { } /** - * We

[GitHub] [kafka] dajac commented on a diff in pull request #13998: KAFKA-14702: Extend server side assignor to support rack aware replica placement

2023-07-24 Thread via GitHub
dajac commented on code in PR #13998: URL: https://github.com/apache/kafka/pull/13998#discussion_r1272465513 ## checkstyle/import-control.xml: ## @@ -48,6 +48,7 @@ + Review Comment: I suppose that we can remove this, isn't it? ##

[jira] [Updated] (KAFKA-15243) User creation mismatch

2023-07-24 Thread Sergio Troiano (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15243?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergio Troiano updated KAFKA-15243: --- Component/s: core > User creation mismatch > -- > >

[jira] [Created] (KAFKA-15243) User creation mismatch

2023-07-24 Thread Sergio Troiano (Jira)
Sergio Troiano created KAFKA-15243: -- Summary: User creation mismatch Key: KAFKA-15243 URL: https://issues.apache.org/jira/browse/KAFKA-15243 Project: Kafka Issue Type: Bug Affects

[GitHub] [kafka] pgjbz closed pull request #13928: KAFKA-15097: prevent server shutdown when source file not exists

2023-07-24 Thread via GitHub
pgjbz closed pull request #13928: KAFKA-15097: prevent server shutdown when source file not exists URL: https://github.com/apache/kafka/pull/13928 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] mehbey closed pull request #13709: KAFKA-14991:Added a validation to check if the record timestamp is in the future compared to the broker's timestamp

2023-07-24 Thread via GitHub
mehbey closed pull request #13709: KAFKA-14991:Added a validation to check if the record timestamp is in the future compared to the broker's timestamp URL: https://github.com/apache/kafka/pull/13709 -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [kafka] mehbey commented on pull request #13709: KAFKA-14991:Added a validation to check if the record timestamp is in the future compared to the broker's timestamp

2023-07-24 Thread via GitHub
mehbey commented on PR #13709: URL: https://github.com/apache/kafka/pull/13709#issuecomment-1648169813 Based on the the proposed implementation in the[ KIP](https://cwiki.apache.org/confluence/display/KAFKA/KIP-937%3A+Improve+Message+Timestamp+Validation) closing this pull requests as we

[GitHub] [kafka] OmniaGM opened a new pull request, #14082: KAFKA-15102: Mirror Maker 2 - KIP690 backward compatibility

2023-07-24 Thread via GitHub
OmniaGM opened a new pull request, #14082: URL: https://github.com/apache/kafka/pull/14082 Waiting for a vote on KIP-949 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify

[jira] [Updated] (KAFKA-15237) Implement write operation timeout

2023-07-24 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15237?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot updated KAFKA-15237: Description: In the scala code, we rely on `offsets.commit.timeout.ms` to bound all the writes.

[jira] [Updated] (KAFKA-15237) Implement write operation timeout

2023-07-24 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15237?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot updated KAFKA-15237: Description: In the scala code, we rely on `offsets.commit.timeout.ms` to bound all the writes.

[jira] [Assigned] (KAFKA-15237) Implement write operation timeout

2023-07-24 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15237?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot reassigned KAFKA-15237: --- Assignee: David Jacot > Implement write operation timeout >

[jira] [Updated] (KAFKA-15237) Implement write operation timeout

2023-07-24 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15237?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot updated KAFKA-15237: Summary: Implement write operation timeout (was: Implement `offsets.commit.timeout.ms` setting)

[GitHub] [kafka] satishd merged pull request #14004: KAFKA-15168: Handle overlapping remote log segments in RemoteLogMetadata cache

2023-07-24 Thread via GitHub
satishd merged PR #14004: URL: https://github.com/apache/kafka/pull/14004 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] C0urante opened a new pull request, #14081: MINOR: Downgrade log level for conflicting Connect plugin aliases

2023-07-24 Thread via GitHub
C0urante opened a new pull request, #14081: URL: https://github.com/apache/kafka/pull/14081 We've started to see messages like this on startup: > [2023-07-24 09:16:34,776] WARN Ignoring ambiguous alias 'Value' since it refers to multiple distinct plugins

[jira] [Created] (KAFKA-15242) FixedKeyProcessor testing is unusable

2023-07-24 Thread Zlstibor Veljkovic (Jira)
Zlstibor Veljkovic created KAFKA-15242: -- Summary: FixedKeyProcessor testing is unusable Key: KAFKA-15242 URL: https://issues.apache.org/jira/browse/KAFKA-15242 Project: Kafka Issue

[GitHub] [kafka] C0urante commented on a diff in pull request #14077: KAFKA-14112: Expose replication-offset-lag Mirror metric

2023-07-24 Thread via GitHub
C0urante commented on code in PR #14077: URL: https://github.com/apache/kafka/pull/14077#discussion_r1272212887 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/AbstractWorkerSourceTask.java: ## @@ -108,7 +108,7 @@ public abstract class AbstractWorkerSourceTask

[jira] [Updated] (KAFKA-14112) Expose replication-offset-lag Mirror metric

2023-07-24 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14112?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Egerton updated KAFKA-14112: -- Labels: needs-kip (was: ) > Expose replication-offset-lag Mirror metric >

[GitHub] [kafka] bmscomp commented on pull request #14075: KAFKA-15235: No test coverage reports for Java due to settings for Jacoco being incompatible with Gradle 8.x

2023-07-24 Thread via GitHub
bmscomp commented on PR #14075: URL: https://github.com/apache/kafka/pull/14075#issuecomment-1647817977 @divijvaidya Before those changes, the generation of tests jacoco coverage report fails because of this error `"Could not set unknown property 'enabled' for Report html of

[GitHub] [kafka] showuon commented on pull request #14051: KAFKA-15218: Avoid NPE thrown while deleting topic and fetch from follower concurrently

2023-07-24 Thread via GitHub
showuon commented on PR #14051: URL: https://github.com/apache/kafka/pull/14051#issuecomment-1647817568 Yes, I've rerun the CI build. Let's wait for the results. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Updated] (KAFKA-15235) No test coverage reports for Java due to settings for Jacoco being incompatible with Gradle 8.x

2023-07-24 Thread Said BOUDJELDA (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15235?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Said BOUDJELDA updated KAFKA-15235: --- Description: On current dev branch, gradle 8.x fails while trying to generate test coverage

[GitHub] [kafka] muralibasani commented on pull request #13417: KAFKA-14585: Moving StorageTool from core to tools module

2023-07-24 Thread via GitHub
muralibasani commented on PR #13417: URL: https://github.com/apache/kafka/pull/13417#issuecomment-1647813211 > Hi @muralibasani, thanks for the additional work. I left some comments. > > As @mimaison, I also think that it would be better to create a dedicated PR for metadata and

[GitHub] [kafka] muralibasani commented on a diff in pull request #13417: KAFKA-14585: Moving StorageTool from core to tools module

2023-07-24 Thread via GitHub
muralibasani commented on code in PR #13417: URL: https://github.com/apache/kafka/pull/13417#discussion_r1272186536 ## storage/src/main/java/org/apache/kafka/storage/internals/log/LogConfig.java: ## @@ -230,6 +235,55 @@ public Optional serverConfigName(String configName) {

[GitHub] [kafka] divijvaidya commented on pull request #14075: KAFKA-15235: No test coverage reports for Java due to settings for Jacoco being incompatible with Gradle 8.x

2023-07-24 Thread via GitHub
divijvaidya commented on PR #14075: URL: https://github.com/apache/kafka/pull/14075#issuecomment-1647805630 Please add how did you test this and the before/after results. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

  1   2   >