[jira] [Commented] (KAFKA-15223) Need more clarity in documentation for upgrade/downgrade procedures and limitations across releases.

[ https://issues.apache.org/jira/browse/KAFKA-15223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17747266#comment-17747266 ] kaushik srinivas commented on KAFKA-15223: -- Any updates on this ? > Need more clarity in

[GitHub] [kafka] olalamichelle commented on pull request #14078: KAFKA-14780: Fix flaky test 'testSecondaryRefreshAfterElapsedDelay'

olalamichelle commented on PR #14078: URL: https://github.com/apache/kafka/pull/14078#issuecomment-1650957681 @divijvaidya Sorry It is my first time trying to contribute to Kafka. I didn't see any error log with the build failure. Could you help review the PR and give me some guidance on

[jira] [Commented] (KAFKA-14049) Relax Non Null Requirement for KStreamGlobalKTable Left Join

[ https://issues.apache.org/jira/browse/KAFKA-14049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17747261#comment-17747261 ] Philip Nee commented on KAFKA-14049: [~aki] - please do! > Relax Non Null Requirement for

[jira] [Commented] (KAFKA-14049) Relax Non Null Requirement for KStreamGlobalKTable Left Join

[ https://issues.apache.org/jira/browse/KAFKA-14049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17747259#comment-17747259 ] Florin Akermann commented on KAFKA-14049: - Hi, [~pnee]  I work on

[jira] [Assigned] (KAFKA-14049) Relax Non Null Requirement for KStreamGlobalKTable Left Join

[ https://issues.apache.org/jira/browse/KAFKA-14049?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Florin Akermann reassigned KAFKA-14049: --- Assignee: Florin Akermann (was: Philip Nee) > Relax Non Null Requirement for

[jira] [Assigned] (KAFKA-13197) KStream-GlobalKTable join semantics don't match documentation

[ https://issues.apache.org/jira/browse/KAFKA-13197?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Florin Akermann reassigned KAFKA-13197: --- Assignee: Florin Akermann > KStream-GlobalKTable join semantics don't match

[GitHub] [kafka] flashmouse commented on a diff in pull request #13920: KAFKA-15106 fix AbstractStickyAssignor isBalanced predict

flashmouse commented on code in PR #13920: URL: https://github.com/apache/kafka/pull/13920#discussion_r1274341109 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignorTest.java: ## @@ -724,6 +725,90 @@ public void

[GitHub] [kafka] github-actions[bot] commented on pull request #12782: KAFKA-14336: MetadataResponse#convertToNodeArray uses iteration

github-actions[bot] commented on PR #12782: URL: https://github.com/apache/kafka/pull/12782#issuecomment-1650925567 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has

[jira] [Resolved] (KAFKA-15218) NPE will be thrown while deleting topic and fetch from follower concurrently

[ https://issues.apache.org/jira/browse/KAFKA-15218?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen resolved KAFKA-15218. --- Fix Version/s: 3.6.0 Resolution: Fixed > NPE will be thrown while deleting topic and fetch

[GitHub] [kafka] showuon merged pull request #14051: KAFKA-15218: Avoid NPE thrown while deleting topic and fetch from follower concurrently

showuon merged PR #14051: URL: https://github.com/apache/kafka/pull/14051 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] showuon commented on pull request #14051: KAFKA-15218: Avoid NPE thrown while deleting topic and fetch from follower concurrently

showuon commented on PR #14051: URL: https://github.com/apache/kafka/pull/14051#issuecomment-1650851531 Thanks @vamossagar12 ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [kafka] showuon commented on pull request #14051: KAFKA-15218: Avoid NPE thrown while deleting topic and fetch from follower concurrently

showuon commented on PR #14051: URL: https://github.com/apache/kafka/pull/14051#issuecomment-1650850675 Finally had a comfortable test results: ``` Build / JDK 11 and Scala 2.13 /

[GitHub] [kafka] DL1231 commented on pull request #13947: KAFKA-15130: Delete remote segments when delete a topic

DL1231 commented on PR #13947: URL: https://github.com/apache/kafka/pull/13947#issuecomment-1650824472 @kamalcph Sure, I appreciate your feedback on the PR. Please go ahead and collaborate with me on the changes. You can push the remaining changes from your KAFKA-15130 branch to my

[GitHub] [kafka] jolshan commented on a diff in pull request #14067: KAFKA-14499: [3/N] Implement OffsetCommit API

jolshan commented on code in PR #14067: URL: https://github.com/apache/kafka/pull/14067#discussion_r1274240171 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/OffsetMetadataManagerTest.java: ## @@ -0,0 +1,1113 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] jolshan commented on a diff in pull request #14067: KAFKA-14499: [3/N] Implement OffsetCommit API

jolshan commented on code in PR #14067: URL: https://github.com/apache/kafka/pull/14067#discussion_r1274240171 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/OffsetMetadataManagerTest.java: ## @@ -0,0 +1,1113 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] jolshan commented on a diff in pull request #14067: KAFKA-14499: [3/N] Implement OffsetCommit API

jolshan commented on code in PR #14067: URL: https://github.com/apache/kafka/pull/14067#discussion_r1274237674 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/OffsetMetadataManagerTest.java: ## @@ -0,0 +1,1113 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] jolshan commented on a diff in pull request #14067: KAFKA-14499: [3/N] Implement OffsetCommit API

jolshan commented on code in PR #14067: URL: https://github.com/apache/kafka/pull/14067#discussion_r1274235539 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/OffsetMetadataManagerTest.java: ## @@ -0,0 +1,1113 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] jolshan commented on a diff in pull request #14067: KAFKA-14499: [3/N] Implement OffsetCommit API

jolshan commented on code in PR #14067: URL: https://github.com/apache/kafka/pull/14067#discussion_r1274232061 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/OffsetMetadataManagerTest.java: ## @@ -0,0 +1,1113 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] jolshan commented on a diff in pull request #14067: KAFKA-14499: [3/N] Implement OffsetCommit API

jolshan commented on code in PR #14067: URL: https://github.com/apache/kafka/pull/14067#discussion_r1274232061 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/OffsetMetadataManagerTest.java: ## @@ -0,0 +1,1113 @@ +/* + * Licensed to the Apache Software

[jira] [Commented] (KAFKA-15235) No test coverage reports for Java due to settings for Jacoco being incompatible with Gradle 8.x

[ https://issues.apache.org/jira/browse/KAFKA-15235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17747217#comment-17747217 ] Said BOUDJELDA commented on KAFKA-15235: [~ethaden]  Please let me know more about your

[GitHub] [kafka] jolshan commented on a diff in pull request #14067: KAFKA-14499: [3/N] Implement OffsetCommit API

jolshan commented on code in PR #14067: URL: https://github.com/apache/kafka/pull/14067#discussion_r1274227661 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/generic/GenericGroupTest.java: ## @@ -956,6 +961,72 @@ public void

[jira] [Assigned] (KAFKA-15097) NoSuchFileException in LogCleaner Operation.

[ https://issues.apache.org/jira/browse/KAFKA-15097?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Said BOUDJELDA reassigned KAFKA-15097: -- Assignee: Said BOUDJELDA > NoSuchFileException in LogCleaner Operation. >

[jira] [Commented] (KAFKA-15097) NoSuchFileException in LogCleaner Operation.

[ https://issues.apache.org/jira/browse/KAFKA-15097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17747212#comment-17747212 ] Said BOUDJELDA commented on KAFKA-15097: I really want to take this ticket and start first by

[jira] [Commented] (KAFKA-12317) Relax non-null key requirement for left/outer KStream joins

[ https://issues.apache.org/jira/browse/KAFKA-12317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17747210#comment-17747210 ] Matthias J. Sax commented on KAFKA-12317: - Thanks for picking it up – I think it would be good

[GitHub] [kafka] mjsax commented on pull request #13909: KAFKA-14957: Update-Description-String

mjsax commented on PR #13909: URL: https://github.com/apache/kafka/pull/13909#issuecomment-1650680240 Yes, that the class I was referring, too. -- I don't know the detail from top of my head, but I am sure if you read the code you can figure it out. Let us know if you have any questions.

[jira] [Created] (KAFKA-15251) Upgrade system test to use 3.5.1

Matthias J. Sax created KAFKA-15251: --- Summary: Upgrade system test to use 3.5.1 Key: KAFKA-15251 URL: https://issues.apache.org/jira/browse/KAFKA-15251 Project: Kafka Issue Type: Test

[GitHub] [kafka] mjsax commented on pull request #12988: KAFKA-14405: Log a warning when users attempt to set a config controlled by Streams

mjsax commented on PR #12988: URL: https://github.com/apache/kafka/pull/12988#issuecomment-1650677564 Thanks! Great to hear. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [kafka] jeffkbkim commented on a diff in pull request #14067: KAFKA-14499: [3/N] Implement OffsetCommit API

jeffkbkim commented on code in PR #14067: URL: https://github.com/apache/kafka/pull/14067#discussion_r1274185328 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetMetadataManager.java: ## @@ -0,0 +1,454 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] rreddy-22 opened a new pull request, #14099: KAFKA-14702:Extend server side assignor to support rack aware replica placement

rreddy-22 opened a new pull request, #14099: URL: https://github.com/apache/kafka/pull/14099 We want to make the assignors rack aware and in order to obtain and provide the rack Information the following interface modifications were made:- SubcribedTopicDescribor - Interface passed

[GitHub] [kafka] jeffkbkim commented on a diff in pull request #14067: KAFKA-14499: [3/N] Implement OffsetCommit API

jeffkbkim commented on code in PR #14067: URL: https://github.com/apache/kafka/pull/14067#discussion_r1274182711 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetMetadataManager.java: ## @@ -0,0 +1,454 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] jeffkbkim commented on a diff in pull request #14067: KAFKA-14499: [3/N] Implement OffsetCommit API

jeffkbkim commented on code in PR #14067: URL: https://github.com/apache/kafka/pull/14067#discussion_r1274173286 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetMetadataManager.java: ## @@ -0,0 +1,454 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] bmscomp opened a new pull request, #14098: MINOR: Upgrade version of gradle-versions-plugin to 0.47.0

bmscomp opened a new pull request, #14098: URL: https://github.com/apache/kafka/pull/14098 Upgrade the version of `Gradle` versions plugin, to version 0.47.0 is a too minor change that have no affect on the build process or design, nor documentation, but I can see it's very important to

[GitHub] [kafka] jolshan commented on a diff in pull request #14067: KAFKA-14499: [3/N] Implement OffsetCommit API

jolshan commented on code in PR #14067: URL: https://github.com/apache/kafka/pull/14067#discussion_r1274178895 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetMetadataManager.java: ## @@ -0,0 +1,454 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] jolshan commented on a diff in pull request #14067: KAFKA-14499: [3/N] Implement OffsetCommit API

jolshan commented on code in PR #14067: URL: https://github.com/apache/kafka/pull/14067#discussion_r1274177883 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/generic/GenericGroup.java: ## @@ -738,6 +742,84 @@ public String generateMemberId(String

[GitHub] [kafka] jolshan commented on a diff in pull request #14067: KAFKA-14499: [3/N] Implement OffsetCommit API

jolshan commented on code in PR #14067: URL: https://github.com/apache/kafka/pull/14067#discussion_r1274175859 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/generic/GenericGroup.java: ## @@ -738,6 +742,84 @@ public String generateMemberId(String

[GitHub] [kafka] jolshan commented on a diff in pull request #14067: KAFKA-14499: [3/N] Implement OffsetCommit API

jolshan commented on code in PR #14067: URL: https://github.com/apache/kafka/pull/14067#discussion_r1274174772 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroup.java: ## @@ -497,6 +499,30 @@ public DeadlineAndEpoch

[GitHub] [kafka] jolshan commented on a diff in pull request #14067: KAFKA-14499: [3/N] Implement OffsetCommit API

jolshan commented on code in PR #14067: URL: https://github.com/apache/kafka/pull/14067#discussion_r1274168232 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/ReplicatedGroupCoordinator.java: ## @@ -239,6 +283,14 @@ public void replay(Record record) throws

[GitHub] [kafka] jolshan commented on a diff in pull request #14067: KAFKA-14499: [3/N] Implement OffsetCommit API

jolshan commented on code in PR #14067: URL: https://github.com/apache/kafka/pull/14067#discussion_r1274166277 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/ReplicatedGroupCoordinator.java: ## @@ -193,6 +217,22 @@ public CoordinatorResult

[GitHub] [kafka] mjsax commented on pull request #14085: MINOR: fix docs markup

mjsax commented on PR #14085: URL: https://github.com/apache/kafka/pull/14085#issuecomment-1650617474 Merged to `trunk` and cherry-picked to `3.5` branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [kafka] mjsax merged pull request #14085: MINOR: fix docs markup

mjsax merged PR #14085: URL: https://github.com/apache/kafka/pull/14085 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] jeffkbkim commented on a diff in pull request #14067: KAFKA-14499: [3/N] Implement OffsetCommit API

jeffkbkim commented on code in PR #14067: URL: https://github.com/apache/kafka/pull/14067#discussion_r1274158029 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetMetadataManager.java: ## @@ -0,0 +1,454 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] jeffkbkim commented on a diff in pull request #14067: KAFKA-14499: [3/N] Implement OffsetCommit API

jeffkbkim commented on code in PR #14067: URL: https://github.com/apache/kafka/pull/14067#discussion_r1274154502 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorService.java: ## @@ -471,9 +472,48 @@ public CompletableFuture commitOffsets(

[GitHub] [kafka] lihaosky opened a new pull request, #14097: KAFKA-15022: [4/N] use client tag assignor for rack aware standby task assignment

lihaosky opened a new pull request, #14097: URL: https://github.com/apache/kafka/pull/14097 ## Description Update `ClientTagAwareStandbyTaskAssignor` to take functional params so that we can pass custom tags from racks. ## Testing Unit test -- This is an automated

[GitHub] [kafka] jolshan commented on a diff in pull request #14067: KAFKA-14499: [3/N] Implement OffsetCommit API

jolshan commented on code in PR #14067: URL: https://github.com/apache/kafka/pull/14067#discussion_r1274140048 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/Utils.java: ## @@ -0,0 +1,40 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [kafka] jolshan commented on a diff in pull request #14067: KAFKA-14499: [3/N] Implement OffsetCommit API

jolshan commented on code in PR #14067: URL: https://github.com/apache/kafka/pull/14067#discussion_r1274140048 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/Utils.java: ## @@ -0,0 +1,40 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [kafka] jolshan commented on a diff in pull request #14067: KAFKA-14499: [3/N] Implement OffsetCommit API

jolshan commented on code in PR #14067: URL: https://github.com/apache/kafka/pull/14067#discussion_r1274139408 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetAndMetadata.java: ## @@ -114,12 +116,29 @@ public static OffsetAndMetadata fromRecord(

[GitHub] [kafka] jeffkbkim commented on a diff in pull request #14056: KAFKA-14501: Implement Heartbeat protocol in new GroupCoordinator

jeffkbkim commented on code in PR #14056: URL: https://github.com/apache/kafka/pull/14056#discussion_r1274116830 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorService.java: ## @@ -368,9 +369,29 @@ public CompletableFuture heartbeat(

[GitHub] [kafka] jolshan commented on a diff in pull request #14090: KAFKA-14048; CoordinatorContext should be protected by a lock

jolshan commented on code in PR #14090: URL: https://github.com/apache/kafka/pull/14090#discussion_r1274109070 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/CoordinatorRuntime.java: ## @@ -1053,50 +1066,80 @@ private void enqueue(CoordinatorEvent

[GitHub] [kafka] jolshan commented on a diff in pull request #14090: KAFKA-14048; CoordinatorContext should be protected by a lock

jolshan commented on code in PR #14090: URL: https://github.com/apache/kafka/pull/14090#discussion_r1274107844 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/CoordinatorRuntime.java: ## @@ -1053,50 +1066,80 @@ private void enqueue(CoordinatorEvent

[GitHub] [kafka] jolshan commented on a diff in pull request #14090: KAFKA-14048; CoordinatorContext should be protected by a lock

jolshan commented on code in PR #14090: URL: https://github.com/apache/kafka/pull/14090#discussion_r1274094726 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/runtime/CoordinatorRuntimeTest.java: ## @@ -970,14 +970,15 @@ public void testClose() throws

[GitHub] [kafka] jolshan commented on a diff in pull request #14090: KAFKA-14048; CoordinatorContext should be protected by a lock

jolshan commented on code in PR #14090: URL: https://github.com/apache/kafka/pull/14090#discussion_r1274093513 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/CoordinatorRuntime.java: ## @@ -1187,63 +1230,62 @@ public void scheduleLoadOperation(

[GitHub] [kafka] jolshan commented on a diff in pull request #14090: KAFKA-14048; CoordinatorContext should be protected by a lock

jolshan commented on code in PR #14090: URL: https://github.com/apache/kafka/pull/14090#discussion_r1274089957 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/CoordinatorRuntime.java: ## @@ -1187,63 +1230,62 @@ public void scheduleLoadOperation(

[GitHub] [kafka] jeffkbkim commented on a diff in pull request #14017: KAFKA-14500; [6/6] Implement SyncGroup protocol in new GroupCoordinator

jeffkbkim commented on code in PR #14017: URL: https://github.com/apache/kafka/pull/14017#discussion_r1274089242 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java: ## @@ -8539,5 +8379,20 @@ private static class RebalanceResult {

[GitHub] [kafka] jolshan commented on a diff in pull request #14067: KAFKA-14499: [3/N] Implement OffsetCommit API

jolshan commented on code in PR #14067: URL: https://github.com/apache/kafka/pull/14067#discussion_r1274067065 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetMetadataManager.java: ## @@ -0,0 +1,454 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] jeffkbkim commented on a diff in pull request #14017: KAFKA-14500; [6/6] Implement SyncGroup protocol in new GroupCoordinator

jeffkbkim commented on code in PR #14017: URL: https://github.com/apache/kafka/pull/14017#discussion_r1274066264 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java: ## @@ -5524,5 +5670,2897 @@ private static Record

[GitHub] [kafka] jolshan commented on a diff in pull request #14067: KAFKA-14499: [3/N] Implement OffsetCommit API

jolshan commented on code in PR #14067: URL: https://github.com/apache/kafka/pull/14067#discussion_r1274065371 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetMetadataManager.java: ## @@ -0,0 +1,454 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] ahuang98 commented on pull request #14084: [MINOR] Add latest versions to kraft upgrade kafkatest

ahuang98 commented on PR #14084: URL: https://github.com/apache/kafka/pull/14084#issuecomment-1650480884 Combined, the last two runs look good. Test failures look to be unrelated. https://ci-builds.apache.org/blue/organizations/jenkins/Kafka%2Fkafka-pr/detail/PR-14084/1/tests

[GitHub] [kafka] mumrah merged pull request #14062: MINOR: Add a Builder for KRaftMigrationDriver

mumrah merged PR #14062: URL: https://github.com/apache/kafka/pull/14062 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] nizhikov opened a new pull request, #14096: KAFKA-14595 AdminUtils rewritten in java

nizhikov opened a new pull request, #14096: URL: https://github.com/apache/kafka/pull/14096 This PR contains migration `AdminUtils` and `BrokerMetadata` classes to java. These classes used in `ReassignPartitionsCommand` which are subject to rewrite in #13247 ### Committer

[GitHub] [kafka] bbejeck commented on pull request #13987: Kafka-15126: Range queries to accept null lower and upper bounds

bbejeck commented on PR #13987: URL: https://github.com/apache/kafka/pull/13987#issuecomment-1650430142 @Cerchie since it's been a couple of weeks for this PR can you rebase this with trunk? Pending the related tests passing we should be able to merge ping @vvcephei for a quick

[GitHub] [kafka] dajac commented on a diff in pull request #14056: KAFKA-14501: Implement Heartbeat protocol in new GroupCoordinator

dajac commented on code in PR #14056: URL: https://github.com/apache/kafka/pull/14056#discussion_r1273976287 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorService.java: ## @@ -368,9 +369,29 @@ public CompletableFuture heartbeat(

[GitHub] [kafka] dajac commented on a diff in pull request #14017: KAFKA-14500; [6/6] Implement SyncGroup protocol in new GroupCoordinator

dajac commented on code in PR #14017: URL: https://github.com/apache/kafka/pull/14017#discussion_r1273993761 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorService.java: ## @@ -330,9 +330,30 @@ public CompletableFuture syncGroup(

[GitHub] [kafka] dajac commented on a diff in pull request #14017: KAFKA-14500; [6/6] Implement SyncGroup protocol in new GroupCoordinator

dajac commented on code in PR #14017: URL: https://github.com/apache/kafka/pull/14017#discussion_r1273964395 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java: ## @@ -5524,5 +5670,2897 @@ private static Record

[GitHub] [kafka] dajac commented on a diff in pull request #14017: KAFKA-14500; [6/6] Implement SyncGroup protocol in new GroupCoordinator

dajac commented on code in PR #14017: URL: https://github.com/apache/kafka/pull/14017#discussion_r1273962781 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java: ## @@ -8539,5 +8379,20 @@ private static class RebalanceResult {

[jira] [Updated] (KAFKA-15250) DefaultBackgroundThread is running tight loop

[ https://issues.apache.org/jira/browse/KAFKA-15250?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Philip Nee updated KAFKA-15250: --- Parent: KAFKA-14246 Issue Type: Sub-task (was: Bug) > DefaultBackgroundThread is running

[jira] [Created] (KAFKA-15250) DefaultBackgroundThread is running tight loop

Philip Nee created KAFKA-15250: -- Summary: DefaultBackgroundThread is running tight loop Key: KAFKA-15250 URL: https://issues.apache.org/jira/browse/KAFKA-15250 Project: Kafka Issue Type: Bug

[GitHub] [kafka] dajac commented on a diff in pull request #14017: KAFKA-14500; [6/6] Implement SyncGroup protocol in new GroupCoordinator

dajac commented on code in PR #14017: URL: https://github.com/apache/kafka/pull/14017#discussion_r1273960665 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java: ## @@ -5524,5 +5670,2897 @@ private static Record

[GitHub] [kafka] dajac commented on a diff in pull request #14017: KAFKA-14500; [6/6] Implement SyncGroup protocol in new GroupCoordinator

dajac commented on code in PR #14017: URL: https://github.com/apache/kafka/pull/14017#discussion_r1273959151 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java: ## @@ -5524,5 +5670,2897 @@ private static Record

[GitHub] [kafka] dajac commented on a diff in pull request #14017: KAFKA-14500; [6/6] Implement SyncGroup protocol in new GroupCoordinator

dajac commented on code in PR #14017: URL: https://github.com/apache/kafka/pull/14017#discussion_r1273958096 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java: ## @@ -5524,5 +5670,2897 @@ private static Record

[GitHub] [kafka] dajac commented on a diff in pull request #14017: KAFKA-14500; [6/6] Implement SyncGroup protocol in new GroupCoordinator

dajac commented on code in PR #14017: URL: https://github.com/apache/kafka/pull/14017#discussion_r1273957238 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java: ## @@ -5524,5 +5670,2897 @@ private static Record

[GitHub] [kafka] dajac commented on a diff in pull request #14017: KAFKA-14500; [6/6] Implement SyncGroup protocol in new GroupCoordinator

dajac commented on code in PR #14017: URL: https://github.com/apache/kafka/pull/14017#discussion_r1273954244 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java: ## @@ -5524,5 +5670,2897 @@ private static Record

[GitHub] [kafka] dajac commented on a diff in pull request #14017: KAFKA-14500; [6/6] Implement SyncGroup protocol in new GroupCoordinator

dajac commented on code in PR #14017: URL: https://github.com/apache/kafka/pull/14017#discussion_r1273952844 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java: ## @@ -5524,5 +5670,2897 @@ private static Record

[GitHub] [kafka] dajac commented on a diff in pull request #14017: KAFKA-14500; [6/6] Implement SyncGroup protocol in new GroupCoordinator

dajac commented on code in PR #14017: URL: https://github.com/apache/kafka/pull/14017#discussion_r1273950275 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java: ## @@ -5205,11 +5245,102 @@ public void

[GitHub] [kafka] dajac commented on a diff in pull request #14067: KAFKA-14499: [3/N] Implement OffsetCommit API

dajac commented on code in PR #14067: URL: https://github.com/apache/kafka/pull/14067#discussion_r1273942395 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetMetadataManager.java: ## @@ -0,0 +1,454 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [kafka] vamossagar12 commented on pull request #13801: KAFKA-15018: Failing offset flush for EOS when secondary offset store writes fails for tombstone records

vamossagar12 commented on PR #13801: URL: https://github.com/apache/kafka/pull/13801#issuecomment-1650338567 Regarding > Can we skip writes for tombstone records to the secondary store in our second write (the one that takes place after we've written to the primary store)? It's a

[GitHub] [kafka] vamossagar12 commented on a diff in pull request #13801: KAFKA-15018: Failing offset flush for EOS when secondary offset store writes fails for tombstone records

vamossagar12 commented on code in PR #13801: URL: https://github.com/apache/kafka/pull/13801#discussion_r1273932710 ## connect/runtime/src/main/java/org/apache/kafka/connect/storage/ConnectorOffsetBackingStore.java: ## @@ -279,8 +284,51 @@ public Future set(Map values,

[GitHub] [kafka] jeffkbkim commented on a diff in pull request #14017: KAFKA-14500; [6/6] Implement SyncGroup protocol in new GroupCoordinator

jeffkbkim commented on code in PR #14017: URL: https://github.com/apache/kafka/pull/14017#discussion_r1273929393 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java: ## @@ -5524,5 +5670,2897 @@ private static Record

[GitHub] [kafka] kirktrue opened a new pull request, #14095: [DON'T MERGE] Added whitespace to README

kirktrue opened a new pull request, #14095: URL: https://github.com/apache/kafka/pull/14095 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of

[GitHub] [kafka] kirktrue commented on pull request #13990: KAFKA-14937: Refactoring for client code to reduce boilerplate

kirktrue commented on PR #13990: URL: https://github.com/apache/kafka/pull/13990#issuecomment-1650291166 @junrao in the logs for the JDK 11 run, I see this: ``` > Task :clients:testClasses Unexpected exception thrown. org.gradle.internal.remote.internal.MessageIOException:

[GitHub] [kafka] omkreddy commented on pull request #14094: KAFKA-15243: Desanitizing(AKA: decoding) User before listing them

omkreddy commented on PR #14094: URL: https://github.com/apache/kafka/pull/14094#issuecomment-1650257506 @sciclon2 Thanks, Can you try add/update test here: https://github.com/apache/kafka/blob/trunk/core/src/test/scala/unit/kafka/server/AlterUserScramCredentialsRequestTest.scala#L251 --

[jira] [Commented] (KAFKA-15243) User creation mismatch

[ https://issues.apache.org/jira/browse/KAFKA-15243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17747081#comment-17747081 ] Sergio Troiano commented on KAFKA-15243: [~omkreddy] , thanks, PR open

[GitHub] [kafka] sciclon2 opened a new pull request, #14094: KAFKA-15243: Desanitizing(AKA: decoding) User before listing them

sciclon2 opened a new pull request, #14094: URL: https://github.com/apache/kafka/pull/14094 This PR aims to fix a bug, basically there is a mismatch between the Kafka users and the list tool output. Kafka allows to create users with special characters that are encoded before

[jira] [Commented] (KAFKA-15191) Add support for Micrometer Observation

[ https://issues.apache.org/jira/browse/KAFKA-15191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17747079#comment-17747079 ] Bryan commented on KAFKA-15191: --- Strong interest from my perspective for end-to-end visibility of a flow,

[GitHub] [kafka] gharris1727 commented on pull request #14089: KAFKA-15244: Remove PluginType.from(Class)

gharris1727 commented on PR #14089: URL: https://github.com/apache/kafka/pull/14089#issuecomment-1650218495 > should we expand the scope of how PluginDesc objects can be compared? Yes, this is a good idea. I could feel that something was wrong when I had to double-cast the dissimilar

[GitHub] [kafka] gharris1727 commented on a diff in pull request #14089: KAFKA-15244: Remove PluginType.from(Class)

gharris1727 commented on code in PR #14089: URL: https://github.com/apache/kafka/pull/14089#discussion_r1273845134 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/isolation/PluginDesc.java: ## @@ -115,6 +115,10 @@ public int compareTo(PluginDesc other) {

[GitHub] [kafka] junrao commented on pull request #13990: KAFKA-14937: Refactoring for client code to reduce boilerplate

junrao commented on PR #13990: URL: https://github.com/apache/kafka/pull/13990#issuecomment-1650204432 @kirktrue : For JDK 11 tests, it seems that there were 2 checkstyle failures `:clients:checkstyleTest`and `:server-common:checkstyleTest`. -- This is an automated message from

[GitHub] [kafka] cmccabe commented on a diff in pull request #13643: KAFKA-15213: provide the exact offset to QuorumController.replay

cmccabe commented on code in PR #13643: URL: https://github.com/apache/kafka/pull/13643#discussion_r1273720728 ## raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java: ## @@ -2394,6 +2394,11 @@ public Optional latestSnapshotId() { return

[jira] [Assigned] (KAFKA-15200) verify pre-requisite at start of release.py

[ https://issues.apache.org/jira/browse/KAFKA-15200?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Abhinav Tripathi reassigned KAFKA-15200: Assignee: Abhinav Tripathi > verify pre-requisite at start of release.py >

[GitHub] [kafka] cmccabe commented on a diff in pull request #13643: KAFKA-15213: provide the exact offset to QuorumController.replay

cmccabe commented on code in PR #13643: URL: https://github.com/apache/kafka/pull/13643#discussion_r1273720728 ## raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java: ## @@ -2394,6 +2394,11 @@ public Optional latestSnapshotId() { return

[GitHub] [kafka] gharris1727 commented on a diff in pull request #14089: KAFKA-15244: Remove PluginType.from(Class)

gharris1727 commented on code in PR #14089: URL: https://github.com/apache/kafka/pull/14089#discussion_r1273821447 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/isolation/PluginDesc.java: ## @@ -115,6 +115,10 @@ public int compareTo(PluginDesc other) {

[GitHub] [kafka] C0urante commented on a diff in pull request #14089: KAFKA-15244: Remove PluginType.from(Class)

C0urante commented on code in PR #14089: URL: https://github.com/apache/kafka/pull/14089#discussion_r1273737370 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/isolation/PluginDesc.java: ## @@ -115,6 +115,10 @@ public int compareTo(PluginDesc other) {

[GitHub] [kafka] mimaison commented on a diff in pull request #14005: KAFKA-15177: Implement KIP-875 SourceConnector::alterOffset API in MirrorMaker 2 connectors

mimaison commented on code in PR #14005: URL: https://github.com/apache/kafka/pull/14005#discussion_r1269270009 ## connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorHeartbeatConnector.java: ## @@ -85,6 +89,26 @@ public String version() { return

[GitHub] [kafka] mimaison merged pull request #14070: MINOR: Fix typo in ProduceRequest.json

mimaison merged PR #14070: URL: https://github.com/apache/kafka/pull/14070 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] cmccabe commented on a diff in pull request #13643: KAFKA-15213: provide the exact offset to QuorumController.replay

cmccabe commented on code in PR #13643: URL: https://github.com/apache/kafka/pull/13643#discussion_r1273720728 ## raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java: ## @@ -2394,6 +2394,11 @@ public Optional latestSnapshotId() { return

[GitHub] [kafka] cmccabe commented on a diff in pull request #13643: KAFKA-15213: provide the exact offset to QuorumController.replay

cmccabe commented on code in PR #13643: URL: https://github.com/apache/kafka/pull/13643#discussion_r1273742201 ## raft/src/main/java/org/apache/kafka/raft/internals/BatchAccumulator.java: ## @@ -147,6 +126,13 @@ private long append(int epoch, List records, boolean isAtomic) {

[GitHub] [kafka] fvaleri commented on pull request #13313: KAFKA-14760: Move ThroughputThrottler from tools to clients, remove tools dependency from connect-runtime

fvaleri commented on PR #13313: URL: https://github.com/apache/kafka/pull/13313#issuecomment-1650078193 I opened a PR with an attempt to fix it: https://github.com/apache/kafka/pull/14092. It works with mentioned STs, but I'm running all non-core STs to actually verify it's all

[GitHub] [kafka] cmccabe commented on a diff in pull request #13643: KAFKA-15213: provide the exact offset to QuorumController.replay

cmccabe commented on code in PR #13643: URL: https://github.com/apache/kafka/pull/13643#discussion_r1273742201 ## raft/src/main/java/org/apache/kafka/raft/internals/BatchAccumulator.java: ## @@ -147,6 +126,13 @@ private long append(int epoch, List records, boolean isAtomic) {

[GitHub] [kafka] gharris1727 commented on pull request #13313: KAFKA-14760: Move ThroughputThrottler from tools to clients, remove tools dependency from connect-runtime

gharris1727 commented on PR #13313: URL: https://github.com/apache/kafka/pull/13313#issuecomment-1650067494 @fvaleri Thanks for pointing that out! I mistakenly assumed that I wasn't going to be affecting intermediate versions, or that the location I changed was the only place where we

[GitHub] [kafka] dajac commented on a diff in pull request #14017: KAFKA-14500; [6/6] Implement SyncGroup protocol in new GroupCoordinator

dajac commented on code in PR #14017: URL: https://github.com/apache/kafka/pull/14017#discussion_r1273730364 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java: ## @@ -5524,5 +5670,2897 @@ private static Record

[GitHub] [kafka] cmccabe commented on a diff in pull request #13643: KAFKA-15213: provide the exact offset to QuorumController.replay

cmccabe commented on code in PR #13643: URL: https://github.com/apache/kafka/pull/13643#discussion_r1273720728 ## raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java: ## @@ -2394,6 +2394,11 @@ public Optional latestSnapshotId() { return

  1   2   >