[jira] [Commented] (KAFKA-12829) Remove Deprecated methods under Topology

[ https://issues.apache.org/jira/browse/KAFKA-12829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17747726#comment-17747726 ] Junyao Huang commented on KAFKA-12829: -- [~josep.prat]  I am new to kafka contribution, seeing

[jira] [Commented] (KAFKA-14908) Sporadic "Address already in use" when starting kafka cluster embedded within tests

[ https://issues.apache.org/jira/browse/KAFKA-14908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17747721#comment-17747721 ] Luke Chen commented on KAFKA-14908: --- Thanks [~divijvaidya] , but I cannot see the `Address already in

[GitHub] [kafka] showuon commented on pull request #14080: MINOR: Add co-authors to release announcement email template

showuon commented on PR #14080: URL: https://github.com/apache/kafka/pull/14080#issuecomment-1652827077 Nice improvement! Sorry for being late! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] ableegoldman commented on a diff in pull request #13846: KAFKA-15022: [1/N] add configs to control rack aware assignment

ableegoldman commented on code in PR #13846: URL: https://github.com/apache/kafka/pull/13846#discussion_r1275629503 ## streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java: ## @@ -755,6 +755,18 @@ public class StreamsConfig extends AbstractConfig { public

[GitHub] [kafka] lihaosky commented on a diff in pull request #14097: KAFKA-15022: [4/N] use client tag assignor for rack aware standby task assignment

lihaosky commented on code in PR #14097: URL: https://github.com/apache/kafka/pull/14097#discussion_r1275599868 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/assignment/ClientTagAwareStandbyTaskAssignorTest.java: ## @@ -313,20 +315,145 @@ public void

[GitHub] [kafka] edoardocomar commented on pull request #13113: KAFKA-5238: BrokerTopicMetrics can be recreated after topic is deleted

edoardocomar commented on PR #13113: URL: https://github.com/apache/kafka/pull/13113#issuecomment-1652693790 bump2 - @mimaison @rajinisivaram @tombentley @ijuma I'd like this not to be closed by staleness -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kafka] mjsax commented on a diff in pull request #14097: KAFKA-15022: [4/N] use client tag assignor for rack aware standby task assignment

mjsax commented on code in PR #14097: URL: https://github.com/apache/kafka/pull/14097#discussion_r1275580851 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/assignment/ClientTagAwareStandbyTaskAssignorTest.java: ## @@ -313,20 +315,145 @@ public void

[GitHub] [kafka] lihaosky commented on a diff in pull request #14097: KAFKA-15022: [4/N] use client tag assignor for rack aware standby task assignment

lihaosky commented on code in PR #14097: URL: https://github.com/apache/kafka/pull/14097#discussion_r1275577058 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/RackAwareTaskAssignor.java: ## @@ -48,23 +49,25 @@ public class RackAwareTaskAssignor

[GitHub] [kafka] mjsax commented on a diff in pull request #14097: KAFKA-15022: [4/N] use client tag assignor for rack aware standby task assignment

mjsax commented on code in PR #14097: URL: https://github.com/apache/kafka/pull/14097#discussion_r1275571720 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/RackAwareTaskAssignor.java: ## @@ -48,23 +49,25 @@ public class RackAwareTaskAssignor {

[GitHub] [kafka] mjsax merged pull request #14030: KAFKA-15022: [3/N] use graph to compute rack aware assignment for active stateful tasks

mjsax merged PR #14030: URL: https://github.com/apache/kafka/pull/14030 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] mjsax commented on a diff in pull request #14030: KAFKA-15022: [3/N] use graph to compute rack aware assignment for active stateful tasks

mjsax commented on code in PR #14030: URL: https://github.com/apache/kafka/pull/14030#discussion_r1275434335 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/assignment/AssignmentTestUtils.java: ## @@ -69,12 +71,38 @@ public final class AssignmentTestUtils

[GitHub] [kafka] ahuang98 opened a new pull request, #14109: [MINOR] Addressing NPE when broker's initialCatchUpFuture fails

ahuang98 opened a new pull request, #14109: URL: https://github.com/apache/kafka/pull/14109 We want the `firstPublishFuture` to complete exceptionally as well when `initialCatchUpFuture` completes exceptionally, however `brokerMetadataPublisher` is not instantiated at this point which will

[GitHub] [kafka] jolshan commented on a diff in pull request #14088: MINOR: Adjust Invalid Record Exception for Invalid Txn State as mentioned in KIP-890

jolshan commented on code in PR #14088: URL: https://github.com/apache/kafka/pull/14088#discussion_r1275558576 ## clients/src/test/java/org/apache/kafka/clients/producer/internals/SenderTest.java: ## @@ -3107,6 +3099,45 @@ public void

[GitHub] [kafka] lihaosky opened a new pull request, #14108: KAFKA-15022: [5/N] compute rack aware assignment for standby tasks

lihaosky opened a new pull request, #14108: URL: https://github.com/apache/kafka/pull/14108 ## Description Optimize cross rack traffic for standby tasks. This is a greedy algorithm to find optimal assignment between each pair of clients if standby tasks between them can be swapped. This

[GitHub] [kafka] jolshan commented on a diff in pull request #14088: MINOR: Adjust Invalid Record Exception for Invalid Txn State as mentioned in KIP-890

jolshan commented on code in PR #14088: URL: https://github.com/apache/kafka/pull/14088#discussion_r1275549290 ## clients/src/test/java/org/apache/kafka/clients/producer/internals/SenderTest.java: ## @@ -3107,6 +3099,45 @@ public void

[GitHub] [kafka] jolshan commented on a diff in pull request #14088: MINOR: Adjust Invalid Record Exception for Invalid Txn State as mentioned in KIP-890

jolshan commented on code in PR #14088: URL: https://github.com/apache/kafka/pull/14088#discussion_r1275549290 ## clients/src/test/java/org/apache/kafka/clients/producer/internals/SenderTest.java: ## @@ -3107,6 +3099,45 @@ public void

[GitHub] [kafka] jeffkbkim commented on a diff in pull request #14067: KAFKA-14499: [3/N] Implement OffsetCommit API

jeffkbkim commented on code in PR #14067: URL: https://github.com/apache/kafka/pull/14067#discussion_r1275548644 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetMetadataManager.java: ## @@ -0,0 +1,454 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] hachikuji commented on a diff in pull request #14088: MINOR: Adjust Invalid Record Exception for Invalid Txn State as mentioned in KIP-890

hachikuji commented on code in PR #14088: URL: https://github.com/apache/kafka/pull/14088#discussion_r1275544007 ## clients/src/test/java/org/apache/kafka/clients/producer/internals/SenderTest.java: ## @@ -3107,6 +3099,45 @@ public void

[jira] [Commented] (KAFKA-15235) No test coverage reports for Java due to settings for Jacoco being incompatible with Gradle 8.x

[ https://issues.apache.org/jira/browse/KAFKA-15235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17747674#comment-17747674 ] Eike Thaden commented on KAFKA-15235: - [~divijvaidya] Thank you for verifying that you can generate

[GitHub] [kafka] gharris1727 commented on pull request #14055: KAFKA-15031: Add plugin.discovery to Connect worker configuration (KIP-898)

gharris1727 commented on PR #14055: URL: https://github.com/apache/kafka/pull/14055#issuecomment-1652619220 > The question of plugins that are installed directly onto the classpath might be a bit tricky... let me know if I've missed something. My current understanding is that these plugins

[GitHub] [kafka] jeffkbkim commented on a diff in pull request #14067: KAFKA-14499: [3/N] Implement OffsetCommit API

jeffkbkim commented on code in PR #14067: URL: https://github.com/apache/kafka/pull/14067#discussion_r1275398688 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -408,6 +409,17 @@ public MetadataImage image() {

[jira] [Comment Edited] (KAFKA-14748) Relax non-null FK left-join requirement

[ https://issues.apache.org/jira/browse/KAFKA-14748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17747670#comment-17747670 ] Florin Akermann edited comment on KAFKA-14748 at 7/26/23 9:54 PM: -- I

[jira] [Commented] (KAFKA-12317) Relax non-null key requirement for left/outer KStream joins

[ https://issues.apache.org/jira/browse/KAFKA-12317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17747671#comment-17747671 ] Florin Akermann commented on KAFKA-12317: - Thanks [~mjsax], I have assigned myself to the rest

[jira] [Commented] (KAFKA-14748) Relax non-null FK left-join requirement

[ https://issues.apache.org/jira/browse/KAFKA-14748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17747670#comment-17747670 ] Florin Akermann commented on KAFKA-14748: - I have created a PR for this particular issue.

[GitHub] [kafka] florin-akermann opened a new pull request, #14107: Kafka-14748: Relax non-null FK left-join requirement

florin-akermann opened a new pull request, #14107: URL: https://github.com/apache/kafka/pull/14107 Relax non-null FK left-join requirement. Testing Strategy: Inject extractor which returns null on first or second element. ### Committer Checklist (excluded from commit message)

[GitHub] [kafka] junrao commented on pull request #14086: MINOR: Test assign() and assignment() in the integration test

junrao commented on PR #14086: URL: https://github.com/apache/kafka/pull/14086#issuecomment-1652497248 @philipnee : Thanks for the PR. Are the test failures related? Also, there are compilation failures in JDK 8. > Task :core:compileTestScala [Error]

[GitHub] [kafka] dajac commented on a diff in pull request #14067: KAFKA-14499: [3/N] Implement OffsetCommit API

dajac commented on code in PR #14067: URL: https://github.com/apache/kafka/pull/14067#discussion_r1275472419 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetMetadataManager.java: ## @@ -0,0 +1,454 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [kafka] cmccabe commented on a diff in pull request #13643: KAFKA-15213: provide the exact offset to QuorumController.replay

cmccabe commented on code in PR #13643: URL: https://github.com/apache/kafka/pull/13643#discussion_r1275472446 ## metadata/src/main/java/org/apache/kafka/controller/QuorumController.java: ## @@ -1168,15 +1165,15 @@ private void updateWriteOffset(long offset) { } }

[GitHub] [kafka] jolshan commented on a diff in pull request #14088: MINOR: Adjust Invalid Record Exception for Invalid Txn State as mentioned in KIP-890

jolshan commented on code in PR #14088: URL: https://github.com/apache/kafka/pull/14088#discussion_r1275468083 ## core/src/test/scala/unit/kafka/server/AddPartitionsToTxnManagerTest.scala: ## @@ -201,7 +201,7 @@ class AddPartitionsToTxnManagerTest {

[GitHub] [kafka] muralibasani commented on pull request #13417: KAFKA-14585: Moving StorageTool from core to tools module

muralibasani commented on PR #13417: URL: https://github.com/apache/kafka/pull/13417#issuecomment-1652450786 > _Description_ > This PR does the below. @fvaleri here is the new PR https://github.com/apache/kafka/pull/14106 There are a few dependencies on the scala version of

[GitHub] [kafka] muralibasani opened a new pull request, #14106: KAFKA-14585: 1st part : Java versions for metadata/broker and updated LogConfig

muralibasani opened a new pull request, #14106: URL: https://github.com/apache/kafka/pull/14106 Description This PR does the below. - Create java version for core/src/main/scala/kafka/server/BrokerMetadataCheckpoint.scala - Update LogConfig with new constructor to handle nodeId,

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #14099: KAFKA-14702: Extend server side assignor to support rack aware replica placement

rreddy-22 commented on code in PR #14099: URL: https://github.com/apache/kafka/pull/14099#discussion_r1275444245 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/consumer/TargetAssignmentBuilderTest.java: ## @@ -624,8 +745,27 @@ public void

[GitHub] [kafka] jolshan commented on a diff in pull request #14067: KAFKA-14499: [3/N] Implement OffsetCommit API

jolshan commented on code in PR #14067: URL: https://github.com/apache/kafka/pull/14067#discussion_r1275444136 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetMetadataManager.java: ## @@ -0,0 +1,454 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #14099: KAFKA-14702: Extend server side assignor to support rack aware replica placement

rreddy-22 commented on code in PR #14099: URL: https://github.com/apache/kafka/pull/14099#discussion_r1275362470 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/consumer/TargetAssignmentBuilderTest.java: ## @@ -222,8 +231,25 @@ public void

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #14099: KAFKA-14702: Extend server side assignor to support rack aware replica placement

rreddy-22 commented on code in PR #14099: URL: https://github.com/apache/kafka/pull/14099#discussion_r1275362470 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/consumer/TargetAssignmentBuilderTest.java: ## @@ -222,8 +231,25 @@ public void

[GitHub] [kafka] dajac commented on a diff in pull request #14067: KAFKA-14499: [3/N] Implement OffsetCommit API

dajac commented on code in PR #14067: URL: https://github.com/apache/kafka/pull/14067#discussion_r1275411706 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetMetadataManager.java: ## @@ -0,0 +1,454 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [kafka] jeffkbkim commented on a diff in pull request #14067: KAFKA-14499: [3/N] Implement OffsetCommit API

jeffkbkim commented on code in PR #14067: URL: https://github.com/apache/kafka/pull/14067#discussion_r1275397334 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetMetadataManager.java: ## @@ -0,0 +1,384 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] jeffkbkim commented on a diff in pull request #14067: KAFKA-14499: [3/N] Implement OffsetCommit API

jeffkbkim commented on code in PR #14067: URL: https://github.com/apache/kafka/pull/14067#discussion_r1275396220 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetMetadataManager.java: ## @@ -0,0 +1,454 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] mumrah commented on a diff in pull request #13643: KAFKA-15213: provide the exact offset to QuorumController.replay

mumrah commented on code in PR #13643: URL: https://github.com/apache/kafka/pull/13643#discussion_r1275381984 ## raft/src/main/java/org/apache/kafka/raft/RaftClient.java: ## @@ -172,15 +173,17 @@ default void beginShutdown() {} * uncommitted entries after observing an

[GitHub] [kafka] dajac commented on a diff in pull request #14067: KAFKA-14499: [3/N] Implement OffsetCommit API

dajac commented on code in PR #14067: URL: https://github.com/apache/kafka/pull/14067#discussion_r1275376886 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroup.java: ## @@ -497,6 +499,30 @@ public DeadlineAndEpoch

[GitHub] [kafka] dajac commented on a diff in pull request #14067: KAFKA-14499: [3/N] Implement OffsetCommit API

dajac commented on code in PR #14067: URL: https://github.com/apache/kafka/pull/14067#discussion_r1275376592 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/OffsetMetadataManagerTest.java: ## @@ -537,6 +554,55 @@ public void

[GitHub] [kafka] dajac commented on a diff in pull request #14067: KAFKA-14499: [3/N] Implement OffsetCommit API

dajac commented on code in PR #14067: URL: https://github.com/apache/kafka/pull/14067#discussion_r1275371089 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetMetadataManager.java: ## @@ -0,0 +1,384 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [kafka] dajac commented on a diff in pull request #14067: KAFKA-14499: [3/N] Implement OffsetCommit API

dajac commented on code in PR #14067: URL: https://github.com/apache/kafka/pull/14067#discussion_r1275366606 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/generic/GenericGroup.java: ## @@ -738,6 +742,84 @@ public String generateMemberId(String clientId,

[GitHub] [kafka] dajac commented on a diff in pull request #14067: KAFKA-14499: [3/N] Implement OffsetCommit API

dajac commented on code in PR #14067: URL: https://github.com/apache/kafka/pull/14067#discussion_r1275365874 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetMetadataManager.java: ## @@ -0,0 +1,454 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #14099: KAFKA-14702: Extend server side assignor to support rack aware replica placement

rreddy-22 commented on code in PR #14099: URL: https://github.com/apache/kafka/pull/14099#discussion_r1275362470 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/consumer/TargetAssignmentBuilderTest.java: ## @@ -222,8 +231,25 @@ public void

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #14099: KAFKA-14702: Extend server side assignor to support rack aware replica placement

rreddy-22 commented on code in PR #14099: URL: https://github.com/apache/kafka/pull/14099#discussion_r1275362470 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/consumer/TargetAssignmentBuilderTest.java: ## @@ -222,8 +231,25 @@ public void

[jira] [Commented] (KAFKA-15259) Kafka Streams does not continue processing due to rollback despite ProductionExceptionHandlerResponse.CONTINUE if using execute_once

[ https://issues.apache.org/jira/browse/KAFKA-15259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17747630#comment-17747630 ] Matthias J. Sax commented on KAFKA-15259: - Thanks for opening this ticket. Given that you are

[jira] [Updated] (KAFKA-15257) Support interactive queries (IQv2) with versioned state store

[ https://issues.apache.org/jira/browse/KAFKA-15257?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-15257: Labels: kip (was: ) > Support interactive queries (IQv2) with versioned state store >

[jira] [Updated] (KAFKA-15257) Support interactive queries (IQv2) with versioned state store

[ https://issues.apache.org/jira/browse/KAFKA-15257?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-15257: Description: KIP-960:

[jira] [Updated] (KAFKA-15257) Support interactive queries (IQv2) with versioned state store

[ https://issues.apache.org/jira/browse/KAFKA-15257?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-15257: Component/s: streams > Support interactive queries (IQv2) with versioned state store >

[jira] [Updated] (KAFKA-15257) Support interactive queries (IQv2) with versioned state store

[ https://issues.apache.org/jira/browse/KAFKA-15257?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-15257: Issue Type: New Feature (was: Task) > Support interactive queries (IQv2) with versioned

[GitHub] [kafka] mjsax commented on pull request #14069: MINOR: Add 3.5.1 to system tests

mjsax commented on PR #14069: URL: https://github.com/apache/kafka/pull/14069#issuecomment-1652312533 > The 3.5.1 packages are not in https://s3-us-west-2.amazonaws.com/kafka-packages yet. You need someone from Confluent to upload them (they own the S3 bucket). Did this today. --

[GitHub] [kafka] jolshan commented on a diff in pull request #14067: KAFKA-14499: [3/N] Implement OffsetCommit API

jolshan commented on code in PR #14067: URL: https://github.com/apache/kafka/pull/14067#discussion_r1275352752 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetMetadataManager.java: ## @@ -0,0 +1,384 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] jolshan commented on a diff in pull request #14067: KAFKA-14499: [3/N] Implement OffsetCommit API

jolshan commented on code in PR #14067: URL: https://github.com/apache/kafka/pull/14067#discussion_r1275350025 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/OffsetMetadataManagerTest.java: ## @@ -537,6 +554,55 @@ public void

[GitHub] [kafka] jeffkbkim commented on a diff in pull request #14067: KAFKA-14499: [3/N] Implement OffsetCommit API

jeffkbkim commented on code in PR #14067: URL: https://github.com/apache/kafka/pull/14067#discussion_r1275347397 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetMetadataManager.java: ## @@ -0,0 +1,384 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #14099: KAFKA-14702: Extend server side assignor to support rack aware replica placement

rreddy-22 commented on code in PR #14099: URL: https://github.com/apache/kafka/pull/14099#discussion_r1275342001 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/consumer/TargetAssignmentBuilderTest.java: ## @@ -145,13 +147,13 @@ public

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #14099: KAFKA-14702: Extend server side assignor to support rack aware replica placement

rreddy-22 commented on code in PR #14099: URL: https://github.com/apache/kafka/pull/14099#discussion_r1275342001 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/consumer/TargetAssignmentBuilderTest.java: ## @@ -145,13 +147,13 @@ public

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #14099: KAFKA-14702: Extend server side assignor to support rack aware replica placement

rreddy-22 commented on code in PR #14099: URL: https://github.com/apache/kafka/pull/14099#discussion_r1275337959 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroupTest.java: ## @@ -417,19 +417,23 @@ public void

[GitHub] [kafka] jolshan commented on a diff in pull request #14067: KAFKA-14499: [3/N] Implement OffsetCommit API

jolshan commented on code in PR #14067: URL: https://github.com/apache/kafka/pull/14067#discussion_r1275334511 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/OffsetMetadataManagerTest.java: ## @@ -0,0 +1,1113 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] jolshan commented on a diff in pull request #14067: KAFKA-14499: [3/N] Implement OffsetCommit API

jolshan commented on code in PR #14067: URL: https://github.com/apache/kafka/pull/14067#discussion_r1275333908 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/generic/GenericGroup.java: ## @@ -738,6 +742,84 @@ public String generateMemberId(String

[GitHub] [kafka] jolshan commented on a diff in pull request #14067: KAFKA-14499: [3/N] Implement OffsetCommit API

jolshan commented on code in PR #14067: URL: https://github.com/apache/kafka/pull/14067#discussion_r1275332469 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroup.java: ## @@ -497,6 +499,30 @@ public DeadlineAndEpoch

[GitHub] [kafka] jeffkbkim commented on a diff in pull request #14067: KAFKA-14499: [3/N] Implement OffsetCommit API

jeffkbkim commented on code in PR #14067: URL: https://github.com/apache/kafka/pull/14067#discussion_r1275329676 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetMetadataManager.java: ## @@ -0,0 +1,454 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] jolshan commented on a diff in pull request #14067: KAFKA-14499: [3/N] Implement OffsetCommit API

jolshan commented on code in PR #14067: URL: https://github.com/apache/kafka/pull/14067#discussion_r1275328506 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetAndMetadata.java: ## @@ -114,12 +116,29 @@ public static OffsetAndMetadata fromRecord(

[GitHub] [kafka] jolshan commented on a diff in pull request #14067: KAFKA-14499: [3/N] Implement OffsetCommit API

jolshan commented on code in PR #14067: URL: https://github.com/apache/kafka/pull/14067#discussion_r1275322523 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetMetadataManager.java: ## @@ -0,0 +1,454 @@ +/* + * Licensed to the Apache Software

[jira] [Resolved] (KAFKA-15235) No test coverage reports for Java due to settings for Jacoco being incompatible with Gradle 8.x

[ https://issues.apache.org/jira/browse/KAFKA-15235?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Divij Vaidya resolved KAFKA-15235. -- Resolution: Fixed > No test coverage reports for Java due to settings for Jacoco being >

[jira] [Commented] (KAFKA-15235) No test coverage reports for Java due to settings for Jacoco being incompatible with Gradle 8.x

[ https://issues.apache.org/jira/browse/KAFKA-15235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17747615#comment-17747615 ] Divij Vaidya commented on KAFKA-15235: -- I have backported this to 3.5 branch as well. I have also

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #14099: KAFKA-14702: Extend server side assignor to support rack aware replica placement

rreddy-22 commented on code in PR #14099: URL: https://github.com/apache/kafka/pull/14099#discussion_r1275306576 ## checkstyle/suppressions.xml: ## @@ -321,13 +321,13 @@ + - Review Comment: sorry I did move it, when I double checked in the

[jira] [Updated] (KAFKA-15235) No test coverage reports for Java due to settings for Jacoco being incompatible with Gradle 8.x

[ https://issues.apache.org/jira/browse/KAFKA-15235?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Divij Vaidya updated KAFKA-15235: - Fix Version/s: 3.6.0 3.5.2 > No test coverage reports for Java due to

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #14099: KAFKA-14702: Extend server side assignor to support rack aware replica placement

rreddy-22 commented on code in PR #14099: URL: https://github.com/apache/kafka/pull/14099#discussion_r1275307169 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/RecordHelpers.java: ## @@ -131,13 +131,24 @@ public static Record

[GitHub] [kafka] divijvaidya merged pull request #14075: KAFKA-15235: No test coverage reports for Java due to settings for Jacoco being incompatible with Gradle 8.x

divijvaidya merged PR #14075: URL: https://github.com/apache/kafka/pull/14075 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #14099: KAFKA-14702: Extend server side assignor to support rack aware replica placement

rreddy-22 commented on code in PR #14099: URL: https://github.com/apache/kafka/pull/14099#discussion_r1275306576 ## checkstyle/suppressions.xml: ## @@ -321,13 +321,13 @@ + - Review Comment: sorry I did remove it, when I double checked in

[GitHub] [kafka] divijvaidya commented on pull request #14075: KAFKA-15235: No test coverage reports for Java due to settings for Jacoco being incompatible with Gradle 8.x

divijvaidya commented on PR #14075: URL: https://github.com/apache/kafka/pull/14075#issuecomment-1652253193 Test failures are not related. Merging this one. Nice catch @bmscomp! I am surprised that this wasn't caught earlier. I will also backport this to 3.5. -- This is an automated

[GitHub] [kafka] ex172000 commented on a diff in pull request #14076: MINOR: Use Awaitility for waiting in test

ex172000 commented on code in PR #14076: URL: https://github.com/apache/kafka/pull/14076#discussion_r1275295110 ## gradle/dependencies.gradle: ## @@ -164,6 +165,7 @@ libs += [ apachedsMavibotPartition:

[GitHub] [kafka] divijvaidya commented on pull request #14104: Tiered storage | Segment with corrupted index should not be uploaded to remote storage

divijvaidya commented on PR #14104: URL: https://github.com/apache/kafka/pull/14104#issuecomment-1652239984 @Nickstery please create a JIRA and use the format : PR description as the title of this PR. You can see such information at

[GitHub] [kafka] mjsax opened a new pull request, #14105: MINOR: improve logging for FK-join

mjsax opened a new pull request, #14105: URL: https://github.com/apache/kafka/pull/14105 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of testing

[GitHub] [kafka] divijvaidya commented on a diff in pull request #14076: MINOR: Use Awaitility for waiting in test

divijvaidya commented on code in PR #14076: URL: https://github.com/apache/kafka/pull/14076#discussion_r1275292654 ## gradle/dependencies.gradle: ## @@ -164,6 +165,7 @@ libs += [ apachedsMavibotPartition:

[GitHub] [kafka] jolshan commented on pull request #14090: KAFKA-14048; CoordinatorContext should be protected by a lock

jolshan commented on PR #14090: URL: https://github.com/apache/kafka/pull/14090#issuecomment-1652229967 Can we try to add a test for the locking and/or the transition from failed state? -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [kafka] divijvaidya commented on pull request #14094: KAFKA-15243: Desanitizing(AKA: decoding) User before listing them

divijvaidya commented on PR #14094: URL: https://github.com/apache/kafka/pull/14094#issuecomment-1652221358 @omkreddy are you planning to back-port this to 3.5 and 3.4? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [kafka] divijvaidya commented on a diff in pull request #14049: KAFKA-14038: Optimise calculation of size for log in remote tier

divijvaidya commented on code in PR #14049: URL: https://github.com/apache/kafka/pull/14049#discussion_r1275269942 ## storage/src/test/java/org/apache/kafka/server/log/remote/metadata/storage/TopicBasedRemoteLogMetadataManagerTest.java: ## @@ -168,4 +169,64 @@ private void

[GitHub] [kafka] divijvaidya merged pull request #14098: MINOR: Upgrade version of gradle-versions-plugin to 0.47.0

divijvaidya merged PR #14098: URL: https://github.com/apache/kafka/pull/14098 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] divijvaidya commented on pull request #14098: MINOR: Upgrade version of gradle-versions-plugin to 0.47.0

divijvaidya commented on PR #14098: URL: https://github.com/apache/kafka/pull/14098#issuecomment-1652201778 Unrelated test failures: ``` [Build / JDK 17 and Scala 2.13 /

[GitHub] [kafka] divijvaidya commented on a diff in pull request #14104: Tiered storage | Segment with corrupted index should not be uploaded to remote storage

divijvaidya commented on code in PR #14104: URL: https://github.com/apache/kafka/pull/14104#discussion_r1275258903 ## core/src/test/java/kafka/log/remote/RemoteLogManagerTest.java: ## @@ -558,6 +618,38 @@ void testCopyLogSegmentsToRemoteShouldNotCopySegmentForFollower() throws

[GitHub] [kafka] gharris1727 commented on a diff in pull request #14089: KAFKA-15244: Remove PluginType.from(Class)

gharris1727 commented on code in PR #14089: URL: https://github.com/apache/kafka/pull/14089#discussion_r1275252571 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/isolation/PluginDesc.java: ## @@ -110,11 +110,18 @@ public int hashCode() { }

[GitHub] [kafka] mumrah merged pull request #14028: KAFKA-15196 Additional ZK migration metrics

mumrah merged PR #14028: URL: https://github.com/apache/kafka/pull/14028 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] Nickstery opened a new pull request, #14104: Tiered storage | Segment with corrupted index should not be uploaded

Nickstery opened a new pull request, #14104: URL: https://github.com/apache/kafka/pull/14104 It is possible to get corrupted index hitting that data disk full issue. There is an existing function which can check segment for index corruption `sanityCheck()`. So before copying new segment

[GitHub] [kafka] dajac commented on a diff in pull request #14099: KAFKA-14702: Extend server side assignor to support rack aware replica placement

dajac commented on code in PR #14099: URL: https://github.com/apache/kafka/pull/14099#discussion_r1275243699 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/RecordHelpers.java: ## @@ -131,13 +131,24 @@ public static Record

[GitHub] [kafka] dajac commented on a diff in pull request #14099: KAFKA-14702: Extend server side assignor to support rack aware replica placement

dajac commented on code in PR #14099: URL: https://github.com/apache/kafka/pull/14099#discussion_r1275242714 ## checkstyle/suppressions.xml: ## @@ -321,13 +321,13 @@ + - Review Comment: Hum.. I asked in the other PR if the change was

[GitHub] [kafka] philipnee commented on pull request #13920: KAFKA-15106 fix AbstractStickyAssignor isBalanced predict

philipnee commented on PR #13920: URL: https://github.com/apache/kafka/pull/13920#issuecomment-1652170353 @flashmouse - There are 108 test failures. Some of those are "Existing Failures". Could you look into it? I think it might not be related to this PR because @kirktrue has had a

[GitHub] [kafka] philipnee commented on pull request #13920: KAFKA-15106 fix AbstractStickyAssignor isBalanced predict

philipnee commented on PR #13920: URL: https://github.com/apache/kafka/pull/13920#issuecomment-1652167809 Thanks, kindly ask @dajac to review this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [kafka] philipnee commented on a diff in pull request #13920: KAFKA-15106 fix AbstractStickyAssignor isBalanced predict

philipnee commented on code in PR #13920: URL: https://github.com/apache/kafka/pull/13920#discussion_r1275235329 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignorTest.java: ## @@ -724,6 +725,90 @@ public void

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #14099: KAFKA-14702: Extend server side assignor to support rack aware replica placement

rreddy-22 commented on code in PR #14099: URL: https://github.com/apache/kafka/pull/14099#discussion_r1275226238 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/RecordHelpers.java: ## @@ -131,13 +131,24 @@ public static Record

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #14099: KAFKA-14702: Extend server side assignor to support rack aware replica placement

rreddy-22 commented on code in PR #14099: URL: https://github.com/apache/kafka/pull/14099#discussion_r1275225268 ## checkstyle/suppressions.xml: ## @@ -321,13 +321,13 @@ + - Review Comment: You had put a comment to remove it in the last PR

[GitHub] [kafka] gharris1727 commented on pull request #14092: KAFKA-15239: Fix system tests using producer performance service

gharris1727 commented on PR #14092: URL: https://github.com/apache/kafka/pull/14092#issuecomment-1652125644 > Can you explain better what you mean here? By "version mixing" I mean that artifacts from two different versions from different versions are present on the classpath at the

[GitHub] [kafka] fvaleri commented on pull request #13417: KAFKA-14585: Moving StorageTool from core to tools module

fvaleri commented on PR #13417: URL: https://github.com/apache/kafka/pull/13417#issuecomment-1652106480 @muralibasani the new PR should contain the work you already did with LogConfig, RawMetaProperties, etc. Note that we can't keep two versions of the same code without the risk of

[GitHub] [kafka] mjsax commented on pull request #13860: KAFKA-15093: Add 3.4 and 3.5 Streams upgrade system tests

mjsax commented on PR #13860: URL: https://github.com/apache/kafka/pull/13860#issuecomment-1652102807 With KIP-904 we changes some serialization format inside an internal repartition topic (cf

[GitHub] [kafka] CalvinConfluent commented on pull request #14053: KAFKA-15221; Fix the race between fetch requests from a rebooted follower.

CalvinConfluent commented on PR #14053: URL: https://github.com/apache/kafka/pull/14053#issuecomment-1652102209 @dajac @splett2 Let me know if you have further comments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [kafka] fvaleri commented on pull request #14092: KAFKA-15239: Fix system tests using producer performance service

fvaleri commented on PR #14092: URL: https://github.com/apache/kafka/pull/14092#issuecomment-1652091101 > if we loaded a 1.0.0 server-common class that depended on a class which was missing from DEV clients, I would expect that to fail. These changes are just for the

[GitHub] [kafka] yashmayya commented on pull request #14101: Source task stop call was added to force stopping execution.

yashmayya commented on PR #14101: URL: https://github.com/apache/kafka/pull/14101#issuecomment-1652085859 Adding to what Sagar said above - this whole machinery is intentional because there is a mechanism

[jira] [Created] (KAFKA-15259) Kafka Streams does not continue processing due to rollback despite ProductionExceptionHandlerResponse.CONTINUE if using execute_once

Tomonari Yamashita created KAFKA-15259: -- Summary: Kafka Streams does not continue processing due to rollback despite ProductionExceptionHandlerResponse.CONTINUE if using execute_once Key: KAFKA-15259 URL:

[GitHub] [kafka] C0urante commented on a diff in pull request #14089: KAFKA-15244: Remove PluginType.from(Class)

C0urante commented on code in PR #14089: URL: https://github.com/apache/kafka/pull/14089#discussion_r1275115110 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/isolation/PluginDesc.java: ## @@ -110,11 +110,18 @@ public int hashCode() { } @Override

  1   2   3   >