ivanyu commented on PR #13984:
URL: https://github.com/apache/kafka/pull/13984#issuecomment-1663331558
Thank you @showuon for the review!
Please let me know if I need to squash the commits.
--
This is an automated message from the Apache Git Service.
To respond to the message, please
lihaosky commented on code in PR #14139:
URL: https://github.com/apache/kafka/pull/14139#discussion_r1282664432
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/TaskAssignor.java:
##
@@ -16,18 +16,29 @@
*/
package
showuon commented on code in PR #13984:
URL: https://github.com/apache/kafka/pull/13984#discussion_r1282649360
##
core/src/main/java/kafka/log/remote/CustomMetadataSizeLimitExceededException.java:
##
@@ -0,0 +1,20 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
ableegoldman commented on code in PR #14139:
URL: https://github.com/apache/kafka/pull/14139#discussion_r1282604132
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/RackAwareTaskAssignor.java:
##
@@ -43,26 +51,39 @@
import
github-actions[bot] commented on PR #13674:
URL: https://github.com/apache/kafka/pull/13674#issuecomment-1663242081
This PR is being marked as stale since it has not had any activity in 90
days. If you would like to keep this PR alive, please ask a committer for
review. If the PR has
ableegoldman commented on code in PR #14139:
URL: https://github.com/apache/kafka/pull/14139#discussion_r1282600984
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/TaskAssignor.java:
##
@@ -16,18 +16,29 @@
*/
package
flashmouse commented on PR #13920:
URL: https://github.com/apache/kafka/pull/13920#issuecomment-1663210404
> > I hadn't changed the logic, it is still a slow function. whether execute
performReassignments is checked by isBalanced, but it is not effective
previously and this pr just fix
philipnee commented on PR #14123:
URL: https://github.com/apache/kafka/pull/14123#issuecomment-1663201841
There seems to be some weirdness to the build - jdk 17 was timedout or
something. Retriggered the build...
--
This is an automated message from the Apache Git Service.
To respond to
lihaosky commented on code in PR #14108:
URL: https://github.com/apache/kafka/pull/14108#discussion_r1282572143
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/assignment/RackAwareTaskAssignorTest.java:
##
@@ -715,23 +1087,49 @@ private Map>>
mjsax merged PR #14108:
URL: https://github.com/apache/kafka/pull/14108
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
mjsax commented on code in PR #14108:
URL: https://github.com/apache/kafka/pull/14108#discussion_r1282569306
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/assignment/RackAwareTaskAssignorTest.java:
##
@@ -715,23 +1087,49 @@ private Map>>
mjsax commented on code in PR #14108:
URL: https://github.com/apache/kafka/pull/14108#discussion_r1282569306
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/assignment/RackAwareTaskAssignorTest.java:
##
@@ -715,23 +1087,49 @@ private Map>>
mjsax commented on code in PR #14108:
URL: https://github.com/apache/kafka/pull/14108#discussion_r1282568706
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/assignment/RackAwareTaskAssignorTest.java:
##
@@ -715,23 +1087,49 @@ private Map>>
mjsax commented on code in PR #14108:
URL: https://github.com/apache/kafka/pull/14108#discussion_r1282562934
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/assignment/RackAwareTaskAssignorTest.java:
##
@@ -678,18 +838,230 @@ public void
mjsax commented on code in PR #14108:
URL: https://github.com/apache/kafka/pull/14108#discussion_r1282562934
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/assignment/RackAwareTaskAssignorTest.java:
##
@@ -678,18 +838,230 @@ public void
mjsax commented on code in PR #14108:
URL: https://github.com/apache/kafka/pull/14108#discussion_r1282562934
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/assignment/RackAwareTaskAssignorTest.java:
##
@@ -678,18 +838,230 @@ public void
[
https://issues.apache.org/jira/browse/KAFKA-12829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17750508#comment-17750508
]
Junyao Huang commented on KAFKA-12829:
--
Thanks [~mjsax] for clarification!
> Remove Deprecated
[
https://issues.apache.org/jira/browse/KAFKA-15116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17750506#comment-17750506
]
Matthias J. Sax commented on KAFKA-15116:
-
Are you saying you are using a custom store? For this
pprovenzano commented on code in PR #14083:
URL: https://github.com/apache/kafka/pull/14083#discussion_r1282518474
##
core/src/main/scala/kafka/server/DelegationTokenManager.scala:
##
@@ -165,10 +112,11 @@ object DelegationTokenManager {
class DelegationTokenManager(val
pprovenzano commented on code in PR #14083:
URL: https://github.com/apache/kafka/pull/14083#discussion_r1282514451
##
metadata/src/main/java/org/apache/kafka/controller/DelegationTokenControlManager.java:
##
@@ -0,0 +1,359 @@
+/*
+ * Licensed to the Apache Software Foundation
[
https://issues.apache.org/jira/browse/KAFKA-15297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17750504#comment-17750504
]
Matthias J. Sax commented on KAFKA-15297:
-
The ticket description contains an example to
[
https://issues.apache.org/jira/browse/KAFKA-12829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17750503#comment-17750503
]
Matthias J. Sax commented on KAFKA-12829:
-
It's actually unclear when 4.0 will come along, so it
[
https://issues.apache.org/jira/browse/KAFKA-15299?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Igor Fomenko updated KAFKA-15299:
-
Description:
KIP-955:
ex172000 commented on PR #14110:
URL: https://github.com/apache/kafka/pull/14110#issuecomment-1663074232
Hi @divijvaidya can you take another look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
[
https://issues.apache.org/jira/browse/KAFKA-15297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17750495#comment-17750495
]
A. Sophie Blee-Goldman commented on KAFKA-15297:
Were you able to (re)produce this
[
https://issues.apache.org/jira/browse/KAFKA-12829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17750494#comment-17750494
]
Junyao Huang commented on KAFKA-12829:
--
Yes, [~guozhang] ,
I am willing to raise a PR for this
pprovenzano commented on code in PR #14083:
URL: https://github.com/apache/kafka/pull/14083#discussion_r1282479785
##
core/src/main/scala/kafka/server/ControllerApis.scala:
##
@@ -842,6 +847,75 @@ class ControllerApis(val requestChannel: RequestChannel,
}
}
+ def
[
https://issues.apache.org/jira/browse/KAFKA-12317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17750491#comment-17750491
]
Guozhang Wang commented on KAFKA-12317:
---
Thanks [~aki] ! Will take a look soon.
> Relax non-null
[
https://issues.apache.org/jira/browse/KAFKA-12829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17750490#comment-17750490
]
Guozhang Wang commented on KAFKA-12829:
---
[~pegasas] Your comment seems deleted, are you still
guozhangwang commented on PR #13920:
URL: https://github.com/apache/kafka/pull/13920#issuecomment-1663038140
> I hadn't changed the logic, it is still a slow function. whether execute
performReassignments is checked by isBalanced, but it is not effective
previously and this pr just fix
elkkhan commented on PR #14077:
URL: https://github.com/apache/kafka/pull/14077#issuecomment-1663002964
> @elkkhan I think it was mentioned on the [Jira
ticket](https://issues.apache.org/jira/browse/KAFKA-14112) that a KIP is
required for new metrics; have you published a KIP for this
elkkhan commented on code in PR #14077:
URL: https://github.com/apache/kafka/pull/14077#discussion_r1282447173
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/AbstractWorkerSourceTask.java:
##
@@ -108,7 +108,7 @@ public abstract class AbstractWorkerSourceTask
jsancio commented on PR #14141:
URL: https://github.com/apache/kafka/pull/14141#issuecomment-1662978648
The two tests added in the PR fail against trunk.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
jsancio opened a new pull request, #14141:
URL: https://github.com/apache/kafka/pull/14141
The KRaft client uses an expiration service to complete FETCH requests that
have timed out. This expiration service uses a different thread from the KRaft
polling thread. This means that it is unsafe
gharris1727 commented on PR #14064:
URL: https://github.com/apache/kafka/pull/14064#issuecomment-1662952817
Okay I have a potential fix: we can make the URL unique by inserting `.` in
the path.
It works with the test case you provided, and even this one:
```
cd
mumrah opened a new pull request, #14140:
URL: https://github.com/apache/kafka/pull/14140
Allows DeferredEventQueue to complete events for "unstable" offsets. This
will be used for metadata transactions where the committed offset is
increasing, but the stable offset is not.
For
omkreddy commented on code in PR #14130:
URL: https://github.com/apache/kafka/pull/14130#discussion_r1282124322
##
clients/src/main/java/org/apache/kafka/common/security/ssl/DefaultSslEngineFactory.java:
##
@@ -16,47 +16,48 @@
*/
package org.apache.kafka.common.security.ssl;
omkreddy commented on code in PR #14130:
URL: https://github.com/apache/kafka/pull/14130#discussion_r1282124322
##
clients/src/main/java/org/apache/kafka/common/security/ssl/DefaultSslEngineFactory.java:
##
@@ -16,47 +16,48 @@
*/
package org.apache.kafka.common.security.ssl;
gharris1727 commented on code in PR #14064:
URL: https://github.com/apache/kafka/pull/14064#discussion_r1282351442
##
tools/src/main/java/org/apache/kafka/tools/ConnectPluginPath.java:
##
@@ -0,0 +1,498 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
jeffkbkim commented on code in PR #14124:
URL: https://github.com/apache/kafka/pull/14124#discussion_r1282327275
##
clients/src/main/resources/common/message/ConsumerGroupDescribeResponse.json:
##
@@ -0,0 +1,98 @@
+// Licensed to the Apache Software Foundation (ASF) under one
jeffkbkim commented on code in PR #14124:
URL: https://github.com/apache/kafka/pull/14124#discussion_r1282326175
##
clients/src/main/resources/common/message/ConsumerGroupDescribeResponse.json:
##
@@ -0,0 +1,98 @@
+// Licensed to the Apache Software Foundation (ASF) under one
ruslankrivoshein commented on PR #13562:
URL: https://github.com/apache/kafka/pull/13562#issuecomment-1662850171
@dengziming could you tell me, what is a good approach for rebase here? When
I do this, I face conflicts. After resolving I do push, and there are dozens of
commits in PR, so I
junrao commented on code in PR #14111:
URL: https://github.com/apache/kafka/pull/14111#discussion_r1282312134
##
clients/src/main/java/org/apache/kafka/clients/producer/internals/RecordAccumulator.java:
##
@@ -73,6 +75,7 @@ public class RecordAccumulator {
private final
[
https://issues.apache.org/jira/browse/KAFKA-15299?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-15299:
Labels: kip (was: )
> Support left stream-table join on foreign key
>
gharris1727 commented on PR #14064:
URL: https://github.com/apache/kafka/pull/14064#issuecomment-1662806844
> As far as the epilogue output goes, I wonder if we're getting a little too
detailed here... will users get much out of knowing the number of total
locations/compatible locations?
C0urante commented on code in PR #14064:
URL: https://github.com/apache/kafka/pull/14064#discussion_r1281978798
##
tools/src/main/java/org/apache/kafka/tools/ConnectPluginPath.java:
##
@@ -0,0 +1,498 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
[
https://issues.apache.org/jira/browse/KAFKA-15291?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Greg Harris updated KAFKA-15291:
Summary: Implement Versioned interfaces in common Connect plugins (was:
Implemented Versioned
[
https://issues.apache.org/jira/browse/KAFKA-13562?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Greg Harris resolved KAFKA-13562.
-
Fix Version/s: 3.3.3
3.4.1
3.5.0
Resolution: Fixed
[
https://issues.apache.org/jira/browse/KAFKA-8597?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Greg Harris resolved KAFKA-8597.
Fix Version/s: 2.6.0
Resolution: Fixed
> Give access to the Dead Letter Queue APIs to Kafka
[
https://issues.apache.org/jira/browse/KAFKA-8754?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Greg Harris resolved KAFKA-8754.
Fix Version/s: 3.2.0
Resolution: Fixed
> Connect API: Expose the list of available
Satish Duggana created KAFKA-15300:
--
Summary: Include remotelog size in complete log size and also add
local log size and remote log size separately in kafka-log-dirs tool.
Key: KAFKA-15300
URL:
[
https://issues.apache.org/jira/browse/KAFKA-15102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17750371#comment-17750371
]
Omnia Ibrahim edited comment on KAFKA-15102 at 8/2/23 3:06 PM:
---
The KIP
[
https://issues.apache.org/jira/browse/KAFKA-15102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17750371#comment-17750371
]
Omnia Ibrahim edited comment on KAFKA-15102 at 8/2/23 3:06 PM:
---
The KIP is
[
https://issues.apache.org/jira/browse/KAFKA-15102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17750371#comment-17750371
]
Omnia Ibrahim commented on KAFKA-15102:
---
The KIP is accepted and the PR is ready
> Mirror Maker 2
[
https://issues.apache.org/jira/browse/KAFKA-15298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17750357#comment-17750357
]
Kamal Chandraprakash commented on KAFKA-15298:
--
[~christo_lolov]
Could you explain why
Igor Fomenko created KAFKA-15299:
Summary: Support left stream-table join on foreign key
Key: KAFKA-15299
URL: https://issues.apache.org/jira/browse/KAFKA-15299
Project: Kafka
Issue Type:
[
https://issues.apache.org/jira/browse/KAFKA-10339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17750338#comment-17750338
]
Chris Egerton commented on KAFKA-10339:
---
Now that KAFKA-6080 has been resolved with
[
https://issues.apache.org/jira/browse/KAFKA-15116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17750311#comment-17750311
]
David Gammon commented on KAFKA-15116:
--
# The store is storing everything from all partitions which
Christo Lolov created KAFKA-15298:
-
Summary: Disable DeleteRecords on Tiered Storage topics
Key: KAFKA-15298
URL: https://issues.apache.org/jira/browse/KAFKA-15298
Project: Kafka
Issue Type:
[
https://issues.apache.org/jira/browse/KAFKA-15298?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christo Lolov updated KAFKA-15298:
--
Labels: tiered-storage (was: )
> Disable DeleteRecords on Tiered Storage topics
>
[
https://issues.apache.org/jira/browse/KAFKA-15297?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bruno Cadonna updated KAFKA-15297:
--
Description:
The flush order of the state store caches in Kafka Streams might not correspond
[
https://issues.apache.org/jira/browse/KAFKA-15297?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bruno Cadonna updated KAFKA-15297:
--
Description:
The flush order of the state store caches in Kafka Streams might not correspond
[
https://issues.apache.org/jira/browse/KAFKA-15297?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bruno Cadonna updated KAFKA-15297:
--
Description:
The flush order of the state store caches in Kafka Streams might not correspond
[
https://issues.apache.org/jira/browse/KAFKA-15297?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bruno Cadonna updated KAFKA-15297:
--
Description:
The flush order of the state store caches in Kafka Streams might not correspond
Bruno Cadonna created KAFKA-15297:
-
Summary: Cache flush order might not be topological order
Key: KAFKA-15297
URL: https://issues.apache.org/jira/browse/KAFKA-15297
Project: Kafka
Issue
[
https://issues.apache.org/jira/browse/KAFKA-15297?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bruno Cadonna updated KAFKA-15297:
--
Attachment: minimal_example.png
> Cache flush order might not be topological order
>
satishd commented on code in PR #13561:
URL: https://github.com/apache/kafka/pull/13561#discussion_r1281844159
##
core/src/main/scala/kafka/log/UnifiedLog.scala:
##
@@ -945,13 +978,19 @@ class UnifiedLog(@volatile var logStartOffset: Long,
[
https://issues.apache.org/jira/browse/KAFKA-15154?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Divij Vaidya updated KAFKA-15154:
-
Component/s: metrics
> Potential bug: We don't acquire lock when reading checkQuotas
>
[
https://issues.apache.org/jira/browse/KAFKA-15058?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Divij Vaidya updated KAFKA-15058:
-
Component/s: metrics
> Improve the accuracy of Histogram in client metric
>
bmscomp commented on PR #14131:
URL: https://github.com/apache/kafka/pull/14131#issuecomment-1662023509
@divijvaidya I just made a rebase, wait to see the build results
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
ivanyu commented on code in PR #13984:
URL: https://github.com/apache/kafka/pull/13984#discussion_r1281763529
##
core/src/main/java/kafka/log/remote/RemoteLogManager.java:
##
@@ -621,10 +626,30 @@ private void copyLogSegment(UnifiedLog log, LogSegment
segment, long nextSegment
Sagar Rao created KAFKA-15296:
-
Summary: Allow committing offsets for Dropped records via SMTs
Key: KAFKA-15296
URL: https://issues.apache.org/jira/browse/KAFKA-15296
Project: Kafka
Issue Type:
divijvaidya commented on PR #14131:
URL: https://github.com/apache/kafka/pull/14131#issuecomment-1661996961
CI has a compilation error which is fixed by
https://github.com/apache/kafka/pull/14126. Please rebase from trunk and we can
start the CI run again.
--
This is an automated
clolov commented on code in PR #14135:
URL: https://github.com/apache/kafka/pull/14135#discussion_r1281724231
##
core/src/main/scala/kafka/server/KafkaConfig.scala:
##
@@ -1862,7 +1884,23 @@ class KafkaConfig private(doLog: Boolean, val props:
java.util.Map[_, _], dynami
[
https://issues.apache.org/jira/browse/KAFKA-15295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Divij Vaidya updated KAFKA-15295:
-
Fix Version/s: 3.6.0
> Add config validation when remote storage is enabled on a topic
>
divijvaidya commented on code in PR #13947:
URL: https://github.com/apache/kafka/pull/13947#discussion_r1252999633
##
core/src/main/scala/kafka/server/ReplicaManager.scala:
##
@@ -471,6 +472,9 @@ class ReplicaManager(val config: KafkaConfig,
case
divijvaidya commented on code in PR #13947:
URL: https://github.com/apache/kafka/pull/13947#discussion_r1252989860
##
core/src/main/java/kafka/log/remote/RemoteLogManager.java:
##
@@ -615,6 +661,9 @@ public void run() {
try {
Optional
fvaleri commented on PR #14121:
URL: https://github.com/apache/kafka/pull/14121#issuecomment-1661979478
@dajac are you good with these changes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
divijvaidya commented on code in PR #13947:
URL: https://github.com/apache/kafka/pull/13947#discussion_r1252976430
##
core/src/main/java/kafka/log/remote/RemoteLogManager.java:
##
@@ -556,6 +562,46 @@ public void copyLogSegmentsToRemote(UnifiedLog log) throws
kamalcph commented on PR #14116:
URL: https://github.com/apache/kafka/pull/14116#issuecomment-1661973903
> Hello and thank you for starting on this ! What is your plan when it
comes to reviewing this code - will you be splitting it into multiple pull
requests for individual
kamalcph commented on code in PR #14114:
URL: https://github.com/apache/kafka/pull/14114#discussion_r1281723208
##
storage/src/main/java/org/apache/kafka/storage/internals/log/LogConfig.java:
##
@@ -102,49 +102,14 @@ public String topicWarningMessage(String topicName) {
[
https://issues.apache.org/jira/browse/KAFKA-15295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kamal Chandraprakash updated KAFKA-15295:
-
Parent: KAFKA-7739
Issue Type: Sub-task (was: Task)
> Add config
Kamal Chandraprakash created KAFKA-15295:
Summary: Add config validation when remote storage is enabled on a
topic
Key: KAFKA-15295
URL: https://issues.apache.org/jira/browse/KAFKA-15295
divijvaidya commented on code in PR #14133:
URL: https://github.com/apache/kafka/pull/14133#discussion_r1281718684
##
storage/api/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteStorageMetrics.java:
##
@@ -0,0 +1,93 @@
+/*
+ * Licensed to the Apache Software
divijvaidya commented on code in PR #14114:
URL: https://github.com/apache/kafka/pull/14114#discussion_r1281717116
##
storage/src/main/java/org/apache/kafka/storage/internals/log/LogConfig.java:
##
@@ -102,49 +102,14 @@ public String topicWarningMessage(String topicName) {
clolov commented on PR #14116:
URL: https://github.com/apache/kafka/pull/14116#issuecomment-1661952445
Hello and thank you for starting on this ! What is your plan when it comes
to reviewing this code - will you be splitting it into multiple pull requests
for individual
clolov commented on code in PR #14116:
URL: https://github.com/apache/kafka/pull/14116#discussion_r1281706478
##
storage/src/test/java/integration/kafka/tiered/storage/actions/CreateTopicAction.java:
##
@@ -0,0 +1,74 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
kamalcph commented on code in PR #14114:
URL: https://github.com/apache/kafka/pull/14114#discussion_r1281701381
##
storage/src/main/java/org/apache/kafka/storage/internals/log/LogConfig.java:
##
@@ -102,49 +102,14 @@ public String topicWarningMessage(String topicName) {
ivanyu commented on code in PR #13984:
URL: https://github.com/apache/kafka/pull/13984#discussion_r1281701101
##
core/src/main/java/kafka/log/remote/CustomMetadataSizeLimitExceededException.java:
##
@@ -0,0 +1,20 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
OmniaGM commented on PR #13201:
URL: https://github.com/apache/kafka/pull/13201#issuecomment-1661932121
I have updated the PR to use #13158 and #13278. The test checks are failing
because of an unrelated class. However the `:tools:compileTestJava` is failing
because it doesn't like
showuon commented on code in PR #14133:
URL: https://github.com/apache/kafka/pull/14133#discussion_r1281679405
##
storage/api/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteStorageMetrics.java:
##
@@ -0,0 +1,93 @@
+/*
+ * Licensed to the Apache Software
showuon commented on code in PR #13561:
URL: https://github.com/apache/kafka/pull/13561#discussion_r1281657244
##
core/src/main/java/kafka/log/remote/RemoteLogManager.java:
##
@@ -667,11 +675,323 @@ public void run() {
}
}
+public void
satishd commented on code in PR #13561:
URL: https://github.com/apache/kafka/pull/13561#discussion_r1281672320
##
core/src/main/java/kafka/log/remote/RemoteLogManager.java:
##
@@ -618,6 +625,230 @@ public void run() {
}
}
+public void
ivanyu commented on code in PR #13984:
URL: https://github.com/apache/kafka/pull/13984#discussion_r1281661247
##
core/src/main/java/kafka/log/remote/RemoteLogManager.java:
##
@@ -621,10 +626,30 @@ private void copyLogSegment(UnifiedLog log, LogSegment
segment, long nextSegment
divijvaidya commented on code in PR #14133:
URL: https://github.com/apache/kafka/pull/14133#discussion_r1281642972
##
storage/api/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteStorageMetrics.java:
##
@@ -0,0 +1,93 @@
+/*
+ * Licensed to the Apache Software
ivanyu commented on code in PR #13984:
URL: https://github.com/apache/kafka/pull/13984#discussion_r1281646428
##
core/src/main/java/kafka/log/remote/RemoteLogManager.java:
##
@@ -572,6 +573,9 @@ public void copyLogSegmentsToRemote(UnifiedLog log) throws
InterruptedException
divijvaidya commented on code in PR #14114:
URL: https://github.com/apache/kafka/pull/14114#discussion_r1281624661
##
storage/src/main/java/org/apache/kafka/storage/internals/log/LogConfig.java:
##
@@ -102,49 +102,14 @@ public String topicWarningMessage(String topicName) {
ivanyu commented on code in PR #13984:
URL: https://github.com/apache/kafka/pull/13984#discussion_r1281602105
##
storage/api/src/test/java/org/apache/kafka/server/log/remote/storage/RemoteLogSegmentMetadataTest.java:
##
@@ -0,0 +1,67 @@
+/*
+ * Licensed to the Apache Software
ivanyu commented on code in PR #13984:
URL: https://github.com/apache/kafka/pull/13984#discussion_r1281591602
##
core/src/test/java/kafka/log/remote/RemoteLogManagerTest.java:
##
@@ -239,96 +240,186 @@ void testStartup() {
assertEquals(logDir,
[
https://issues.apache.org/jira/browse/KAFKA-15267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17750188#comment-17750188
]
Christo Lolov commented on KAFKA-15267:
---
Yup, you are correct. 4.1 can be the first deliverable,
1 - 100 of 118 matches
Mail list logo
