kamalcph commented on code in PR #14151:
URL: https://github.com/apache/kafka/pull/14151#discussion_r1284973824
##
storage/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteLogManagerConfig.java:
##
@@ -134,6 +134,8 @@ public final class RemoteLogManagerConfig {
[
https://issues.apache.org/jira/browse/KAFKA-12890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17751269#comment-17751269
]
Yang commented on KAFKA-12890:
--
Hi [~dajac] I know this issue and PR have been closed for a while, just
[
https://issues.apache.org/jira/browse/KAFKA-15309?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-15309:
Description:
The producer collects multiple records into batches, and a single record
[
https://issues.apache.org/jira/browse/KAFKA-15309?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-15309:
Description:
The producer collects multiple records into batches, and a single record
[
https://issues.apache.org/jira/browse/KAFKA-15309?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-15309:
Description:
The producer collects multiple records into batches, and a single record
[
https://issues.apache.org/jira/browse/KAFKA-15309?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-15309:
Description:
The producer batches up multiple records into batches, and a single record
[
https://issues.apache.org/jira/browse/KAFKA-15259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17751267#comment-17751267
]
Matthias J. Sax commented on KAFKA-15259:
-
I did sync up with [~cegerton] who worked on
Matthias J. Sax created KAFKA-15309:
---
Summary: Add custom error handler to Producer
Key: KAFKA-15309
URL: https://issues.apache.org/jira/browse/KAFKA-15309
Project: Kafka
Issue Type: New
showuon merged PR #14133:
URL: https://github.com/apache/kafka/pull/14133
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
showuon commented on PR #14133:
URL: https://github.com/apache/kafka/pull/14133#issuecomment-1666390423
Failed tests are unrelated:
```
Build / JDK 8 and Scala 2.12 /
showuon commented on PR #14151:
URL: https://github.com/apache/kafka/pull/14151#issuecomment-1666390279
> Yeah, okay, this pull request makes sense to me. To summarise, you are
saying that configurations starting with `remote.log.metadata` need to be
passed to implementations of the
[
https://issues.apache.org/jira/browse/KAFKA-15259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17751263#comment-17751263
]
Matthias J. Sax commented on KAFKA-15259:
-
Thanks for digging into it – that's a good fine – I
mjsax merged PR #14105:
URL: https://github.com/apache/kafka/pull/14105
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/KAFKA-15202?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Greg Harris reassigned KAFKA-15202:
---
Assignee: Greg Harris
> MM2 OffsetSyncStore clears too many syncs when sync spacing is
gharris1727 opened a new pull request, #14156:
URL: https://github.com/apache/kafka/pull/14156
The new OffsetSyncStore historical translation cache clears more syncs than
necessary when the gap between syncs is variable. This is a problem with the
replacement promotion logic, which only
[
https://issues.apache.org/jira/browse/KAFKA-15308?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-15308:
Affects Version/s: (was: 3.4.0)
(was: 3.5.0)
> Wipe Stores
Colt McNealy created KAFKA-15308:
Summary: Wipe Stores upon OffsetOutOfRangeException in ALOS
Key: KAFKA-15308
URL: https://issues.apache.org/jira/browse/KAFKA-15308
Project: Kafka
Issue
Matthias J. Sax created KAFKA-15307:
---
Summary: Kafka Streams configuration docs outdate
Key: KAFKA-15307
URL: https://issues.apache.org/jira/browse/KAFKA-15307
Project: Kafka
Issue Type:
mehbey commented on PR #14135:
URL: https://github.com/apache/kafka/pull/14135#issuecomment-1666331731
Updated PR to address comments
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
mehbey commented on code in PR #14135:
URL: https://github.com/apache/kafka/pull/14135#discussion_r1284932829
##
core/src/test/scala/integration/kafka/server/DynamicBrokerReconfigurationTest.scala:
##
@@ -642,7 +642,7 @@ class DynamicBrokerReconfigurationTest extends
mjsax commented on code in PR #14150:
URL: https://github.com/apache/kafka/pull/14150#discussion_r1284932353
##
streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java:
##
@@ -890,6 +914,22 @@ public class StreamsConfig extends AbstractConfig {
mjsax commented on PR #14155:
URL: https://github.com/apache/kafka/pull/14155#issuecomment-1666311777
`kafka-site.git` PR: https://github.com/apache/kafka-site/pull/536
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
[
https://issues.apache.org/jira/browse/KAFKA-15267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17751241#comment-17751241
]
Satish Duggana commented on KAFKA-15267:
Option 4.1 is the option suggested in
lihaosky commented on code in PR #14139:
URL: https://github.com/apache/kafka/pull/14139#discussion_r1284914061
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/StickyTaskAssignor.java:
##
@@ -57,6 +57,7 @@ public StickyTaskAssignor() {
lihaosky commented on code in PR #14150:
URL: https://github.com/apache/kafka/pull/14150#discussion_r1284910264
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/AssignorConfiguration.java:
##
@@ -267,25 +267,46 @@ public static class
[
https://issues.apache.org/jira/browse/KAFKA-15302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17751236#comment-17751236
]
Matthias J. Sax commented on KAFKA-15302:
-
Thanks for reporting this issue. – When you call
lihaosky commented on code in PR #14139:
URL: https://github.com/apache/kafka/pull/14139#discussion_r1284910181
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/HighAvailabilityTaskAssignor.java:
##
@@ -43,21 +43,27 @@
public class
AndrewJSchofield commented on code in PR #14111:
URL: https://github.com/apache/kafka/pull/14111#discussion_r1284873983
##
clients/src/main/java/org/apache/kafka/clients/producer/internals/RecordAccumulator.java:
##
@@ -701,7 +713,9 @@ private long partitionReady(Cluster
mjsax commented on code in PR #14139:
URL: https://github.com/apache/kafka/pull/14139#discussion_r1284866806
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/HighAvailabilityTaskAssignor.java:
##
@@ -43,21 +43,27 @@
public class
mjsax commented on code in PR #14150:
URL: https://github.com/apache/kafka/pull/14150#discussion_r1284793025
##
streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java:
##
@@ -755,6 +756,29 @@ public class StreamsConfig extends AbstractConfig {
public static
[
https://issues.apache.org/jira/browse/KAFKA-15306?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lianet Magrans updated KAFKA-15306:
---
Description: Integrate refreshCommittedOffsets logic, currently performed
by the
Lianet Magrans created KAFKA-15306:
--
Summary: Integrate committed offsets logic when updating fetching
positions
Key: KAFKA-15306
URL: https://issues.apache.org/jira/browse/KAFKA-15306
Project:
ableegoldman commented on PR #14149:
URL: https://github.com/apache/kafka/pull/14149#issuecomment-1666170754
Test failures are unrelated
Super small fix, would like to get it into 3.6 though
ping also @vvcephei @showuon @wcarlson5 for a review
--
This is an automated message
[
https://issues.apache.org/jira/browse/KAFKA-15090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17751214#comment-17751214
]
Chris Egerton commented on KAFKA-15090:
---
This is a tricky one. First off, although we're almost
[
https://issues.apache.org/jira/browse/KAFKA-15303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17751212#comment-17751212
]
Matthias J. Sax commented on KAFKA-15303:
-
Thanks for filing this ticket.
Kafka Streams as only
[
https://issues.apache.org/jira/browse/KAFKA-15303?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-15303:
Issue Type: Improvement (was: Bug)
> Foreign key joins no longer triggered by events on
[
https://issues.apache.org/jira/browse/KAFKA-15303?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-15303:
Priority: Major (was: Critical)
> Foreign key joins no longer triggered by events on the
gharris1727 commented on PR #14092:
URL: https://github.com/apache/kafka/pull/14092#issuecomment-1666104751
@fvaleri That does appear to work, because [server-common is not being
excluded from
[
https://issues.apache.org/jira/browse/KAFKA-15090?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Egerton updated KAFKA-15090:
--
Description:
Before [https://github.com/apache/kafka/pull/9669], in distributed mode, the
Philip Nee created KAFKA-15305:
--
Summary: The background thread should try to process the remaining
task until the shutdown timer is expired
Key: KAFKA-15305
URL: https://issues.apache.org/jira/browse/KAFKA-15305
[
https://issues.apache.org/jira/browse/KAFKA-15020?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-15020:
--
Component/s: unit tests
>
[
https://issues.apache.org/jira/browse/KAFKA-15101?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-15101:
--
Labels: flaky-test (was: )
> Improve testRackAwareRangeAssignor test
>
[
https://issues.apache.org/jira/browse/KAFKA-15101?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-15101:
--
Component/s: unit tests
> Improve testRackAwareRangeAssignor test
>
[
https://issues.apache.org/jira/browse/KAFKA-15101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17751187#comment-17751187
]
Kirk True commented on KAFKA-15101:
---
Looks like a duplicate of KAFKA-15020.
> Improve
Philip Nee created KAFKA-15304:
--
Summary: CompletableApplicationEvents aren't being completed when
the consumer is closing
Key: KAFKA-15304
URL: https://issues.apache.org/jira/browse/KAFKA-15304
ruslankrivoshein commented on PR #13562:
URL: https://github.com/apache/kafka/pull/13562#issuecomment-1665982738
@fvaleri I summon thee. Please, take one more look
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
lianetm commented on code in PR #14123:
URL: https://github.com/apache/kafka/pull/14123#discussion_r1284689796
##
core/src/test/scala/integration/kafka/api/BaseAsyncConsumerTest.scala:
##
@@ -35,8 +39,12 @@ class BaseAsyncConsumerTest extends AbstractConsumerTest {
[
https://issues.apache.org/jira/browse/KAFKA-14682?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Egerton updated KAFKA-14682:
--
Description:
We've started using [strict
[
https://issues.apache.org/jira/browse/KAFKA-14682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17751178#comment-17751178
]
Chris Egerton commented on KAFKA-14682:
---
I've taken a stab at an upstream Mockito fix. If it's
[
https://issues.apache.org/jira/browse/KAFKA-14682?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Egerton reassigned KAFKA-14682:
-
Assignee: Chris Egerton (was: Christo Lolov)
> Unused stubbings are not reported by
[
https://issues.apache.org/jira/browse/KAFKA-15298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17751172#comment-17751172
]
Christo Lolov commented on KAFKA-15298:
---
Heya [~ckamal]! Thanks for pointing me to the pull
philipnee opened a new pull request, #14154:
URL: https://github.com/apache/kafka/pull/14154
There's a lot of random build failure, and we aren't sure why. Starting a
fresh build to see if these build failures persist.
--
This is an automated message from the Apache Git Service.
To
bachmanity1 commented on PR #14153:
URL: https://github.com/apache/kafka/pull/14153#issuecomment-1665858277
@C0urante @mjsax @cadonna could you please review this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
bachmanity1 opened a new pull request, #14153:
URL: https://github.com/apache/kafka/pull/14153
Replaced Easymock & Powermock with Mockito in KafkaBasedLogTest.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test
[
https://issues.apache.org/jira/browse/KAFKA-15239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17746622#comment-17746622
]
Federico Valeri edited comment on KAFKA-15239 at 8/4/23 3:58 PM:
-
Hi
fvaleri commented on PR #14092:
URL: https://github.com/apache/kafka/pull/14092#issuecomment-1665804677
@gharris1727 I tried various things, as I'm also learning how this works.
The best solution I found is to move the ThroughputThrottler class from
clients to server-common, adding
philipnee commented on PR #14118:
URL: https://github.com/apache/kafka/pull/14118#issuecomment-1665733961
I've been seeing stream test failures in the recent commits too!
This PR needs to be rebased against this PR:
https://github.com/apache/kafka/pull/14123 to resolve some of the
[
https://issues.apache.org/jira/browse/KAFKA-14682?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Egerton updated KAFKA-14682:
--
Description:
We've started using [strict
[
https://issues.apache.org/jira/browse/KAFKA-14682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17751125#comment-17751125
]
Chris Egerton commented on KAFKA-14682:
---
[~christo_lolov] were you still planning on working on
satishd merged PR #13984:
URL: https://github.com/apache/kafka/pull/13984
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
satishd commented on PR #13984:
URL: https://github.com/apache/kafka/pull/13984#issuecomment-1665559532
Right, there are a few unrelated test failures, merging it to trunk.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
[
https://issues.apache.org/jira/browse/KAFKA-15303?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Charles-Eddy updated KAFKA-15303:
-
Attachment: image (1).png
> Foreign key joins no longer triggered by events on the right side
[
https://issues.apache.org/jira/browse/KAFKA-15267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17751099#comment-17751099
]
Christo Lolov commented on KAFKA-15267:
---
Okay, I will send out an email later today
>
ivanyu commented on PR #13984:
URL: https://github.com/apache/kafka/pull/13984#issuecomment-1665493163
Thank you @satishd
Seems the failures aren't related
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
[
https://issues.apache.org/jira/browse/KAFKA-15267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17751095#comment-17751095
]
Luke Chen commented on KAFKA-15267:
---
(1) and (3) are good to me. The only concern is we don't have KIP
satishd commented on code in PR #13561:
URL: https://github.com/apache/kafka/pull/13561#discussion_r1284280124
##
core/src/main/java/kafka/log/remote/RemoteLogManager.java:
##
@@ -667,11 +675,323 @@ public void run() {
}
}
+public void
satishd commented on code in PR #13561:
URL: https://github.com/apache/kafka/pull/13561#discussion_r1284278935
##
core/src/main/scala/kafka/log/UnifiedLog.scala:
##
@@ -2207,7 +2267,7 @@ case class RetentionSizeBreach(log: UnifiedLog) extends
SegmentDeletionReason {
var
[
https://issues.apache.org/jira/browse/KAFKA-15195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17751078#comment-17751078
]
Christo Lolov commented on KAFKA-15195:
---
Acknowledged, I will circle-back on this once 3.6.0 makes
[
https://issues.apache.org/jira/browse/KAFKA-15267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17751077#comment-17751077
]
Christo Lolov commented on KAFKA-15267:
---
Heya [~showuon]. Okay, I propose we do the following:
*
[
https://issues.apache.org/jira/browse/KAFKA-14038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17751076#comment-17751076
]
Christo Lolov edited comment on KAFKA-14038 at 8/4/23 10:37 AM:
The
[
https://issues.apache.org/jira/browse/KAFKA-14038?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christo Lolov reassigned KAFKA-14038:
-
Assignee: Christo Lolov (was: Divij Vaidya)
> Optimize calculation of size for log in
[
https://issues.apache.org/jira/browse/KAFKA-14038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17751076#comment-17751076
]
Christo Lolov commented on KAFKA-14038:
---
The remaining part of this ticket is blocked on merging
fvaleri commented on PR #14092:
URL: https://github.com/apache/kafka/pull/14092#issuecomment-1665393332
> So for example, if the node.version is 1.0.0, this condition will be true,
and the script will add DEV jars to CLASSPATH. kafka-run-class.sh then finds
the 1.0.0 jars and adds them to
[
https://issues.apache.org/jira/browse/KAFKA-15303?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Charles-Eddy updated KAFKA-15303:
-
Description:
Hello everyone, I am currently working on a project that uses Kafka Streams
hudeqi commented on PR #13929:
URL: https://github.com/apache/kafka/pull/13929#issuecomment-1665378793
> I still need to get 3.5.1 out and focus on KIP-405 PRs (targeting 3.6
release) before I get some more time @hudeqi!
Hi, do you have time to review this PR now? I want to combine
Charles-Eddy created KAFKA-15303:
Summary: Foreign key joins no longer triggered by events on the
right side of the join after deployment with a new compatible Avro schema
Key: KAFKA-15303
URL:
yashmayya commented on PR #14152:
URL: https://github.com/apache/kafka/pull/14152#issuecomment-1665377020
@cadonna @mjsax would you be able to take a look at this whenever you get a
chance?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
yashmayya commented on code in PR #14152:
URL: https://github.com/apache/kafka/pull/14152#discussion_r1284245654
##
streams/src/test/java/org/apache/kafka/streams/state/internals/WindowStoreBuilderTest.java:
##
@@ -164,17 +160,6 @@ public void
yashmayya commented on code in PR #14152:
URL: https://github.com/apache/kafka/pull/14152#discussion_r1284245654
##
streams/src/test/java/org/apache/kafka/streams/state/internals/WindowStoreBuilderTest.java:
##
@@ -164,17 +160,6 @@ public void
satishd commented on code in PR #13561:
URL: https://github.com/apache/kafka/pull/13561#discussion_r1284241897
##
core/src/main/scala/kafka/log/UnifiedLog.scala:
##
@@ -152,16 +152,42 @@ class UnifiedLog(@volatile var logStartOffset: Long,
locally {
yashmayya opened a new pull request, #14152:
URL: https://github.com/apache/kafka/pull/14152
- Part of the larger effort to replace the usage of `EasyMock` and
`PowerMock` with `Mockito` across the project that has been underway for the
last few years (see
showuon opened a new pull request, #14151:
URL: https://github.com/apache/kafka/pull/14151
When configuring RLMM, the configs passed into `configure` method is the
`RemoteLogManagerConfig`. But in `RemoteLogManagerConfig`, there's no configs
related to `remote.log.metadata.*`, ex:
satishd commented on PR #13984:
URL: https://github.com/apache/kafka/pull/13984#issuecomment-1665334207
Will merge if the Jenkins jobs do not fail with any related tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
[
https://issues.apache.org/jira/browse/KAFKA-15295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kamal Chandraprakash reassigned KAFKA-15295:
Assignee: Luke Chen (was: Kamal Chandraprakash)
> Add config validation
[
https://issues.apache.org/jira/browse/KAFKA-15295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17751054#comment-17751054
]
Kamal Chandraprakash commented on KAFKA-15295:
--
[~showuon]
I'm not working on this one
[
https://issues.apache.org/jira/browse/KAFKA-14598?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ashwin Pankaj resolved KAFKA-14598.
---
Resolution: Fixed
Did not observe this recently
> Fix flaky ConnectRestApiTest
>
[
https://issues.apache.org/jira/browse/KAFKA-14598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17751051#comment-17751051
]
Ashwin Pankaj commented on KAFKA-14598:
---
Did not see this occuring recently - closing this issue.
[
https://issues.apache.org/jira/browse/KAFKA-15083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17751036#comment-17751036
]
Luke Chen commented on KAFKA-15083:
---
[~satish.duggana] , sorry that I didn't get the ping last time.
[
https://issues.apache.org/jira/browse/KAFKA-15267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17751033#comment-17751033
]
Luke Chen commented on KAFKA-15267:
---
Do we have any update on this issue? I think this is a blocker
satishd commented on code in PR #13984:
URL: https://github.com/apache/kafka/pull/13984#discussion_r1284146317
##
core/src/main/java/kafka/log/remote/RemoteLogManager.java:
##
@@ -623,10 +632,30 @@ private void copyLogSegment(UnifiedLog log, LogSegment
segment, long
[
https://issues.apache.org/jira/browse/KAFKA-15295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17751031#comment-17751031
]
Luke Chen commented on KAFKA-15295:
---
[~ckamal] , are you still working on this? If you don't have
ivanyu commented on code in PR #13984:
URL: https://github.com/apache/kafka/pull/13984#discussion_r1284145024
##
storage/api/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteLogSegmentMetadata.java:
##
@@ -66,6 +68,11 @@ public class RemoteLogSegmentMetadata
showuon commented on code in PR #13984:
URL: https://github.com/apache/kafka/pull/13984#discussion_r1284105567
##
storage/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteLogManagerConfig.java:
##
@@ -81,6 +81,13 @@ public final class RemoteLogManagerConfig {
cadonna merged PR #14145:
URL: https://github.com/apache/kafka/pull/14145
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
cadonna commented on PR #14145:
URL: https://github.com/apache/kafka/pull/14145#issuecomment-1665114431
Build failures are unrelated:
```
Build / JDK 17 and Scala 2.13 /
integration.kafka.server.FetchFromFollowerIntegrationTest.testRackAwareRangeAssignor()
Build / JDK 11
showuon commented on code in PR #14127:
URL: https://github.com/apache/kafka/pull/14127#discussion_r1284009383
##
storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/ConsumerTask.java:
##
@@ -64,302 +65,387 @@
class ConsumerTask implements Runnable,
lihaosky opened a new pull request, #14150:
URL: https://github.com/apache/kafka/pull/14150
### Description
1. Add configs for rack aware assignor
2. Update standby optimizer in `RackAwareTaskAssignor` to have more rounds
3. Refactor some method in `RackAwareTaskAssignorTest` to
satishd commented on code in PR #13984:
URL: https://github.com/apache/kafka/pull/13984#discussion_r1284030338
##
storage/api/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteLogSegmentMetadata.java:
##
@@ -66,6 +68,11 @@ public class RemoteLogSegmentMetadata
98 matches
Mail list logo