[GitHub] [kafka] amangandhi94 commented on pull request #14119: KAFKA-15266: Static configs set for non primary synonyms are ignored for Log configs

amangandhi94 commented on PR #14119: URL: https://github.com/apache/kafka/pull/14119#issuecomment-1667210115 @divijvaidya @chia7712 Would appreciate any input on this patch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [kafka] philipnee commented on pull request #14123: MINOR: Fix committed API in the PrototypeAsyncConsumer timeout

philipnee commented on PR #14123: URL: https://github.com/apache/kafka/pull/14123#issuecomment-1667163104 Hey @junrao - The most recent build, after merging trunk in, seems reasonably clean. Here are the broken tests, but all seem unrelated to the change ``` Build / JDK 11 and

[GitHub] [kafka] vamossagar12 opened a new pull request, #14158: KAFKA-15296: Allow offsets to be committed for filtered records when Exactly Once support is disabled

vamossagar12 opened a new pull request, #14158: URL: https://github.com/apache/kafka/pull/14158 …Exactly Once support is disabled *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment

[GitHub] [kafka] mjsax commented on a diff in pull request #14157: KAFKA-15030: Avoid unnecessary re-serialization in FK-join

mjsax commented on code in PR #14157: URL: https://github.com/apache/kafka/pull/14157#discussion_r1285343576 ## streams/src/main/java/org/apache/kafka/streams/state/internals/KeyValueRawStoreWrapper.java: ## @@ -0,0 +1,166 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [kafka] mjsax commented on a diff in pull request #14157: KAFKA-15030: Avoid unnecessary re-serialization in FK-join

mjsax commented on code in PR #14157: URL: https://github.com/apache/kafka/pull/14157#discussion_r1285343576 ## streams/src/main/java/org/apache/kafka/streams/state/internals/KeyValueRawStoreWrapper.java: ## @@ -0,0 +1,166 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [kafka] mjsax commented on a diff in pull request #14157: KAFKA-15030: Avoid unnecessary re-serialization in FK-join

mjsax commented on code in PR #14157: URL: https://github.com/apache/kafka/pull/14157#discussion_r1285341728 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/foreignkeyjoin/ResponseJoinProcessorSupplier.java: ## @@ -44,72 +45,98 @@ * @param Type of foreign

[GitHub] [kafka] mjsax commented on a diff in pull request #14157: KAFKA-15030: Avoid unnecessary re-serialization in FK-join

mjsax commented on code in PR #14157: URL: https://github.com/apache/kafka/pull/14157#discussion_r1285341380 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamSessionWindowAggregate.java: ## @@ -266,20 +266,22 @@ private void fetchAndEmit(final Record

[GitHub] [kafka] mjsax commented on a diff in pull request #14157: KAFKA-15030: Avoid unnecessary re-serialization in FK-join

mjsax commented on code in PR #14157: URL: https://github.com/apache/kafka/pull/14157#discussion_r1285341513 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/KTableProcessorSupplier.java: ## @@ -16,12 +16,17 @@ */ package

[GitHub] [kafka] mjsax commented on a diff in pull request #14157: KAFKA-15030: Avoid unnecessary re-serialization in FK-join

mjsax commented on code in PR #14157: URL: https://github.com/apache/kafka/pull/14157#discussion_r1285340966 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamAggProcessorSupplier.java: ## @@ -16,12 +16,17 @@ */ package

[jira] [Assigned] (KAFKA-15303) Foreign key joins no longer triggered by events on the right side of the join after deployment with a new compatible Avro schema

[ https://issues.apache.org/jira/browse/KAFKA-15303?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax reassigned KAFKA-15303: --- Assignee: Matthias J. Sax > Foreign key joins no longer triggered by events on the

[jira] [Commented] (KAFKA-15302) Stale value returned when using store.all() in punctuation function.

[ https://issues.apache.org/jira/browse/KAFKA-15302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17751422#comment-17751422 ] Jinyong Choi commented on KAFKA-15302: -- [~guozhang] Hi. Sure. It is my test code. As you

[jira] [Commented] (KAFKA-15302) Stale value returned when using store.all() in punctuation function.

[ https://issues.apache.org/jira/browse/KAFKA-15302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17751403#comment-17751403 ] Guozhang Wang commented on KAFKA-15302: --- [~jinyong.choi] to help us better understand your issue,

[GitHub] [kafka] guozhangwang merged pull request #14155: MINOR: update Kafka Streams state.dir doc

guozhangwang merged PR #14155: URL: https://github.com/apache/kafka/pull/14155 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] kamalcph commented on pull request #14116: KAFKA-15167: Tiered Storage Test Harness Framework

kamalcph commented on PR #14116: URL: https://github.com/apache/kafka/pull/14116#issuecomment-1666869894 @clolov @divijvaidya @showuon @Hangleton @satishd 1. This PR contains huge changes but most of them are new POJO classes and specific actions. My suggestion is to review all the

[GitHub] [kafka] abhijeetk88 commented on a diff in pull request #14127: KAFKA-15181: Wait for RemoteLogMetadataCache to initialize after assigning partitions

abhijeetk88 commented on code in PR #14127: URL: https://github.com/apache/kafka/pull/14127#discussion_r1285212779 ## storage/src/test/java/org/apache/kafka/server/log/remote/metadata/storage/TopicBasedRemoteLogMetadataManagerMultipleSubscriptionsTest.java: ## @@ -0,0 +1,186 @@

[GitHub] [kafka] abhijeetk88 commented on a diff in pull request #14127: KAFKA-15181: Wait for RemoteLogMetadataCache to initialize after assigning partitions

abhijeetk88 commented on code in PR #14127: URL: https://github.com/apache/kafka/pull/14127#discussion_r1285212684 ## storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/ConsumerTask.java: ## @@ -64,302 +65,387 @@ class ConsumerTask implements Runnable,

[GitHub] [kafka] abhijeetk88 commented on a diff in pull request #14127: KAFKA-15181: Wait for RemoteLogMetadataCache to initialize after assigning partitions

abhijeetk88 commented on code in PR #14127: URL: https://github.com/apache/kafka/pull/14127#discussion_r1285212647 ## storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/ConsumerTask.java: ## @@ -64,302 +65,387 @@ class ConsumerTask implements Runnable,

[GitHub] [kafka] abhijeetk88 commented on a diff in pull request #14127: KAFKA-15181: Wait for RemoteLogMetadataCache to initialize after assigning partitions

abhijeetk88 commented on code in PR #14127: URL: https://github.com/apache/kafka/pull/14127#discussion_r1285212583 ## storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/ConsumerTask.java: ## @@ -64,302 +65,387 @@ class ConsumerTask implements Runnable,

[GitHub] [kafka] abhijeetk88 commented on a diff in pull request #14127: KAFKA-15181: Wait for RemoteLogMetadataCache to initialize after assigning partitions

abhijeetk88 commented on code in PR #14127: URL: https://github.com/apache/kafka/pull/14127#discussion_r1285212542 ## storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/ConsumerTask.java: ## @@ -64,302 +65,387 @@ class ConsumerTask implements Runnable,

[GitHub] [kafka] abhijeetk88 commented on a diff in pull request #14127: KAFKA-15181: Wait for RemoteLogMetadataCache to initialize after assigning partitions

abhijeetk88 commented on code in PR #14127: URL: https://github.com/apache/kafka/pull/14127#discussion_r1285212375 ## storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/ConsumerTask.java: ## @@ -64,302 +65,387 @@ class ConsumerTask implements Runnable,

[GitHub] [kafka] abhijeetk88 commented on a diff in pull request #14127: KAFKA-15181: Wait for RemoteLogMetadataCache to initialize after assigning partitions

abhijeetk88 commented on code in PR #14127: URL: https://github.com/apache/kafka/pull/14127#discussion_r1285204749 ## storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/RemoteLogMetadataCache.java: ## @@ -104,6 +106,22 @@ public class

[GitHub] [kafka] abhijeetk88 commented on a diff in pull request #14127: KAFKA-15181: Wait for RemoteLogMetadataCache to initialize after assigning partitions

abhijeetk88 commented on code in PR #14127: URL: https://github.com/apache/kafka/pull/14127#discussion_r1285196135 ## storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/ConsumerTask.java: ## @@ -64,302 +65,387 @@ class ConsumerTask implements Runnable,

[GitHub] [kafka] ethaden commented on a diff in pull request #14130: KAFKA-15273: Log common name of expired client certificates

ethaden commented on code in PR #14130: URL: https://github.com/apache/kafka/pull/14130#discussion_r1285195172 ## clients/src/main/java/org/apache/kafka/common/security/ssl/DefaultSslEngineFactory.java: ## @@ -255,7 +271,7 @@ private SSLContext createSSLContext(SecurityStore

[GitHub] [kafka] ethaden commented on a diff in pull request #14130: KAFKA-15273: Log common name of expired client certificates

ethaden commented on code in PR #14130: URL: https://github.com/apache/kafka/pull/14130#discussion_r1285195172 ## clients/src/main/java/org/apache/kafka/common/security/ssl/DefaultSslEngineFactory.java: ## @@ -255,7 +271,7 @@ private SSLContext createSSLContext(SecurityStore

[GitHub] [kafka] abhijeetk88 commented on a diff in pull request #14127: KAFKA-15181: Wait for RemoteLogMetadataCache to initialize after assigning partitions

abhijeetk88 commented on code in PR #14127: URL: https://github.com/apache/kafka/pull/14127#discussion_r1285156707 ## storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/ConsumerTask.java: ## @@ -64,302 +65,387 @@ class ConsumerTask implements Runnable,