alok123t commented on code in PR #14162:
URL: https://github.com/apache/kafka/pull/14162#discussion_r1286557850
##
raft/src/main/java/org/apache/kafka/snapshot/FileRawSnapshotWriter.java:
##
@@ -112,6 +112,9 @@ public void freeze() {
checkIfFrozen("Freeze");
[
https://issues.apache.org/jira/browse/KAFKA-15259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17751878#comment-17751878
]
Guozhang Wang commented on KAFKA-15259:
---
Got it, KAFKA-15309 makes sense.
> Kafka Streams does
[
https://issues.apache.org/jira/browse/KAFKA-15259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tomonari Yamashita updated KAFKA-15259:
---
Description:
[Problem]
- Kafka Streams does not continue processing due to
[
https://issues.apache.org/jira/browse/KAFKA-15259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tomonari Yamashita updated KAFKA-15259:
---
Summary: Kafka Streams does not continue processing due to rollback despite
[
https://issues.apache.org/jira/browse/KAFKA-15259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tomonari Yamashita updated KAFKA-15259:
---
Description:
[Problem]
- Kafka Streams does not continue processing due to
[
https://issues.apache.org/jira/browse/KAFKA-15259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17751862#comment-17751862
]
Tomonari Yamashita commented on KAFKA-15259:
Thank you for creating the new ticket for Kafka
[
https://issues.apache.org/jira/browse/KAFKA-15302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17751836#comment-17751836
]
Matthias J. Sax commented on KAFKA-15302:
-
{quote}it's a combo of a cache snapshot and the
[
https://issues.apache.org/jira/browse/KAFKA-15259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17751835#comment-17751835
]
Matthias J. Sax commented on KAFKA-15259:
-
Ah. Sorry. Meant
[
https://issues.apache.org/jira/browse/KAFKA-15259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17751759#comment-17751759
]
Matthias J. Sax edited comment on KAFKA-15259 at 8/7/23 11:59 PM:
--
[
https://issues.apache.org/jira/browse/KAFKA-15259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17751759#comment-17751759
]
Matthias J. Sax edited comment on KAFKA-15259 at 8/7/23 11:58 PM:
--
[
https://issues.apache.org/jira/browse/KAFKA-15259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17751267#comment-17751267
]
Matthias J. Sax edited comment on KAFKA-15259 at 8/7/23 11:58 PM:
--
I
[
https://issues.apache.org/jira/browse/KAFKA-15259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17751267#comment-17751267
]
Matthias J. Sax edited comment on KAFKA-15259 at 8/7/23 11:58 PM:
--
I
[
https://issues.apache.org/jira/browse/KAFKA-15197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17751833#comment-17751833
]
Greg Harris commented on KAFKA-15197:
-
[~divijvaidya] I apologize for the flakiness of the test,
gharris1727 commented on code in PR #14068:
URL: https://github.com/apache/kafka/pull/14068#discussion_r1286472665
##
docs/connect.html:
##
@@ -543,6 +543,67 @@ ACL requirements
+Plugin
Discovery
+
+Plugin discovery is the name for the strategy which
[
https://issues.apache.org/jira/browse/KAFKA-15302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17751830#comment-17751830
]
Guozhang Wang commented on KAFKA-15302:
---
I think case I'm not sure if this is defined as a bug
gharris1727 commented on code in PR #14068:
URL: https://github.com/apache/kafka/pull/14068#discussion_r1286461778
##
docs/connect.html:
##
@@ -543,6 +543,67 @@ ACL requirements
+Plugin
Discovery
+
+Plugin discovery is the name for the strategy which
gharris1727 commented on code in PR #14068:
URL: https://github.com/apache/kafka/pull/14068#discussion_r1286460752
##
docs/connect.html:
##
@@ -543,6 +543,67 @@ ACL requirements
+Plugin
Discovery
+
+Plugin discovery is the name for the strategy which
[
https://issues.apache.org/jira/browse/KAFKA-15259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17751824#comment-17751824
]
Guozhang Wang commented on KAFKA-15259:
---
[~mjsax] Did you mean a different ticket other than
gharris1727 commented on code in PR #14068:
URL: https://github.com/apache/kafka/pull/14068#discussion_r1286456172
##
docs/connect.html:
##
@@ -543,6 +543,67 @@ ACL requirements
+Plugin
Discovery
+
+Plugin discovery is the name for the strategy which
guozhangwang commented on code in PR #14149:
URL: https://github.com/apache/kafka/pull/14149#discussion_r1286454991
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignor.java:
##
@@ -618,18 +618,24 @@ private boolean
gharris1727 commented on code in PR #14068:
URL: https://github.com/apache/kafka/pull/14068#discussion_r1286456172
##
docs/connect.html:
##
@@ -543,6 +543,67 @@ ACL requirements
+Plugin
Discovery
+
+Plugin discovery is the name for the strategy which
[
https://issues.apache.org/jira/browse/KAFKA-15297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17751821#comment-17751821
]
Guozhang Wang commented on KAFKA-15297:
---
I think this is indeed a general issue, that state stores
lihaosky commented on code in PR #14139:
URL: https://github.com/apache/kafka/pull/14139#discussion_r1286439107
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/assignment/HighAvailabilityTaskAssignorTest.java:
##
@@ -56,52 +67,118 @@
import static
lihaosky commented on code in PR #14139:
URL: https://github.com/apache/kafka/pull/14139#discussion_r1286438784
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/HighAvailabilityTaskAssignor.java:
##
@@ -124,11 +133,20 @@ private static void
[
https://issues.apache.org/jira/browse/KAFKA-15281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True reassigned KAFKA-15281:
-
Assignee: (was: Kirk True)
> Implement the groupMetadata Consumer API
>
[
https://issues.apache.org/jira/browse/KAFKA-15282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True reassigned KAFKA-15282:
-
Assignee: (was: Kirk True)
> Implement client support for KIP-848 client-side assignors
>
[
https://issues.apache.org/jira/browse/KAFKA-15280?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True reassigned KAFKA-15280:
-
Assignee: (was: Kirk True)
> Implement client support for KIP-848 server-side assignors
>
[
https://issues.apache.org/jira/browse/KAFKA-15284?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True reassigned KAFKA-15284:
-
Assignee: (was: Kirk True)
> Implement ConsumerGroupProtocolVersionResolver to determine
[
https://issues.apache.org/jira/browse/KAFKA-15279?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True reassigned KAFKA-15279:
-
Assignee: (was: Kirk True)
> Implement client support for KIP-848 assignment RPCs
>
[
https://issues.apache.org/jira/browse/KAFKA-15278?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True reassigned KAFKA-15278:
-
Assignee: (was: Kirk True)
> Implement client support for KIP-848 ConsumerGroupHeartbeat
[
https://issues.apache.org/jira/browse/KAFKA-15306?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-15306:
--
Labels: consumer-threading-refactor (was: client consumer)
> Integrate committed offsets logic when
[
https://issues.apache.org/jira/browse/KAFKA-15304?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-15304:
--
Labels: consumer-threading-refactor (was: )
> CompletableApplicationEvents aren't being completed
[
https://issues.apache.org/jira/browse/KAFKA-15306?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-15306:
--
Labels: client consumer (was: client consumer kip-945)
> Integrate committed offsets logic when
[
https://issues.apache.org/jira/browse/KAFKA-15305?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-15305:
--
Component/s: clients
> The background thread should try to process the remaining task until the
>
[
https://issues.apache.org/jira/browse/KAFKA-15305?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-15305:
--
Labels: consumer-threading-refactor (was: )
> The background thread should try to process the
[
https://issues.apache.org/jira/browse/KAFKA-15304?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-15304:
--
Component/s: clients
> CompletableApplicationEvents aren't being completed when the consumer is
>
[
https://issues.apache.org/jira/browse/KAFKA-15306?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-15306:
--
Component/s: clients
consumer
> Integrate committed offsets logic when updating
mjsax commented on code in PR #14163:
URL: https://github.com/apache/kafka/pull/14163#discussion_r1286429053
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/assignment/AssignmentTestUtils.java:
##
@@ -805,12 +805,14 @@ static Map>
kirktrue commented on code in PR #14111:
URL: https://github.com/apache/kafka/pull/14111#discussion_r1286379164
##
clients/src/main/java/org/apache/kafka/clients/CommonClientConfigs.java:
##
@@ -77,17 +77,33 @@ public class CommonClientConfigs {
public static final String
gharris1727 commented on PR #14064:
URL: https://github.com/apache/kafka/pull/14064#issuecomment-1668643267
I've also added a new warning to stdout which alerts users when they have
incompatible plugins on the classpath that will not be auto-migrated. Currently
without any manifests in the
gharris1727 commented on PR #14064:
URL: https://github.com/apache/kafka/pull/14064#issuecomment-1668640505
> I think our workaround with a special path of classpath to denote
classpath plugins in PluginUtils::classpathPluginSource should be improved. I
built the basic auth extension,
gharris1727 commented on code in PR #14064:
URL: https://github.com/apache/kafka/pull/14064#discussion_r1286420767
##
tools/src/main/java/org/apache/kafka/tools/ConnectPluginPath.java:
##
@@ -0,0 +1,518 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
jsancio opened a new pull request, #14162:
URL: https://github.com/apache/kafka/pull/14162
On ext4 file systems we have seen snapshots with zero-length files. This is
possible if the file is closed and moved before forcing the channel to write to
disk.
### Committer Checklist
[
https://issues.apache.org/jira/browse/KAFKA-15312?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
José Armando García Sancio updated KAFKA-15312:
---
Description:
Not all file system fsync to disk on close. For KRaft
mjsax commented on code in PR #14139:
URL: https://github.com/apache/kafka/pull/14139#discussion_r1286401088
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/HighAvailabilityTaskAssignor.java:
##
@@ -145,6 +163,14 @@ private void
philipnee closed pull request #14154: [TEST] Testing build failures for the
commit
URL: https://github.com/apache/kafka/pull/14154
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
ruslankrivoshein commented on code in PR #13562:
URL: https://github.com/apache/kafka/pull/13562#discussion_r1286370800
##
tools/src/main/java/org/apache/kafka/tools/GetOffsetShell.java:
##
@@ -0,0 +1,404 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
C0urante commented on code in PR #13801:
URL: https://github.com/apache/kafka/pull/13801#discussion_r1286347860
##
connect/runtime/src/main/java/org/apache/kafka/connect/storage/ConnectorOffsetBackingStore.java:
##
@@ -279,15 +290,52 @@ public Future set(Map
values, Callback
nizhikov commented on code in PR #14096:
URL: https://github.com/apache/kafka/pull/14096#discussion_r1286331468
##
server-common/src/main/java/org/apache/kafka/admin/AdminUtils.java:
##
@@ -0,0 +1,257 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
C0urante commented on code in PR #14064:
URL: https://github.com/apache/kafka/pull/14064#discussion_r1286292051
##
tools/src/main/java/org/apache/kafka/tools/ConnectPluginPath.java:
##
@@ -0,0 +1,518 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
gharris1727 commented on PR #12806:
URL: https://github.com/apache/kafka/pull/12806#issuecomment-1668440375
Hey @divijvaidya .
> aren't we then accepting the current behaviour of quotas implementation as
expected behaviour i.e. the deviation could be +- epsilon and epsilon could
C0urante commented on code in PR #14064:
URL: https://github.com/apache/kafka/pull/14064#discussion_r1286274051
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/isolation/PluginUtils.java:
##
@@ -206,6 +207,12 @@ public static Set pluginLocations(String
C0urante commented on code in PR #14068:
URL: https://github.com/apache/kafka/pull/14068#discussion_r1286204067
##
docs/connect.html:
##
@@ -543,6 +543,67 @@ ACL requirements
+Plugin
Discovery
+
+Plugin discovery is the name for the strategy which the
mjsax merged PR #14150:
URL: https://github.com/apache/kafka/pull/14150
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
mjsax commented on code in PR #14150:
URL: https://github.com/apache/kafka/pull/14150#discussion_r1286245745
##
streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java:
##
@@ -890,12 +914,28 @@ public class StreamsConfig extends AbstractConfig {
rondagostino commented on code in PR #14160:
URL: https://github.com/apache/kafka/pull/14160#discussion_r1286234750
##
docs/ops.html:
##
@@ -3778,6 +3778,14 @@ Migrating brokers to KRaft
Each broker is restarted with a KRaft configuration until the entire
cluster is
mjsax commented on PR #14155:
URL: https://github.com/apache/kafka/pull/14155#issuecomment-1668327508
Cherry-picked to `3.5, [...], 2.8` branches.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
[
https://issues.apache.org/jira/browse/KAFKA-15302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17751761#comment-17751761
]
Matthias J. Sax commented on KAFKA-15302:
-
Thanks for providing more details; the `delete()`
[
https://issues.apache.org/jira/browse/KAFKA-15259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17751759#comment-17751759
]
Matthias J. Sax commented on KAFKA-15259:
-
{quote}Should we create a new ticket for Kafka
[
https://issues.apache.org/jira/browse/KAFKA-14747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17751756#comment-17751756
]
Matthias J. Sax commented on KAFKA-14747:
-
We can discuss here on the ticket I guess. The class
CalvinConfluent commented on PR #14138:
URL: https://github.com/apache/kafka/pull/14138#issuecomment-1668274095
@jolshan Can you help take a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
[
https://issues.apache.org/jira/browse/KAFKA-15312?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
José Armando García Sancio updated KAFKA-15312:
---
Description:
Not all file system fsync to disk on close. For KRaft
José Armando García Sancio created KAFKA-15312:
--
Summary: FileRawSnapshotWriter must flush before atomic move
Key: KAFKA-15312
URL: https://issues.apache.org/jira/browse/KAFKA-15312
clolov opened a new pull request, #14161:
URL: https://github.com/apache/kafka/pull/14161
# TODO
I need to find where the unit/integration tests for this behaviour are in
order to add the manual test to them
### Summary
The purpose of this change is to not allow a broker to
[
https://issues.apache.org/jira/browse/KAFKA-15310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17751747#comment-17751747
]
Chris Egerton commented on KAFKA-15310:
---
Hey [~romsouza], thanks for filing this ticket! Since the
[
https://issues.apache.org/jira/browse/KAFKA-15310?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Egerton updated KAFKA-15310:
--
Labels: needs-kip (was: )
> Add timezone configuration option in TimestampConverter from
gharris1727 commented on PR #14156:
URL: https://github.com/apache/kafka/pull/14156#issuecomment-1668233376
@monish-byte This specific PR thread isn't the right place to discuss this,
so please in the future post your general questions on the dev mailing list.
Your next steps should
C0urante commented on PR #14158:
URL: https://github.com/apache/kafka/pull/14158#issuecomment-1668229509
I've been scratching my head over this one for a bit. One one hand, it's
nice to allow heavily-filtered source connectors to record progress (and this
was a suggestion I made to address
[
https://issues.apache.org/jira/browse/KAFKA-14598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17751735#comment-17751735
]
Greg Harris edited comment on KAFKA-14598 at 8/7/23 4:33 PM:
-
[
https://issues.apache.org/jira/browse/KAFKA-14598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17751735#comment-17751735
]
Greg Harris commented on KAFKA-14598:
-
[~ashwinpankaj] The PR for this is a one line fix, and you
bachmanity1 commented on PR #14153:
URL: https://github.com/apache/kafka/pull/14153#issuecomment-1668221501
Hi @divijvaidya
Thanks for letting me know about ticket KAFKA-14132. It turns out that
@mdedetrich has already begun working on this issue and has submitted a PR, but
he said
[
https://issues.apache.org/jira/browse/KAFKA-15311?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Colin McCabe updated KAFKA-15311:
-
Summary: Fix docs about reverting to ZooKeeper mode during KRaft migration
(was: Docs
[
https://issues.apache.org/jira/browse/KAFKA-15311?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Colin McCabe updated KAFKA-15311:
-
Description: The cocs incorrectly state that reverting to ZooKeeper mode
during KRaft migration
[
https://issues.apache.org/jira/browse/KAFKA-15311?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Colin McCabe reassigned KAFKA-15311:
Assignee: Colin McCabe
> Fix docs about reverting to ZooKeeper mode during KRaft
cmccabe opened a new pull request, #14160:
URL: https://github.com/apache/kafka/pull/14160
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
Colin McCabe created KAFKA-15311:
Summary: Docs incorrectly state that reverting to ZooKeeper mode
during the migration is not possible
Key: KAFKA-15311
URL: https://issues.apache.org/jira/browse/KAFKA-15311
[
https://issues.apache.org/jira/browse/KAFKA-15311?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Colin McCabe updated KAFKA-15311:
-
Summary: Docs incorrectly state that reverting to ZooKeeper mode during
KRaft migration is not
gharris1727 commented on code in PR #14159:
URL: https://github.com/apache/kafka/pull/14159#discussion_r1286093427
##
connect/transforms/src/test/java/org/apache/kafka/connect/transforms/TimestampRouterTest.java:
##
@@ -16,24 +16,19 @@
*/
package
gharris1727 commented on code in PR #14159:
URL: https://github.com/apache/kafka/pull/14159#discussion_r1286093427
##
connect/transforms/src/test/java/org/apache/kafka/connect/transforms/TimestampRouterTest.java:
##
@@ -16,24 +16,19 @@
*/
package
lucasbru commented on code in PR #14001:
URL: https://github.com/apache/kafka/pull/14001#discussion_r1286114522
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/tasks/DefaultTaskExecutor.java:
##
@@ -86,12 +87,29 @@ private void runOnce(final long nowMs) {
lucasbru commented on code in PR #14001:
URL: https://github.com/apache/kafka/pull/14001#discussion_r1286114522
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/tasks/DefaultTaskExecutor.java:
##
@@ -86,12 +87,29 @@ private void runOnce(final long nowMs) {
vamossagar12 commented on PR #14158:
URL: https://github.com/apache/kafka/pull/14158#issuecomment-1668174595
Yash, Greg I have marked you as reviewers for this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
[
https://issues.apache.org/jira/browse/KAFKA-14421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17751726#comment-17751726
]
Philip Nee commented on KAFKA-14421:
[~showuon] - should we close this issue as it is not supported.
kamalcph commented on code in PR #14127:
URL: https://github.com/apache/kafka/pull/14127#discussion_r1286092708
##
storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/RemoteLogMetadataCache.java:
##
@@ -104,6 +106,22 @@ public class RemoteLogMetadataCache
abhijeetk88 commented on code in PR #14127:
URL: https://github.com/apache/kafka/pull/14127#discussion_r1286091923
##
storage/src/test/java/org/apache/kafka/server/log/remote/metadata/storage/ConsumerTaskTest.java:
##
@@ -0,0 +1,396 @@
+/*
+ * Licensed to the Apache Software
abhijeetk88 commented on code in PR #14127:
URL: https://github.com/apache/kafka/pull/14127#discussion_r1286090883
##
storage/src/test/java/org/apache/kafka/server/log/remote/metadata/storage/ConsumerTaskTest.java:
##
@@ -0,0 +1,396 @@
+/*
+ * Licensed to the Apache Software
abhijeetk88 commented on code in PR #14127:
URL: https://github.com/apache/kafka/pull/14127#discussion_r1286089506
##
storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/ConsumerTask.java:
##
@@ -64,302 +65,387 @@
class ConsumerTask implements Runnable,
kamalcph commented on code in PR #14116:
URL: https://github.com/apache/kafka/pull/14116#discussion_r1286059074
##
core/src/main/scala/kafka/server/KafkaBroker.scala:
##
@@ -19,6 +19,7 @@ package kafka.server
import com.yammer.metrics.core.MetricName
import
kamalcph commented on PR #14116:
URL: https://github.com/apache/kafka/pull/14116#issuecomment-1668144105
> This leads to a situation where the tests we add will not be runnable with
kraft/zk mode easily.
We are not using ZooKeeper client directly anywhere so Kraft mode should
work
kamalcph commented on code in PR #14116:
URL: https://github.com/apache/kafka/pull/14116#discussion_r1286072822
##
storage/src/test/java/org/apache/kafka/tiered/storage/TieredStorageTestBuilder.java:
##
@@ -0,0 +1,427 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
vamossagar12 commented on PR #14000:
URL: https://github.com/apache/kafka/pull/14000#issuecomment-1668141669
Test failures are unrelated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
kamalcph commented on code in PR #14116:
URL: https://github.com/apache/kafka/pull/14116#discussion_r1286074651
##
storage/src/test/java/org/apache/kafka/tiered/storage/TieredStorageTestBuilder.java:
##
@@ -0,0 +1,427 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
kamalcph commented on code in PR #14116:
URL: https://github.com/apache/kafka/pull/14116#discussion_r1286072822
##
storage/src/test/java/org/apache/kafka/tiered/storage/TieredStorageTestBuilder.java:
##
@@ -0,0 +1,427 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
kamalcph commented on code in PR #14116:
URL: https://github.com/apache/kafka/pull/14116#discussion_r1286066810
##
storage/src/test/java/org/apache/kafka/tiered/storage/TieredStorageTestContext.java:
##
@@ -0,0 +1,348 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
kamalcph commented on code in PR #14116:
URL: https://github.com/apache/kafka/pull/14116#discussion_r1286064263
##
storage/src/test/java/org/apache/kafka/tiered/storage/TieredStorageTestContext.java:
##
@@ -0,0 +1,348 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
kamalcph commented on code in PR #14116:
URL: https://github.com/apache/kafka/pull/14116#discussion_r1286060966
##
storage/src/test/java/org/apache/kafka/tiered/storage/TieredStorageTestContext.java:
##
@@ -0,0 +1,348 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
kamalcph commented on code in PR #14116:
URL: https://github.com/apache/kafka/pull/14116#discussion_r1286060584
##
storage/src/test/java/org/apache/kafka/tiered/storage/TieredStorageTestContext.java:
##
@@ -0,0 +1,348 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
kamalcph commented on code in PR #14116:
URL: https://github.com/apache/kafka/pull/14116#discussion_r1286060074
##
storage/src/test/java/org/apache/kafka/tiered/storage/TieredStorageTestContext.java:
##
@@ -0,0 +1,348 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
kamalcph commented on code in PR #14116:
URL: https://github.com/apache/kafka/pull/14116#discussion_r1286059074
##
core/src/main/scala/kafka/server/KafkaBroker.scala:
##
@@ -19,6 +19,7 @@ package kafka.server
import com.yammer.metrics.core.MetricName
import
lucasbru commented on code in PR #14001:
URL: https://github.com/apache/kafka/pull/14001#discussion_r1286049066
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/tasks/DefaultTaskExecutor.java:
##
@@ -87,11 +88,29 @@ private void runOnce(final long nowMs) {
1 - 100 of 128 matches
Mail list logo
