satishd commented on code in PR #13561:
URL: https://github.com/apache/kafka/pull/13561#discussion_r1289577612
##
core/src/main/scala/kafka/log/UnifiedLog.scala:
##
@@ -1464,12 +1513,12 @@ class UnifiedLog(@volatile var logStartOffset: Long,
}
}
-
satishd commented on code in PR #13561:
URL: https://github.com/apache/kafka/pull/13561#discussion_r1289577043
##
core/src/main/java/kafka/log/remote/RemoteLogManager.java:
##
@@ -696,11 +704,327 @@ public void run() {
}
}
+public void
mehbey commented on code in PR #14135:
URL: https://github.com/apache/kafka/pull/14135#discussion_r1289574391
##
storage/src/main/java/org/apache/kafka/storage/internals/log/LogConfig.java:
##
@@ -186,6 +191,12 @@ public Optional serverConfigName(String
configName) {
mehbey commented on code in PR #14135:
URL: https://github.com/apache/kafka/pull/14135#discussion_r1289574103
##
core/src/test/scala/unit/kafka/log/LogValidatorTest.scala:
##
@@ -1398,6 +1437,73 @@ class LogValidatorTest {
assertEquals(6, e.recordErrors.size)
}
+
mehbey commented on code in PR #14135:
URL: https://github.com/apache/kafka/pull/14135#discussion_r1289573699
##
core/src/test/scala/unit/kafka/log/LogValidatorTest.scala:
##
@@ -1398,6 +1437,73 @@ class LogValidatorTest {
assertEquals(6, e.recordErrors.size)
}
+
mehbey commented on code in PR #14135:
URL: https://github.com/apache/kafka/pull/14135#discussion_r1289573138
##
core/src/test/scala/integration/kafka/api/PlaintextProducerSendTest.scala:
##
@@ -120,17 +121,17 @@ class PlaintextProducerSendTest extends
BaseProducerSendTest {
satishd commented on code in PR #13561:
URL: https://github.com/apache/kafka/pull/13561#discussion_r1289566534
##
core/src/main/scala/kafka/log/UnifiedLog.scala:
##
@@ -1390,7 +1424,15 @@ class UnifiedLog(@volatile var logStartOffset: Long,
private def
mehbey commented on code in PR #14135:
URL: https://github.com/apache/kafka/pull/14135#discussion_r1289521270
##
core/src/main/scala/kafka/server/KafkaConfig.scala:
##
@@ -1862,7 +1884,35 @@ class KafkaConfig private(doLog: Boolean, val props:
java.util.Map[_, _], dynami
[
https://issues.apache.org/jira/browse/KAFKA-15240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17752604#comment-17752604
]
shilin Lu commented on KAFKA-15240:
---
[~cmccabe] [~hachikuji] please take a look at this issue,thks
>
satishd commented on code in PR #13561:
URL: https://github.com/apache/kafka/pull/13561#discussion_r1289488513
##
core/src/main/scala/kafka/log/UnifiedLog.scala:
##
@@ -1390,7 +1424,15 @@ class UnifiedLog(@volatile var logStartOffset: Long,
private def
[
https://issues.apache.org/jira/browse/KAFKA-9199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17752596#comment-17752596
]
Fei Xie commented on KAFKA-9199:
Hi [~hachikuji] , is this issue still open? You've mentioned that this
mjsax merged PR #14178:
URL: https://github.com/apache/kafka/pull/14178
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
showuon commented on PR #14078:
URL: https://github.com/apache/kafka/pull/14078#issuecomment-1672467423
The failed tests are listed here:
https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-14078/2/
They are all unrelated to your change. I'll review this PR later. Thanks for
the
dengziming merged PR #14110:
URL: https://github.com/apache/kafka/pull/14110
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
olalamichelle commented on PR #14078:
URL: https://github.com/apache/kafka/pull/14078#issuecomment-1672436566
Hi Divij,
It is stating that "all checks have failed and this commit has test
failures". But upon checking the merge details, I was not able to find the
exact failure info.
ex172000 commented on PR #14110:
URL: https://github.com/apache/kafka/pull/14110#issuecomment-1672429558
@satishd can you help to review?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
mjsax commented on code in PR #14149:
URL: https://github.com/apache/kafka/pull/14149#discussion_r1289372985
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignor.java:
##
@@ -1063,9 +1071,13 @@ private Map>
buildStandbyTaskMap(final
mjsax commented on code in PR #14149:
URL: https://github.com/apache/kafka/pull/14149#discussion_r1289369350
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignor.java:
##
@@ -1063,9 +1071,13 @@ private Map>
buildStandbyTaskMap(final
mjsax merged PR #14164:
URL: https://github.com/apache/kafka/pull/14164
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
junrao commented on PR #13947:
URL: https://github.com/apache/kafka/pull/13947#issuecomment-1672284941
> I didn't follow previous changes, but I think current implementation also
works for KRaft mode, right? I can see ReplicaManager#applyDelta is invoking
stopPartitions, which will do what
junrao commented on code in PR #13947:
URL: https://github.com/apache/kafka/pull/13947#discussion_r1289212842
##
core/src/main/scala/kafka/server/ReplicaManager.scala:
##
@@ -526,25 +530,37 @@ class ReplicaManager(val config: KafkaConfig,
/**
* Stop the given partitions.
lucasbru opened a new pull request, #14180:
URL: https://github.com/apache/kafka/pull/14180
Avoid busy waiting for processable tasks. We need to be a bit careful here
to not have the task executors to sleep when work is available. We have to make
sure to signal on the condition variable
philipnee opened a new pull request, #14179:
URL: https://github.com/apache/kafka/pull/14179
As title, we discovered a flaky bug during testing that it would seldomly
thrown a NOT_COORDINATOR exception, which means the request was routed to a
non-coordinator node. We discovered that if we
[
https://issues.apache.org/jira/browse/KAFKA-14049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17752522#comment-17752522
]
Matthias J. Sax commented on KAFKA-14049:
-
I am still not sure if I understand this ticket? – Or
[
https://issues.apache.org/jira/browse/KAFKA-14049?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-14049:
Labels: (was: kip)
> Relax Non Null Requirement for KStreamGlobalKTable Left Join
>
lihaosky commented on code in PR #14178:
URL: https://github.com/apache/kafka/pull/14178#discussion_r1289205241
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/assignment/AssignmentTestUtils.java:
##
@@ -617,21 +652,23 @@ static Map>>
[
https://issues.apache.org/jira/browse/KAFKA-14049?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-14049:
Labels: kip (was: beginner newbie)
> Relax Non Null Requirement for KStreamGlobalKTable
[
https://issues.apache.org/jira/browse/KAFKA-14748?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-14748:
Description:
Kafka Streams enforces a strict non-null-key policy in the DSL across all
[
https://issues.apache.org/jira/browse/KAFKA-14748?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-14748:
Labels: kip (was: )
> Relax non-null FK left-join requirement
>
[
https://issues.apache.org/jira/browse/KAFKA-12317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-12317:
Description:
Currently, for a stream-streams and stream-table/globalTable join
[
https://issues.apache.org/jira/browse/KAFKA-12317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-12317:
Labels: kip (was: )
> Relax non-null key requirement for left/outer KStream joins
>
[
https://issues.apache.org/jira/browse/KAFKA-12317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17752519#comment-17752519
]
Matthias J. Sax commented on KAFKA-12317:
-
Just catching on of comments...
{quote}KAFKA-12845 is
aindriu-aiven commented on code in PR #14159:
URL: https://github.com/apache/kafka/pull/14159#discussion_r1289206301
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/isolation/PluginScannerTest.java:
##
@@ -145,10 +148,28 @@ public void
mjsax commented on code in PR #14178:
URL: https://github.com/apache/kafka/pull/14178#discussion_r1289147669
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/ClientState.java:
##
@@ -505,4 +505,15 @@ private void assertNotAssigned(final TaskId
[
https://issues.apache.org/jira/browse/KAFKA-14831?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True resolved KAFKA-14831.
---
Resolution: Fixed
> Illegal state errors should be fatal in transactional producer
>
mumrah commented on code in PR #14083:
URL: https://github.com/apache/kafka/pull/14083#discussion_r1289141277
##
metadata/src/main/java/org/apache/kafka/controller/QuorumController.java:
##
@@ -1498,6 +1543,30 @@ private void cancelNextWriteNoOpRecord() {
[
https://issues.apache.org/jira/browse/KAFKA-15224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17752510#comment-17752510
]
Divij Vaidya commented on KAFKA-15224:
--
> can we include new python packages?
Sure. Currently the
lihaosky opened a new pull request, #14178:
URL: https://github.com/apache/kafka/pull/14178
## Description
Use rack aware assignor in `StickyTaskAssignor`. This PR is on top of
https://github.com/apache/kafka/pull/14164.
## Test
Update existing unit test
--
This is an
[
https://issues.apache.org/jira/browse/KAFKA-15224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17752504#comment-17752504
]
Tanay Karmarkar edited comment on KAFKA-15224 at 8/9/23 7:46 PM:
-
[
https://issues.apache.org/jira/browse/KAFKA-15224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17752504#comment-17752504
]
Tanay Karmarkar commented on KAFKA-15224:
-
Another clarification needed, in the example PR,
omkreddy commented on code in PR #14083:
URL: https://github.com/apache/kafka/pull/14083#discussion_r1289107179
##
core/src/main/scala/kafka/server/DelegationTokenManager.scala:
##
@@ -165,10 +112,11 @@ object DelegationTokenManager {
class DelegationTokenManager(val config:
[
https://issues.apache.org/jira/browse/KAFKA-15042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17752503#comment-17752503
]
Adrian Preston commented on KAFKA-15042:
[~smashingquasar],
Looking at the hex dump of your
omkreddy commented on code in PR #14083:
URL: https://github.com/apache/kafka/pull/14083#discussion_r1289096459
##
core/src/test/scala/integration/kafka/api/DelegationTokenEndToEndAuthorizationTest.scala:
##
@@ -145,12 +163,12 @@ class DelegationTokenEndToEndAuthorizationTest
gharris1727 commented on code in PR #14156:
URL: https://github.com/apache/kafka/pull/14156#discussion_r1289079347
##
connect/mirror/src/main/java/org/apache/kafka/connect/mirror/OffsetSyncStore.java:
##
@@ -227,7 +227,7 @@ private void clearSyncArray(OffsetSync[] syncs,
Lianet Magrans created KAFKA-15327:
--
Summary: Async consumer should commit offsets on close
Key: KAFKA-15327
URL: https://issues.apache.org/jira/browse/KAFKA-15327
Project: Kafka
Issue
gharris1727 commented on code in PR #14159:
URL: https://github.com/apache/kafka/pull/14159#discussion_r1289026069
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/isolation/PluginScannerTest.java:
##
@@ -145,10 +148,28 @@ public void
gharris1727 opened a new pull request, #14177:
URL: https://github.com/apache/kafka/pull/14177
The `Classloader.registerAsParallelCapable()` call is intended to be called
during static initialization. It must be called prior to the `Classloader`
superconstructor, because there it is
junrao commented on code in PR #14111:
URL: https://github.com/apache/kafka/pull/14111#discussion_r1288946333
##
clients/src/main/java/org/apache/kafka/clients/Metadata.java:
##
@@ -144,13 +159,25 @@ public long metadataExpireMs() {
*/
public synchronized int
divijvaidya commented on code in PR #14161:
URL: https://github.com/apache/kafka/pull/14161#discussion_r1288939068
##
core/src/main/scala/kafka/server/ConfigHandler.scala:
##
@@ -62,6 +62,12 @@ class TopicConfigHandler(private val logManager: LogManager,
kafkaConfig: KafkaC
divijvaidya commented on code in PR #14176:
URL: https://github.com/apache/kafka/pull/14176#discussion_r1288894765
##
storage/src/main/java/org/apache/kafka/storage/internals/log/LogConfig.java:
##
@@ -459,49 +463,53 @@ public static void validateValues(Map props) {
junrao commented on code in PR #13561:
URL: https://github.com/apache/kafka/pull/13561#discussion_r1287764297
##
core/src/main/scala/kafka/log/UnifiedLog.scala:
##
@@ -956,6 +981,15 @@ class UnifiedLog(@volatile var logStartOffset: Long,
}
}
+ private def
C0urante commented on code in PR #14156:
URL: https://github.com/apache/kafka/pull/14156#discussion_r1287870397
##
connect/mirror/src/main/java/org/apache/kafka/connect/mirror/OffsetSyncStore.java:
##
@@ -227,7 +227,7 @@ private void clearSyncArray(OffsetSync[] syncs,
cmccabe commented on code in PR #14169:
URL: https://github.com/apache/kafka/pull/14169#discussion_r1288918541
##
core/src/main/scala/kafka/server/metadata/AclPublisher.scala:
##
@@ -0,0 +1,99 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ *
[
https://issues.apache.org/jira/browse/KAFKA-15319?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-15319:
Priority: Critical (was: Major)
> Upgrade rocksdb to fix CVE-2022-37434
>
[
https://issues.apache.org/jira/browse/KAFKA-15319?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-15319:
Component/s: streams
> Upgrade rocksdb to fix CVE-2022-37434
>
gharris1727 commented on PR #14064:
URL: https://github.com/apache/kafka/pull/14064#issuecomment-1671793380
Looking forward at the `sync-manifests` implementation, I realized that I
had some duplication. The `ManifestEntry`, `findManifests` function, and the
exclude behavior I added in
OmniaGM commented on code in PR #13204:
URL: https://github.com/apache/kafka/pull/13204#discussion_r128079
##
tools/src/main/java/org/apache/kafka/tools/LeaderElectionCommand.java:
##
@@ -0,0 +1,378 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
OmniaGM commented on code in PR #13204:
URL: https://github.com/apache/kafka/pull/13204#discussion_r127858
##
tools/src/main/java/org/apache/kafka/tools/LeaderElectionCommand.java:
##
@@ -0,0 +1,378 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
OmniaGM commented on code in PR #13204:
URL: https://github.com/apache/kafka/pull/13204#discussion_r127595
##
tools/src/main/java/org/apache/kafka/tools/LeaderElectionCommand.java:
##
@@ -0,0 +1,378 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
OmniaGM commented on code in PR #13204:
URL: https://github.com/apache/kafka/pull/13204#discussion_r126617
##
tools/src/main/java/org/apache/kafka/tools/LeaderElectionCommand.java:
##
@@ -0,0 +1,378 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
OmniaGM commented on code in PR #13204:
URL: https://github.com/apache/kafka/pull/13204#discussion_r126278
##
tools/src/test/java/org/apache/kafka/tools/LeaderElectionCommandErrorTest.java:
##
@@ -0,0 +1,100 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
OmniaGM commented on code in PR #13204:
URL: https://github.com/apache/kafka/pull/13204#discussion_r1288877172
##
tools/src/main/java/org/apache/kafka/tools/LeaderElectionCommand.java:
##
@@ -0,0 +1,378 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
Lucas Brutschy created KAFKA-15326:
--
Summary: Decouple Processing Thread from Polling Thread
Key: KAFKA-15326
URL: https://issues.apache.org/jira/browse/KAFKA-15326
Project: Kafka
Issue
cmccabe commented on code in PR #14169:
URL: https://github.com/apache/kafka/pull/14169#discussion_r1288849218
##
metadata/src/main/java/org/apache/kafka/controller/AclControlManager.java:
##
@@ -256,11 +224,6 @@ public void replay(
throw new
cmccabe commented on code in PR #14169:
URL: https://github.com/apache/kafka/pull/14169#discussion_r1288848313
##
metadata/src/main/java/org/apache/kafka/controller/QuorumController.java:
##
@@ -1112,35 +1102,12 @@ private void appendRaftEvent(String name, Runnable
runnable) {
OmniaGM commented on code in PR #14082:
URL: https://github.com/apache/kafka/pull/14082#discussion_r1288843685
##
connect/mirror/src/test/java/org/apache/kafka/connect/mirror/integration/MirrorConnectorsIntegrationBaseTest.java:
##
@@ -406,7 +406,6 @@ public void
OmniaGM commented on code in PR #14082:
URL: https://github.com/apache/kafka/pull/14082#discussion_r1288843344
##
connect/mirror-client/src/main/java/org/apache/kafka/connect/mirror/DefaultReplicationPolicy.java:
##
@@ -43,6 +47,11 @@ public void configure(Map props) {
OmniaGM commented on code in PR #14082:
URL: https://github.com/apache/kafka/pull/14082#discussion_r1288843014
##
connect/mirror/src/test/java/org/apache/kafka/connect/mirror/integration/DefaultReplicationIntegrationTest.java:
##
@@ -0,0 +1,324 @@
+/*
Review Comment:
I
[
https://issues.apache.org/jira/browse/KAFKA-15298?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christo Lolov resolved KAFKA-15298.
---
Resolution: Won't Fix
> Disable DeleteRecords on Tiered Storage topics
>
[
https://issues.apache.org/jira/browse/KAFKA-15302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17752451#comment-17752451
]
Jinyong Choi commented on KAFKA-15302:
--
[~mjsax] , [~guozhang]
If you perform a delete() within
kamalcph commented on code in PR #14114:
URL: https://github.com/apache/kafka/pull/14114#discussion_r1288729452
##
storage/src/main/java/org/apache/kafka/storage/internals/log/LogConfig.java:
##
@@ -102,49 +102,14 @@ public String topicWarningMessage(String topicName) {
kamalcph opened a new pull request, #14176:
URL: https://github.com/apache/kafka/pull/14176
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of
[
https://issues.apache.org/jira/browse/KAFKA-15100?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
José Armando García Sancio resolved KAFKA-15100.
Resolution: Fixed
> Unsafe to call tryCompleteFetchResponse on
[
https://issues.apache.org/jira/browse/KAFKA-15100?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
José Armando García Sancio updated KAFKA-15100:
---
Fix Version/s: 3.4.2
> Unsafe to call tryCompleteFetchResponse on
jeqo commented on code in PR #14127:
URL: https://github.com/apache/kafka/pull/14127#discussion_r1288620620
##
storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/ConsumerTask.java:
##
@@ -64,302 +65,393 @@
class ConsumerTask implements Runnable,
vveicc commented on PR #14175:
URL: https://github.com/apache/kafka/pull/14175#issuecomment-1671596827
Thank you for your advice @dengziming, this is very helpful to me. I have
made some changes, PTAL.
--
This is an automated message from the Apache Git Service.
To respond to the
clolov commented on code in PR #14136:
URL: https://github.com/apache/kafka/pull/14136#discussion_r1288687969
##
core/src/main/java/kafka/log/remote/RemoteLogManager.java:
##
@@ -347,15 +353,16 @@ public void onLeadershipChange(Set
partitionsBecomeLeader,
public void
[
https://issues.apache.org/jira/browse/KAFKA-15100?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
José Armando García Sancio updated KAFKA-15100:
---
Fix Version/s: 3.5.2
> Unsafe to call tryCompleteFetchResponse on
AndrewJSchofield commented on code in PR #14111:
URL: https://github.com/apache/kafka/pull/14111#discussion_r1288667079
##
clients/src/main/java/org/apache/kafka/clients/Metadata.java:
##
@@ -119,20 +130,24 @@ public synchronized Cluster fetch() {
* @return remaining time
clolov commented on code in PR #14127:
URL: https://github.com/apache/kafka/pull/14127#discussion_r1288608136
##
storage/src/test/java/org/apache/kafka/server/log/remote/metadata/storage/TopicBasedRemoteLogMetadataManagerMultipleSubscriptionsTest.java:
##
@@ -0,0 +1,176 @@
+/*
jeffkbkim commented on PR #14124:
URL: https://github.com/apache/kafka/pull/14124#issuecomment-1671432782
Thanks @riedelmax!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
jsancio merged PR #14141:
URL: https://github.com/apache/kafka/pull/14141
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
prestona commented on PR #14173:
URL: https://github.com/apache/kafka/pull/14173#issuecomment-1671409792
For context, any API message description that has a TAG_BUFFER field will be
changed as follows
https://github.com/apache/kafka/assets/10883734/108fd5a9-cf6c-4698-8311-ea6845bf7886;>
divijvaidya commented on PR #14168:
URL: https://github.com/apache/kafka/pull/14168#issuecomment-1671384884
Wow! This is news to me. BTW there is a JIRA tracking this test failure at
https://issues.apache.org/jira/browse/KAFKA-15052 and you might want to
associate this PR with that JIRA.
mumrah commented on code in PR #14169:
URL: https://github.com/apache/kafka/pull/14169#discussion_r1288505525
##
metadata/src/main/java/org/apache/kafka/controller/AclControlManager.java:
##
@@ -256,11 +224,6 @@ public void replay(
throw new
dengziming commented on code in PR #14175:
URL: https://github.com/apache/kafka/pull/14175#discussion_r1288503732
##
core/src/test/scala/integration/kafka/admin/BrokerApiVersionsCommandTest.scala:
##
@@ -56,21 +66,30 @@ class BrokerApiVersionsCommandTest extends
Lianet Magrans created KAFKA-15325:
--
Summary: Integrate topicId in OffsetFetch and OffsetCommit async
consumer calls
Key: KAFKA-15325
URL: https://issues.apache.org/jira/browse/KAFKA-15325
Project:
kamalcph commented on code in PR #14161:
URL: https://github.com/apache/kafka/pull/14161#discussion_r1288449342
##
core/src/main/scala/kafka/server/ConfigHandler.scala:
##
@@ -62,6 +62,12 @@ class TopicConfigHandler(private val logManager: LogManager,
kafkaConfig: KafkaC
[
https://issues.apache.org/jira/browse/KAFKA-15295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kamal Chandraprakash reassigned KAFKA-15295:
Assignee: Kamal Chandraprakash (was: Luke Chen)
> Add config validation
nizhikov commented on code in PR #14172:
URL: https://github.com/apache/kafka/pull/14172#discussion_r1288443925
##
tools/src/main/java/org/apache/kafka/tools/reassign/ActiveMoveState.java:
##
@@ -0,0 +1,60 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
[
https://issues.apache.org/jira/browse/KAFKA-12317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17752407#comment-17752407
]
Florin Akermann commented on KAFKA-12317:
-
Drafted a PR:
vveicc opened a new pull request, #14175:
URL: https://github.com/apache/kafka/pull/14175
Change BrokerApiVersionsCommandTest to support kraft mode.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI
yashmayya commented on code in PR #14102:
URL: https://github.com/apache/kafka/pull/14102#discussion_r1288239604
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/distributed/DistributedHerderTest.java:
##
@@ -3724,62 +2818,54 @@ public void
florin-akermann opened a new pull request, #14174:
URL: https://github.com/apache/kafka/pull/14174
https://cwiki.apache.org/confluence/display/KAFKA/KIP-962%3A+Relax+non-null+key+requirement+in+Kafka+Streams
Test Strategy:
Basic tests on minimal topologies with call to
mimaison commented on code in PR #14172:
URL: https://github.com/apache/kafka/pull/14172#discussion_r1288390063
##
tools/src/main/java/org/apache/kafka/tools/reassign/ActiveMoveState.java:
##
@@ -0,0 +1,60 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
[
https://issues.apache.org/jira/browse/KAFKA-15172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17752398#comment-17752398
]
hudeqi commented on KAFKA-15172:
Hi, I have initiated a kip discussion:
riedelmax commented on PR #14124:
URL: https://github.com/apache/kafka/pull/14124#issuecomment-1671187508
I will find time in the next days to fix those.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
[
https://issues.apache.org/jira/browse/KAFKA-15259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17752396#comment-17752396
]
Tomonari Yamashita commented on KAFKA-15259:
My opinion is neutral on whether it should be
divijvaidya commented on PR #14153:
URL: https://github.com/apache/kafka/pull/14153#issuecomment-1671124312
Thank you for reviewing @yashmayya. The CI is still flaky with large number
of failures and I am restarting it.
--
This is an automated message from the Apache Git Service.
To
divijvaidya commented on code in PR #14161:
URL: https://github.com/apache/kafka/pull/14161#discussion_r1288309828
##
core/src/main/scala/kafka/server/ConfigHandler.scala:
##
@@ -62,6 +62,12 @@ class TopicConfigHandler(private val logManager: LogManager,
kafkaConfig: KafkaC
1 - 100 of 124 matches
Mail list logo
