mehbey commented on code in PR #14135:
URL: https://github.com/apache/kafka/pull/14135#discussion_r1290912365
##
core/src/test/scala/integration/kafka/api/PlaintextProducerSendTest.scala:
##
@@ -120,17 +121,17 @@ class PlaintextProducerSendTest extends
BaseProducerSendTest {
mehbey commented on code in PR #14135:
URL: https://github.com/apache/kafka/pull/14135#discussion_r1290912365
##
core/src/test/scala/integration/kafka/api/PlaintextProducerSendTest.scala:
##
@@ -120,17 +121,17 @@ class PlaintextProducerSendTest extends
BaseProducerSendTest {
mehbey commented on PR #14135:
URL: https://github.com/apache/kafka/pull/14135#issuecomment-1674232688
> Whenever we are making customer facing changes (adding new config in this
scenario), we usually mention it in upgrade notes at
>
>
[
https://issues.apache.org/jira/browse/KAFKA-10875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17753049#comment-17753049
]
Kong Yin Lai edited comment on KAFKA-10875 at 8/11/23 5:14 AM:
---
We are
[
https://issues.apache.org/jira/browse/KAFKA-10875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17753049#comment-17753049
]
Kong Yin Lai commented on KAFKA-10875:
--
We are also seeing something that looks a lot like this
bachmanity1 commented on PR #14190:
URL: https://github.com/apache/kafka/pull/14190#issuecomment-1674220529
@cadonna @divijvaidya can you please review this? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
bachmanity1 opened a new pull request, #14190:
URL: https://github.com/apache/kafka/pull/14190
Replace Easymock & Powermock with Mockito in
RocksDBMetricsRecorderGaugesTest.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ]
bachmanity1 commented on PR #14189:
URL: https://github.com/apache/kafka/pull/14189#issuecomment-1674210277
@cadonna @mjsax @C0urante can you please review this PR? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
bachmanity1 opened a new pull request, #14189:
URL: https://github.com/apache/kafka/pull/14189
Replace Easymock & Powermock with Mockito in TableSourceNodeTest
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test
C0urante commented on PR #14177:
URL: https://github.com/apache/kafka/pull/14177#issuecomment-1674205775
Changes seems fine, but CI results are a little worrying. Nothing directly
tied to this PR on the surface, but I've kicked off another build just to be
safe.
--
This is an automated
C0urante commented on PR #14186:
URL: https://github.com/apache/kafka/pull/14186#issuecomment-1674202980
@divijvaidya given that this touches on the strict stubbing feature that
you've helped introduce to our tests, would you be interested in reviewing?
@mumrah @ijuma based on
rreddy-22 commented on code in PR #14182:
URL: https://github.com/apache/kafka/pull/14182#discussion_r1290880628
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/OptimizedUniformAssignor.java:
##
@@ -0,0 +1,396 @@
+/*
+ * Licensed to the Apache
rreddy-22 commented on code in PR #14182:
URL: https://github.com/apache/kafka/pull/14182#discussion_r1290880471
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/OptimizedUniformAssignor.java:
##
@@ -0,0 +1,396 @@
+/*
+ * Licensed to the Apache
C0urante commented on PR #14186:
URL: https://github.com/apache/kafka/pull/14186#issuecomment-1674193833
As we can see with the [CI results for the first
build](https://ci-builds.apache.org/blue/organizations/jenkins/Kafka%2Fkafka-pr/detail/PR-14186/1/tests),
unused stubbings were
[
https://issues.apache.org/jira/browse/KAFKA-15083?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Luke Chen updated KAFKA-15083:
--
Description:
Based on the
showuon merged PR #14151:
URL: https://github.com/apache/kafka/pull/14151
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/KAFKA-15083?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Luke Chen updated KAFKA-15083:
--
Description:
Based on the
showuon commented on PR #14151:
URL: https://github.com/apache/kafka/pull/14151#issuecomment-1674147451
Failed tests are unrelated:
```
Build / JDK 11 and Scala 2.13 /
showuon merged PR #14121:
URL: https://github.com/apache/kafka/pull/14121
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
showuon commented on PR #14121:
URL: https://github.com/apache/kafka/pull/14121#issuecomment-1674146055
Failed tests are unrelated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
[
https://issues.apache.org/jira/browse/KAFKA-15289?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Deng Ziming updated KAFKA-15289:
Description: we are calling `zkBrokerApis` in , we should ensure kraft
broker apis are also
[
https://issues.apache.org/jira/browse/KAFKA-15289?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Deng Ziming updated KAFKA-15289:
Description: we are calling `zkBrokerApis` in RequestQuotaTest, we should
ensure kraft broker
[
https://issues.apache.org/jira/browse/KAFKA-15289?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Deng Ziming updated KAFKA-15289:
Summary: Support KRaft mode in RequestQuotaTest (was: Use
zkBrokerApis.clientApis instead of
[
https://issues.apache.org/jira/browse/KAFKA-15287?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Deng Ziming resolved KAFKA-15287.
-
Resolution: Fixed
> Change NodeApiVersions.create() to contains both apis of zk and kraft
dengziming merged PR #14185:
URL: https://github.com/apache/kafka/pull/14185
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/KAFKA-14132?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nelson Bighetti updated KAFKA-14132:
Description:
{color:#de350b}Some of the tests below use EasyMock as well. For those
[
https://issues.apache.org/jira/browse/KAFKA-14132?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nelson Bighetti updated KAFKA-14132:
Description:
{color:#de350b}Some of the tests below use EasyMock as well. For those
jeffkbkim commented on code in PR #14182:
URL: https://github.com/apache/kafka/pull/14182#discussion_r1290813753
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/OptimizedUniformAssignor.java:
##
@@ -0,0 +1,396 @@
+/*
+ * Licensed to the Apache
jeffkbkim commented on code in PR #14182:
URL: https://github.com/apache/kafka/pull/14182#discussion_r1290813322
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/OptimizedUniformAssignor.java:
##
@@ -0,0 +1,396 @@
+/*
+ * Licensed to the Apache
gharris1727 merged PR #14188:
URL: https://github.com/apache/kafka/pull/14188
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
gharris1727 opened a new pull request, #14188:
URL: https://github.com/apache/kafka/pull/14188
#14092 broke checkstyle due to the package name changing.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and
[
https://issues.apache.org/jira/browse/KAFKA-14598?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Greg Harris reopened KAFKA-14598:
-
Assignee: (was: Ashwin Pankaj)
> Fix flaky ConnectRestApiTest
>
rreddy-22 commented on code in PR #14182:
URL: https://github.com/apache/kafka/pull/14182#discussion_r1290766391
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/OptimizedUniformAssignor.java:
##
@@ -0,0 +1,396 @@
+/*
+ * Licensed to the Apache
rreddy-22 commented on code in PR #14182:
URL: https://github.com/apache/kafka/pull/14182#discussion_r1290765488
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/OptimizedUniformAssignor.java:
##
@@ -0,0 +1,396 @@
+/*
+ * Licensed to the Apache
junrao commented on code in PR #14111:
URL: https://github.com/apache/kafka/pull/14111#discussion_r1290474356
##
clients/src/main/java/org/apache/kafka/clients/Metadata.java:
##
@@ -140,17 +167,30 @@ public long metadataExpireMs() {
}
/**
- * Request an update
rreddy-22 commented on code in PR #14182:
URL: https://github.com/apache/kafka/pull/14182#discussion_r1290764909
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/OptimizedUniformAssignor.java:
##
@@ -0,0 +1,396 @@
+/*
+ * Licensed to the Apache
rreddy-22 commented on code in PR #14182:
URL: https://github.com/apache/kafka/pull/14182#discussion_r1290763624
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/OptimizedUniformAssignor.java:
##
@@ -0,0 +1,396 @@
+/*
+ * Licensed to the Apache
rreddy-22 commented on code in PR #14182:
URL: https://github.com/apache/kafka/pull/14182#discussion_r1290763071
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/OptimizedUniformAssignor.java:
##
@@ -0,0 +1,396 @@
+/*
+ * Licensed to the Apache
philipnee commented on PR #14179:
URL: https://github.com/apache/kafka/pull/14179#issuecomment-1674034799
@junrao - This minor PR fixes a small bug in the commit request manager.
Would you be able to review it?
--
This is an automated message from the Apache Git Service.
To respond to
philipnee commented on PR #14179:
URL: https://github.com/apache/kafka/pull/14179#issuecomment-1674034179
Here are the failing flaky tests.
```
Build / JDK 17 and Scala 2.13 / testOffsetTranslationBehindReplicationFlow()
–
mjsax commented on code in PR #14187:
URL: https://github.com/apache/kafka/pull/14187#discussion_r1290758646
##
streams/src/main/java/org/apache/kafka/streams/kstream/KStream.java:
##
@@ -2805,7 +2805,7 @@ KStream leftJoin(final KTable
table,
* For each {@code KStream}
[
https://issues.apache.org/jira/browse/KAFKA-13197?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-13197:
Component/s: documentation
streams
> KStream-GlobalKTable join semantics
gharris1727 commented on PR #14092:
URL: https://github.com/apache/kafka/pull/14092#issuecomment-1673942664
Thank you @fvaleri for diagnosing this test regression and promptly fixing
it!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
[
https://issues.apache.org/jira/browse/KAFKA-15239?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Greg Harris resolved KAFKA-15239.
-
Fix Version/s: 3.6.0
Reviewer: Greg Harris
Resolution: Fixed
>
gharris1727 merged PR #14092:
URL: https://github.com/apache/kafka/pull/14092
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/KAFKA-15202?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Greg Harris updated KAFKA-15202:
Affects Version/s: 3.5.1
(was: 3.3.3)
> MM2 OffsetSyncStore clears too
[
https://issues.apache.org/jira/browse/KAFKA-15202?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Greg Harris updated KAFKA-15202:
Fix Version/s: 3.3.3
3.4.2
3.5.2
> MM2 OffsetSyncStore
[
https://issues.apache.org/jira/browse/KAFKA-13187?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Egerton resolved KAFKA-13187.
---
Fix Version/s: 3.6.0
Resolution: Done
> Replace EasyMock and PowerMock with Mockito
C0urante merged PR #14102:
URL: https://github.com/apache/kafka/pull/14102
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
C0urante commented on PR #14102:
URL: https://github.com/apache/kafka/pull/14102#issuecomment-1673896029
I should note that because this test makes heavy use of Mockito's strict
stubbing feature, I've opened https://github.com/apache/kafka/pull/14186 to
enable reporting of unused stubbings
C0urante commented on code in PR #14102:
URL: https://github.com/apache/kafka/pull/14102#discussion_r1290658873
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/distributed/DistributedHerderTest.java:
##
@@ -3872,7 +2952,7 @@ public void
C0urante commented on code in PR #14102:
URL: https://github.com/apache/kafka/pull/14102#discussion_r1290659476
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/distributed/DistributedHerderTest.java:
##
@@ -3929,543 +3008,636 @@ public void
rittikaadhikari commented on PR #13503:
URL: https://github.com/apache/kafka/pull/13503#issuecomment-1673867152
@junrao Thanks for the review! I have addressed the comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
gharris1727 merged PR #14156:
URL: https://github.com/apache/kafka/pull/14156
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
gharris1727 commented on PR #14156:
URL: https://github.com/apache/kafka/pull/14156#issuecomment-1673861990
The latest CI run has some unrelated flakiness, and tests pass locally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
C0urante commented on code in PR #14082:
URL: https://github.com/apache/kafka/pull/14082#discussion_r1290641476
##
connect/mirror-client/src/main/java/org/apache/kafka/connect/mirror/DefaultReplicationPolicy.java:
##
@@ -43,6 +47,11 @@ public void configure(Map props) {
gharris1727 commented on PR #14156:
URL: https://github.com/apache/kafka/pull/14156#issuecomment-1673859231
I saw one of the CI builds with testOffsetTranslationBehindReplicationFlow
failing, so I think there is still another source of flakiness somewhere. I'll
close the fix JIRA but leave
jeffkbkim commented on code in PR #14182:
URL: https://github.com/apache/kafka/pull/14182#discussion_r1290585581
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/OptimizedUniformAssignor.java:
##
@@ -0,0 +1,396 @@
+/*
+ * Licensed to the Apache
C0urante commented on code in PR #14068:
URL: https://github.com/apache/kafka/pull/14068#discussion_r1290629836
##
docs/connect.html:
##
@@ -543,6 +543,67 @@ ACL requirements
+Plugin
Discovery
+
+Plugin discovery is the name for the strategy which the
C0urante commented on code in PR #14068:
URL: https://github.com/apache/kafka/pull/14068#discussion_r1290627899
##
docs/connect.html:
##
@@ -543,6 +543,67 @@ ACL requirements
+Plugin
Discovery
+
+Plugin discovery is the name for the strategy which the
C0urante commented on code in PR #14068:
URL: https://github.com/apache/kafka/pull/14068#discussion_r1290624547
##
docs/connect.html:
##
@@ -543,6 +543,67 @@ ACL requirements
+Plugin
Discovery
+
+Plugin discovery is the name for the strategy which the
gharris1727 commented on code in PR #14064:
URL: https://github.com/apache/kafka/pull/14064#discussion_r1290624348
##
tools/src/main/java/org/apache/kafka/tools/ConnectPluginPath.java:
##
@@ -0,0 +1,559 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
gharris1727 commented on PR #14064:
URL: https://github.com/apache/kafka/pull/14064#issuecomment-1673833354
> We may choose to report broken plugin locations (i.e., any that has one or
more unloadable plugins), but IMO it's better to leave this info out entirely.
We have room to maneuver
florin-akermann opened a new pull request, #14187:
URL: https://github.com/apache/kafka/pull/14187
The documentation for join/left-join Kstream-GlobalKtable is out dated: The
left hand side key may be null.
Note that the second statement mentioned in the Jira
C0urante commented on code in PR #14068:
URL: https://github.com/apache/kafka/pull/14068#discussion_r1290620328
##
docs/connect.html:
##
@@ -543,6 +543,67 @@ ACL requirements
+Plugin
Discovery
+
+Plugin discovery is the name for the strategy which the
mjsax commented on code in PR #14103:
URL: https://github.com/apache/kafka/pull/14103#discussion_r1290589930
##
clients/src/main/java/org/apache/kafka/common/config/ConfigDef.java:
##
@@ -947,9 +947,15 @@ public String toString() {
}
public static class ValidString
kirktrue commented on PR #14156:
URL: https://github.com/apache/kafka/pull/14156#issuecomment-1673817790
@gharris1727 Thanks for your work on this! Hopefully it will help
KAFKA-15197 too!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
kirktrue commented on PR #13908:
URL: https://github.com/apache/kafka/pull/13908#issuecomment-1673815636
@divijvaidya Can you review this with an eye to merging it? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
gharris1727 commented on PR #14092:
URL: https://github.com/apache/kafka/pull/14092#issuecomment-1673813076
System test failures appear to be due to reasons other than
classloading/dependency issues. The producer performance tests appear to work
normally.
```
C0urante commented on code in PR #14064:
URL: https://github.com/apache/kafka/pull/14064#discussion_r1290570863
##
tools/src/main/java/org/apache/kafka/tools/ConnectPluginPath.java:
##
@@ -0,0 +1,559 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
mjsax commented on code in PR #14103:
URL: https://github.com/apache/kafka/pull/14103#discussion_r1290575646
##
clients/src/main/java/org/apache/kafka/common/config/ConfigDef.java:
##
@@ -947,9 +947,15 @@ public String toString() {
}
public static class ValidString
mjsax commented on code in PR #14103:
URL: https://github.com/apache/kafka/pull/14103#discussion_r1290575646
##
clients/src/main/java/org/apache/kafka/common/config/ConfigDef.java:
##
@@ -947,9 +947,15 @@ public String toString() {
}
public static class ValidString
mjsax commented on code in PR #14103:
URL: https://github.com/apache/kafka/pull/14103#discussion_r1290575646
##
clients/src/main/java/org/apache/kafka/common/config/ConfigDef.java:
##
@@ -947,9 +947,15 @@ public String toString() {
}
public static class ValidString
mjsax commented on code in PR #14103:
URL: https://github.com/apache/kafka/pull/14103#discussion_r1290575646
##
clients/src/main/java/org/apache/kafka/common/config/ConfigDef.java:
##
@@ -947,9 +947,15 @@ public String toString() {
}
public static class ValidString
mjsax commented on code in PR #14103:
URL: https://github.com/apache/kafka/pull/14103#discussion_r1290555860
##
clients/src/main/java/org/apache/kafka/common/config/ConfigDef.java:
##
@@ -947,9 +947,15 @@ public String toString() {
}
public static class ValidString
mjsax commented on code in PR #14103:
URL: https://github.com/apache/kafka/pull/14103#discussion_r1290555860
##
clients/src/main/java/org/apache/kafka/common/config/ConfigDef.java:
##
@@ -947,9 +947,15 @@ public String toString() {
}
public static class ValidString
mjsax commented on code in PR #14103:
URL: https://github.com/apache/kafka/pull/14103#discussion_r1290555860
##
clients/src/main/java/org/apache/kafka/common/config/ConfigDef.java:
##
@@ -947,9 +947,15 @@ public String toString() {
}
public static class ValidString
Philip Nee created KAFKA-15333:
--
Summary: Flaky build failure throwing Connect Exception: Could not
connect to server
Key: KAFKA-15333
URL: https://issues.apache.org/jira/browse/KAFKA-15333
Project:
jolshan commented on code in PR #14138:
URL: https://github.com/apache/kafka/pull/14138#discussion_r1290546194
##
core/src/main/scala/kafka/cluster/Partition.scala:
##
@@ -798,6 +803,12 @@ class Partition(val topicPartition: TopicPartition,
// to maintain the decision
C0urante commented on PR #14186:
URL: https://github.com/apache/kafka/pull/14186#issuecomment-1673671924
I've opened this as a draft request to demonstrate that unused stubbings
will be successfully reported with the proposed change to the Jenkinsfile. Once
the build fails successfully
mjsax commented on code in PR #14181:
URL: https://github.com/apache/kafka/pull/14181#discussion_r1290483692
##
docs/streams/developer-guide/config-streams.html:
##
@@ -685,6 +688,45 @@ default.windowed.value.serde.innerThis is discussed in more detail in Data types and
cmccabe merged PR #14050:
URL: https://github.com/apache/kafka/pull/14050
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
mjsax commented on code in PR #14181:
URL: https://github.com/apache/kafka/pull/14181#discussion_r1290482358
##
docs/streams/developer-guide/config-streams.html:
##
@@ -685,6 +688,45 @@ default.windowed.value.serde.innerThis is discussed in more detail in Data types and
C0urante opened a new pull request, #14186:
URL: https://github.com/apache/kafka/pull/14186
[Jira](https://issues.apache.org/jira/browse/KAFKA-14682)
Our Jenkinsfile is currently configured to do testing with the `unitTest`
and `integrationTest` tasks, instead of the `test` task.
Calvin Liu created KAFKA-15332:
--
Summary: Eligible Leader Replicas
Key: KAFKA-15332
URL: https://issues.apache.org/jira/browse/KAFKA-15332
Project: Kafka
Issue Type: New Feature
mjsax commented on code in PR #14181:
URL: https://github.com/apache/kafka/pull/14181#discussion_r1290485321
##
docs/streams/developer-guide/config-streams.html:
##
@@ -685,6 +688,45 @@ default.windowed.value.serde.innerThis is discussed in more detail in Data types and
mjsax commented on code in PR #14181:
URL: https://github.com/apache/kafka/pull/14181#discussion_r1290489521
##
docs/streams/developer-guide/config-streams.html:
##
@@ -718,6 +760,24 @@ rack.aware.assignment.tags
+rack.aware.assignment.traffic_cost
+
+
mjsax commented on code in PR #14181:
URL: https://github.com/apache/kafka/pull/14181#discussion_r1290483313
##
docs/streams/developer-guide/config-streams.html:
##
@@ -685,6 +688,45 @@ default.windowed.value.serde.innerThis is discussed in more detail in Data types and
mjsax commented on code in PR #14181:
URL: https://github.com/apache/kafka/pull/14181#discussion_r1290445751
##
docs/streams/architecture.html:
##
@@ -167,6 +167,14 @@ Kafka
Streams Developer Guide section.
+
+There is also a client side config client.rack
mjsax commented on code in PR #14181:
URL: https://github.com/apache/kafka/pull/14181#discussion_r1290489338
##
docs/streams/developer-guide/config-streams.html:
##
@@ -718,6 +760,24 @@ rack.aware.assignment.tags
+rack.aware.assignment.traffic_cost
+
+
mjsax commented on code in PR #14181:
URL: https://github.com/apache/kafka/pull/14181#discussion_r1290445388
##
docs/streams/architecture.html:
##
@@ -167,6 +167,14 @@ Kafka
Streams Developer Guide section.
+
+There is also a client side config client.rack
mjsax commented on code in PR #14181:
URL: https://github.com/apache/kafka/pull/14181#discussion_r1290486200
##
docs/streams/developer-guide/config-streams.html:
##
@@ -685,6 +688,45 @@ default.windowed.value.serde.innerThis is discussed in more detail in Data types and
gharris1727 merged PR #14159:
URL: https://github.com/apache/kafka/pull/14159
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/KAFKA-15291?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Greg Harris resolved KAFKA-15291.
-
Resolution: Fixed
> Implement Versioned interfaces in common Connect plugins
>
gharris1727 commented on PR #14159:
URL: https://github.com/apache/kafka/pull/14159#issuecomment-1673635408
Flaky test failures appear unrelated, and tests pass locally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
mimaison commented on code in PR #13204:
URL: https://github.com/apache/kafka/pull/13204#discussion_r1290277580
##
tools/src/test/java/org/apache/kafka/tools/LeaderElectionCommandTest.java:
##
@@ -0,0 +1,329 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
kamalcph commented on code in PR #13947:
URL: https://github.com/apache/kafka/pull/13947#discussion_r1290377829
##
core/src/main/java/kafka/log/remote/RemoteLogManager.java:
##
@@ -343,21 +345,78 @@ public void onLeadershipChange(Set
partitionsBecomeLeader,
/**
*
kamalcph commented on code in PR #13947:
URL: https://github.com/apache/kafka/pull/13947#discussion_r1290376710
##
core/src/main/java/kafka/log/remote/RemoteLogManager.java:
##
@@ -343,21 +345,78 @@ public void onLeadershipChange(Set
partitionsBecomeLeader,
/**
*
kamalcph commented on code in PR #13947:
URL: https://github.com/apache/kafka/pull/13947#discussion_r1290369199
##
core/src/main/java/kafka/log/remote/RemoteLogManager.java:
##
@@ -343,21 +345,78 @@ public void onLeadershipChange(Set
partitionsBecomeLeader,
/**
*
kamalcph commented on code in PR #13947:
URL: https://github.com/apache/kafka/pull/13947#discussion_r1290366372
##
core/src/main/scala/kafka/server/ReplicaManager.scala:
##
@@ -558,17 +574,38 @@ class ReplicaManager(val config: KafkaConfig,
}
1 - 100 of 150 matches
Mail list logo
