C0urante commented on PR #13981:
URL: https://github.com/apache/kafka/pull/13981#issuecomment-1675709706
@hijker FYI, we do not add new features to older branches except under
extremely rare circumstances. Can you re-target this PR at the `trunk` branch
(rebasing if necessary to resolve
stevenbooke commented on code in PR #13842:
URL: https://github.com/apache/kafka/pull/13842#discussion_r1291838865
##
refresh-collaborators.py:
##
@@ -59,9 +64,20 @@
yaml_content["github"]["collaborators"] = collaborators
# Convert the updated content back to YAML
lihaosky opened a new pull request, #14198:
URL: https://github.com/apache/kafka/pull/14198
If we use a number, even there's no path from source to u and v, it can be
relaxed still which is wrong.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and
[
https://issues.apache.org/jira/browse/KAFKA-13197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17753349#comment-17753349
]
Florin Akermann commented on KAFKA-13197:
-
[~twbecker], thanks for raising this. The
junrao merged PR #13503:
URL: https://github.com/apache/kafka/pull/13503
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
junrao commented on code in PR #13947:
URL: https://github.com/apache/kafka/pull/13947#discussion_r1291773207
##
core/src/main/scala/kafka/server/ReplicaManager.scala:
##
@@ -2418,7 +2449,15 @@ class ReplicaManager(val config: KafkaConfig,
// Handle deleted partitions.
lihaosky opened a new pull request, #14196:
URL: https://github.com/apache/kafka/pull/14196
Fix test. They were passing previously before `maxCapacity` and
`partitionSize` have same value
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
junrao merged PR #14123:
URL: https://github.com/apache/kafka/pull/14123
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
C0urante commented on code in PR #14194:
URL: https://github.com/apache/kafka/pull/14194#discussion_r1291736381
##
connect/api/src/main/java/org/apache/kafka/connect/sink/SinkConnector.java:
##
@@ -23,6 +23,9 @@
/**
* SinkConnectors implement the Connector interface to
C0urante commented on PR #14191:
URL: https://github.com/apache/kafka/pull/14191#issuecomment-1675305377
A few extra thoughts:
- We may be unearthing fundamental limitations with the static `Exit` API if
we can't cleanly/easily force testing-only clusters to not invoke
rreddy-22 commented on code in PR #14182:
URL: https://github.com/apache/kafka/pull/14182#discussion_r1291732541
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/OptimizedUniformAssignor.java:
##
@@ -0,0 +1,396 @@
+/*
+ * Licensed to the Apache
gharris1727 opened a new pull request, #14195:
URL: https://github.com/apache/kafka/pull/14195
This is the secondary component of KIP-898, a command to migrate released
artifacts to include ServiceLoader manifests.
In order to provide dry-run functionality and to reduce the number of
rreddy-22 commented on code in PR #14182:
URL: https://github.com/apache/kafka/pull/14182#discussion_r1291731843
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/OptimizedUniformAssignor.java:
##
@@ -0,0 +1,396 @@
+/*
+ * Licensed to the Apache
junrao commented on code in PR #13561:
URL: https://github.com/apache/kafka/pull/13561#discussion_r1291690729
##
core/src/main/scala/kafka/log/UnifiedLog.scala:
##
@@ -1390,7 +1424,15 @@ class UnifiedLog(@volatile var logStartOffset: Long,
private def
gharris1727 merged PR #14064:
URL: https://github.com/apache/kafka/pull/14064
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
gharris1727 commented on PR #14064:
URL: https://github.com/apache/kafka/pull/14064#issuecomment-1675237095
CI failures appear unrelated, and the tests pass locally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
[
https://issues.apache.org/jira/browse/KAFKA-13197?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax resolved KAFKA-13197.
-
Fix Version/s: 3.6.0
3.5.2
Resolution: Fixed
>
mjsax commented on PR #14187:
URL: https://github.com/apache/kafka/pull/14187#issuecomment-1675218688
Thanks for the PR! Merged to ` trunk` and cherry-picked to `3.5` branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
mjsax merged PR #14187:
URL: https://github.com/apache/kafka/pull/14187
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/KAFKA-15026?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Hao Li reassigned KAFKA-15026:
--
Assignee: Hao Li
> Implement min-cost flow balancing tasks for same subtopology
>
[
https://issues.apache.org/jira/browse/KAFKA-15054?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Hao Li reassigned KAFKA-15054:
--
Assignee: Hao Li
> Add configs and logic to decide if rack aware assignment should be enabled
>
[
https://issues.apache.org/jira/browse/KAFKA-15024?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Hao Li reassigned KAFKA-15024:
--
Assignee: Hao Li
> Add cost function for task/client
> -
>
>
[
https://issues.apache.org/jira/browse/KAFKA-15025?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Hao Li closed KAFKA-15025.
--
> Implement min-cost flow without balancing tasks for same subtopology
>
[
https://issues.apache.org/jira/browse/KAFKA-15025?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Hao Li resolved KAFKA-15025.
Fix Version/s: 3.6.0
Resolution: Fixed
> Implement min-cost flow without balancing tasks for same
[
https://issues.apache.org/jira/browse/KAFKA-15054?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Hao Li closed KAFKA-15054.
--
> Add configs and logic to decide if rack aware assignment should be enabled
>
[
https://issues.apache.org/jira/browse/KAFKA-15054?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Hao Li resolved KAFKA-15054.
Fix Version/s: 3.6.0
Resolution: Fixed
> Add configs and logic to decide if rack aware assignment
mjsax merged PR #14181:
URL: https://github.com/apache/kafka/pull/14181
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/KAFKA-15025?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Hao Li reassigned KAFKA-15025:
--
Assignee: Hao Li
> Implement min-cost flow without balancing tasks for same subtopology
>
[
https://issues.apache.org/jira/browse/KAFKA-15024?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Hao Li closed KAFKA-15024.
--
> Add cost function for task/client
> -
>
> Key: KAFKA-15024
>
[
https://issues.apache.org/jira/browse/KAFKA-15024?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Hao Li resolved KAFKA-15024.
Fix Version/s: 3.6.0
Resolution: Fixed
> Add cost function for task/client
>
[
https://issues.apache.org/jira/browse/KAFKA-15027?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Hao Li closed KAFKA-15027.
--
> Implement rack aware assignment for standby tasks
> -
>
>
[
https://issues.apache.org/jira/browse/KAFKA-15027?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Hao Li resolved KAFKA-15027.
Fix Version/s: 3.6.0
Resolution: Fixed
> Implement rack aware assignment for standby tasks
>
[
https://issues.apache.org/jira/browse/KAFKA-15027?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Hao Li reassigned KAFKA-15027:
--
Assignee: Hao Li
> Implement rack aware assignment for standby tasks
>
[
https://issues.apache.org/jira/browse/KAFKA-15023?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Hao Li resolved KAFKA-15023.
Fix Version/s: 3.6.0
Resolution: Fixed
> Get rack information for source topic partitions for a
[
https://issues.apache.org/jira/browse/KAFKA-15023?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Hao Li closed KAFKA-15023.
--
> Get rack information for source topic partitions for a task
>
[
https://issues.apache.org/jira/browse/KAFKA-15023?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Hao Li reassigned KAFKA-15023:
--
Assignee: Hao Li
> Get rack information for source topic partitions for a task
>
junrao commented on PR #13990:
URL: https://github.com/apache/kafka/pull/13990#issuecomment-1675203219
@kirktrue : Thanks for the update. If there is clear evidence that test
failures are unrelated, it's reasonable to merge the PR. The latest build has 3
red failures due to a connect
gharris1727 opened a new pull request, #14194:
URL: https://github.com/apache/kafka/pull/14194
In the past, the DirectoryConfigProvider was added without a corresponding
manifest, which was finally noticed when Connect was unable to discover it.
When this was being fixed, a notice was
Greg Harris created KAFKA-15336:
---
Summary: Connect plugin Javadocs should mention serviceloader
manifests
Key: KAFKA-15336
URL: https://issues.apache.org/jira/browse/KAFKA-15336
Project: Kafka
junrao commented on code in PR #14111:
URL: https://github.com/apache/kafka/pull/14111#discussion_r1291575101
##
clients/src/main/java/org/apache/kafka/clients/Metadata.java:
##
@@ -114,18 +127,41 @@ public synchronized Cluster fetch() {
/**
* Return the next time
riedelmax commented on PR #14124:
URL: https://github.com/apache/kafka/pull/14124#issuecomment-1675067780
Hey @jeffkbkim
I fixed the related test failures. I had to implement some lines in
KafkaApis::handleConsumerGroupDescribe to make it work. However, this is still
a mess as the real
clolov commented on PR #14190:
URL: https://github.com/apache/kafka/pull/14190#issuecomment-1675013748
This is an interesting find. That list was compiled quite sometime ago, but
given this information I will go and recheck again - maybe my search was faulty
¯\\\_(ツ)\_/¯
--
This is an
hgeraldino commented on PR #14093:
URL: https://github.com/apache/kafka/pull/14093#issuecomment-1674897648
Thanks @yashmayya for your review!
I addressed your comments, please take another look when you have a chance
--
This is an automated message from the Apache Git Service.
To
ijuma commented on PR #14186:
URL: https://github.com/apache/kafka/pull/14186#issuecomment-1674805468
@C0urante Yes, if we can't fix `unitTest` and `integrationTest`, it makes
sense to change to `test` until we can fix it.
--
This is an automated message from the Apache Git Service.
To
nizhikov commented on PR #13247:
URL: https://github.com/apache/kafka/pull/13247#issuecomment-1674795242
@mimaison Thanks for review and merge of #14172
The PR still pretty big but touches only 15 classes.
Are you comfortable with reviewing it as is?
I can try to move
lucasbru opened a new pull request, #14193:
URL: https://github.com/apache/kafka/pull/14193
Stacked draft PR. Not really ready for review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
AndrewJSchofield commented on PR #14111:
URL: https://github.com/apache/kafka/pull/14111#issuecomment-1674778113
Builds cleanly with 12 unrelated test failures.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
mimaison merged PR #14172:
URL: https://github.com/apache/kafka/pull/14172
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/KAFKA-15116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17753215#comment-17753215
]
David Gammon commented on KAFKA-15116:
--
The issue we are experiencing is not happening before or at
yashmayya commented on code in PR #14093:
URL: https://github.com/apache/kafka/pull/14093#discussion_r1291268068
##
connect/runtime/src/test/java/org/apache/kafka/connect/converters/BooleanConverterTest.java:
##
@@ -0,0 +1,85 @@
+/*
+ * Licensed to the Apache Software
divijvaidya commented on code in PR #14176:
URL: https://github.com/apache/kafka/pull/14176#discussion_r1291232121
##
core/src/main/scala/kafka/server/ControllerServer.scala:
##
@@ -231,7 +231,7 @@ class ControllerServer(
setMetrics(quorumControllerMetrics).
divijvaidya commented on code in PR #14176:
URL: https://github.com/apache/kafka/pull/14176#discussion_r1291265129
##
core/src/main/scala/kafka/server/ControllerServer.scala:
##
@@ -231,7 +231,7 @@ class ControllerServer(
setMetrics(quorumControllerMetrics).
abhijeetk88 commented on code in PR #14127:
URL: https://github.com/apache/kafka/pull/14127#discussion_r1291235847
##
storage/src/test/java/org/apache/kafka/server/log/remote/metadata/storage/TopicBasedRemoteLogMetadataManagerMultipleSubscriptionsTest.java:
##
@@ -0,0 +1,176 @@
abhijeetk88 commented on code in PR #14127:
URL: https://github.com/apache/kafka/pull/14127#discussion_r1291235847
##
storage/src/test/java/org/apache/kafka/server/log/remote/metadata/storage/TopicBasedRemoteLogMetadataManagerMultipleSubscriptionsTest.java:
##
@@ -0,0 +1,176 @@
divijvaidya commented on code in PR #14176:
URL: https://github.com/apache/kafka/pull/14176#discussion_r1291234961
##
core/src/test/scala/integration/kafka/admin/RemoteTopicCreateAndUpdateConfigTest.scala:
##
@@ -0,0 +1,274 @@
+/**
+ * Licensed to the Apache Software Foundation
abhijeetk88 commented on code in PR #14127:
URL: https://github.com/apache/kafka/pull/14127#discussion_r1291234396
##
storage/src/test/java/org/apache/kafka/server/log/remote/metadata/storage/ConsumerTaskTest.java:
##
@@ -0,0 +1,414 @@
+/*
+ * Licensed to the Apache Software
PrasanthV454 commented on PR #14191:
URL: https://github.com/apache/kafka/pull/14191#issuecomment-1674600678
@divijvaidya I did follow the above steps. can you try Prasanth?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
divijvaidya commented on code in PR #14176:
URL: https://github.com/apache/kafka/pull/14176#discussion_r1291232121
##
core/src/main/scala/kafka/server/ControllerServer.scala:
##
@@ -231,7 +231,7 @@ class ControllerServer(
setMetrics(quorumControllerMetrics).
divijvaidya commented on code in PR #14176:
URL: https://github.com/apache/kafka/pull/14176#discussion_r1291222788
##
storage/src/main/java/org/apache/kafka/storage/internals/log/LogConfig.java:
##
@@ -459,49 +463,53 @@ public static void validateValues(Map props) {
divijvaidya commented on code in PR #14176:
URL: https://github.com/apache/kafka/pull/14176#discussion_r1291213288
##
storage/src/main/java/org/apache/kafka/storage/internals/log/LogConfig.java:
##
@@ -459,49 +463,53 @@ public static void validateValues(Map props) {
divijvaidya commented on PR #14191:
URL: https://github.com/apache/kafka/pull/14191#issuecomment-1674572876
> @divijvaidya "prasanth" it is.
Ah seems like your JIRA account is not created at all.
https://issues.apache.org/jira/secure/ViewProfile.jspa?name=prasanth says "The
divijvaidya commented on PR #14191:
URL: https://github.com/apache/kafka/pull/14191#issuecomment-1674564363
Added you as a contributor. You should be able to create JIRA now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
[
https://issues.apache.org/jira/browse/KAFKA-15335?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Taras Ledkov updated KAFKA-15335:
-
Description: Root issue to track
[
https://issues.apache.org/jira/browse/KAFKA-15335?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Taras Ledkov updated KAFKA-15335:
-
Description: Root to track
Taras Ledkov created KAFKA-15335:
Summary: Support custom SSL configuration for Kafka Connect
RestServer
Key: KAFKA-15335
URL: https://issues.apache.org/jira/browse/KAFKA-15335
Project: Kafka
PrasanthV454 commented on PR #14191:
URL: https://github.com/apache/kafka/pull/14191#issuecomment-1674540040
@divijvaidya "prasanth" it is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
divijvaidya commented on PR #14191:
URL: https://github.com/apache/kafka/pull/14191#issuecomment-1674534365
@PrasanthV454 what's your JIRA username? I can add permissions now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
divijvaidya commented on PR #14186:
URL: https://github.com/apache/kafka/pull/14186#issuecomment-1674531931
If I understand the change correctly here, the downside of this change is
that we won't fail fast in CI. This is because prior to this change if
`unitTest` target fails, the
PrasanthV454 commented on PR #14191:
URL: https://github.com/apache/kafka/pull/14191#issuecomment-1674530457
> @PrasanthV454 thank you for digging into this. Some of these are tests are
important enough that we cannot release without them. But they are also making
CI fail and hence making
florin-akermann commented on code in PR #14187:
URL: https://github.com/apache/kafka/pull/14187#discussion_r1291165997
##
streams/src/main/java/org/apache/kafka/streams/kstream/KStream.java:
##
@@ -2805,7 +2805,7 @@ KStream leftJoin(final KTable
table,
* For each {@code
bachmanity1 commented on PR #14190:
URL: https://github.com/apache/kafka/pull/14190#issuecomment-1674521878
> Weird that we are not tracking this test at
https://issues.apache.org/jira/browse/KAFKA-14133 or
https://issues.apache.org/jira/browse/KAFKA-14132.
Looking at the state of
divijvaidya commented on PR #14191:
URL: https://github.com/apache/kafka/pull/14191#issuecomment-1674447516
@PrasanthV454 thank you for digging into this. Some of these are tests are
important enough that we cannot release without them. But they are also making
CI fail and hence making it
AndrewJSchofield commented on code in PR #14191:
URL: https://github.com/apache/kafka/pull/14191#discussion_r1291101907
##
connect/mirror/src/test/java/org/apache/kafka/connect/mirror/integration/MirrorConnectorsIntegrationTransactionsTest.java:
##
@@ -31,6 +32,7 @@
*
divijvaidya commented on PR #14191:
URL: https://github.com/apache/kafka/pull/14191#issuecomment-1674434985
cc @kirktrue since you are interested in getting the CI stable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
AndrewJSchofield commented on code in PR #14111:
URL: https://github.com/apache/kafka/pull/14111#discussion_r1291092191
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java:
##
@@ -550,7 +550,7 @@ public boolean poll(Timer timer, boolean
[
https://issues.apache.org/jira/browse/KAFKA-14132?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yash Mayya updated KAFKA-14132:
---
Description:
{color:#de350b}Some of the tests below use EasyMock as well. For those migrate
both
[
https://issues.apache.org/jira/browse/KAFKA-15313?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Divij Vaidya updated KAFKA-15313:
-
Issue Type: Improvement (was: Task)
> Delete remote log segments partition asynchronously when
AndrewJSchofield commented on code in PR #14111:
URL: https://github.com/apache/kafka/pull/14111#discussion_r1291085760
##
clients/src/main/java/org/apache/kafka/clients/Metadata.java:
##
@@ -140,17 +167,30 @@ public long metadataExpireMs() {
}
/**
- * Request
divijvaidya merged PR #14153:
URL: https://github.com/apache/kafka/pull/14153
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
AndrewJSchofield commented on code in PR #14111:
URL: https://github.com/apache/kafka/pull/14111#discussion_r1291061981
##
clients/src/main/java/org/apache/kafka/clients/Metadata.java:
##
@@ -267,11 +307,14 @@ public synchronized void update(int requestVersion,
showuon opened a new pull request, #14192:
URL: https://github.com/apache/kafka/pull/14192
Currently, when consumer startup, there will be a log message said:
```
[2023-08-11 15:47:17,713] INFO [Consumer clientId=console-consumer,
groupId=console-consumer-28605] Request joining group
PrasanthV454 opened a new pull request, #14191:
URL: https://github.com/apache/kafka/pull/14191
AK Builds are exiting while running the tests. After going through various
builds here is what I found -
- Clients which ever aren't closed while running the tests are trying to
connect
[
https://issues.apache.org/jira/browse/KAFKA-15330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17753074#comment-17753074
]
Roland Sommer commented on KAFKA-15330:
---
Re-ran the tests today with a snapshot build of commit
kamalcph commented on code in PR #13947:
URL: https://github.com/apache/kafka/pull/13947#discussion_r1290329055
##
core/src/main/scala/kafka/server/ReplicaManager.scala:
##
@@ -558,17 +574,38 @@ class ReplicaManager(val config: KafkaConfig,
}
[
https://issues.apache.org/jira/browse/KAFKA-15334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17753070#comment-17753070
]
Deng Ziming commented on KAFKA-15334:
-
We are treating DescribeQuorum as cluster action, and not
Deng Ziming created KAFKA-15334:
---
Summary: DescribeQuorum should not be seen as cluster action
Key: KAFKA-15334
URL: https://issues.apache.org/jira/browse/KAFKA-15334
Project: Kafka
Issue
86 matches
Mail list logo
