[GitHub] [kafka] wcarlson5 opened a new pull request, #14247: Init store properly

2023-08-18 Thread via GitHub
wcarlson5 opened a new pull request, #14247: URL: https://github.com/apache/kafka/pull/14247 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of

[GitHub] [kafka] wcarlson5 commented on pull request #14027: KAFKA-14936: Add restore logic (3/N)

2023-08-18 Thread via GitHub
wcarlson5 commented on PR #14027: URL: https://github.com/apache/kafka/pull/14027#issuecomment-1684718224 No tests failled -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [kafka] wcarlson5 merged pull request #14027: KAFKA-14936: Add restore logic (3/N)

2023-08-18 Thread via GitHub
wcarlson5 merged PR #14027: URL: https://github.com/apache/kafka/pull/14027 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] pprovenzano commented on a diff in pull request #14083: KAFKA-15219: KRaft support for DelegationTokens

2023-08-18 Thread via GitHub
pprovenzano commented on code in PR #14083: URL: https://github.com/apache/kafka/pull/14083#discussion_r1299014422 ## core/src/main/scala/kafka/server/ControllerApis.scala: ## @@ -842,6 +848,114 @@ class ControllerApis(val requestChannel: RequestChannel, } } + def

[GitHub] [kafka] pprovenzano commented on a diff in pull request #14083: KAFKA-15219: KRaft support for DelegationTokens

2023-08-18 Thread via GitHub
pprovenzano commented on code in PR #14083: URL: https://github.com/apache/kafka/pull/14083#discussion_r1299014398 ## core/src/test/scala/unit/kafka/server/KafkaApisTest.scala: ## @@ -6069,19 +6071,19 @@ class KafkaApisTest { @Test def

[GitHub] [kafka] pprovenzano commented on a diff in pull request #14083: KAFKA-15219: KRaft support for DelegationTokens

2023-08-18 Thread via GitHub
pprovenzano commented on code in PR #14083: URL: https://github.com/apache/kafka/pull/14083#discussion_r1299014357 ## core/src/test/scala/unit/kafka/server/KafkaApisTest.scala: ## @@ -5290,8 +5290,10 @@ class KafkaApisTest { // read the header from the buffer first so

[jira] [Created] (KAFKA-15381) Controller waiting for migration should only allow failover when transactions are supported

2023-08-18 Thread David Arthur (Jira)
David Arthur created KAFKA-15381: Summary: Controller waiting for migration should only allow failover when transactions are supported Key: KAFKA-15381 URL: https://issues.apache.org/jira/browse/KAFKA-15381

[GitHub] [kafka] mumrah commented on a diff in pull request #14208: KAFKA-14538 Metadata transactions in MetadataLoader

2023-08-18 Thread via GitHub
mumrah commented on code in PR #14208: URL: https://github.com/apache/kafka/pull/14208#discussion_r1298915833 ## metadata/src/main/java/org/apache/kafka/controller/ActivationRecordsGenerator.java: ## @@ -0,0 +1,197 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] wcarlson5 closed pull request #13641: KAFKA-14936: Add Grace Period to Stream Table Join

2023-08-18 Thread via GitHub
wcarlson5 closed pull request #13641: KAFKA-14936: Add Grace Period to Stream Table Join URL: https://github.com/apache/kafka/pull/13641 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Created] (KAFKA-15380) Try complete actions after callback

2023-08-18 Thread Justine Olshan (Jira)
Justine Olshan created KAFKA-15380: -- Summary: Try complete actions after callback Key: KAFKA-15380 URL: https://issues.apache.org/jira/browse/KAFKA-15380 Project: Kafka Issue Type: Sub-task

[jira] [Resolved] (KAFKA-14627) Modernize Connect plugin discovery

2023-08-18 Thread Greg Harris (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14627?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Harris resolved KAFKA-14627. - Resolution: Fixed > Modernize Connect plugin discovery > -- > >

[jira] [Resolved] (KAFKA-15226) System tests for plugin.discovery worker configuration

2023-08-18 Thread Greg Harris (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15226?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Harris resolved KAFKA-15226. - Fix Version/s: 3.6.0 Resolution: Fixed > System tests for plugin.discovery worker

[GitHub] [kafka] gharris1727 commented on pull request #14230: KAFKA-15226: Add connect-plugin-path and plugin.discovery system test

2023-08-18 Thread via GitHub
gharris1727 commented on PR #14230: URL: https://github.com/apache/kafka/pull/14230#issuecomment-1684494668 Test failures in CI appear unrelated. All of the Connect system tests passed for me locally. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kafka] splett2 opened a new pull request, #14246: MINOR: Minor storage cleanups

2023-08-18 Thread via GitHub
splett2 opened a new pull request, #14246: URL: https://github.com/apache/kafka/pull/14246 ### What Noticed that there was a dangling unused class (LongRef, replaced by PrimitiveRef.LongRef), and the LogOffsetMetadata toString was a little oddly formatted. *Summary of testing

[GitHub] [kafka] jolshan commented on pull request #14197: MINOR: Execute action queue after callback request

2023-08-18 Thread via GitHub
jolshan commented on PR #14197: URL: https://github.com/apache/kafka/pull/14197#issuecomment-1684439722 I recommend turning off whitespace changes so that the diff renders correctly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] cmccabe commented on a diff in pull request #14208: KAFKA-14538 Metadata transactions in MetadataLoader

2023-08-18 Thread via GitHub
cmccabe commented on code in PR #14208: URL: https://github.com/apache/kafka/pull/14208#discussion_r1298865134 ## metadata/src/main/java/org/apache/kafka/controller/ActivationRecordsGenerator.java: ## @@ -0,0 +1,197 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] mumrah commented on a diff in pull request #14122: KAFKA-14500; [7/7] Refactor GroupMetadataManagerTest

2023-08-18 Thread via GitHub
mumrah commented on code in PR #14122: URL: https://github.com/apache/kafka/pull/14122#discussion_r1298845661 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java: ## @@ -9119,4 +8742,257 @@ public void

[GitHub] [kafka] wcarlson5 commented on a diff in pull request #14027: KAFKA-14936: Add restore logic (3/N)

2023-08-18 Thread via GitHub
wcarlson5 commented on code in PR #14027: URL: https://github.com/apache/kafka/pull/14027#discussion_r1298818523 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamImpl.java: ## @@ -1271,7 +1271,7 @@ private KStream doStreamTableJoin(final KTable

[jira] [Updated] (KAFKA-15379) Add option for Grace period Joins to disable changelog creation

2023-08-18 Thread Walker Carlson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Walker Carlson updated KAFKA-15379: --- Priority: Minor (was: Major) > Add option for Grace period Joins to disable changelog

[jira] [Updated] (KAFKA-15379) Add option for Grace period Joins to disable changelog creation

2023-08-18 Thread Walker Carlson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Walker Carlson updated KAFKA-15379: --- Component/s: streams > Add option for Grace period Joins to disable changelog creation >

[jira] [Updated] (KAFKA-15379) Add option for Grace period Joins to disable changelog creation

2023-08-18 Thread Walker Carlson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Walker Carlson updated KAFKA-15379: --- Affects Version/s: 3.6.0 > Add option for Grace period Joins to disable changelog creation

[jira] [Updated] (KAFKA-15379) Add option for Grace period Joins to disable changelog creation

2023-08-18 Thread Walker Carlson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Walker Carlson updated KAFKA-15379: --- Labels: kip (was: ) > Add option for Grace period Joins to disable changelog creation >

[jira] [Created] (KAFKA-15379) Add option for Grace period Joins to disable changelog creation

2023-08-18 Thread Walker Carlson (Jira)
Walker Carlson created KAFKA-15379: -- Summary: Add option for Grace period Joins to disable changelog creation Key: KAFKA-15379 URL: https://issues.apache.org/jira/browse/KAFKA-15379 Project: Kafka

[GitHub] [kafka] bbejeck commented on a diff in pull request #14027: KAFKA-14936: Add restore logic (3/N)

2023-08-18 Thread via GitHub
bbejeck commented on code in PR #14027: URL: https://github.com/apache/kafka/pull/14027#discussion_r1298812512 ## streams/src/test/java/org/apache/kafka/streams/integration/JoinGracePeriodDurabilityIntegrationTest.java: ## @@ -0,0 +1,275 @@ +/* + * Licensed to the Apache

[GitHub] [kafka] pprovenzano commented on a diff in pull request #14083: KAFKA-15219: KRaft support for DelegationTokens

2023-08-18 Thread via GitHub
pprovenzano commented on code in PR #14083: URL: https://github.com/apache/kafka/pull/14083#discussion_r1298798195 ## core/src/main/scala/kafka/server/BrokerServer.scala: ## @@ -279,10 +280,7 @@ class BrokerServer( ) /* start token manager */ - if

[GitHub] [kafka] bbejeck commented on a diff in pull request #14027: KAFKA-14936: Add restore logic (3/N)

2023-08-18 Thread via GitHub
bbejeck commented on code in PR #14027: URL: https://github.com/apache/kafka/pull/14027#discussion_r1298789285 ## streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBTimeOrderedKeyValueBuffer.java: ## @@ -45,17 +53,24 @@ public class

[GitHub] [kafka] mjsax commented on a diff in pull request #14027: KAFKA-14936: Add restore logic (3/N)

2023-08-18 Thread via GitHub
mjsax commented on code in PR #14027: URL: https://github.com/apache/kafka/pull/14027#discussion_r1298793261 ## streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBTimeOrderedKeyValueBytesStore.java: ## @@ -42,7 +46,29 @@ protected KeyValue

[GitHub] [kafka] pprovenzano commented on a diff in pull request #14083: KAFKA-15219: KRaft support for DelegationTokens

2023-08-18 Thread via GitHub
pprovenzano commented on code in PR #14083: URL: https://github.com/apache/kafka/pull/14083#discussion_r1298784076 ## core/src/test/scala/unit/kafka/server/KafkaApisTest.scala: ## @@ -6069,19 +6071,19 @@ class KafkaApisTest { @Test def

[GitHub] [kafka] pprovenzano commented on a diff in pull request #14083: KAFKA-15219: KRaft support for DelegationTokens

2023-08-18 Thread via GitHub
pprovenzano commented on code in PR #14083: URL: https://github.com/apache/kafka/pull/14083#discussion_r1298770601 ## core/src/main/scala/kafka/server/ControllerApis.scala: ## @@ -842,6 +848,114 @@ class ControllerApis(val requestChannel: RequestChannel, } } + def

[GitHub] [kafka] rondagostino commented on a diff in pull request #14083: KAFKA-15219: KRaft support for DelegationTokens

2023-08-18 Thread via GitHub
rondagostino commented on code in PR #14083: URL: https://github.com/apache/kafka/pull/14083#discussion_r1298761957 ## core/src/test/scala/unit/kafka/server/KafkaApisTest.scala: ## @@ -5290,8 +5290,10 @@ class KafkaApisTest { // read the header from the buffer first so

[GitHub] [kafka] rondagostino commented on a diff in pull request #14083: KAFKA-15219: KRaft support for DelegationTokens

2023-08-18 Thread via GitHub
rondagostino commented on code in PR #14083: URL: https://github.com/apache/kafka/pull/14083#discussion_r1298759956 ## core/src/test/scala/unit/kafka/server/KafkaApisTest.scala: ## @@ -6069,19 +6071,19 @@ class KafkaApisTest { @Test def

[GitHub] [kafka] rondagostino commented on a diff in pull request #14083: KAFKA-15219: KRaft support for DelegationTokens

2023-08-18 Thread via GitHub
rondagostino commented on code in PR #14083: URL: https://github.com/apache/kafka/pull/14083#discussion_r1298748051 ## core/src/test/scala/unit/kafka/server/DelegationTokenRequestsTest.scala: ## @@ -109,13 +127,44 @@ class DelegationTokenRequestsTest extends BaseRequestTest

[GitHub] [kafka] rondagostino commented on a diff in pull request #14083: KAFKA-15219: KRaft support for DelegationTokens

2023-08-18 Thread via GitHub
rondagostino commented on code in PR #14083: URL: https://github.com/apache/kafka/pull/14083#discussion_r1298740130 ## core/src/main/scala/kafka/server/BrokerServer.scala: ## @@ -279,10 +280,7 @@ class BrokerServer( ) /* start token manager */ - if

[GitHub] [kafka] rondagostino commented on a diff in pull request #14083: KAFKA-15219: KRaft support for DelegationTokens

2023-08-18 Thread via GitHub
rondagostino commented on code in PR #14083: URL: https://github.com/apache/kafka/pull/14083#discussion_r1298734803 ## core/src/main/scala/kafka/server/ControllerApis.scala: ## @@ -842,6 +848,114 @@ class ControllerApis(val requestChannel: RequestChannel, } } + def

[GitHub] [kafka] pprovenzano commented on a diff in pull request #14083: KAFKA-15219: KRaft support for DelegationTokens

2023-08-18 Thread via GitHub
pprovenzano commented on code in PR #14083: URL: https://github.com/apache/kafka/pull/14083#discussion_r1298728194 ## core/src/main/scala/kafka/server/DelegationTokenManager.scala: ## @@ -165,16 +99,16 @@ object DelegationTokenManager { class DelegationTokenManager(val

[GitHub] [kafka] pprovenzano commented on a diff in pull request #14083: KAFKA-15219: KRaft support for DelegationTokens

2023-08-18 Thread via GitHub
pprovenzano commented on code in PR #14083: URL: https://github.com/apache/kafka/pull/14083#discussion_r1298721551 ## metadata/src/main/java/org/apache/kafka/controller/DelegationTokenControlManager.java: ## @@ -0,0 +1,359 @@ +/* + * Licensed to the Apache Software Foundation

[jira] [Updated] (KAFKA-15378) Rolling upgrade system tests are failing

2023-08-18 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15378?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-15378: Component/s: system tests > Rolling upgrade system tests are failing >

[GitHub] [kafka] rondagostino commented on a diff in pull request #14083: KAFKA-15219: KRaft support for DelegationTokens

2023-08-18 Thread via GitHub
rondagostino commented on code in PR #14083: URL: https://github.com/apache/kafka/pull/14083#discussion_r1298718349 ## core/src/main/scala/kafka/server/DelegationTokenManager.scala: ## @@ -165,16 +99,16 @@ object DelegationTokenManager { class DelegationTokenManager(val

[GitHub] [kafka] florin-akermann commented on pull request #14174: Kafka 12317: Relax non-null key requirement in Kafka Streams

2023-08-18 Thread via GitHub
florin-akermann commented on PR #14174: URL: https://github.com/apache/kafka/pull/14174#issuecomment-1684251499 @mjsax @guozhangwang I'd say this PR is ready to be reviewd. May I ask for your input or do you know who to poke? -- This is an automated message from the Apache Git Service.

[GitHub] [kafka] mumrah commented on a diff in pull request #14083: KAFKA-15219: KRaft support for DelegationTokens

2023-08-18 Thread via GitHub
mumrah commented on code in PR #14083: URL: https://github.com/apache/kafka/pull/14083#discussion_r1298714610 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -2999,7 +2999,38 @@ class KafkaApis(val requestChannel: RequestChannel, } def

[GitHub] [kafka] rondagostino commented on a diff in pull request #14083: KAFKA-15219: KRaft support for DelegationTokens

2023-08-18 Thread via GitHub
rondagostino commented on code in PR #14083: URL: https://github.com/apache/kafka/pull/14083#discussion_r1298706120 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -2999,7 +2999,38 @@ class KafkaApis(val requestChannel: RequestChannel, } def

[GitHub] [kafka] rondagostino commented on a diff in pull request #14083: KAFKA-15219: KRaft support for DelegationTokens

2023-08-18 Thread via GitHub
rondagostino commented on code in PR #14083: URL: https://github.com/apache/kafka/pull/14083#discussion_r1298687894 ## metadata/src/main/java/org/apache/kafka/controller/DelegationTokenControlManager.java: ## @@ -0,0 +1,359 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [kafka] rondagostino commented on a diff in pull request #14083: KAFKA-15219: KRaft support for DelegationTokens

2023-08-18 Thread via GitHub
rondagostino commented on code in PR #14083: URL: https://github.com/apache/kafka/pull/14083#discussion_r1298683576 ## metadata/src/main/java/org/apache/kafka/controller/DelegationTokenControlManager.java: ## @@ -0,0 +1,359 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [kafka] rondagostino commented on a diff in pull request #14083: KAFKA-15219: KRaft support for DelegationTokens

2023-08-18 Thread via GitHub
rondagostino commented on code in PR #14083: URL: https://github.com/apache/kafka/pull/14083#discussion_r1298682884 ## metadata/src/main/java/org/apache/kafka/controller/DelegationTokenControlManager.java: ## @@ -0,0 +1,359 @@ +/* + * Licensed to the Apache Software Foundation

[jira] [Updated] (KAFKA-15374) ZK migration fails on configs for default broker resource

2023-08-18 Thread David Arthur (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15374?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Arthur updated KAFKA-15374: - Fix Version/s: (was: 3.4.2) > ZK migration fails on configs for default broker resource >

[jira] [Updated] (KAFKA-15374) ZK migration fails on configs for default broker resource

2023-08-18 Thread David Arthur (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15374?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Arthur updated KAFKA-15374: - Affects Version/s: (was: 3.4.1) > ZK migration fails on configs for default broker resource

[jira] [Commented] (KAFKA-15372) MM2 rolling restart can drop configuration changes silently

2023-08-18 Thread Greg Harris (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17756062#comment-17756062 ] Greg Harris commented on KAFKA-15372: - Here's a proof-of-concept for the fix:

[GitHub] [kafka] gharris1727 opened a new pull request, #14245: KAFKA-15372: Add MirrorMaker2 connector config forwarding on startup

2023-08-18 Thread via GitHub
gharris1727 opened a new pull request, #14245: URL: https://github.com/apache/kafka/pull/14245 This is an extremely sloppy proof-of-concept and should not be merged in it's current state, as it breaks a lot of abstractions. This is meant only for diagnostic purposes. ### Committer

[GitHub] [kafka] mumrah merged pull request #14237: KAFKA-15374 Handle case of default broker in config migration

2023-08-18 Thread via GitHub
mumrah merged PR #14237: URL: https://github.com/apache/kafka/pull/14237 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] mumrah commented on pull request #14237: KAFKA-15374 Handle case of default broker in config migration

2023-08-18 Thread via GitHub
mumrah commented on PR #14237: URL: https://github.com/apache/kafka/pull/14237#issuecomment-1684172655 Test failures look unrelated https://github.com/apache/kafka/assets/55116/19cfb202-781e-4930-adc1-15485c8574be;> -- This is an automated message from the Apache Git Service.

[jira] [Comment Edited] (KAFKA-15372) MM2 rolling restart can drop configuration changes silently

2023-08-18 Thread Greg Harris (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17756048#comment-17756048 ] Greg Harris edited comment on KAFKA-15372 at 8/18/23 4:38 PM: -- [~durban]

[jira] [Resolved] (KAFKA-15319) Upgrade rocksdb to fix CVE-2022-37434

2023-08-18 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15319?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Cadonna resolved KAFKA-15319. --- Resolution: Fixed > Upgrade rocksdb to fix CVE-2022-37434 >

[GitHub] [kafka] cadonna merged pull request #14216: KAFKA-15319: Upgrade rocksdb to fix CVE-2022-37434

2023-08-18 Thread via GitHub
cadonna merged PR #14216: URL: https://github.com/apache/kafka/pull/14216 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Updated] (KAFKA-15372) MM2 rolling restart can drop configuration changes silently

2023-08-18 Thread Greg Harris (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15372?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Harris updated KAFKA-15372: Issue Type: Bug (was: Improvement) > MM2 rolling restart can drop configuration changes silently

[jira] [Updated] (KAFKA-15372) MM2 rolling restart can drop configuration changes silently

2023-08-18 Thread Greg Harris (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15372?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Harris updated KAFKA-15372: Fix Version/s: 3.6.0 > MM2 rolling restart can drop configuration changes silently >

[jira] [Commented] (KAFKA-15372) MM2 rolling restart can drop configuration changes silently

2023-08-18 Thread Greg Harris (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17756048#comment-17756048 ] Greg Harris commented on KAFKA-15372: - [~durban] thank you for the sanity check, I see the flaw now.

[GitHub] [kafka] junrao commented on a diff in pull request #13561: KAFKA-14888: Added remote log segments retention functionality based on time and size.

2023-08-18 Thread via GitHub
junrao commented on code in PR #13561: URL: https://github.com/apache/kafka/pull/13561#discussion_r1298640349 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -696,11 +704,327 @@ public void run() { } } +public void

[GitHub] [kafka] yashmayya opened a new pull request, #14244: KAFKA-15377: Don't expose externalized secret values in tasks-config API endpoint

2023-08-18 Thread via GitHub
yashmayya opened a new pull request, #14244: URL: https://github.com/apache/kafka/pull/14244 From https://issues.apache.org/jira/browse/KAFKA-15377: > The `GET /connectors/{connector}/tasks-config` endpoint added in

[GitHub] [kafka] clolov commented on a diff in pull request #14161: KAFKA-15267: Do not allow Tiered Storage to be disabled while topics have remote.storage.enable property

2023-08-18 Thread via GitHub
clolov commented on code in PR #14161: URL: https://github.com/apache/kafka/pull/14161#discussion_r1298593281 ## core/src/test/scala/unit/kafka/server/KafkaServerTest.scala: ## @@ -154,6 +155,96 @@ class KafkaServerTest extends QuorumTestHarness { server.shutdown() }

[jira] [Assigned] (KAFKA-14589) Move ConsumerGroupCommand to tools

2023-08-18 Thread Nikolay Izhikov (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14589?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nikolay Izhikov reassigned KAFKA-14589: --- Assignee: Nikolay Izhikov (was: Omnia Ibrahim) > Move ConsumerGroupCommand to

[GitHub] [kafka] mumrah commented on a diff in pull request #14208: KAFKA-14538 Metadata transactions in MetadataLoader

2023-08-18 Thread via GitHub
mumrah commented on code in PR #14208: URL: https://github.com/apache/kafka/pull/14208#discussion_r1298547454 ## metadata/src/main/java/org/apache/kafka/controller/ActivationRecordsGenerator.java: ## @@ -0,0 +1,197 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] mumrah commented on a diff in pull request #14208: KAFKA-14538 Metadata transactions in MetadataLoader

2023-08-18 Thread via GitHub
mumrah commented on code in PR #14208: URL: https://github.com/apache/kafka/pull/14208#discussion_r1298547454 ## metadata/src/main/java/org/apache/kafka/controller/ActivationRecordsGenerator.java: ## @@ -0,0 +1,197 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] mumrah commented on a diff in pull request #14208: KAFKA-14538 Metadata transactions in MetadataLoader

2023-08-18 Thread via GitHub
mumrah commented on code in PR #14208: URL: https://github.com/apache/kafka/pull/14208#discussion_r1298547454 ## metadata/src/main/java/org/apache/kafka/controller/ActivationRecordsGenerator.java: ## @@ -0,0 +1,197 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] mumrah commented on a diff in pull request #14208: KAFKA-14538 Metadata transactions in MetadataLoader

2023-08-18 Thread via GitHub
mumrah commented on code in PR #14208: URL: https://github.com/apache/kafka/pull/14208#discussion_r1298547454 ## metadata/src/main/java/org/apache/kafka/controller/ActivationRecordsGenerator.java: ## @@ -0,0 +1,197 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[jira] [Comment Edited] (KAFKA-15378) Rolling upgrade system tests are failing

2023-08-18 Thread Lucas Brutschy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17756002#comment-17756002 ] Lucas Brutschy edited comment on KAFKA-15378 at 8/18/23 2:34 PM: -

[jira] [Updated] (KAFKA-15378) Rolling upgrade system tests are failing

2023-08-18 Thread Lucas Brutschy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15378?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lucas Brutschy updated KAFKA-15378: --- Description: The system tests are having failures for these tests: {noformat}

[jira] [Commented] (KAFKA-15378) Rolling upgrade system tests are failing

2023-08-18 Thread Lucas Brutschy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17756002#comment-17756002 ] Lucas Brutschy commented on KAFKA-15378: Thanks, [~ChrisEgerton] , I didn't realize that even

[jira] [Comment Edited] (KAFKA-15372) MM2 rolling restart can drop configuration changes silently

2023-08-18 Thread Daniel Urban (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17755997#comment-17755997 ] Daniel Urban edited comment on KAFKA-15372 at 8/18/23 2:33 PM: ---

[jira] [Commented] (KAFKA-15372) MM2 rolling restart can drop configuration changes silently

2023-08-18 Thread Daniel Urban (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17755997#comment-17755997 ] Daniel Urban commented on KAFKA-15372: -- [~gharris1727] I have a bit more information: we managed to

[jira] [Commented] (KAFKA-15377) GET /connectors/{connector}/tasks-config endpoint exposes externalized secret values

2023-08-18 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17755993#comment-17755993 ] Chris Egerton commented on KAFKA-15377: --- I don't think a KIP is necessary, for the same reasons

[jira] [Commented] (KAFKA-15378) Rolling upgrade system tests are failing

2023-08-18 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17755990#comment-17755990 ] Chris Egerton commented on KAFKA-15378: --- [~lbrutschy] the

[jira] [Commented] (KAFKA-15219) Support delegation tokens in KRaft

2023-08-18 Thread Proven Provenzano (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17755975#comment-17755975 ] Proven Provenzano commented on KAFKA-15219: --- We would like to push the PR today, so if you

[GitHub] [kafka] pprovenzano commented on a diff in pull request #14083: KAFKA-15219: KRaft support for DelegationTokens

2023-08-18 Thread via GitHub
pprovenzano commented on code in PR #14083: URL: https://github.com/apache/kafka/pull/14083#discussion_r1298461774 ## core/src/main/scala/kafka/server/ControllerApis.scala: ## @@ -842,6 +848,114 @@ class ControllerApis(val requestChannel: RequestChannel, } } + def

[GitHub] [kafka] satishd merged pull request #13947: KAFKA-15130: Delete remote segments when delete a topic

2023-08-18 Thread via GitHub
satishd merged PR #13947: URL: https://github.com/apache/kafka/pull/13947 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Comment Edited] (KAFKA-15046) Produce performance issue under high disk load

2023-08-18 Thread Haruki Okada (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17755904#comment-17755904 ] Haruki Okada edited comment on KAFKA-15046 at 8/18/23 12:05 PM: I

[GitHub] [kafka] hudeqi commented on pull request #14243: KAFKA-14912:Add a dynamic config for remote index cache size

2023-08-18 Thread via GitHub
hudeqi commented on PR #14243: URL: https://github.com/apache/kafka/pull/14243#issuecomment-1683773061 Hi, @divijvaidya @satishd If you have time, help to review this pr, thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] omkreddy commented on a diff in pull request #14083: KAFKA-15219: KRaft support for DelegationTokens

2023-08-18 Thread via GitHub
omkreddy commented on code in PR #14083: URL: https://github.com/apache/kafka/pull/14083#discussion_r1298325937 ## core/src/main/scala/kafka/server/ControllerApis.scala: ## @@ -842,6 +848,114 @@ class ControllerApis(val requestChannel: RequestChannel, } } + def

[jira] [Commented] (KAFKA-15046) Produce performance issue under high disk load

2023-08-18 Thread Haruki Okada (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17755904#comment-17755904 ] Haruki Okada commented on KAFKA-15046: -- I submitted a patch

[jira] [Updated] (KAFKA-15046) Produce performance issue under high disk load

2023-08-18 Thread Haruki Okada (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15046?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haruki Okada updated KAFKA-15046: - Attachment: image-2023-08-18-19-29-56-377.png > Produce performance issue under high disk load

[jira] [Updated] (KAFKA-15046) Produce performance issue under high disk load

2023-08-18 Thread Haruki Okada (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15046?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haruki Okada updated KAFKA-15046: - Attachment: image-2023-08-18-19-23-36-597.png > Produce performance issue under high disk load

[GitHub] [kafka] iamgd67 closed pull request #8274: KAFKA-9699: remove -E option from sed in kafka-run-class.sh

2023-08-18 Thread via GitHub
iamgd67 closed pull request #8274: KAFKA-9699: remove -E option from sed in kafka-run-class.sh URL: https://github.com/apache/kafka/pull/8274 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] iamgd67 commented on pull request #8274: KAFKA-9699: remove -E option from sed in kafka-run-class.sh

2023-08-18 Thread via GitHub
iamgd67 commented on PR #8274: URL: https://github.com/apache/kafka/pull/8274#issuecomment-1683688095 after all these years, old version of `sed` is really rare. Using `-E` will make the regex expression simpler, so just close this PR. -- This is an automated message from the Apache Git

[jira] [Commented] (KAFKA-15046) Produce performance issue under high disk load

2023-08-18 Thread Haruki Okada (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17755898#comment-17755898 ] Haruki Okada commented on KAFKA-15046: -- After dug into the fsync call paths in detail, I summarized

[jira] [Created] (KAFKA-15378) Rolling upgrade system tests are failing

2023-08-18 Thread Lucas Brutschy (Jira)
Lucas Brutschy created KAFKA-15378: -- Summary: Rolling upgrade system tests are failing Key: KAFKA-15378 URL: https://issues.apache.org/jira/browse/KAFKA-15378 Project: Kafka Issue Type:

[GitHub] [kafka] lucasbru commented on pull request #14216: KAFKA-15319: Upgrade rocksdb to fix CVE-2022-37434

2023-08-18 Thread via GitHub
lucasbru commented on PR #14216: URL: https://github.com/apache/kafka/pull/14216#issuecomment-1683538192 The benchmarks are clean: https://jenkins.confluent.io/job/confluentinc/job/kafka-streams-benchmarks/job/master/655/console The system tests are having failures:

[jira] [Commented] (KAFKA-15372) MM2 rolling restart can drop configuration changes silently

2023-08-18 Thread Daniel Urban (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17755833#comment-17755833 ] Daniel Urban commented on KAFKA-15372: -- [~gharris1727]  Not sure if I follow this part: "should

[jira] [Comment Edited] (KAFKA-15377) GET /connectors/{connector}/tasks-config endpoint exposes externalized secret values

2023-08-18 Thread Yash Mayya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17755826#comment-17755826 ] Yash Mayya edited comment on KAFKA-15377 at 8/18/23 7:13 AM: - [~mimaison]

[jira] [Commented] (KAFKA-15377) GET /connectors/{connector}/tasks-config endpoint exposes externalized secret values

2023-08-18 Thread Yash Mayya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17755826#comment-17755826 ] Yash Mayya commented on KAFKA-15377: [~mimaison] [~ChrisEgerton] even though this does technically

[jira] [Updated] (KAFKA-15377) GET /connectors/{connector}/tasks-config endpoint exposes externalized secret values

2023-08-18 Thread Yash Mayya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15377?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yash Mayya updated KAFKA-15377: --- Description: The {{GET /connectors/\{connector}/tasks-config}} endpoint added in

[jira] [Created] (KAFKA-15377) GET /connectors/{connector}/tasks-config endpoint exposes externalized secret values

2023-08-18 Thread Yash Mayya (Jira)
Yash Mayya created KAFKA-15377: -- Summary: GET /connectors/{connector}/tasks-config endpoint exposes externalized secret values Key: KAFKA-15377 URL: https://issues.apache.org/jira/browse/KAFKA-15377

[jira] [Updated] (KAFKA-15376) Explore options of removing data earlier to the current leader's leader epoch lineage for topics enabled with tiered storage.

2023-08-18 Thread Satish Duggana (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15376?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Satish Duggana updated KAFKA-15376: --- Summary: Explore options of removing data earlier to the current leader's leader epoch

[jira] [Comment Edited] (KAFKA-15339) Transient I/O error happening in appending records could lead to the halt of whole cluster

2023-08-18 Thread Sagar Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17755812#comment-17755812 ] Sagar Rao edited comment on KAFKA-15339 at 8/18/23 5:52 AM: Thanks for

[jira] [Commented] (KAFKA-15339) Transient I/O error happening in appending records could lead to the halt of whole cluster

2023-08-18 Thread Sagar Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17755812#comment-17755812 ] Sagar Rao commented on KAFKA-15339: --- Thanks for reporting this bug [~functioner]. As you correctly

[GitHub] [kafka] satishd commented on a diff in pull request #13561: KAFKA-14888: Added remote log segments retention functionality based on time and size.

2023-08-18 Thread via GitHub
satishd commented on code in PR #13561: URL: https://github.com/apache/kafka/pull/13561#discussion_r1298027732 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -696,11 +704,327 @@ public void run() { } } +public void

[jira] [Created] (KAFKA-15376) Revisit removing data earlier to the current leader for topics enabled with tiered storage.

2023-08-18 Thread Satish Duggana (Jira)
Satish Duggana created KAFKA-15376: -- Summary: Revisit removing data earlier to the current leader for topics enabled with tiered storage. Key: KAFKA-15376 URL: https://issues.apache.org/jira/browse/KAFKA-15376