[GitHub] [kafka] kamalcph commented on pull request #14329: KAFKA-15410: Delete topic integration test with LocalTieredStorage and TBRLMM (3/4)

kamalcph commented on PR #14329: URL: https://github.com/apache/kafka/pull/14329#issuecomment-1705975965 Rebased the PR against trunk. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] jolshan merged pull request #14324: KAFKA-15424: Make the transaction verification a dynamic configuration

jolshan merged PR #14324: URL: https://github.com/apache/kafka/pull/14324 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (KAFKA-15309) Add custom error handler to Producer

[ https://issues.apache.org/jira/browse/KAFKA-15309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17761924#comment-17761924 ] Matthias J. Sax commented on KAFKA-15309: - Sure, the ticket is up for grabs. Note, that we will

[jira] [Comment Edited] (KAFKA-15417) JoinWindow does not seem to work properly with a KStream - KStream - LeftJoin()

[ https://issues.apache.org/jira/browse/KAFKA-15417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17761918#comment-17761918 ] Matthias J. Sax edited comment on KAFKA-15417 at 9/5/23 1:57 AM: - I

[jira] [Comment Edited] (KAFKA-15417) JoinWindow does not seem to work properly with a KStream - KStream - LeftJoin()

[ https://issues.apache.org/jira/browse/KAFKA-15417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17761918#comment-17761918 ] Matthias J. Sax edited comment on KAFKA-15417 at 9/5/23 1:56 AM: - I

[jira] [Comment Edited] (KAFKA-15417) JoinWindow does not seem to work properly with a KStream - KStream - LeftJoin()

[ https://issues.apache.org/jira/browse/KAFKA-15417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17761918#comment-17761918 ] Matthias J. Sax edited comment on KAFKA-15417 at 9/5/23 1:56 AM: - I

[jira] [Comment Edited] (KAFKA-15417) JoinWindow does not seem to work properly with a KStream - KStream - LeftJoin()

[ https://issues.apache.org/jira/browse/KAFKA-15417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17761918#comment-17761918 ] Matthias J. Sax edited comment on KAFKA-15417 at 9/5/23 1:55 AM: - I

[jira] [Commented] (KAFKA-15417) JoinWindow does not seem to work properly with a KStream - KStream - LeftJoin()

[ https://issues.apache.org/jira/browse/KAFKA-15417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17761918#comment-17761918 ] Matthias J. Sax commented on KAFKA-15417: - I believe it could be related to an internal

[jira] [Updated] (KAFKA-15383) Replace EasyMock with Mockito for KTableImplTest

[ https://issues.apache.org/jira/browse/KAFKA-15383?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-15383: Component/s: streams unit tests > Replace EasyMock with Mockito for

[jira] [Updated] (KAFKA-15385) Replace EasyMock with Mockito for AbstractStreamTest

[ https://issues.apache.org/jira/browse/KAFKA-15385?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-15385: Component/s: streams unit tests > Replace EasyMock with Mockito for

[jira] [Updated] (KAFKA-15382) Replace EasyMock with Mockito for KStreamTransformValuesTest

[ https://issues.apache.org/jira/browse/KAFKA-15382?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-15382: Component/s: streams unit tests > Replace EasyMock with Mockito for

[jira] [Updated] (KAFKA-15384) Replace EasyMock with Mockito for KTableTransformValuesTest

[ https://issues.apache.org/jira/browse/KAFKA-15384?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-15384: Component/s: streams unit tests > Replace EasyMock with Mockito for

[GitHub] [kafka] satishd merged pull request #14307: KAFKA-15410: Expand partitions, segment deletion by retention and enable remote log on topic integration tests (1/4)

satishd merged PR #14307: URL: https://github.com/apache/kafka/pull/14307 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] satishd commented on pull request #14307: KAFKA-15410: Expand partitions, segment deletion by retention and enable remote log on topic integration tests (1/4)

satishd commented on PR #14307: URL: https://github.com/apache/kafka/pull/14307#issuecomment-1705769550 There are a couple of unrelated tests failed in Jenkins jobs, merging to trunk and 3.6. -- This is an automated message from the Apache Git Service. To respond to the message, please

[jira] [Resolved] (KAFKA-14936) Add Grace Period To Stream Table Join

[ https://issues.apache.org/jira/browse/KAFKA-14936?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Walker Carlson resolved KAFKA-14936. Resolution: Done > Add Grace Period To Stream Table Join >

[jira] [Updated] (KAFKA-14936) Add Grace Period To Stream Table Join

[ https://issues.apache.org/jira/browse/KAFKA-14936?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Walker Carlson updated KAFKA-14936: --- Fix Version/s: 3.6.0 > Add Grace Period To Stream Table Join >

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #14182: KAFKA 14515: Optimized Uniform Rack Aware Assignor

rreddy-22 commented on code in PR #14182: URL: https://github.com/apache/kafka/pull/14182#discussion_r1315178928 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/assignor/OptimizedUniformAssignmentBuilderTest.java: ## @@ -0,0 +1,1070 @@ +/* + * Licensed to

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #14182: KAFKA 14515: Optimized Uniform Rack Aware Assignor

rreddy-22 commented on code in PR #14182: URL: https://github.com/apache/kafka/pull/14182#discussion_r1315178781 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/UniformAssignor.java: ## @@ -0,0 +1,270 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #14182: KAFKA 14515: Optimized Uniform Rack Aware Assignor

rreddy-22 commented on code in PR #14182: URL: https://github.com/apache/kafka/pull/14182#discussion_r1315178560 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/OptimizedUniformAssignmentBuilder.java: ## @@ -0,0 +1,399 @@ +/* + * Licensed to the

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #14182: KAFKA 14515: Optimized Uniform Rack Aware Assignor

rreddy-22 commented on code in PR #14182: URL: https://github.com/apache/kafka/pull/14182#discussion_r1315178473 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/OptimizedUniformAssignmentBuilder.java: ## @@ -0,0 +1,399 @@ +/* + * Licensed to the

[GitHub] [kafka] kamalcph commented on a diff in pull request #14329: KAFKA-15410: Delete topic integration test with LocalTieredStorage and TBRLMM (3/4)

kamalcph commented on code in PR #14329: URL: https://github.com/apache/kafka/pull/14329#discussion_r1315134679 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -379,9 +379,9 @@ public void stopPartitions(Set topicPartitions,

[GitHub] [kafka] kamalcph commented on a diff in pull request #14329: KAFKA-15410: Delete topic integration test with LocalTieredStorage and TBRLMM (3/4)

kamalcph commented on code in PR #14329: URL: https://github.com/apache/kafka/pull/14329#discussion_r1315134679 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -379,9 +379,9 @@ public void stopPartitions(Set topicPartitions,

[jira] [Updated] (KAFKA-15388) Handle topics that were having compaction as retention earlier are changed to delete only retention policy and onboarded to tiered storage.

[ https://issues.apache.org/jira/browse/KAFKA-15388?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Divij Vaidya updated KAFKA-15388: - Issue Type: Bug (was: Task) > Handle topics that were having compaction as retention earlier

[jira] [Updated] (KAFKA-15420) Kafka Tiered Storage V1

[ https://issues.apache.org/jira/browse/KAFKA-15420?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Divij Vaidya updated KAFKA-15420: - Labels: KIP-405 (was: ) > Kafka Tiered Storage V1 > --- > >

[jira] [Commented] (KAFKA-15388) Handle topics that were having compaction as retention earlier are changed to delete only retention policy and onboarded to tiered storage.

[ https://issues.apache.org/jira/browse/KAFKA-15388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17761859#comment-17761859 ] Divij Vaidya commented on KAFKA-15388: -- Hey [~satish.duggana]  If supporting TS on historically

[GitHub] [kafka] divijvaidya commented on a diff in pull request #14329: KAFKA-15410: Delete topic integration test with LocalTieredStorage and TBRLMM (3/4)

divijvaidya commented on code in PR #14329: URL: https://github.com/apache/kafka/pull/14329#discussion_r1315061717 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -379,9 +379,9 @@ public void stopPartitions(Set topicPartitions,

[GitHub] [kafka] divijvaidya commented on a diff in pull request #14329: KAFKA-15410: Delete topic integration test with LocalTieredStorage and TBRLMM (3/4)

divijvaidya commented on code in PR #14329: URL: https://github.com/apache/kafka/pull/14329#discussion_r1314961838 ## storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/TopicBasedRemoteLogMetadataManager.java: ## @@ -438,10 +440,19 @@ private void

[GitHub] [kafka] divijvaidya commented on a diff in pull request #14307: KAFKA-15410: Expand partitions, segment deletion by retention and enable remote log on topic integration tests (1/4)

divijvaidya commented on code in PR #14307: URL: https://github.com/apache/kafka/pull/14307#discussion_r1315045974 ## storage/src/test/java/org/apache/kafka/tiered/storage/integration/EnableRemoteLogOnTopicTest.java: ## @@ -0,0 +1,89 @@ +/* + * Licensed to the Apache Software

[jira] [Updated] (KAFKA-15431) Add support to assert offloaded segment for already produced event in Tiered Storage Framework

[ https://issues.apache.org/jira/browse/KAFKA-15431?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kamal Chandraprakash updated KAFKA-15431: - Parent: (was: KAFKA-15420) Issue Type: Task (was: Sub-task) > Add

[GitHub] [kafka] kamalcph commented on a diff in pull request #14307: KAFKA-15410: Expand partitions, segment deletion by retention and enable remote log on topic integration tests (1/4)

kamalcph commented on code in PR #14307: URL: https://github.com/apache/kafka/pull/14307#discussion_r1315003306 ## storage/src/test/java/org/apache/kafka/tiered/storage/integration/PartitionsExpandTest.java: ## @@ -0,0 +1,106 @@ +/* + * Licensed to the Apache Software

[jira] [Updated] (KAFKA-15431) Add support to assert offloaded segment for already produced event in Tiered Storage Framework

[ https://issues.apache.org/jira/browse/KAFKA-15431?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kamal Chandraprakash updated KAFKA-15431: - Parent: KAFKA-15420 Issue Type: Sub-task (was: Task) > Add support to

[jira] [Created] (KAFKA-15431) Add support to assert offloaded segment for already produced event in Tiered Storage Framework

Kamal Chandraprakash created KAFKA-15431: Summary: Add support to assert offloaded segment for already produced event in Tiered Storage Framework Key: KAFKA-15431 URL:

[GitHub] [kafka] kamalcph commented on a diff in pull request #14307: KAFKA-15410: Expand partitions, segment deletion by retention and enable remote log on topic integration tests (1/4)

kamalcph commented on code in PR #14307: URL: https://github.com/apache/kafka/pull/14307#discussion_r1314999348 ## storage/src/test/java/org/apache/kafka/tiered/storage/integration/EnableRemoteLogOnTopicTest.java: ## @@ -0,0 +1,89 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] kamalcph commented on a diff in pull request #14307: KAFKA-15410: Expand partitions, segment deletion by retention and enable remote log on topic integration tests (1/4)

kamalcph commented on code in PR #14307: URL: https://github.com/apache/kafka/pull/14307#discussion_r1314999348 ## storage/src/test/java/org/apache/kafka/tiered/storage/integration/EnableRemoteLogOnTopicTest.java: ## @@ -0,0 +1,89 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] dajac commented on a diff in pull request #14271: KAFKA-14503: Implement ListGroups

dajac commented on code in PR #14271: URL: https://github.com/apache/kafka/pull/14271#discussion_r1314944364 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorShard.java: ## @@ -306,6 +308,19 @@ public CoordinatorResult commitOffset(

[GitHub] [kafka] divijvaidya commented on a diff in pull request #14307: KAFKA-15410: Expand partitions, segment deletion by retention and enable remote log on topic integration tests (1/4)

divijvaidya commented on code in PR #14307: URL: https://github.com/apache/kafka/pull/14307#discussion_r1314943942 ## storage/src/test/java/org/apache/kafka/tiered/storage/integration/PartitionsExpandTest.java: ## @@ -0,0 +1,106 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] dopuskh3 closed pull request #14332: [MINOR] Fix TopicPartition comparison

dopuskh3 closed pull request #14332: [MINOR] Fix TopicPartition comparison URL: https://github.com/apache/kafka/pull/14332 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[jira] [Updated] (KAFKA-15430) Kafla create replca partition on controller node

[ https://issues.apache.org/jira/browse/KAFKA-15430?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrii Vysotskiy updated KAFKA-15430: - Priority: Major (was: Minor) > Kafla create replca partition on controller node >

[GitHub] [kafka] dengziming commented on a diff in pull request #14306: KAFKA-15369: Implement KIP-919: Allow AC to Talk Directly with Controllers

dengziming commented on code in PR #14306: URL: https://github.com/apache/kafka/pull/14306#discussion_r1314913328 ## server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java: ## @@ -320,6 +323,19 @@ public short registerBrokerRecordVersion() { }

[GitHub] [kafka] satishd commented on pull request #14332: [MINOR] Fix TopicPartition comparison

satishd commented on PR #14332: URL: https://github.com/apache/kafka/pull/14332#issuecomment-1705221588 Thanks @dopuskh3 for catching and raising the PR. As @showuon mentioned, it is addressed by

[GitHub] [kafka] kamalcph commented on a diff in pull request #14307: KAFKA-15410: Expand partitions, segment deletion by retention and enable remote log on topic integration tests (1/4)

kamalcph commented on code in PR #14307: URL: https://github.com/apache/kafka/pull/14307#discussion_r1314900757 ## storage/src/test/java/org/apache/kafka/tiered/storage/integration/BaseDeleteSegmentsTest.java: ## @@ -0,0 +1,72 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] dopuskh3 commented on pull request #14332: [MINOR] Fix TopicPartition comparison

dopuskh3 commented on PR #14332: URL: https://github.com/apache/kafka/pull/14332#issuecomment-1705208040 cc: @satishd @jeqo -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [kafka] dopuskh3 opened a new pull request, #14332: [MINOR] Fix TopicPartition comparison

dopuskh3 opened a new pull request, #14332: URL: https://github.com/apache/kafka/pull/14332 This only affect logging -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [kafka] clolov commented on a diff in pull request #14307: KAFKA-15410: Expand partitions, segment deletion by retention and enable remote log on topic integration tests (1/4)

clolov commented on code in PR #14307: URL: https://github.com/apache/kafka/pull/14307#discussion_r1314892554 ## storage/src/test/java/org/apache/kafka/tiered/storage/integration/BaseDeleteSegmentsTest.java: ## @@ -0,0 +1,72 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [kafka] kamalcph commented on a diff in pull request #14328: KAFKA-15410: Reassign replica expand, move and shrink integration tests (2/4)

kamalcph commented on code in PR #14328: URL: https://github.com/apache/kafka/pull/14328#discussion_r1314897616 ## storage/src/test/java/org/apache/kafka/tiered/storage/integration/ReassignReplicaShrinkTest.java: ## @@ -0,0 +1,104 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] kamalcph commented on a diff in pull request #14328: KAFKA-15410: Reassign replica expand, move and shrink integration tests (2/4)

kamalcph commented on code in PR #14328: URL: https://github.com/apache/kafka/pull/14328#discussion_r1314896591 ## storage/src/test/java/org/apache/kafka/tiered/storage/integration/ReassignReplicaExpandTest.java: ## @@ -0,0 +1,99 @@ +/* + * Licensed to the Apache Software

[jira] [Updated] (KAFKA-14133) Remaining EasyMock to Mockito tests

[ https://issues.apache.org/jira/browse/KAFKA-14133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christo Lolov updated KAFKA-14133: -- Description: {color:#de350b}There are tests which use both PowerMock and EasyMock. I have

[GitHub] [kafka] showuon commented on a diff in pull request #14306: KAFKA-15369: Implement KIP-919: Allow AC to Talk Directly with Controllers

showuon commented on code in PR #14306: URL: https://github.com/apache/kafka/pull/14306#discussion_r1314886326 ## clients/src/main/java/org/apache/kafka/common/requests/ControllerRegistrationRequest.java: ## @@ -0,0 +1,73 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [kafka] dengziming commented on a diff in pull request #14306: KAFKA-15369: Implement KIP-919: Allow AC to Talk Directly with Controllers

dengziming commented on code in PR #14306: URL: https://github.com/apache/kafka/pull/14306#discussion_r1314864521 ## clients/src/main/java/org/apache/kafka/common/requests/ControllerRegistrationRequest.java: ## @@ -0,0 +1,73 @@ +/* + * Licensed to the Apache Software Foundation

[jira] [Updated] (KAFKA-15293) Update metrics doc to add tiered storage metrics

[ https://issues.apache.org/jira/browse/KAFKA-15293?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Satish Duggana updated KAFKA-15293: --- Component/s: documentation > Update metrics doc to add tiered storage metrics >

[jira] [Commented] (KAFKA-13421) Fix ConsumerBounceTest#testRollingBrokerRestartsWithSmallerMaxGroupSizeConfigDisruptsBigGroup

[ https://issues.apache.org/jira/browse/KAFKA-13421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17761806#comment-17761806 ] Satish Duggana commented on KAFKA-13421: Moving it to 3.7.0 as there is not much activity on

[jira] [Updated] (KAFKA-13421) Fix ConsumerBounceTest#testRollingBrokerRestartsWithSmallerMaxGroupSizeConfigDisruptsBigGroup

[ https://issues.apache.org/jira/browse/KAFKA-13421?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Satish Duggana updated KAFKA-13421: --- Fix Version/s: 3.7.0 (was: 3.6.0) > Fix >

[GitHub] [kafka] showuon commented on pull request #14307: KAFKA-15410: Expand partitions, segment deletion by retention and enable remote log on topic integration tests (1/4)

showuon commented on PR #14307: URL: https://github.com/apache/kafka/pull/14307#issuecomment-1705153637 Will wait for @clolov 's review before merging it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [kafka] divijvaidya commented on a diff in pull request #14331: Add documentation for tiered storage metrics

divijvaidya commented on code in PR #14331: URL: https://github.com/apache/kafka/pull/14331#discussion_r1314856715 ## docs/ops.html: ## @@ -1545,6 +1545,51 @@

[GitHub] [kafka] satishd commented on a diff in pull request #14307: KAFKA-15410: Expand partitions, segment deletion by retention and enable remote log on topic integration tests (1/4)

satishd commented on code in PR #14307: URL: https://github.com/apache/kafka/pull/14307#discussion_r1314858032 ## storage/src/test/java/org/apache/kafka/tiered/storage/integration/PartitionsExpandTest.java: ## @@ -0,0 +1,106 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [kafka] yashmayya commented on pull request #14152: KAFKA-7438: Migrate WindowStoreBuilderTest from EasyMock to Mockito

yashmayya commented on PR #14152: URL: https://github.com/apache/kafka/pull/14152#issuecomment-1705144816 Thanks Divij and no worries, this was pretty low priority!  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [kafka] kamalcph commented on a diff in pull request #14307: KAFKA-15410: Expand partitions, segment deletion by retention and enable remote log on topic integration tests (1/4)

kamalcph commented on code in PR #14307: URL: https://github.com/apache/kafka/pull/14307#discussion_r1314851919 ## storage/src/test/java/org/apache/kafka/tiered/storage/integration/PartitionsExpandTest.java: ## @@ -0,0 +1,106 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] divijvaidya merged pull request #14152: KAFKA-7438: Migrate WindowStoreBuilderTest from EasyMock to Mockito

divijvaidya merged PR #14152: URL: https://github.com/apache/kafka/pull/14152 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] divijvaidya commented on pull request #14152: KAFKA-7438: Migrate WindowStoreBuilderTest from EasyMock to Mockito

divijvaidya commented on PR #14152: URL: https://github.com/apache/kafka/pull/14152#issuecomment-1705136079 I have verified that that the test passes in CI

[GitHub] [kafka] abhijeetk88 commented on a diff in pull request #14331: Add documentation for tiered storage metrics

abhijeetk88 commented on code in PR #14331: URL: https://github.com/apache/kafka/pull/14331#discussion_r1314820039 ## docs/ops.html: ## @@ -1545,6 +1545,51 @@

[GitHub] [kafka] satishd commented on a diff in pull request #14331: Add documentation for tiered storage metrics

satishd commented on code in PR #14331: URL: https://github.com/apache/kafka/pull/14331#discussion_r1314813270 ## docs/ops.html: ## @@ -1545,6 +1545,51 @@

[GitHub] [kafka] divijvaidya merged pull request #14223: KAFKA-14133: Move AbstractStreamTest and RocksDBMetricsRecordingTriggerTest to Mockito

divijvaidya merged PR #14223: URL: https://github.com/apache/kafka/pull/14223 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Updated] (KAFKA-15352) Ensure consistency while deleting the remote log segments

[ https://issues.apache.org/jira/browse/KAFKA-15352?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kamal Chandraprakash updated KAFKA-15352: - Description: In Kafka-14888, the remote log segments are deleted which breaches

[jira] [Updated] (KAFKA-15351) Update log-start-offset after leader election for topics enabled with remote storage

[ https://issues.apache.org/jira/browse/KAFKA-15351?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kamal Chandraprakash updated KAFKA-15351: - Description: Case-1: In the FETCH response, the leader-log-start-offset will

[GitHub] [kafka] kamalcph commented on a diff in pull request #14330: KAFKA-15410: Delete records with tiered storage integration test (4/4)

kamalcph commented on code in PR #14330: URL: https://github.com/apache/kafka/pull/14330#discussion_r1314697994 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -1066,50 +1066,53 @@ public static boolean

[GitHub] [kafka] divijvaidya commented on a diff in pull request #14322: KAFKA-15418: update statement on decompression

divijvaidya commented on code in PR #14322: URL: https://github.com/apache/kafka/pull/14322#discussion_r1314750361 ## docs/design.html: ## @@ -136,8 +136,10 @@ -Kafka supports this with an efficient batching format. A batch of messages can be clumped together compressed

[jira] [Commented] (KAFKA-14936) Add Grace Period To Stream Table Join

[ https://issues.apache.org/jira/browse/KAFKA-14936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17761766#comment-17761766 ] Satish Duggana commented on KAFKA-14936: [~wcarlson5] Is this completed for 3.6.0? If yes,

[GitHub] [kafka] kamalcph commented on a diff in pull request #14330: KAFKA-15410: Delete records with tiered storage integration test (4/4)

kamalcph commented on code in PR #14330: URL: https://github.com/apache/kafka/pull/14330#discussion_r1314697994 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -1066,50 +1066,53 @@ public static boolean

[jira] [Commented] (KAFKA-12473) Make the "cooperative-sticky, range" as the default assignor

[ https://issues.apache.org/jira/browse/KAFKA-12473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17761763#comment-17761763 ] Satish Duggana commented on KAFKA-12473: Removing the KIP from 3.6.0 release plan as it does not

[GitHub] [kafka] kamalcph commented on a diff in pull request #14330: KAFKA-15410: Delete records with tiered storage integration test (4/4)

kamalcph commented on code in PR #14330: URL: https://github.com/apache/kafka/pull/14330#discussion_r1314695377 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -1066,50 +1066,53 @@ public static boolean

[GitHub] [kafka] kamalcph commented on a diff in pull request #14330: KAFKA-15410: Delete records with tiered storage integration test (4/4)

kamalcph commented on code in PR #14330: URL: https://github.com/apache/kafka/pull/14330#discussion_r1314695377 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -1066,50 +1066,53 @@ public static boolean

[GitHub] [kafka] dajac commented on pull request #14321: KAFKA-14499: [6/N] Add MemberId and MemberEpoch to OffsetFetchRequest

dajac commented on PR #14321: URL: https://github.com/apache/kafka/pull/14321#issuecomment-1704917384 @rreddy-22 @CalvinConfluent @jolshan Thanks for your comments. I have addressed all of them. I have also changed a bit the schema and fixed a few other tests. -- This is an automated

[GitHub] [kafka] dajac commented on a diff in pull request #14321: KAFKA-14499: [6/N] Add MemberId and MemberEpoch to OffsetFetchRequest

dajac commented on code in PR #14321: URL: https://github.com/apache/kafka/pull/14321#discussion_r1314671160 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroupTest.java: ## @@ -631,4 +631,33 @@ public void testValidateOffsetCommit() {

[GitHub] [kafka] dajac commented on a diff in pull request #14321: KAFKA-14499: [6/N] Add MemberId and MemberEpoch to OffsetFetchRequest

dajac commented on code in PR #14321: URL: https://github.com/apache/kafka/pull/14321#discussion_r131483 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroupTest.java: ## @@ -631,4 +631,33 @@ public void testValidateOffsetCommit() {

[GitHub] [kafka] dajac commented on a diff in pull request #14321: KAFKA-14499: [6/N] Add MemberId and MemberEpoch to OffsetFetchRequest

dajac commented on code in PR #14321: URL: https://github.com/apache/kafka/pull/14321#discussion_r1314665557 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/OffsetMetadataManagerTest.java: ## @@ -181,10 +181,28 @@ public List fetchOffsets(

[GitHub] [kafka] dajac commented on a diff in pull request #14321: KAFKA-14499: [6/N] Add MemberId and MemberEpoch to OffsetFetchRequest

dajac commented on code in PR #14321: URL: https://github.com/apache/kafka/pull/14321#discussion_r1314664510 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/OffsetMetadataManagerTest.java: ## @@ -181,10 +181,28 @@ public List fetchOffsets(

[GitHub] [kafka] dajac commented on a diff in pull request #14321: KAFKA-14499: [6/N] Add MemberId and MemberEpoch to OffsetFetchRequest

dajac commented on code in PR #14321: URL: https://github.com/apache/kafka/pull/14321#discussion_r1314663349 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/generic/GenericGroup.java: ## @@ -823,9 +823,17 @@ public void validateOffsetCommit( /**

[GitHub] [kafka] dajac commented on a diff in pull request #14321: KAFKA-14499: [6/N] Add MemberId and MemberEpoch to OffsetFetchRequest

dajac commented on code in PR #14321: URL: https://github.com/apache/kafka/pull/14321#discussion_r1314661887 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/OffsetMetadataManagerTest.java: ## @@ -1409,6 +1444,82 @@ public void

[jira] [Updated] (KAFKA-6527) Transient failure in DynamicBrokerReconfigurationTest.testDefaultTopicConfig

[ https://issues.apache.org/jira/browse/KAFKA-6527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Satish Duggana updated KAFKA-6527: -- Fix Version/s: 3.7.0 (was: 3.6.0) > Transient failure in

[jira] [Commented] (KAFKA-6527) Transient failure in DynamicBrokerReconfigurationTest.testDefaultTopicConfig

[ https://issues.apache.org/jira/browse/KAFKA-6527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17761748#comment-17761748 ] Satish Duggana commented on KAFKA-6527: --- Moved to 3.7.0 as this JIRA is not yet assigned and we are

[GitHub] [kafka] showuon commented on pull request #13908: KAFKA-15052 Fix the flaky testBalancePartitionLeaders - part II

showuon commented on PR #13908: URL: https://github.com/apache/kafka/pull/13908#issuecomment-1704888456 Backported into 3.6 branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Resolved] (KAFKA-15052) Fix flaky test QuorumControllerTest.testBalancePartitionLeaders()

[ https://issues.apache.org/jira/browse/KAFKA-15052?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen resolved KAFKA-15052. --- Resolution: Fixed > Fix flaky test QuorumControllerTest.testBalancePartitionLeaders() >

[jira] [Updated] (KAFKA-15052) Fix flaky test QuorumControllerTest.testBalancePartitionLeaders()

[ https://issues.apache.org/jira/browse/KAFKA-15052?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen updated KAFKA-15052: -- Fix Version/s: 3.6.0 (was: 3.7.0) > Fix flaky test

[GitHub] [kafka] showuon merged pull request #13908: KAFKA-15052 Fix the flaky testBalancePartitionLeaders - part II

showuon merged PR #13908: URL: https://github.com/apache/kafka/pull/13908 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] showuon commented on a diff in pull request #14307: KAFKA-15410: Expand partitions, segment deletion by retention and enable remote log on topic integration tests (1/4)

showuon commented on code in PR #14307: URL: https://github.com/apache/kafka/pull/14307#discussion_r1314623009 ## storage/src/test/java/org/apache/kafka/tiered/storage/utils/BrokerLocalStorage.java: ## @@ -56,7 +56,7 @@ public Integer getBrokerId() { /** * Wait

[GitHub] [kafka] abhijeetk88 opened a new pull request, #14331: Add documentation for tiered storage metrics

abhijeetk88 opened a new pull request, #14331: URL: https://github.com/apache/kafka/pull/14331 Added documentation for tiered storage metrics. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build

[jira] [Updated] (KAFKA-15430) Kafla create replca partition on controller node

[ https://issues.apache.org/jira/browse/KAFKA-15430?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrii Vysotskiy updated KAFKA-15430: - Description: I have configuration 5 nodes (KRAFT mode), with next roles: 4

[jira] [Created] (KAFKA-15430) Kafla create replca partition on controller node

Andrii Vysotskiy created KAFKA-15430: Summary: Kafla create replca partition on controller node Key: KAFKA-15430 URL: https://issues.apache.org/jira/browse/KAFKA-15430 Project: Kafka

[GitHub] [kafka] omkreddy merged pull request #14318: KAFKA-15422: Update documentation for Delegation Tokens in Kafka with KRaft

omkreddy merged PR #14318: URL: https://github.com/apache/kafka/pull/14318 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] omkreddy commented on pull request #14318: KAFKA-15422: Update documentation for Delegation Tokens in Kafka with KRaft

omkreddy commented on PR #14318: URL: https://github.com/apache/kafka/pull/14318#issuecomment-1704861029 Test failures are not related, merging this minor doc change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [kafka] elkkhan commented on a diff in pull request #14077: KAFKA-14112: Expose replication-offset-lag Mirror metric

elkkhan commented on code in PR #14077: URL: https://github.com/apache/kafka/pull/14077#discussion_r1314605208 ## connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorSourceMetrics.java: ## @@ -104,12 +108,25 @@ class MirrorSourceMetrics implements AutoCloseable {

[GitHub] [kafka] hudeqi commented on a diff in pull request #14077: KAFKA-14112: Expose replication-offset-lag Mirror metric

hudeqi commented on code in PR #14077: URL: https://github.com/apache/kafka/pull/14077#discussion_r1314592488 ## connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorSourceMetrics.java: ## @@ -104,12 +108,25 @@ class MirrorSourceMetrics implements AutoCloseable {

[GitHub] [kafka] dajac commented on a diff in pull request #14321: KAFKA-14499: [6/N] Add MemberId and MemberEpoch to OffsetFetchRequest

dajac commented on code in PR #14321: URL: https://github.com/apache/kafka/pull/14321#discussion_r1314590003 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroup.java: ## @@ -538,17 +537,46 @@ public void validateOffsetCommit( if

[GitHub] [kafka] hudeqi commented on a diff in pull request #14077: KAFKA-14112: Expose replication-offset-lag Mirror metric

hudeqi commented on code in PR #14077: URL: https://github.com/apache/kafka/pull/14077#discussion_r1314583243 ## connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorSourceTask.java: ## @@ -282,6 +285,38 @@ SourceRecord convertRecord(ConsumerRecord record) {

[GitHub] [kafka] clolov commented on pull request #14307: KAFKA-15410: Expand partitions, segment deletion by retention and enable remote log on topic integration tests (1/4)

clolov commented on PR #14307: URL: https://github.com/apache/kafka/pull/14307#issuecomment-1704805274 I will aim to provide a review by the end of the day! Thanks for the effort -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[jira] [Commented] (KAFKA-15399) Enable OffloadAndConsumeFromLeader test

[ https://issues.apache.org/jira/browse/KAFKA-15399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17761727#comment-17761727 ] Christo Lolov commented on KAFKA-15399: --- Heya [~pnee], [~lianetm] and [~showuon]! I had a look at

[GitHub] [kafka] ocadaruma commented on pull request #14242: KAFKA-15046: Get rid of unnecessary fsyncs inside UnifiedLog.lock to stabilize performance

ocadaruma commented on PR #14242: URL: https://github.com/apache/kafka/pull/14242#issuecomment-1704786562 @showuon Thank you for your review. 0) Got it. I revised the PR description to include analysis. 2) The actual change is made against `SnapshotFile.java#renameTo`, which is

[GitHub] [kafka] showuon commented on pull request #14242: KAFKA-15046: Get rid of unnecessary fsyncs inside UnifiedLog.lock to stabilize performance

showuon commented on PR #14242: URL: https://github.com/apache/kafka/pull/14242#issuecomment-1704740274 @ocadaruma , thanks for the improvement! Some high level questions: 0. Although you've added comments in the JIRA, it'd better you add your analysis and what/why you've changed in the

[GitHub] [kafka] nizhikov commented on pull request #14217: KAFKA-14595 ReassignPartitionsCommandArgsTest rewritten in java

nizhikov commented on PR #14217: URL: https://github.com/apache/kafka/pull/14217#issuecomment-1704725921 Hello @gharris1727 Thanks for the review. Are you ready to merge this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] satishd commented on a diff in pull request #14329: KAFKA-15410: Delete topic integration test with LocalTieredStorage and TBRLMM (3/4)

satishd commented on code in PR #14329: URL: https://github.com/apache/kafka/pull/14329#discussion_r1314498306 ## storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/ConsumerManager.java: ## @@ -98,35 +98,28 @@ public void

  1   2   >