[jira] [Updated] (KAFKA-15444) KIP-974: Docker Image for GraalVM based Native Kafka Broker

2023-09-07 Thread Krishna Agarwal (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15444?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Krishna Agarwal updated KAFKA-15444: Description: [KIP-974: Docker Image for GraalVM based Native Kafka

[jira] [Updated] (KAFKA-15445) KIP-975: Docker Image for Apache Kafka

2023-09-07 Thread Krishna Agarwal (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15445?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Krishna Agarwal updated KAFKA-15445: Description: [KIP-975: Docker Image for Apache

[jira] [Updated] (KAFKA-15445) KIP-975: Docker Image for Apache Kafka

2023-09-07 Thread Krishna Agarwal (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15445?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Krishna Agarwal updated KAFKA-15445: Description:

[jira] [Created] (KAFKA-15445) KIP-975: Docker Image for Apache Kafka

2023-09-07 Thread Krishna Agarwal (Jira)
Krishna Agarwal created KAFKA-15445: --- Summary: KIP-975: Docker Image for Apache Kafka Key: KAFKA-15445 URL: https://issues.apache.org/jira/browse/KAFKA-15445 Project: Kafka Issue Type: New

[jira] [Created] (KAFKA-15444) KIP-974: Docker Image for GraalVM based Native Kafka Broker

2023-09-07 Thread Krishna Agarwal (Jira)
Krishna Agarwal created KAFKA-15444: --- Summary: KIP-974: Docker Image for GraalVM based Native Kafka Broker Key: KAFKA-15444 URL: https://issues.apache.org/jira/browse/KAFKA-15444 Project: Kafka

[GitHub] [kafka] github-actions[bot] commented on pull request #13836: KAFKA-14218: Replace temp file handler with JUnit 5 Temporary Directory Support

2023-09-07 Thread via GitHub
github-actions[bot] commented on PR #13836: URL: https://github.com/apache/kafka/pull/13836#issuecomment-1711026816 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has

[jira] [Commented] (KAFKA-14912) Introduce a configuration for remote index cache size, preferably a dynamic config.

2023-09-07 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17762931#comment-17762931 ] Luke Chen commented on KAFKA-14912: --- Agree to limit the cache by size, instead of the total entry

[GitHub] [kafka] showuon commented on a diff in pull request #14287: [Minor] Check the existence of AppInfo for the given ID before creating a new mbean of the same name

2023-09-07 Thread via GitHub
showuon commented on code in PR #14287: URL: https://github.com/apache/kafka/pull/14287#discussion_r1319285955 ## clients/src/main/java/org/apache/kafka/common/utils/AppInfoParser.java: ## @@ -60,8 +60,13 @@ public static String getCommitId() { public static synchronized

[GitHub] [kafka] mjsax commented on pull request #14224: MINOR: fix currentLag javadoc

2023-09-07 Thread via GitHub
mjsax commented on PR #14224: URL: https://github.com/apache/kafka/pull/14224#issuecomment-1710988445 Thanks for the fix! Merged to `trunk` and cherry-picked to `3.6` branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] mjsax merged pull request #14224: MINOR: fix currentLag javadoc

2023-09-07 Thread via GitHub
mjsax merged PR #14224: URL: https://github.com/apache/kafka/pull/14224 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] mjsax commented on pull request #12988: KAFKA-14405: Log a warning when users attempt to set a config controlled by Streams

2023-09-07 Thread via GitHub
mjsax commented on PR #12988: URL: https://github.com/apache/kafka/pull/12988#issuecomment-1710983828 Yes, that's expected and we should also cover this case. Because there are multiple consumer, we use `consumer.` to allow users to change a config for _all_ consumer. If you want to

[GitHub] [kafka] mjsax commented on pull request #14221: KAFKA-15338: The metric group documentation for metrics added in KAFK…

2023-09-07 Thread via GitHub
mjsax commented on PR #14221: URL: https://github.com/apache/kafka/pull/14221#issuecomment-1710978564 Thanks for the PR @atu-sharm. Merged to `trunk`, and cherry-picked to `3.6`, `3.5`, `3.4`, and `3.3` branches. Could you also do a PR against https://github.com/apache/kafka-site and

[GitHub] [kafka] mjsax merged pull request #14221: KAFKA-15338: The metric group documentation for metrics added in KAFK…

2023-09-07 Thread via GitHub
mjsax merged PR #14221: URL: https://github.com/apache/kafka/pull/14221 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] mjsax commented on a diff in pull request #14317: KAFKA-13973: Fix inflated block cache metrics

2023-09-07 Thread via GitHub
mjsax commented on code in PR #14317: URL: https://github.com/apache/kafka/pull/14317#discussion_r1319266372 ## streams/src/main/java/org/apache/kafka/streams/state/internals/metrics/RocksDBMetricsRecorder.java: ## @@ -373,14 +373,14 @@ private Gauge

[jira] [Created] (KAFKA-15443) Upgrade RocksDB dependency

2023-09-07 Thread Matthias J. Sax (Jira)
Matthias J. Sax created KAFKA-15443: --- Summary: Upgrade RocksDB dependency Key: KAFKA-15443 URL: https://issues.apache.org/jira/browse/KAFKA-15443 Project: Kafka Issue Type: Task

[GitHub] [kafka] cmccabe commented on pull request #14351: KAFKA-15441 Allow broker heartbeats to complete in metadata transaction

2023-09-07 Thread via GitHub
cmccabe commented on PR #14351: URL: https://github.com/apache/kafka/pull/14351#issuecomment-1710954958 Thinking about this more, If something runs in premigration it should complete in premigration. But maybe not complete inside a transaction more generally. Like I can imagine us doing

[jira] [Commented] (KAFKA-12473) Make the "cooperative-sticky, range" as the default assignor

2023-09-07 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17762920#comment-17762920 ] Luke Chen commented on KAFKA-12473: --- Yes, we can wait for KIP-848. Thanks [~dajac]. > Make the

[jira] [Commented] (KAFKA-9800) [KIP-580] Client Exponential Backoff Implementation

2023-09-07 Thread Satish Duggana (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17762921#comment-17762921 ] Satish Duggana commented on KAFKA-9800: --- [~junrao] [~schofielaj] Are you planning to merge these

[jira] [Assigned] (KAFKA-12473) Make the "cooperative-sticky, range" as the default assignor

2023-09-07 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12473?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen reassigned KAFKA-12473: - Assignee: (was: Luke Chen) > Make the "cooperative-sticky, range" as the default assignor

[GitHub] [kafka] satishd commented on pull request #14111: KAFKA-9800: Exponential backoff for Kafka clients - KIP-580

2023-09-07 Thread via GitHub
satishd commented on PR #14111: URL: https://github.com/apache/kafka/pull/14111#issuecomment-1710948188 @junrao @AndrewJSchofield Are you planning to merge these changes to 3.6 branch? -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [kafka] mjsax commented on pull request #14157: KAFKA-15303: Avoid unnecessary re-serialization in FK-join

2023-09-07 Thread via GitHub
mjsax commented on PR #14157: URL: https://github.com/apache/kafka/pull/14157#issuecomment-1710947305 \cc @cadonna @ableegoldman @lucasbru -- anyone has some spare cycles to review so we can make progress? -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kafka] philipnee commented on pull request #14313: KAFKA-15416: Fix flaky TopicAdminTest::retryEndOffsetsShouldRetryWhenTopicNotFound test case

2023-09-07 Thread via GitHub
philipnee commented on PR #14313: URL: https://github.com/apache/kafka/pull/14313#issuecomment-1710936514 @C0urante - Thank you! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [kafka] kirktrue opened a new pull request, #14357: KAFKA-15276: Implement partition assignment reconciliation

2023-09-07 Thread via GitHub
kirktrue opened a new pull request, #14357: URL: https://github.com/apache/kafka/pull/14357 WIP -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] cmccabe opened a new pull request, #14356: MINOR: rename BrokerToControllerChannelManager to NodeToControllerChannelManager

2023-09-07 Thread via GitHub
cmccabe opened a new pull request, #14356: URL: https://github.com/apache/kafka/pull/14356 No code changes, just renames. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Commented] (KAFKA-14273) Kafka doesn't start with KRaft on Windows

2023-09-07 Thread Satish Duggana (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17762907#comment-17762907 ] Satish Duggana commented on KAFKA-14273: https://github.com/apache/kafka/pull/14354 > Kafka

[jira] [Commented] (KAFKA-14273) Kafka doesn't start with KRaft on Windows

2023-09-07 Thread Satish Duggana (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17762908#comment-17762908 ] Satish Duggana commented on KAFKA-14273: Thanks [~jsancio] for the quick fix. > Kafka doesn't

[jira] [Updated] (KAFKA-15416) Flaky test TopicAdminTest::retryEndOffsetsShouldRetryWhenTopicNotFound

2023-09-07 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15416?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Egerton updated KAFKA-15416: -- Fix Version/s: 3.6.0 > Flaky test TopicAdminTest::retryEndOffsetsShouldRetryWhenTopicNotFound

[jira] [Resolved] (KAFKA-14273) Kafka doesn't start with KRaft on Windows

2023-09-07 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-14273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] José Armando García Sancio resolved KAFKA-14273. Resolution: Fixed > Kafka doesn't start with KRaft on Windows >

[jira] [Resolved] (KAFKA-15416) Flaky test TopicAdminTest::retryEndOffsetsShouldRetryWhenTopicNotFound

2023-09-07 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15416?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Egerton resolved KAFKA-15416. --- Fix Version/s: 3.7.0 Resolution: Fixed > Flaky test

[GitHub] [kafka] C0urante merged pull request #14313: KAFKA-15416: Fix flaky TopicAdminTest::retryEndOffsetsShouldRetryWhenTopicNotFound test case

2023-09-07 Thread via GitHub
C0urante merged PR #14313: URL: https://github.com/apache/kafka/pull/14313 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] C0urante commented on pull request #14313: KAFKA-15416: Fix flaky TopicAdminTest::retryEndOffsetsShouldRetryWhenTopicNotFound test case

2023-09-07 Thread via GitHub
C0urante commented on PR #14313: URL: https://github.com/apache/kafka/pull/14313#issuecomment-1710880812 Ah, that makes more sense. Yeah, I've seen some of those too, would be nice to patch them. Thanks for your help on this one @philipnee! -- This is an automated message from the Apache

[GitHub] [kafka] jsancio closed pull request #12763: KAFKA-14273: Kafka doesn't start with KRaft on Windows

2023-09-07 Thread via GitHub
jsancio closed pull request #12763: KAFKA-14273: Kafka doesn't start with KRaft on Windows URL: https://github.com/apache/kafka/pull/12763 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] jsancio merged pull request #14354: KAFKA-14273; Close file before atomic move

2023-09-07 Thread via GitHub
jsancio merged PR #14354: URL: https://github.com/apache/kafka/pull/14354 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] jsancio commented on a diff in pull request #14354: KAFKA-14273; Close file before atomic move

2023-09-07 Thread via GitHub
jsancio commented on code in PR #14354: URL: https://github.com/apache/kafka/pull/14354#discussion_r1319056404 ## raft/src/main/java/org/apache/kafka/raft/FileBasedStateStore.java: ## @@ -144,21 +144,29 @@ private void writeElectionStateToFile(final File stateFile,

[GitHub] [kafka] junrao merged pull request #14305: KAFKA-14274: [1/7] basic refactoring

2023-09-07 Thread via GitHub
junrao merged PR #14305: URL: https://github.com/apache/kafka/pull/14305 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] cmccabe merged pull request #14306: KAFKA-15369: Implement KIP-919: Allow AC to Talk Directly with Controllers

2023-09-07 Thread via GitHub
cmccabe merged PR #14306: URL: https://github.com/apache/kafka/pull/14306 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] cmccabe commented on a diff in pull request #14306: KAFKA-15369: Implement KIP-919: Allow AC to Talk Directly with Controllers

2023-09-07 Thread via GitHub
cmccabe commented on code in PR #14306: URL: https://github.com/apache/kafka/pull/14306#discussion_r1319165974 ## clients/src/main/resources/common/message/ControllerRegistrationRequest.json: ## @@ -0,0 +1,51 @@ +// Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [kafka] C0urante commented on pull request #14314: KAFKA-15425: Fail fast in Admin::listOffsets when topic (but not partition) metadata is not found

2023-09-07 Thread via GitHub
C0urante commented on PR #14314: URL: https://github.com/apache/kafka/pull/14314#issuecomment-1710828993 Sorry! Yes, that's correct--3.6 is all we need to backport to. Thanks @jolshan! -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [kafka] kirktrue commented on a diff in pull request #14305: KAFKA-14274: [1/7] basic refactoring

2023-09-07 Thread via GitHub
kirktrue commented on code in PR #14305: URL: https://github.com/apache/kafka/pull/14305#discussion_r1319162018 ## clients/src/main/java/org/apache/kafka/clients/consumer/ConsumerConfig.java: ## @@ -639,9 +639,9 @@ private void maybeOverrideClientId(Map configs) { }

[GitHub] [kafka] kirktrue commented on pull request #14305: KAFKA-14274: [1/7] basic refactoring

2023-09-07 Thread via GitHub
kirktrue commented on PR #14305: URL: https://github.com/apache/kafka/pull/14305#issuecomment-1710825657 Test failures in latest build are unrelated: ``` integration.kafka.server.FetchFromFollowerIntegrationTest.testRackAwareRangeAssignor()

[GitHub] [kafka] jolshan merged pull request #14314: KAFKA-15425: Fail fast in Admin::listOffsets when topic (but not partition) metadata is not found

2023-09-07 Thread via GitHub
jolshan merged PR #14314: URL: https://github.com/apache/kafka/pull/14314 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] jolshan commented on pull request #14314: KAFKA-15425: Fail fast in Admin::listOffsets when topic (but not partition) metadata is not found

2023-09-07 Thread via GitHub
jolshan commented on PR #14314: URL: https://github.com/apache/kafka/pull/14314#issuecomment-1710766397 Tests look unrelated and like flakes I've seen before, so I will go ahead and merge + pick to 3.6 -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kafka] rreddy-22 commented on pull request #14345: MINOR: Range assignor changes

2023-09-07 Thread via GitHub
rreddy-22 commented on PR #14345: URL: https://github.com/apache/kafka/pull/14345#issuecomment-1710765019 > hey! @vamossagar12 , the other assignors are still under development, this is just an open PR in case we find other changes we would like to make so that all three have the

[GitHub] [kafka] lianetm commented on pull request #14346: KAFKA-15115 - KAFKA-15163; Reset/Validate positions implementation & API integration

2023-09-07 Thread via GitHub
lianetm commented on PR #14346: URL: https://github.com/apache/kafka/pull/14346#issuecomment-1710762508 Thanks a lot @philipnee for the review, all comments addressed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [kafka] lianetm commented on a diff in pull request #14346: KAFKA-15115 - KAFKA-15163; Reset/Validate positions implementation & API integration

2023-09-07 Thread via GitHub
lianetm commented on code in PR #14346: URL: https://github.com/apache/kafka/pull/14346#discussion_r1319111762 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/PrototypeAsyncConsumer.java: ## @@ -209,6 +215,34 @@ public ConsumerRecords poll(final Duration

[GitHub] [kafka] jolshan commented on a diff in pull request #14353: KAFKA-14499: [7/7] Add integration tests for OffsetCommit API and OffsetFetch API

2023-09-07 Thread via GitHub
jolshan commented on code in PR #14353: URL: https://github.com/apache/kafka/pull/14353#discussion_r1319107403 ## core/src/test/scala/unit/kafka/server/OffsetFetchRequestTest.scala: ## @@ -14,233 +14,532 @@ * See the License for the specific language governing permissions and

[GitHub] [kafka] lianetm commented on a diff in pull request #14346: KAFKA-15115 - KAFKA-15163; Reset/Validate positions implementation & API integration

2023-09-07 Thread via GitHub
lianetm commented on code in PR #14346: URL: https://github.com/apache/kafka/pull/14346#discussion_r1319093808 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/OffsetsRequestManager.java: ## @@ -298,6 +356,154 @@ private CompletableFuture

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #14353: KAFKA-14499: [7/7] Add integration tests for OffsetCommit API and OffsetFetch API

2023-09-07 Thread via GitHub
rreddy-22 commented on code in PR #14353: URL: https://github.com/apache/kafka/pull/14353#discussion_r1319088896 ## core/src/test/scala/unit/kafka/server/OffsetFetchRequestTest.scala: ## @@ -14,233 +14,532 @@ * See the License for the specific language governing permissions

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #14353: KAFKA-14499: [7/7] Add integration tests for OffsetCommit API and OffsetFetch API

2023-09-07 Thread via GitHub
rreddy-22 commented on code in PR #14353: URL: https://github.com/apache/kafka/pull/14353#discussion_r1319088896 ## core/src/test/scala/unit/kafka/server/OffsetFetchRequestTest.scala: ## @@ -14,233 +14,532 @@ * See the License for the specific language governing permissions

[GitHub] [kafka] jolshan commented on a diff in pull request #14353: KAFKA-14499: [7/7] Add integration tests for OffsetCommit API and OffsetFetch API

2023-09-07 Thread via GitHub
jolshan commented on code in PR #14353: URL: https://github.com/apache/kafka/pull/14353#discussion_r1319083998 ## core/src/test/scala/unit/kafka/server/OffsetFetchRequestTest.scala: ## @@ -14,233 +14,532 @@ * See the License for the specific language governing permissions and

[GitHub] [kafka] jolshan commented on a diff in pull request #14353: KAFKA-14499: [7/7] Add integration tests for OffsetCommit API and OffsetFetch API

2023-09-07 Thread via GitHub
jolshan commented on code in PR #14353: URL: https://github.com/apache/kafka/pull/14353#discussion_r1319082640 ## core/src/test/scala/unit/kafka/server/OffsetFetchRequestTest.scala: ## @@ -14,233 +14,532 @@ * See the License for the specific language governing permissions and

[jira] [Updated] (KAFKA-14273) Kafka doesn't start with KRaft on Windows

2023-09-07 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-14273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] José Armando García Sancio updated KAFKA-14273: --- Fix Version/s: 3.6.0 > Kafka doesn't start with KRaft on Windows >

[GitHub] [kafka] lianetm commented on a diff in pull request #14346: KAFKA-15115 - KAFKA-15163; Reset/Validate positions implementation & API integration

2023-09-07 Thread via GitHub
lianetm commented on code in PR #14346: URL: https://github.com/apache/kafka/pull/14346#discussion_r1319081696 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/PrototypeAsyncConsumer.java: ## @@ -209,6 +215,34 @@ public ConsumerRecords poll(final Duration

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #14353: KAFKA-14499: [7/7] Add integration tests for OffsetCommit API and OffsetFetch API

2023-09-07 Thread via GitHub
rreddy-22 commented on code in PR #14353: URL: https://github.com/apache/kafka/pull/14353#discussion_r1319078806 ## core/src/test/scala/unit/kafka/server/OffsetFetchRequestTest.scala: ## @@ -14,233 +14,532 @@ * See the License for the specific language governing permissions

[GitHub] [kafka] jolshan commented on a diff in pull request #14353: KAFKA-14499: [7/7] Add integration tests for OffsetCommit API and OffsetFetch API

2023-09-07 Thread via GitHub
jolshan commented on code in PR #14353: URL: https://github.com/apache/kafka/pull/14353#discussion_r1319078377 ## core/src/test/scala/unit/kafka/server/OffsetCommitRequestTest.scala: ## @@ -0,0 +1,163 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [kafka] lianetm commented on a diff in pull request #14346: KAFKA-15115 - KAFKA-15163; Reset/Validate positions implementation & API integration

2023-09-07 Thread via GitHub
lianetm commented on code in PR #14346: URL: https://github.com/apache/kafka/pull/14346#discussion_r1319078266 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/OffsetsRequestManager.java: ## @@ -268,7 +326,7 @@ private CompletableFuture

[GitHub] [kafka] lianetm commented on a diff in pull request #14323: KAFKA-15275 - Client state machine basic components, states and initial transitions

2023-09-07 Thread via GitHub
lianetm commented on code in PR #14323: URL: https://github.com/apache/kafka/pull/14323#discussion_r1319075024 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java: ## @@ -0,0 +1,168 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] lianetm commented on a diff in pull request #14323: KAFKA-15275 - Client state machine basic components, states and initial transitions

2023-09-07 Thread via GitHub
lianetm commented on code in PR #14323: URL: https://github.com/apache/kafka/pull/14323#discussion_r1319075024 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java: ## @@ -0,0 +1,168 @@ +/* + * Licensed to the Apache Software

[jira] [Assigned] (KAFKA-15417) JoinWindow does not seem to work properly with a KStream - KStream - LeftJoin()

2023-09-07 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15417?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax reassigned KAFKA-15417: --- Assignee: Victor van den Hoven > JoinWindow does not seem to work properly with a

[jira] [Commented] (KAFKA-15417) JoinWindow does not seem to work properly with a KStream - KStream - LeftJoin()

2023-09-07 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17762863#comment-17762863 ] Matthias J. Sax commented on KAFKA-15417: - Thanks a lot! Assigned the ticket to you. >

[GitHub] [kafka] mjsax merged pull request #14341: KAFKA-15307: Removes non-existent configs

2023-09-07 Thread via GitHub
mjsax merged PR #14341: URL: https://github.com/apache/kafka/pull/14341 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] nizhikov opened a new pull request, #14355: KAFKA-14595 ReassignPartitionsUnitTest rewritten in java

2023-09-07 Thread via GitHub
nizhikov opened a new pull request, #14355: URL: https://github.com/apache/kafka/pull/14355 This PR is part of #13247 It contains changes to rewrite single test in java. Intention is reduce changes in parent PR. ### Committer Checklist (excluded from commit message) - [ ]

[GitHub] [kafka] cmccabe commented on a diff in pull request #14354: KAFKA-14273; Close file before atomic move

2023-09-07 Thread via GitHub
cmccabe commented on code in PR #14354: URL: https://github.com/apache/kafka/pull/14354#discussion_r1319034514 ## raft/src/main/java/org/apache/kafka/raft/FileBasedStateStore.java: ## @@ -144,21 +144,29 @@ private void writeElectionStateToFile(final File stateFile,

[GitHub] [kafka] philipnee commented on a diff in pull request #14323: KAFKA-15275 - Client state machine basic components, states and initial transitions

2023-09-07 Thread via GitHub
philipnee commented on code in PR #14323: URL: https://github.com/apache/kafka/pull/14323#discussion_r1319012270 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java: ## @@ -0,0 +1,168 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] jolshan commented on a diff in pull request #14353: KAFKA-14499: [7/7] Add integration tests for OffsetCommit API and OffsetFetch API

2023-09-07 Thread via GitHub
jolshan commented on code in PR #14353: URL: https://github.com/apache/kafka/pull/14353#discussion_r1319008280 ## core/src/test/scala/unit/kafka/server/OffsetCommitRequestTest.scala: ## @@ -0,0 +1,163 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [kafka] jolshan commented on a diff in pull request #14353: KAFKA-14499: [7/7] Add integration tests for OffsetCommit API and OffsetFetch API

2023-09-07 Thread via GitHub
jolshan commented on code in PR #14353: URL: https://github.com/apache/kafka/pull/14353#discussion_r1319005551 ## core/src/test/scala/unit/kafka/server/GroupCoordinatorBaseRequestTest.scala: ## @@ -0,0 +1,158 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [kafka] lianetm commented on a diff in pull request #14323: KAFKA-15275 - Client state machine basic components, states and initial transitions

2023-09-07 Thread via GitHub
lianetm commented on code in PR #14323: URL: https://github.com/apache/kafka/pull/14323#discussion_r1319005335 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java: ## @@ -0,0 +1,168 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] jsancio commented on a diff in pull request #12763: KAFKA-14273: Kafka doesn't start with KRaft on Windows

2023-09-07 Thread via GitHub
jsancio commented on code in PR #12763: URL: https://github.com/apache/kafka/pull/12763#discussion_r1319003199 ## raft/src/main/java/org/apache/kafka/raft/FileBasedStateStore.java: ## @@ -149,6 +149,7 @@ private void writeElectionStateToFile(final File stateFile,

[GitHub] [kafka] jsancio opened a new pull request, #14354: KAFKA-14273; Close file before atomic move

2023-09-07 Thread via GitHub
jsancio opened a new pull request, #14354: URL: https://github.com/apache/kafka/pull/14354 In the Windows OS atomic move are not allowed if the file has an open handle. E.g __cluster_metadata-0\quorum-state: The process cannot access the file because it is being used by another

[GitHub] [kafka] lianetm commented on pull request #14323: KAFKA-15275 - Client state machine basic components, states and initial transitions

2023-09-07 Thread via GitHub
lianetm commented on PR #14323: URL: https://github.com/apache/kafka/pull/14323#issuecomment-1710622597 Build completed with 6 unrelated test failures: Build / JDK 20 and Scala 2.13 / testBumpTransactionalEpoch(String).quorum=kraft – kafka.api.TransactionsTest Build / JDK 8 and

[GitHub] [kafka] philipnee commented on a diff in pull request #14346: KAFKA-15115 - KAFKA-15163; Reset/Validate positions implementation & API integration

2023-09-07 Thread via GitHub
philipnee commented on code in PR #14346: URL: https://github.com/apache/kafka/pull/14346#discussion_r1318977376 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/OffsetsRequestManager.java: ## @@ -268,7 +326,7 @@ private CompletableFuture

[GitHub] [kafka] lianetm commented on pull request #14346: KAFKA-15115 - KAFKA-15163; Reset/Validate positions implementation & API integration

2023-09-07 Thread via GitHub
lianetm commented on PR #14346: URL: https://github.com/apache/kafka/pull/14346#issuecomment-1710621218 Build completed with 6 unrelated test failures: Build / JDK 20 and Scala 2.13 / testOffsetTranslationBehindReplicationFlow() –

[jira] [Commented] (KAFKA-12473) Make the "cooperative-sticky, range" as the default assignor

2023-09-07 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17762846#comment-17762846 ] David Jacot commented on KAFKA-12473: - [~kirktrue] [~showuon] In my opinion, we should not do this

[jira] [Commented] (KAFKA-14273) Kafka doesn't start with KRaft on Windows

2023-09-07 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-14273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17762843#comment-17762843 ] José Armando García Sancio commented on KAFKA-14273: [~satish.duggana] I think it is

[jira] [Commented] (KAFKA-12473) Make the "cooperative-sticky, range" as the default assignor

2023-09-07 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17762842#comment-17762842 ] Kirk True commented on KAFKA-12473: --- [~showuon] Are you working on this change actively? I'm wondering

[jira] [Assigned] (KAFKA-14273) Kafka doesn't start with KRaft on Windows

2023-09-07 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-14273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] José Armando García Sancio reassigned KAFKA-14273: -- Assignee: José Armando García Sancio > Kafka doesn't start

[GitHub] [kafka] philipnee commented on pull request #14313: KAFKA-15416: Fix flaky TopicAdminTest::retryEndOffsetsShouldRetryWhenTopicNotFound test case

2023-09-07 Thread via GitHub
philipnee commented on PR #14313: URL: https://github.com/apache/kafka/pull/14313#issuecomment-1710569868 @C0urante - Sorry what i meant was I've seen other locally flaky tests that almost never show up during the jenkins build. Thanks! I'll submit a patch after you merge it. -- This

[GitHub] [kafka] blacktooth commented on a diff in pull request #13726: KAFKA-13109: SourceTask#poll not enforcing retries in case of RetriableException

2023-09-07 Thread via GitHub
blacktooth commented on code in PR #13726: URL: https://github.com/apache/kafka/pull/13726#discussion_r1318930687 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/AbstractWorkerSourceTask.java: ## @@ -458,13 +458,8 @@ boolean sendRecords() { }

[GitHub] [kafka] blacktooth commented on a diff in pull request #13726: KAFKA-13109: SourceTask#poll not enforcing retries in case of RetriableException

2023-09-07 Thread via GitHub
blacktooth commented on code in PR #13726: URL: https://github.com/apache/kafka/pull/13726#discussion_r1318930687 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/AbstractWorkerSourceTask.java: ## @@ -458,13 +458,8 @@ boolean sendRecords() { }

[GitHub] [kafka] nizhikov commented on pull request #14217: KAFKA-14595 ReassignPartitionsCommandArgsTest rewritten in java

2023-09-07 Thread via GitHub
nizhikov commented on PR #14217: URL: https://github.com/apache/kafka/pull/14217#issuecomment-1710540249 @gharris1727 Thank you very much! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] jolshan commented on pull request #14314: KAFKA-15425: Fail fast in Admin::listOffsets when topic (but not partition) metadata is not found

2023-09-07 Thread via GitHub
jolshan commented on PR #14314: URL: https://github.com/apache/kafka/pull/14314#issuecomment-1710539538 Also -- I assume we want to pick this to 3.6 as well. Is that the only branch @C0urante? -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [kafka] gharris1727 commented on pull request #14217: KAFKA-14595 ReassignPartitionsCommandArgsTest rewritten in java

2023-09-07 Thread via GitHub
gharris1727 commented on PR #14217: URL: https://github.com/apache/kafka/pull/14217#issuecomment-1710524166 Thanks @nizhikov for your patience, and thanks for keeping people notified about this PR. Too many PRs like this one are left stale due to limited committer bandwidth. -- This is

[jira] [Commented] (KAFKA-14595) Move ReassignPartitionsCommand to tools

2023-09-07 Thread Greg Harris (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17762822#comment-17762822 ] Greg Harris commented on KAFKA-14595: - I merged [https://github.com/apache/kafka/pull/14217] but I

[GitHub] [kafka] cmccabe commented on pull request #14306: KAFKA-15369: Implement KIP-919: Allow AC to Talk Directly with Controllers

2023-09-07 Thread via GitHub
cmccabe commented on PR #14306: URL: https://github.com/apache/kafka/pull/14306#issuecomment-1710512791 Fixed conflicts -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [kafka] gharris1727 merged pull request #14217: KAFKA-14595 ReassignPartitionsCommandArgsTest rewritten in java

2023-09-07 Thread via GitHub
gharris1727 merged PR #14217: URL: https://github.com/apache/kafka/pull/14217 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] gharris1727 commented on pull request #14217: KAFKA-14595 ReassignPartitionsCommandArgsTest rewritten in java

2023-09-07 Thread via GitHub
gharris1727 commented on PR #14217: URL: https://github.com/apache/kafka/pull/14217#issuecomment-1710503247 The test failures in CI appear unrelated, and `tools:test` passes for me locally. -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] Cerchie commented on pull request #14341: KAFKA-15307: Removes non-existent configs

2023-09-07 Thread via GitHub
Cerchie commented on PR #14341: URL: https://github.com/apache/kafka/pull/14341#issuecomment-1710482923 > Thanks for the PR. I know that we did remove `partition.grouper`, but the others seems to be valid config. For example

[GitHub] [kafka] Cerchie commented on a diff in pull request #14322: KAFKA-15418: update statement on decompression

2023-09-07 Thread via GitHub
Cerchie commented on code in PR #14322: URL: https://github.com/apache/kafka/pull/14322#discussion_r1318874061 ## docs/design.html: ## @@ -136,8 +136,10 @@ -Kafka supports this with an efficient batching format. A batch of messages can be clumped together compressed and

[jira] [Comment Edited] (KAFKA-15402) Performance regression on close consumer after upgrading to 3.5.0

2023-09-07 Thread Benoit Delbosc (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17762808#comment-17762808 ] Benoit Delbosc edited comment on KAFKA-15402 at 9/7/23 4:38 PM: Thanks,

[GitHub] [kafka] C0urante commented on a diff in pull request #14314: KAFKA-15425: Fail fast in Admin::listOffsets when topic (but not partition) metadata is not found

2023-09-07 Thread via GitHub
C0urante commented on code in PR #14314: URL: https://github.com/apache/kafka/pull/14314#discussion_r1318868378 ## clients/src/test/java/org/apache/kafka/clients/admin/KafkaAdminClientTest.java: ## @@ -5633,20 +5643,39 @@ public void testListOffsetsMetadataNonRetriableErrors()

[GitHub] [kafka] yashmayya commented on pull request #14279: KAFKA-15179: Add integration tests for the file sink and source connectors

2023-09-07 Thread via GitHub
yashmayya commented on PR #14279: URL: https://github.com/apache/kafka/pull/14279#issuecomment-1710462603 Thanks Chris! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[jira] [Commented] (KAFKA-15402) Performance regression on close consumer after upgrading to 3.5.0

2023-09-07 Thread Benoit Delbosc (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17762808#comment-17762808 ] Benoit Delbosc commented on KAFKA-15402: Thanks, I have tested 

[GitHub] [kafka] kamalcph commented on pull request #14349: KAFKA-15352: Update log-start-offset before initiating deletion of remote segments

2023-09-07 Thread via GitHub
kamalcph commented on PR #14349: URL: https://github.com/apache/kafka/pull/14349#issuecomment-1710450437 > My point is, should we check for leadership even before updating the log start offset? yes, this is the expectation and being done inside the `handleLogStartOffsetUpdate`

[GitHub] [kafka] C0urante merged pull request #14279: KAFKA-15179: Add integration tests for the file sink and source connectors

2023-09-07 Thread via GitHub
C0urante merged PR #14279: URL: https://github.com/apache/kafka/pull/14279 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] C0urante commented on a diff in pull request #14279: KAFKA-15179: Add integration tests for the file sink and source connectors

2023-09-07 Thread via GitHub
C0urante commented on code in PR #14279: URL: https://github.com/apache/kafka/pull/14279#discussion_r1318853979 ## connect/file/src/test/java/org/apache/kafka/connect/file/integration/FileStreamSinkConnectorIntegrationTest.java: ## @@ -0,0 +1,192 @@ +/* + * Licensed to the

[GitHub] [kafka] C0urante commented on a diff in pull request #14279: KAFKA-15179: Add integration tests for the file sink and source connectors

2023-09-07 Thread via GitHub
C0urante commented on code in PR #14279: URL: https://github.com/apache/kafka/pull/14279#discussion_r1318849972 ## connect/file/src/test/java/org/apache/kafka/connect/file/integration/FileStreamSinkConnectorIntegrationTest.java: ## @@ -0,0 +1,194 @@ +/* + * Licensed to the

[GitHub] [kafka] C0urante commented on a diff in pull request #14279: KAFKA-15179: Add integration tests for the file sink and source connectors

2023-09-07 Thread via GitHub
C0urante commented on code in PR #14279: URL: https://github.com/apache/kafka/pull/14279#discussion_r1318849515 ## connect/file/src/test/java/org/apache/kafka/connect/file/integration/FileStreamSinkConnectorIntegrationTest.java: ## @@ -0,0 +1,194 @@ +/* + * Licensed to the

[jira] [Comment Edited] (KAFKA-15417) JoinWindow does not seem to work properly with a KStream - KStream - LeftJoin()

2023-09-07 Thread Victor van den Hoven (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17762676#comment-17762676 ] Victor van den Hoven edited comment on KAFKA-15417 at 9/7/23 4:13 PM:

[GitHub] [kafka] jolshan commented on a diff in pull request #14314: KAFKA-15425: Fail fast in Admin::listOffsets when topic (but not partition) metadata is not found

2023-09-07 Thread via GitHub
jolshan commented on code in PR #14314: URL: https://github.com/apache/kafka/pull/14314#discussion_r1318833581 ## clients/src/test/java/org/apache/kafka/clients/admin/KafkaAdminClientTest.java: ## @@ -5633,20 +5643,39 @@ public void testListOffsetsMetadataNonRetriableErrors()

[GitHub] [kafka] philipnee commented on a diff in pull request #14323: KAFKA-15275 - Client state machine basic components, states and initial transitions

2023-09-07 Thread via GitHub
philipnee commented on code in PR #14323: URL: https://github.com/apache/kafka/pull/14323#discussion_r1318822595 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AssignorSelection.java: ## @@ -0,0 +1,102 @@ +/* + * Licensed to the Apache Software Foundation

  1   2   >