atu-sharm closed pull request #14472: KAFKA-15521: Refactor build.gradle to
align gradle swagger plugin with swagger dependencies
URL: https://github.com/apache/kafka/pull/14472
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
atu-sharm opened a new pull request, #14473:
URL: https://github.com/apache/kafka/pull/14473
Having a single version of swagger to avoid breaking of build
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so
atu-sharm opened a new pull request, #14472:
URL: https://github.com/apache/kafka/pull/14472
Having a single version of swagger to avoid breaking of build
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message,
yangy commented on code in PR #1:
URL: https://github.com/apache/kafka/pull/1#discussion_r1343485049
##
core/src/main/scala/kafka/server/KafkaApis.scala:
##
@@ -559,6 +560,30 @@ class KafkaApis(val requestChannel: RequestChannel,
}
}
+ case class
[
https://issues.apache.org/jira/browse/KAFKA-15521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17771334#comment-17771334
]
Atul Sharma commented on KAFKA-15521:
-
Hi, [~mimaison] can i take this up?
> Refactor build.gradle
showuon commented on code in PR #14428:
URL: https://github.com/apache/kafka/pull/14428#discussion_r1343475329
##
raft/src/test/java/org/apache/kafka/raft/KafkaRaftClientTest.java:
##
@@ -485,6 +485,49 @@ public void
testHandleBeginQuorumEpochAfterUserInitiatedResign() throws
showuon commented on code in PR #14428:
URL: https://github.com/apache/kafka/pull/14428#discussion_r1343472387
##
raft/src/main/java/org/apache/kafka/raft/LeaderState.java:
##
@@ -76,9 +85,37 @@ protected LeaderState(
boolean hasAcknowledgedLeader = voterId ==
github-actions[bot] commented on PR #13953:
URL: https://github.com/apache/kafka/pull/13953#issuecomment-1744109897
This PR is being marked as stale since it has not had any activity in 90
days. If you would like to keep this PR alive, please ask a committer for
review. If the PR has
splett2 commented on code in PR #14470:
URL: https://github.com/apache/kafka/pull/14470#discussion_r1343331209
##
core/src/main/scala/kafka/log/UnifiedLog.scala:
##
@@ -892,16 +889,11 @@ class UnifiedLog(@volatile var logStartOffset: Long,
maybeDuplicate match {
splett2 commented on code in PR #14470:
URL: https://github.com/apache/kafka/pull/14470#discussion_r1343327345
##
core/src/main/scala/kafka/server/ReplicaManager.scala:
##
@@ -787,19 +770,22 @@ class ReplicaManager(val config: KafkaConfig,
)
}
-
dongnuo123 commented on code in PR #14462:
URL: https://github.com/apache/kafka/pull/14462#discussion_r1343272684
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -444,6 +445,66 @@ public List
listGroups(List statesFi
junrao commented on code in PR #14406:
URL: https://github.com/apache/kafka/pull/14406#discussion_r1334821243
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/FetchRequestManagerTest.java:
##
@@ -0,0 +1,3565 @@
+/*
+ * Licensed to the Apache Software
jeffkbkim commented on code in PR #14408:
URL: https://github.com/apache/kafka/pull/14408#discussion_r1343258721
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -3071,6 +3071,33 @@ private void
xinyuliu-cb commented on PR #13905:
URL: https://github.com/apache/kafka/pull/13905#issuecomment-1743917984
same here. catching up from the earliest offsets is too expensive and
resource demanding to MM2 and Kafka brokers.
--
This is an automated message from the Apache Git Service.
To
[
https://issues.apache.org/jira/browse/KAFKA-15028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17771294#comment-17771294
]
Justine Olshan commented on KAFKA-15028:
[~divijvaidya] I saw your comment on the RC thread
nizhikov opened a new pull request, #14471:
URL: https://github.com/apache/kafka/pull/14471
WIP PR.
This PR contains changes to rewrite `ConsumerGroupCommand` in java and
transfer it to `tools` module
### Committer Checklist (excluded from commit message)
- [ ] Verify
nizhikov commented on PR #13247:
URL: https://github.com/apache/kafka/pull/13247#issuecomment-1743782703
@mimaison
@ijuma
It seems we reduced changes as much as possible.
So it's time to do final review of command transfer from scala to java.
Can you, please, take a
ahuang98 commented on code in PR #14428:
URL: https://github.com/apache/kafka/pull/14428#discussion_r1343169152
##
raft/src/main/java/org/apache/kafka/raft/LeaderState.java:
##
@@ -76,9 +85,37 @@ protected LeaderState(
boolean hasAcknowledgedLeader = voterId ==
nizhikov commented on PR #14456:
URL: https://github.com/apache/kafka/pull/14456#issuecomment-1743719944
@jolshan Thank you very much for the review and merge. Appreciate it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
Greg Harris created KAFKA-15528:
---
Summary: KIP-986: Cross-Cluster Replication
Key: KAFKA-15528
URL: https://issues.apache.org/jira/browse/KAFKA-15528
Project: Kafka
Issue Type: New Feature
jolshan merged PR #14456:
URL: https://github.com/apache/kafka/pull/14456
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
jolshan commented on PR #14456:
URL: https://github.com/apache/kafka/pull/14456#issuecomment-1743685795
Hey sorry. I was off for the weekend. I can take another look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
chb2ab commented on code in PR #1:
URL: https://github.com/apache/kafka/pull/1#discussion_r1343033045
##
clients/src/main/java/org/apache/kafka/common/requests/ProduceResponse.java:
##
@@ -210,6 +238,12 @@ public String toString() {
[
https://issues.apache.org/jira/browse/KAFKA-15527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-15527:
Labels: kip (was: )
> Add reverseRange and reverseAll query over kv-store in IQv2
>
[
https://issues.apache.org/jira/browse/KAFKA-15527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-15527:
Component/s: streams
> Add reverseRange and reverseAll query over kv-store in IQv2
>
[
https://issues.apache.org/jira/browse/KAFKA-13005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17771237#comment-17771237
]
Proven Provenzano commented on KAFKA-13005:
---
Can this story be closed as duplicate as a new
[
https://issues.apache.org/jira/browse/KAFKA-15449?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Justine Olshan resolved KAFKA-15449.
Resolution: Fixed
> Verify transactional offset commits (KIP-890 part 1)
>
jolshan merged PR #14370:
URL: https://github.com/apache/kafka/pull/14370
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
jolshan commented on code in PR #14470:
URL: https://github.com/apache/kafka/pull/14470#discussion_r1342935092
##
core/src/main/scala/kafka/log/UnifiedLog.scala:
##
@@ -1141,13 +1134,13 @@ class UnifiedLog(@volatile var logStartOffset: Long,
// Also indicate whether we
jolshan commented on code in PR #14470:
URL: https://github.com/apache/kafka/pull/14470#discussion_r1342933163
##
core/src/main/scala/kafka/log/UnifiedLog.scala:
##
@@ -892,16 +889,11 @@ class UnifiedLog(@volatile var logStartOffset: Long,
maybeDuplicate match {
msn-tldr commented on PR #14384:
URL: https://github.com/apache/kafka/pull/14384#issuecomment-1743383185
@kirktrue
> @jsancio - can you weigh in about changes to org.apache.kafka.common
needing a KIP?
I have removed the changes to public classes, so this shouldn't require a
KIP,
msn-tldr commented on code in PR #14384:
URL: https://github.com/apache/kafka/pull/14384#discussion_r1340370371
##
clients/src/test/java/org/apache/kafka/clients/producer/internals/SenderTest.java:
##
@@ -156,6 +157,8 @@ public class SenderTest {
private
Hanyu Zheng created KAFKA-15527:
---
Summary: Add reverseRange and reverseAll query over kv-store in
IQv2
Key: KAFKA-15527
URL: https://issues.apache.org/jira/browse/KAFKA-15527
Project: Kafka
[
https://issues.apache.org/jira/browse/KAFKA-15527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Hanyu Zheng reassigned KAFKA-15527:
---
Assignee: Hanyu Zheng
> Add reverseRange and reverseAll query over kv-store in IQv2
>
philipnee commented on code in PR #14364:
URL: https://github.com/apache/kafka/pull/14364#discussion_r1342920121
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java:
##
@@ -0,0 +1,330 @@
+/*
+ * Licensed to the Apache Software
jlprat merged PR #14460:
URL: https://github.com/apache/kafka/pull/14460
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
philipnee commented on PR #14364:
URL: https://github.com/apache/kafka/pull/14364#issuecomment-1743351780
Hello @dajac - Thanks for the review. I hope I've addressed most of your
concerns in the recent reviews. Thanks!
--
This is an automated message from the Apache Git Service.
To
jlprat commented on PR #14460:
URL: https://github.com/apache/kafka/pull/14460#issuecomment-1743351726
Test failures are all unrelated to the change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
philipnee commented on code in PR #14364:
URL: https://github.com/apache/kafka/pull/14364#discussion_r1342915079
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java:
##
@@ -0,0 +1,330 @@
+/*
+ * Licensed to the Apache Software
philipnee commented on code in PR #14364:
URL: https://github.com/apache/kafka/pull/14364#discussion_r1342910020
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java:
##
@@ -0,0 +1,324 @@
+/*
+ * Licensed to the Apache Software
splett2 commented on code in PR #14470:
URL: https://github.com/apache/kafka/pull/14470#discussion_r1342909611
##
core/src/main/scala/kafka/raft/KafkaMetadataLog.scala:
##
@@ -96,10 +96,10 @@ final class KafkaMetadataLog private (
}
private def
David Mao created KAFKA-15526:
-
Summary: Simplify LogAppendInfo parameters
Key: KAFKA-15526
URL: https://issues.apache.org/jira/browse/KAFKA-15526
Project: Kafka
Issue Type: Improvement
philipnee commented on code in PR #14364:
URL: https://github.com/apache/kafka/pull/14364#discussion_r1342899010
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java:
##
@@ -0,0 +1,330 @@
+/*
+ * Licensed to the Apache Software
[
https://issues.apache.org/jira/browse/KAFKA-15525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17771171#comment-17771171
]
Francois Visconte commented on KAFKA-15525:
---
I was planning to do that change anyways but the
chb2ab commented on code in PR #1:
URL: https://github.com/apache/kafka/pull/1#discussion_r1342844776
##
core/src/main/scala/kafka/server/KafkaApis.scala:
##
@@ -559,6 +560,30 @@ class KafkaApis(val requestChannel: RequestChannel,
}
}
+ case class
yangy commented on code in PR #14408:
URL: https://github.com/apache/kafka/pull/14408#discussion_r1342851207
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetMetadataManager.java:
##
@@ -333,6 +348,87 @@ public CoordinatorResult
commitOffset(
chb2ab commented on code in PR #1:
URL: https://github.com/apache/kafka/pull/1#discussion_r1342850556
##
core/src/main/scala/kafka/server/KafkaApis.scala:
##
@@ -559,6 +560,30 @@ class KafkaApis(val requestChannel: RequestChannel,
}
}
+ case class
chb2ab commented on code in PR #1:
URL: https://github.com/apache/kafka/pull/1#discussion_r1342844776
##
core/src/main/scala/kafka/server/KafkaApis.scala:
##
@@ -559,6 +560,30 @@ class KafkaApis(val requestChannel: RequestChannel,
}
}
+ case class
dajac commented on code in PR #14462:
URL: https://github.com/apache/kafka/pull/14462#discussion_r1342814124
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -444,6 +445,66 @@ public List
listGroups(List statesFi
philipnee commented on code in PR #14364:
URL: https://github.com/apache/kafka/pull/14364#discussion_r1342785385
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java:
##
@@ -0,0 +1,330 @@
+/*
+ * Licensed to the Apache Software
philipnee commented on code in PR #14364:
URL: https://github.com/apache/kafka/pull/14364#discussion_r1342783380
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java:
##
@@ -0,0 +1,330 @@
+/*
+ * Licensed to the Apache Software
philipnee commented on code in PR #14364:
URL: https://github.com/apache/kafka/pull/14364#discussion_r1342781938
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java:
##
@@ -0,0 +1,330 @@
+/*
+ * Licensed to the Apache Software
philipnee commented on code in PR #14364:
URL: https://github.com/apache/kafka/pull/14364#discussion_r1342778930
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java:
##
@@ -0,0 +1,330 @@
+/*
+ * Licensed to the Apache Software
lucasbru merged PR #14281:
URL: https://github.com/apache/kafka/pull/14281
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
lucasbru commented on PR #14281:
URL: https://github.com/apache/kafka/pull/14281#issuecomment-174303
Build failures unrelated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
dajac commented on code in PR #14364:
URL: https://github.com/apache/kafka/pull/14364#discussion_r1342694336
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java:
##
@@ -0,0 +1,330 @@
+/*
+ * Licensed to the Apache Software
dajac commented on code in PR #14364:
URL: https://github.com/apache/kafka/pull/14364#discussion_r1342667683
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java:
##
@@ -0,0 +1,330 @@
+/*
+ * Licensed to the Apache Software
showuon commented on code in PR #14428:
URL: https://github.com/apache/kafka/pull/14428#discussion_r1342676499
##
raft/src/main/java/org/apache/kafka/raft/LeaderState.java:
##
@@ -76,9 +85,37 @@ protected LeaderState(
boolean hasAcknowledgedLeader = voterId ==
showuon commented on code in PR #14428:
URL: https://github.com/apache/kafka/pull/14428#discussion_r1342668812
##
raft/src/main/java/org/apache/kafka/raft/LeaderState.java:
##
@@ -76,9 +85,37 @@ protected LeaderState(
boolean hasAcknowledgedLeader = voterId ==
showuon commented on code in PR #14428:
URL: https://github.com/apache/kafka/pull/14428#discussion_r1342669657
##
raft/src/test/java/org/apache/kafka/raft/KafkaRaftClientTest.java:
##
@@ -485,6 +485,49 @@ public void
testHandleBeginQuorumEpochAfterUserInitiatedResign() throws
showuon commented on code in PR #14428:
URL: https://github.com/apache/kafka/pull/14428#discussion_r1342665261
##
raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java:
##
@@ -965,6 +965,10 @@ private CompletableFuture
handleFetchRequest(
}
int
dajac commented on code in PR #14408:
URL: https://github.com/apache/kafka/pull/14408#discussion_r1342599402
##
clients/src/test/java/org/apache/kafka/common/requests/DeleteGroupsRequestTest.java:
##
@@ -0,0 +1,57 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
[
https://issues.apache.org/jira/browse/KAFKA-15525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17771065#comment-17771065
]
Kamal Chandraprakash commented on KAFKA-15525:
--
While uploading the segment, the
dajac merged PR #14468:
URL: https://github.com/apache/kafka/pull/14468
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
dajac merged PR #14469:
URL: https://github.com/apache/kafka/pull/14469
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
fvaleri commented on PR #13562:
URL: https://github.com/apache/kafka/pull/13562#issuecomment-1742881176
> @fvaleri I think it's time to take a note about this changes in
[KAFKA-14705](https://issues.apache.org/jira/browse/KAFKA-14705), isn't it?
This should fall under the phrase: "4.
[
https://issues.apache.org/jira/browse/KAFKA-15498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17771051#comment-17771051
]
Luke Chen commented on KAFKA-15498:
---
Note: In v3.7.0, Snappy-Java is upgraded to 1.1.10.5 in this PR:
showuon merged PR #14458:
URL: https://github.com/apache/kafka/pull/14458
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
showuon commented on PR #14458:
URL: https://github.com/apache/kafka/pull/14458#issuecomment-1742858256
Agree it's not a blocker for v3.6.0. Failed tests are unrelated:
```
Build / JDK 21 and Scala 2.13 /
Francois Visconte created KAFKA-15525:
-
Summary: Segment uploads stop working following a broker failure
Key: KAFKA-15525
URL: https://issues.apache.org/jira/browse/KAFKA-15525
Project: Kafka
ruslankrivoshein commented on PR #13562:
URL: https://github.com/apache/kafka/pull/13562#issuecomment-1742817052
@fvaleri I think it's time to take a note about this changes in
[KAFKA-14705](https://issues.apache.org/jira/browse/KAFKA-14705), isn't it?
--
This is an automated message
lucasbru commented on PR #14435:
URL: https://github.com/apache/kafka/pull/14435#issuecomment-1742776359
> @lucasbru you set up your apache account already, right? I'm leaving it to
you to merge but just let me know if you need me to do so
Yes, done and backported
--
This is an
nizhikov commented on PR #14456:
URL: https://github.com/apache/kafka/pull/14456#issuecomment-1742776092
CI is OK after code review changes.
@jolshan do you have other comments?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
lucasbru merged PR #14435:
URL: https://github.com/apache/kafka/pull/14435
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
urbandan commented on PR #13796:
URL: https://github.com/apache/kafka/pull/13796#issuecomment-1742583164
@viktorsomogyi I would like to, yes, but my understanding is (based on the
comments of @jolshan) that another loosely related bug blocks this fix.
--
This is an automated message
showuon commented on PR #14459:
URL: https://github.com/apache/kafka/pull/14459#issuecomment-1742572611
Thanks for the fix @iit2009060 ! Nice find!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
vamossagar12 commented on PR #14468:
URL: https://github.com/apache/kafka/pull/14468#issuecomment-1742509255
@dajac , sorry about that. It was a checkstyle failure. I have corrected it
and ran locally. Checkstyles passed now.
--
This is an automated message from the Apache Git Service.
77 matches
Mail list logo
