Re: [PR] KAFKA-15169: Added TestCase in RemoteIndexCache [kafka]

2023-10-04 Thread via GitHub
iit2009060 commented on code in PR #14482: URL: https://github.com/apache/kafka/pull/14482#discussion_r1346817006 ## core/src/test/scala/unit/kafka/log/remote/RemoteIndexCacheTest.scala: ## @@ -541,6 +542,131 @@ class RemoteIndexCacheTest { verifyFetchIndexInvocation(count

Re: [PR] KAFKA-15169: Added TestCase in RemoteIndexCache [kafka]

2023-10-04 Thread via GitHub
showuon commented on code in PR #14482: URL: https://github.com/apache/kafka/pull/14482#discussion_r1346739560 ## core/src/test/scala/unit/kafka/log/remote/RemoteIndexCacheTest.scala: ## @@ -541,6 +542,131 @@ class RemoteIndexCacheTest { verifyFetchIndexInvocation(count =

Re: [PR] KAFKA-15169: Added TestCase in RemoteIndexCache [kafka]

2023-10-04 Thread via GitHub
showuon commented on code in PR #14482: URL: https://github.com/apache/kafka/pull/14482#discussion_r1346739560 ## core/src/test/scala/unit/kafka/log/remote/RemoteIndexCacheTest.scala: ## @@ -541,6 +542,131 @@ class RemoteIndexCacheTest { verifyFetchIndexInvocation(count =

Re: [PR] MINOR Added version 3.6.0 to system tests [kafka]

2023-10-04 Thread via GitHub
showuon commented on PR #14488: URL: https://github.com/apache/kafka/pull/14488#issuecomment-1748033933 @satishd , we need to wait until someone in Confluent help upload the artifacts , then merge it. So, you should go ahead with the release process and do this afterwards. -- This is an

[jira] [Updated] (KAFKA-15547) Thread leak in MirrorMakerConfigTest#testClientConfigProperties

2023-10-04 Thread Yash Mayya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15547?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yash Mayya updated KAFKA-15547: --- Issue Type: Test (was: Bug) > Thread leak in MirrorMakerConfigTest#testClientConfigProperties >

[jira] [Resolved] (KAFKA-15547) Thread leak in MirrorMakerConfigTest#testClientConfigProperties

2023-10-04 Thread Yash Mayya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15547?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yash Mayya resolved KAFKA-15547. Fix Version/s: 3.7.0 Resolution: Fixed > Thread leak in

Re: [PR] KAFKA-15547 fixes thread leak in MirrorMakerConfigTest [kafka]

2023-10-04 Thread via GitHub
yashmayya merged PR #14487: URL: https://github.com/apache/kafka/pull/14487 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] KAFKA-15547 fixes thread leak in MirrorMakerConfigTest [kafka]

2023-10-04 Thread via GitHub
yashmayya commented on PR #14487: URL: https://github.com/apache/kafka/pull/14487#issuecomment-1748025828 Test failures are unrelated, merging to `trunk`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[jira] [Commented] (KAFKA-15541) RocksDB Iterator Metrics

2023-10-04 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17772072#comment-17772072 ] Matthias J. Sax commented on KAFKA-15541: - Did not read the KIP yet, but sound very similar to

Re: [PR] KAFKA-15356: Generate and persist directory IDs [kafka]

2023-10-04 Thread via GitHub
soarez commented on PR #14291: URL: https://github.com/apache/kafka/pull/14291#issuecomment-1747977220 Thank you for the reviews @rondagostino and @pprovenzano. I've addressed the suggestions, and also made the changes discussed earlier: * Introduce a third reserved UUID *

[jira] [Commented] (KAFKA-14941) Document which configuration options are applicable only to processes with broker role or controller role

2023-10-04 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17772048#comment-17772048 ] Luke Chen commented on KAFKA-14941: --- Great! I'm working on the list, will let you know when completed.

Re: [PR] KAFKA-14274 [6, 7]: Introduction of fetch request manager [kafka]

2023-10-04 Thread via GitHub
kirktrue commented on code in PR #14406: URL: https://github.com/apache/kafka/pull/14406#discussion_r1346616646 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/PrototypeAsyncConsumer.java: ## @@ -621,56 +825,174 @@ public void assign(Collection partitions)

Re: [PR] KAFKA-14274 [6, 7]: Introduction of fetch request manager [kafka]

2023-10-04 Thread via GitHub
kirktrue commented on code in PR #14406: URL: https://github.com/apache/kafka/pull/14406#discussion_r1346616102 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/FetchRequestManagerTest.java: ## @@ -0,0 +1,3565 @@ +/* + * Licensed to the Apache Software

Re: [PR] KAFKA-14274 [6, 7]: Introduction of fetch request manager [kafka]

2023-10-04 Thread via GitHub
kirktrue commented on code in PR #14406: URL: https://github.com/apache/kafka/pull/14406#discussion_r1346615044 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractFetch.java: ## @@ -92,6 +88,23 @@ public AbstractFetch(final LogContext logContext,

Re: [PR] KAFKA-14274 [6, 7]: Introduction of fetch request manager [kafka]

2023-10-04 Thread via GitHub
kirktrue commented on code in PR #14406: URL: https://github.com/apache/kafka/pull/14406#discussion_r1346613925 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/PrototypeAsyncConsumer.java: ## @@ -622,12 +837,18 @@ public void assign(Collection partitions)

Re: [PR] KAFKA-14274 [6, 7]: Introduction of fetch request manager [kafka]

2023-10-04 Thread via GitHub
kirktrue commented on code in PR #14406: URL: https://github.com/apache/kafka/pull/14406#discussion_r1346612374 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/PrototypeAsyncConsumer.java: ## @@ -192,71 +321,38 @@ public PrototypeAsyncConsumer(final

Re: [PR] KAFKA-14519; [1/N] Implement coordinator runtime metrics [kafka]

2023-10-04 Thread via GitHub
jeffkbkim commented on code in PR #14417: URL: https://github.com/apache/kafka/pull/14417#discussion_r1346610016 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/metrics/CoordinatorRuntimeMetrics.java: ## @@ -0,0 +1,100 @@ +/* + * Licensed to the Apache

Re: [PR] KAFKA-14519; [1/N] Implement coordinator runtime metrics [kafka]

2023-10-04 Thread via GitHub
jeffkbkim commented on code in PR #14417: URL: https://github.com/apache/kafka/pull/14417#discussion_r1346608656 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/CoordinatorRuntime.java: ## @@ -156,15 +165,16 @@ public CoordinatorRuntime build() {

Re: [PR] KAFKA-14519; [1/N] Implement coordinator runtime metrics [kafka]

2023-10-04 Thread via GitHub
jeffkbkim commented on code in PR #14417: URL: https://github.com/apache/kafka/pull/14417#discussion_r1346607275 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/metrics/GroupCoordinatorRuntimeMetrics.java: ## @@ -0,0 +1,353 @@ +/* + * Licensed to the

Re: [PR] KAFKA-14274 [6, 7]: Introduction of fetch request manager [kafka]

2023-10-04 Thread via GitHub
kirktrue commented on code in PR #14406: URL: https://github.com/apache/kafka/pull/14406#discussion_r1346607807 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/FetchRequestManager.java: ## @@ -0,0 +1,136 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] KAFKA-14274 [6, 7]: Introduction of fetch request manager [kafka]

2023-10-04 Thread via GitHub
kirktrue commented on code in PR #14406: URL: https://github.com/apache/kafka/pull/14406#discussion_r1346606932 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/Fetcher.java: ## @@ -106,7 +127,62 @@ public void onFailure(RuntimeException e) { return

Re: [PR] KAFKA-14274 [6, 7]: Introduction of fetch request manager [kafka]

2023-10-04 Thread via GitHub
kirktrue commented on code in PR #14406: URL: https://github.com/apache/kafka/pull/14406#discussion_r1346606768 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/ApplicationEventHandler.java: ## @@ -0,0 +1,122 @@ +/* + * Licensed to the Apache Software

Re: [PR] KAFKA-15468: Prevent transaction coordinator reloads on already loaded leaders [kafka]

2023-10-04 Thread via GitHub
jolshan commented on code in PR #14489: URL: https://github.com/apache/kafka/pull/14489#discussion_r1346606122 ## core/src/main/scala/kafka/coordinator/transaction/TransactionMetadata.scala: ## @@ -375,7 +375,7 @@ private[transaction] class TransactionMetadata(val

Re: [PR] KAFKA-14274 [6, 7]: Introduction of fetch request manager [kafka]

2023-10-04 Thread via GitHub
kirktrue commented on code in PR #14406: URL: https://github.com/apache/kafka/pull/14406#discussion_r1346604856 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/BackgroundEventHandler.java: ## @@ -0,0 +1,52 @@ +/* + * Licensed to the Apache Software

[PR] KAFKA-15468: Prevent transaction coordinator reloads on already loaded leaders [kafka]

2023-10-04 Thread via GitHub
jolshan opened a new pull request, #14489: URL: https://github.com/apache/kafka/pull/14489 This PR has two parts: 1. Redefining the TopicDelta fields to better distinguish when a leader is elected (leader epoch bump) vs when a leader has isr/replica changes (partition epoch bump).

Re: [PR] KAFKA-14519; [1/N] Implement coordinator runtime metrics [kafka]

2023-10-04 Thread via GitHub
jeffkbkim commented on code in PR #14417: URL: https://github.com/apache/kafka/pull/14417#discussion_r1346600021 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/metrics/CoordinatorRuntimeMetrics.java: ## @@ -0,0 +1,100 @@ +/* + * Licensed to the Apache

Re: [PR] KAFKA-14519; [1/N] Implement coordinator runtime metrics [kafka]

2023-10-04 Thread via GitHub
jeffkbkim commented on code in PR #14417: URL: https://github.com/apache/kafka/pull/14417#discussion_r1346596121 ## core/src/test/scala/unit/kafka/coordinator/group/CoordinatorLoaderImplTest.scala: ## @@ -283,7 +292,63 @@ class CoordinatorLoaderImplTest { minOneMessage

Re: [PR] KAFKA-15547 fixes thread leak in MirrorMakerConfigTest [kafka]

2023-10-04 Thread via GitHub
kpatelatwork commented on PR #14487: URL: https://github.com/apache/kafka/pull/14487#issuecomment-1747775381 below test failures are only in the Scala 2.13 build and unrelated to this change ``` QuorumControllerTest > testBrokerHeartbeatDuringMigration(MetadataVersion) > [1] 3.4-IV0

Re: [PR] KAFKA-14274 [6, 7]: Introduction of fetch request manager [kafka]

2023-10-04 Thread via GitHub
kirktrue commented on code in PR #14406: URL: https://github.com/apache/kafka/pull/14406#discussion_r1346546088 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/PrototypeAsyncConsumer.java: ## @@ -621,56 +825,174 @@ public void assign(Collection partitions)

Re: [PR] KAFKA-14274 [6, 7]: Introduction of fetch request manager [kafka]

2023-10-04 Thread via GitHub
kirktrue commented on code in PR #14406: URL: https://github.com/apache/kafka/pull/14406#discussion_r1346545044 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/FetchBuffer.java: ## @@ -37,7 +36,7 @@ * * Note: this class is not thread-safe and is

Re: [PR] KAFKA-14274 [6, 7]: Introduction of fetch request manager [kafka]

2023-10-04 Thread via GitHub
kirktrue commented on code in PR #14406: URL: https://github.com/apache/kafka/pull/14406#discussion_r1346517075 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/PrototypeAsyncConsumer.java: ## @@ -621,56 +825,174 @@ public void assign(Collection partitions)

Re: [PR] KAFKA-14274 [6, 7]: Introduction of fetch request manager [kafka]

2023-10-04 Thread via GitHub
kirktrue commented on code in PR #14406: URL: https://github.com/apache/kafka/pull/14406#discussion_r1346508562 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/PrototypeAsyncConsumer.java: ## @@ -693,15 +1015,14 @@ private boolean

Re: [PR] KAFKA-14274 [6, 7]: Introduction of fetch request manager [kafka]

2023-10-04 Thread via GitHub
kirktrue commented on code in PR #14406: URL: https://github.com/apache/kafka/pull/14406#discussion_r1346504058 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/FetchRequestManager.java: ## @@ -0,0 +1,186 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] KAFKA-14274 [6, 7]: Introduction of fetch request manager [kafka]

2023-10-04 Thread via GitHub
philipnee commented on code in PR #14406: URL: https://github.com/apache/kafka/pull/14406#discussion_r1346493970 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/Fetcher.java: ## @@ -106,7 +127,62 @@ public void onFailure(RuntimeException e) {

Re: [PR] KAFKA-15278: Implement HeartbeatRequestManager to handle heartbeat requests [kafka]

2023-10-04 Thread via GitHub
philipnee commented on PR #14364: URL: https://github.com/apache/kafka/pull/14364#issuecomment-1747674288 Thanks @dajac - I refactored some tests based on your comments. Thanks a lot for putting time into it. Here I've got a list of Jira for the follow-ups: - Propagate time during

[jira] [Updated] (KAFKA-15548) Handling close() properly

2023-10-04 Thread Philip Nee (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15548?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Philip Nee updated KAFKA-15548: --- Parent: KAFKA-14246 Issue Type: Sub-task (was: Bug) > Handling close() properly >

[jira] [Created] (KAFKA-15548) Handling close() properly

2023-10-04 Thread Philip Nee (Jira)
Philip Nee created KAFKA-15548: -- Summary: Handling close() properly Key: KAFKA-15548 URL: https://issues.apache.org/jira/browse/KAFKA-15548 Project: Kafka Issue Type: Bug Components:

Re: [PR] KAFKA-15278: Implement HeartbeatRequestManager to handle heartbeat requests [kafka]

2023-10-04 Thread via GitHub
philipnee commented on code in PR #14364: URL: https://github.com/apache/kafka/pull/14364#discussion_r1346463825 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManagerTest.java: ## @@ -0,0 +1,346 @@ +/* + * Licensed to the Apache Software

[PR] MINOR Added version 3.6.0 to system tests [kafka]

2023-10-04 Thread via GitHub
satishd opened a new pull request, #14488: URL: https://github.com/apache/kafka/pull/14488 Added version 3.6.0 to system tests. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ]

Re: [PR] KAFKA-15330: Add missing documentation of metrics introduced as part of KAFKA-15028 [kafka]

2023-10-04 Thread via GitHub
jolshan merged PR #14480: URL: https://github.com/apache/kafka/pull/14480 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] KAFKA-15330: Add missing documentation of metrics introduced as part of KAFKA-15028 [kafka]

2023-10-04 Thread via GitHub
jolshan commented on PR #14480: URL: https://github.com/apache/kafka/pull/14480#issuecomment-1747589664 Tests are unrelated  It is a bit worrying we see this large number of failures in Java 11 from time to time. I may follow up later. -- This is an automated message from the Apache

Re: [PR] KAFKA-15356: Generate and persist directory IDs [kafka]

2023-10-04 Thread via GitHub
rondagostino commented on code in PR #14291: URL: https://github.com/apache/kafka/pull/14291#discussion_r1346212521 ## clients/src/main/java/org/apache/kafka/common/Uuid.java: ## @@ -27,16 +30,33 @@ */ public class Uuid implements Comparable { +/** + * A reserved

[PR] KAFKA-15547 fixes thread leak in MirrorMakerConfigTest [kafka]

2023-10-04 Thread via GitHub
kpatelatwork opened a new pull request, #14487: URL: https://github.com/apache/kafka/pull/14487 The test MirrorMakerConfigTest#testClientConfigProperties` creates a `ForwardingAdmin` but needs to use `try-with-resources` statement to ensure the Admin client is closed ### Committer

Re: [PR] KAFKA-15547 fixes thread leak in MirrorMakerConfigTest [kafka]

2023-10-04 Thread via GitHub
kpatelatwork commented on PR #14487: URL: https://github.com/apache/kafka/pull/14487#issuecomment-1747424669 Hey @yashmayya would you be able to review this change? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] KAFKA-14274 [6, 7]: Introduction of fetch request manager [kafka]

2023-10-04 Thread via GitHub
kirktrue commented on code in PR #14406: URL: https://github.com/apache/kafka/pull/14406#discussion_r1346278813 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/BackgroundEventProcessor.java: ## @@ -0,0 +1,77 @@ +/* + * Licensed to the Apache Software

Re: [PR] KAFKA-14274 [6, 7]: Introduction of fetch request manager [kafka]

2023-10-04 Thread via GitHub
kirktrue commented on code in PR #14406: URL: https://github.com/apache/kafka/pull/14406#discussion_r1346270372 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/DefaultBackgroundThread.java: ## @@ -222,58 +99,158 @@ public void run() { } catch

[jira] [Assigned] (KAFKA-15547) Thread leak in MirrorMakerConfigTest#testClientConfigProperties

2023-10-04 Thread Kalpesh Patel (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15547?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kalpesh Patel reassigned KAFKA-15547: - Assignee: Kalpesh Patel > Thread leak in

[jira] [Created] (KAFKA-15547) Thread leak in MirrorMakerConfigTest#testClientConfigProperties

2023-10-04 Thread Kalpesh Patel (Jira)
Kalpesh Patel created KAFKA-15547: - Summary: Thread leak in MirrorMakerConfigTest#testClientConfigProperties Key: KAFKA-15547 URL: https://issues.apache.org/jira/browse/KAFKA-15547 Project: Kafka

Re: [PR] KAFKA-15278: Implement HeartbeatRequestManager to handle heartbeat requests [kafka]

2023-10-04 Thread via GitHub
philipnee commented on code in PR #14364: URL: https://github.com/apache/kafka/pull/14364#discussion_r1346258637 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManagerTest.java: ## @@ -0,0 +1,346 @@ +/* + * Licensed to the Apache Software

Re: [PR] KIP-951: Server side and protocol changes for KIP-951 [kafka]

2023-10-04 Thread via GitHub
msn-tldr commented on code in PR #1: URL: https://github.com/apache/kafka/pull/1#discussion_r1346257999 ## clients/src/main/resources/common/message/FetchRequest.json: ## @@ -53,7 +53,9 @@ // // Version 15 adds the ReplicaState which includes new field

Re: [PR] KAFKA-15278: Implement HeartbeatRequestManager to handle heartbeat requests [kafka]

2023-10-04 Thread via GitHub
philipnee commented on code in PR #14364: URL: https://github.com/apache/kafka/pull/14364#discussion_r1346245842 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManagerTest.java: ## @@ -0,0 +1,346 @@ +/* + * Licensed to the Apache Software

Re: [PR] KAFKA-15278: Implement HeartbeatRequestManager to handle heartbeat requests [kafka]

2023-10-04 Thread via GitHub
philipnee commented on code in PR #14364: URL: https://github.com/apache/kafka/pull/14364#discussion_r1346244285 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManagerTest.java: ## @@ -0,0 +1,346 @@ +/* + * Licensed to the Apache Software

Re: [PR] KIP-951: Server side and protocol changes for KIP-951 [kafka]

2023-10-04 Thread via GitHub
chb2ab commented on code in PR #1: URL: https://github.com/apache/kafka/pull/1#discussion_r1346244195 ## clients/src/main/java/org/apache/kafka/common/requests/FetchResponse.java: ## @@ -276,11 +289,16 @@ private static FetchResponseData toMessage(Errors error,

[jira] [Commented] (KAFKA-15530) Add missing documentation of metrics introduced as part of KAFKA-15028

2023-10-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17771948#comment-17771948 ] ASF GitHub Bot commented on KAFKA-15530: jolshan opened a new pull request, #555: URL:

Re: [PR] KAFKA-15278: Implement HeartbeatRequestManager to handle heartbeat requests [kafka]

2023-10-04 Thread via GitHub
philipnee commented on code in PR #14364: URL: https://github.com/apache/kafka/pull/14364#discussion_r1346233433 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManagerTest.java: ## @@ -0,0 +1,346 @@ +/* + * Licensed to the Apache Software

Re: [PR] KAFKA-14274 [6, 7]: Introduction of fetch request manager [kafka]

2023-10-04 Thread via GitHub
kirktrue commented on code in PR #14406: URL: https://github.com/apache/kafka/pull/14406#discussion_r1346234546 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/DefaultBackgroundThread.java: ## @@ -222,58 +99,158 @@ public void run() { } catch

[jira] [Created] (KAFKA-15546) Transactions tool duration field confusing for completed transactions

2023-10-04 Thread Justine Olshan (Jira)
Justine Olshan created KAFKA-15546: -- Summary: Transactions tool duration field confusing for completed transactions Key: KAFKA-15546 URL: https://issues.apache.org/jira/browse/KAFKA-15546 Project:

Re: [PR] KAFKA-14734: Use CommandDefaultOptions in StreamsResetter [kafka]

2023-10-04 Thread via GitHub
mjsax commented on PR #13983: URL: https://github.com/apache/kafka/pull/13983#issuecomment-1747335866 Just discovered this PR -- Seems it part of KIP-906, but the KIP does not cover the renaming of the method -- it's technically a breaking change... Given that `StreamsResetter` is

Re: [PR] [MINOR] remove meaningless lines [kafka]

2023-10-04 Thread via GitHub
sangyongchoi commented on PR #14423: URL: https://github.com/apache/kafka/pull/14423#issuecomment-1747310104 @vamossagar12 1. If I find it while looking at the sauce, I will add it. 2. I do -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] KAFKA-14504: Implement DescribeGroups API [kafka]

2023-10-04 Thread via GitHub
dongnuo123 commented on code in PR #14462: URL: https://github.com/apache/kafka/pull/14462#discussion_r1346196993 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java: ## @@ -8686,6 +8695,88 @@ public void testListGroups() {

Re: [PR] KAFKA-14504: Implement DescribeGroups API [kafka]

2023-10-04 Thread via GitHub
dongnuo123 commented on code in PR #14462: URL: https://github.com/apache/kafka/pull/14462#discussion_r1346196163 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -521,6 +575,31 @@ GenericGroup getOrMaybeCreateGenericGroup(

[jira] [Updated] (KAFKA-14761) Integration Tests for the New Consumer Implementation

2023-10-04 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14761?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-14761: -- Parent: KAFKA-14246 Issue Type: Sub-task (was: Task) > Integration Tests for the New

[jira] [Updated] (KAFKA-14875) Implement Wakeup()

2023-10-04 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14875?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-14875: -- Parent: KAFKA-14246 Issue Type: Sub-task (was: Task) > Implement Wakeup() >

[jira] [Updated] (KAFKA-15277) Design & implement support for internal Consumer delegates

2023-10-04 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15277?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-15277: -- Parent: KAFKA-14246 Issue Type: Sub-task (was: Task) > Design & implement support for

[jira] [Updated] (KAFKA-15304) CompletableApplicationEvents aren't being completed when the consumer is closing

2023-10-04 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15304?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-15304: -- Parent: KAFKA-14246 Issue Type: Sub-task (was: Bug) > CompletableApplicationEvents aren't

[jira] [Updated] (KAFKA-14960) Metadata Request Manager and listTopics/partitionsFor API

2023-10-04 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14960?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-14960: -- Parent: KAFKA-14246 Issue Type: Sub-task (was: Task) > Metadata Request Manager and

[jira] [Updated] (KAFKA-15180) Generalize integration tests to change use of KafkaConsumer to Consumer

2023-10-04 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15180?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-15180: -- Parent: KAFKA-14246 Issue Type: Sub-task (was: Test) > Generalize integration tests to

[jira] [Updated] (KAFKA-15284) Implement ConsumerGroupProtocolVersionResolver to determine consumer group protocol

2023-10-04 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15284?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-15284: -- Parent: KAFKA-14246 Issue Type: Sub-task (was: Task) > Implement

Re: [PR] KAFKA-15415: On producer-batch retry, skip-backoff on a new leader [kafka]

2023-10-04 Thread via GitHub
msn-tldr commented on code in PR #14384: URL: https://github.com/apache/kafka/pull/14384#discussion_r1346188807 ## clients/src/test/java/org/apache/kafka/clients/producer/internals/SenderTest.java: ## @@ -3146,6 +3149,97 @@ public void testInvalidTxnStateIsAnAbortableError()

[jira] [Updated] (KAFKA-14965) Introduce OffsetsRequestManager to integrate ListOffsets requests into new consumer threading refactor

2023-10-04 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14965?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-14965: -- Parent: KAFKA-14246 Issue Type: Sub-task (was: Task) > Introduce OffsetsRequestManager to

[jira] [Updated] (KAFKA-15081) Implement new consumer offsetsForTimes

2023-10-04 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15081?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-15081: -- Parent: KAFKA-14246 Issue Type: Sub-task (was: Task) > Implement new consumer

[jira] [Updated] (KAFKA-14848) KafkaConsumer incorrectly passes locally-scoped deserializers to FetchConfig

2023-10-04 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14848?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-14848: -- Parent: KAFKA-14246 Issue Type: Sub-task (was: Bug) > KafkaConsumer incorrectly passes

[jira] [Updated] (KAFKA-14274) Introduce FetchRequestManager to integrate fetch into new consumer threading refactor

2023-10-04 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14274?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-14274: -- Parent: KAFKA-14246 Issue Type: Sub-task (was: Task) > Introduce FetchRequestManager to

[jira] [Updated] (KAFKA-15173) Consumer event queues should be bounded

2023-10-04 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-15173: -- Parent: KAFKA-14246 Issue Type: Sub-task (was: Task) > Consumer event queues should be

[jira] [Updated] (KAFKA-14724) Port tests in FetcherTest to FetchRequestManagerTest

2023-10-04 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14724?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-14724: -- Parent: KAFKA-14246 Issue Type: Sub-task (was: Task) > Port tests in FetcherTest to

[jira] [Updated] (KAFKA-14937) Refactoring for client code to reduce boilerplate

2023-10-04 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14937?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-14937: -- Parent: KAFKA-14246 Issue Type: Sub-task (was: Improvement) > Refactoring for client code to

[jira] [Updated] (KAFKA-14966) Extract reusable logic from OffsetFetcher

2023-10-04 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14966?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-14966: -- Parent: KAFKA-14246 Issue Type: Sub-task (was: Task) > Extract reusable logic from

[jira] [Updated] (KAFKA-15320) Document event queueing patterns

2023-10-04 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15320?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-15320: -- Parent: KAFKA-14246 Issue Type: Sub-task (was: Task) > Document event queueing patterns >

[jira] [Updated] (KAFKA-14675) Extract metadata-related tasks from Fetcher into MetadataFetcher

2023-10-04 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14675?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-14675: -- Parent: KAFKA-14246 Issue Type: Sub-task (was: Task) > Extract metadata-related tasks from

[jira] [Updated] (KAFKA-15320) Document event queueing patterns

2023-10-04 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15320?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-15320: -- Parent: (was: KAFKA-15173) Issue Type: Task (was: Sub-task) > Document event queueing

Re: [PR] MINOR: Update the list of collaborators [kafka]

2023-10-04 Thread via GitHub
yashmayya commented on PR #14486: URL: https://github.com/apache/kafka/pull/14486#issuecomment-1747287584 Mentioning the newly added collaborators here as an FYI - @kamalcph @hudeqi @lihaosky @jeffkbkim @tinaselenge You can check out the `Collaborators` section on

[jira] [Updated] (KAFKA-14758) Extract inner classes from Fetcher for reuse in refactoring

2023-10-04 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14758?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-14758: -- Parent: KAFKA-14246 Issue Type: Sub-task (was: Task) > Extract inner classes from Fetcher

[jira] [Updated] (KAFKA-14365) Extract common logic from Fetcher

2023-10-04 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14365?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-14365: -- Parent: KAFKA-14246 Issue Type: Sub-task (was: Task) > Extract common logic from Fetcher >

Re: [PR] MINOR: Update the list of collaborators [kafka]

2023-10-04 Thread via GitHub
yashmayya merged PR #14486: URL: https://github.com/apache/kafka/pull/14486 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Updated] (KAFKA-15184) New consumer internals refactoring and clean up

2023-10-04 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15184?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-15184: -- Parent: KAFKA-14246 Issue Type: Sub-task (was: Task) > New consumer internals refactoring

[jira] [Updated] (KAFKA-15188) Implement more of the remaining PrototypeAsyncConsumer APIs

2023-10-04 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15188?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-15188: -- Parent: KAFKA-14246 Issue Type: Sub-task (was: Task) > Implement more of the remaining

[jira] [Updated] (KAFKA-15316) CommitRequestManager not calling RequestState callbacks

2023-10-04 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15316?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-15316: -- Parent: KAFKA-14246 Issue Type: Sub-task (was: Bug) > CommitRequestManager not calling

[jira] [Updated] (KAFKA-15281) Implement the groupMetadata Consumer API

2023-10-04 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-15281: -- Parent: KAFKA-14246 Issue Type: Sub-task (was: Task) > Implement the groupMetadata Consumer

[jira] [Updated] (KAFKA-15317) Fix for async consumer access to committed offsets with multiple consumers

2023-10-04 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-15317: -- Parent: KAFKA-14246 Issue Type: Sub-task (was: Task) > Fix for async consumer access to

[jira] [Updated] (KAFKA-15515) Remove duplicated integration tests for new consumer

2023-10-04 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15515?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-15515: -- Parent: KAFKA-14246 Issue Type: Sub-task (was: Task) > Remove duplicated integration tests

[jira] [Updated] (KAFKA-15438) Review exception caching logic used for reset/validate positions in async consumer

2023-10-04 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15438?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-15438: -- Parent: KAFKA-14246 Issue Type: Sub-task (was: Task) > Review exception caching logic used

[jira] [Updated] (KAFKA-15475) Timeout request might retry forever even if the user API times out in PrototypeAsyncConsumer

2023-10-04 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15475?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-15475: -- Labels: consumer-threading-refactor (was: ) > Timeout request might retry forever even if the user

Re: [PR] KAFKA-14274 [6, 7]: Introduction of fetch request manager [kafka]

2023-10-04 Thread via GitHub
junrao commented on code in PR #14406: URL: https://github.com/apache/kafka/pull/14406#discussion_r1346179200 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/FetchBuffer.java: ## @@ -37,7 +36,7 @@ * * Note: this class is not thread-safe and is intended

[jira] [Updated] (KAFKA-15475) Timeout request might retry forever even if the user API times out in PrototypeAsyncConsumer

2023-10-04 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15475?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-15475: -- Parent: KAFKA-14246 Issue Type: Sub-task (was: Bug) > Timeout request might retry forever

[jira] [Updated] (KAFKA-15534) Propagate client response time when timeout to the request handler

2023-10-04 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15534?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-15534: -- Labels: consumer-threading-refactor (was: ) > Propagate client response time when timeout to the

[jira] [Updated] (KAFKA-15475) Timeout request might retry forever even if the user API times out in PrototypeAsyncConsumer

2023-10-04 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15475?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-15475: -- Summary: Timeout request might retry forever even if the user API times out in PrototypeAsyncConsumer

[jira] [Updated] (KAFKA-15534) Propagate client response time when timeout to the request handler

2023-10-04 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15534?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-15534: -- Parent: KAFKA-14246 Issue Type: Sub-task (was: Bug) > Propagate client response time when

[jira] [Updated] (KAFKA-15539) Client should stop fetching while partitions being revoked

2023-10-04 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15539?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-15539: -- Parent: KAFKA-14048 Issue Type: Sub-task (was: Task) > Client should stop fetching while

[jira] [Assigned] (KAFKA-15539) Client should stop fetching while partitions being revoked

2023-10-04 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15539?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True reassigned KAFKA-15539: - Assignee: Kirk True > Client should stop fetching while partitions being revoked >

[jira] [Updated] (KAFKA-15539) Client should stop fetching while partitions being revoked

2023-10-04 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15539?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-15539: -- Parent: (was: KAFKA-14048) Issue Type: Task (was: Sub-task) > Client should stop

  1   2   3   >