vamossagar12 commented on code in PR #14241:
URL: https://github.com/apache/kafka/pull/14241#discussion_r1349466119
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java:
##
@@ -459,19 +459,14 @@ boolean joinGroupIfNeeded(final Timer
vamossagar12 commented on PR #14241:
URL: https://github.com/apache/kafka/pull/14241#issuecomment-1751607482
Thanks for the interesting PR @haodanchen. If we focus on point number 1,
the main point that you are trying to make is that even though the
`generationsnapshot` is received in the
[
https://issues.apache.org/jira/browse/KAFKA-15378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17772748#comment-17772748
]
Matthias J. Sax commented on KAFKA-15378:
-
This is a partial fix with regard to versions...
[
https://issues.apache.org/jira/browse/KAFKA-15378?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax reassigned KAFKA-15378:
---
Assignee: Matthias J. Sax
> Rolling upgrade system tests are failing
>
philipnee commented on PR #14364:
URL: https://github.com/apache/kafka/pull/14364#issuecomment-1751592366
There's some issue with the jdk11 build - retriggering the tests don't seem
to work. So I opened a [DRAFT PR](https://github.com/apache/kafka/pull/14509)
to run the test. It seems
philipnee closed pull request #14364: KAFKA-15278: Implement
HeartbeatRequestManager to handle heartbeat requests
URL: https://github.com/apache/kafka/pull/14364
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
hudeqi commented on code in PR #14381:
URL: https://github.com/apache/kafka/pull/14381#discussion_r1349454991
##
storage/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteLogManagerConfig.java:
##
@@ -197,7 +197,7 @@ public final class RemoteLogManagerConfig {
hudeqi commented on code in PR #14381:
URL: https://github.com/apache/kafka/pull/14381#discussion_r1349450982
##
storage/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteLogManagerConfig.java:
##
@@ -197,7 +197,7 @@ public final class RemoteLogManagerConfig {
hudeqi commented on code in PR #14381:
URL: https://github.com/apache/kafka/pull/14381#discussion_r1349453329
##
core/src/main/scala/kafka/server/DynamicBrokerConfig.scala:
##
@@ -1129,3 +1131,50 @@ class DynamicProducerStateManagerConfig(val
producerStateManagerConfig:
hudeqi commented on code in PR #14381:
URL: https://github.com/apache/kafka/pull/14381#discussion_r1349450982
##
storage/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteLogManagerConfig.java:
##
@@ -197,7 +197,7 @@ public final class RemoteLogManagerConfig {
hanyuzheng7 commented on code in PR #14477:
URL: https://github.com/apache/kafka/pull/14477#discussion_r1349442309
##
streams/src/test/java/org/apache/kafka/streams/integration/IQv2StoreIntegrationTest.java:
##
@@ -816,29 +816,65 @@ private void shouldHandleRangeQueries(final
hanyuzheng7 commented on code in PR #14477:
URL: https://github.com/apache/kafka/pull/14477#discussion_r1349442309
##
streams/src/test/java/org/apache/kafka/streams/integration/IQv2StoreIntegrationTest.java:
##
@@ -816,29 +816,65 @@ private void shouldHandleRangeQueries(final
hanyuzheng7 commented on code in PR #14477:
URL: https://github.com/apache/kafka/pull/14477#discussion_r1349442196
##
streams/src/main/java/org/apache/kafka/streams/state/internals/MeteredKeyValueStore.java:
##
@@ -254,17 +254,37 @@ protected QueryResult runRangeQuery(final
soarez commented on code in PR #14290:
URL: https://github.com/apache/kafka/pull/14290#discussion_r1349439010
##
generator/src/main/java/org/apache/kafka/message/FieldSpec.java:
##
@@ -157,11 +157,6 @@ private void checkTagInvariants() {
this.taggedVersions
philipnee opened a new pull request, #14509:
URL: https://github.com/apache/kafka/pull/14509
JDK11 seems to fail all the time, so using this PR to run builds: PR-14364
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
philipnee commented on PR #14364:
URL: https://github.com/apache/kafka/pull/14364#issuecomment-1751532067
JDK11 build failed with `Command "git reset --hard" returned status code
128:` , for the rest here is the list of failing tests:
```
Build / JDK 21 and Scala 2.13 /
[
https://issues.apache.org/jira/browse/KAFKA-15276?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yi Ding updated KAFKA-15276:
Labels: kip-848 kip-848-client-support kip-848-e2e kip-848-preview (was:
kip-848 kip-848-client-support
[
https://issues.apache.org/jira/browse/KAFKA-15278?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yi Ding updated KAFKA-15278:
Labels: consumer-threading-refactor kip-848 kip-848-client-support
kip-848-e2e kip-848-preview (was:
[
https://issues.apache.org/jira/browse/KAFKA-15280?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yi Ding updated KAFKA-15280:
Labels: consumer-threading-refactor kip-848 kip-848-client-support
kip-848-e2e kip-848-preview (was:
[
https://issues.apache.org/jira/browse/KAFKA-15531?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yi Ding updated KAFKA-15531:
Labels: kip-848 kip-848-client-support kip-848-e2e kip-848-preview (was:
kip-848 kip-848-client-support
[
https://issues.apache.org/jira/browse/KAFKA-15542?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yi Ding updated KAFKA-15542:
Labels: kip-848 kip-848-client-support kip-848-e2e kip-848-preview (was:
kip-848 kip-848-client-support
[
https://issues.apache.org/jira/browse/KAFKA-15540?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yi Ding updated KAFKA-15540:
Labels: kip-848 kip-848-client-support kip-848-e2e kip-848-preview (was:
kip-848 kip-848-client-support
[
https://issues.apache.org/jira/browse/KAFKA-15533?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yi Ding updated KAFKA-15533:
Labels: kip-848-e2e kip-848-preview (was: kip-848-preview)
> Ensure HeartbeatRequestManager only send
[
https://issues.apache.org/jira/browse/KAFKA-15543?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yi Ding updated KAFKA-15543:
Labels: kip-848 kip-848-client-support kip-848-e2e kip-848-preview (was:
kip-848 kip-848-client-support
[
https://issues.apache.org/jira/browse/KAFKA-15554?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yi Ding updated KAFKA-15554:
Labels: kip-848-client-support kip-848-e2e kip-848-preview (was:
kip-848-client-support kip-848-preview)
jeffkbkim commented on code in PR #14467:
URL: https://github.com/apache/kafka/pull/14467#discussion_r1349386383
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/generic/GenericGroup.java:
##
@@ -898,6 +900,52 @@ public void createGroupTombstoneRecords(List
jeffkbkim commented on code in PR #14467:
URL: https://github.com/apache/kafka/pull/14467#discussion_r1349382254
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetMetadataManager.java:
##
@@ -544,6 +579,100 @@ public
artemlivshits commented on code in PR #14312:
URL: https://github.com/apache/kafka/pull/14312#discussion_r1349318665
##
metadata/src/main/java/org/apache/kafka/controller/PartitionChangeBuilder.java:
##
@@ -328,13 +349,38 @@ public Optional build() {
kirktrue commented on code in PR #14406:
URL: https://github.com/apache/kafka/pull/14406#discussion_r1349343412
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/FetchBuffer.java:
##
@@ -37,7 +36,7 @@
*
* Note: this class is not thread-safe and is
kirktrue commented on code in PR #14406:
URL: https://github.com/apache/kafka/pull/14406#discussion_r1349343753
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThread.java:
##
@@ -0,0 +1,252 @@
+/*
+ * Licensed to the Apache Software
kirktrue commented on code in PR #14406:
URL: https://github.com/apache/kafka/pull/14406#discussion_r1349342751
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/PrototypeAsyncConsumer.java:
##
@@ -636,42 +857,148 @@ public void assign(Collection
partitions)
jeffkbkim commented on code in PR #14467:
URL: https://github.com/apache/kafka/pull/14467#discussion_r1349341227
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/OffsetMetadataManagerTest.java:
##
@@ -1763,6 +1803,120 @@ public void
jeffkbkim commented on code in PR #14467:
URL: https://github.com/apache/kafka/pull/14467#discussion_r1349340087
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/OffsetMetadataManagerTest.java:
##
@@ -1763,6 +1803,120 @@ public void
lianetm closed pull request #14503: MINOR - KAFKA-15550: Validation for
negative target times in offsetsForTimes
URL: https://github.com/apache/kafka/pull/14503
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
Chris Egerton created KAFKA-15563:
-
Summary: Provide informative error messages when Connect REST
requests time out
Key: KAFKA-15563
URL: https://issues.apache.org/jira/browse/KAFKA-15563
Project:
mjsax commented on code in PR #14508:
URL: https://github.com/apache/kafka/pull/14508#discussion_r1349252619
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java:
##
@@ -223,10 +223,7 @@ boolean handleCorruption(final Set corruptedTasks)
{
[
https://issues.apache.org/jira/browse/KAFKA-15455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17772677#comment-17772677
]
Philip Nee commented on KAFKA-15455:
It seems like we missed the error handling in the request
[
https://issues.apache.org/jira/browse/KAFKA-15562?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Philip Nee updated KAFKA-15562:
---
Parent: KAFKA-14246
Issue Type: Sub-task (was: Bug)
> CommitRequestManager needs to test
Philip Nee created KAFKA-15562:
--
Summary: CommitRequestManager needs to test different error
handling
Key: KAFKA-15562
URL: https://issues.apache.org/jira/browse/KAFKA-15562
Project: Kafka
[
https://issues.apache.org/jira/browse/KAFKA-15455?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lianet Magrans reassigned KAFKA-15455:
--
Assignee: Philip Nee (was: Lianet Magrans)
> Add support for OffsetCommit version 9
[
https://issues.apache.org/jira/browse/KAFKA-15456?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lianet Magrans reassigned KAFKA-15456:
--
Assignee: Lianet Magrans
> Add support for OffsetFetch version 9 in consumer
>
hachikuji commented on code in PR #1:
URL: https://github.com/apache/kafka/pull/1#discussion_r1349226317
##
clients/src/main/resources/common/message/ProduceResponse.json:
##
@@ -32,7 +32,9 @@
// records that cause the whole batch to be dropped. See KIP-467 for
philipnee commented on code in PR #14406:
URL: https://github.com/apache/kafka/pull/14406#discussion_r1349221937
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThread.java:
##
@@ -0,0 +1,252 @@
+/*
+ * Licensed to the Apache Software
cadonna opened a new pull request, #14508:
URL: https://github.com/apache/kafka/pull/14508
When tasks are found corrupted, Kafka Streams tries to commit the
non-corrupted tasks before closing and reviving the corrupted active tasks.
Besides active running tasks, Kafka Streams tries to
chb2ab commented on code in PR #1:
URL: https://github.com/apache/kafka/pull/1#discussion_r1349137249
##
clients/src/main/java/org/apache/kafka/common/requests/ProduceResponse.java:
##
@@ -67,20 +69,31 @@ public ProduceResponse(ProduceResponseData
produceResponseData)
chb2ab commented on code in PR #1:
URL: https://github.com/apache/kafka/pull/1#discussion_r1349137249
##
clients/src/main/java/org/apache/kafka/common/requests/ProduceResponse.java:
##
@@ -67,20 +69,31 @@ public ProduceResponse(ProduceResponseData
produceResponseData)
chb2ab commented on code in PR #1:
URL: https://github.com/apache/kafka/pull/1#discussion_r1349136486
##
clients/src/main/java/org/apache/kafka/common/requests/FetchResponse.java:
##
@@ -276,11 +289,16 @@ private static FetchResponseData toMessage(Errors error,
rondagostino merged PR #14291:
URL: https://github.com/apache/kafka/pull/14291
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
rondagostino commented on PR #14291:
URL: https://github.com/apache/kafka/pull/14291#issuecomment-1751113965
Test failures are unrelated. Merging to trunk.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
[
https://issues.apache.org/jira/browse/KAFKA-15454?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Philip Nee updated KAFKA-15454:
---
Labels: kip-848 kip-848-preview (was: kip-848)
> Add support for OffsetCommit version 9 in admin
[
https://issues.apache.org/jira/browse/KAFKA-15457?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Philip Nee updated KAFKA-15457:
---
Labels: kip-848-preview (was: )
> Add support for OffsetFetch version 9 in admin
>
[
https://issues.apache.org/jira/browse/KAFKA-15454?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Philip Nee updated KAFKA-15454:
---
Labels: kip-848 (was: )
> Add support for OffsetCommit version 9 in admin client
>
dajac commented on code in PR #14432:
URL: https://github.com/apache/kafka/pull/14432#discussion_r1348699907
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroup.java:
##
@@ -107,6 +107,11 @@ public static class DeadlineAndEpoch {
philipnee commented on code in PR #14364:
URL: https://github.com/apache/kafka/pull/14364#discussion_r1348885178
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java:
##
@@ -0,0 +1,385 @@
+/*
+ * Licensed to the Apache Software
mannoopj commented on PR #14295:
URL: https://github.com/apache/kafka/pull/14295#issuecomment-1750918421
cc: @dengziming
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
[
https://issues.apache.org/jira/browse/KAFKA-14387?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
masood closed KAFKA-14387.
--
> kafka.common.KafkaException | kafka_2.12-3.3.1.jar
> ---
>
>
nikramakrishnan commented on PR #14212:
URL: https://github.com/apache/kafka/pull/14212#issuecomment-1750844756
@showuon @divijvaidya thanks for your reviews! I have addressed all the
comments, and believe this PR is ready to be merged.
--
This is an automated message from the Apache Git
jeffkbkim commented on code in PR #14467:
URL: https://github.com/apache/kafka/pull/14467#discussion_r1348814529
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/generic/GenericGroup.java:
##
@@ -898,6 +904,53 @@ public void createGroupTombstoneRecords(List
nizhikov commented on PR #13214:
URL: https://github.com/apache/kafka/pull/13214#issuecomment-1750793532
Hello @Hangleton . Do you need help with review of this PR?
Are you still workin on it?
--
This is an automated message from the Apache Git Service.
To respond to the message,
[
https://issues.apache.org/jira/browse/KAFKA-15344?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lucas Brutschy reassigned KAFKA-15344:
--
Assignee: Lucas Brutschy (was: Lucas Brutschy)
> Kafka Streams should include the
lucasbru commented on code in PR #14193:
URL: https://github.com/apache/kafka/pull/14193#discussion_r1348755156
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java:
##
@@ -452,6 +468,31 @@ public static StreamThread create(final
Lianet Magrans created KAFKA-15561:
--
Summary: Client support for new SubscriptionPattern based
subscription
Key: KAFKA-15561
URL: https://issues.apache.org/jira/browse/KAFKA-15561
Project: Kafka
[
https://issues.apache.org/jira/browse/KAFKA-15538?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lianet Magrans updated KAFKA-15538:
---
Labels: kip-848 kip-848-client-support kip-848-preview (was: kip-848
[
https://issues.apache.org/jira/browse/KAFKA-15538?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lianet Magrans updated KAFKA-15538:
---
Labels: kip-848 kip-848-client-support kip-848-preview (was: kip-848
[
https://issues.apache.org/jira/browse/KAFKA-15538?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lianet Magrans updated KAFKA-15538:
---
Summary: Client support for java regex based subscription (was: Client
java regex support
[
https://issues.apache.org/jira/browse/KAFKA-15538?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lianet Magrans updated KAFKA-15538:
---
Description:
When using subscribe with a java regex (Pattern), we need to resolve it on the
[
https://issues.apache.org/jira/browse/KAFKA-15538?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lianet Magrans updated KAFKA-15538:
---
Summary: Client java regex support (was: Resolve regex on client side
when using java
iit2009060 commented on code in PR #14482:
URL: https://github.com/apache/kafka/pull/14482#discussion_r1348694105
##
core/src/test/scala/unit/kafka/log/remote/RemoteIndexCacheTest.scala:
##
@@ -524,23 +527,221 @@ class RemoteIndexCacheTest {
}
}
- @Test
- def
[
https://issues.apache.org/jira/browse/KAFKA-15456?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lianet Magrans updated KAFKA-15456:
---
Labels: kip-848-client-support kip-848-preview (was: )
> Add support for OffsetFetch
[
https://issues.apache.org/jira/browse/KAFKA-15455?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lianet Magrans updated KAFKA-15455:
---
Labels: kip-848-client-support kip-848-preview (was: )
> Add support for OffsetCommit
[
https://issues.apache.org/jira/browse/KAFKA-15540?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lianet Magrans updated KAFKA-15540:
---
Labels: kip-848 kip-848-client-support kip-848-preview (was: kip-848
dajac commented on code in PR #14364:
URL: https://github.com/apache/kafka/pull/14364#discussion_r1348690378
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java:
##
@@ -0,0 +1,385 @@
+/*
+ * Licensed to the Apache Software
[
https://issues.apache.org/jira/browse/KAFKA-15542?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lianet Magrans updated KAFKA-15542:
---
Labels: kip-848 kip-848-client-support kip-848-preview (was: kip-848
[
https://issues.apache.org/jira/browse/KAFKA-15543?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lianet Magrans updated KAFKA-15543:
---
Labels: kip-848 kip-848-client-support kip-848-preview (was: kip-848
[
https://issues.apache.org/jira/browse/KAFKA-15327?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lianet Magrans updated KAFKA-15327:
---
Labels: kip-848 kip-848-client-support kip-848-preview (was: kip-848
bmscomp commented on code in PR #14502:
URL: https://github.com/apache/kafka/pull/14502#discussion_r1348664633
##
gradlew:
##
@@ -157,15 +158,15 @@ if ! "$cygwin" && ! "$darwin" && ! "$nonstop" ; then
case $MAX_FD in #(
max*)
# In POSIX sh, ulimit -H is
[
https://issues.apache.org/jira/browse/KAFKA-15544?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lianet Magrans updated KAFKA-15544:
---
Description: Enable & validate integration tests defined in
`PlaintextAsyncConsumerTest`
bmscomp commented on code in PR #14502:
URL: https://github.com/apache/kafka/pull/14502#discussion_r1348663954
##
gradlew:
##
@@ -214,11 +215,11 @@ fi
# Add default JVM options here. You can also use JAVA_OPTS and GRADLE_OPTS to
pass JVM options to this script.
dajac commented on code in PR #14467:
URL: https://github.com/apache/kafka/pull/14467#discussion_r1348548710
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupCoordinatorShardTest.java:
##
@@ -623,4 +674,33 @@ public void
jeel2420 commented on code in PR #14483:
URL: https://github.com/apache/kafka/pull/14483#discussion_r1348624218
##
core/src/test/scala/unit/kafka/log/remote/RemoteIndexCacheTest.scala:
##
@@ -568,27 +621,26 @@ class RemoteIndexCacheTest {
}
private def
cadonna commented on code in PR #14193:
URL: https://github.com/apache/kafka/pull/14193#discussion_r1345894518
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java:
##
@@ -387,7 +391,9 @@ public static StreamThread create(final
dajac commented on code in PR #14467:
URL: https://github.com/apache/kafka/pull/14467#discussion_r1348542303
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/generic/GenericGroup.java:
##
@@ -898,6 +904,53 @@ public void createGroupTombstoneRecords(List
dajac commented on code in PR #14467:
URL: https://github.com/apache/kafka/pull/14467#discussion_r1348539504
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetMetadataManager.java:
##
@@ -544,6 +573,81 @@ public
showuon commented on code in PR #14482:
URL: https://github.com/apache/kafka/pull/14482#discussion_r1348509233
##
core/src/test/scala/unit/kafka/log/remote/RemoteIndexCacheTest.scala:
##
@@ -524,23 +527,221 @@ class RemoteIndexCacheTest {
}
}
- @Test
- def
iit2009060 commented on code in PR #14482:
URL: https://github.com/apache/kafka/pull/14482#discussion_r1348507987
##
core/src/test/scala/unit/kafka/log/remote/RemoteIndexCacheTest.scala:
##
@@ -524,23 +527,221 @@ class RemoteIndexCacheTest {
}
}
- @Test
- def
showuon commented on code in PR #14482:
URL: https://github.com/apache/kafka/pull/14482#discussion_r1348497724
##
core/src/test/scala/unit/kafka/log/remote/RemoteIndexCacheTest.scala:
##
@@ -524,23 +527,221 @@ class RemoteIndexCacheTest {
}
}
- @Test
- def
dajac commented on code in PR #1:
URL: https://github.com/apache/kafka/pull/1#discussion_r1348494902
##
clients/src/main/resources/common/message/ProduceResponse.json:
##
@@ -32,7 +32,9 @@
// records that cause the whole batch to be dropped. See KIP-467 for
dajac merged PR #14462:
URL: https://github.com/apache/kafka/pull/14462
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
jeffkbkim commented on code in PR #14417:
URL: https://github.com/apache/kafka/pull/14417#discussion_r1348458471
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/metrics/CoordinatorRuntimeMetrics.java:
##
@@ -0,0 +1,100 @@
+/*
+ * Licensed to the Apache
r-sidd commented on PR #14507:
URL: https://github.com/apache/kafka/pull/14507#issuecomment-1750252772
> Thank you for submitting this change!
>
> Please list the release notes and diff in the description with an
explanation on why this upgrade will not break backward compatibility.
divijvaidya commented on code in PR #14502:
URL: https://github.com/apache/kafka/pull/14502#discussion_r1348447835
##
gradlew:
##
@@ -157,15 +158,15 @@ if ! "$cygwin" && ! "$darwin" && ! "$nonstop" ; then
case $MAX_FD in #(
max*)
# In POSIX sh, ulimit -H is
iit2009060 commented on code in PR #14482:
URL: https://github.com/apache/kafka/pull/14482#discussion_r1348438768
##
core/src/test/scala/unit/kafka/log/remote/RemoteIndexCacheTest.scala:
##
@@ -541,6 +541,126 @@ class RemoteIndexCacheTest {
verifyFetchIndexInvocation(count
showuon commented on code in PR #14482:
URL: https://github.com/apache/kafka/pull/14482#discussion_r1348432941
##
core/src/test/scala/unit/kafka/log/remote/RemoteIndexCacheTest.scala:
##
@@ -541,6 +541,126 @@ class RemoteIndexCacheTest {
verifyFetchIndexInvocation(count =
divijvaidya commented on PR #14507:
URL: https://github.com/apache/kafka/pull/14507#issuecomment-1750218919
Thank you for submitting this change!
Please list the release notes and diff in the description with an
explanation on why this upgrade will not break backward compatibility.
[
https://issues.apache.org/jira/browse/KAFKA-15530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17772488#comment-17772488
]
ASF GitHub Bot commented on KAFKA-15530:
divijvaidya merged PR #555:
URL:
r-sidd opened a new pull request, #14507:
URL: https://github.com/apache/kafka/pull/14507
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of testing
Siddharth R created KAFKA-15560:
---
Summary: Upgrade argparse4j to 0.9.0
Key: KAFKA-15560
URL: https://issues.apache.org/jira/browse/KAFKA-15560
Project: Kafka
Issue Type: Improvement
iit2009060 commented on PR #14482:
URL: https://github.com/apache/kafka/pull/14482#issuecomment-1750181038
> @iit2009060 , overall LGTM, left some refactor comments.
@showuon done as mentioned.
--
This is an automated message from the Apache Git Service.
To respond to the message,
iit2009060 commented on code in PR #14482:
URL: https://github.com/apache/kafka/pull/14482#discussion_r1348400936
##
core/src/test/scala/unit/kafka/log/remote/RemoteIndexCacheTest.scala:
##
@@ -524,23 +527,239 @@ class RemoteIndexCacheTest {
}
}
- @Test
- def
iit2009060 commented on code in PR #14482:
URL: https://github.com/apache/kafka/pull/14482#discussion_r1348400586
##
core/src/test/scala/unit/kafka/log/remote/RemoteIndexCacheTest.scala:
##
@@ -524,23 +527,239 @@ class RemoteIndexCacheTest {
}
}
- @Test
- def
1 - 100 of 112 matches
Mail list logo
