iit2009060 commented on code in PR #14482:
URL: https://github.com/apache/kafka/pull/14482#discussion_r1351514017
##
core/src/test/scala/unit/kafka/log/remote/RemoteIndexCacheTest.scala:
##
@@ -540,6 +545,8 @@ class RemoteIndexCacheTest {
"Failed to mark cache entry for
showuon commented on code in PR #14482:
URL: https://github.com/apache/kafka/pull/14482#discussion_r1351504132
##
core/src/test/scala/unit/kafka/log/remote/RemoteIndexCacheTest.scala:
##
@@ -540,6 +545,8 @@ class RemoteIndexCacheTest {
"Failed to mark cache entry for
[
https://issues.apache.org/jira/browse/KAFKA-15514?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Igor Soarez reassigned KAFKA-15514:
---
Assignee: Igor Soarez
> Controller-side replica management changes
>
philipnee closed pull request #14509: [TEST] Run builds for PR #14364
URL: https://github.com/apache/kafka/pull/14509
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
iit2009060 commented on PR #14482:
URL: https://github.com/apache/kafka/pull/14482#issuecomment-1754314250
@showuon Can we merge this changes ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
soarez opened a new pull request, #14517:
URL: https://github.com/apache/kafka/pull/14517
After a late discussion in the voting thread for KIP-858 we decided to
improve the names for the designated reserved log directory UUID values.
### Committer Checklist (excluded from commit
github-actions[bot] commented on PR #13528:
URL: https://github.com/apache/kafka/pull/13528#issuecomment-1754300677
This PR is being marked as stale since it has not had any activity in 90
days. If you would like to keep this PR alive, please ask a committer for
review. If the PR has
github-actions[bot] commented on PR #13876:
URL: https://github.com/apache/kafka/pull/13876#issuecomment-1754300502
This PR is being marked as stale since it has not had any activity in 90
days. If you would like to keep this PR alive, please ask a committer for
review. If the PR has
soarez opened a new pull request, #14516:
URL: https://github.com/apache/kafka/pull/14516
The new "Assignments" field replaces the "Replicas" field in PartitionRecord
and PartitionChangeRecord.
Depends on #14290 -
[KAFKA-15355](https://issues.apache.org/jira/browse/KAFKA-15355)
kirktrue commented on code in PR #14406:
URL: https://github.com/apache/kafka/pull/14406#discussion_r1351064502
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerTestBuilder.java:
##
@@ -0,0 +1,267 @@
+/*
+ * Licensed to the Apache Software Foundation
kirktrue commented on code in PR #14406:
URL: https://github.com/apache/kafka/pull/14406#discussion_r1351063405
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThreadTest.java:
##
@@ -0,0 +1,288 @@
+/*
+ * Licensed to the Apache Software
kirktrue commented on code in PR #14406:
URL: https://github.com/apache/kafka/pull/14406#discussion_r1351054656
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThreadTest.java:
##
@@ -0,0 +1,288 @@
+/*
+ * Licensed to the Apache Software
kirktrue commented on code in PR #14406:
URL: https://github.com/apache/kafka/pull/14406#discussion_r1351042141
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThreadTest.java:
##
@@ -0,0 +1,288 @@
+/*
+ * Licensed to the Apache Software
kirktrue commented on code in PR #14406:
URL: https://github.com/apache/kafka/pull/14406#discussion_r1351011656
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/FetchRequestManager.java:
##
@@ -0,0 +1,181 @@
+/*
+ * Licensed to the Apache Software Foundation
hachikuji commented on code in PR #14053:
URL: https://github.com/apache/kafka/pull/14053#discussion_r1351005643
##
core/src/main/scala/kafka/cluster/Replica.scala:
##
@@ -98,14 +105,22 @@ class Replica(val brokerId: Int, val topicPartition:
TopicPartition) extends Log
*
rbaddam commented on code in PR #14491:
URL: https://github.com/apache/kafka/pull/14491#discussion_r1350996498
##
clients/src/main/java/org/apache/kafka/common/network/ChannelBuilders.java:
##
@@ -240,12 +242,19 @@ public static KafkaPrincipalBuilder
createPrincipalBuilder(Map
jolshan commented on code in PR #14417:
URL: https://github.com/apache/kafka/pull/14417#discussion_r1350953160
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/runtime/CoordinatorRuntimeTest.java:
##
@@ -1340,4 +1377,119 @@ public void
jolshan commented on code in PR #1:
URL: https://github.com/apache/kafka/pull/1#discussion_r1350945079
##
server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java:
##
@@ -338,7 +338,7 @@ public boolean isControllerRegistrationSupported() {
jolshan commented on code in PR #1:
URL: https://github.com/apache/kafka/pull/1#discussion_r1350936703
##
core/src/main/scala/kafka/server/KafkaApis.scala:
##
@@ -559,6 +560,30 @@ class KafkaApis(val requestChannel: RequestChannel,
}
}
+ case class
jolshan commented on code in PR #1:
URL: https://github.com/apache/kafka/pull/1#discussion_r1350934417
##
core/src/main/scala/kafka/server/KafkaApis.scala:
##
@@ -559,6 +560,30 @@ class KafkaApis(val requestChannel: RequestChannel,
}
}
+ case class
jolshan commented on code in PR #1:
URL: https://github.com/apache/kafka/pull/1#discussion_r1350934417
##
core/src/main/scala/kafka/server/KafkaApis.scala:
##
@@ -559,6 +560,30 @@ class KafkaApis(val requestChannel: RequestChannel,
}
}
+ case class
jolshan commented on code in PR #1:
URL: https://github.com/apache/kafka/pull/1#discussion_r1350933806
##
core/src/main/scala/kafka/server/KafkaApis.scala:
##
@@ -559,6 +560,30 @@ class KafkaApis(val requestChannel: RequestChannel,
}
}
+ case class
jolshan commented on code in PR #1:
URL: https://github.com/apache/kafka/pull/1#discussion_r1350932166
##
clients/src/main/java/org/apache/kafka/common/requests/ProduceResponse.java:
##
@@ -67,20 +69,31 @@ public ProduceResponse(ProduceResponseData
produceResponseData)
rbaddam commented on code in PR #14491:
URL: https://github.com/apache/kafka/pull/14491#discussion_r1350920227
##
clients/src/main/java/org/apache/kafka/common/network/ChannelBuilders.java:
##
@@ -240,12 +242,19 @@ public static KafkaPrincipalBuilder
createPrincipalBuilder(Map
imcdo closed pull request #11392: freeze requirements for system-tests running
with python2
URL: https://github.com/apache/kafka/pull/11392
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
jolshan commented on code in PR #14489:
URL: https://github.com/apache/kafka/pull/14489#discussion_r1350911184
##
metadata/src/main/java/org/apache/kafka/image/LocalReplicaChanges.java:
##
@@ -26,19 +26,22 @@
public final class LocalReplicaChanges {
private final Set
jeffkbkim commented on code in PR #14417:
URL: https://github.com/apache/kafka/pull/14417#discussion_r1350909602
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/runtime/CoordinatorRuntimeTest.java:
##
@@ -1340,4 +1377,119 @@ public void
jeffkbkim commented on code in PR #14417:
URL: https://github.com/apache/kafka/pull/14417#discussion_r1350893216
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/metrics/CoordinatorRuntimeMetrics.java:
##
@@ -0,0 +1,100 @@
+/*
+ * Licensed to the Apache
jeffkbkim commented on code in PR #14417:
URL: https://github.com/apache/kafka/pull/14417#discussion_r1350893216
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/metrics/CoordinatorRuntimeMetrics.java:
##
@@ -0,0 +1,100 @@
+/*
+ * Licensed to the Apache
jeffkbkim commented on code in PR #14417:
URL: https://github.com/apache/kafka/pull/14417#discussion_r1350888321
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/metrics/CoordinatorRuntimeMetrics.java:
##
@@ -0,0 +1,68 @@
+/*
+ * Licensed to the Apache
jolshan commented on code in PR #14489:
URL: https://github.com/apache/kafka/pull/14489#discussion_r1350877639
##
core/src/main/scala/kafka/coordinator/transaction/TransactionStateManager.scala:
##
@@ -515,7 +521,10 @@ class TransactionStateManager(brokerId: Int,
* metadata
jeffkbkim commented on code in PR #14467:
URL: https://github.com/apache/kafka/pull/14467#discussion_r1350863763
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetMetadataManager.java:
##
@@ -544,6 +573,81 @@ public
ahuang98 commented on code in PR #14428:
URL: https://github.com/apache/kafka/pull/14428#discussion_r1350814062
##
raft/src/main/java/org/apache/kafka/raft/LeaderState.java:
##
@@ -79,6 +86,38 @@ protected LeaderState(
this.grantingVoters =
CalvinConfluent commented on code in PR #14053:
URL: https://github.com/apache/kafka/pull/14053#discussion_r1350811556
##
core/src/main/scala/kafka/cluster/Replica.scala:
##
@@ -98,14 +105,22 @@ class Replica(val brokerId: Int, val topicPartition:
TopicPartition) extends Log
CalvinConfluent commented on code in PR #14053:
URL: https://github.com/apache/kafka/pull/14053#discussion_r1350811307
##
core/src/main/scala/kafka/cluster/Replica.scala:
##
@@ -98,14 +105,22 @@ class Replica(val brokerId: Int, val topicPartition:
TopicPartition) extends Log
jeffkbkim commented on code in PR #14467:
URL: https://github.com/apache/kafka/pull/14467#discussion_r1350811243
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetExpirationCondition.java:
##
@@ -0,0 +1,36 @@
+/*
+ * Licensed to the Apache Software
jolshan commented on PR #14417:
URL: https://github.com/apache/kafka/pull/14417#issuecomment-1753860433
Let's also checkstyle in the build. Something seems to be off in the group
coordinator module.
--
This is an automated message from the Apache Git Service.
To respond to the message,
junrao commented on code in PR #14406:
URL: https://github.com/apache/kafka/pull/14406#discussion_r1350697908
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/PrototypeAsyncConsumer.java:
##
@@ -621,56 +825,163 @@ public void assign(Collection
partitions) {
nizhikov commented on code in PR #13247:
URL: https://github.com/apache/kafka/pull/13247#discussion_r1350743924
##
tools/src/test/java/org/apache/kafka/tools/reassign/ReassignPartitionsUnitTest.java:
##
@@ -769,22 +762,12 @@ public void testPropagateInvalidJsonError() {
}
jolshan commented on code in PR #13247:
URL: https://github.com/apache/kafka/pull/13247#discussion_r1350759368
##
tools/src/test/java/org/apache/kafka/tools/reassign/ReassignPartitionsIntegrationTest.java:
##
@@ -857,68 +864,18 @@ public void close() {
}
}
-
[
https://issues.apache.org/jira/browse/KAFKA-15569?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-15569:
Issue Type: Test (was: Improvement)
> Update test and add test cases in
[
https://issues.apache.org/jira/browse/KAFKA-15569?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-15569:
Component/s: streams
unit tests
> Update test and add test cases in
nizhikov commented on code in PR #13247:
URL: https://github.com/apache/kafka/pull/13247#discussion_r1350744820
##
tools/src/test/java/org/apache/kafka/tools/reassign/ReassignPartitionsIntegrationTest.java:
##
@@ -857,68 +864,18 @@ public void close() {
}
}
-
nizhikov commented on code in PR #13247:
URL: https://github.com/apache/kafka/pull/13247#discussion_r1350743924
##
tools/src/test/java/org/apache/kafka/tools/reassign/ReassignPartitionsUnitTest.java:
##
@@ -769,22 +762,12 @@ public void testPropagateInvalidJsonError() {
}
hachikuji commented on code in PR #14053:
URL: https://github.com/apache/kafka/pull/14053#discussion_r1350736079
##
core/src/main/scala/kafka/cluster/Replica.scala:
##
@@ -98,14 +105,22 @@ class Replica(val brokerId: Int, val topicPartition:
TopicPartition) extends Log
*
[
https://issues.apache.org/jira/browse/KAFKA-15569?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Hanyu Zheng reassigned KAFKA-15569:
---
Assignee: Hanyu Zheng
> Update test and add test cases in IQv2StoreIntegrationTest
>
[
https://issues.apache.org/jira/browse/KAFKA-15565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17773463#comment-17773463
]
Sankalp Bhatia edited comment on KAFKA-15565 at 10/9/23 7:34 PM:
-
Hanyu Zheng created KAFKA-15569:
---
Summary: Update test and add test cases in IQv2StoreIntegrationTest
Key: KAFKA-15569
URL: https://issues.apache.org/jira/browse/KAFKA-15569
Project: Kafka
[
https://issues.apache.org/jira/browse/KAFKA-15565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17773463#comment-17773463
]
Sankalp Bhatia edited comment on KAFKA-15565 at 10/9/23 7:25 PM:
-
[
https://issues.apache.org/jira/browse/KAFKA-15565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17773463#comment-17773463
]
Sankalp Bhatia commented on KAFKA-15565:
Thanks. The reason I say it is a bug is because the
wcarlson5 commented on code in PR #14174:
URL: https://github.com/apache/kafka/pull/14174#discussion_r1347987570
##
streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamJoinWindow.java:
##
@@ -51,8 +51,8 @@ public void init(final ProcessorContext context) {
mjsax commented on code in PR #14508:
URL: https://github.com/apache/kafka/pull/14508#discussion_r1350625946
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java:
##
@@ -223,10 +223,7 @@ boolean handleCorruption(final Set corruptedTasks)
{
jolshan commented on code in PR #13247:
URL: https://github.com/apache/kafka/pull/13247#discussion_r1350623608
##
tools/src/test/java/org/apache/kafka/tools/reassign/ReassignPartitionsUnitTest.java:
##
@@ -769,22 +762,12 @@ public void testPropagateInvalidJsonError() {
}
jolshan commented on code in PR #13247:
URL: https://github.com/apache/kafka/pull/13247#discussion_r1350622281
##
tools/src/test/java/org/apache/kafka/tools/reassign/ReassignPartitionsIntegrationTest.java:
##
@@ -857,68 +864,18 @@ public void close() {
}
}
-
jolshan commented on code in PR #14417:
URL: https://github.com/apache/kafka/pull/14417#discussion_r1350610255
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/runtime/CoordinatorRuntimeTest.java:
##
@@ -1340,4 +1377,119 @@ public void
jolshan commented on code in PR #14417:
URL: https://github.com/apache/kafka/pull/14417#discussion_r1350608637
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/metrics/CoordinatorRuntimeMetrics.java:
##
@@ -0,0 +1,68 @@
+/*
+ * Licensed to the Apache
jolshan commented on code in PR #14417:
URL: https://github.com/apache/kafka/pull/14417#discussion_r1350606817
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/metrics/CoordinatorRuntimeMetrics.java:
##
@@ -0,0 +1,100 @@
+/*
+ * Licensed to the Apache
[
https://issues.apache.org/jira/browse/KAFKA-15278?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Philip Nee resolved KAFKA-15278.
Resolution: Fixed
> Implement client support for KIP-848 ConsumerGroupHeartbeat protocol RPC
>
[
https://issues.apache.org/jira/browse/KAFKA-15278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17773429#comment-17773429
]
Philip Nee commented on KAFKA-15278:
The basic heartbeat is implemented. We are missing the
[
https://issues.apache.org/jira/browse/KAFKA-15278?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Philip Nee updated KAFKA-15278:
---
Description:
The necessary Java code that represents the {{ConsumerGroupHeartbeatRequest}}
and
[
https://issues.apache.org/jira/browse/KAFKA-15278?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Philip Nee reassigned KAFKA-15278:
--
Assignee: Philip Nee
> Implement client support for KIP-848 ConsumerGroupHeartbeat protocol
[
https://issues.apache.org/jira/browse/KAFKA-15278?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Philip Nee updated KAFKA-15278:
---
Description:
The necessary Java code that represents the {{ConsumerGroupHeartbeatRequest}}
and
[
https://issues.apache.org/jira/browse/KAFKA-15278?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Philip Nee updated KAFKA-15278:
---
Description:
The protocol introduces three new RPCs that the client uses to communicate with
the
rbaddam commented on code in PR #14491:
URL: https://github.com/apache/kafka/pull/14491#discussion_r1350588084
##
clients/src/main/java/org/apache/kafka/common/network/ChannelBuilders.java:
##
@@ -240,12 +242,19 @@ public static KafkaPrincipalBuilder
createPrincipalBuilder(Map
[
https://issues.apache.org/jira/browse/KAFKA-15546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17773425#comment-17773425
]
Justine Olshan commented on KAFKA-15546:
Hey Giovanni. The API does not currently support
jolshan commented on code in PR #14489:
URL: https://github.com/apache/kafka/pull/14489#discussion_r1350579091
##
core/src/main/scala/kafka/coordinator/transaction/TransactionStateManager.scala:
##
@@ -515,7 +521,10 @@ class TransactionStateManager(brokerId: Int,
* metadata
mimaison commented on PR #13201:
URL: https://github.com/apache/kafka/pull/13201#issuecomment-1753360551
@OmniaGM Thanks for the update. I've not had time to take a look yet but
noticed there's a compilation failure:
```
> Task :tools:compileTestJava
clolov commented on code in PR #14489:
URL: https://github.com/apache/kafka/pull/14489#discussion_r1350537983
##
core/src/main/scala/kafka/coordinator/transaction/TransactionStateManager.scala:
##
@@ -515,7 +521,10 @@ class TransactionStateManager(brokerId: Int,
* metadata
ijuma commented on code in PR #14473:
URL: https://github.com/apache/kafka/pull/14473#discussion_r1350536831
##
gradle.properties:
##
@@ -25,6 +25,9 @@ group=org.apache.kafka
# - streams/quickstart/java/pom.xml
version=3.7.0-SNAPSHOT
scalaVersion=2.13.12
+# Adding
ijuma commented on code in PR #14473:
URL: https://github.com/apache/kafka/pull/14473#discussion_r1350536831
##
gradle.properties:
##
@@ -25,6 +25,9 @@ group=org.apache.kafka
# - streams/quickstart/java/pom.xml
version=3.7.0-SNAPSHOT
scalaVersion=2.13.12
+# Adding
jolshan commented on code in PR #1:
URL: https://github.com/apache/kafka/pull/1#discussion_r1350511364
##
clients/src/main/resources/common/message/ProduceResponse.json:
##
@@ -32,7 +32,9 @@
// records that cause the whole batch to be dropped. See KIP-467 for
[
https://issues.apache.org/jira/browse/KAFKA-15325?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Philip Nee updated KAFKA-15325:
---
Labels: kip-848 kip-848-client-support (was: kip-848
kip-848-client-support kip-848-preview)
>
jolshan commented on code in PR #14489:
URL: https://github.com/apache/kafka/pull/14489#discussion_r1350505733
##
metadata/src/main/java/org/apache/kafka/image/LocalReplicaChanges.java:
##
@@ -26,19 +26,22 @@
public final class LocalReplicaChanges {
private final Set
jolshan commented on code in PR #14489:
URL: https://github.com/apache/kafka/pull/14489#discussion_r1350503797
##
core/src/main/scala/kafka/coordinator/transaction/TransactionStateManager.scala:
##
@@ -515,7 +521,10 @@ class TransactionStateManager(brokerId: Int,
* metadata
mimaison commented on code in PR #14515:
URL: https://github.com/apache/kafka/pull/14515#discussion_r1350502430
##
clients/src/main/java/org/apache/kafka/common/config/ConfigDef.java:
##
@@ -802,11 +802,63 @@ else if (value instanceof Class)
}
/**
- * The config
mimaison commented on code in PR #14515:
URL: https://github.com/apache/kafka/pull/14515#discussion_r1350501171
##
clients/src/main/java/org/apache/kafka/common/config/ConfigDef.java:
##
@@ -57,7 +57,7 @@
* defs.define(config_with_default, Type.STRING, default
string value,
mimaison opened a new pull request, #14515:
URL: https://github.com/apache/kafka/pull/14515
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including
[
https://issues.apache.org/jira/browse/KAFKA-15568?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aman Singh updated KAFKA-15568:
---
Description:
As part of
electrical commented on PR #13905:
URL: https://github.com/apache/kafka/pull/13905#issuecomment-1753259175
@C0urante the other PR is **https://github.com/apache/kafka/pull/12358**
So far it seems it was reviewed and approved but no movement from that point
on.
--
This is an automated
dajac merged PR #14364:
URL: https://github.com/apache/kafka/pull/14364
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
dajac commented on PR #14364:
URL: https://github.com/apache/kafka/pull/14364#issuecomment-1753238153
If we combine the last two builds, I am confident that the changes are good
so I will merge it to trunk.
--
This is an automated message from the Apache Git Service.
To respond to the
Aman Singh created KAFKA-15568:
--
Summary: Use incrementalAlterConfigs to update the dynamic config
of broker in ConfigCommand tool
Key: KAFKA-15568
URL: https://issues.apache.org/jira/browse/KAFKA-15568
[
https://issues.apache.org/jira/browse/KAFKA-14927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17773365#comment-17773365
]
Aman Singh commented on KAFKA-14927:
Raised the PR to add validation
singhnama opened a new pull request, #14514:
URL: https://github.com/apache/kafka/pull/14514
Added validation in ConfigCommand tool, only allow characters
'([a-z][A-Z][0-9][._-])*' for config keys.
Jira: https://issues.apache.org/jira/browse/KAFKA-14927 (Contains more
details about why
ocadaruma opened a new pull request, #14513:
URL: https://github.com/apache/kafka/pull/14513
## Summary
- Currently, ReplicaFetcherThreadBenchmark doesn't run due to 2 reasons:
* NPE that is introduced by
C0urante commented on PR #13905:
URL: https://github.com/apache/kafka/pull/13905#issuecomment-1753124395
@electrical can you link to the second PR? I've reviewed this one and am
waiting on the author. If a second author is more responsive, we may be able to
fix this issue sooner.
--
electrical commented on PR #13905:
URL: https://github.com/apache/kafka/pull/13905#issuecomment-1753118374
Hi,
Seems there are now 2 PR's open to solve the same issue but both are not
moving forward at all and is blocking a lot of people of moving forward to
migrate to MM2.
I
[
https://issues.apache.org/jira/browse/KAFKA-15514?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Igor Soarez updated KAFKA-15514:
Description:
The new "Assignments" field replaces the "Replicas" field in PartitionRecord
and
[
https://issues.apache.org/jira/browse/KAFKA-15514?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Igor Soarez updated KAFKA-15514:
Summary: Replica management changes (was: Controller-side replica
management changes)
> Replica
[
https://issues.apache.org/jira/browse/KAFKA-15514?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Igor Soarez updated KAFKA-15514:
Summary: Controller-side replica management changes (was: Replica
management changes)
>
Haruki Okada created KAFKA-15567:
Summary: ReplicaFetcherThreadBenchmark is not working
Key: KAFKA-15567
URL: https://issues.apache.org/jira/browse/KAFKA-15567
Project: Kafka
Issue Type:
clolov commented on code in PR #14489:
URL: https://github.com/apache/kafka/pull/14489#discussion_r1350305894
##
core/src/main/scala/kafka/coordinator/transaction/TransactionStateManager.scala:
##
@@ -392,6 +392,12 @@ class TransactionStateManager(brokerId: Int,
}
}
+
tinaselenge commented on PR #14455:
URL: https://github.com/apache/kafka/pull/14455#issuecomment-1753035679
Thanks everyone for reviewing the PR.
@showuon, I have updated the failing tests. 2 other tests failed in the last
build, but they seem unrelated and passed when running locally.
dajac commented on code in PR #14467:
URL: https://github.com/apache/kafka/pull/14467#discussion_r1350279208
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetExpirationCondition.java:
##
@@ -0,0 +1,36 @@
+/*
+ * Licensed to the Apache Software
cadonna commented on code in PR #14508:
URL: https://github.com/apache/kafka/pull/14508#discussion_r1350271668
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java:
##
@@ -223,10 +223,7 @@ boolean handleCorruption(final Set corruptedTasks)
{
dajac commented on code in PR #14467:
URL: https://github.com/apache/kafka/pull/14467#discussion_r1350261943
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetMetadataManager.java:
##
@@ -544,6 +573,81 @@ public
dajac commented on code in PR #14467:
URL: https://github.com/apache/kafka/pull/14467#discussion_r1350261109
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetMetadataManager.java:
##
@@ -544,6 +573,81 @@ public
plazma-prizma commented on code in PR #14491:
URL: https://github.com/apache/kafka/pull/14491#discussion_r1350253419
##
clients/src/main/java/org/apache/kafka/common/network/ChannelBuilders.java:
##
@@ -240,12 +242,19 @@ public static KafkaPrincipalBuilder
dengziming opened a new pull request, #14512:
URL: https://github.com/apache/kafka/pull/14512
*More detailed description of your change*
*Summary of testing strategy (including rationale)*
### Committer Checklist (excluded from commit message)
- [ ] Verify design and
iit2009060 commented on PR #14482:
URL: https://github.com/apache/kafka/pull/14482#issuecomment-1752910354
Unrelated test failures
https://ci-builds.apache.org/blue/organizations/jenkins/Kafka%2Fkafka-pr/detail/PR-14482/14/tests
@showuon @divijvaidya can we merge this changes ?
1 - 100 of 123 matches
Mail list logo
