[jira] [Updated] (KAFKA-15576) Add 3.6.0 to broker/client and streams upgrade/compatibility tests

2023-10-10 Thread Satish Duggana (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Satish Duggana updated KAFKA-15576: --- Summary: Add 3.6.0 to broker/client and streams upgrade/compatibility tests (was: Add

[jira] [Created] (KAFKA-15576) Add 3.2.0 to broker/client and streams upgrade/compatibility tests

2023-10-10 Thread Satish Duggana (Jira)
Satish Duggana created KAFKA-15576: -- Summary: Add 3.2.0 to broker/client and streams upgrade/compatibility tests Key: KAFKA-15576 URL: https://issues.apache.org/jira/browse/KAFKA-15576 Project:

[jira] [Commented] (KAFKA-15535) Add documentation of "remote.log.index.file.cache.total.size.bytes" configuration property.

2023-10-10 Thread Satish Duggana (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17773898#comment-17773898 ] Satish Duggana commented on KAFKA-15535: Thanks [~hudeqi] for checking that out. > Add

[jira] [Resolved] (KAFKA-15535) Add documentation of "remote.log.index.file.cache.total.size.bytes" configuration property.

2023-10-10 Thread Satish Duggana (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15535?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Satish Duggana resolved KAFKA-15535. Resolution: Fixed > Add documentation of "remote.log.index.file.cache.total.size.bytes"

Re: [PR] KAFKA-15570: Add unit tests for MemoryConfigBackingStore [kafka]

2023-10-10 Thread via GitHub
yashmayya commented on code in PR #14518: URL: https://github.com/apache/kafka/pull/14518#discussion_r1354103192 ## connect/runtime/src/test/java/org/apache/kafka/connect/storage/MemoryConfigBackingStoreTest.java: ## @@ -0,0 +1,183 @@ +/* + * Licensed to the Apache Software

[PR] MINOR: Disable flaky kraft-test in FetchRequestTest [kafka]

2023-10-10 Thread via GitHub
dengziming opened a new pull request, #14525: URL: https://github.com/apache/kafka/pull/14525 *More detailed description of your change* We introduced a bunch of flaky tests in #14295 , which are normal when running locally but will always fail in CI, lets rollback them before we find

[jira] [Resolved] (KAFKA-15507) adminClient should not throw retriable exception when closing instance

2023-10-10 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15507?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen resolved KAFKA-15507. --- Fix Version/s: 3.7.0 Resolution: Fixed > adminClient should not throw retriable exception

Re: [PR] KAFKA-15507: Make AdminClient throw non-retriable exception for a new call while closing [kafka]

2023-10-10 Thread via GitHub
showuon merged PR #14455: URL: https://github.com/apache/kafka/pull/14455 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] KAFKA-15507: Make AdminClient throw non-retriable exception for a new call while closing [kafka]

2023-10-10 Thread via GitHub
showuon commented on PR #14455: URL: https://github.com/apache/kafka/pull/14455#issuecomment-1756715114 Failed tests are unrelated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] MINOR: Remove StreamsProducer flush under EOS [kafka]

2023-10-10 Thread via GitHub
github-actions[bot] commented on PR #13994: URL: https://github.com/apache/kafka/pull/13994#issuecomment-1756711475 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has

Re: [PR] KAFKA-13756: Connect validate endpoint should return proper validatio… [kafka]

2023-10-10 Thread via GitHub
github-actions[bot] commented on PR #13813: URL: https://github.com/apache/kafka/pull/13813#issuecomment-1756711573 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has

Re: [PR] KAFKA-15169: Added TestCase in RemoteIndexCache [kafka]

2023-10-10 Thread via GitHub
showuon merged PR #14482: URL: https://github.com/apache/kafka/pull/14482 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] KAFKA-15169: Added TestCase in RemoteIndexCache [kafka]

2023-10-10 Thread via GitHub
showuon commented on PR #14482: URL: https://github.com/apache/kafka/pull/14482#issuecomment-1756672787 Failed tests are unrelated and also failed in trunk build. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] KAFKA-15570: Add unit tests for MemoryConfigBackingStore [kafka]

2023-10-10 Thread via GitHub
kpatelatwork commented on code in PR #14518: URL: https://github.com/apache/kafka/pull/14518#discussion_r1353833312 ## connect/runtime/src/test/java/org/apache/kafka/connect/storage/MemoryConfigBackingStoreTest.java: ## @@ -0,0 +1,183 @@ +/* + * Licensed to the Apache Software

Re: [PR] KAFKA-14987; Implement Group/Offset expiration in the new coordinator [kafka]

2023-10-10 Thread via GitHub
rreddy-22 commented on code in PR #14467: URL: https://github.com/apache/kafka/pull/14467#discussion_r1353833261 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/generic/GenericGroup.java: ## @@ -898,6 +900,47 @@ public void createGroupTombstoneRecords(List

Re: [PR] KAFKA-14987; Implement Group/Offset expiration in the new coordinator [kafka]

2023-10-10 Thread via GitHub
rreddy-22 commented on code in PR #14467: URL: https://github.com/apache/kafka/pull/14467#discussion_r1353832984 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/generic/GenericGroup.java: ## @@ -898,6 +900,47 @@ public void createGroupTombstoneRecords(List

Re: [PR] KAFKA-14987; Implement Group/Offset expiration in the new coordinator [kafka]

2023-10-10 Thread via GitHub
rreddy-22 commented on code in PR #14467: URL: https://github.com/apache/kafka/pull/14467#discussion_r1353832660 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/generic/GenericGroup.java: ## @@ -898,6 +900,47 @@ public void createGroupTombstoneRecords(List

Re: [PR] KAFKA-14987; Implement Group/Offset expiration in the new coordinator [kafka]

2023-10-10 Thread via GitHub
rreddy-22 commented on code in PR #14467: URL: https://github.com/apache/kafka/pull/14467#discussion_r1353832416 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/generic/GenericGroup.java: ## @@ -898,6 +900,47 @@ public void createGroupTombstoneRecords(List

Re: [PR] KAFKA-14987; Implement Group/Offset expiration in the new coordinator [kafka]

2023-10-10 Thread via GitHub
rreddy-22 commented on code in PR #14467: URL: https://github.com/apache/kafka/pull/14467#discussion_r1353831509 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/generic/GenericGroup.java: ## @@ -898,6 +900,47 @@ public void createGroupTombstoneRecords(List

Re: [PR] KAFKA-14987; Implement Group/Offset expiration in the new coordinator [kafka]

2023-10-10 Thread via GitHub
rreddy-22 commented on code in PR #14467: URL: https://github.com/apache/kafka/pull/14467#discussion_r1353831027 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetMetadataManager.java: ## @@ -544,6 +550,77 @@ public

Re: [PR] KAFKA-14987; Implement Group/Offset expiration in the new coordinator [kafka]

2023-10-10 Thread via GitHub
rreddy-22 commented on code in PR #14467: URL: https://github.com/apache/kafka/pull/14467#discussion_r1353831281 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroup.java: ## @@ -635,6 +639,21 @@ public void

Re: [PR] KAFKA-14987; Implement Group/Offset expiration in the new coordinator [kafka]

2023-10-10 Thread via GitHub
rreddy-22 commented on code in PR #14467: URL: https://github.com/apache/kafka/pull/14467#discussion_r1353830271 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetMetadataManager.java: ## @@ -544,6 +550,77 @@ public

Re: [PR] KAFKA-14987; Implement Group/Offset expiration in the new coordinator [kafka]

2023-10-10 Thread via GitHub
rreddy-22 commented on code in PR #14467: URL: https://github.com/apache/kafka/pull/14467#discussion_r1353823509 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetMetadataManager.java: ## @@ -544,6 +550,77 @@ public

[PR] System Tests for KIP-848 [kafka]

2023-10-10 Thread via GitHub
rreddy-22 opened a new pull request, #14524: URL: https://github.com/apache/kafka/pull/14524 Added configs and custom decorators to facilitate the testing of the old protocol with the new group coordinator (KIP-848) in kraft mode. The new coordinator doesn't support zookeeper mode and

Re: [PR] KAFKA-14987; Implement Group/Offset expiration in the new coordinator [kafka]

2023-10-10 Thread via GitHub
jeffkbkim commented on code in PR #14467: URL: https://github.com/apache/kafka/pull/14467#discussion_r1353679164 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetMetadataManager.java: ## @@ -544,6 +550,77 @@ public

Re: [PR] KAFKA-14519; [1/N] Implement coordinator runtime metrics [kafka]

2023-10-10 Thread via GitHub
jeffkbkim commented on PR #14417: URL: https://github.com/apache/kafka/pull/14417#issuecomment-1756480353 @jolshan this is flaky in trunk as well -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] KAFKA-14519; [1/N] Implement coordinator runtime metrics [kafka]

2023-10-10 Thread via GitHub
jolshan commented on PR #14417: URL: https://github.com/apache/kafka/pull/14417#issuecomment-1756470166 I restarted the build. But can we take a look at

[jira] [Commented] (KAFKA-15571) StateRestoreListener#onRestoreSuspended is never called because wrapper DelegatingStateRestoreListener doesn't implement onRestoreSuspended

2023-10-10 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17773849#comment-17773849 ] Matthias J. Sax commented on KAFKA-15571: - Ups... Thanks to reporting and the PR! >

Re: [PR] KAFKA-15221; Fix the race between fetch requests from a rebooted follower. [kafka]

2023-10-10 Thread via GitHub
CalvinConfluent commented on PR #14053: URL: https://github.com/apache/kafka/pull/14053#issuecomment-1756411287 Thanks @hachikuji , verified the failed UT can pass locally. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] KAFKA-15276: Implement partition assignment reconciliation [kafka]

2023-10-10 Thread via GitHub
kirktrue commented on PR #14357: URL: https://github.com/apache/kafka/pull/14357#issuecomment-1756404090 @lianetm @philipnee @dajac we can start reviewing this PR now. I'll keep working on the unit tests in the background. I resolved a bunch of comments that pertained to a former

Re: [PR] KAFKA-15276: Implement partition assignment reconciliation [kafka]

2023-10-10 Thread via GitHub
kirktrue commented on code in PR #14357: URL: https://github.com/apache/kafka/pull/14357#discussion_r1353544098 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AssignmentReconciler.java: ## @@ -85,122 +111,162 @@ enum ReconciliationResult { private

Re: [PR] KAFKA-15276: Implement partition assignment reconciliation [kafka]

2023-10-10 Thread via GitHub
kirktrue commented on code in PR #14357: URL: https://github.com/apache/kafka/pull/14357#discussion_r1353534627 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AssignmentReconciler.java: ## @@ -0,0 +1,355 @@ +/* + * Licensed to the Apache Software

Re: [PR] KAFKA-15276: Implement partition assignment reconciliation [kafka]

2023-10-10 Thread via GitHub
kirktrue commented on code in PR #14357: URL: https://github.com/apache/kafka/pull/14357#discussion_r1353533180 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AssignmentReconciler.java: ## @@ -44,21 +45,46 @@ import java.util.stream.Collectors; /** - *

[PR] Update test and add test cases in IQv2StoreIntegrationTest [kafka]

2023-10-10 Thread via GitHub
hanyuzheng7 opened a new pull request, #14523: URL: https://github.com/apache/kafka/pull/14523 Update test and add test cases in IQv2StoreIntegrationTest Change the input key-value pair timestamp and add more test cases. ### Committer Checklist (excluded from commit message)

[jira] [Created] (KAFKA-15575) Prevent Connectors from exceeding tasks.max configuration

2023-10-10 Thread Greg Harris (Jira)
Greg Harris created KAFKA-15575: --- Summary: Prevent Connectors from exceeding tasks.max configuration Key: KAFKA-15575 URL: https://issues.apache.org/jira/browse/KAFKA-15575 Project: Kafka

Re: [PR] KAFKA-15452: Access SslPrincipalMapper and kerberosShortNamer in Custom KafkaPrincipalBuilder(KIP-982) [kafka]

2023-10-10 Thread via GitHub
plazma-prizma commented on code in PR #14491: URL: https://github.com/apache/kafka/pull/14491#discussion_r1353388791 ## clients/src/main/java/org/apache/kafka/common/network/ChannelBuilders.java: ## @@ -240,12 +242,19 @@ public static KafkaPrincipalBuilder

Re: [PR] [MINOR] More image replay test cases [kafka]

2023-10-10 Thread via GitHub
rondagostino commented on PR #14206: URL: https://github.com/apache/kafka/pull/14206#issuecomment-1756151303 @ahuang98 I still saw lots of test failures, and when I checked them locally I actually was able to reproduce the below failures. Can you take a look to see if you also agree these

Re: [PR] KAFKA-15571 / `StateRestoreListener#onRestoreSuspended` is never called because `DelegatingStateRestoreListener` doesn't implement `onRestoreSuspended` [kafka]

2023-10-10 Thread via GitHub
lkokhreidze commented on PR #14519: URL: https://github.com/apache/kafka/pull/14519#issuecomment-1756120126 Hi @cadonna, I've added an integration test. It seemed the safest way to test out the new functionality. -- This is an automated message from the Apache Git Service. To respond

Re: [PR] MINOR: Replace GroupState with MembershipManager [kafka]

2023-10-10 Thread via GitHub
philipnee commented on code in PR #14390: URL: https://github.com/apache/kafka/pull/14390#discussion_r1353232858 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java: ## @@ -180,19 +180,19 @@ CompletableFuture sendAutoCommit(final Map

[jira] [Updated] (KAFKA-15548) Handling close() properly

2023-10-10 Thread Philip Nee (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15548?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Philip Nee updated KAFKA-15548: --- Labels: consumer-threading-refactor kip-848 kip-848-client-support kip-848-e2e kip-848-preview

[jira] [Updated] (KAFKA-15534) Propagate client response time when timeout to the request handler

2023-10-10 Thread Yi Ding (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15534?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yi Ding updated KAFKA-15534: Labels: consumer-threading-refactor kip-848 kip-848-client-support kip-848-e2e kip-848-preview (was:

[jira] [Updated] (KAFKA-15548) Handling close() properly

2023-10-10 Thread Yi Ding (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15548?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yi Ding updated KAFKA-15548: Labels: consumer-threading-refactor kip-848 kip-848-client-support kip-848-preview (was:

[jira] [Updated] (KAFKA-15548) Handling close() properly

2023-10-10 Thread Yi Ding (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15548?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yi Ding updated KAFKA-15548: Labels: consumer-threading-refactor kip- (was: consumer-threading-refactor) > Handling close() properly

Re: [PR] MINOR: Replace GroupState with MembershipManager [kafka]

2023-10-10 Thread via GitHub
dajac commented on code in PR #14390: URL: https://github.com/apache/kafka/pull/14390#discussion_r1353179173 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java: ## @@ -180,19 +180,19 @@ CompletableFuture sendAutoCommit(final Map

Re: [PR] KAFKA-15417 flip joinSpuriousLookBackTimeMs and emit non-joined items [kafka]

2023-10-10 Thread via GitHub
lihaosky commented on code in PR #14426: URL: https://github.com/apache/kafka/pull/14426#discussion_r1353117588 ## streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamKStreamLeftJoinTest.java: ## @@ -436,6 +436,239 @@ public void

Re: [PR] MINOR - KAFKA-15550: Validation for negative target times in offsetsForTimes [kafka]

2023-10-10 Thread via GitHub
lianetm commented on PR #14503: URL: https://github.com/apache/kafka/pull/14503#issuecomment-1756011144 hey @cadonna, @lucasbru. This is a very small PR adding a missing API validation to the new consumer `offsetsForTimes` functionality. It also includes some improved comments for the

Re: [PR] KAFKA-14879: Update system tests to use latest versions [kafka]

2023-10-10 Thread via GitHub
jolshan commented on PR #13528: URL: https://github.com/apache/kafka/pull/13528#issuecomment-1755954984 Sorry I must have missed this ping. :( My bad. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] KAFKA-14879: Update system tests to use latest versions [kafka]

2023-10-10 Thread via GitHub
kirktrue commented on PR #13528: URL: https://github.com/apache/kafka/pull/13528#issuecomment-1755953000 This appears to be taken up by someone else, but they're doing it in a more automated/dynamic manner, which is better anyway. -- This is an automated message from the Apache Git

Re: [PR] Backport kafka 15415 [kafka]

2023-10-10 Thread via GitHub
msn-tldr closed pull request #14521: Backport kafka 15415 URL: https://github.com/apache/kafka/pull/14521 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[PR] KAFKA-15415: On producer-batch retry, skip-backoff on a new leader (#… [kafka]

2023-10-10 Thread via GitHub
msn-tldr opened a new pull request, #14522: URL: https://github.com/apache/kafka/pull/14522 …14384) This PR backports https://github.com/apache/kafka/pull/14384 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit

Re: [PR] KAFKA-14879: Update system tests to use latest versions [kafka]

2023-10-10 Thread via GitHub
kirktrue closed pull request #13528: KAFKA-14879: Update system tests to use latest versions URL: https://github.com/apache/kafka/pull/13528 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[PR] Backport kafka 15415 [kafka]

2023-10-10 Thread via GitHub
msn-tldr opened a new pull request, #14521: URL: https://github.com/apache/kafka/pull/14521 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of

Re: [PR] KAFKA-14987; Implement Group/Offset expiration in the new coordinator [kafka]

2023-10-10 Thread via GitHub
rreddy-22 commented on code in PR #14467: URL: https://github.com/apache/kafka/pull/14467#discussion_r1353056783 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetMetadataManager.java: ## @@ -544,6 +550,77 @@ public

Re: [PR] KAFKA-14987; Implement Group/Offset expiration in the new coordinator [kafka]

2023-10-10 Thread via GitHub
rreddy-22 commented on code in PR #14467: URL: https://github.com/apache/kafka/pull/14467#discussion_r1353055183 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetMetadataManager.java: ## @@ -544,6 +550,77 @@ public

Re: [PR] KAFKA-14987; Implement Group/Offset expiration in the new coordinator [kafka]

2023-10-10 Thread via GitHub
rreddy-22 commented on code in PR #14467: URL: https://github.com/apache/kafka/pull/14467#discussion_r1353053689 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetExpirationConditionImpl.java: ## @@ -0,0 +1,62 @@ +/* + * Licensed to the Apache Software

Re: [PR] KAFKA-14987; Implement Group/Offset expiration in the new coordinator [kafka]

2023-10-10 Thread via GitHub
rreddy-22 commented on code in PR #14467: URL: https://github.com/apache/kafka/pull/14467#discussion_r1353048258 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorShard.java: ## @@ -417,6 +441,39 @@ public CoordinatorResult deleteOffsets(

Re: [PR] KAFKA-14987; Implement Group/Offset expiration in the new coordinator [kafka]

2023-10-10 Thread via GitHub
rreddy-22 commented on code in PR #14467: URL: https://github.com/apache/kafka/pull/14467#discussion_r1353045452 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorConfig.java: ## @@ -91,6 +91,27 @@ public class GroupCoordinatorConfig {

Re: [PR] KAFKA-14987; Implement Group/Offset expiration in the new coordinator [kafka]

2023-10-10 Thread via GitHub
dajac commented on code in PR #14467: URL: https://github.com/apache/kafka/pull/14467#discussion_r1353045293 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/Group.java: ## @@ -117,4 +119,16 @@ void validateOffsetFetch( * @param records The list of

Re: [PR] KAFKA-14987; Implement Group/Offset expiration in the new coordinator [kafka]

2023-10-10 Thread via GitHub
rreddy-22 commented on code in PR #14467: URL: https://github.com/apache/kafka/pull/14467#discussion_r1353045205 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorConfig.java: ## @@ -91,6 +91,27 @@ public class GroupCoordinatorConfig {

Re: [PR] KAFKA-14987; Implement Group/Offset expiration in the new coordinator [kafka]

2023-10-10 Thread via GitHub
rreddy-22 commented on code in PR #14467: URL: https://github.com/apache/kafka/pull/14467#discussion_r1353044716 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorConfig.java: ## @@ -91,6 +91,27 @@ public class GroupCoordinatorConfig {

Re: [PR] KAFKA-14987; Implement Group/Offset expiration in the new coordinator [kafka]

2023-10-10 Thread via GitHub
rreddy-22 commented on code in PR #14467: URL: https://github.com/apache/kafka/pull/14467#discussion_r1353043290 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/Group.java: ## @@ -117,4 +119,16 @@ void validateOffsetFetch( * @param records The list

Re: [PR] KAFKA-15169: Added TestCase in RemoteIndexCache [kafka]

2023-10-10 Thread via GitHub
iit2009060 commented on code in PR #14482: URL: https://github.com/apache/kafka/pull/14482#discussion_r1353033902 ## core/src/test/scala/unit/kafka/log/remote/RemoteIndexCacheTest.scala: ## @@ -540,6 +545,8 @@ class RemoteIndexCacheTest { "Failed to mark cache entry for

Re: [PR] KAFKA-15169: Added TestCase in RemoteIndexCache [kafka]

2023-10-10 Thread via GitHub
iit2009060 commented on code in PR #14482: URL: https://github.com/apache/kafka/pull/14482#discussion_r1353033902 ## core/src/test/scala/unit/kafka/log/remote/RemoteIndexCacheTest.scala: ## @@ -540,6 +545,8 @@ class RemoteIndexCacheTest { "Failed to mark cache entry for

[jira] [Updated] (KAFKA-15574) Integrate partition assignment reconciliation with heartbeat request manager

2023-10-10 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15574?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lianet Magrans updated KAFKA-15574: --- Description: This task is to call the partition assignment reconciler from the heartbeat

[jira] [Updated] (KAFKA-15574) Integrate partition assignment reconciliation with heartbeat request manager

2023-10-10 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15574?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lianet Magrans updated KAFKA-15574: --- Description: This task is to call the partition assignment reconciler from the heartbeat

[jira] [Updated] (KAFKA-15574) Integrate partition assignment reconciliation with heartbeat request manager

2023-10-10 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15574?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lianet Magrans updated KAFKA-15574: --- Description: This task is to call the partition assignment reconciler from the heartbeat

Re: [PR] KAFKA-14519; [1/N] Implement coordinator runtime metrics [kafka]

2023-10-10 Thread via GitHub
jeffkbkim commented on PR #14417: URL: https://github.com/apache/kafka/pull/14417#issuecomment-1755898146 not sure what this error is from ``` > Task :streams:compileJava

Re: [PR] KAFKA-14323: Client state changes for handling one assignment at a time & minor improvements [kafka]

2023-10-10 Thread via GitHub
philipnee commented on code in PR #14413: URL: https://github.com/apache/kafka/pull/14413#discussion_r1353024844 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java: ## @@ -160,92 +228,91 @@ private boolean maybeTransitionToStable() {

Re: [PR] KAFKA-14323: Client state changes for handling one assignment at a time & minor improvements [kafka]

2023-10-10 Thread via GitHub
philipnee commented on code in PR #14413: URL: https://github.com/apache/kafka/pull/14413#discussion_r1353015059 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java: ## @@ -160,92 +228,91 @@ private boolean maybeTransitionToStable() {

Re: [PR] KAFKA-15452: Access SslPrincipalMapper and kerberosShortNamer in Custom KafkaPrincipalBuilder(KIP-982) [kafka]

2023-10-10 Thread via GitHub
rbaddam commented on PR #14504: URL: https://github.com/apache/kafka/pull/14504#issuecomment-1755866839 To address your concern about the specificity of the solution, I will create Interfaces/subclasses of KerberosPrincipalBuilder and SSLPrincipalBuilder to handle different types of

[jira] [Updated] (KAFKA-15574) Integrate partition assignment reconciliation with heartbeat request manager

2023-10-10 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15574?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-15574: -- Description: This task is to call the partition assignment reconciler from the heartbeat request

[jira] [Created] (KAFKA-15574) Integrate partition assignment reconciliation with heartbeat request manager

2023-10-10 Thread Kirk True (Jira)
Kirk True created KAFKA-15574: - Summary: Integrate partition assignment reconciliation with heartbeat request manager Key: KAFKA-15574 URL: https://issues.apache.org/jira/browse/KAFKA-15574 Project:

[jira] [Created] (KAFKA-15573) Implement auto-commit on partition assignment revocation

2023-10-10 Thread Kirk True (Jira)
Kirk True created KAFKA-15573: - Summary: Implement auto-commit on partition assignment revocation Key: KAFKA-15573 URL: https://issues.apache.org/jira/browse/KAFKA-15573 Project: Kafka Issue

[jira] [Updated] (KAFKA-15573) Implement auto-commit on partition assignment revocation

2023-10-10 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15573?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-15573: -- Description: When the group member's assignment changes and partitions are revoked and auto-commit is

Re: [PR] KAFKA-14323: Client state changes for handling one assignment at a time & minor improvements [kafka]

2023-10-10 Thread via GitHub
philipnee commented on code in PR #14413: URL: https://github.com/apache/kafka/pull/14413#discussion_r1352882295 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManager.java: ## @@ -21,53 +21,76 @@ import java.util.Optional; /** - * Manages

Re: [PR] KAFKA-14274 [6, 7]: Introduction of fetch request manager [kafka]

2023-10-10 Thread via GitHub
kirktrue commented on code in PR #14406: URL: https://github.com/apache/kafka/pull/14406#discussion_r1352879009 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/RequestManager.java: ## @@ -16,13 +16,48 @@ */ package

Re: [PR] KAFKA-14274 [6, 7]: Introduction of fetch request manager [kafka]

2023-10-10 Thread via GitHub
kirktrue commented on code in PR #14406: URL: https://github.com/apache/kafka/pull/14406#discussion_r1352876631 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThread.java: ## @@ -0,0 +1,252 @@ +/* + * Licensed to the Apache Software

Re: [PR] KAFKA-14323: Client state changes for handling one assignment at a time & minor improvements [kafka]

2023-10-10 Thread via GitHub
philipnee commented on code in PR #14413: URL: https://github.com/apache/kafka/pull/14413#discussion_r1352876691 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManager.java: ## @@ -21,53 +21,76 @@ import java.util.Optional; /** - * Manages

Re: [PR] KAFKA-14323: Client state changes for handling one assignment at a time & minor improvements [kafka]

2023-10-10 Thread via GitHub
lianetm commented on code in PR #14413: URL: https://github.com/apache/kafka/pull/14413#discussion_r1352875373 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java: ## @@ -19,56 +19,91 @@ import

Re: [PR] KAFKA-14274 [6, 7]: Introduction of fetch request manager [kafka]

2023-10-10 Thread via GitHub
kirktrue commented on code in PR #14406: URL: https://github.com/apache/kafka/pull/14406#discussion_r1352874538 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/BackgroundEventProcessor.java: ## @@ -0,0 +1,103 @@ +/* + * Licensed to the Apache

[PR] Update HEADER [kafka]

2023-10-10 Thread via GitHub
adikarthik opened a new pull request, #14520: URL: https://github.com/apache/kafka/pull/14520 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of

Re: [PR] KAFKA-15221; Fix the race between fetch requests from a rebooted follower. [kafka]

2023-10-10 Thread via GitHub
CalvinConfluent commented on code in PR #14053: URL: https://github.com/apache/kafka/pull/14053#discussion_r1352848836 ## core/src/main/scala/kafka/cluster/Replica.scala: ## @@ -98,14 +105,22 @@ class Replica(val brokerId: Int, val topicPartition: TopicPartition) extends Log

Re: [PR] KAFKA-15221; Fix the race between fetch requests from a rebooted follower. [kafka]

2023-10-10 Thread via GitHub
CalvinConfluent commented on code in PR #14053: URL: https://github.com/apache/kafka/pull/14053#discussion_r1352848836 ## core/src/main/scala/kafka/cluster/Replica.scala: ## @@ -98,14 +105,22 @@ class Replica(val brokerId: Int, val topicPartition: TopicPartition) extends Log

Re: [PR] KAFKA-14987; Implement Group/Offset expiration in the new coordinator [kafka]

2023-10-10 Thread via GitHub
jeffkbkim commented on code in PR #14467: URL: https://github.com/apache/kafka/pull/14467#discussion_r1352815096 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/generic/GenericGroup.java: ## @@ -898,6 +900,46 @@ public void createGroupTombstoneRecords(List

Re: [PR] KAFKA-15355: Message schema changes [kafka]

2023-10-10 Thread via GitHub
clolov commented on PR #14290: URL: https://github.com/apache/kafka/pull/14290#issuecomment-1755706472 I am putting myself as a reviewer because I would like to keep up to date with these changes. I will aim to provide my review tomorrow! -- This is an automated message from the Apache

Re: [PR] KAFKA-14323: Client state changes for handling one assignment at a time & minor improvements [kafka]

2023-10-10 Thread via GitHub
lianetm commented on PR #14413: URL: https://github.com/apache/kafka/pull/14413#issuecomment-1755659746 Hey @dajac , this ready for review now, including trunk latest changes. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[PR] KAFKA-14323: Client state changes for handling one assignment at a time & minor improvements [kafka]

2023-10-10 Thread via GitHub
lianetm opened a new pull request, #14413: URL: https://github.com/apache/kafka/pull/14413 This PR includes: - changes for error handling, leaving responsibility in the heartbeatManager and exposing only the functionality for when the state needs to be updated (on successful HB, on

Re: [PR] KAFKA-14323: Client state changes for handling one assignment at a time & minor improvements [kafka]

2023-10-10 Thread via GitHub
lianetm closed pull request #14413: KAFKA-14323: Client state changes for handling one assignment at a time & minor improvements URL: https://github.com/apache/kafka/pull/14413 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[jira] [Updated] (KAFKA-15572) Race condition between future log dir roll and replace current with future log during alterReplicaLogDirs

2023-10-10 Thread Lucian Ilie (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15572?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lucian Ilie updated KAFKA-15572: Affects Version/s: 3.0.0 (was: 3.3.1) (was:

[jira] [Updated] (KAFKA-15572) Race condition between future log dir roll and replace current with future log during alterReplicaLogDirs

2023-10-10 Thread Lucian Ilie (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15572?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lucian Ilie updated KAFKA-15572: Description: We are using a Kafka cluster with Zookeeper, deployed on top of Kubernetes, using

[jira] [Updated] (KAFKA-15572) Race condition between future log dir roll and replace current with future log during alterReplicaLogDirs

2023-10-10 Thread Lucian Ilie (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15572?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lucian Ilie updated KAFKA-15572: Attachment: kafka-alter-log-dir-nosuchfileexception.log > Race condition between future log dir

[jira] [Updated] (KAFKA-15572) Race condition between future log dir roll and replace current with future log during alterReplicaLogDirs

2023-10-10 Thread Lucian Ilie (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15572?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lucian Ilie updated KAFKA-15572: Description: We are using a Kafka cluster with Zookeeper, deployed on top of Kubernetes, using

[jira] [Updated] (KAFKA-15572) Race condition between future log dir roll and replace current with future log during alterReplicaLogDirs

2023-10-10 Thread Lucian Ilie (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15572?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lucian Ilie updated KAFKA-15572: Description: We are using a Kafka cluster with Zookeeper, deployed on top of Kubernetes, using

[jira] [Updated] (KAFKA-15572) Race condition between future log dir roll and replace current with future log during alterReplicaLogDirs

2023-10-10 Thread Lucian Ilie (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15572?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lucian Ilie updated KAFKA-15572: Description: We are using a Kafka cluster with Zookeeper, deployed on top of Kubernetes, using

[jira] [Updated] (KAFKA-15572) Race condition between future log dir roll and replace current with future log during alterReplicaLogDirs

2023-10-10 Thread Lucian Ilie (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15572?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lucian Ilie updated KAFKA-15572: Description: We are using a Kafka cluster with Zookeeper, deployed on top of Kubernetes, using

[jira] [Updated] (KAFKA-15572) Race condition between future log dir roll and replace current with future log during alterReplicaLogDirs

2023-10-10 Thread Lucian Ilie (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15572?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lucian Ilie updated KAFKA-15572: Description: We are using a Kafka cluster with Zookeeper, deployed on top of Kubernetes, using

[jira] [Updated] (KAFKA-15572) Race condition between future log dir roll and replace current with future log during alterReplicaLogDirs

2023-10-10 Thread Lucian Ilie (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15572?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lucian Ilie updated KAFKA-15572: Description: We are using a Kafka cluster with Zookeeper, deployed on top of Kubernetes, using

Re: [PR] KAFKA-14596: Move TopicCommand to tools [kafka]

2023-10-10 Thread via GitHub
OmniaGM commented on PR #13201: URL: https://github.com/apache/kafka/pull/13201#issuecomment-1755578715 @mimaison fixed the compilation issue. I spotted another one with Java21 and fixed it as well. -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] KAFKA-15465: Don't throw if MirrorMaker not authorized to create topics. [kafka]

2023-10-10 Thread via GitHub
OmniaGM commented on PR #14388: URL: https://github.com/apache/kafka/pull/14388#issuecomment-1755573422 @mimaison or @C0urante can one of you review this pr, please? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[jira] [Created] (KAFKA-15572) Race condition between future log dir roll and replace current with future log during alterReplicaLogDirs

2023-10-10 Thread Lucian Ilie (Jira)
Lucian Ilie created KAFKA-15572: --- Summary: Race condition between future log dir roll and replace current with future log during alterReplicaLogDirs Key: KAFKA-15572 URL:

  1   2   >