Re: [PR] MINOR: Add upgrade documentation for 3.6.0 [kafka]

2023-10-12 Thread via GitHub
showuon commented on PR #14534: URL: https://github.com/apache/kafka/pull/14534#issuecomment-1760927762 @fvaleri , please open a PR against kafka-site repo for these changes. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] MINOR: Add upgrade documentation for 3.6.0 [kafka]

2023-10-12 Thread via GitHub
fvaleri commented on PR #14534: URL: https://github.com/apache/kafka/pull/14534#issuecomment-1760920323 Thanks for the review. Should be fine now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] KAFKA-15428: Cluster-wide dynamic log adjustments for Connect [kafka]

2023-10-12 Thread via GitHub
yangy commented on code in PR #14538: URL: https://github.com/apache/kafka/pull/14538#discussion_r1357785014 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/Loggers.java: ## @@ -0,0 +1,213 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] KAFKA-15536:Dynamically resize remoteIndexCache [kafka]

2023-10-12 Thread via GitHub
satishd commented on code in PR #14511: URL: https://github.com/apache/kafka/pull/14511#discussion_r1357784736 ## core/src/test/scala/unit/kafka/log/remote/RemoteIndexCacheTest.scala: ## @@ -561,6 +561,103 @@ class RemoteIndexCacheTest {

Re: [PR] KAFKA-15428: Cluster-wide dynamic log adjustments for Connect [kafka]

2023-10-12 Thread via GitHub
yangy commented on code in PR #14538: URL: https://github.com/apache/kafka/pull/14538#discussion_r1357779469 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/Loggers.java: ## @@ -0,0 +1,213 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] KAFKA-15338: The metric group documentation for metrics added in KAFK… [kafka]

2023-10-12 Thread via GitHub
atu-sharm commented on PR #14221: URL: https://github.com/apache/kafka/pull/14221#issuecomment-1760823808 Thanks @mjsax, somehow missed the above comment -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] MINOR: Add upgrade documentation for 3.6.0 [kafka]

2023-10-12 Thread via GitHub
satishd commented on code in PR #14534: URL: https://github.com/apache/kafka/pull/14534#discussion_r1357730427 ## docs/upgrade.html: ## @@ -21,6 +21,67 @@ Upgrading to 3.6.0 from any version 0.8.x through 3.5.x +Upgrading ZooKeeper-based clusters Review Comment:

Re: [PR] MINOR: Add upgrade documentation for 3.6.0 [kafka]

2023-10-12 Thread via GitHub
satishd commented on code in PR #14534: URL: https://github.com/apache/kafka/pull/14534#discussion_r1357730427 ## docs/upgrade.html: ## @@ -21,6 +21,67 @@ Upgrading to 3.6.0 from any version 0.8.x through 3.5.x +Upgrading ZooKeeper-based clusters Review Comment:

Re: [PR] MINOR: Keep FileOffset opened only the needed time [kafka]

2023-10-12 Thread via GitHub
github-actions[bot] commented on PR #13464: URL: https://github.com/apache/kafka/pull/13464#issuecomment-1760709793 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has

Re: [PR] KAFKA-15481: Fix concurrency bug in RemoteIndexCache [kafka]

2023-10-12 Thread via GitHub
showuon commented on code in PR #14483: URL: https://github.com/apache/kafka/pull/14483#discussion_r1357702660 ## storage/src/main/java/org/apache/kafka/storage/internals/log/RemoteIndexCache.java: ## @@ -137,13 +137,10 @@ public RemoteIndexCache(long maxSize,

Re: [PR] MINOR: Optimization of equals methods on implementations of Commands.Handler in shell.command package [kafka]

2023-10-12 Thread via GitHub
github-actions[bot] commented on PR #14018: URL: https://github.com/apache/kafka/pull/14018#issuecomment-1760709572 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has

Re: [PR] KAFKA-15129;[4/N] Remove metrics in Partition when broker shutdown and stopPartitions [kafka]

2023-10-12 Thread via GitHub
github-actions[bot] commented on PR #13952: URL: https://github.com/apache/kafka/pull/13952#issuecomment-1760709626 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has

Re: [PR] KAFKA-15154: Acquire lock when reading checkQuotas [kafka]

2023-10-12 Thread via GitHub
github-actions[bot] commented on PR #13969: URL: https://github.com/apache/kafka/pull/13969#issuecomment-1760709602 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has

Re: [PR] MINOR: Update of the PAPI testing classes to the latest implementation [kafka]

2023-10-12 Thread via GitHub
mjsax commented on code in PR #12740: URL: https://github.com/apache/kafka/pull/12740#discussion_r1357706271 ## streams/src/test/java/org/apache/kafka/test/MockProcessor.java: ## @@ -41,16 +42,14 @@ public MockProcessor() { delegate = new MockApiProcessor<>(); }

[jira] [Updated] (KAFKA-15602) Breaking change in 3.4.0 ByteBufferSerializer

2023-10-12 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15602?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma updated KAFKA-15602: Priority: Critical (was: Major) > Breaking change in 3.4.0 ByteBufferSerializer >

Re: [PR] MINOR: Add upgrade documentation for 3.6.0 [kafka]

2023-10-12 Thread via GitHub
showuon commented on code in PR #14534: URL: https://github.com/apache/kafka/pull/14534#discussion_r1357692822 ## docs/upgrade.html: ## @@ -21,6 +21,67 @@ Upgrading to 3.6.0 from any version 0.8.x through 3.5.x +Upgrading ZooKeeper-based clusters +If you are

Re: [PR] KAFKA-14405: Log a warning when users attempt to set a config controlled by Streams [kafka]

2023-10-12 Thread via GitHub
mjsax commented on PR #12988: URL: https://github.com/apache/kafka/pull/12988#issuecomment-1760676675 Thanks for digging into this -- I think you are spot on -- seem we should extract a method that will set KS controlled config, and refactor `getMainConsumerConfigs` to first call

[jira] [Created] (KAFKA-15602) Breaking change in 3.4.0 ByteBufferSerializer

2023-10-12 Thread Luke Kirby (Jira)
Luke Kirby created KAFKA-15602: -- Summary: Breaking change in 3.4.0 ByteBufferSerializer Key: KAFKA-15602 URL: https://issues.apache.org/jira/browse/KAFKA-15602 Project: Kafka Issue Type: Bug

Re: [PR] KAFKA-10892: Shared Readonly State Stores ( revisited ) [kafka]

2023-10-12 Thread via GitHub
mjsax commented on PR #12742: URL: https://github.com/apache/kafka/pull/12742#issuecomment-1760672364 @calmera -- sorry to dropping the ball on this one -- can we resurrect it? -- First step would be rebase to resolve the conflict. -- This is an automated message from the Apache Git

Re: [PR] [DO NOT MERGE] KAFKA-14533: re-enable the 'false' parameter of SmokeTestDriverIntegrationTest [kafka]

2023-10-12 Thread via GitHub
ableegoldman closed pull request #13155: [DO NOT MERGE] KAFKA-14533: re-enable the 'false' parameter of SmokeTestDriverIntegrationTest URL: https://github.com/apache/kafka/pull/13155 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] [DO NOT MERGE] KAFKA-14533: re-enable the 'false' parameter of SmokeTestDriverIntegrationTest [kafka]

2023-10-12 Thread via GitHub
ableegoldman commented on PR #13155: URL: https://github.com/apache/kafka/pull/13155#issuecomment-1760671049 re-enabled already in https://github.com/apache/kafka/commit/beb0be5fe45d08ff45d6cdddfd86feac8500a7d7#diff-26010bb30ef947a13d4d6d35866c892258dc59dad4d5e2d40c9bb6059fb35381R99 --

Re: [PR] MINOR: Remove unnecessary code for WindowStoreBuilder. [kafka]

2023-10-12 Thread via GitHub
mjsax commented on PR #11047: URL: https://github.com/apache/kafka/pull/11047#issuecomment-1760637045 Closing this PR due to inactivity. Feel free to re-open at any point. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] Enable KStream to be merged with itself [kafka]

2023-10-12 Thread via GitHub
mjsax commented on PR #12608: URL: https://github.com/apache/kafka/pull/12608#issuecomment-1760636434 Closing this PR due to inactivity. Feel free to resume at any time -- and we should have a Jira for this. -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] MINOR: Remove unnecessary code for WindowStoreBuilder. [kafka]

2023-10-12 Thread via GitHub
mjsax closed pull request #11047: MINOR: Remove unnecessary code for WindowStoreBuilder. URL: https://github.com/apache/kafka/pull/11047 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Enable KStream to be merged with itself [kafka]

2023-10-12 Thread via GitHub
mjsax closed pull request #12608: Enable KStream to be merged with itself URL: https://github.com/apache/kafka/pull/12608 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] KAFKA-13787 explicitly delete left over state directory contents to a… [kafka]

2023-10-12 Thread via GitHub
mjsax closed pull request #11977: KAFKA-13787 explicitly delete left over state directory contents to a… URL: https://github.com/apache/kafka/pull/11977 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] KAFKA-13787 explicitly delete left over state directory contents to a… [kafka]

2023-10-12 Thread via GitHub
mjsax commented on PR #11977: URL: https://github.com/apache/kafka/pull/11977#issuecomment-1760636004 Closing this PR because of inactivity. Feel free to re-open at any time. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] MINOR: Typo fixes [kafka]

2023-10-12 Thread via GitHub
mjsax closed pull request #10373: MINOR: Typo fixes URL: https://github.com/apache/kafka/pull/10373 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] MINOR: Typo fixes [kafka]

2023-10-12 Thread via GitHub
mjsax commented on PR #10373: URL: https://github.com/apache/kafka/pull/10373#issuecomment-1760634478 Closing this stale PR in favor of https://github.com/apache/kafka/pull/14542 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[PR] MINOR: fix typo [kafka]

2023-10-12 Thread via GitHub
mjsax opened a new pull request, #14542: URL: https://github.com/apache/kafka/pull/14542 Follow up to abandoned PR https://github.com/apache/kafka/pull/10373 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[PR] MINOR: Fix directory name inconsistency in the Kafka Streams tutorial [kafka]

2023-10-12 Thread via GitHub
mjsax opened a new pull request, #14541: URL: https://github.com/apache/kafka/pull/14541 Follow up for abandoned PR https://github.com/apache/kafka/pull/6640 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] MINOR: Fix directory name inconsistency in the Kafka Streams tutorial [kafka]

2023-10-12 Thread via GitHub
mjsax closed pull request #6640: MINOR: Fix directory name inconsistency in the Kafka Streams tutorial URL: https://github.com/apache/kafka/pull/6640 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] MINOR: Fix directory name inconsistency in the Kafka Streams tutorial [kafka]

2023-10-12 Thread via GitHub
mjsax commented on PR #6640: URL: https://github.com/apache/kafka/pull/6640#issuecomment-1760632087 Closing this stale PR in favor of https://github.com/apache/kafka/pull/14541 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] MINOR: Do not end Javadoc comments with `**/` [kafka]

2023-10-12 Thread via GitHub
mjsax closed pull request #7034: MINOR: Do not end Javadoc comments with `**/` URL: https://github.com/apache/kafka/pull/7034 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] MINOR: Do not end Javadoc comments with `**/` [kafka]

2023-10-12 Thread via GitHub
mjsax commented on PR #7034: URL: https://github.com/apache/kafka/pull/7034#issuecomment-1760629873 Closing this stale PR in favor of https://github.com/apache/kafka/pull/14540 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[PR] MINOR: Do not end Javadoc comments with `**/` [kafka]

2023-10-12 Thread via GitHub
mjsax opened a new pull request, #14540: URL: https://github.com/apache/kafka/pull/14540 Follow up to https://github.com/apache/kafka/pull/7034 that got abandoned. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] KAFKA-14517:Implement regex subscriptions [kafka]

2023-10-12 Thread via GitHub
JimmyWang6 commented on PR #14327: URL: https://github.com/apache/kafka/pull/14327#issuecomment-1760624540 Hi @dajac Thank you for your feedback. I have just understood your point and realized that there are indeed some issues with my code. I will make it a priority to address them as

Re: [PR] KAFKA-15338: The metric group documentation for metrics added in KAFK… [kafka]

2023-10-12 Thread via GitHub
mjsax commented on PR #14221: URL: https://github.com/apache/kafka/pull/14221#issuecomment-1760605508 Did a follow up PR to the webpage: https://github.com/apache/kafka-site/pull/558 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] KAFKA-14481: Move LogSegment/LogSegments to storage module [kafka]

2023-10-12 Thread via GitHub
ijuma commented on PR #14529: URL: https://github.com/apache/kafka/pull/14529#issuecomment-1760584199 Test failures: > Build / JDK 17 and Scala 2.13 / kafka.api.PlaintextConsumerTest.testSubsequentPatternSubscription() Build / JDK 21 and Scala 2.13 /

Re: [PR] KAFKA-15598: Add integration tests for DescribeGroups API, DeleteGroups API and OffsetDelete API [kafka]

2023-10-12 Thread via GitHub
rreddy-22 commented on code in PR #14537: URL: https://github.com/apache/kafka/pull/14537#discussion_r1357586964 ## core/src/test/scala/unit/kafka/server/OffsetDeleteRequestTest.scala: ## @@ -0,0 +1,156 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or

Re: [PR] KAFKA-15093: Add 3.4 and 3.5 Streams upgrade system tests [kafka]

2023-10-12 Thread via GitHub
mjsax commented on PR #13860: URL: https://github.com/apache/kafka/pull/13860#issuecomment-1760562882 > while it was backported to 3.3 branch, too, we never did a bug fix release afterwards and thus the system test that pull release binaries only cannot pickup the cherry-pick I

Re: [PR] KAFKA-15598: Add integration tests for DescribeGroups API, DeleteGroups API and OffsetDelete API [kafka]

2023-10-12 Thread via GitHub
rreddy-22 commented on code in PR #14537: URL: https://github.com/apache/kafka/pull/14537#discussion_r1357582903 ## core/src/test/scala/unit/kafka/server/GroupCoordinatorBaseRequestTest.scala: ## @@ -181,6 +185,52 @@ class GroupCoordinatorBaseRequestTest(cluster:

Re: [PR] KAFKA-15598: Add integration tests for DescribeGroups API, DeleteGroups API and OffsetDelete API [kafka]

2023-10-12 Thread via GitHub
rreddy-22 commented on code in PR #14537: URL: https://github.com/apache/kafka/pull/14537#discussion_r1357577836 ## core/src/test/scala/unit/kafka/server/DescribeGroupsRequestTest.scala: ## @@ -0,0 +1,118 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or

[jira] [Updated] (KAFKA-15601) Client metrics and observability

2023-10-12 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15601?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-15601: Component/s: streams > Client metrics and observability >

[jira] [Updated] (KAFKA-15601) Client metrics and observability

2023-10-12 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15601?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-15601: Component/s: admin clients consumer

[jira] [Updated] (KAFKA-15601) Client metrics and observability

2023-10-12 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15601?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-15601: Labels: kip (was: ) > Client metrics and observability >

Re: [PR] KAFKA-15378: fix streams upgrade system test [kafka]

2023-10-12 Thread via GitHub
mjsax commented on PR #14539: URL: https://github.com/apache/kafka/pull/14539#issuecomment-1760544857 Triggered a system test run: https://jenkins.confluent.io/job/system-test-kafka-branch-builder/5884/ -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] KAFKA-15093: Add 3.4 and 3.5 Streams upgrade system tests [kafka]

2023-10-12 Thread via GitHub
mjsax commented on PR #13860: URL: https://github.com/apache/kafka/pull/13860#issuecomment-1760532227 I just opened a PR to fix `trunk` -- if this PR is merged, I can cherry-pick it to older branches, and you can rebase this PR so we can verify everything is in order and we can merge this

[jira] [Commented] (KAFKA-15591) Trogdor produce workload reports errors in KRaft mode

2023-10-12 Thread Xi Yang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17774710#comment-17774710 ] Xi Yang commented on KAFKA-15591: - Thanks for your reply [~rndgstn].  >If the broker is responding that

[jira] [Updated] (KAFKA-15591) Trogdor produce workload reports errors in KRaft mode

2023-10-12 Thread Xi Yang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15591?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xi Yang updated KAFKA-15591: Attachment: trogdor-kafka-kraft.txt > Trogdor produce workload reports errors in KRaft mode >

Re: [PR] KAFKA-15428: Cluster-wide dynamic log adjustments for Connect [kafka]

2023-10-12 Thread via GitHub
gharris1727 commented on code in PR #14538: URL: https://github.com/apache/kafka/pull/14538#discussion_r1357258143 ## checkstyle/suppressions.xml: ## @@ -139,6 +139,8 @@ files="Worker(SinkTask|SourceTask|Coordinator).java"/> + Review Comment: nit:

[jira] [Created] (KAFKA-15601) Client metrics and observability

2023-10-12 Thread Apoorv Mittal (Jira)
Apoorv Mittal created KAFKA-15601: - Summary: Client metrics and observability Key: KAFKA-15601 URL: https://issues.apache.org/jira/browse/KAFKA-15601 Project: Kafka Issue Type: Improvement

Re: [PR] KAFKA-14519; [1/N] Implement coordinator runtime metrics [kafka]

2023-10-12 Thread via GitHub
jolshan commented on PR #14417: URL: https://github.com/apache/kafka/pull/14417#issuecomment-1760414807 Talked to folks offline -- seems we may want to avoid Yammer metrics, so we will hold off on the histograms for now. -- This is an automated message from the Apache Git Service. To

Re: [PR] KIP-951: Server side and protocol changes for KIP-951 [kafka]

2023-10-12 Thread via GitHub
jolshan commented on code in PR #1: URL: https://github.com/apache/kafka/pull/1#discussion_r1357390202 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -559,6 +560,30 @@ class KafkaApis(val requestChannel: RequestChannel, } } + case class

[jira] [Updated] (KAFKA-15280) Implement client support for KIP-848 server-side assignors

2023-10-12 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15280?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-15280: -- Labels: kip-848 kip-848-client-support kip-848-e2e kip-848-preview (was: consumer-threading-refactor

[jira] [Updated] (KAFKA-15457) Add support for OffsetFetch version 9 in admin

2023-10-12 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15457?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-15457: -- Labels: kip-848 kip-848-client-support kip-848-preview (was: kip-848-preview) > Add support for

[jira] [Updated] (KAFKA-15457) Add support for OffsetFetch version 9 in admin

2023-10-12 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15457?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-15457: -- Component/s: clients consumer > Add support for OffsetFetch version 9 in admin >

[jira] [Updated] (KAFKA-15455) Add support for OffsetCommit version 9 in consumer

2023-10-12 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15455?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-15455: -- Labels: kip-848 kip-848-client-support kip-848-preview (was: kip-848-client-support kip-848-preview)

[jira] [Updated] (KAFKA-15554) Update client state machine to align with protocol sending one assignment at a time

2023-10-12 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15554?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-15554: -- Labels: kip-848 kip-848-client-support kip-848-e2e kip-848-preview (was: kip-848-client-support

[jira] [Updated] (KAFKA-15550) OffsetsForTimes validation for negative timestamps in new consumer

2023-10-12 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15550?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-15550: -- Labels: kip-848 kip-848-client-support kip-848-preview (was: kip-848-client-support kip-848-preview)

[jira] [Updated] (KAFKA-15456) Add support for OffsetFetch version 9 in consumer

2023-10-12 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15456?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-15456: -- Labels: kip-848 kip-848-client-support kip-848-preview (was: kip-848-client-support kip-848-preview)

[jira] [Updated] (KAFKA-15561) Client support for new SubscriptionPattern based subscription

2023-10-12 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15561?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-15561: -- Labels: kip-848 kip-848-client-support kip-848-preview (was: kip-848-client-support kip-848-preview)

[jira] [Updated] (KAFKA-15455) Add support for OffsetCommit version 9 in consumer

2023-10-12 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15455?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-15455: -- Component/s: clients consumer > Add support for OffsetCommit version 9 in consumer >

[jira] [Updated] (KAFKA-15456) Add support for OffsetFetch version 9 in consumer

2023-10-12 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15456?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-15456: -- Component/s: clients consumer > Add support for OffsetFetch version 9 in consumer >

[jira] [Updated] (KAFKA-15454) Add support for OffsetCommit version 9 in admin client

2023-10-12 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15454?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-15454: -- Component/s: clients consumer > Add support for OffsetCommit version 9 in admin

[jira] [Updated] (KAFKA-15454) Add support for OffsetCommit version 9 in admin client

2023-10-12 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15454?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-15454: -- Labels: kip-848 kip-848-client-support kip-848-preview (was: kip-848 kip-848-preview) > Add support

Re: [PR] KIP-951: Server side and protocol changes for KIP-951 [kafka]

2023-10-12 Thread via GitHub
chb2ab commented on code in PR #1: URL: https://github.com/apache/kafka/pull/1#discussion_r1357361724 ## clients/src/main/java/org/apache/kafka/common/requests/ProduceResponse.java: ## @@ -67,20 +69,31 @@ public ProduceResponse(ProduceResponseData produceResponseData)

Re: [PR] KIP-951: Server side and protocol changes for KIP-951 [kafka]

2023-10-12 Thread via GitHub
chb2ab commented on code in PR #1: URL: https://github.com/apache/kafka/pull/1#discussion_r1357335847 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -559,6 +560,30 @@ class KafkaApis(val requestChannel: RequestChannel, } } + case class

Re: [PR] KAFKA-15276: Implement partition assignment reconciliation [kafka]

2023-10-12 Thread via GitHub
lianetm commented on code in PR #14357: URL: https://github.com/apache/kafka/pull/14357#discussion_r1357303436 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AssignmentReconciler.java: ## @@ -0,0 +1,328 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] KIP-951: Server side and protocol changes for KIP-951 [kafka]

2023-10-12 Thread via GitHub
chb2ab commented on code in PR #1: URL: https://github.com/apache/kafka/pull/1#discussion_r1357293893 ## server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java: ## @@ -338,7 +338,7 @@ public boolean isControllerRegistrationSupported() {

Re: [PR] KIP-951: Server side and protocol changes for KIP-951 [kafka]

2023-10-12 Thread via GitHub
chb2ab commented on code in PR #1: URL: https://github.com/apache/kafka/pull/1#discussion_r1357293893 ## server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java: ## @@ -338,7 +338,7 @@ public boolean isControllerRegistrationSupported() {

Re: [PR] KIP-951: Server side and protocol changes for KIP-951 [kafka]

2023-10-12 Thread via GitHub
chb2ab commented on code in PR #1: URL: https://github.com/apache/kafka/pull/1#discussion_r1357293893 ## server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java: ## @@ -338,7 +338,7 @@ public boolean isControllerRegistrationSupported() {

Re: [PR] KAFKA-15276: Implement partition assignment reconciliation [kafka]

2023-10-12 Thread via GitHub
lianetm commented on code in PR #14357: URL: https://github.com/apache/kafka/pull/14357#discussion_r1357289954 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AssignmentReconciler.java: ## @@ -0,0 +1,328 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] KIP-951: Server side and protocol changes for KIP-951 [kafka]

2023-10-12 Thread via GitHub
chb2ab commented on code in PR #1: URL: https://github.com/apache/kafka/pull/1#discussion_r1357265438 ## server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java: ## @@ -338,7 +338,7 @@ public boolean isControllerRegistrationSupported() {

[jira] [Updated] (KAFKA-15562) CommitRequestManager needs to test different error handling

2023-10-12 Thread Philip Nee (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15562?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Philip Nee updated KAFKA-15562: --- Labels: consumer-threading-refactor kip-848-e2e kip-848-preview (was: consumer-threading-refactor

[jira] [Updated] (KAFKA-14761) Integration Tests for the New Consumer Implementation

2023-10-12 Thread Philip Nee (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14761?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Philip Nee updated KAFKA-14761: --- Priority: Blocker (was: Critical) > Integration Tests for the New Consumer Implementation >

[jira] [Updated] (KAFKA-15277) Design & implement support for internal Consumer delegates

2023-10-12 Thread Philip Nee (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15277?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Philip Nee updated KAFKA-15277: --- Priority: Blocker (was: Major) > Design & implement support for internal Consumer delegates >

Re: [PR] KAFKA-15598: Add integration tests for DescribeGroups API, DeleteGroups API and OffsetDelete API [kafka]

2023-10-12 Thread via GitHub
rreddy-22 commented on code in PR #14537: URL: https://github.com/apache/kafka/pull/14537#discussion_r1357266534 ## core/src/test/scala/unit/kafka/server/DescribeGroupsRequestTest.scala: ## @@ -0,0 +1,119 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or

[jira] [Updated] (KAFKA-15284) Implement ConsumerGroupProtocolVersionResolver to determine consumer group protocol

2023-10-12 Thread Philip Nee (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15284?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Philip Nee updated KAFKA-15284: --- Priority: Blocker (was: Major) > Implement ConsumerGroupProtocolVersionResolver to determine

Re: [PR] KIP-951: Server side and protocol changes for KIP-951 [kafka]

2023-10-12 Thread via GitHub
chb2ab commented on code in PR #1: URL: https://github.com/apache/kafka/pull/1#discussion_r1357265438 ## server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java: ## @@ -338,7 +338,7 @@ public boolean isControllerRegistrationSupported() {

Re: [PR] KAFKA-15598: Add integration tests for DescribeGroups API, DeleteGroups API and OffsetDelete API [kafka]

2023-10-12 Thread via GitHub
rreddy-22 commented on code in PR #14537: URL: https://github.com/apache/kafka/pull/14537#discussion_r1357264959 ## core/src/test/scala/unit/kafka/server/DeleteGroupsRequestTest.scala: ## @@ -0,0 +1,136 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or

[jira] [Updated] (KAFKA-15321) Document consumer group member state machine

2023-10-12 Thread Philip Nee (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15321?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Philip Nee updated KAFKA-15321: --- Priority: Minor (was: Major) > Document consumer group member state machine >

[jira] [Updated] (KAFKA-15317) Fix for async consumer access to committed offsets with multiple consumers

2023-10-12 Thread Philip Nee (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Philip Nee updated KAFKA-15317: --- Priority: Minor (was: Major) > Fix for async consumer access to committed offsets with multiple

[jira] [Updated] (KAFKA-15534) Propagate client response time when timeout to the request handler

2023-10-12 Thread Philip Nee (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15534?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Philip Nee updated KAFKA-15534: --- Priority: Minor (was: Major) > Propagate client response time when timeout to the request handler

Re: [PR] KAFKA-15598: Add integration tests for DescribeGroups API, DeleteGroups API and OffsetDelete API [kafka]

2023-10-12 Thread via GitHub
rreddy-22 commented on code in PR #14537: URL: https://github.com/apache/kafka/pull/14537#discussion_r1357262012 ## core/src/test/scala/unit/kafka/server/DeleteGroupsRequestTest.scala: ## @@ -0,0 +1,136 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or

[jira] [Updated] (KAFKA-15457) Add support for OffsetFetch version 9 in admin

2023-10-12 Thread Philip Nee (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15457?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Philip Nee updated KAFKA-15457: --- Priority: Minor (was: Major) > Add support for OffsetFetch version 9 in admin >

[jira] [Updated] (KAFKA-15454) Add support for OffsetCommit version 9 in admin client

2023-10-12 Thread Philip Nee (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15454?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Philip Nee updated KAFKA-15454: --- Priority: Minor (was: Major) > Add support for OffsetCommit version 9 in admin client >

[jira] [Updated] (KAFKA-15538) Client support for java regex based subscription

2023-10-12 Thread Philip Nee (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15538?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Philip Nee updated KAFKA-15538: --- Priority: Minor (was: Critical) > Client support for java regex based subscription >

[jira] [Updated] (KAFKA-15533) Ensure HeartbeatRequestManager only send out some fields once

2023-10-12 Thread Philip Nee (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15533?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Philip Nee updated KAFKA-15533: --- Priority: Minor (was: Major) > Ensure HeartbeatRequestManager only send out some fields once >

[jira] [Updated] (KAFKA-15475) Timeout request might retry forever even if the user API times out in PrototypeAsyncConsumer

2023-10-12 Thread Philip Nee (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15475?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Philip Nee updated KAFKA-15475: --- Priority: Minor (was: Major) > Timeout request might retry forever even if the user API times out

[jira] [Updated] (KAFKA-15561) Client support for new SubscriptionPattern based subscription

2023-10-12 Thread Philip Nee (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15561?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Philip Nee updated KAFKA-15561: --- Priority: Minor (was: Critical) > Client support for new SubscriptionPattern based subscription >

[jira] [Updated] (KAFKA-15554) Update client state machine to align with protocol sending one assignment at a time

2023-10-12 Thread Philip Nee (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15554?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Philip Nee updated KAFKA-15554: --- Priority: Blocker (was: Major) > Update client state machine to align with protocol sending one

[jira] [Updated] (KAFKA-15555) Ensure wakeups are handled correctly in PrototypeAsyncConsumer.poll()

2023-10-12 Thread Philip Nee (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-1?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Philip Nee updated KAFKA-1: --- Priority: Minor (was: Major) > Ensure wakeups are handled correctly in

[jira] [Updated] (KAFKA-15543) Send HB request right after reconciliation completes

2023-10-12 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15543?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lianet Magrans updated KAFKA-15543: --- Priority: Blocker (was: Major) > Send HB request right after reconciliation completes >

[jira] [Updated] (KAFKA-15562) CommitRequestManager needs to test different error handling

2023-10-12 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15562?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lianet Magrans updated KAFKA-15562: --- Priority: Blocker (was: Major) > CommitRequestManager needs to test different error

[jira] [Updated] (KAFKA-15574) Integrate partition assignment reconciliation with heartbeat request manager

2023-10-12 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15574?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lianet Magrans updated KAFKA-15574: --- Priority: Blocker (was: Major) > Integrate partition assignment reconciliation with

Re: [PR] KAFKA-15581: Introduce ELR [kafka]

2023-10-12 Thread via GitHub
CalvinConfluent commented on code in PR #14312: URL: https://github.com/apache/kafka/pull/14312#discussion_r1357255199 ## metadata/src/main/java/org/apache/kafka/controller/PartitionChangeBuilder.java: ## @@ -328,13 +353,37 @@ public Optional build() {

Re: [PR] KAFKA-15581: Introduce ELR [kafka]

2023-10-12 Thread via GitHub
CalvinConfluent commented on code in PR #14312: URL: https://github.com/apache/kafka/pull/14312#discussion_r1357250930 ## metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java: ## @@ -1994,6 +2014,24 @@ private void

Re: [PR] KAFKA-15581: Introduce ELR [kafka]

2023-10-12 Thread via GitHub
CalvinConfluent commented on code in PR #14312: URL: https://github.com/apache/kafka/pull/14312#discussion_r1357251569 ## metadata/src/main/resources/common/metadata/PartitionChangeRecord.json: ## @@ -40,6 +42,15 @@ "versions": "0+", "nullableVersions": "0+",

[jira] [Updated] (KAFKA-15562) CommitRequestManager needs to test different error handling

2023-10-12 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15562?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-15562: -- Component/s: clients > CommitRequestManager needs to test different error handling >

  1   2   3   >