ableegoldman commented on code in PR #14549:
URL: https://github.com/apache/kafka/pull/14549#discussion_r1359737490
##
streams/src/main/java/org/apache/kafka/streams/StreamsBuilder.java:
##
@@ -87,12 +87,12 @@ public StreamsBuilder() {
*/
hgeraldino commented on code in PR #14505:
URL: https://github.com/apache/kafka/pull/14505#discussion_r1359700014
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/WorkerSinkTaskThreadedTest.java:
##
@@ -409,309 +430,266 @@ public void
guozhangwang commented on code in PR #14550:
URL: https://github.com/apache/kafka/pull/14550#discussion_r1359692144
##
streams/src/main/java/org/apache/kafka/streams/kstream/Branched.java:
##
@@ -90,33 +104,43 @@ public static Branched withConsumer(final
Consumer> c
/**
mjsax commented on code in PR #14549:
URL: https://github.com/apache/kafka/pull/14549#discussion_r1359669572
##
streams/src/main/java/org/apache/kafka/streams/StreamsBuilder.java:
##
@@ -87,12 +87,12 @@ public StreamsBuilder() {
*/
@SuppressWarnings("this-escape")
mjsax commented on code in PR #14550:
URL: https://github.com/apache/kafka/pull/14550#discussion_r1359669078
##
streams/src/main/java/org/apache/kafka/streams/kstream/Branched.java:
##
@@ -90,33 +104,43 @@ public static Branched withConsumer(final
Consumer> c
/**
*
mjsax commented on code in PR #14550:
URL: https://github.com/apache/kafka/pull/14550#discussion_r1359668981
##
streams/src/main/java/org/apache/kafka/streams/kstream/ForeachAction.java:
##
@@ -27,15 +27,18 @@
*
* @param key type
* @param value type
+ *
* @see
mjsax commented on code in PR #14550:
URL: https://github.com/apache/kafka/pull/14550#discussion_r1359668737
##
streams/src/main/java/org/apache/kafka/streams/kstream/Branched.java:
##
@@ -125,21 +149,14 @@ public static Branched withConsumer(final
Consumer(name, null,
[
https://issues.apache.org/jira/browse/KAFKA-13152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17775325#comment-17775325
]
Matthias J. Sax commented on KAFKA-13152:
-
[~guozhang] would you have interest to help getting
[
https://issues.apache.org/jira/browse/KAFKA-15594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17775323#comment-17775323
]
Matthias J. Sax commented on KAFKA-15594:
-
This ticket is to include upgrade test from 3.6 to
[
https://issues.apache.org/jira/browse/KAFKA-15594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17775324#comment-17775324
]
Matthias J. Sax commented on KAFKA-15594:
-
This ticket is to include upgrade test from 3.6 to
[
https://issues.apache.org/jira/browse/KAFKA-15593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17775322#comment-17775322
]
Matthias J. Sax commented on KAFKA-15593:
-
This ticket is to include upgrade test from 3.6 to
[
https://issues.apache.org/jira/browse/KAFKA-15406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17775316#comment-17775316
]
Colin McCabe commented on KAFKA-15406:
--
This feature is planned for 3.7, but not with high
guozhangwang commented on code in PR #14549:
URL: https://github.com/apache/kafka/pull/14549#discussion_r1359654735
##
streams/src/main/java/org/apache/kafka/streams/StreamsBuilder.java:
##
@@ -87,12 +87,12 @@ public StreamsBuilder() {
*/
guozhangwang commented on code in PR #14550:
URL: https://github.com/apache/kafka/pull/14550#discussion_r1359652648
##
streams/src/main/java/org/apache/kafka/streams/kstream/ForeachAction.java:
##
@@ -27,15 +27,18 @@
*
* @param key type
* @param value type
+ *
* @see
[
https://issues.apache.org/jira/browse/KAFKA-15147?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Divij Vaidya reassigned KAFKA-15147:
Assignee: Christo Lolov (was: Divij Vaidya)
> Measure pending and outstanding Remote
[
https://issues.apache.org/jira/browse/KAFKA-15249?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Egerton resolved KAFKA-15249.
---
Resolution: Done
> Verify Connect test-plugins artifact is published to Maven Central
>
[
https://issues.apache.org/jira/browse/KAFKA-15147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17775304#comment-17775304
]
Stanislav Kozlovski commented on KAFKA-15147:
-
thanks for the quick update [~divijvaidya] -
[
https://issues.apache.org/jira/browse/KAFKA-15147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17775303#comment-17775303
]
Divij Vaidya commented on KAFKA-15147:
--
Hi [~enether]
We have a KIP for this Jira which is under
[
https://issues.apache.org/jira/browse/KAFKA-14175?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stanislav Kozlovski resolved KAFKA-14175.
-
Resolution: Won't Fix
> KRaft Upgrades Part 2
> -
>
>
[
https://issues.apache.org/jira/browse/KAFKA-14175?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stanislav Kozlovski updated KAFKA-14175:
Fix Version/s: (was: 3.7.0)
> KRaft Upgrades Part 2
> -
>
[
https://issues.apache.org/jira/browse/KAFKA-14175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17775301#comment-17775301
]
Stanislav Kozlovski commented on KAFKA-14175:
-
[~mumrah] confirmed to me that this seems to
[
https://issues.apache.org/jira/browse/KAFKA-14945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17775300#comment-17775300
]
Stanislav Kozlovski commented on KAFKA-14945:
-
[~LSK] given the lack of activity from July
mjsax opened a new pull request, #14550:
URL: https://github.com/apache/kafka/pull/14550
We embrace immutability and thus should return a new object instead of
`this`, similar to other config classed we use in the DSL.
Side JavaDocs cleanup for a bunch of classes.
--
This is an
[
https://issues.apache.org/jira/browse/KAFKA-15230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17775299#comment-17775299
]
Stanislav Kozlovski commented on KAFKA-15230:
-
Did it release with 3.6.0?
> ApiVersions
[
https://issues.apache.org/jira/browse/KAFKA-10892?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stanislav Kozlovski updated KAFKA-10892:
Fix Version/s: (was: 3.7.0)
> Add Topology#connectSourceStoreAndTopic as a
[
https://issues.apache.org/jira/browse/KAFKA-10892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17775298#comment-17775298
]
Stanislav Kozlovski commented on KAFKA-10892:
-
Given the lack of activity on
[
https://issues.apache.org/jira/browse/KAFKA-12473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17775296#comment-17775296
]
Stanislav Kozlovski commented on KAFKA-12473:
-
[~dajac] [~showuon] shall we update the KIP
[
https://issues.apache.org/jira/browse/KAFKA-15147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17775295#comment-17775295
]
Stanislav Kozlovski commented on KAFKA-15147:
-
[~divijvaidya] given that there is no kip, is
[
https://issues.apache.org/jira/browse/KAFKA-14175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17775294#comment-17775294
]
Stanislav Kozlovski commented on KAFKA-14175:
-
given the lack of activity in the last few
[
https://issues.apache.org/jira/browse/KAFKA-15594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17775293#comment-17775293
]
Stanislav Kozlovski commented on KAFKA-15594:
-
[~satish.duggana] is anyone going to be
[
https://issues.apache.org/jira/browse/KAFKA-12399?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stanislav Kozlovski updated KAFKA-12399:
Fix Version/s: (was: 3.7.0)
> Deprecate Log4J Appender KIP-719
>
[
https://issues.apache.org/jira/browse/KAFKA-12399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17775292#comment-17775292
]
Stanislav Kozlovski commented on KAFKA-12399:
-
This was last reviewed on March 7 and there
[
https://issues.apache.org/jira/browse/KAFKA-13152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17775291#comment-17775291
]
Stanislav Kozlovski commented on KAFKA-13152:
-
Given there hasn't been much movement in this
[
https://issues.apache.org/jira/browse/KAFKA-15593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17775286#comment-17775286
]
Stanislav Kozlovski commented on KAFKA-15593:
-
[~satish.duggana] is this good to close?
[
https://issues.apache.org/jira/browse/KAFKA-14077?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stanislav Kozlovski updated KAFKA-14077:
Fix Version/s: (was: 3.7.0)
> KRaft should support recovery from failed disk
[
https://issues.apache.org/jira/browse/KAFKA-14077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17775285#comment-17775285
]
Stanislav Kozlovski commented on KAFKA-14077:
-
I asked [~jagsancio] and [~hachikuji] for
[
https://issues.apache.org/jira/browse/KAFKA-12886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17775284#comment-17775284
]
Stanislav Kozlovski commented on KAFKA-12886:
-
[~rdielhenn] is this targetting 3.7? I wonder
[
https://issues.apache.org/jira/browse/KAFKA-12886?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stanislav Kozlovski updated KAFKA-12886:
Fix Version/s: (was: 3.7.0)
> Enable request forwarding by default
>
[
https://issues.apache.org/jira/browse/KAFKA-15406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17775275#comment-17775275
]
Stanislav Kozlovski commented on KAFKA-15406:
-
[~cmccabe] given that we are targetting this
mjsax opened a new pull request, #14549:
URL: https://github.com/apache/kafka/pull/14549
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of testing
mjsax commented on code in PR #14548:
URL: https://github.com/apache/kafka/pull/14548#discussion_r1359477497
##
build.gradle:
##
@@ -2151,7 +2151,7 @@ project(':streams') {
task genStreamsConfigDocs(type: JavaExec) {
classpath = sourceSets.main.runtimeClasspath
-
mjsax opened a new pull request, #14548:
URL: https://github.com/apache/kafka/pull/14548
This is a POC to refactor `StreamsConfig` to move "leaking" internal methods
into a newly added subclass `InternalStreamsConfig`, following an already
established pattern using for DSL config objects
hudeqi created KAFKA-15607:
--
Summary: Possible NPE is thrown in MirrorCheckpointTask
Key: KAFKA-15607
URL: https://issues.apache.org/jira/browse/KAFKA-15607
Project: Kafka
Issue Type: Bug
hudeqi commented on code in PR #14511:
URL: https://github.com/apache/kafka/pull/14511#discussion_r1359460675
##
core/src/test/scala/unit/kafka/log/remote/RemoteIndexCacheTest.scala:
##
@@ -561,6 +561,108 @@ class RemoteIndexCacheTest {
hudeqi commented on code in PR #14511:
URL: https://github.com/apache/kafka/pull/14511#discussion_r1359460627
##
core/src/test/scala/unit/kafka/log/remote/RemoteIndexCacheTest.scala:
##
@@ -561,6 +561,108 @@ class RemoteIndexCacheTest {
hudeqi commented on code in PR #14511:
URL: https://github.com/apache/kafka/pull/14511#discussion_r1359460606
##
core/src/test/scala/unit/kafka/log/remote/RemoteIndexCacheTest.scala:
##
@@ -561,6 +561,108 @@ class RemoteIndexCacheTest {
hudeqi commented on code in PR #14511:
URL: https://github.com/apache/kafka/pull/14511#discussion_r1359460521
##
core/src/test/scala/unit/kafka/log/remote/RemoteIndexCacheTest.scala:
##
@@ -561,6 +561,108 @@ class RemoteIndexCacheTest {
hudeqi commented on code in PR #14511:
URL: https://github.com/apache/kafka/pull/14511#discussion_r1359435180
##
core/src/test/scala/unit/kafka/log/remote/RemoteIndexCacheTest.scala:
##
@@ -525,7 +525,7 @@ class RemoteIndexCacheTest {
.filter(path =>
iit2009060 commented on code in PR #14483:
URL: https://github.com/apache/kafka/pull/14483#discussion_r1359185319
##
core/src/test/scala/unit/kafka/log/remote/RemoteIndexCacheTest.scala:
##
@@ -592,16 +593,75 @@ class RemoteIndexCacheTest {
verifyFetchIndexInvocation(count
yashmayya commented on PR #14361:
URL: https://github.com/apache/kafka/pull/14361#issuecomment-1762750265
Test failures are unrelated, merging to `trunk`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
yashmayya merged PR #14361:
URL: https://github.com/apache/kafka/pull/14361
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
showuon commented on code in PR #14483:
URL: https://github.com/apache/kafka/pull/14483#discussion_r1359202415
##
storage/src/main/java/org/apache/kafka/storage/internals/log/RemoteIndexCache.java:
##
@@ -193,7 +192,16 @@ public File cacheDir() {
public void remove(Uuid
showuon commented on code in PR #14483:
URL: https://github.com/apache/kafka/pull/14483#discussion_r1359202160
##
storage/src/main/java/org/apache/kafka/storage/internals/log/RemoteIndexCache.java:
##
@@ -193,7 +192,16 @@ public File cacheDir() {
public void remove(Uuid
53 matches
Mail list logo
