Re: [PR] KAFKA-15534: Inject request completion time when the request failed [kafka]

cadonna commented on code in PR #14532: URL: https://github.com/apache/kafka/pull/14532#discussion_r1363231692 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java: ## @@ -184,13 +184,11 @@ private NetworkClientDelegate.UnsentRequest

[jira] [Updated] (KAFKA-15223) Need more clarity in documentation for upgrade/downgrade procedures and limitations across releases.

[ https://issues.apache.org/jira/browse/KAFKA-15223?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] kaushik srinivas updated KAFKA-15223: - Priority: Major (was: Critical) > Need more clarity in documentation for

[jira] [Updated] (KAFKA-15223) Need more clarity in documentation for upgrade/downgrade procedures and limitations across releases.

[ https://issues.apache.org/jira/browse/KAFKA-15223?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] kaushik srinivas updated KAFKA-15223: - Issue Type: Improvement (was: Bug) > Need more clarity in documentation for

[PR] MINOR: Rename lock variable of the entry class [kafka]

iit2009060 opened a new pull request, #14569: URL: https://github.com/apache/kafka/pull/14569 The RemoteIndexCache has a variable `lock` and the child class also have a variable `lock` in the same class file. Renaming lock of the entry(child class) to avoid confusion. ### Committer

Re: [PR] KAFKA-15378: fix streams upgrade system test [kafka]

mjsax commented on code in PR #14539: URL: https://github.com/apache/kafka/pull/14539#discussion_r1363148136 ## tests/kafkatest/tests/streams/streams_upgrade_test.py: ## @@ -40,11 +40,13 @@ metadata_1_versions = [str(LATEST_0_10_0)] metadata_2_versions = [str(LATEST_0_10_1),

Re: [PR] KAFKA-15378: fix streams upgrade system test [kafka]

mjsax commented on code in PR #14539: URL: https://github.com/apache/kafka/pull/14539#discussion_r1363147275 ## tests/kafkatest/tests/streams/streams_broker_down_resilience_test.py: ## @@ -100,7 +100,7 @@ def test_streams_runs_with_broker_down_initially(self, metadata_quorum):

Re: [PR] MINOR: Do not end Javadoc comments with `**/` [kafka]

mjsax merged PR #14540: URL: https://github.com/apache/kafka/pull/14540 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] MINOR: Do not end Javadoc comments with `**/` [kafka]

mjsax commented on code in PR #14540: URL: https://github.com/apache/kafka/pull/14540#discussion_r1363144968 ## tools/src/main/java/org/apache/kafka/tools/VerifiableProducer.java: ## @@ -290,7 +290,7 @@ record = new ProducerRecord<>(topic, key, value); } } -

Re: [PR] MINOR: Do not end Javadoc comments with `**/` [kafka]

mjsax commented on code in PR #14540: URL: https://github.com/apache/kafka/pull/14540#discussion_r1363143859 ## connect/api/src/main/java/org/apache/kafka/connect/health/ConnectClusterDetails.java: ## @@ -27,6 +27,6 @@ public interface ConnectClusterDetails { * Get the

Re: [PR] KAFKA-14960: [Part I]TopicMetadataRequestManager Implementation [kafka]

philipnee closed pull request #14052: KAFKA-14960: [Part I]TopicMetadataRequestManager Implementation URL: https://github.com/apache/kafka/pull/14052 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] KAFKA-15616: Client telemetry states and transition (KIP-714) [kafka]

philipnee commented on PR #14566: URL: https://github.com/apache/kafka/pull/14566#issuecomment-1767581183 Hi @apoorvmittal10 - Thanks for the PR. I left two comments, similar to @mjsax 's: 1. It seems like internal package is a good place for the state machine 2. IllegalStateException

Re: [PR] KAFKA-15616: Client telemetry states and transition (KIP-714) [kafka]

philipnee commented on code in PR #14566: URL: https://github.com/apache/kafka/pull/14566#discussion_r1363114377 ## clients/src/main/java/org/apache/kafka/clients/ClientTelemetryState.java: ## @@ -0,0 +1,167 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] KAFKA-15616: Client telemetry states and transition (KIP-714) [kafka]

philipnee commented on code in PR #14566: URL: https://github.com/apache/kafka/pull/14566#discussion_r1363112509 ## clients/src/main/java/org/apache/kafka/common/errors/IllegalClientTelemetryStateException.java: ## @@ -0,0 +1,26 @@ +/* + * Licensed to the Apache Software

Re: [PR] KAFKA-15093: Add 3.4 and 3.5 Streams upgrade system tests [kafka]

mjsax commented on PR #13860: URL: https://github.com/apache/kafka/pull/13860#issuecomment-1767576747 Updated https://github.com/apache/kafka/pull/14539 and re-triggered a system test run. Let's hope for the best :) -- This is an automated message from the Apache Git Service. To respond

Re: [PR] KAFKA-15378: fix streams upgrade system test [kafka]

mjsax commented on PR #14539: URL: https://github.com/apache/kafka/pull/14539#issuecomment-1767576443 Triggered a new system test build: https://jenkins.confluent.io/job/system-test-kafka-branch-builder/5891/ Some tests seems to be flaky (cf

Re: [PR] KAFKA-15378: fix streams upgrade system test [kafka]

mjsax commented on PR #14539: URL: https://github.com/apache/kafka/pull/14539#issuecomment-1767575130 Rebased this PR to pick-up bug-fix https://github.com/apache/kafka/pull/14555 (bug was exposed via system test). -> Re-enable state-updater. Also added a fix for

Re: [PR] KAFKA-15093: Add 3.4 and 3.5 Streams upgrade system tests [kafka]

mjsax commented on PR #13860: URL: https://github.com/apache/kafka/pull/13860#issuecomment-1767572941 Summary about your test results: - `streams_upgrade_test` expected to still fail because 14539 was not merged yet - `streams_cooperative_rebalance_upgrade_test` -- seems to be flaky

Re: [PR] KAFKA-15088: Fixing Incorrect Reference Usage in Connector State Changes [kafka]

github-actions[bot] commented on PR #13853: URL: https://github.com/apache/kafka/pull/13853#issuecomment-1767571944 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has

Re: [PR] MINOR : Changing the invalid domain name of the test code to a meaningful one [kafka]

github-actions[bot] commented on PR #13985: URL: https://github.com/apache/kafka/pull/13985#issuecomment-1767571768 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has

Re: [PR] KAFKA-15205:Catch InterruptedException when calling ShutDownableThrea… [kafka]

github-actions[bot] commented on PR #14042: URL: https://github.com/apache/kafka/pull/14042#issuecomment-1767571710 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has

Re: [PR] On metadata-update, mark paritions for immediate retry [kafka]

github-actions[bot] commented on PR #14048: URL: https://github.com/apache/kafka/pull/14048#issuecomment-1767571686 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has

Re: [PR] KAFKA-14960: [Part I]TopicMetadataRequestManager Implementation [kafka]

github-actions[bot] commented on PR #14052: URL: https://github.com/apache/kafka/pull/14052#issuecomment-1767571650 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has

Re: [PR] KAFKA-15616: Client telemetry states and transition (KIP-714) [kafka]

philipnee commented on code in PR #14566: URL: https://github.com/apache/kafka/pull/14566#discussion_r1363095438 ## clients/src/main/java/org/apache/kafka/clients/ClientTelemetryState.java: ## @@ -0,0 +1,167 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] KAFKA-15616: Client telemetry states and transition (KIP-714) [kafka]

philipnee commented on code in PR #14566: URL: https://github.com/apache/kafka/pull/14566#discussion_r1363095438 ## clients/src/main/java/org/apache/kafka/clients/ClientTelemetryState.java: ## @@ -0,0 +1,167 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] KAFKA-15616: Client telemetry states and transition (KIP-714) [kafka]

philipnee commented on code in PR #14566: URL: https://github.com/apache/kafka/pull/14566#discussion_r1363092161 ## clients/src/main/java/org/apache/kafka/clients/ClientTelemetryState.java: ## @@ -0,0 +1,167 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] KAFKA-15276: Implement partition assignment reconciliation [kafka]

kirktrue commented on code in PR #14357: URL: https://github.com/apache/kafka/pull/14357#discussion_r1363014042 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AssignmentReconciler.java: ## @@ -0,0 +1,263 @@ +/* + * Licensed to the Apache Software

Re: [PR] KAFKA-15276: Implement partition assignment reconciliation [kafka]

kirktrue commented on code in PR #14357: URL: https://github.com/apache/kafka/pull/14357#discussion_r1363013596 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AssignmentReconciler.java: ## @@ -0,0 +1,263 @@ +/* + * Licensed to the Apache Software

Re: [PR] KAFKA-15276: Implement partition assignment reconciliation [kafka]

kirktrue commented on code in PR #14357: URL: https://github.com/apache/kafka/pull/14357#discussion_r1363012138 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AssignmentReconciler.java: ## @@ -0,0 +1,263 @@ +/* + * Licensed to the Apache Software

Re: [PR] KAFKA-15276: Implement partition assignment reconciliation [kafka]

kirktrue commented on code in PR #14357: URL: https://github.com/apache/kafka/pull/14357#discussion_r1363012138 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AssignmentReconciler.java: ## @@ -0,0 +1,263 @@ +/* + * Licensed to the Apache Software

Re: [PR] KAFKA-15276: Implement partition assignment reconciliation [kafka]

kirktrue commented on code in PR #14357: URL: https://github.com/apache/kafka/pull/14357#discussion_r1363010549 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AssignmentReconciler.java: ## @@ -0,0 +1,263 @@ +/* + * Licensed to the Apache Software

Re: [PR] KAFKA-15582: Identify clean shutdown broker [kafka]

CalvinConfluent commented on code in PR #14465: URL: https://github.com/apache/kafka/pull/14465#discussion_r1362968373 ## core/src/main/scala/kafka/log/LogManager.scala: ## @@ -1409,6 +1410,32 @@ class LogManager(logDirs: Seq[File], None } } + + def

Re: [PR] KAFKA-15582: Identify clean shutdown broker [kafka]

CalvinConfluent commented on code in PR #14465: URL: https://github.com/apache/kafka/pull/14465#discussion_r1362968197 ## core/src/main/scala/kafka/log/LogManager.scala: ## @@ -1409,6 +1410,32 @@ class LogManager(logDirs: Seq[File], None } } + + def

Re: [PR] KAFKA-15582: Identify clean shutdown broker [kafka]

CalvinConfluent commented on code in PR #14465: URL: https://github.com/apache/kafka/pull/14465#discussion_r1362967900 ## core/src/main/scala/kafka/log/LogManager.scala: ## @@ -1409,6 +1410,32 @@ class LogManager(logDirs: Seq[File], None } } + + def

Re: [PR] KAFKA-15626: Replace verification guard object with an specific type [kafka]

artemlivshits commented on code in PR #14568: URL: https://github.com/apache/kafka/pull/14568#discussion_r1362959888 ## core/src/main/scala/kafka/log/UnifiedLog.scala: ## @@ -1080,9 +1080,9 @@ class UnifiedLog(@volatile var logStartOffset: Long, (updatedProducers,

Re: [PR] KAFKA-15581: Introduce ELR [kafka]

CalvinConfluent commented on code in PR #14312: URL: https://github.com/apache/kafka/pull/14312#discussion_r1362959182 ## server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java: ## @@ -186,7 +186,10 @@ public enum MetadataVersion { IBP_3_6_IV2(14,

Re: [PR] KAFKA-15626: Replace verification guard object with an specific type [kafka]

jolshan commented on code in PR #14568: URL: https://github.com/apache/kafka/pull/14568#discussion_r1362938647 ## core/src/main/scala/kafka/log/UnifiedLog.scala: ## @@ -1080,9 +1080,9 @@ class UnifiedLog(@volatile var logStartOffset: Long, (updatedProducers,

Re: [PR] KAFKA-15581: Introduce ELR [kafka]

cmccabe commented on code in PR #14312: URL: https://github.com/apache/kafka/pull/14312#discussion_r1362935412 ## server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java: ## @@ -186,7 +186,10 @@ public enum MetadataVersion { IBP_3_6_IV2(14, "3.6",

Re: [PR] KAFKA-15581: Introduce ELR [kafka]

cmccabe commented on code in PR #14312: URL: https://github.com/apache/kafka/pull/14312#discussion_r1362934680 ## metadata/src/main/java/org/apache/kafka/controller/ConfigurationControlManager.java: ## @@ -434,6 +434,14 @@ Map getConfigs(ConfigResource configResource) {

Re: [PR] KAFKA-15626: Replace verification guard object with an specific type [kafka]

artemlivshits commented on code in PR #14568: URL: https://github.com/apache/kafka/pull/14568#discussion_r1362920242 ## core/src/main/scala/kafka/log/UnifiedLog.scala: ## @@ -1080,9 +1080,9 @@ class UnifiedLog(@volatile var logStartOffset: Long, (updatedProducers,

Re: [PR] KAFKA-15581: Introduce ELR [kafka]

CalvinConfluent commented on code in PR #14312: URL: https://github.com/apache/kafka/pull/14312#discussion_r1362922279 ## metadata/src/main/java/org/apache/kafka/controller/PartitionChangeBuilder.java: ## @@ -362,6 +393,58 @@ private void

Re: [PR] KAFKA-15628: Refactor ConsumerRebalanceListener invocation for reuse [kafka]

kirktrue commented on PR #14565: URL: https://github.com/apache/kafka/pull/14565#issuecomment-1767347909 @dajac or @philipnee Can I get the KIP-848 tag on this, please? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] KAFKA-14884: Include check transaction is still ongoing right before append (take 2) [kafka]

ijuma commented on code in PR #13787: URL: https://github.com/apache/kafka/pull/13787#discussion_r1362920887 ## core/src/main/scala/kafka/cluster/Partition.scala: ## @@ -1279,7 +1283,7 @@ class Partition(val topicPartition: TopicPartition, } def

Re: [PR] KAFKA-14519; [1/N] Implement coordinator runtime metrics [kafka]

jolshan merged PR #14417: URL: https://github.com/apache/kafka/pull/14417 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (KAFKA-15602) Breaking change in 3.4.0 ByteBufferSerializer

[ https://issues.apache.org/jira/browse/KAFKA-15602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17776422#comment-17776422 ] Luke Kirby commented on KAFKA-15602: I think that's a pretty reasonable take, [~pnee]! Will give the

[PR] KAFKA-15626: Replace verification guard object with an specific type [kafka]

jolshan opened a new pull request, #14568: URL: https://github.com/apache/kafka/pull/14568 I've added a new class with an incrementing atomic long to represent the verification guard. Upon creation of verification guard, we will increment this value and assign it to the guard. The

Re: [PR] [WIP]KAFKA-15444: Native docker image [kafka]

ijuma commented on code in PR #14556: URL: https://github.com/apache/kafka/pull/14556#discussion_r1362884405 ## docker/test/requirements.txt: ## @@ -0,0 +1,6 @@ +confluent_kafka Review Comment: Can we not use the CLI tools that are included in the Apache Kafka project?

Re: [PR] KAFKA-15616: Client telemetry states and transition (KIP-714) [kafka]

apoorvmittal10 commented on code in PR #14566: URL: https://github.com/apache/kafka/pull/14566#discussion_r1362871568 ## clients/src/main/java/org/apache/kafka/clients/ClientTelemetryState.java: ## @@ -0,0 +1,167 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] KAFKA-15616: Client telemetry states and transition (KIP-714) [kafka]

apoorvmittal10 commented on code in PR #14566: URL: https://github.com/apache/kafka/pull/14566#discussion_r1362858382 ## clients/src/main/java/org/apache/kafka/common/errors/IllegalClientTelemetryStateException.java: ## @@ -0,0 +1,26 @@ +/* + * Licensed to the Apache Software

Re: [PR] KAFKA-15616: Client telemetry states and transition (KIP-714) [kafka]

apoorvmittal10 commented on code in PR #14566: URL: https://github.com/apache/kafka/pull/14566#discussion_r1362852365 ## clients/src/main/java/org/apache/kafka/clients/ClientTelemetryState.java: ## @@ -0,0 +1,167 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] KAFKA-15093: Add 3.4 and 3.5 Streams upgrade system tests [kafka]

mjsax commented on PR #13860: URL: https://github.com/apache/kafka/pull/13860#issuecomment-1767260687 > I rebased this PR on trunk https://github.com/apache/kafka/pull/14539 is not merged yet... So that's expected I guess. -- We actually also just found another bug that was fixed in

Re: [PR] KAFKA-15616: Client telemetry states and transition (KIP-714) [kafka]

mjsax commented on code in PR #14566: URL: https://github.com/apache/kafka/pull/14566#discussion_r1362827605 ## clients/src/main/java/org/apache/kafka/clients/ClientTelemetryState.java: ## @@ -0,0 +1,167 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

[jira] [Commented] (KAFKA-14132) Remaining PowerMock to Mockito tests

[ https://issues.apache.org/jira/browse/KAFKA-14132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17776407#comment-17776407 ] Matthew de Detrich commented on KAFKA-14132: [~ChrisEgerton] Feel free to leave it

Re: [PR] KAFKA-15582: Identify clean shutdown broker [kafka]

junrao commented on code in PR #14465: URL: https://github.com/apache/kafka/pull/14465#discussion_r1362791793 ## core/src/main/scala/kafka/log/LogManager.scala: ## @@ -1409,6 +1410,32 @@ class LogManager(logDirs: Seq[File], None } } + + def

Re: [PR] KAFKA-15581: Introduce ELR [kafka]

artemlivshits commented on code in PR #14312: URL: https://github.com/apache/kafka/pull/14312#discussion_r1362802596 ## metadata/src/main/java/org/apache/kafka/controller/PartitionChangeBuilder.java: ## @@ -362,6 +393,58 @@ private void

Re: [PR] KAFKA-15276: Implement partition assignment reconciliation [kafka]

kirktrue commented on code in PR #14357: URL: https://github.com/apache/kafka/pull/14357#discussion_r1362776957 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java: ## @@ -248,4 +261,28 @@ public void

Re: [PR] KAFKA-15581: Introduce ELR [kafka]

CalvinConfluent commented on code in PR #14312: URL: https://github.com/apache/kafka/pull/14312#discussion_r1362774389 ## metadata/src/main/java/org/apache/kafka/controller/ConfigurationControlManager.java: ## @@ -434,6 +434,14 @@ Map getConfigs(ConfigResource configResource)

Re: [PR] KAFKA-15581: Introduce ELR [kafka]

artemlivshits commented on code in PR #14312: URL: https://github.com/apache/kafka/pull/14312#discussion_r1362773250 ## metadata/src/main/java/org/apache/kafka/controller/PartitionChangeBuilder.java: ## @@ -362,6 +405,35 @@ private void

Re: [PR] KAFKA-15581: Introduce ELR [kafka]

CalvinConfluent commented on code in PR #14312: URL: https://github.com/apache/kafka/pull/14312#discussion_r1362759943 ## metadata/src/main/java/org/apache/kafka/controller/ClusterControlManager.java: ## @@ -244,6 +251,11 @@ boolean check() { */ private final boolean

[jira] [Updated] (KAFKA-14683) Replace EasyMock and PowerMock with Mockito in WorkerSinkTaskTest

[ https://issues.apache.org/jira/browse/KAFKA-14683?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma updated KAFKA-14683: Fix Version/s: 3.7.0 > Replace EasyMock and PowerMock with Mockito in WorkerSinkTaskTest >

[jira] [Commented] (KAFKA-6520) When a Kafka Stream can't communicate with the server, it's Status stays RUNNING

[ https://issues.apache.org/jira/browse/KAFKA-6520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17776381#comment-17776381 ] Matthias J. Sax commented on KAFKA-6520: Could we use Admin.describeCluster() which returns the

Re: [PR] KAFKA-15613: Client API definition and configurations (KIP-714) [kafka]

apoorvmittal10 commented on code in PR #14560: URL: https://github.com/apache/kafka/pull/14560#discussion_r1362737991 ## clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java: ## @@ -4385,6 +4385,11 @@ public FenceProducersResult fenceProducers(Collection

Re: [PR] KAFKA-15613: Client API definition and configurations (KIP-714) [kafka]

apoorvmittal10 commented on code in PR #14560: URL: https://github.com/apache/kafka/pull/14560#discussion_r1362736361 ## clients/src/main/java/org/apache/kafka/clients/admin/Admin.java: ## @@ -1660,6 +1663,34 @@ default FenceProducersResult fenceProducers(Collection

Re: [PR] KAFKA-14884: Include check transaction is still ongoing right before append (take 2) [kafka]

artemlivshits commented on code in PR #13787: URL: https://github.com/apache/kafka/pull/13787#discussion_r1362733029 ## core/src/main/scala/kafka/cluster/Partition.scala: ## @@ -1279,7 +1283,7 @@ class Partition(val topicPartition: TopicPartition, } def

Re: [PR] KAFKA-15613: Client API definition and configurations (KIP-714) [kafka]

apoorvmittal10 commented on code in PR #14560: URL: https://github.com/apache/kafka/pull/14560#discussion_r1362732755 ## clients/src/main/java/org/apache/kafka/clients/admin/Admin.java: ## @@ -1660,6 +1663,34 @@ default FenceProducersResult fenceProducers(Collection

Re: [PR] KAFKA-15613: Client API definition and configurations (KIP-714) [kafka]

apoorvmittal10 commented on code in PR #14560: URL: https://github.com/apache/kafka/pull/14560#discussion_r1362731201 ## clients/src/main/java/org/apache/kafka/clients/admin/Admin.java: ## @@ -1660,6 +1663,34 @@ default FenceProducersResult fenceProducers(Collection

Re: [PR] KAFKA-15616: Client telemetry states and transition (KIP-714) [kafka]

apoorvmittal10 commented on code in PR #14566: URL: https://github.com/apache/kafka/pull/14566#discussion_r1362714998 ## clients/src/main/java/org/apache/kafka/clients/ClientTelemetryState.java: ## @@ -0,0 +1,169 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] KAFKA-15616: Client telemetry states and transition (KIP-714) [kafka]

apoorvmittal10 commented on code in PR #14566: URL: https://github.com/apache/kafka/pull/14566#discussion_r1362709895 ## clients/src/main/java/org/apache/kafka/common/errors/IllegalClientTelemetryStateException.java: ## @@ -0,0 +1,28 @@ +/* + * Licensed to the Apache Software

Re: [PR] KAFKA-15616: Client telemetry states and transition (KIP-714) [kafka]

apoorvmittal10 commented on code in PR #14566: URL: https://github.com/apache/kafka/pull/14566#discussion_r1362708196 ## clients/src/main/java/org/apache/kafka/clients/ClientTelemetryState.java: ## @@ -0,0 +1,169 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] Metadata schema checker [kafka]

cmccabe commented on code in PR #14389: URL: https://github.com/apache/kafka/pull/14389#discussion_r1362705401 ## tools/src/main/java/org/apache/kafka/tools/SchemaChecker/MetadataSchemaChecker.java: ## @@ -0,0 +1,347 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] Metadata schema checker [kafka]

cmccabe commented on code in PR #14389: URL: https://github.com/apache/kafka/pull/14389#discussion_r1362704344 ## tools/src/main/java/org/apache/kafka/tools/SchemaChecker/MetadataSchemaChecker.java: ## @@ -0,0 +1,347 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] Metadata schema checker [kafka]

cmccabe commented on code in PR #14389: URL: https://github.com/apache/kafka/pull/14389#discussion_r1362703702 ## tools/src/main/java/org/apache/kafka/tools/SchemaChecker/MetadataSchemaChecker.java: ## @@ -0,0 +1,347 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[jira] [Commented] (KAFKA-14132) Remaining PowerMock to Mockito tests

[ https://issues.apache.org/jira/browse/KAFKA-14132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17776375#comment-17776375 ] Hector Geraldino commented on KAFKA-14132: -- I think we can set the target to KAFKA-14683 as

Re: [PR] Metadata schema checker [kafka]

cmccabe commented on code in PR #14389: URL: https://github.com/apache/kafka/pull/14389#discussion_r1362702777 ## tools/src/main/java/org/apache/kafka/tools/SchemaChecker/MetadataSchemaChecker.java: ## @@ -0,0 +1,347 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] Metadata schema checker [kafka]

cmccabe commented on code in PR #14389: URL: https://github.com/apache/kafka/pull/14389#discussion_r1362702954 ## tools/src/main/java/org/apache/kafka/tools/SchemaChecker/MetadataSchemaChecker.java: ## @@ -0,0 +1,347 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] Metadata schema checker [kafka]

cmccabe commented on code in PR #14389: URL: https://github.com/apache/kafka/pull/14389#discussion_r1362702312 ## tools/src/main/java/org/apache/kafka/tools/SchemaChecker/MetadataSchemaChecker.java: ## @@ -0,0 +1,347 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] Metadata schema checker [kafka]

cmccabe commented on code in PR #14389: URL: https://github.com/apache/kafka/pull/14389#discussion_r1362701664 ## tools/src/main/java/org/apache/kafka/tools/SchemaChecker/MetadataSchemaChecker.java: ## @@ -0,0 +1,347 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] Metadata schema checker [kafka]

cmccabe commented on code in PR #14389: URL: https://github.com/apache/kafka/pull/14389#discussion_r1362700793 ## tools/src/main/java/org/apache/kafka/tools/SchemaChecker/MetadataSchemaChecker.java: ## @@ -0,0 +1,347 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] KAFKA-15604: Telemetry API request and response schemas and classes (KIP-714) [kafka]

apoorvmittal10 commented on code in PR #14554: URL: https://github.com/apache/kafka/pull/14554#discussion_r1362700550 ## core/src/test/scala/unit/kafka/server/KafkaApisTest.scala: ## @@ -6222,4 +6222,62 @@ class KafkaApisTest { assertEquals(expectedResponse,

Re: [PR] Metadata schema checker [kafka]

cmccabe commented on code in PR #14389: URL: https://github.com/apache/kafka/pull/14389#discussion_r1362700044 ## tools/src/main/java/org/apache/kafka/tools/SchemaChecker/MetadataSchemaChecker.java: ## @@ -0,0 +1,347 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] Metadata schema checker [kafka]

cmccabe commented on code in PR #14389: URL: https://github.com/apache/kafka/pull/14389#discussion_r1362699472 ## tools/src/main/java/org/apache/kafka/tools/SchemaChecker/MetadataSchemaChecker.java: ## @@ -0,0 +1,347 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] KAFKA-15604: Telemetry API request and response schemas and classes (KIP-714) [kafka]

apoorvmittal10 commented on code in PR #14554: URL: https://github.com/apache/kafka/pull/14554#discussion_r1362698415 ## clients/src/test/java/org/apache/kafka/common/requests/PushTelemetryResponseTest.java: ## @@ -0,0 +1,53 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] KAFKA-15604: Telemetry API request and response schemas and classes (KIP-714) [kafka]

apoorvmittal10 commented on code in PR #14554: URL: https://github.com/apache/kafka/pull/14554#discussion_r1362698016 ## clients/src/test/java/org/apache/kafka/common/requests/GetTelemetrySubscriptionsResponseTest.java: ## @@ -0,0 +1,52 @@ +/* + * Licensed to the Apache

Re: [PR] KAFKA-15604: Telemetry API request and response schemas and classes (KIP-714) [kafka]

apoorvmittal10 commented on code in PR #14554: URL: https://github.com/apache/kafka/pull/14554#discussion_r1362697604 ## clients/src/test/java/org/apache/kafka/common/requests/GetTelemetrySubscriptionsResponseTest.java: ## @@ -0,0 +1,52 @@ +/* + * Licensed to the Apache

Re: [PR] KAFKA-15604: Telemetry API request and response schemas and classes (KIP-714) [kafka]

apoorvmittal10 commented on code in PR #14554: URL: https://github.com/apache/kafka/pull/14554#discussion_r1362696790 ## clients/src/main/java/org/apache/kafka/common/requests/PushTelemetryRequest.java: ## @@ -0,0 +1,78 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] KAFKA-15604: Telemetry API request and response schemas and classes (KIP-714) [kafka]

apoorvmittal10 commented on code in PR #14554: URL: https://github.com/apache/kafka/pull/14554#discussion_r1362690914 ## core/src/test/scala/unit/kafka/server/KafkaApisTest.scala: ## @@ -6222,4 +6222,62 @@ class KafkaApisTest { assertEquals(expectedResponse,

Re: [PR] KAFKA-15276: Implement partition assignment reconciliation [kafka]

lianetm commented on code in PR #14357: URL: https://github.com/apache/kafka/pull/14357#discussion_r1362685795 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java: ## @@ -248,4 +261,28 @@ public void

Re: [PR] KAFKA-15604: Telemetry API request and response schemas and classes (KIP-714) [kafka]

apoorvmittal10 commented on code in PR #14554: URL: https://github.com/apache/kafka/pull/14554#discussion_r1362679708 ## clients/src/test/java/org/apache/kafka/common/protocol/ProtoUtilsTest.java: ## @@ -34,6 +34,7 @@ public void testDelayedAllocationSchemaDetection() {

Re: [PR] KAFKA-15604: Telemetry API request and response schemas and classes (KIP-714) [kafka]

apoorvmittal10 commented on code in PR #14554: URL: https://github.com/apache/kafka/pull/14554#discussion_r1362670208 ## clients/src/main/resources/common/message/GetTelemetrySubscriptionsRequest.json: ## @@ -0,0 +1,33 @@ +// Licensed to the Apache Software Foundation (ASF)

Re: [PR] KAFKA-15604: Telemetry API request and response schemas and classes (KIP-714) [kafka]

apoorvmittal10 commented on code in PR #14554: URL: https://github.com/apache/kafka/pull/14554#discussion_r1362665976 ## clients/src/main/resources/common/message/GetTelemetrySubscriptionsRequest.json: ## @@ -0,0 +1,33 @@ +// Licensed to the Apache Software Foundation (ASF)

Re: [PR] Kip951 client changes [kafka]

AndrewJSchofield commented on code in PR #14564: URL: https://github.com/apache/kafka/pull/14564#discussion_r1362664111 ## clients/src/main/java/org/apache/kafka/clients/Metadata.java: ## @@ -350,6 +353,92 @@ public synchronized void update(int requestVersion, MetadataResponse

Re: [PR] KAFKA-15604: Telemetry API request and response schemas and classes (KIP-714) [kafka]

apoorvmittal10 commented on code in PR #14554: URL: https://github.com/apache/kafka/pull/14554#discussion_r1362662718 ## clients/src/main/java/org/apache/kafka/common/requests/GetTelemetrySubscriptionsRequest.java: ## @@ -0,0 +1,79 @@ +/* + * Licensed to the Apache Software

Re: [PR] KAFKA-15604: Telemetry API request and response schemas and classes (KIP-714) [kafka]

apoorvmittal10 commented on code in PR #14554: URL: https://github.com/apache/kafka/pull/14554#discussion_r1362658016 ## core/src/test/scala/unit/kafka/server/KafkaApisTest.scala: ## @@ -6222,4 +6222,62 @@ class KafkaApisTest { assertEquals(expectedResponse,

Re: [PR] KAFKA-15613: Client API definition and configurations (KIP-714) [kafka]

mjsax commented on code in PR #14560: URL: https://github.com/apache/kafka/pull/14560#discussion_r1362644942 ## clients/src/main/java/org/apache/kafka/clients/admin/Admin.java: ## @@ -1660,6 +1663,34 @@ default FenceProducersResult fenceProducers(Collection transactionalIds)

Re: [PR] KAFKA-15604: Telemetry API request and response schemas and classes (KIP-714) [kafka]

apoorvmittal10 commented on code in PR #14554: URL: https://github.com/apache/kafka/pull/14554#discussion_r1362652533 ## core/src/test/scala/unit/kafka/server/KafkaApisTest.scala: ## @@ -6222,4 +6222,62 @@ class KafkaApisTest { assertEquals(expectedResponse,

[PR] KAFKA-13988: Enable replicating from latest with MirrorMaker 2 [kafka]

C0urante opened a new pull request, #14567: URL: https://github.com/apache/kafka/pull/14567 [Jira](https://issues.apache.org/jira/browse/KAFKA-13988) Based off of https://github.com/apache/kafka/pull/13905, which itself appears to be based off of

Re: [PR] KAFKA-13988: Fix MM2 not consuming from latest when "auto.offset.reset=latest" is set [kafka]

C0urante commented on PR #13905: URL: https://github.com/apache/kafka/pull/13905#issuecomment-1767027696 @electrical @showuon @blacktooth I've published https://github.com/apache/kafka/pull/14567, which is based off this PR and contains the suggestions I proposed during code review

Re: [PR] KAFKA-15613: Client API definition and configurations (KIP-714) [kafka]

mjsax commented on code in PR #14560: URL: https://github.com/apache/kafka/pull/14560#discussion_r1362638521 ## clients/src/main/java/org/apache/kafka/clients/admin/Admin.java: ## @@ -1660,6 +1663,34 @@ default FenceProducersResult fenceProducers(Collection transactionalIds)

Re: [PR] KAFKA-15613: Client API definition and configurations (KIP-714) [kafka]

mjsax commented on code in PR #14560: URL: https://github.com/apache/kafka/pull/14560#discussion_r1362638521 ## clients/src/main/java/org/apache/kafka/clients/admin/Admin.java: ## @@ -1660,6 +1663,34 @@ default FenceProducersResult fenceProducers(Collection transactionalIds)

Re: [PR] KAFKA-15616: Client telemetry states and transition (KIP-714) [kafka]

AndrewJSchofield commented on code in PR #14566: URL: https://github.com/apache/kafka/pull/14566#discussion_r1362631340 ## clients/src/main/java/org/apache/kafka/clients/ClientTelemetryState.java: ## @@ -0,0 +1,169 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[jira] [Assigned] (KAFKA-13988) Mirrormaker 2 auto.offset.reset=latest not working

[ https://issues.apache.org/jira/browse/KAFKA-13988?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Egerton reassigned KAFKA-13988: - Assignee: Chris Egerton (was: Ravindranath Kakarla) > Mirrormaker 2

  1   2   3   >