showuon commented on code in PR #14576:
URL: https://github.com/apache/kafka/pull/14576#discussion_r1369627969
##
storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/RemoteLogMetadataCache.java:
##
@@ -157,13 +157,20 @@ public void
philipnee commented on code in PR #14617:
URL: https://github.com/apache/kafka/pull/14617#discussion_r1369600869
##
clients/src/main/java/org/apache/kafka/common/serialization/ByteBufferSerializer.java:
##
@@ -16,38 +16,34 @@
*/
package org.apache.kafka.common.serialization;
[
https://issues.apache.org/jira/browse/KAFKA-15602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17778913#comment-17778913
]
Philip Nee commented on KAFKA-15602:
Thanks, [~luke.kirby] - Can you create a Jira to document what
hudeqi commented on PR #14610:
URL: https://github.com/apache/kafka/pull/14610#issuecomment-1776463505
> @hudeqi Are you OK with merging this?
I'm ok, but need other commiters to merge. @showuon
--
This is an automated message from the Apache Git Service.
To respond to the
nizhikov commented on PR #14610:
URL: https://github.com/apache/kafka/pull/14610#issuecomment-1776460338
@hudeqi Are you OK with merging this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
hudeqi commented on PR #14483:
URL: https://github.com/apache/kafka/pull/14483#issuecomment-1776392320
> > @jeel2420
[
https://issues.apache.org/jira/browse/KAFKA-15675?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-15675:
--
Labels: flaky-test (was: )
> Fix flaky
>
kirktrue closed pull request #14406: KAFKA-14274 [6, 7]: Introduction of fetch
request manager
URL: https://github.com/apache/kafka/pull/14406
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
kirktrue commented on PR #14406:
URL: https://github.com/apache/kafka/pull/14406#issuecomment-1776378053
Closing and reopening to restart test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
kirktrue commented on PR #14406:
URL: https://github.com/apache/kafka/pull/14406#issuecomment-1776377391
Ugh. One of the builds failed with:
```
ERROR: Error fetching remote repo 'origin'
hudson.plugins.git.GitException: Failed to fetch from
https://github.com/apache/kafka.git
[
https://issues.apache.org/jira/browse/KAFKA-15388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17778884#comment-17778884
]
Arpit Goyal commented on KAFKA-15388:
-
[~divijvaidya] Sure I am picking it up.
> Handle topics that
[
https://issues.apache.org/jira/browse/KAFKA-15388?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Arpit Goyal reassigned KAFKA-15388:
---
Assignee: Arpit Goyal
> Handle topics that were having compaction as retention earlier are
bachmanity1 commented on code in PR #14410:
URL: https://github.com/apache/kafka/pull/14410#discussion_r1368465903
##
streams/src/test/java/org/apache/kafka/streams/state/internals/GlobalStateStoreProviderTest.java:
##
@@ -105,28 +105,19 @@ public void before() {
apoorvmittal10 commented on code in PR #14621:
URL: https://github.com/apache/kafka/pull/14621#discussion_r1369416326
##
core/src/main/scala/kafka/metrics/clientmetrics/ClientMetricsConfig.scala:
##
@@ -0,0 +1,137 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF)
apoorvmittal10 commented on code in PR #14621:
URL: https://github.com/apache/kafka/pull/14621#discussion_r1369415500
##
core/src/main/scala/kafka/server/ClientMetricsManager.scala:
##
@@ -0,0 +1,38 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
apoorvmittal10 commented on code in PR #14621:
URL: https://github.com/apache/kafka/pull/14621#discussion_r1369413838
##
core/src/main/scala/kafka/server/ClientMetricsManager.scala:
##
@@ -0,0 +1,38 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
apoorvmittal10 opened a new pull request, #14621:
URL: https://github.com/apache/kafka/pull/14621
This PR add resources to store and handle client metrics needed for KIP-714
as defined
[
https://issues.apache.org/jira/browse/KAFKA-15673?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Apoorv Mittal updated KAFKA-15673:
--
Description:
The KIP-714 introduces new resource type named CLIENT_METRICS -
cmccabe commented on code in PR #14545:
URL: https://github.com/apache/kafka/pull/14545#discussion_r1369368851
##
core/src/main/scala/kafka/zk/migration/ZkTopicMigrationClient.scala:
##
@@ -47,8 +47,14 @@ class ZkTopicMigrationClient(zkClient: KafkaZkClient)
extends
cmccabe commented on PR #14545:
URL: https://github.com/apache/kafka/pull/14545#issuecomment-1776180980
oh, and please remove the thing where we log all deleting topic names … if
it’s too much effort, just log the # . We don't want to blow up our log4j files
--
This is an automated
cmccabe commented on code in PR #14545:
URL: https://github.com/apache/kafka/pull/14545#discussion_r1369366766
##
clients/src/main/java/org/apache/kafka/common/requests/LeaderAndIsrRequest.java:
##
@@ -42,26 +42,52 @@
public class LeaderAndIsrRequest extends
cmccabe commented on code in PR #14545:
URL: https://github.com/apache/kafka/pull/14545#discussion_r1369366766
##
clients/src/main/java/org/apache/kafka/common/requests/LeaderAndIsrRequest.java:
##
@@ -42,26 +42,52 @@
public class LeaderAndIsrRequest extends
junrao commented on code in PR #13451:
URL: https://github.com/apache/kafka/pull/13451#discussion_r1369359298
##
core/src/main/scala/kafka/controller/KafkaController.scala:
##
@@ -1894,10 +1894,16 @@ class KafkaController(val config: KafkaConfig,
val currentAssignment =
junrao commented on code in PR #13451:
URL: https://github.com/apache/kafka/pull/13451#discussion_r1369359298
##
core/src/main/scala/kafka/controller/KafkaController.scala:
##
@@ -1894,10 +1894,16 @@ class KafkaController(val config: KafkaConfig,
val currentAssignment =
junrao commented on code in PR #13451:
URL: https://github.com/apache/kafka/pull/13451#discussion_r1369359298
##
core/src/main/scala/kafka/controller/KafkaController.scala:
##
@@ -1894,10 +1894,16 @@ class KafkaController(val config: KafkaConfig,
val currentAssignment =
pprovenzano commented on code in PR #14578:
URL: https://github.com/apache/kafka/pull/14578#discussion_r1369329881
##
core/src/main/scala/kafka/server/KafkaServer.scala:
##
@@ -1025,9 +1026,13 @@ class KafkaServer(
*/
private def checkpointBrokerMetadata(brokerMetadata:
[
https://issues.apache.org/jira/browse/KAFKA-15643?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ritika Muduganti reassigned KAFKA-15643:
Assignee: Ritika Muduganti
> Improve unloading logging
>
pprovenzano commented on code in PR #14578:
URL: https://github.com/apache/kafka/pull/14578#discussion_r1369328666
##
core/src/main/scala/kafka/server/BrokerMetadataCheckpoint.scala:
##
@@ -166,6 +166,7 @@ case class MetaProperties(
}
}
+// Return only the
kirktrue opened a new pull request, #14406:
URL: https://github.com/apache/kafka/pull/14406
Changes:
1. Introduces `FetchRequestManager` that implements the `RequestManager` API
for fetching messages from brokers. Unlike `Fetcher`, record decompression and
deserialization is
kirktrue commented on PR #14406:
URL: https://github.com/apache/kafka/pull/14406#issuecomment-1776110492
Closing and reopening to trigger another Jenkins test run.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
kirktrue closed pull request #14406: KAFKA-14274 [6, 7]: Introduction of fetch
request manager
URL: https://github.com/apache/kafka/pull/14406
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
kirktrue commented on PR #14406:
URL: https://github.com/apache/kafka/pull/14406#issuecomment-1776108652
> Are the 30 test failures related?
No, I do not believe they are.
There are 8 failures, of which two are the same test with different
parameters. Here are the tests and
Kirk True created KAFKA-15675:
-
Summary: Fix flaky
ConnectorRestartApiIntegrationTest.testMultiWorkerRestartOnlyConnector() test
Key: KAFKA-15675
URL: https://issues.apache.org/jira/browse/KAFKA-15675
[
https://issues.apache.org/jira/browse/KAFKA-15674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17778835#comment-17778835
]
Jun Rao commented on KAFKA-15674:
-
For context, [https://github.com/apache/kafka/pull/9220] was the
[
https://issues.apache.org/jira/browse/KAFKA-15653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17778831#comment-17778831
]
Justine Olshan commented on KAFKA-15653:
I will definitely work on this [~divijvaidya].
I plan
Justine Olshan created KAFKA-15674:
--
Summary: Consider making RequestLocal thread safe
Key: KAFKA-15674
URL: https://issues.apache.org/jira/browse/KAFKA-15674
Project: Kafka
Issue Type:
[
https://issues.apache.org/jira/browse/KAFKA-15653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Justine Olshan reassigned KAFKA-15653:
--
Assignee: Justine Olshan
> NPE in ChunkedByteStream
>
>
>
rondagostino commented on code in PR #14290:
URL: https://github.com/apache/kafka/pull/14290#discussion_r1368928056
##
metadata/src/main/resources/common/metadata/BrokerRegistrationChangeRecord.json:
##
@@ -13,11 +13,12 @@
// See the License for the specific language governing
[
https://issues.apache.org/jira/browse/KAFKA-15656?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Travis Bischel resolved KAFKA-15656.
Resolution: Duplicate
Closing this as a different manifestation of (and thus, duplicate
[
https://issues.apache.org/jira/browse/KAFKA-15657?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Travis Bischel resolved KAFKA-15657.
Resolution: Duplicate
Closing this as a different manifestation (and thus, duplicate of)
[
https://issues.apache.org/jira/browse/KAFKA-15653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17778827#comment-17778827
]
Travis Bischel commented on KAFKA-15653:
I've loop tested this a few times at this point, and so
Apoorv Mittal created KAFKA-15673:
-
Summary: Define new client_metrics resource type configuration to
store metric config.
Key: KAFKA-15673
URL: https://issues.apache.org/jira/browse/KAFKA-15673
apoorvmittal10 commented on code in PR #14619:
URL: https://github.com/apache/kafka/pull/14619#discussion_r1369241432
##
clients/src/test/java/org/apache/kafka/common/telemetry/internals/MetricNamingConventionTest.java:
##
@@ -0,0 +1,196 @@
+/*
+ * Licensed to the Apache
kirktrue commented on PR #14565:
URL: https://github.com/apache/kafka/pull/14565#issuecomment-1775972229
@dajac This is ready for another review. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
AndrewJSchofield commented on code in PR #14619:
URL: https://github.com/apache/kafka/pull/14619#discussion_r1369227989
##
clients/src/test/java/org/apache/kafka/common/telemetry/internals/MetricNamingConventionTest.java:
##
@@ -0,0 +1,196 @@
+/*
+ * Licensed to the Apache
[
https://issues.apache.org/jira/browse/KAFKA-15401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17778807#comment-17778807
]
Jun Rao commented on KAFKA-15401:
-
[~nickstery] : Thanks for reporting this issue. I am wondering how a
tombentley commented on PR #13862:
URL: https://github.com/apache/kafka/pull/13862#issuecomment-1775906514
@joobisb when I said
> It works fine for me with ``, using both
FF and a chrome-based browser.
I meant that I still don't think we need the changes which add the
[
https://issues.apache.org/jira/browse/KAFKA-15093?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mickael Maison updated KAFKA-15093:
---
Fix Version/s: (was: 3.5.2)
> Add 3.5.0 to broker/client and streams
mimaison commented on PR #14602:
URL: https://github.com/apache/kafka/pull/14602#issuecomment-1775903085
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
mimaison commented on PR #14602:
URL: https://github.com/apache/kafka/pull/14602#issuecomment-1775898581
Ok, I'll revert d769f1dd87 in the 3.5 branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
mdedetrich commented on PR #12728:
URL: https://github.com/apache/kafka/pull/12728#issuecomment-1775892079
@mimaison I started rebasing across `trunk` and under-estimated the amount
of changes that have since landed so this may take a day or two longer
--
This is an automated message
[
https://issues.apache.org/jira/browse/KAFKA-15602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17778797#comment-17778797
]
Luke Kirby commented on KAFKA-15602:
Hi [~pnee] , [~mjsax] – I largely agree with what's been said
[
https://issues.apache.org/jira/browse/KAFKA-15671?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Brian reassigned KAFKA-15671:
-
Assignee: Brian
> Flaky test RemoteIndexCacheTest.testClearCacheAndIndexFilesWhenResizeCache
>
[
https://issues.apache.org/jira/browse/KAFKA-15671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17778782#comment-17778782
]
Divij Vaidya commented on KAFKA-15671:
--
Sure [~brian030128] , please go ahead and assign it to
[
https://issues.apache.org/jira/browse/KAFKA-15542?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True reassigned KAFKA-15542:
-
Assignee: Kirk True
> Release member assignments on errors
>
kamalcph commented on code in PR #14576:
URL: https://github.com/apache/kafka/pull/14576#discussion_r1369070287
##
storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/RemoteLogMetadataCache.java:
##
@@ -157,13 +157,20 @@ public void
[
https://issues.apache.org/jira/browse/KAFKA-15574?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True reassigned KAFKA-15574:
-
Assignee: Kirk True
> Integrate partition assignment reconciliation with heartbeat request
kamalcph commented on code in PR #14576:
URL: https://github.com/apache/kafka/pull/14576#discussion_r1369070287
##
storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/RemoteLogMetadataCache.java:
##
@@ -157,13 +157,20 @@ public void
kamalcph commented on code in PR #14576:
URL: https://github.com/apache/kafka/pull/14576#discussion_r1369070287
##
storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/RemoteLogMetadataCache.java:
##
@@ -157,13 +157,20 @@ public void
kamalcph commented on code in PR #14576:
URL: https://github.com/apache/kafka/pull/14576#discussion_r1367695583
##
storage/src/test/java/org/apache/kafka/server/log/remote/metadata/storage/RemoteLogMetadataCacheTest.java:
##
@@ -26,83 +26,136 @@
import
CalvinConfluent commented on code in PR #14593:
URL: https://github.com/apache/kafka/pull/14593#discussion_r1369069244
##
metadata/src/main/java/org/apache/kafka/controller/PartitionChangeBuilder.java:
##
@@ -253,17 +269,30 @@ private ElectionResult electAnyLeader() {
CalvinConfluent commented on code in PR #14593:
URL: https://github.com/apache/kafka/pull/14593#discussion_r1369067852
##
metadata/src/main/java/org/apache/kafka/controller/PartitionChangeBuilder.java:
##
@@ -253,17 +269,30 @@ private ElectionResult electAnyLeader() {
[
https://issues.apache.org/jira/browse/KAFKA-15671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17778777#comment-17778777
]
Brian commented on KAFKA-15671:
---
[~divijvaidya] Hello I'm new to this project, can I give it a try?
>
[ https://issues.apache.org/jira/browse/KAFKA-15672 ]
Brian deleted comment on KAFKA-15672:
---
was (Author: JIRAUSER302723):
I could work on this, can you assign it to me?
> Add 3.6 to streams system tests
> ---
>
>
[
https://issues.apache.org/jira/browse/KAFKA-15672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17778771#comment-17778771
]
Brian commented on KAFKA-15672:
---
I could work on this, can you assign it to me?
> Add 3.6 to streams
[
https://issues.apache.org/jira/browse/KAFKA-15653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Divij Vaidya reassigned KAFKA-15653:
Assignee: (was: Divij Vaidya)
> NPE in ChunkedByteStream
>
CalvinConfluent commented on code in PR #14593:
URL: https://github.com/apache/kafka/pull/14593#discussion_r1369023859
##
metadata/src/main/java/org/apache/kafka/controller/PartitionChangeBuilder.java:
##
@@ -253,17 +269,30 @@ private ElectionResult electAnyLeader() {
ijuma commented on code in PR #14603:
URL: https://github.com/apache/kafka/pull/14603#discussion_r1369015980
##
storage/src/main/java/org/apache/kafka/storage/internals/util/CleanShutdownFileHandler.java:
##
@@ -85,6 +85,7 @@ void write(long brokerEpoch, int version) throws
ijuma commented on code in PR #14603:
URL: https://github.com/apache/kafka/pull/14603#discussion_r1369013666
##
storage/src/main/java/org/apache/kafka/storage/internals/util/CleanShutdownFileHandler.java:
##
@@ -15,7 +15,7 @@
* limitations under the License.
*/
-package
CalvinConfluent commented on code in PR #14593:
URL: https://github.com/apache/kafka/pull/14593#discussion_r1369012157
##
metadata/src/main/java/org/apache/kafka/controller/PartitionChangeBuilder.java:
##
@@ -93,6 +93,9 @@ public enum Election {
private boolean
CalvinConfluent commented on code in PR #14603:
URL: https://github.com/apache/kafka/pull/14603#discussion_r1369010124
##
storage/src/main/java/org/apache/kafka/storage/internals/util/CleanShutdownFileHandler.java:
##
@@ -15,7 +15,7 @@
* limitations under the License.
*/
apoorvmittal10 opened a new pull request, #14620:
URL: https://github.com/apache/kafka/pull/14620
The PR ([jira](https://issues.apache.org/jira/browse/KAFKA-15618)) outlines
classes to collect metrics for client by KafkaMetricsCollector implementation.
The MetricsCollector defines
ijuma commented on code in PR #14603:
URL: https://github.com/apache/kafka/pull/14603#discussion_r1369008762
##
storage/src/main/java/org/apache/kafka/storage/internals/util/CleanShutdownFileHandler.java:
##
@@ -15,7 +15,7 @@
* limitations under the License.
*/
-package
kirktrue commented on code in PR #14565:
URL: https://github.com/apache/kafka/pull/14565#discussion_r1369002478
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinatorMetrics.java:
##
@@ -0,0 +1,80 @@
+/*
+ * Licensed to the Apache Software
kirktrue commented on code in PR #14565:
URL: https://github.com/apache/kafka/pull/14565#discussion_r1368991272
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerRebalanceListenerInvoker.java:
##
@@ -0,0 +1,128 @@
+/*
+ * Licensed to the Apache
mjsax commented on PR #14602:
URL: https://github.com/apache/kafka/pull/14602#issuecomment-1775630277
I think it would be good to revert? System test run already very long, and
if we can cut down a few minutes by not re-running the same test twice, it
might be good?
--
This is an
kirktrue commented on code in PR #14565:
URL: https://github.com/apache/kafka/pull/14565#discussion_r1368990080
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java:
##
@@ -227,6 +224,12 @@ public ConsumerCoordinator(GroupRebalanceConfig
kirktrue commented on code in PR #14565:
URL: https://github.com/apache/kafka/pull/14565#discussion_r1368989675
##
clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java:
##
@@ -961,7 +960,7 @@ public void subscribe(Collection topics,
apoorvmittal10 opened a new pull request, #14619:
URL: https://github.com/apache/kafka/pull/14619
The PR defined the naming convention for telemetry metric names for KIP-714.
Telemetry metric name should be dot separated and tags should be snake case.
PR adds the interface which will
apoorvmittal10 opened a new pull request, #14618:
URL: https://github.com/apache/kafka/pull/14618
The PR comprises of changes to include opentlemetry library as defined in
KIP-714. The libraries are shadowed to prevent conflicts.
```
jar -tf kafka-clients-3.7.0-SNAPSHOT.jar | grep
CalvinConfluent commented on PR #14603:
URL: https://github.com/apache/kafka/pull/14603#issuecomment-1775608992
@junrao @ijuma Now the build success with irrelevant test failures.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
[
https://issues.apache.org/jira/browse/KAFKA-14767?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Greg Harris updated KAFKA-14767:
Fix Version/s: 3.4.2
3.5.2
3.6.1
> Gradle build fails with
philipnee commented on code in PR #14617:
URL: https://github.com/apache/kafka/pull/14617#discussion_r1368954689
##
clients/src/main/java/org/apache/kafka/common/serialization/ByteBufferSerializer.java:
##
@@ -16,38 +16,32 @@
*/
package org.apache.kafka.common.serialization;
splett2 commented on code in PR #14485:
URL: https://github.com/apache/kafka/pull/14485#discussion_r1368951497
##
storage/src/main/java/org/apache/kafka/storage/internals/log/LogAppendInfo.java:
##
@@ -204,6 +204,10 @@ public LeaderHwChange leaderHwChange() {
return
[
https://issues.apache.org/jira/browse/KAFKA-15602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17778731#comment-17778731
]
Matthias J. Sax edited comment on KAFKA-15602 at 10/23/23 4:20 PM:
---
[
https://issues.apache.org/jira/browse/KAFKA-15602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17778731#comment-17778731
]
Matthias J. Sax commented on KAFKA-15602:
-
Btw: also left a comment on K4852:
[
https://issues.apache.org/jira/browse/KAFKA-4852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17778727#comment-17778727
]
Matthias J. Sax commented on KAFKA-4852:
As reported on
[
https://issues.apache.org/jira/browse/KAFKA-15602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17778726#comment-17778726
]
Philip Nee commented on KAFKA-15602:
Great I think so. [~luke.kirby] - Do you agree? Also, do you
mjsax opened a new pull request, #14617:
URL: https://github.com/apache/kafka/pull/14617
This PR reverts
-
https://github.com/apache/kafka/commit/51dbd175b08e78aeca03d6752847aa5f23c98659
-
https://github.com/apache/kafka/commit/496ae054c2d43c0905167745bfb2f4a0725e9fc2
Also
[
https://issues.apache.org/jira/browse/KAFKA-15653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17778721#comment-17778721
]
Divij Vaidya commented on KAFKA-15653:
--
> However, there was some other way to access the bug in
[
https://issues.apache.org/jira/browse/KAFKA-15602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17778719#comment-17778719
]
Matthias J. Sax commented on KAFKA-15602:
-
Sounds fair. – Let me revert K4852 in all applicable
hanyuzheng7 commented on code in PR #14570:
URL: https://github.com/apache/kafka/pull/14570#discussion_r1368883149
##
streams/src/main/java/org/apache/kafka/streams/state/internals/MeteredKeyValueStore.java:
##
@@ -99,9 +101,17 @@ public class MeteredKeyValueStore
[
https://issues.apache.org/jira/browse/KAFKA-15666?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax resolved KAFKA-15666.
-
Resolution: Invalid
[~noraverba] – We can only take tickets in English. – Also piped
mimaison commented on PR #14602:
URL: https://github.com/apache/kafka/pull/14602#issuecomment-1775452320
Are we ok keeping the commit or should we revert it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
Matthias J. Sax created KAFKA-15672:
---
Summary: Add 3.6 to streams system tests
Key: KAFKA-15672
URL: https://issues.apache.org/jira/browse/KAFKA-15672
Project: Kafka
Issue Type: Test
mimaison commented on PR #14601:
URL: https://github.com/apache/kafka/pull/14601#issuecomment-1775449629
Ah ok, thanks for clarifying.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
[
https://issues.apache.org/jira/browse/KAFKA-15653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17778709#comment-17778709
]
Justine Olshan commented on KAFKA-15653:
Thanks [~divijvaidya] and [~ijuma] for looking at this.
mjsax commented on PR #14602:
URL: https://github.com/apache/kafka/pull/14602#issuecomment-1775443078
Why backport to `3.5` ? That's not necessary -- we test upgrade to
`DEV_VERSION` what is `3.5.x-SNAPSHOT` -- no need to double test.
--
This is an automated message from the Apache Git
mjsax commented on PR #14601:
URL: https://github.com/apache/kafka/pull/14601#issuecomment-1775440767
We don't need to backported to `3.4` branch -- In `3.4` branch we test this
implicitly by upgrading to `DEV_VERSION`.
--
This is an automated message from the Apache Git Service.
To
OmniaGM commented on code in PR #14516:
URL: https://github.com/apache/kafka/pull/14516#discussion_r1368826071
##
core/src/test/scala/integration/kafka/zk/ZkMigrationIntegrationTest.scala:
##
@@ -128,7 +128,7 @@ class ZkMigrationIntegrationTest {
val underlying =
1 - 100 of 175 matches
Mail list logo
