ijuma commented on code in PR #14671:
URL: https://github.com/apache/kafka/pull/14671#discussion_r1377053376
##
server-common/src/main/java/org/apache/kafka/common/DirectoryId.java:
##
@@ -42,29 +42,27 @@ public class DirectoryId {
public static final Uuid MIGRATING = new
CalvinConfluent commented on PR #14593:
URL: https://github.com/apache/kafka/pull/14593#issuecomment-1786438703
Failing tests are irrelevant.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
hudeqi commented on code in PR #14667:
URL: https://github.com/apache/kafka/pull/14667#discussion_r1377023677
##
core/src/main/scala/kafka/server/ReplicaManager.scala:
##
@@ -630,13 +630,17 @@ class ReplicaManager(val config: KafkaConfig,
// Third delete the logs and
[
https://issues.apache.org/jira/browse/KAFKA-15686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17781206#comment-17781206
]
Philip Nee commented on KAFKA-15686:
[~ihavenoem...@163.com] - What is the use case of knowing which
[
https://issues.apache.org/jira/browse/KAFKA-15686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17781206#comment-17781206
]
Philip Nee edited comment on KAFKA-15686 at 10/31/23 4:03 AM:
--
hudeqi commented on code in PR #14667:
URL: https://github.com/apache/kafka/pull/14667#discussion_r1377023677
##
core/src/main/scala/kafka/server/ReplicaManager.scala:
##
@@ -630,13 +630,17 @@ class ReplicaManager(val config: KafkaConfig,
// Third delete the logs and
hudeqi commented on code in PR #14667:
URL: https://github.com/apache/kafka/pull/14667#discussion_r1377023677
##
core/src/main/scala/kafka/server/ReplicaManager.scala:
##
@@ -630,13 +630,17 @@ class ReplicaManager(val config: KafkaConfig,
// Third delete the logs and
hudeqi commented on code in PR #14667:
URL: https://github.com/apache/kafka/pull/14667#discussion_r1377020873
##
core/src/main/scala/kafka/server/ReplicaManager.scala:
##
@@ -630,13 +630,17 @@ class ReplicaManager(val config: KafkaConfig,
// Third delete the logs and
kirktrue commented on PR #14672:
URL: https://github.com/apache/kafka/pull/14672#issuecomment-1786396441
@philipnee Can you add the `ctr` tag, please?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
philipnee commented on PR #14598:
URL: https://github.com/apache/kafka/pull/14598#issuecomment-1786392041
Hi @kirktrue @cadonna - Thank you for taking the time to review the PR. I
don't have a very strong opinion about the constructor, but I do want other
refactor changes so let me know
philipnee commented on PR #14642:
URL: https://github.com/apache/kafka/pull/14642#issuecomment-1786388893
Hi @dajac - Thank you for the comments. I addressed them in the latest
commits. Would you mind reviewing the changes again?
--
This is an automated message from the Apache Git
github-actions[bot] commented on PR #13530:
URL: https://github.com/apache/kafka/pull/13530#issuecomment-1786384406
This PR is being marked as stale since it has not had any activity in 90
days. If you would like to keep this PR alive, please ask a committer for
review. If the PR has
philipnee commented on code in PR #14575:
URL: https://github.com/apache/kafka/pull/14575#discussion_r1377011485
##
clients/src/main/java/org/apache/kafka/common/telemetry/internals/MetricKey.java:
##
@@ -0,0 +1,94 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
kirktrue opened a new pull request, #14672:
URL: https://github.com/apache/kafka/pull/14672
This implements the `Consumer.groupMetadata()` API by means of an event
passed to and fulfilled in the consumer network I/O thread. The application
thread will block until this event is processed
jolshan commented on code in PR #14671:
URL: https://github.com/apache/kafka/pull/14671#discussion_r1376940646
##
server-common/src/main/java/org/apache/kafka/common/DirectoryId.java:
##
@@ -42,29 +42,27 @@ public class DirectoryId {
public static final Uuid MIGRATING =
jolshan commented on code in PR #14671:
URL: https://github.com/apache/kafka/pull/14671#discussion_r1376940840
##
server-common/src/main/java/org/apache/kafka/common/DirectoryId.java:
##
@@ -42,29 +42,27 @@ public class DirectoryId {
public static final Uuid MIGRATING =
jolshan commented on code in PR #14671:
URL: https://github.com/apache/kafka/pull/14671#discussion_r1376940646
##
server-common/src/main/java/org/apache/kafka/common/DirectoryId.java:
##
@@ -42,29 +42,27 @@ public class DirectoryId {
public static final Uuid MIGRATING =
[
https://issues.apache.org/jira/browse/KAFKA-15281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True reassigned KAFKA-15281:
-
Assignee: Kirk True
> Implement the groupMetadata Consumer API
>
kirktrue commented on code in PR #14670:
URL: https://github.com/apache/kafka/pull/14670#discussion_r1376925327
##
clients/src/main/java/org/apache/kafka/clients/consumer/ConsumerConfig.java:
##
@@ -321,20 +320,6 @@ public class ConsumerConfig extends AbstractConfig {
*/
mjsax commented on code in PR #14575:
URL: https://github.com/apache/kafka/pull/14575#discussion_r1376921687
##
clients/src/main/java/org/apache/kafka/common/telemetry/internals/MetricKey.java:
##
@@ -0,0 +1,94 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
cmccabe opened a new pull request, #14671:
URL: https://github.com/apache/kafka/pull/14671
DirectoryId.random doesn't need to instantiate the first 100 IDs to check if
an ID is one of them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
junrao merged PR #14603:
URL: https://github.com/apache/kafka/pull/14603
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/KAFKA-15754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17781155#comment-17781155
]
Colin McCabe commented on KAFKA-15754:
--
{quote}
I was wondering if there is any good reason for
[
https://issues.apache.org/jira/browse/KAFKA-15754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17781152#comment-17781152
]
Colin McCabe edited comment on KAFKA-15754 at 10/30/23 11:21 PM:
-
You
[
https://issues.apache.org/jira/browse/KAFKA-15754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17781153#comment-17781153
]
Colin McCabe edited comment on KAFKA-15754 at 10/30/23 11:20 PM:
-
I am
[
https://issues.apache.org/jira/browse/KAFKA-15754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17781153#comment-17781153
]
Colin McCabe edited comment on KAFKA-15754 at 10/30/23 11:20 PM:
-
I am
[
https://issues.apache.org/jira/browse/KAFKA-15754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17781151#comment-17781151
]
Colin McCabe edited comment on KAFKA-15754 at 10/30/23 11:20 PM:
-
I ran
[
https://issues.apache.org/jira/browse/KAFKA-15754?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Colin McCabe resolved KAFKA-15754.
--
Resolution: Invalid
kafka-storage tool can not, in fact, generate uuids starting with '-'
>
[
https://issues.apache.org/jira/browse/KAFKA-15754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17781153#comment-17781153
]
Colin McCabe edited comment on KAFKA-15754 at 10/30/23 11:19 PM:
-
I am
[
https://issues.apache.org/jira/browse/KAFKA-15754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17781151#comment-17781151
]
Colin McCabe edited comment on KAFKA-15754 at 10/30/23 11:19 PM:
-
I ran
[
https://issues.apache.org/jira/browse/KAFKA-15754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17781152#comment-17781152
]
Colin McCabe commented on KAFKA-15754:
--
You can run this code yourself if you are curious. Here it
CalvinConfluent commented on PR #14603:
URL: https://github.com/apache/kafka/pull/14603#issuecomment-1786194305
https://issues.apache.org/jira/browse/KAFKA-15759 DescribeClusterRequestTest
https://issues.apache.org/jira/browse/KAFKA-15760 CoordinatorTest
Calvin Liu created KAFKA-15762:
--
Summary: ClusterConnectionStatesTest.testSingleIP is flaky
Key: KAFKA-15762
URL: https://issues.apache.org/jira/browse/KAFKA-15762
Project: Kafka
Issue Type:
[
https://issues.apache.org/jira/browse/KAFKA-15754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17781151#comment-17781151
]
Colin McCabe commented on KAFKA-15754:
--
I ran `kafka-storage.sh random-uuid` 10,000 times and got
Calvin Liu created KAFKA-15761:
--
Summary:
ConnectorRestartApiIntegrationTest.testMultiWorkerRestartOnlyConnector is flaky
Key: KAFKA-15761
URL: https://issues.apache.org/jira/browse/KAFKA-15761
Project:
Calvin Liu created KAFKA-15760:
--
Summary:
org.apache.kafka.trogdor.coordinator.CoordinatorTest.testTaskRequestWithOldStartMsGetsUpdated
is flaky
Key: KAFKA-15760
URL:
Calvin Liu created KAFKA-15759:
--
Summary: DescribeClusterRequestTest is flaky
Key: KAFKA-15759
URL: https://issues.apache.org/jira/browse/KAFKA-15759
Project: Kafka
Issue Type: Bug
apoorvmittal10 commented on PR #14621:
URL: https://github.com/apache/kafka/pull/14621#issuecomment-1786178001
> > @apoorvmittal10 : Yes, we are gradually moving the codebase to java.
Ideally, all new classes should be written in java.
>
> Thanks @junrao, I ll update the PR by
apoorvmittal10 commented on code in PR #14621:
URL: https://github.com/apache/kafka/pull/14621#discussion_r1376884298
##
core/src/main/scala/kafka/metrics/ClientMetricsMetadata.scala:
##
@@ -0,0 +1,119 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or
apoorvmittal10 commented on code in PR #14621:
URL: https://github.com/apache/kafka/pull/14621#discussion_r1376884030
##
core/src/main/scala/kafka/metrics/ClientMetricsConfig.scala:
##
@@ -0,0 +1,146 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
[
https://issues.apache.org/jira/browse/KAFKA-14402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17781148#comment-17781148
]
Justine Olshan commented on KAFKA-14402:
Sorry the wording is unclear. I will fix this. For
apoorvmittal10 commented on code in PR #14621:
URL: https://github.com/apache/kafka/pull/14621#discussion_r1376883781
##
core/src/main/scala/kafka/metrics/ClientMetricsConfig.scala:
##
@@ -0,0 +1,141 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
apoorvmittal10 commented on code in PR #14621:
URL: https://github.com/apache/kafka/pull/14621#discussion_r1376883099
##
core/src/main/scala/kafka/server/ClientMetricsManager.scala:
##
@@ -0,0 +1,38 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
apoorvmittal10 commented on code in PR #14621:
URL: https://github.com/apache/kafka/pull/14621#discussion_r1376882728
##
core/src/main/scala/kafka/server/ClientMetricsManager.scala:
##
@@ -0,0 +1,38 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
[
https://issues.apache.org/jira/browse/KAFKA-14402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17781144#comment-17781144
]
Travis Bischel commented on KAFKA-14402:
Sorry, I may be a bit confused then: when it says "for
[
https://issues.apache.org/jira/browse/KAFKA-15758?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Justine Olshan updated KAFKA-15758:
---
Summary: Always schedule wrapped callbacks (was: Always schedule wrapped
callbacks)
>
jolshan commented on code in PR #14629:
URL: https://github.com/apache/kafka/pull/14629#discussion_r1376866891
##
core/src/main/scala/kafka/server/KafkaRequestHandler.scala:
##
@@ -55,23 +55,23 @@ object KafkaRequestHandler {
* @param fun Callback function to execute
*
jolshan commented on code in PR #14629:
URL: https://github.com/apache/kafka/pull/14629#discussion_r1376866596
##
core/src/main/scala/kafka/server/KafkaRequestHandler.scala:
##
@@ -53,25 +53,27 @@ object KafkaRequestHandler {
* Wrap callback to schedule it on a request
[
https://issues.apache.org/jira/browse/KAFKA-4852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17781139#comment-17781139
]
Philip Nee commented on KAFKA-4852:
---
cc [~luke.kirby]
> ByteBufferSerializer not compatible with
[
https://issues.apache.org/jira/browse/KAFKA-4852?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Philip Nee updated KAFKA-4852:
--
Labels: needs-kip serializers (was: needs-kip)
> ByteBufferSerializer not compatible with offsets
>
Justine Olshan created KAFKA-15758:
--
Summary: Always schedule wrapped callbacks
Key: KAFKA-15758
URL: https://issues.apache.org/jira/browse/KAFKA-15758
Project: Kafka
Issue Type: Sub-task
Justine Olshan created KAFKA-15757:
--
Summary: Do not advertise v4 AddPartitionsToTxn to clients
Key: KAFKA-15757
URL: https://issues.apache.org/jira/browse/KAFKA-15757
Project: Kafka
Issue
[
https://issues.apache.org/jira/browse/KAFKA-14402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17781132#comment-17781132
]
Justine Olshan commented on KAFKA-14402:
Hi [~twmb]
The KIP current states:
> We will bump the
Dongnuo Lyu created KAFKA-15756:
---
Summary: Migrate existing integration tests to run old protocol in
new coordinator
Key: KAFKA-15756
URL: https://issues.apache.org/jira/browse/KAFKA-15756
Project:
[
https://issues.apache.org/jira/browse/KAFKA-15756?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dongnuo Lyu reassigned KAFKA-15756:
---
Assignee: Dongnuo Lyu
> Migrate existing integration tests to run old protocol in new
jolshan commented on code in PR #14629:
URL: https://github.com/apache/kafka/pull/14629#discussion_r1376821250
##
core/src/main/scala/kafka/server/ReplicaManager.scala:
##
@@ -864,6 +778,111 @@ class ReplicaManager(val config: KafkaConfig,
}
}
+ /*
+ * Note: This
artemlivshits commented on code in PR #14629:
URL: https://github.com/apache/kafka/pull/14629#discussion_r1376817191
##
core/src/main/scala/kafka/server/ReplicaManager.scala:
##
@@ -864,6 +778,111 @@ class ReplicaManager(val config: KafkaConfig,
}
}
+ /*
+ * Note:
cmccabe commented on code in PR #14290:
URL: https://github.com/apache/kafka/pull/14290#discussion_r1376808429
##
metadata/src/main/resources/common/metadata/PartitionRecord.json:
##
@@ -47,6 +47,8 @@
"about": "The eligible leader replicas of this partition." },
{
cmccabe commented on code in PR #14290:
URL: https://github.com/apache/kafka/pull/14290#discussion_r1376807529
##
server-common/src/main/java/org/apache/kafka/common/DirectoryId.java:
##
@@ -16,55 +16,166 @@
*/
package org.apache.kafka.common;
+import java.util.ArrayList;
cmccabe commented on code in PR #14290:
URL: https://github.com/apache/kafka/pull/14290#discussion_r1376805476
##
clients/src/main/java/org/apache/kafka/common/errors/InvalidMetadataException.java:
##
@@ -19,7 +19,7 @@
/**
* An exception that may indicate the client's
[
https://issues.apache.org/jira/browse/KAFKA-14402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17781122#comment-17781122
]
Travis Bischel commented on KAFKA-14402:
Another addendum, after your update: v4 of the
soarez commented on code in PR #14290:
URL: https://github.com/apache/kafka/pull/14290#discussion_r1376787884
##
metadata/src/main/java/org/apache/kafka/metadata/PartitionRegistration.java:
##
@@ -310,11 +337,22 @@ public ApiMessageAndVersion toRecord(Uuid topicId, int
soarez commented on code in PR #14290:
URL: https://github.com/apache/kafka/pull/14290#discussion_r1376787569
##
metadata/src/test/java/org/apache/kafka/controller/PartitionChangeBuilderTest.java:
##
@@ -49,12 +51,15 @@
import static
soarez commented on code in PR #14290:
URL: https://github.com/apache/kafka/pull/14290#discussion_r1376787303
##
clients/src/main/java/org/apache/kafka/common/errors/InvalidMetadataException.java:
##
@@ -19,7 +19,7 @@
/**
* An exception that may indicate the client's
hanyuzheng7 commented on code in PR #14570:
URL: https://github.com/apache/kafka/pull/14570#discussion_r1376784755
##
streams/src/main/java/org/apache/kafka/streams/state/internals/MeteredTimestampedKeyValueStore.java:
##
@@ -102,4 +140,230 @@ static class
[
https://issues.apache.org/jira/browse/KAFKA-15602?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax resolved KAFKA-15602.
-
Fix Version/s: 3.4.2
3.5.2
3.7.0
kirktrue closed pull request #14664: KAFKA-15277: ConsumerDelegate support
URL: https://github.com/apache/kafka/pull/14664
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
[
https://issues.apache.org/jira/browse/KAFKA-4852?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax reopened KAFKA-4852:
Assignee: (was: LinShunkang)
> ByteBufferSerializer not compatible with offsets
>
[
https://issues.apache.org/jira/browse/KAFKA-4852?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-4852:
---
Labels: needs-kip (was: )
> ByteBufferSerializer not compatible with offsets
>
kirktrue commented on PR #14664:
URL: https://github.com/apache/kafka/pull/14664#issuecomment-1785968980
This was a simple experiment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
kirktrue opened a new pull request, #14670:
URL: https://github.com/apache/kafka/pull/14670
The consumer refactoring project introduced another `Consumer`
implementation, creating two different, coexisting implementations of the
`Consumer` interface:
* `KafkaConsumer` (AKA
[
https://issues.apache.org/jira/browse/KAFKA-4852?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-4852:
---
Fix Version/s: (was: 3.4.0)
> ByteBufferSerializer not compatible with offsets
>
[
https://issues.apache.org/jira/browse/KAFKA-15277?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-15277:
--
Description:
The consumer refactoring project introduced another {{Consumer}}
implementation,
mjsax merged PR #14617:
URL: https://github.com/apache/kafka/pull/14617
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/KAFKA-15643?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ritika Muduganti resolved KAFKA-15643.
--
Reviewer: David Jacot
Resolution: Fixed
> Improve unloading logging
>
[
https://issues.apache.org/jira/browse/KAFKA-15284?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True reassigned KAFKA-15284:
-
Assignee: Kirk True
> Implement ConsumerGroupProtocolVersionResolver to determine consumer
[
https://issues.apache.org/jira/browse/KAFKA-15277?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True reassigned KAFKA-15277:
-
Assignee: Kirk True (was: Philip Nee)
> Design & implement support for internal Consumer
dajac commented on code in PR #14642:
URL: https://github.com/apache/kafka/pull/14642#discussion_r1376703936
##
clients/src/main/java/org/apache/kafka/clients/consumer/ConsumerConfig.java:
##
@@ -105,6 +105,24 @@ public class ConsumerConfig extends AbstractConfig {
public
[
https://issues.apache.org/jira/browse/KAFKA-15653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17781095#comment-17781095
]
ASF GitHub Bot commented on KAFKA-15653:
jolshan merged PR #564:
URL:
dajac commented on code in PR #14589:
URL: https://github.com/apache/kafka/pull/14589#discussion_r1376679603
##
core/src/main/scala/kafka/server/KafkaApis.scala:
##
@@ -1500,6 +1502,8 @@ class KafkaApis(val requestChannel: RequestChannel,
new
jolshan commented on code in PR #14629:
URL: https://github.com/apache/kafka/pull/14629#discussion_r1376679750
##
core/src/main/scala/kafka/server/ReplicaManager.scala:
##
@@ -864,6 +778,111 @@ class ReplicaManager(val config: KafkaConfig,
}
}
+ /*
+ * Note: This
jolshan commented on code in PR #14629:
URL: https://github.com/apache/kafka/pull/14629#discussion_r1376678541
##
core/src/main/scala/kafka/server/KafkaRequestHandler.scala:
##
@@ -53,25 +53,27 @@ object KafkaRequestHandler {
* Wrap callback to schedule it on a request
junrao closed pull request #14603: KAFKA-15582: Move the clean shutdown file to
the storage package
URL: https://github.com/apache/kafka/pull/14603
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
junrao commented on PR #14603:
URL: https://github.com/apache/kafka/pull/14603#issuecomment-1785851656
@CalvinConfluent :
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
[
https://issues.apache.org/jira/browse/KAFKA-15628?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Jacot resolved KAFKA-15628.
-
Fix Version/s: 3.7.0
Resolution: Fixed
> Refactor ConsumerRebalanceListener invocation
dajac merged PR #14638:
URL: https://github.com/apache/kafka/pull/14638
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
junrao commented on code in PR #14629:
URL: https://github.com/apache/kafka/pull/14629#discussion_r1376674826
##
core/src/main/scala/kafka/server/ReplicaManager.scala:
##
@@ -864,6 +778,111 @@ class ReplicaManager(val config: KafkaConfig,
}
}
+ /*
+ * Note: This
junrao commented on code in PR #14629:
URL: https://github.com/apache/kafka/pull/14629#discussion_r1376671529
##
core/src/main/scala/kafka/server/ReplicaManager.scala:
##
@@ -864,6 +778,111 @@ class ReplicaManager(val config: KafkaConfig,
}
}
+ /*
+ * Note: This
jolshan commented on code in PR #14629:
URL: https://github.com/apache/kafka/pull/14629#discussion_r1376670972
##
core/src/main/scala/kafka/server/ReplicaManager.scala:
##
@@ -864,6 +778,111 @@ class ReplicaManager(val config: KafkaConfig,
}
}
+ /*
+ * Note: This
jolshan commented on code in PR #14629:
URL: https://github.com/apache/kafka/pull/14629#discussion_r1376662251
##
core/src/main/scala/kafka/server/ReplicaManager.scala:
##
@@ -864,6 +778,111 @@ class ReplicaManager(val config: KafkaConfig,
}
}
+ /*
+ * Note: This
junrao commented on code in PR #14629:
URL: https://github.com/apache/kafka/pull/14629#discussion_r1376661650
##
core/src/main/scala/kafka/server/KafkaRequestHandler.scala:
##
@@ -53,25 +53,27 @@ object KafkaRequestHandler {
* Wrap callback to schedule it on a request
jolshan commented on code in PR #14629:
URL: https://github.com/apache/kafka/pull/14629#discussion_r1376659689
##
core/src/main/scala/kafka/server/KafkaRequestHandler.scala:
##
@@ -53,25 +53,27 @@ object KafkaRequestHandler {
* Wrap callback to schedule it on a request
junrao commented on code in PR #14629:
URL: https://github.com/apache/kafka/pull/14629#discussion_r1376657322
##
core/src/main/scala/kafka/server/KafkaRequestHandler.scala:
##
@@ -53,25 +53,27 @@ object KafkaRequestHandler {
* Wrap callback to schedule it on a request
divijvaidya commented on code in PR #14629:
URL: https://github.com/apache/kafka/pull/14629#discussion_r1376654240
##
core/src/main/scala/kafka/server/ReplicaManager.scala:
##
@@ -864,6 +778,111 @@ class ReplicaManager(val config: KafkaConfig,
}
}
+ /*
+ * Note:
junrao commented on code in PR #14629:
URL: https://github.com/apache/kafka/pull/14629#discussion_r1376651533
##
core/src/main/scala/kafka/server/ReplicaManager.scala:
##
@@ -864,6 +778,111 @@ class ReplicaManager(val config: KafkaConfig,
}
}
+ /*
+ * Note: This
[
https://issues.apache.org/jira/browse/KAFKA-15631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17781075#comment-17781075
]
Philip Nee commented on KAFKA-15631:
Hi [~lianetm] Thanks for filing this issue. I believe the
rreddy-22 commented on PR #14582:
URL: https://github.com/apache/kafka/pull/14582#issuecomment-1785758202
https://jenkins.confluent.io/job/system-test-kafka-branch-builder/5915/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
[
https://issues.apache.org/jira/browse/KAFKA-15631?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Philip Nee resolved KAFKA-15631.
Resolution: Not A Problem
> Do not send new heartbeat request while another one in-flight
>
rreddy-22 commented on code in PR #14657:
URL: https://github.com/apache/kafka/pull/14657#discussion_r1376601434
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/CoordinatorRuntime.java:
##
@@ -1359,7 +1359,8 @@ public void scheduleUnloadOperation(
[
https://issues.apache.org/jira/browse/KAFKA-15754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17781069#comment-17781069
]
Ismael Juma commented on KAFKA-15754:
-
[~jolshan] I think this issue can happen if some code does
1 - 100 of 182 matches
Mail list logo
