Re: [PR] KAFKA-15890: Consumer.poll with long timeout unaware of assigned partitions [kafka]

2023-11-30 Thread via GitHub
AndrewJSchofield commented on code in PR #14835: URL: https://github.com/apache/kafka/pull/14835#discussion_r1411721121 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThread.java: ## @@ -205,6 +205,26 @@ public void wakeup() {

Re: [PR] KAFKA-15831: KIP-1000 protocol and admin client [kafka]

2023-11-30 Thread via GitHub
AndrewJSchofield commented on PR #14811: URL: https://github.com/apache/kafka/pull/14811#issuecomment-1835612791 @junrao This time Java 8, 11 and 21 completed with a handful of unrelated flaky test failures, but Java 17 timed out. The CI system seems to be a dice roll at the moment. --

Re: [PR] KAFKA-15830: Add telemetry API handling (KIP-714) [kafka]

2023-11-30 Thread via GitHub
apoorvmittal10 commented on code in PR #14767: URL: https://github.com/apache/kafka/pull/14767#discussion_r1411715897 ## core/src/main/scala/kafka/server/ApiVersionManager.scala: ## @@ -130,7 +133,8 @@ class DefaultApiVersionManager( brokerFeatures: BrokerFeatures,

Re: [PR] KAFKA-15830: Add telemetry API handling (KIP-714) [kafka]

2023-11-30 Thread via GitHub
apoorvmittal10 commented on code in PR #14767: URL: https://github.com/apache/kafka/pull/14767#discussion_r1411715680 ## core/src/main/scala/kafka/server/BrokerServer.scala: ## @@ -235,14 +235,15 @@ class BrokerServer( ) clientToControllerChannelManager.start()

Re: [PR] KAFKA-15901: Client changes for registering telemetry and API calls (KIP-714) [kafka]

2023-11-30 Thread via GitHub
apoorvmittal10 commented on code in PR #14843: URL: https://github.com/apache/kafka/pull/14843#discussion_r1411708516 ## clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java: ## @@ -4387,7 +4398,52 @@ public FenceProducersResult fenceProducers(Collection

Re: [PR] HOTFIX: Fix BrokerRegistrationRequestTest [kafka]

2023-11-30 Thread via GitHub
showuon commented on PR #14892: URL: https://github.com/apache/kafka/pull/14892#issuecomment-1835580555 @cmccabe @rondagostino , call for review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[PR] Flaky test - testSyncTopicConfigs() – org.apache.kafka.connect.mirror.integration.MirrorConnectorsIntegrationBaseTest [kafka]

2023-11-30 Thread via GitHub
atu-sharm opened a new pull request, #14893: URL: https://github.com/apache/kafka/pull/14893 Added a method, waitForConfigValueChange, to wait for a configuration value change in an EmbeddedKafkaCluster after using the incrementalAlterConfigs API. The test, testSyncTopicConfigs,

[PR] HOTFIX: Fix BrokerRegistrationRequestTest [kafka]

2023-11-30 Thread via GitHub
showuon opened a new pull request, #14892: URL: https://github.com/apache/kafka/pull/14892 We should reset `previousBrokerEpoch` to default value for version less than 2 like

Re: [PR] KAFKA-15489: resign leadership when no fetch from majority voters [kafka]

2023-11-30 Thread via GitHub
showuon commented on PR #14428: URL: https://github.com/apache/kafka/pull/14428#issuecomment-1835574772 Yes, I agree. Thanks for helping merge it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] KAFKA-14516: [2/N] New Group Coordinator IT for Static Member Replacement [kafka]

2023-11-30 Thread via GitHub
vamossagar12 commented on PR #14882: URL: https://github.com/apache/kafka/pull/14882#issuecomment-1835573531 Looks like this new test failed ``` Error org.opentest4j.AssertionFailedError: expected: but was: Stacktrace org.opentest4j.AssertionFailedError: expected: but

Re: [PR] KAFKA-15901: Client changes for registering telemetry and API calls (KIP-714) [kafka]

2023-11-30 Thread via GitHub
mjsax commented on code in PR #14843: URL: https://github.com/apache/kafka/pull/14843#discussion_r1411677019 ## clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java: ## @@ -4387,7 +4398,52 @@ public FenceProducersResult fenceProducers(Collection

Re: [PR] KAFKA-15663, KAFKA-15794: Telemetry reporter and request handling (KIP-714) [kafka]

2023-11-30 Thread via GitHub
apoorvmittal10 commented on code in PR #14724: URL: https://github.com/apache/kafka/pull/14724#discussion_r1411628858 ## clients/src/main/java/org/apache/kafka/clients/ClientTelemetryProvider.java: ## @@ -0,0 +1,144 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] KAFKA-15901: Client changes for registering telemetry and API calls (KIP-714) [kafka]

2023-11-30 Thread via GitHub
apoorvmittal10 commented on code in PR #14843: URL: https://github.com/apache/kafka/pull/14843#discussion_r1411627705 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java: ## @@ -957,7 +972,11 @@ public void commitSync(Map offsets,

Re: [PR] KAFKA-15901: Client changes for registering telemetry and API calls (KIP-714) [kafka]

2023-11-30 Thread via GitHub
apoorvmittal10 commented on code in PR #14843: URL: https://github.com/apache/kafka/pull/14843#discussion_r1411627068 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java: ## @@ -957,7 +972,11 @@ public void commitSync(Map offsets,

Re: [PR] KAFKA-15663, KAFKA-15794: Telemetry reporter and request handling (KIP-714) [kafka]

2023-11-30 Thread via GitHub
mjsax commented on code in PR #14724: URL: https://github.com/apache/kafka/pull/14724#discussion_r1411624321 ## clients/src/main/java/org/apache/kafka/clients/ClientTelemetryProvider.java: ## @@ -0,0 +1,144 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] KAFKA-15663, KAFKA-15794: Telemetry reporter and request handling (KIP-714) [kafka]

2023-11-30 Thread via GitHub
mjsax commented on code in PR #14724: URL: https://github.com/apache/kafka/pull/14724#discussion_r1411624321 ## clients/src/main/java/org/apache/kafka/clients/ClientTelemetryProvider.java: ## @@ -0,0 +1,144 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] KAFKA-15663, KAFKA-15794: Telemetry reporter and request handling (KIP-714) [kafka]

2023-11-30 Thread via GitHub
philipnee commented on code in PR #14724: URL: https://github.com/apache/kafka/pull/14724#discussion_r1411319047 ## clients/src/main/java/org/apache/kafka/clients/ClientTelemetryReporter.java: ## @@ -0,0 +1,952 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] KAFKA-15663, KAFKA-15794: Telemetry reporter and request handling (KIP-714) [kafka]

2023-11-30 Thread via GitHub
philipnee commented on code in PR #14724: URL: https://github.com/apache/kafka/pull/14724#discussion_r1411317556 ## clients/src/main/java/org/apache/kafka/clients/ClientTelemetryReporter.java: ## @@ -0,0 +1,952 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] MINOR: Upgrade to gradle 8.5 [kafka]

2023-11-30 Thread via GitHub
satishd merged PR #14883: URL: https://github.com/apache/kafka/pull/14883 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] MINOR: Upgrade to gradle 8.5 [kafka]

2023-11-30 Thread via GitHub
satishd commented on PR #14883: URL: https://github.com/apache/kafka/pull/14883#issuecomment-1835422111 There are some unrelated intermittent test failures in Jenkins jobs, merging it to trunk. -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] ctr-staging-testing-draft [kafka]

2023-11-30 Thread via GitHub
github-actions[bot] commented on PR #13716: URL: https://github.com/apache/kafka/pull/13716#issuecomment-1835400867 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has

Re: [PR] KAFKA-14725: Interrupt source task poll thread when cancelled [kafka]

2023-11-30 Thread via GitHub
github-actions[bot] commented on PR #14316: URL: https://github.com/apache/kafka/pull/14316#issuecomment-1835400701 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has

[PR] improve TopicCommandIntegrationTest to be less flaky [kafka]

2023-11-30 Thread via GitHub
Owen-CH-Leung opened a new pull request, #14891: URL: https://github.com/apache/kafka/pull/14891 As per

Re: [PR] MINOR: fix BrokerRegistrationRequest broken by KAFKA-15922 [kafka]

2023-11-30 Thread via GitHub
jolshan commented on PR #14887: URL: https://github.com/apache/kafka/pull/14887#issuecomment-1835314327 Looks like there is a checkstyle issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] MINOR: Fix flaky `DescribeClusterRequestTest.testDescribeClusterRequestIncludingClusterAuthorizedOperations` [kafka]

2023-11-30 Thread via GitHub
hachikuji commented on PR #14890: URL: https://github.com/apache/kafka/pull/14890#issuecomment-1835309801 Example of flaky failure:

[PR] MINOR: Fix flaky `DescribeClusterRequestTest.testDescribeClusterRequestIncludingClusterAuthorizedOperations` [kafka]

2023-11-30 Thread via GitHub
hachikuji opened a new pull request, #14890: URL: https://github.com/apache/kafka/pull/14890 Test startup does not assure that all brokers are registered. In flaky failures, the `DescribeCluster` API does not return a complete list of brokers. To fix the issue, we add a call to

Re: [PR] KAFKA-15347: add support for 'single key multi timestamp' IQs with versioned state stores (KIP-968) [kafka]

2023-11-30 Thread via GitHub
mjsax commented on code in PR #14626: URL: https://github.com/apache/kafka/pull/14626#discussion_r1411475602 ## streams/src/main/java/org/apache/kafka/streams/query/MultiVersionedKeyQuery.java: ## @@ -130,9 +129,9 @@ public Optional toTime() { /** * The order of

[PR] MINOR: cleanup internal Iterator impl [kafka]

2023-11-30 Thread via GitHub
mjsax opened a new pull request, #14889: URL: https://github.com/apache/kafka/pull/14889 makeNext() is internal and visibility should not be extended to `public` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] MINOR: Fix flaky test RefreshingHttpsJwksTest.testBasicScheduleRefresh [kafka]

2023-11-30 Thread via GitHub
splett2 commented on code in PR #14888: URL: https://github.com/apache/kafka/pull/14888#discussion_r1411492950 ## clients/src/test/java/org/apache/kafka/common/security/oauthbearer/internals/secured/RefreshingHttpsJwksTest.java: ## @@ -62,14 +62,14 @@ public class

[PR] MINOR: Fix flaky test RefreshingHttpsJwksTest.testBasicScheduleRefresh [kafka]

2023-11-30 Thread via GitHub
splett2 opened a new pull request, #14888: URL: https://github.com/apache/kafka/pull/14888 ### What This test is flaky because `maybeExpediteRefresh` schedules a refresh in a background thread. Instead pass through a mock executor service so that the refresh is executed directly.

Re: [PR] KAFKA-15363: Broker log directory failure changes [kafka]

2023-11-30 Thread via GitHub
cmccabe commented on code in PR #14790: URL: https://github.com/apache/kafka/pull/14790#discussion_r1411471028 ## core/src/main/scala/kafka/cluster/Partition.scala: ## @@ -613,7 +613,16 @@ class Partition(val topicPartition: TopicPartition, // Only ReplicaAlterDirThread will

Re: [PR] KAFKA-15890: Consumer.poll with long timeout unaware of assigned partitions [kafka]

2023-11-30 Thread via GitHub
kirktrue commented on code in PR #14835: URL: https://github.com/apache/kafka/pull/14835#discussion_r1411470319 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThread.java: ## @@ -205,6 +205,26 @@ public void wakeup() {

Re: [PR] KAFKA-15890: Consumer.poll with long timeout unaware of assigned partitions [kafka]

2023-11-30 Thread via GitHub
kirktrue commented on code in PR #14835: URL: https://github.com/apache/kafka/pull/14835#discussion_r1411470319 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThread.java: ## @@ -205,6 +205,26 @@ public void wakeup() {

Re: [PR] MINOR: Upgrade to gradle 8.5 [kafka]

2023-11-30 Thread via GitHub
ijuma commented on PR #14883: URL: https://github.com/apache/kafka/pull/14883#issuecomment-1835170235 @satishd Do you have cycles to review this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] KAFKA-15363: Broker log directory failure changes [kafka]

2023-11-30 Thread via GitHub
cmccabe commented on code in PR #14790: URL: https://github.com/apache/kafka/pull/14790#discussion_r1411470125 ## server/src/main/java/org/apache/kafka/server/AssignmentsManager.java: ## @@ -95,7 +96,10 @@ public void close() throws InterruptedException { } public

[PR] MINOR: fix BrokerRegistrationRequest broken by KAFKA-15922 [kafka]

2023-11-30 Thread via GitHub
cmccabe opened a new pull request, #14887: URL: https://github.com/apache/kafka/pull/14887 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[jira] [Resolved] (KAFKA-15527) Add reverseRange and reverseAll query over kv-store in IQv2

2023-11-30 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax resolved KAFKA-15527. - Resolution: Fixed > Add reverseRange and reverseAll query over kv-store in IQv2 >

Re: [PR] KAFKA-15448: Streams Standby Update Listener (KIP-988) [kafka]

2023-11-30 Thread via GitHub
ableegoldman commented on code in PR #14735: URL: https://github.com/apache/kafka/pull/14735#discussion_r1411413767 ## streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java: ## @@ -175,13 +176,15 @@ public class KafkaStreams implements AutoCloseable { private

[PR] MINOR: fully encapsulate user restore listener in the DelegatingRestoreListener [kafka]

2023-11-30 Thread via GitHub
ableegoldman opened a new pull request, #14886: URL: https://github.com/apache/kafka/pull/14886 Minor cleanup to make it easier to follow the restore listener logic. Currently, the KafkaStreams class tracks two restore listener fields: there is a non-final, nullable

Re: [PR] KAFKA-15663, KAFKA-15794: Telemetry reporter and request handling (KIP-714) [kafka]

2023-11-30 Thread via GitHub
philipnee commented on PR #14724: URL: https://github.com/apache/kafka/pull/14724#issuecomment-1834658465 Hi @apoorvmittal10 thanks for writing this PR - also sorry for the delay but I made the first pass and left some stylistic comments. -- This is an automated message from the Apache

Re: [PR] KAFKA-15663, KAFKA-15794: Telemetry reporter and request handling (KIP-714) [kafka]

2023-11-30 Thread via GitHub
philipnee commented on code in PR #14724: URL: https://github.com/apache/kafka/pull/14724#discussion_r1411338139 ## clients/src/main/java/org/apache/kafka/clients/ClientTelemetryReporter.java: ## @@ -0,0 +1,952 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] KAFKA-15663, KAFKA-15794: Telemetry reporter and request handling (KIP-714) [kafka]

2023-11-30 Thread via GitHub
philipnee commented on code in PR #14724: URL: https://github.com/apache/kafka/pull/14724#discussion_r1411331948 ## clients/src/main/java/org/apache/kafka/clients/ClientTelemetryReporter.java: ## @@ -0,0 +1,952 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] KAFKA-15663, KAFKA-15794: Telemetry reporter and request handling (KIP-714) [kafka]

2023-11-30 Thread via GitHub
philipnee commented on code in PR #14724: URL: https://github.com/apache/kafka/pull/14724#discussion_r1411331257 ## clients/src/main/java/org/apache/kafka/clients/ClientTelemetryReporter.java: ## @@ -0,0 +1,952 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] KAFKA-15663, KAFKA-15794: Telemetry reporter and request handling (KIP-714) [kafka]

2023-11-30 Thread via GitHub
philipnee commented on code in PR #14724: URL: https://github.com/apache/kafka/pull/14724#discussion_r1411330545 ## clients/src/main/java/org/apache/kafka/clients/ClientTelemetryReporter.java: ## @@ -0,0 +1,952 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] KAFKA-15663, KAFKA-15794: Telemetry reporter and request handling (KIP-714) [kafka]

2023-11-30 Thread via GitHub
philipnee commented on code in PR #14724: URL: https://github.com/apache/kafka/pull/14724#discussion_r1411328695 ## clients/src/main/java/org/apache/kafka/clients/ClientTelemetryReporter.java: ## @@ -0,0 +1,952 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] KAFKA-15886: Always specify directories for new partition registrations [kafka]

2023-11-30 Thread via GitHub
cmccabe commented on PR #14820: URL: https://github.com/apache/kafka/pull/14820#issuecomment-1834642532 committed, thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] KAFKA-15886: Always specify directories for new partition registrations [kafka]

2023-11-30 Thread via GitHub
cmccabe closed pull request #14820: KAFKA-15886: Always specify directories for new partition registrations URL: https://github.com/apache/kafka/pull/14820 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] KAFKA-15663, KAFKA-15794: Telemetry reporter and request handling (KIP-714) [kafka]

2023-11-30 Thread via GitHub
philipnee commented on code in PR #14724: URL: https://github.com/apache/kafka/pull/14724#discussion_r1411319789 ## clients/src/main/java/org/apache/kafka/clients/ClientTelemetryReporter.java: ## @@ -0,0 +1,952 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] KAFKA-15663, KAFKA-15794: Telemetry reporter and request handling (KIP-714) [kafka]

2023-11-30 Thread via GitHub
philipnee commented on code in PR #14724: URL: https://github.com/apache/kafka/pull/14724#discussion_r1411319047 ## clients/src/main/java/org/apache/kafka/clients/ClientTelemetryReporter.java: ## @@ -0,0 +1,952 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] KAFKA-15663, KAFKA-15794: Telemetry reporter and request handling (KIP-714) [kafka]

2023-11-30 Thread via GitHub
philipnee commented on code in PR #14724: URL: https://github.com/apache/kafka/pull/14724#discussion_r1411317556 ## clients/src/main/java/org/apache/kafka/clients/ClientTelemetryReporter.java: ## @@ -0,0 +1,952 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] KAFKA-15663, KAFKA-15794: Telemetry reporter and request handling (KIP-714) [kafka]

2023-11-30 Thread via GitHub
philipnee commented on code in PR #14724: URL: https://github.com/apache/kafka/pull/14724#discussion_r1411316589 ## clients/src/main/java/org/apache/kafka/clients/ClientTelemetryReporter.java: ## @@ -0,0 +1,952 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] KAFKA-15663, KAFKA-15794: Telemetry reporter and request handling (KIP-714) [kafka]

2023-11-30 Thread via GitHub
philipnee commented on code in PR #14724: URL: https://github.com/apache/kafka/pull/14724#discussion_r1411312954 ## clients/src/main/java/org/apache/kafka/clients/ClientTelemetryReporter.java: ## @@ -0,0 +1,952 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] KAFKA-15663, KAFKA-15794: Telemetry reporter and request handling (KIP-714) [kafka]

2023-11-30 Thread via GitHub
philipnee commented on code in PR #14724: URL: https://github.com/apache/kafka/pull/14724#discussion_r1411305972 ## clients/src/main/java/org/apache/kafka/clients/ClientTelemetryProvider.java: ## @@ -0,0 +1,144 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] KAFKA-15830: Add telemetry API handling (KIP-714) [kafka]

2023-11-30 Thread via GitHub
junrao commented on code in PR #14767: URL: https://github.com/apache/kafka/pull/14767#discussion_r1411280008 ## core/src/main/scala/kafka/server/BrokerServer.scala: ## @@ -235,14 +235,15 @@ class BrokerServer( ) clientToControllerChannelManager.start()

[jira] [Created] (KAFKA-15951) MissingSourceTopicException should include topic names

2023-11-30 Thread Matthias J. Sax (Jira)
Matthias J. Sax created KAFKA-15951: --- Summary: MissingSourceTopicException should include topic names Key: KAFKA-15951 URL: https://issues.apache.org/jira/browse/KAFKA-15951 Project: Kafka

Re: [PR] KAFKA-15842: Correct handling of KafkaConsumer.committed for new consumer [kafka]

2023-11-30 Thread via GitHub
AndrewJSchofield commented on code in PR #14859: URL: https://github.com/apache/kafka/pull/14859#discussion_r1411266359 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java: ## @@ -653,7 +652,7 @@ public Map committed(final Set(); +

Re: [PR] KAFKA-14509: [2/2] Implement server side logic for ConsumerGroupDescribe API [kafka]

2023-11-30 Thread via GitHub
riedelmax commented on code in PR #14544: URL: https://github.com/apache/kafka/pull/14544#discussion_r1411265076 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroupMember.java: ## @@ -545,6 +547,32 @@ public String

Re: [PR] KAFKA-15890: Consumer.poll with long timeout unaware of assigned partitions [kafka]

2023-11-30 Thread via GitHub
AndrewJSchofield commented on code in PR #14835: URL: https://github.com/apache/kafka/pull/14835#discussion_r1411254378 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java: ## @@ -800,6 +811,11 @@ public void resetTimer() {

Re: [PR] KAFKA-15890: Consumer.poll with long timeout unaware of assigned partitions [kafka]

2023-11-30 Thread via GitHub
AndrewJSchofield commented on code in PR #14835: URL: https://github.com/apache/kafka/pull/14835#discussion_r1411253921 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThread.java: ## @@ -205,6 +205,26 @@ public void wakeup() {

Re: [PR] KAFKA-15842: Correct handling of KafkaConsumer.committed for new consumer [kafka]

2023-11-30 Thread via GitHub
kirktrue commented on code in PR #14859: URL: https://github.com/apache/kafka/pull/14859#discussion_r1411224159 ## checkstyle/suppressions.xml: ## @@ -48,7 +48,7 @@ Review Comment: Thank you for this clean up! ##

Re: [PR] KAFKA-15890: Consumer.poll with long timeout unaware of assigned partitions [kafka]

2023-11-30 Thread via GitHub
kirktrue commented on code in PR #14835: URL: https://github.com/apache/kafka/pull/14835#discussion_r1411218465 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java: ## @@ -800,6 +811,11 @@ public void resetTimer() {

Re: [PR] MINOR: Add junit properties to display parameterized test names [kafka]

2023-11-30 Thread via GitHub
dajac commented on PR #14687: URL: https://github.com/apache/kafka/pull/14687#issuecomment-1834494230 I cannot get a clean build for this one... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Resolved] (KAFKA-15629) proposal to introduce IQv2 Query Types: TimestampedKeyQuery and TimestampedRangeQuery

2023-11-30 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15629?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax resolved KAFKA-15629. - Resolution: Fixed > proposal to introduce IQv2 Query Types: TimestampedKeyQuery and >

[jira] [Assigned] (KAFKA-15061) CoordinatorPartitionWriter should reuse buffer

2023-11-30 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15061?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot reassigned KAFKA-15061: --- Assignee: David Jacot > CoordinatorPartitionWriter should reuse buffer >

[PR] KAFKA-15061; CoordinatorPartitionWriter should reuse buffer [kafka]

2023-11-30 Thread via GitHub
dajac opened a new pull request, #14885: URL: https://github.com/apache/kafka/pull/14885 This patch adds a ThreadLocal with a GrowableBufferSupplier so that each writing thread can reuse the same buffer instead of allocating a new one for each write. The patch relies on existing tests.

Re: [PR] KAFKA-15629: Proposal to introduce IQv2 Query Types: TimestampedKeyQuery and TimestampedRangeQuery [kafka]

2023-11-30 Thread via GitHub
mjsax commented on PR #14570: URL: https://github.com/apache/kafka/pull/14570#issuecomment-1834478535 Thanks for the KIP and PR. Merged to `trunk`. One more thing: can you do a follow up PR to update the docs? -- This is an automated message from the Apache Git Service. To respond

Re: [PR] KAFKA-15629: Proposal to introduce IQv2 Query Types: TimestampedKeyQuery and TimestampedRangeQuery [kafka]

2023-11-30 Thread via GitHub
mjsax merged PR #14570: URL: https://github.com/apache/kafka/pull/14570 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] KAFKA-15281: Implement the groupMetadata Consumer API [kafka]

2023-11-30 Thread via GitHub
kirktrue commented on code in PR #14879: URL: https://github.com/apache/kafka/pull/14879#discussion_r1411200070 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java: ## @@ -398,6 +466,38 @@ public class AsyncKafkaConsumer implements

[PR] MINOR: disable test_transactions with new group coordinator [kafka]

2023-11-30 Thread via GitHub
jeffkbkim opened a new pull request, #14884: URL: https://github.com/apache/kafka/pull/14884 https://issues.apache.org/jira/browse/KAFKA-14505 is not done yet so we need to disable the system test. Added a comment in the jira to re-enable once it's implemented. ### Committer

[jira] [Commented] (KAFKA-14505) Implement TnxOffsetCommit API

2023-11-30 Thread Jeff Kim (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17791759#comment-17791759 ] Jeff Kim commented on KAFKA-14505: -- disabled test_transactions

[jira] [Resolved] (KAFKA-13621) Resign leader on network partition

2023-11-30 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-13621?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] José Armando García Sancio resolved KAFKA-13621. Resolution: Duplicate > Resign leader on network partition >

[jira] [Updated] (KAFKA-15911) KRaft quorum leader should make sure the follower fetch is making progress

2023-11-30 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-15911?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] José Armando García Sancio updated KAFKA-15911: --- Affects Version/s: 3.7.0 > KRaft quorum leader should make sure the

[jira] [Updated] (KAFKA-15489) split brain in KRaft cluster

2023-11-30 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-15489?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] José Armando García Sancio updated KAFKA-15489: --- Fix Version/s: 3.7.0 > split brain in KRaft cluster >

Re: [PR] KAFKA-15489: resign leadership when no fetch from majority voters [kafka]

2023-11-30 Thread via GitHub
jsancio merged PR #14428: URL: https://github.com/apache/kafka/pull/14428 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Updated] (KAFKA-15890) Consumer.poll with long timeout unaware of assigned partitions

2023-11-30 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15890?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-15890: -- Summary: Consumer.poll with long timeout unaware of assigned partitions (was:

[jira] [Comment Edited] (KAFKA-10840) Need way to catch auth issues in poll method of Java Kafka client

2023-11-30 Thread Philip Nee (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17791742#comment-17791742 ] Philip Nee edited comment on KAFKA-10840 at 11/30/23 7:03 PM: -- Hey

[jira] [Commented] (KAFKA-10840) Need way to catch auth issues in poll method of Java Kafka client

2023-11-30 Thread Philip Nee (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17791742#comment-17791742 ] Philip Nee commented on KAFKA-10840: Hey [~ChrisEgerton] - Seems like you've been working on

Re: [PR] MINOR: Rewrite the meta.properties handling code in Java and fix some issues [kafka]

2023-11-30 Thread via GitHub
cmccabe commented on code in PR #14628: URL: https://github.com/apache/kafka/pull/14628#discussion_r1411139366 ## core/src/main/scala/kafka/server/KafkaServer.scala: ## @@ -1048,20 +1054,15 @@ class KafkaServer( * * @return The brokerId. */ - private def

[PR] MINOR: Upgrade to gradle 8.5 [kafka]

2023-11-30 Thread via GitHub
ijuma opened a new pull request, #14883: URL: https://github.com/apache/kafka/pull/14883 The highlight is full support for Java 21, full release notes below: * https://docs.gradle.org/8.4/release-notes.html * https://docs.gradle.org/8.5/release-notes.html ### Committer

Re: [PR] KAFKA-15922: Add a MetadataVersion for JBOD [kafka]

2023-11-30 Thread via GitHub
cmccabe merged PR #14860: URL: https://github.com/apache/kafka/pull/14860 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] KAFKA-15831: KIP-1000 protocol and admin client [kafka]

2023-11-30 Thread via GitHub
AndrewJSchofield closed pull request #14811: KAFKA-15831: KIP-1000 protocol and admin client URL: https://github.com/apache/kafka/pull/14811 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] KAFKA-15831: KIP-1000 protocol and admin client [kafka]

2023-11-30 Thread via GitHub
AndrewJSchofield commented on PR #14811: URL: https://github.com/apache/kafka/pull/14811#issuecomment-1834320812 I think so. After 8 hours. I will try resubmitting now (which means it will run overnight for me). In the event that it's still problematic, I'll make a fresh PR and try again.

Re: [PR] KAFKA-15922: Add a MetadataVersion for JBOD [kafka]

2023-11-30 Thread via GitHub
cmccabe commented on PR #14860: URL: https://github.com/apache/kafka/pull/14860#issuecomment-1834306862 > Can we also fix the builder version handling here? > With this fixed, LGTM Good catch. The best way to fix this would be to add "ignorable" to the JSON definition, so that it

[jira] [Updated] (KAFKA-15946) AsyncKafkaConsumer should retry commits on the application thread instead of auto-retry

2023-11-30 Thread Philip Nee (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15946?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Philip Nee updated KAFKA-15946: --- Summary: AsyncKafkaConsumer should retry commits on the application thread instead of auto-retry

Re: [PR] KAFKA-15831: KIP-1000 protocol and admin client [kafka]

2023-11-30 Thread via GitHub
junrao commented on PR #14811: URL: https://github.com/apache/kafka/pull/14811#issuecomment-1834296289 @AndrewJSchofield : It seems that the last build timed out? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] MINOR: Fix flaky `MetadataLoaderTest.testNoPublishEmptyImage` [kafka]

2023-11-30 Thread via GitHub
hachikuji merged PR #14875: URL: https://github.com/apache/kafka/pull/14875 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] KAFKA-15910: New group coordinator needs to generate snapshots while loading [kafka]

2023-11-30 Thread via GitHub
jeffkbkim commented on code in PR #14849: URL: https://github.com/apache/kafka/pull/14849#discussion_r1411063985 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/CoordinatorShard.java: ## @@ -47,4 +47,15 @@ default void

[PR] KAFKA-14516: [2/N] New Group Coordinator IT for Static Member Replacement [kafka]

2023-11-30 Thread via GitHub
vamossagar12 opened a new pull request, #14882: URL: https://github.com/apache/kafka/pull/14882 Adding IT for the case when a static member temporarily leaves the group and another member replaces it. -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] MINOR: Fix a few reconciliation bugs [kafka]

2023-11-30 Thread via GitHub
dajac closed pull request #14819: MINOR: Fix a few reconciliation bugs URL: https://github.com/apache/kafka/pull/14819 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] KAFKA-15662: Add support for clientInstanceIds in Kafka Stream [kafka]

2023-11-30 Thread via GitHub
lucasbru commented on code in PR #14864: URL: https://github.com/apache/kafka/pull/14864#discussion_r1410975879 ## streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java: ## @@ -1791,6 +1794,74 @@ protected int processStreamThread(final Consumer consumer) {

[PR] KAFKA-15365: Broker-side replica management changes [kafka]

2023-11-30 Thread via GitHub
OmniaGM opened a new pull request, #14881: URL: https://github.com/apache/kafka/pull/14881 - Extended `LogManager.getOrCreateLog` to accept the target directory's ID. At this level, we assume that the directory id is online to keep `getOrCreateLog` simple. - Fixed

Re: [PR] KAFKA-15365: Broker-side replica management changes [kafka]

2023-11-30 Thread via GitHub
OmniaGM closed pull request #14880: KAFKA-15365: Broker-side replica management changes URL: https://github.com/apache/kafka/pull/14880 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] KAFKA-15901: Client changes for registering telemetry and API calls (KIP-714) [kafka]

2023-11-30 Thread via GitHub
mjsax commented on code in PR #14843: URL: https://github.com/apache/kafka/pull/14843#discussion_r1410963954 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java: ## @@ -957,7 +972,11 @@ public void commitSync(Map offsets, Duration

Re: [PR] KAFKA-15901: Client changes for registering telemetry and API calls (KIP-714) [kafka]

2023-11-30 Thread via GitHub
mjsax commented on code in PR #14843: URL: https://github.com/apache/kafka/pull/14843#discussion_r1410962382 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java: ## @@ -957,7 +972,11 @@ public void commitSync(Map offsets, Duration

[jira] [Updated] (KAFKA-15858) Broker stays fenced until all assignments are correct

2023-11-30 Thread Omnia Ibrahim (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15858?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Omnia Ibrahim updated KAFKA-15858: -- Attachment: image.png > Broker stays fenced until all assignments are correct >

[jira] [Updated] (KAFKA-15858) Broker stays fenced until all assignments are correct

2023-11-30 Thread Omnia Ibrahim (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15858?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Omnia Ibrahim updated KAFKA-15858: -- Attachment: (was: image.png) > Broker stays fenced until all assignments are correct >

[PR] KAFKA-15365: Broker-side replica management changes [kafka]

2023-11-30 Thread via GitHub
OmniaGM opened a new pull request, #14880: URL: https://github.com/apache/kafka/pull/14880 - Extended `LogManager.getOrCreateLog` to accept the target directory's ID. At this level, we assume that the directory id is online to keep `getOrCreateLog` simple. - Fixed

Re: [PR] KAFKA-15574; [2/N]: Client state machine updates [kafka]

2023-11-30 Thread via GitHub
lianetm commented on code in PR #14857: URL: https://github.com/apache/kafka/pull/14857#discussion_r1410941917 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java: ## @@ -365,6 +366,16 @@ private void

Re: [PR] KAFKA-15574; [2/N]: Client state machine updates [kafka]

2023-11-30 Thread via GitHub
dajac commented on code in PR #14857: URL: https://github.com/apache/kafka/pull/14857#discussion_r1410931685 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java: ## @@ -365,6 +366,16 @@ private void

[PR] KAFKA-15281: Implement the groupMetadata Consumer API [kafka]

2023-11-30 Thread via GitHub
cadonna opened a new pull request, #14879: URL: https://github.com/apache/kafka/pull/14879 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of

  1   2   >