omkreddy commented on code in PR #14938:
URL: https://github.com/apache/kafka/pull/14938#discussion_r1418474509
##
docker/examples/jvm/cluster/docker-compose.yml:
##
@@ -0,0 +1,110 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license
mdedetrich commented on PR #12728:
URL: https://github.com/apache/kafka/pull/12728#issuecomment-1844822620
I have just pushed a merge commit which adds the
`testCreateConnectorWithStoppedInitialState()` test. The translation of the
test was quite straight forward, only thing to note is
dajac commented on PR #14925:
URL: https://github.com/apache/kafka/pull/14925#issuecomment-1844810244
Triggered a new build.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
dajac commented on PR #14774:
URL: https://github.com/apache/kafka/pull/14774#issuecomment-1844806301
@junrao @jolshan I work on implementing the transactional offset commits in
the new world. I will take care of adding the verification steps there when
this PR is done. We can replicate
tledkov commented on code in PR #14856:
URL: https://github.com/apache/kafka/pull/14856#discussion_r1418448844
##
tools/src/main/java/org/apache/kafka/tools/consumergroup/ConsumerGroupCommandOptions.java:
##
@@ -0,0 +1,263 @@
+/*
+ * Licensed to the Apache Software Foundation
omkreddy merged PR #14940:
URL: https://github.com/apache/kafka/pull/14940
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
omkreddy merged PR #14941:
URL: https://github.com/apache/kafka/pull/14941
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
tledkov commented on code in PR #14856:
URL: https://github.com/apache/kafka/pull/14856#discussion_r1418426538
##
tools/src/main/java/org/apache/kafka/tools/consumergroup/ConsumerGroupCommandOptions.java:
##
@@ -0,0 +1,263 @@
+/*
+ * Licensed to the Apache Software Foundation
cmccabe merged PR #14749:
URL: https://github.com/apache/kafka/pull/14749
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
cmccabe commented on PR #14899:
URL: https://github.com/apache/kafka/pull/14899#issuecomment-1844406974
Jenkins had an internal issue. Re-pushing to get a clean build.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
mjsax merged PR #14947:
URL: https://github.com/apache/kafka/pull/14947
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
github-actions[bot] commented on PR #13726:
URL: https://github.com/apache/kafka/pull/13726#issuecomment-1844200113
This PR is being marked as stale since it has not had any activity in 90
days. If you would like to keep this PR alive, please ask a committer for
review. If the PR has
github-actions[bot] commented on PR #13993:
URL: https://github.com/apache/kafka/pull/13993#issuecomment-1844199926
This PR is being marked as stale since it has not had any activity in 90
days. If you would like to keep this PR alive, please ask a committer for
review. If the PR has
mjsax opened a new pull request, #14951:
URL: https://github.com/apache/kafka/pull/14951
Stacked on other PRs. Still not completed. But early feedback is welcome.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
mjsax merged PR #14898:
URL: https://github.com/apache/kafka/pull/14898
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
mjsax commented on code in PR #14898:
URL: https://github.com/apache/kafka/pull/14898#discussion_r1418202440
##
docs/streams/upgrade-guide.html:
##
@@ -139,6 +139,10 @@ Streams API
kirktrue commented on code in PR #14937:
URL: https://github.com/apache/kafka/pull/14937#discussion_r1418183946
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThread.java:
##
@@ -274,79 +269,18 @@ private void closeInternal(final Duration
[
https://issues.apache.org/jira/browse/KAFKA-12670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17793974#comment-17793974
]
Luke Chen commented on KAFKA-12670:
---
[~cmccabe], do you have any idea when KRaft will support unclean
kirktrue commented on PR #14950:
URL: https://github.com/apache/kafka/pull/14950#issuecomment-1843973958
@lucasbru—please add the `ctr` tag. If you can also review the code, even
better
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
kirktrue opened a new pull request, #14950:
URL: https://github.com/apache/kafka/pull/14950
This is one in a series of changes to reduce/remove reliance on the
`ConsumerTestBuilder` for CTR-related tests.
--
This is an automated message from the Apache Git Service.
To respond to the
Justine Olshan created KAFKA-15984:
--
Summary: Client disconnections can cause hanging transactions on
__consumer_offsets
Key: KAFKA-15984
URL: https://issues.apache.org/jira/browse/KAFKA-15984
[
https://issues.apache.org/jira/browse/KAFKA-15556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17793972#comment-17793972
]
Phuc Hong Tran edited comment on KAFKA-15556 at 12/7/23 12:51 AM:
--
[
https://issues.apache.org/jira/browse/KAFKA-15556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17793972#comment-17793972
]
Phuc Hong Tran commented on KAFKA-15556:
There is a duplicated method "nodeUnavailable" which
[
https://issues.apache.org/jira/browse/KAFKA-15983?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chen He updated KAFKA-15983:
Summary: Kafka-acls should return authorization already done if repeating
work is issued (was:
[
https://issues.apache.org/jira/browse/KAFKA-15983?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chen He updated KAFKA-15983:
Labels: newbie (was: )
> Kafka-acls should return authorization already done if repeat work is issued
>
Chen He created KAFKA-15983:
---
Summary: Kafka-acls should return authorization already done if
repeat work is issued
Key: KAFKA-15983
URL: https://issues.apache.org/jira/browse/KAFKA-15983
Project: Kafka
bmscomp commented on PR #13662:
URL: https://github.com/apache/kafka/pull/13662#issuecomment-1843889093
@mimaison Done!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
philipnee commented on code in PR #14937:
URL: https://github.com/apache/kafka/pull/14937#discussion_r1418129061
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThread.java:
##
@@ -274,79 +269,18 @@ private void closeInternal(final Duration
philipnee commented on code in PR #14937:
URL: https://github.com/apache/kafka/pull/14937#discussion_r1418128177
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##
@@ -1024,15 +1037,14 @@ private void close(Duration timeout, boolean
mdedetrich commented on PR #12728:
URL: https://github.com/apache/kafka/pull/12728#issuecomment-1843872683
> @mdedetrich Thanks, the changes look good to go. But the build is failing
because there are new tests on trunk that still use EasyMock/PowerMock. Can you
rebase on the latest from
hachikuji commented on code in PR #14774:
URL: https://github.com/apache/kafka/pull/14774#discussion_r1418127368
##
core/src/main/scala/kafka/server/ReplicaManager.scala:
##
@@ -941,39 +851,209 @@ class ReplicaManager(val config: KafkaConfig,
}
}
- private def
philipnee commented on PR #14937:
URL: https://github.com/apache/kafka/pull/14937#issuecomment-1843871662
Hi @kirktrue - I rewrote the previous PR based on your feedback. I thought
driving the close via event is a better and clearer pattern, so thanks for the
suggestions. Would you have
agavra opened a new pull request, #14949:
URL: https://github.com/apache/kafka/pull/14949
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
philipnee commented on PR #14920:
URL: https://github.com/apache/kafka/pull/14920#issuecomment-1843868318
Thanks @lucasbru and @kirktrue - i'm closing this one and reopening another
one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
philipnee closed pull request #14920: KAFKA-15696: Refactor AsyncConsumer close
procedure
URL: https://github.com/apache/kafka/pull/14920
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
mjsax opened a new pull request, #14948:
URL: https://github.com/apache/kafka/pull/14948
Part of KIP-714.
Adds support to expose producer client instance id. This PR only adds
support for thread producer and state-updater disabled.
--
This is an automated message from the Apache
philipnee commented on code in PR #14937:
URL: https://github.com/apache/kafka/pull/14937#discussion_r1418122441
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##
@@ -1050,6 +1062,81 @@ private void close(Duration timeout, boolean
aliehsaeedii commented on PR #14626:
URL: https://github.com/apache/kafka/pull/14626#issuecomment-1843861522
> @aliehsaeedii @mjsax The last build has many failed tests:
https://ci-builds.apache.org/blue/organizations/jenkins/Kafka%2Fkafka-pr/detail/PR-14626/26/tests.
I also see them in
jolshan commented on code in PR #14774:
URL: https://github.com/apache/kafka/pull/14774#discussion_r1418097344
##
core/src/main/scala/kafka/coordinator/group/GroupMetadataManager.scala:
##
@@ -349,146 +468,68 @@ class GroupMetadataManager(brokerId: Int,
jolshan commented on code in PR #14774:
URL: https://github.com/apache/kafka/pull/14774#discussion_r1418096753
##
core/src/main/scala/kafka/coordinator/group/GroupMetadataManager.scala:
##
@@ -339,156 +340,183 @@ class GroupMetadataManager(brokerId: Int,
jolshan commented on PR #14774:
URL: https://github.com/apache/kafka/pull/14774#issuecomment-1843841126
@junrao Thanks for taking a look. I was just rewriting the code to make this
clearer. I will take a look at @artemlivshits and your questions about locking
now.
--
This is an
jolshan commented on code in PR #14774:
URL: https://github.com/apache/kafka/pull/14774#discussion_r1418093193
##
core/src/main/scala/kafka/server/KafkaApis.scala:
##
@@ -708,23 +708,40 @@ class KafkaApis(val requestChannel: RequestChannel,
}
}
-if
soarez commented on PR #14903:
URL: https://github.com/apache/kafka/pull/14903#issuecomment-1843813913
@junrao: Thanks for revewing this. It seems there are currently some issues
with faling tests. See
https://github.com/apache/kafka/pull/14838#issuecomment-1843693525
The test failures
mjsax commented on code in PR #14947:
URL: https://github.com/apache/kafka/pull/14947#discussion_r1418059234
##
streams/src/test/java/org/apache/kafka/streams/state/internals/RocksDBVersionedStoreSegmentValueFormatterTest.java:
##
@@ -230,13 +230,19 @@ public void
wcarlson5 commented on code in PR #14935:
URL: https://github.com/apache/kafka/pull/14935#discussion_r1418058902
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java:
##
@@ -1477,6 +1528,27 @@ public Object getStateLock() {
return
wcarlson5 commented on code in PR #14922:
URL: https://github.com/apache/kafka/pull/14922#discussion_r1418054625
##
streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java:
##
@@ -1802,7 +1805,7 @@ protected int processStreamThread(final
Consumer consumer) {
*
rondagostino commented on code in PR #14790:
URL: https://github.com/apache/kafka/pull/14790#discussion_r1418016489
##
core/src/main/scala/kafka/server/ReplicaAlterLogDirsThread.scala:
##
@@ -76,13 +83,69 @@ class ReplicaAlterLogDirsThread(name: String,
AndrewJSchofield commented on PR #14945:
URL: https://github.com/apache/kafka/pull/14945#issuecomment-1843752569
Investigating failure of new test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
rondagostino merged PR #14838:
URL: https://github.com/apache/kafka/pull/14838
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
Jeff Kim created KAFKA-15982:
Summary: Move GenericGroup state metrics to
`GroupCoordinatorMetricsShard`
Key: KAFKA-15982
URL: https://issues.apache.org/jira/browse/KAFKA-15982
Project: Kafka
junrao commented on PR #14774:
URL: https://github.com/apache/kafka/pull/14774#issuecomment-1843729483
@jolshan : Thanks for the PR. Should we fix the `append` call in
`CoordinatorRuntime` (https://github.com/apache/kafka/pull/14705) too? There, a
partition level lock in
cmccabe commented on PR #14838:
URL: https://github.com/apache/kafka/pull/14838#issuecomment-1843728301
@rondagostino : I think we can merge this now because I don't think it's
adding more failures. I do think we need to do another sweep looking for people
calling `Exit.exit`, but that
Jeff Kim created KAFKA-15981:
Summary: only record GenericGroup state metrics once per group
during load
Key: KAFKA-15981
URL: https://issues.apache.org/jira/browse/KAFKA-15981
Project: Kafka
gharris1727 commented on code in PR #14562:
URL: https://github.com/apache/kafka/pull/14562#discussion_r1418003736
##
connect/runtime/src/test/java/org/apache/kafka/connect/integration/ConnectWorkerIntegrationTest.java:
##
@@ -771,6 +778,104 @@ private Map
rondagostino commented on PR #14838:
URL: https://github.com/apache/kafka/pull/14838#issuecomment-1843693525
Looking at the [trunk build
jobs](https://ci-builds.apache.org/blue/organizations/jenkins/Kafka%2Fkafka/activity?branch=trunk):
rondagostino commented on PR #14838:
URL: https://github.com/apache/kafka/pull/14838#issuecomment-1843668221
I think the issue is not with our PR. Here's another [PR that is basically
a 2-line change in a single test](https://github.com/apache/kafka/pull/14944)
and that has [144 test
rondagostino commented on PR #14838:
URL: https://github.com/apache/kafka/pull/14838#issuecomment-1843665517
[Latest builds for JDKs 8 and 21
failed](https://ci-builds.apache.org/blue/organizations/jenkins/Kafka%2Fkafka-pr/detail/PR-14838/16/pipeline/).
Restarted the build:
aliehsaeedii opened a new pull request, #14947:
URL: https://github.com/apache/kafka/pull/14947
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of
junrao commented on code in PR #14903:
URL: https://github.com/apache/kafka/pull/14903#discussion_r1417911671
##
core/src/main/scala/kafka/server/BrokerLifecycleManager.scala:
##
@@ -364,10 +377,30 @@ class BrokerLifecycleManager(
}
_channelManager.sendRequest(new
philipnee commented on code in PR #14937:
URL: https://github.com/apache/kafka/pull/14937#discussion_r1417650715
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumerTest.java:
##
@@ -778,18 +783,23 @@ public void testGroupIdNull() {
philipnee commented on PR #14873:
URL: https://github.com/apache/kafka/pull/14873#issuecomment-1843583099
Hi @lianetm @cadonna @lucasbru - Thanks for taking the time reviewing my PR.
I addressed your comments and left one for @cadonna.
--
This is an automated message from the Apache Git
philipnee commented on code in PR #14873:
URL: https://github.com/apache/kafka/pull/14873#discussion_r1417898446
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManagerTest.java:
##
@@ -399,14 +400,45 @@ public void testHeartbeatState() {
lianetm commented on code in PR #14945:
URL: https://github.com/apache/kafka/pull/14945#discussion_r1417895767
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java:
##
@@ -224,6 +224,13 @@ boolean canAutoCommit() {
return
lianetm commented on code in PR #14945:
URL: https://github.com/apache/kafka/pull/14945#discussion_r1417895767
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java:
##
@@ -224,6 +224,13 @@ boolean canAutoCommit() {
return
lianetm commented on code in PR #14945:
URL: https://github.com/apache/kafka/pull/14945#discussion_r1417892970
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java:
##
@@ -224,6 +224,13 @@ boolean canAutoCommit() {
return
dajac commented on code in PR #14945:
URL: https://github.com/apache/kafka/pull/14945#discussion_r1417891269
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java:
##
@@ -224,6 +224,13 @@ boolean canAutoCommit() {
return
dajac commented on PR #14845:
URL: https://github.com/apache/kafka/pull/14845#issuecomment-1843565757
It looks like the new failing tests are coming from
https://github.com/apache/kafka/pull/14626.
--
This is an automated message from the Apache Git Service.
To respond to the message,
nizhikov commented on code in PR #14471:
URL: https://github.com/apache/kafka/pull/14471#discussion_r1417877630
##
tools/src/main/java/org/apache/kafka/tools/consumergroup/CsvUtils.java:
##
@@ -0,0 +1,154 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
apoorvmittal10 commented on code in PR #14946:
URL: https://github.com/apache/kafka/pull/14946#discussion_r1417877859
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java:
##
@@ -321,6 +332,9 @@ public void
dajac commented on PR #14626:
URL: https://github.com/apache/kafka/pull/14626#issuecomment-1843551173
@aliehsaeedii @mjsax The last build has many failed tests:
https://ci-builds.apache.org/blue/organizations/jenkins/Kafka%2Fkafka-pr/detail/PR-14626/26/tests.
I also see them in other
[
https://issues.apache.org/jira/browse/KAFKA-15972?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Apoorv Mittal resolved KAFKA-15972.
---
Resolution: Done
> Add support to exclude labels in client telemetry
>
[
https://issues.apache.org/jira/browse/KAFKA-15877?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Apoorv Mittal resolved KAFKA-15877.
---
Resolution: Done
> Support change of temporality in Java client
>
[
https://issues.apache.org/jira/browse/KAFKA-15684?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jun Rao resolved KAFKA-15684.
-
Fix Version/s: 3.7.0
Resolution: Fixed
merged the PR to trunk.
> Add support to describe all
[
https://issues.apache.org/jira/browse/KAFKA-15877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17793896#comment-17793896
]
Apoorv Mittal commented on KAFKA-15877:
---
Changes were committed as part of PR:
junrao merged PR #14933:
URL: https://github.com/apache/kafka/pull/14933
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
Colin McCabe created KAFKA-15979:
Summary: Add KIP-1001 CurrentControllerId metric
Key: KAFKA-15979
URL: https://issues.apache.org/jira/browse/KAFKA-15979
Project: Kafka
Issue Type:
Colin McCabe created KAFKA-15980:
Summary: Add KIP-1001 CurrentControllerId metric
Key: KAFKA-15980
URL: https://issues.apache.org/jira/browse/KAFKA-15980
Project: Kafka
Issue Type:
apoorvmittal10 commented on PR #14933:
URL: https://github.com/apache/kafka/pull/14933#issuecomment-1843520738
> @apoorvmittal10 : Thanks for the updated PR. Just a minor comment.
@junrao Thanks for again reviewing the PR. I have added thoughts for the
comment and verified same
apoorvmittal10 commented on code in PR #14946:
URL: https://github.com/apache/kafka/pull/14946#discussion_r1417849266
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java:
##
@@ -321,6 +332,9 @@ public void
[
https://issues.apache.org/jira/browse/KAFKA-15816?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Greg Harris updated KAFKA-15816:
Description:
There are a few tests which leak network sockets due to small typos in the
tests
gharris1727 merged PR #14761:
URL: https://github.com/apache/kafka/pull/14761
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
gharris1727 commented on PR #14761:
URL: https://github.com/apache/kafka/pull/14761#issuecomment-1843486780
Test failures appear unrelated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
apoorvmittal10 commented on code in PR #14933:
URL: https://github.com/apache/kafka/pull/14933#discussion_r1417826343
##
core/src/test/scala/unit/kafka/admin/ConfigCommandTest.scala:
##
@@ -1690,13 +1690,33 @@ class ConfigCommandTest extends Logging {
}
@Test
- def
ableegoldman merged PR #14886:
URL: https://github.com/apache/kafka/pull/14886
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
apoorvmittal10 commented on code in PR #14946:
URL: https://github.com/apache/kafka/pull/14946#discussion_r1417815612
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java:
##
@@ -321,6 +332,9 @@ public void
apoorvmittal10 commented on code in PR #14933:
URL: https://github.com/apache/kafka/pull/14933#discussion_r1417807074
##
core/src/test/scala/unit/kafka/admin/ConfigCommandTest.scala:
##
@@ -1690,13 +1690,33 @@ class ConfigCommandTest extends Logging {
}
@Test
- def
philipnee commented on code in PR #14873:
URL: https://github.com/apache/kafka/pull/14873#discussion_r1417795477
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java:
##
@@ -201,13 +224,35 @@ public long maximumTimeToWait(long
[
https://issues.apache.org/jira/browse/KAFKA-15871?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jun Rao resolved KAFKA-15871.
-
Resolution: Fixed
merged the PR to trunk
> Implement kafka-client-metrics.sh tool
>
C0urante commented on PR #12728:
URL: https://github.com/apache/kafka/pull/12728#issuecomment-1843418398
@mdedetrich Thanks, the changes look good to go. But the build is failing
because there are new tests on trunk that still use EasyMock/PowerMock. Can you
rebase on the latest from
junrao merged PR #14926:
URL: https://github.com/apache/kafka/pull/14926
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
junrao commented on code in PR #14933:
URL: https://github.com/apache/kafka/pull/14933#discussion_r1417759706
##
core/src/test/scala/unit/kafka/admin/ConfigCommandTest.scala:
##
@@ -1690,13 +1690,33 @@ class ConfigCommandTest extends Logging {
}
@Test
- def
AndrewJSchofield commented on code in PR #14946:
URL: https://github.com/apache/kafka/pull/14946#discussion_r1417760787
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java:
##
@@ -321,6 +332,9 @@ public void
C0urante commented on code in PR #13801:
URL: https://github.com/apache/kafka/pull/13801#discussion_r1417751374
##
connect/runtime/src/main/java/org/apache/kafka/connect/storage/ConnectorOffsetBackingStore.java:
##
@@ -279,15 +290,54 @@ public Future set(Map
values, Callback
mjsax commented on code in PR #14922:
URL: https://github.com/apache/kafka/pull/14922#discussion_r1417761864
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java:
##
@@ -1477,6 +1533,29 @@ public Object getStateLock() {
return
C0urante commented on code in PR #13801:
URL: https://github.com/apache/kafka/pull/13801#discussion_r1417677509
##
connect/runtime/src/main/java/org/apache/kafka/connect/storage/ConnectorOffsetBackingStore.java:
##
@@ -279,15 +290,54 @@ public Future set(Map
values, Callback
[
https://issues.apache.org/jira/browse/KAFKA-15932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrew Schofield resolved KAFKA-15932.
--
Resolution: Fixed
> Flaky test -
cadonna merged PR #14912:
URL: https://github.com/apache/kafka/pull/14912
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
jolshan commented on PR #14702:
URL: https://github.com/apache/kafka/pull/14702#issuecomment-1843376087
I've restarted the build every day since the approval and have yet to get a
clean build
--
This is an automated message from the Apache Git Service.
To respond to the message,
apoorvmittal10 commented on PR #14946:
URL: https://github.com/apache/kafka/pull/14946#issuecomment-1843373904
@kirktrue @philipnee @AndrewJSchofield Can you please review the change and
let me know if change is at right place for new consumer?
cc: @mjsax @wcarlson5
--
This is an
apoorvmittal10 opened a new pull request, #14946:
URL: https://github.com/apache/kafka/pull/14946
- As the KIP-848 introduced new Kafka Consumer hence KIP-714 required
further changes to capture `group_member_id`. - The change also includes a fix
to update labels, as earlier calling
1 - 100 of 211 matches
Mail list logo
